CAS Push-Pull-Framework

FindBugs Bug Detector Report

Summary

Files

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is

Effort is min

Summary

ClassesBugsErrorsMissing Classes
867900

Files

ClassBugs
org.apache.oodt.cas.pushpull.config.Config5
org.apache.oodt.cas.pushpull.config.DaemonInfo1
org.apache.oodt.cas.pushpull.config.ParserInfo1
org.apache.oodt.cas.pushpull.config.PropFilesInfo$RegExpAndParser1
org.apache.oodt.cas.pushpull.config.ProtocolInfo1
org.apache.oodt.cas.pushpull.config.RemoteSpecs5
org.apache.oodt.cas.pushpull.config.SiteInfo1
org.apache.oodt.cas.pushpull.daemon.Daemon8
org.apache.oodt.cas.pushpull.daemon.Daemon$11
org.apache.oodt.cas.pushpull.daemon.DaemonController7
org.apache.oodt.cas.pushpull.daemon.DaemonLauncher2
org.apache.oodt.cas.pushpull.daemon.DaemonManager3
org.apache.oodt.cas.pushpull.expressions.Method2
org.apache.oodt.cas.pushpull.expressions.Variable1
org.apache.oodt.cas.pushpull.filerestrictions.VirtualFile1
org.apache.oodt.cas.pushpull.filerestrictions.parsers.ClassNoaaEmailParser1
org.apache.oodt.cas.pushpull.filerestrictions.parsers.DirStructXmlParser1
org.apache.oodt.cas.pushpull.filerestrictions.renamingconventions.RenamingConvention1
org.apache.oodt.cas.pushpull.objectfactory.PushPullObjectFactory1
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler11
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler$PagingInfo1
org.apache.oodt.cas.pushpull.protocol.ProtocolPath1
org.apache.oodt.cas.pushpull.protocol.RemoteSite2
org.apache.oodt.cas.pushpull.protocol.RemoteSiteFile1
org.apache.oodt.cas.pushpull.retrievalsystem.DownloadThreadEvaluator3
org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem8
org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem$32
org.apache.oodt.cas.pushpull.retrievalsystem.RemoteFile1
org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup5

org.apache.oodt.cas.pushpull.config.Config

BugCategoryDetailsLinePriority
org.apache.oodt.cas.pushpull.config.Config defines clone() but doesn't implement CloneableBAD_PRACTICECN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE45High
org.apache.oodt.cas.pushpull.config.Config.getListOfMetadataToOutput() may expose internal representation by returning Config.listOfMetadataToOutputMALICIOUS_CODEEI_EXPOSE_REP361Medium
org.apache.oodt.cas.pushpull.config.Config.loadConfigFile(File) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM107Medium
org.apache.oodt.cas.pushpull.config.Config.loadExternalConfigFiles() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM194Medium

org.apache.oodt.cas.pushpull.config.DaemonInfo

BugCategoryDetailsLinePriority
org.apache.oodt.cas.pushpull.config.DaemonInfo.getFirstRunDateTime() may expose internal representation by returning DaemonInfo.firstRunDateTimeMALICIOUS_CODEEI_EXPOSE_REP115Medium

org.apache.oodt.cas.pushpull.config.ParserInfo

BugCategoryDetailsLinePriority
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.config.ParserInfo.getRetrievalMethod(Parser)CORRECTNESSNP_ALWAYS_NULL98High

org.apache.oodt.cas.pushpull.config.PropFilesInfo$RegExpAndParser

BugCategoryDetailsLinePriority
Should org.apache.oodt.cas.pushpull.config.PropFilesInfo$RegExpAndParser be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC143-157Medium

org.apache.oodt.cas.pushpull.config.ProtocolInfo

BugCategoryDetailsLinePriority
org.apache.oodt.cas.pushpull.config.ProtocolInfo defines clone() but doesn't implement CloneableBAD_PRACTICECN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE47High

org.apache.oodt.cas.pushpull.config.RemoteSpecs

BugCategoryDetailsLinePriority
Dead store to pfiList in org.apache.oodt.cas.pushpull.config.RemoteSpecs.loadRemoteSpecs(File)STYLEDLS_DEAD_LOCAL_STORE122Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.config.RemoteSpecs.loadRemoteSpecs(File)STYLEREC_CATCH_EXCEPTION279Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.config.RemoteSpecs.parseAndStoreLoginInfo(File)STYLEREC_CATCH_EXCEPTION343Medium
Unread field: org.apache.oodt.cas.pushpull.config.RemoteSpecs.parsersPERFORMANCEURF_UNREAD_FIELD59Medium
Unread field: org.apache.oodt.cas.pushpull.config.RemoteSpecs.renamingConvsPERFORMANCEURF_UNREAD_FIELD60Medium

org.apache.oodt.cas.pushpull.config.SiteInfo

BugCategoryDetailsLinePriority
org.apache.oodt.cas.pushpull.config.SiteInfo.getPossibleRemoteSites(String, URL, String, String) invokes java.net.URL.equals(Object), which blocks to do domain name resolutionPERFORMANCEDMI_BLOCKING_METHODS_ON_URL70High

org.apache.oodt.cas.pushpull.daemon.Daemon

BugCategoryDetailsLinePriority
Dead store to name in org.apache.oodt.cas.pushpull.daemon.Daemon.main(String[])STYLEDLS_DEAD_LOCAL_STORE560High
Naked notify in org.apache.oodt.cas.pushpull.daemon.Daemon.resume()MT_CORRECTNESSNN_NAKED_NOTIFY337Medium
Class org.apache.oodt.cas.pushpull.daemon.Daemon defines non-transient non-serializable instance field configBAD_PRACTICESE_BAD_FIELDNot availableMedium
Class org.apache.oodt.cas.pushpull.daemon.Daemon defines non-transient non-serializable instance field daemonInfoBAD_PRACTICESE_BAD_FIELDNot availableMedium
Class org.apache.oodt.cas.pushpull.daemon.Daemon defines non-transient non-serializable instance field daemonListenerBAD_PRACTICESE_BAD_FIELDNot availableMedium
Class org.apache.oodt.cas.pushpull.daemon.Daemon defines non-transient non-serializable instance field mbsBAD_PRACTICESE_BAD_FIELDNot availableMedium
Class org.apache.oodt.cas.pushpull.daemon.Daemon defines non-transient non-serializable instance field rsBAD_PRACTICESE_BAD_FIELDNot availableMedium

org.apache.oodt.cas.pushpull.daemon.Daemon$1

BugCategoryDetailsLinePriority
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.Daemon$1.run()CORRECTNESSNP_ALWAYS_NULL210High

org.apache.oodt.cas.pushpull.daemon.DaemonController

BugCategoryDetailsLinePriority
Null pointer dereference of System.out in new org.apache.oodt.cas.pushpull.daemon.DaemonController(String)CORRECTNESSNP_ALWAYS_NULL51High
Null pointer dereference of System.err in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[])CORRECTNESSNP_ALWAYS_NULL180High
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[])CORRECTNESSNP_ALWAYS_NULL188High
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[])CORRECTNESSNP_ALWAYS_NULL191High
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[])CORRECTNESSNP_ALWAYS_NULL195High
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[])CORRECTNESSNP_ALWAYS_NULL198High
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[])CORRECTNESSNP_ALWAYS_NULL201High

org.apache.oodt.cas.pushpull.daemon.DaemonLauncher

BugCategoryDetailsLinePriority
Unconditional wait in org.apache.oodt.cas.pushpull.daemon.DaemonLauncher.main(String[])MT_CORRECTNESSUW_UNCOND_WAIT186Medium
Wait not in loop in org.apache.oodt.cas.pushpull.daemon.DaemonLauncher.main(String[])MT_CORRECTNESSWA_NOT_IN_LOOP186Medium

org.apache.oodt.cas.pushpull.daemon.DaemonManager

BugCategoryDetailsLinePriority
Method org.apache.oodt.cas.pushpull.daemon.DaemonManager.wasRegisteredWith(Daemon) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR63Medium
Method org.apache.oodt.cas.pushpull.daemon.DaemonManager.wasUnregisteredWith(Daemon) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR67Medium
Inconsistent synchronization of org.apache.oodt.cas.pushpull.daemon.DaemonManager.runningDaemon; locked 87% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC77Medium

org.apache.oodt.cas.pushpull.expressions.Method

BugCategoryDetailsLinePriority
Method org.apache.oodt.cas.pushpull.expressions.Method.addArgSignature(String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR62Medium
Method org.apache.oodt.cas.pushpull.expressions.Method.execute() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR220Medium

org.apache.oodt.cas.pushpull.expressions.Variable

BugCategoryDetailsLinePriority
Unread field: org.apache.oodt.cas.pushpull.expressions.Variable.typePERFORMANCEURF_UNREAD_FIELD79Medium

org.apache.oodt.cas.pushpull.filerestrictions.VirtualFile

BugCategoryDetailsLinePriority
org.apache.oodt.cas.pushpull.filerestrictions.VirtualFile defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE263-269High

org.apache.oodt.cas.pushpull.filerestrictions.parsers.ClassNoaaEmailParser

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.filerestrictions.parsers.ClassNoaaEmailParser.parse(FileInputStream)STYLEREC_CATCH_EXCEPTION98Medium

org.apache.oodt.cas.pushpull.filerestrictions.parsers.DirStructXmlParser

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.filerestrictions.parsers.DirStructXmlParser.replaceVariablesAndMethods(String)STYLEREC_CATCH_EXCEPTION201Medium

org.apache.oodt.cas.pushpull.filerestrictions.renamingconventions.RenamingConvention

BugCategoryDetailsLinePriority
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.filerestrictions.renamingconventions.RenamingConvention.grepRemoveReplace(String, RemoteSiteFile)CORRECTNESSNP_ALWAYS_NULL119High

org.apache.oodt.cas.pushpull.objectfactory.PushPullObjectFactory

BugCategoryDetailsLinePriority
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.objectfactory.PushPullObjectFactory.createIngester(String, String)CORRECTNESSNP_ALWAYS_NULL61High

org.apache.oodt.cas.pushpull.protocol.ProtocolHandler

BugCategoryDetailsLinePriority
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.reuseProtocols is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSNot availableHigh
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.urlAndProtocolFactory is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSNot availableHigh
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.getAppropriateProtocolBySite(RemoteSite, boolean) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS136High
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.getAppropriateProtocolBySite(RemoteSite, boolean) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS157High
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.getAppropriateProtocolBySite(RemoteSite, boolean) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS136High
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.connect(Protocol, RemoteSite, boolean)CORRECTNESSNP_ALWAYS_NULL304High
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.delete(Protocol, RemoteSiteFile)CORRECTNESSNP_ALWAYS_NULL406High
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.nextPage(RemoteSite, Protocol, ProtocolFileFilter)CORRECTNESSNP_ALWAYS_NULL196High
Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.getAppropriateProtocolBySite(RemoteSite, boolean)STYLEREC_CATCH_EXCEPTION162Medium
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.download(Protocol, RemoteSiteFile, File, boolean) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE277Medium
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.download(Protocol, RemoteSiteFile, File, boolean) ignores exceptional return value of java.io.File.renameTo(File)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE251Medium

org.apache.oodt.cas.pushpull.protocol.ProtocolHandler$PagingInfo

BugCategoryDetailsLinePriority
Should org.apache.oodt.cas.pushpull.protocol.ProtocolHandler$PagingInfo be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC560-583Medium

org.apache.oodt.cas.pushpull.protocol.ProtocolPath

BugCategoryDetailsLinePriority
org.apache.oodt.cas.pushpull.protocol.ProtocolPath defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE112-116High

org.apache.oodt.cas.pushpull.protocol.RemoteSite

BugCategoryDetailsLinePriority
org.apache.oodt.cas.pushpull.protocol.RemoteSite.equals(Object) invokes java.net.URL.equals(Object), which blocks to do domain name resolutionPERFORMANCEDMI_BLOCKING_METHODS_ON_URL93High
org.apache.oodt.cas.pushpull.protocol.RemoteSite defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE91-97High

org.apache.oodt.cas.pushpull.protocol.RemoteSiteFile

BugCategoryDetailsLinePriority
org.apache.oodt.cas.pushpull.protocol.RemoteSiteFile doesn't override org.apache.oodt.cas.protocol.ProtocolFile.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS31-84Medium

org.apache.oodt.cas.pushpull.retrievalsystem.DownloadThreadEvaluator

BugCategoryDetailsLinePriority
integral division result cast to double or float in org.apache.oodt.cas.pushpull.retrievalsystem.DownloadThreadEvaluator.fileDownloadComplete(File)STYLEICAST_IDIV_CAST_TO_DOUBLE107Medium
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.retrievalsystem.DownloadThreadEvaluator.fileDownloadComplete(File)CORRECTNESSNP_ALWAYS_NULL105High
Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.retrievalsystem.DownloadThreadEvaluator.getRecommendedThreadCount()CORRECTNESSNP_ALWAYS_NULL145High

org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem

BugCategoryDetailsLinePriority
Call to equals() comparing different types in org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.getSaveToLoc(RemoteFile)CORRECTNESSEC_UNRELATED_TYPES564High
Inconsistent synchronization of org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.avaliableSessions; locked 62% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC942Medium
Inconsistent synchronization of org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.currentlyDownloading; locked 80% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC236Medium
Inconsistent synchronization of org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.numberOfSessions; locked 83% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC947Medium
Naked notify in org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.wakeUpMainThread()MT_CORRECTNESSNN_NAKED_NOTIFY596Medium
org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.getSaveToLoc(RemoteFile) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE566Medium
org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.initializeStagingArea(File) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE540Medium
Wait not in loop in org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.waitMainThread()MT_CORRECTNESSWA_NOT_IN_LOOP589Medium

org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem$3

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem$3.run()STYLEREC_CATCH_EXCEPTION779Medium
org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem$3.run() ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE786Medium

org.apache.oodt.cas.pushpull.retrievalsystem.RemoteFile

BugCategoryDetailsLinePriority

org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.retrieveFiles(PropFilesInfo, DataFilesInfo)STYLEREC_CATCH_EXCEPTION147Medium
org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.movePropsFileToFinalDestination(PropFilesInfo, File, String) ignores exceptional return value of java.io.File.createNewFile()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE264Medium
org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.movePropsFileToFinalDestination(PropFilesInfo, File, String) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE250Medium
org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.movePropsFileToFinalDestination(PropFilesInfo, File, String) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE255Medium
org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.movePropsFileToFinalDestination(PropFilesInfo, File, String) ignores exceptional return value of java.io.File.renameTo(File)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE257Medium