The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is
Effort is min
Files
org.apache.oodt.cas.pushpull.config.Config
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.pushpull.config.Config defines clone() but doesn't implement Cloneable | BAD_PRACTICE | CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE | 45 | High |
| org.apache.oodt.cas.pushpull.config.Config.getListOfMetadataToOutput() may expose internal representation by returning Config.listOfMetadataToOutput | MALICIOUS_CODE | EI_EXPOSE_REP | 361 | Medium |
| org.apache.oodt.cas.pushpull.config.Config.loadConfigFile(File) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 107 | Medium |
| org.apache.oodt.cas.pushpull.config.Config.loadExternalConfigFiles() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 194 | Medium |
org.apache.oodt.cas.pushpull.config.DaemonInfo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.pushpull.config.DaemonInfo.getFirstRunDateTime() may expose internal representation by returning DaemonInfo.firstRunDateTime | MALICIOUS_CODE | EI_EXPOSE_REP | 115 | Medium |
org.apache.oodt.cas.pushpull.config.ParserInfo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.config.ParserInfo.getRetrievalMethod(Parser) | CORRECTNESS | NP_ALWAYS_NULL | 98 | High |
org.apache.oodt.cas.pushpull.config.PropFilesInfo$RegExpAndParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.oodt.cas.pushpull.config.PropFilesInfo$RegExpAndParser be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 143-157 | Medium |
org.apache.oodt.cas.pushpull.config.ProtocolInfo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.pushpull.config.ProtocolInfo defines clone() but doesn't implement Cloneable | BAD_PRACTICE | CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE | 47 | High |
org.apache.oodt.cas.pushpull.config.RemoteSpecs
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to pfiList in org.apache.oodt.cas.pushpull.config.RemoteSpecs.loadRemoteSpecs(File) | STYLE | DLS_DEAD_LOCAL_STORE | 122 | Medium |
| Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.config.RemoteSpecs.loadRemoteSpecs(File) | STYLE | REC_CATCH_EXCEPTION | 279 | Medium |
| Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.config.RemoteSpecs.parseAndStoreLoginInfo(File) | STYLE | REC_CATCH_EXCEPTION | 343 | Medium |
| Unread field: org.apache.oodt.cas.pushpull.config.RemoteSpecs.parsers | PERFORMANCE | URF_UNREAD_FIELD | 59 | Medium |
| Unread field: org.apache.oodt.cas.pushpull.config.RemoteSpecs.renamingConvs | PERFORMANCE | URF_UNREAD_FIELD | 60 | Medium |
org.apache.oodt.cas.pushpull.config.SiteInfo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.pushpull.config.SiteInfo.getPossibleRemoteSites(String, URL, String, String) invokes java.net.URL.equals(Object), which blocks to do domain name resolution | PERFORMANCE | DMI_BLOCKING_METHODS_ON_URL | 70 | High |
org.apache.oodt.cas.pushpull.daemon.Daemon
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to name in org.apache.oodt.cas.pushpull.daemon.Daemon.main(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 560 | High |
| Naked notify in org.apache.oodt.cas.pushpull.daemon.Daemon.resume() | MT_CORRECTNESS | NN_NAKED_NOTIFY | 337 | Medium |
| Class org.apache.oodt.cas.pushpull.daemon.Daemon defines non-transient non-serializable instance field config | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class org.apache.oodt.cas.pushpull.daemon.Daemon defines non-transient non-serializable instance field daemonInfo | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class org.apache.oodt.cas.pushpull.daemon.Daemon defines non-transient non-serializable instance field daemonListener | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class org.apache.oodt.cas.pushpull.daemon.Daemon defines non-transient non-serializable instance field mbs | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class org.apache.oodt.cas.pushpull.daemon.Daemon defines non-transient non-serializable instance field rs | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
org.apache.oodt.cas.pushpull.daemon.Daemon$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.Daemon$1.run() | CORRECTNESS | NP_ALWAYS_NULL | 210 | High |
org.apache.oodt.cas.pushpull.daemon.DaemonController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in new org.apache.oodt.cas.pushpull.daemon.DaemonController(String) | CORRECTNESS | NP_ALWAYS_NULL | 51 | High |
| Null pointer dereference of System.err in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 180 | High |
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 188 | High |
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 191 | High |
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 195 | High |
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 198 | High |
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.daemon.DaemonController.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 201 | High |
org.apache.oodt.cas.pushpull.daemon.DaemonLauncher
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unconditional wait in org.apache.oodt.cas.pushpull.daemon.DaemonLauncher.main(String[]) | MT_CORRECTNESS | UW_UNCOND_WAIT | 186 | Medium |
| Wait not in loop in org.apache.oodt.cas.pushpull.daemon.DaemonLauncher.main(String[]) | MT_CORRECTNESS | WA_NOT_IN_LOOP | 186 | Medium |
org.apache.oodt.cas.pushpull.daemon.DaemonManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.oodt.cas.pushpull.daemon.DaemonManager.wasRegisteredWith(Daemon) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 63 | Medium |
| Method org.apache.oodt.cas.pushpull.daemon.DaemonManager.wasUnregisteredWith(Daemon) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 67 | Medium |
| Inconsistent synchronization of org.apache.oodt.cas.pushpull.daemon.DaemonManager.runningDaemon; locked 87% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 77 | Medium |
org.apache.oodt.cas.pushpull.expressions.Method
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.oodt.cas.pushpull.expressions.Method.addArgSignature(String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 62 | Medium |
| Method org.apache.oodt.cas.pushpull.expressions.Method.execute() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 220 | Medium |
org.apache.oodt.cas.pushpull.expressions.Variable
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.oodt.cas.pushpull.expressions.Variable.type | PERFORMANCE | URF_UNREAD_FIELD | 79 | Medium |
org.apache.oodt.cas.pushpull.filerestrictions.VirtualFile
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.pushpull.filerestrictions.VirtualFile defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 263-269 | High |
org.apache.oodt.cas.pushpull.filerestrictions.parsers.ClassNoaaEmailParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.filerestrictions.parsers.ClassNoaaEmailParser.parse(FileInputStream) | STYLE | REC_CATCH_EXCEPTION | 98 | Medium |
org.apache.oodt.cas.pushpull.filerestrictions.parsers.DirStructXmlParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.filerestrictions.parsers.DirStructXmlParser.replaceVariablesAndMethods(String) | STYLE | REC_CATCH_EXCEPTION | 201 | Medium |
org.apache.oodt.cas.pushpull.filerestrictions.renamingconventions.RenamingConvention
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.filerestrictions.renamingconventions.RenamingConvention.grepRemoveReplace(String, RemoteSiteFile) | CORRECTNESS | NP_ALWAYS_NULL | 119 | High |
org.apache.oodt.cas.pushpull.objectfactory.PushPullObjectFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.objectfactory.PushPullObjectFactory.createIngester(String, String) | CORRECTNESS | NP_ALWAYS_NULL | 61 | High |
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.reuseProtocols is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | Not available | High |
| org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.urlAndProtocolFactory is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | Not available | High |
| org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.getAppropriateProtocolBySite(RemoteSite, boolean) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 136 | High |
| org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.getAppropriateProtocolBySite(RemoteSite, boolean) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 157 | High |
| org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.getAppropriateProtocolBySite(RemoteSite, boolean) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 136 | High |
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.connect(Protocol, RemoteSite, boolean) | CORRECTNESS | NP_ALWAYS_NULL | 304 | High |
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.delete(Protocol, RemoteSiteFile) | CORRECTNESS | NP_ALWAYS_NULL | 406 | High |
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.nextPage(RemoteSite, Protocol, ProtocolFileFilter) | CORRECTNESS | NP_ALWAYS_NULL | 196 | High |
| Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.getAppropriateProtocolBySite(RemoteSite, boolean) | STYLE | REC_CATCH_EXCEPTION | 162 | Medium |
| org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.download(Protocol, RemoteSiteFile, File, boolean) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 277 | Medium |
| org.apache.oodt.cas.pushpull.protocol.ProtocolHandler.download(Protocol, RemoteSiteFile, File, boolean) ignores exceptional return value of java.io.File.renameTo(File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 251 | Medium |
org.apache.oodt.cas.pushpull.protocol.ProtocolHandler$PagingInfo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.oodt.cas.pushpull.protocol.ProtocolHandler$PagingInfo be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 560-583 | Medium |
org.apache.oodt.cas.pushpull.protocol.ProtocolPath
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.pushpull.protocol.ProtocolPath defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 112-116 | High |
org.apache.oodt.cas.pushpull.protocol.RemoteSite
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.pushpull.protocol.RemoteSite.equals(Object) invokes java.net.URL.equals(Object), which blocks to do domain name resolution | PERFORMANCE | DMI_BLOCKING_METHODS_ON_URL | 93 | High |
| org.apache.oodt.cas.pushpull.protocol.RemoteSite defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 91-97 | High |
org.apache.oodt.cas.pushpull.protocol.RemoteSiteFile
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.pushpull.protocol.RemoteSiteFile doesn't override org.apache.oodt.cas.protocol.ProtocolFile.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 31-84 | Medium |
org.apache.oodt.cas.pushpull.retrievalsystem.DownloadThreadEvaluator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| integral division result cast to double or float in org.apache.oodt.cas.pushpull.retrievalsystem.DownloadThreadEvaluator.fileDownloadComplete(File) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 107 | Medium |
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.retrievalsystem.DownloadThreadEvaluator.fileDownloadComplete(File) | CORRECTNESS | NP_ALWAYS_NULL | 105 | High |
| Null pointer dereference of System.out in org.apache.oodt.cas.pushpull.retrievalsystem.DownloadThreadEvaluator.getRecommendedThreadCount() | CORRECTNESS | NP_ALWAYS_NULL | 145 | High |
org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals() comparing different types in org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.getSaveToLoc(RemoteFile) | CORRECTNESS | EC_UNRELATED_TYPES | 564 | High |
| Inconsistent synchronization of org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.avaliableSessions; locked 62% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 942 | Medium |
| Inconsistent synchronization of org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.currentlyDownloading; locked 80% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 236 | Medium |
| Inconsistent synchronization of org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.numberOfSessions; locked 83% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 947 | Medium |
| Naked notify in org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.wakeUpMainThread() | MT_CORRECTNESS | NN_NAKED_NOTIFY | 596 | Medium |
| org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.getSaveToLoc(RemoteFile) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 566 | Medium |
| org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.initializeStagingArea(File) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 540 | Medium |
| Wait not in loop in org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.waitMainThread() | MT_CORRECTNESS | WA_NOT_IN_LOOP | 589 | Medium |
org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem$3
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem$3.run() | STYLE | REC_CATCH_EXCEPTION | 779 | Medium |
| org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem$3.run() ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 786 | Medium |
org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.retrieveFiles(PropFilesInfo, DataFilesInfo) | STYLE | REC_CATCH_EXCEPTION | 147 | Medium |
| org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.movePropsFileToFinalDestination(PropFilesInfo, File, String) ignores exceptional return value of java.io.File.createNewFile() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 264 | Medium |
| org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.movePropsFileToFinalDestination(PropFilesInfo, File, String) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 250 | Medium |
| org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.movePropsFileToFinalDestination(PropFilesInfo, File, String) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 255 | Medium |
| org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.movePropsFileToFinalDestination(PropFilesInfo, File, String) ignores exceptional return value of java.io.File.renameTo(File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 257 | Medium |
