2013-01-28 Keishi Hattori [REGRESSION] Calendar Picker focus ring is gone https://bugs.webkit.org/show_bug.cgi?id=108055 Reviewed by Kent Tamura. The focus ring wasn't visible because -webkit-focus-ring-color value only works for outline property in strict mode. Using fixed color instead. No new tests. Can't reproduce in layout test because mock popup writes a script tag in front of the doctype. * Resources/pagepopups/chromium/calendarPickerChromium.css: (.days-area-container:focus): * Resources/pagepopups/chromium/pickerCommonChromium.css: (:enabled:focus:-webkit-any(button, input[type='button'])): 2013-01-25 Yury Semikhatsky Web Inspector: remove unused isElement and similar methods from HeapProfiler https://bugs.webkit.org/show_bug.cgi?id=107940 Reviewed by Vsevolod Vlasov. - Removed some unused methods. - Moved JS specific edge filters to JSHeapSnapshot. * inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot.prototype.createEdgesProvider): (WebInspector.HeapSnapshot.prototype.createEdgesProviderForTest): (WebInspector.HeapSnapshot.prototype.retainingEdgesFilter): (WebInspector.HeapSnapshot.prototype.containmentEdgesFilter): (WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider): (WebInspector.HeapSnapshot.prototype.classNodesFilter): (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass): * inspector/front-end/HeapSnapshotGridNodes.js: (WebInspector.HeapSnapshotGenericObjectNode): * inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider): (WebInspector.HeapSnapshotProxy.prototype.createRetainingEdgesProvider): * inspector/front-end/JSHeapSnapshot.js: (WebInspector.JSHeapSnapshot.prototype.classNodesFilter): (WebInspector.JSHeapSnapshot.prototype._markDetachedDOMTreeNodes): * inspector/front-end/NativeHeapSnapshot.js: 2013-01-28 Sheriff Bot Unreviewed, rolling out r140554. http://trac.webkit.org/changeset/140554 https://bugs.webkit.org/show_bug.cgi?id=108057 Caused tables/table-section-overflow-clip-crash.html and bug2479-5.html to crash. (Requested by keishi on #webkit). * rendering/RenderBox.cpp: (WebCore::RenderBox::minPreferredLogicalWidth): (WebCore::RenderBox::maxPreferredLogicalWidth): * rendering/mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::computePreferredLogicalWidths): * rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::computePreferredLogicalWidths): * rendering/mathml/RenderMathMLRow.cpp: (WebCore::RenderMathMLRow::computePreferredLogicalWidths): 2013-01-24 Yury Semikhatsky Web Inspector: each node in a detached DOM tree is shown in its own "detached DOM tree" entry in heap profiler https://bugs.webkit.org/show_bug.cgi?id=107819 Reviewed by Adam Barth. Provide single RetainedDOMInfo for each group of DOM Node wrappers reported to GC. Otherwise we have unequal RetainedDOMInfo groups for each wrapped node. * bindings/v8/V8GCController.cpp: (WebCore::ImplicitConnection::ImplicitConnection): (WebCore::ImplicitConnection::retainedObjectInfo): (ImplicitConnection): (WebCore::WrapperGrouper::addObjectToGroup): (WrapperGrouper): (WebCore::WrapperGrouper::addNodeToGroup): (WebCore::WrapperGrouper::apply): (WebCore::V8GCController::opaqueRootForGC): * bindings/v8/V8GCController.h: (V8GCController): 2013-01-27 Mihnea Ovidenie [CSSRegions] RenderFlowThread should keep a count of auto height regions https://bugs.webkit.org/show_bug.cgi?id=105185 Reviewed by Julien Chaffraix. Keep the count of auto height regions on the flow thread instead of flow thread controller. This way, we can streamline the operations associated with the two-pass layout only to those flow threads that have auto height regions associated. The flow thread controller will keep a count of flow thread with auto height regions instead. This is a performance refactoring without an expected change in behavior, therefore no new tests were added. * rendering/FlowThreadController.cpp: Keep a count of flow threads with auto logical height regions. (WebCore::FlowThreadController::FlowThreadController): (WebCore::FlowThreadController::layoutRenderNamedFlowThreads): Check the count of auto height regions for all the flow threads. (WebCore::FlowThreadController::isAutoLogicalHeightRegionsCountConsistent): Make sure that we call these methods only when we have auto logical height regions. (WebCore::FlowThreadController::resetRegionsOverrideLogicalContentHeight): (WebCore::FlowThreadController::markAutoLogicalHeightRegionsForLayout): * rendering/FlowThreadController.h: (WebCore::FlowThreadController::hasFlowThreadsWithAutoLogicalHeightRegions): (WebCore::FlowThreadController::incrementFlowThreadsWithAutoLogicalHeightRegions): (WebCore::FlowThreadController::decrementFlowThreadsWithAutoLogicalHeightRegions): * rendering/RenderFlowThread.cpp: Keep a count of auto logical height regions. (WebCore::RenderFlowThread::RenderFlowThread): (WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent): (WebCore::RenderFlowThread::resetRegionsOverrideLogicalContentHeight): Iterate the region chain only if the region chain has auto height regions. (WebCore::RenderFlowThread::initializeRegionsOverrideLogicalContentHeight): Ditto. (WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout): Ditto. (WebCore::RenderFlowThread::incrementAutoLogicalHeightRegions): (WebCore::RenderFlowThread::decrementAutoLogicalHeightRegions): * rendering/RenderFlowThread.h: * rendering/RenderRegion.cpp: Add increment/decrementAutoLogicalHeightCount to increase/decrease the counter inside the flow thread and use them throughout the code as needed. (WebCore::RenderRegion::incrementAutoLogicalHeightCount): (WebCore::RenderRegion::decrementAutoLogicalHeightCount): (WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag): (WebCore::RenderRegion::attachRegion): (WebCore::RenderRegion::detachRegion): * rendering/RenderRegion.h: * rendering/RenderView.cpp: (WebCore::RenderView::checkTwoPassLayoutForAutoHeightRegions): Use the count of flow threads with auto height regions instead of the count of auto height regions when deciding whether we should attempt the 2 pass layout for auto height regions. 2013-01-27 Shinya Kawanaka [Shadow DOM] Selecting a node to another node in ShadowDOM fires 'click' event unexpectedly https://bugs.webkit.org/show_bug.cgi?id=107233 Reviewed by Dimitri Glazkov. When selecting from a node to another node in ShadowDOM, 'click' event is unexpectedly fired. The root cause of the bug is using shadow ancestor nodes for checking the node mouse is pressed on and the node mouse is released on is the same. This was introduced to fire a click event for a slider in or etc. However, we don't need to check shadow ancestor if we're in Author ShadowDOM. Test: fast/dom/shadow/selecting-anchor.html * page/EventHandler.cpp: (WebCore::mouseIsReleasedOnPressedElement): (WebCore): (WebCore::EventHandler::handleMouseReleaseEvent): 2013-01-27 Kentaro Hara An [ActiveDOMObject] IDL attribute should be inherited https://bugs.webkit.org/show_bug.cgi?id=107877 Reviewed by Adam Barth. Now we support IDL attribute inheritance. We can remove [ActiveDOMObject] from subclasses. No tests. No change in behavior. * Modules/indexeddb/IDBOpenDBRequest.idl: * Modules/webaudio/OfflineAudioContext.idl: * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): (GenerateImplementation): * bindings/scripts/CodeGeneratorV8.pm: (GenerateHeader): (GenerateNamedConstructorCallback): (GenerateImplementation): * workers/SharedWorker.idl: * workers/Worker.idl: 2013-01-27 Sheriff Bot Unreviewed, rolling out r140602. http://trac.webkit.org/changeset/140602 https://bugs.webkit.org/show_bug.cgi?id=108045 Caused 8 indexed tests to crash. (Requested by keishi on #webkit). * CMakeLists.txt: * DerivedSources.make: * GNUmakefile.list.am: * Modules/indexeddb/IDBCallbacks.h: (WebCore::IDBCallbacks::onBlocked): * Modules/indexeddb/IDBDatabase.cpp: * Modules/indexeddb/IDBDatabase.h: (WebCore): * Modules/indexeddb/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::deleteDatabase): * Modules/indexeddb/IDBFactory.cpp: (WebCore::IDBFactory::openInternal): (WebCore::IDBFactory::deleteDatabase): * Modules/indexeddb/IDBFactory.h: (WebCore): (IDBFactory): * Modules/indexeddb/IDBFactory.idl: * Modules/indexeddb/IDBOpenDBRequest.cpp: (WebCore::IDBOpenDBRequest::create): (WebCore::IDBOpenDBRequest::IDBOpenDBRequest): (WebCore::IDBOpenDBRequest::dispatchEvent): * Modules/indexeddb/IDBOpenDBRequest.h: (IDBOpenDBRequest): * Modules/indexeddb/IDBVersionChangeRequest.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h. (WebCore): (WebCore::IDBVersionChangeRequest::create): (WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest): (WebCore::IDBVersionChangeRequest::~IDBVersionChangeRequest): (WebCore::IDBVersionChangeRequest::interfaceName): (WebCore::IDBVersionChangeRequest::onBlocked): * Modules/indexeddb/IDBVersionChangeRequest.h: Copied from Source/WebCore/Modules/indexeddb/IDBFactory.idl. (WebCore): (IDBVersionChangeRequest): * Modules/indexeddb/IDBVersionChangeRequest.idl: Copied from Source/WebCore/Modules/indexeddb/IDBFactory.idl. * WebCore.gypi: * WebCore.xcodeproj/project.pbxproj: * dom/EventTarget.h: (WebCore): * dom/EventTargetFactory.in: 2013-01-27 Shinya Kawanaka Disabled input/textarea doesn't trigger selection change https://bugs.webkit.org/show_bug.cgi?id=85244 Reviewed by Ryosuke Niwa. Only rootEditableNode is there in or