2011-06-06 Shishir Agrawal Reviewed by Tony Gentilcore. Add a "prerender" state for page visibility. https://bugs.webkit.org/show_bug.cgi?id=62062 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setPageVisibility): 2011-06-06 Csaba Osztrogonác [Qt] Implement download feature for QtTestBrowser https://bugs.webkit.org/show_bug.cgi?id=61865 Buildfix for --minimal and CONFIG+=qt_minimal build after r88161. * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): * QtTestBrowser/launcherwindow.h: 2011-06-06 Barát Tibor Reviewed by Csaba Osztrogonác. [Qt] Implement download feature for QtTestBrowser https://bugs.webkit.org/show_bug.cgi?id=61865 * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::downloadRequest): (LauncherWindow::fileDownloadFinished): * QtTestBrowser/launcherwindow.h: 2011-06-04 Dominic Cooney Reviewed by Dimitri Glazkov. Make DumpRenderTree initialize window.internals. https://bugs.webkit.org/show_bug.cgi?id=61076 * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport. * DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): 2011-06-06 Alexandru Chiculita Reviewed by Kent Tamura. Add ENABLE_CSS_EXCLUSIONS support for build-webkit script https://bugs.webkit.org/show_bug.cgi?id=61628 * Scripts/build-webkit: 2011-06-06 Mihnea Ovidenie Reviewed by Kent Tamura. Add ENABLE(CSS_REGIONS) guard for CSS Regions support https://bugs.webkit.org/show_bug.cgi?id=61631 * Scripts/build-webkit: 2011-06-06 Carlos Garcia Campos Unreviewed. Fix the GTK+ build. * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals. 2011-06-05 Alexey Proskuryakov Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion works properly). * Scripts/webkitpy/common/config/committers.py: 2011-06-04 Kevin Ollivier [wx] Unreviewed build fix. Update git branch build dir handling to match what other WebKit scripts expect, so other scripts work properly with wx. * waf/build/build_utils.py: * waf/build/settings.py: 2011-06-04 Kevin Ollivier [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures to build on Mac. * waf/build/settings.py: * wx/install-unix-extras: 2011-06-04 Kevin Ollivier [wx] Unreviewed build fixes for recent trunk changes. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setTextDirection): * waf/build/settings.py: 2011-06-04 Martin Robinson Fix the GTK+ build. * GNUmakefile.am: Add some missing newline escape. 2011-06-03 Martin Robinson Try to fix the GTK+ bulid. * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals source list. 2011-06-03 Dirk Pranke Reviewed by Adam Barth. nrwt: should skip chromium test expectation overrides on upstream bots https://bugs.webkit.org/show_bug.cgi?id=61888 * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 2011-06-03 Dirk Pranke Reviewed by Ojan Vafai. new-run-webkit-tests: minor logging, code cleanup https://bugs.webkit.org/show_bug.cgi?id=62055 * Scripts/webkitpy/layout_tests/layout_package/manager.py: * Scripts/webkitpy/layout_tests/layout_package/worker.py: 2011-06-03 Martin Robinson Try to fix the build failure on the GTK+ 32-bit Release bot. * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list. 2011-05-31 Martin Robinson Reviewed by Ryosuke Niwa. [GTK] Support smart replace for the pasteboard https://bugs.webkit.org/show_bug.cgi?id=61734 Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace. This is required to produce consistent test results. * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Set the smart replace setting to on by default. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this methods which calls into DumpRenderTreeSupportGtk. 2011-06-03 Martin Robinson Reviewed by Dimitri Glazkov. Teach Gtk build about window.internals https://bugs.webkit.org/show_bug.cgi?id=61071 * DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): Inject the new internals object when the window object clears. * GNUmakefile.am: Add new source files and includes necessary for window.internals. Also do a little bit of cleanup. 2011-06-03 Dirk Pranke Reviewed by Tony Chang. Worker may not be stopped after LT. https://bugs.webkit.org/show_bug.cgi?id=61847 Re-submit a variant of the first fix for this bug. It's possible that actually calling cleanup() in the worker threads was taking too long and we triggered the assertions in the manager thread. I've bumped up the timeout in the manager and added better diagnostics. I also cleaned up the cleanup() code a bit because there was some unnecessary if-checks. * Scripts/webkitpy/layout_tests/layout_package/manager.py: * Scripts/webkitpy/layout_tests/layout_package/worker.py: 2011-06-03 Dirk Pranke Reviewed by Tony Chang. nrwt: fix duplicate logging regression https://bugs.webkit.org/show_bug.cgi?id=61981 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 2011-06-03 Robert Kroeger Reviewed by Adam Barth. Modified addTouchPoint to correctly re-use touchPoint id values starting from the lowest not-un-use touchPoint id as is done by the embedder APIs. (Fixes BUGCR36415) https://bugs.webkit.org/show_bug.cgi?id=62016 * DumpRenderTree/chromium/EventSender.cpp: (EventSender::addTouchPoint): 2011-06-03 Cary Clark Reviewed by Eric Seidel. Draw DRT scroll bar thumb with CG when WebKit renders with Skia https://bugs.webkit.org/show_bug.cgi?id=61534 Skia on Mac uses Skia to render WebKit, and CG to render UI elements. The CG elements need a transcribed graphics context that preserves the canvas matrix, and the canvas clip. The SkiaBitLocker utility class sets up a CGContext from the SkCanvas, locks the bitmap's bits, and releases the lock when the class goes out of scope. The SkiaBitLocker implementation is described by this patch: http://codereview.chromium.org/7031006/ When WebKit uses Skia for rendering, the WebCanvas is an SkCanvas. Create an equivalent CGContext to draw the scrollbar thumb. As the Chrome Mac port does not yet use Skia, this patch has no effect and requires no tests. * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb): 2011-06-03 Andras Becsi Unreviewed build fix. Fix typo. * Scripts/old-run-webkit-tests: 2011-06-03 Andras Becsi Reviewed by Csaba Osztrogonác. Print error message when there is no httpd present on the system https://bugs.webkit.org/show_bug.cgi?id=61939 * Scripts/old-run-webkit-tests: Propose to run with --no-httpd. * Scripts/webkitperl/httpd.pm: 2011-06-03 Mikhail Naganov Reviewed by Yury Semikhatsky. Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug. https://bugs.webkit.org/show_bug.cgi?id=61533 Skip cpu-profiler-profiling in debug, implement a fast headless alternative. * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::setJavaScriptProfilingEnabled): * DumpRenderTree/chromium/DRTDevToolsAgent.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptProfilingEnabled): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setJavaScriptProfilingEnabled): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2011-06-02 Dirk Pranke Reviewed by Tony Chang. NRWT needs a way to log to a file without including backspaces without needing --verbose https://bugs.webkit.org/show_bug.cgi?id=60328 This change modifies NRWT so that if it can tell if it is writing to a terminal, it will overwrite any messages printed in the 'one-line-progress' and 'updates' print options, and if not (or if --verbose was specified) the messages will be printed without backspaces. If the overwriting updates are disabled, one-line-progress will only print every 10 seconds instead of on every update. This ensures that we still get updates once in a while while the tests are running, even if we're not in --verbose mode. Note that one-line-progress will now still be printed in --verbose, since it's useful as long as you're not flooded with the updates. * Scripts/webkitpy/layout_tests/layout_package/manager.py: * Scripts/webkitpy/layout_tests/layout_package/printing.py: * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 2011-06-02 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] autogen.sh is run twice for each buld on the bots https://bugs.webkit.org/show_bug.cgi?id=61951 * Scripts/webkitdirs.pm: Only check the previous autotools arguments for the WebKit project. This prevents build-jsc runs from forcing subsequent build-webkit runs to re-rerun autogen.sh. 2011-06-02 Sheriff Bot Unreviewed, rolling out r87946. http://trac.webkit.org/changeset/87946 https://bugs.webkit.org/show_bug.cgi?id=61965 Cause NRWT to break (Requested by abarth|gardener on #webkit). * Scripts/webkitpy/layout_tests/layout_package/worker.py: 2011-06-02 Dimitri Glazkov Reviewed by Darin Adler. Add build logistics and plumbing for window.internals object. https://bugs.webkit.org/show_bug.cgi?id=60313 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto. 2011-06-02 Hao Zheng Reviewed by Dirk Pranke. Call cleanup() explicitly at the end of worker.run(). https://bugs.webkit.org/show_bug.cgi?id=61847 * Scripts/webkitpy/layout_tests/layout_package/worker.py: 2011-06-02 Dimitri Glazkov Unreviewed, rolling out r87926. http://trac.webkit.org/changeset/87926 https://bugs.webkit.org/show_bug.cgi?id=60313 Fails to find WebCoreTestSupport.dylib on bots. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): 2011-05-21 Dimitri Glazkov Reviewed by Darin Adler. Add build logistics and plumbing for window.internals object. https://bugs.webkit.org/show_bug.cgi?id=60313 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto. 2011-06-02 Gyuyoung Kim Reviewed by Eric Seidel. Adjust efl coding style to more efl directories https://bugs.webkit.org/show_bug.cgi?id=61903 * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories. 2011-06-01 Dirk Pranke Reviewed by Tony Chang. old-run-webkit-tests: add support for audio files https://bugs.webkit.org/show_bug.cgi?id=57992 * Scripts/old-run-webkit-tests: 2011-06-01 Jochen Eisinger Reviewed by Adam Barth. Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient https://bugs.webkit.org/show_bug.cgi?id=34314 * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setImagesAllowed): (LayoutTestController::setStorageAllowed): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h. (WebPermissions::WebPermissions): (WebPermissions::~WebPermissions): (WebPermissions::allowImages): (WebPermissions::allowStorage): (WebPermissions::setImagesAllowed): (WebPermissions::setStorageAllowed): (WebPermissions::reset): * DumpRenderTree/chromium/WebPermissions.h: 2011-06-01 Noel Gordon Reviewed by Tony Chang. Test plugin should support event logging on the windows port. https://bugs.webkit.org/show_bug.cgi?id=61721 * DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventWin): Well, handle them. 2011-06-01 Daniel Cheng Reviewed by Tony Chang. [chromium] Use correct file name for dragging out images. https://bugs.webkit.org/show_bug.cgi?id=24887 * DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::dumpFilenameBeingDragged): * DumpRenderTree/chromium/EventSender.h: 2011-06-01 Dirk Pranke Reviewed by Tony Chang. nrwt: make webaudio work w/o content-length header https://bugs.webkit.org/show_bug.cgi?id=61819 * Scripts/webkitpy/layout_tests/layout_package/printing.py: * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: * Scripts/webkitpy/layout_tests/port/mock_drt.py: * Scripts/webkitpy/layout_tests/port/webkit.py: 2011-06-01 Viatcheslav Ostapenko Reviewed by Andreas Kling. [Qt][WK2] Add QGLWidget viewport support to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=61802 Add command line parameter and menu item to MiniBrowser application enabling use of QGLWidget for browser viewport. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::toggleGLViewport): * MiniBrowser/qt/BrowserWindow.h: * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions): * MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::WindowOptions): 2011-06-01 Martin Robinson Reviewed by Xan Lopez. Print out autogen arguments when they differ from the last set, to help with debugging build issues. * Scripts/webkitdirs.pm: Print out previous and current build arguments when they differ. 2011-06-01 Carlos Garcia Campos Reviewed by Martin Robinson. [GTK] run-launcher should run MiniBrowser in WebKit2 https://bugs.webkit.org/show_bug.cgi?id=61858 * Scripts/run-launcher: Check whether -2 command line option has been passed and run MiniBrowser instead of GtkLauncher. 2011-05-31 Hao Zheng Reviewed by Dirk Pranke. Fix exception in verbose printing mode. https://bugs.webkit.org/show_bug.cgi?id=61723 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 2011-05-31 Yong Li Reviewed by Eric Seidel. https://bugs.webkit.org/show_bug.cgi?id=54807 We have been assuming plain bitfields (like "int a : 31") are always signed integers. However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned. http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers, always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good rule we should have in order to make our code independent from compilers and compiler flags. * Scripts/webkitpy/style/checkers/cpp.py: 2011-05-31 Hironori Bono Reviewed by Eric Seidel. Add a JavaScript function layoutTestController.setTextDirection(). https://bugs.webkit.org/show_bug.cgi?id=50952 This change adds a new JavaScript function setTextDirection() to the LayoutTestController class of Safari and Chrome to write layout tests that changes the text direction of an editable element. * DumpRenderTree/LayoutTestController.cpp: (setTextDirectionCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setTextDirection): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTextDirection): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setTextDirection): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setTextDirection): 2011-05-31 Ademar de Souza Reis Jr Reviewed by Simon Hausmann. [Qt] User-agent list of Qt test browsers is very outdated https://bugs.webkit.org/show_bug.cgi?id=61531 The user can edit the user-agent manually, so there's no need to have a super complete and up to date list, but it's nice to have it minimally updated. * MiniBrowser/qt/useragentlist.txt: * QtTestBrowser/useragentlist.txt: 2011-03-30 Martin Robinson Reviewed by Adam Roben. [GTK] [WebKit2] Implement a basic WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=57068 Add an implementation of WebKitTestRunner for GTK+. * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner. * Scripts/old-run-webkit-tests: Ditto. * Scripts/run-launcher: Ditto. * Scripts/webkitdirs.pm: Ditto. * WebKitTestRunner/GNUmakefile.am: Added. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added. * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp. * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp. * WebKitTestRunner/PlatformWebView.h: * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added. * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added. * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp. (main): Added. 2011-05-31 Dirk Pranke Reviewed by Tony Chang. new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c https://bugs.webkit.org/show_bug.cgi?id=60241 * Scripts/new-run-webkit-tests: 2011-05-31 Eric Seidel Reviewed by David Kilzer. webkitpy should create zips with zip -9 https://bugs.webkit.org/show_bug.cgi?id=61789 Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller. * Scripts/webkitpy/common/system/workspace.py: * Scripts/webkitpy/common/system/workspace_unittest.py: 2011-05-31 Kristóf Kosztyó Reviewed by Csaba Osztrogonác. [Qt] Implement find feature for QtTestBrowser https://bugs.webkit.org/show_bug.cgi?id=61425 Buildfix for --minimal and CONFIG+=qt_minimal build. * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::createChrome): * QtTestBrowser/launcherwindow.h: 2011-05-31 Kristóf Kosztyó Reviewed by Csaba Osztrogonác. [Qt] Implement find feature for QtTestBrowser https://bugs.webkit.org/show_bug.cgi?id=61425 * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::createChrome): (LauncherWindow::showFindBar): (LauncherWindow::find): * QtTestBrowser/launcherwindow.h: 2011-05-30 Carlos Garcia Campos Reviewed by Martin Robinson. [GTK] Implement JavaScript dialogs in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=61725 * MiniBrowser/gtk/BrowserWindow.c: (WKStringGetCString): Helper function to get a UTF-8 c string from a WKStringRef. (WKURLGetCString): Helper function to get a UTF-8 c string from a WKURLRef. (browserWindowUpdateURL): Update to use WKURLGetCString. (didReceiveTitleForFrame): Update to use WKStringGetCString. (createMessageDialog): Create a GtkMessageDialog. (runJavaScriptAlert): (runJavaScriptConfirm): (runJavaScriptPrompt): (browserWindowUIClientInit): 2011-05-29 Yuta Kitamura Reviewed by Kent Tamura. WebSocket closing handshake https://bugs.webkit.org/show_bug.cgi?id=35721 * Scripts/webkitpy/thirdparty/__init__.py: Pull in pywebsocket 0.6b1. We need to update pywebsocket to get the right behavior of closing handshake. 2011-05-29 Daniel Bates Reviewed by David Kilzer. REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range https://bugs.webkit.org/show_bug.cgi?id=61162 Fixes an issue where svn-apply may ignore a diff that contains a chunk range line that omits a line count. In particular, the chunk range regular expression does not match a chunk range line that omits a line count. GNU diff(1) will omit the line count in the chunk range if the line count is exactly 1. For example, appending a new line to the end of an existing file F that contains exactly one line of text will be represented in a diff with a chunk range line that omits the line count for F. * Scripts/VCSUtils.pm: (parseChunkRange): Added. * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added. * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: - Added unit test "Git: Append new line to the end of an existing file". 2011-05-28 Adam Barth Reviewed by Eric Seidel. EWS builds patches that fail to build twice, which seems useless and slows down the bots https://bugs.webkit.org/show_bug.cgi?id=55585 This patch switches all the early warning system bots over to the new PatchAnalysisTask-based infrastructure. This patch makes these bots more efficient (in the case where patches fail to build) and paves the way for running tests on these bots! * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: * Scripts/webkitpy/tool/bot/patchanalysistask.py: * Scripts/webkitpy/tool/commands/earlywarningsystem.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: 2011-05-28 Kenichi Ishibashi Reviewed by Kent Tamura. Add bashi as a committer. https://bugs.webkit.org/show_bug.cgi?id=61685 * Scripts/webkitpy/common/config/committers.py: 2011-05-27 Adam Barth Reviewed by Eric Seidel. When checking whether the tree is red, the EWS posts a link to the wrong log https://bugs.webkit.org/show_bug.cgi?id=61072 We need to cache the original script error because that contains the failure log we want to upload. If we don't cache that script error, self._script_error will get overwritten when we sanity check the clean tree (and it also has test failures). * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: - This testing approach is slightly goofy. We'd like to use assertRaisesRegexp, but that's not available until Python 2.7. * Scripts/webkitpy/tool/bot/patchanalysistask.py: 2011-05-27 Jochen Eisinger Reviewed by Adam Barth. Add layoutTestController.setStorageAllowed() to control whether access to the localStorage API is enabled via the WebPermissionClient https://bugs.webkit.org/show_bug.cgi?id=61581 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setStorageAllowed): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::createNewWindow): * DumpRenderTree/chromium/TestShell.h: * DumpRenderTree/chromium/WebPermissions.h: Added. (WebPermissions::WebPermissions): (WebPermissions::allowStorage): (WebPermissions::setStorageAllowed): (WebPermissions::reset): 2011-05-27 Dirk Pranke Reviewed by Eric Seidel. NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch https://bugs.webkit.org/show_bug.cgi?id=60326 This patch removes a lot of the complexity from the metered_stream implementation that was unnecessary since there was only one caller and the logic could be coordinated better. There should be no functional changes in this patch, just code getting deleted and cleaned up. * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: * Scripts/webkitpy/layout_tests/layout_package/printing.py: * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 2011-05-27 Dirk Pranke Reviewed by Eric Seidel. NRWT: minor cleanup in printing module https://bugs.webkit.org/show_bug.cgi?id=60329 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 2011-05-27 Steve Lacey Reviewed by David Levin. Add sjl@chromium.org as a committer. https://bugs.webkit.org/show_bug.cgi?id=61672 * Scripts/webkitpy/common/config/committers.py: 2011-05-27 Dirk Pranke Reviewed by Adam Barth. NRWT: remove --print detailed-progress https://bugs.webkit.org/show_bug.cgi?id=60324 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: * Scripts/webkitpy/layout_tests/layout_package/printing.py: * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2011-05-27 Dirk Pranke Reviewed by Ojan Vafai. NRWT: debug messages from the workers are being logged twice https://bugs.webkit.org/show_bug.cgi?id=60428 It looks like when the workers are run in separate processes we end up getting two copies of every log message they print. This has to do with the multiprocessing module on UNIX cloning the log configuration in a way I wasn't expecting, and so two log handlers end up getting registered. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: * Scripts/webkitpy/layout_tests/layout_package/printing.py: * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2011-05-27 Adam Roben Always decode tester names from location.hash When navigating directly to a tester-specific URL (e.g., ), you could end up with a URL-encoded tester name in the page, and then the encoded name could make its way into Bugzilla bugs. Bad! Reviewed by David Kilzer. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through decodeURIComponent before trying to use it. 2011-05-27 Adam Roben Remove testing code that snuck into r87528 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing. 2011-05-27 Adam Roben Add links to TestFailures to easily file bugs about failing tests Fixes TestFailures page should have links to file bugs for failing tests Reviewed by David Kilzer. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html for a particular build. (Builder.prototype._getFailingTests): Use resultsPageURL. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: (ViewController.prototype._displayBuilder): Add links to file bugs about each set of failures. (ViewController.prototype._domForBuildName): Use resultsPageURL. (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the new bug link. The bug has a title, description, and URL already filled in for you! 2011-05-27 Sheriff Bot Unreviewed, rolling out r87464. http://trac.webkit.org/changeset/87464 https://bugs.webkit.org/show_bug.cgi?id=61643 client-close/server-close tests are flaky on Chromium Mac and Windows (Requested by aklein on #webkit). * Scripts/webkitpy/thirdparty/__init__.py: 2011-05-27 Alexey Proskuryakov Added Douglas Davidson to contributors list for easier CC'ing. * Scripts/webkitpy/common/config/committers.py: 2011-05-26 Mihai Parparita Reviewed by Adam Barth. Fix worldID and destinationDomain argument names https://bugs.webkit.org/show_bug.cgi?id=61571 As part of working on r87423, I noticed a couple of inconsistencies in argument names: - We would use worldId in .h files but worldID in .cpp files. Standardize on the latter - SecurityOrigin::addOriginAccessWhitelistEntry would take a destinationDomains argument, even though the actual parameter was for a single domain (renamed to be singular). * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld): 2011-05-26 Yuta Kitamura Reviewed by Kent Tamura. WebSocket closing handshake https://bugs.webkit.org/show_bug.cgi?id=35721 * Scripts/webkitpy/thirdparty/__init__.py: Pull in pywebsocket 0.6b1. We need to update pywebsocket to get the right behavior of closing handshake. 2011-05-26 Qi Zhang Reviewed by Andreas Kling. WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled https://bugs.webkit.org/show_bug.cgi?id=42676 Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setAuthorAndUserStylesEnabled): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2011-05-26 Ademar de Souza Reis Jr. Reviewed by Andreas Kling. [Qt] QtTestBrowser "Switch User Agent" dialog is broken https://bugs.webkit.org/show_bug.cgi?id=61527 The setMaximumHeight() call is unecessary and breaks the dialog at least on my setup. * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::showUserAgentDialog): 2011-05-02 Robert Hogan Reviewed by Adam Roben. [Qt] Allow popup windows from plugins when initiated by a user gesture https://bugs.webkit.org/show_bug.cgi?id=41292 Support parameters introduced in plugin-initiate-popup-window.html * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_handle_event): 2011-05-26 Mihai Parparita Reviewed by Adam Barth. Support cross-origin XMLHttpRequest in isolated worlds https://bugs.webkit.org/show_bug.cgi?id=59843 Expose setIsolatedWorldSecurityOrigin in LayoutTestController. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setIsolatedWorldSecurityOrigin): * DumpRenderTree/chromium/LayoutTestController.h: 2011-05-25 Brian Weinstein Reviewed by Adam Roben. WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle https://bugs.webkit.org/show_bug.cgi?id=61474 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient. 2011-05-26 Andreas Kling Unreviewed, correct address to webkit-committers mailing list. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 2011-05-25 Adam Roben Don't assume that builds finish in the order they were started Fixes TestFailures page shows failures from a not-most-recent build when one slave is taking a long time to finish a build Reviewed by Antti Koivisto. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are newer than the oldest in-progress build are also themselves in progress. Just check whether each build is actually in progress (as signified by its presence in the currentBuilds set). 2011-05-25 Adam Roben Correctly detect cases where only a single test failed/crashed/timed out Fixes TestFailures page doesn't show testers with only a single failing test Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It will be singular when only a single test fails/crashes/times out. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test failed/crashed/timed out. 2011-05-26 Tom Hudson Reviewed by Tony Chang. Add flags to Chromium ImageDiff to write image comparison metrics on stdout. https://bugs.webkit.org/show_bug.cgi?id=60569 * DumpRenderTree/chromium/ImageDiff.cpp: (Image::createFromStdin): Fix spelling. (maxOf3): New function to do 3-way maximum. (getRedComponent): Extract red component from ABGR packed encoding. (getGreenComponent): Extract green component from ABGR packed encoding. (getBlueComponent): Extract blue component from ABGR packed encoding. (weightedPercentageDifferent): Determine % of pixels different in two images multiplied by intensity difference of each pixel. (printHelp): Document new arguments. (compareImages): Parameterize. (untestedCompareImages): Parameterize. (diffImages): Parameterize; write results on stdout if requested. (main): Parse new arguments. 2011-05-25 Qi Zhang Reviewed by Simon Hausmann. WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled https://bugs.webkit.org/show_bug.cgi?id=42697 Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setPrivateBrowsingEnabled): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2011-05-25 Jon Honeycutt REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery https://bugs.webkit.org/show_bug.cgi?id=61428 Reviewed by Adam Roben. The crash occurs when Flash posts a message to a window that it creates, and in processing the message, it calls NPN_Evaluate to evaluate JavaScript that removes the plug-in from the page. Flash then crashes when we return to Flash code. This test emulates that behavior. * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added. (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin): Initialize member vars. (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin): Remove our custom property from the message window, and destroy it. (CallJSThatDestroysPlugin::NPP_Destroy): Set m_isDestroyed, log that the plug-in was destroyed, and notify the layout test controller that we're done. (wndProc): Get the PluginTest object, and call its runTest() function. (CallJSThatDestroysPlugin::NPP_New): Setup the test: register a class for the message-only window, create it, and post a message to it to run the test. (CallJSThatDestroysPlugin::runTest): Execute JS that removes the plug-in from the page, and if we're not destroyed, log a success message. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Add new test to project. 2011-05-25 Tony Chang Reviewed by Adam Barth. webkitpy's NetworkTransaction shouldn't use mechanize https://bugs.webkit.org/show_bug.cgi?id=61450 mechanize.HTTPError is just an alias for urllib2.HTTPError, so use urllib2 directly. Re-add NetworkTransaction to test_results_uploader.py (reverting r87124). * Scripts/webkitpy/common/net/networktransaction.py: * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: 2011-05-25 Kevin Ollivier [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA until the port begins using those export macros. * DumpRenderTree/chromium/config.h: 2011-05-25 Sheriff Bot Unreviewed, rolling out r87257. http://trac.webkit.org/changeset/87257 https://bugs.webkit.org/show_bug.cgi?id=61457 This broke layout tests, see bug 61431. (Requested by hwennborg on #webkit). * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::clearAllDatabases): * DumpRenderTree/chromium/LayoutTestController.h: 2011-05-25 Qi Zhang Reviewed by Andreas Kling. [Qt] fast/css/disabled-author-styles.html failed https://bugs.webkit.org/show_bug.cgi?id=61438 Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setAuthorAndUserStylesEnabled): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2011-05-25 Adam Roben Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures Fixes TestFailures page should show when run-webkit-tests started exiting early due to too many crashes, timeouts, or failures Reviewed by David Kilzer. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when run-webkit-tests exits early due to too many failures, pass that information in another argument to the callback. (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect the new structure of the object passed to the callback. (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to pass that along to our own callbacks. (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean from _getFailingTests and to store that value in the history object. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: (.info): Added. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: (ViewController.prototype._displayBuilder): Updated for change in structure to the history object and to add a note when run-webkit-tests exited early due to too many failures. (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to latestBuildInfos since each entry now contains more than just the tester and failure count. Now displays a message for testers where the latest build exited early due to too many failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to store that value in latestBuildInfos. 2011-05-24 Keishi Hattori Reviewed by Kent Tamura. Disable textfield implementation of . Add INPUT_COLOR feature flag. Add input color sanitizer. https://bugs.webkit.org/show_bug.cgi?id=61273 * Scripts/build-webkit: Added INPUT_COLOR feature flag. 2011-05-24 Greg Simon Reviewed by Dimitri Glazkov. Control Indexeddb backends from LayoutTestController https://bugs.webkit.org/show_bug.cgi?id=61000 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setOverrideIndexedDBBackingStore): (LayoutTestController::clearAllDatabases): * DumpRenderTree/chromium/LayoutTestController.h: 2011-05-24 Robert Hogan Reviewed by Ryosuke Niwa. [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html https://bugs.webkit.org/show_bug.cgi?id=61393 * DumpRenderTree/qt/EventSenderQt.h: * DumpRenderTree/qt/EventSenderQt.cpp: (getModifiers): static function for interpreting modifiers (EventSender::mouseDown): Respect keyboard modifiers (EventSender::keyDown): use new static function (EventSender::sendOrQueueEvent): whitespace fix 2011-05-24 Jay Civelli Reviewed by Adam Barth. Adding MHTML reading support. https://bugs.webkit.org/show_bug.cgi?id=7168 * Scripts/build-webkit: * Scripts/old-run-webkit-tests: * Scripts/webkitperl/features.pm: * Scripts/webkitpy/layout_tests/port/test_files.py: * Scripts/webkitpy/layout_tests/port/webkit.py: 2011-05-24 Stephen White Reviewed by Kenneth Russell. Remove most style checks on Source/ThirdParty/glu, since it doesn't follow WebKit style. https://bugs.webkit.org/show_bug.cgi?id=61365 * Scripts/webkitpy/style/checker.py: 2011-05-24 Adam Roben Don't allow forcing builds through the build.webkit.org web interface Someone has been forcing bogus builds. * BuildSlaveSupport/build.webkit.org-config/master.cfg: 2011-05-24 Qi Zhang Reviewed by Adam Roben. WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard https://bugs.webkit.org/show_bug.cgi?id=42669 Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed. Because that case changed the setting. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): 2011-05-24 Csaba Osztrogonác Reviewed by Kenneth Rohde Christiansen. [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix https://bugs.webkit.org/show_bug.cgi?id=61052 * Scripts/old-run-webkit-tests: 2011-05-24 Adam Roben Make TestFailures show how many tests are failing on each tester, and omit testers with no failures Fixes TestFailures page shows testers that don't have any failing tests, which isn't useful Reviewed by David Kilzer. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects instead of name strings. (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of builder names into an array of builders. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of the most recently completed build, or -1 if there is no such build. (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed in the given build, or -1 if the number could not be determined. Some of this code came from _getFailingTests. (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests. (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and getNumberOfFailingTests functions. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: (ViewController.prototype._displayTesters): Get the current number of test failures for each tester and show it in the list. Omit testers that have no failures at all. We keep the testers and failure counts in an array and sort it before displaying the current data, as the order in which data will be fetched is unpredictable. 2011-05-23 Tony Chang Reviewed by Ojan Vafai. [nrwt] don't use NetworkTranslation when uploading results https://bugs.webkit.org/show_bug.cgi?id=61315 This avoids autoinstalling mechanize. It didn't matter anyway because test_results_uploader.py wasn't using mechanize to make the request so NetworkTransaction::run wasn't doing anything extra (it only matters if it catches mechanize.HTTPError). * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: 2011-05-23 Tony Chang Reviewed by Dirk Pranke. [chromium] fix the rebaseline tool to work with Linux GPU failures https://bugs.webkit.org/show_bug.cgi?id=61312 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2011-05-23 Darin Adler Ignore generated .pyc files in a directory full of python code. * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore. 2011-05-23 Adam Barth Reviewed by Eric Seidel. sheriffbot should give more details about the failures in IRC https://bugs.webkit.org/show_bug.cgi?id=61233 With this patch, sheriffbot will annonce the set of failing tests, which might help folks triage the problem. * Scripts/webkitpy/tool/commands/sheriffbot.py: * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 2011-05-23 Sheriff Bot Unreviewed, rolling out r87078. http://trac.webkit.org/changeset/87078 https://bugs.webkit.org/show_bug.cgi?id=61294 Patch contains errors and seems likely to break a bunch of bots (Requested by abarth on #webkit). * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 2011-05-23 Alice Boxhall Reviewed by Ojan Vafai. Convert json_results_generator.py to output version 4 JSON. https://bugs.webkit.org/show_bug.cgi?id=60869 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 2011-05-23 Patrick Gansterer Reviewed by Adam Barth. Move generation of shell_command from port to executive https://bugs.webkit.org/show_bug.cgi?id=61251 After move it's possible to use the code in other places too. * Scripts/webkitpy/common/config/ports.py: * Scripts/webkitpy/common/system/executive.py: 2011-05-23 Qi Zhang Reviewed by Darin Adler. WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard https://bugs.webkit.org/show_bug.cgi?id=42669 Implement setJavaScriptCanAccessClipboard in WebKitTestRunner. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setJavaScriptCanAccessClipboard): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2011-05-22 Robert Hogan Reviewed by Kenneth Rohde Christiansen. Fix policyDelegate in Qt DRT https://bugs.webkit.org/show_bug.cgi?id=61247 Use the 'policy delegate' implemented in FrameLoaderClient for layout tests. The partial implementation in DumpRenderTreeQt is redundant, so remove it. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::acceptNavigationRequest): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitForPolicyDelegate): 2011-05-22 Patrick Gansterer Reviewed by Darin Adler. Use double quotes for filename arguments https://bugs.webkit.org/show_bug.cgi?id=61250 Windows does not support single quotes on the command line, so replace them with double quotes. * Scripts/prepare-ChangeLog: 2011-05-20 Simon Fraser Reviewed by Sam Weinig. WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId https://bugs.webkit.org/show_bug.cgi?id=42550 Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Copy the code for pausing animations, FIXME comments and all. (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2011-05-20 Alok Priyadarshi Reviewed by Stephen White. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2011-05-19 Adam Roben Test that the WebKit2 UI process doesn't crash when starting a download Test for REGRESSION (r86812): Crash (preceded by assertion) in fastMalloc when downloading a file Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added. * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added. (TestWebKitAPI::decidePolicyForNavigationAction): Start a download. (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was started, cancel the download, and return a bogus string. (TestWebKitAPI::setContextDownloadClient): (TestWebKitAPI::setPagePolicyClient): Simple helper functions. (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to our policy client, and run until we know that the download was started. If we haven't crashed, we win! * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/win/TestWebKitAPI.vcproj: * TestWebKitAPI/win/copy-resources.cmd: Added new files. 2011-05-20 Kent Tamura Reviewed by Ryosuke Niwa. Fix style errors in DumpRenderTree/chromium/. https://bugs.webkit.org/show_bug.cgi?id=61172 * DumpRenderTree/chromium/CppBoundClass.cpp: (CppBoundClass::getAsCppVariant): (CppBoundClass::bindToJavascript): * DumpRenderTree/chromium/CppBoundClass.h: (CppBoundClass::GetterCallback::~GetterCallback): (CppBoundClass::CppBoundClass): (CppBoundClass::Callback::~Callback): (CppBoundClass::MemberCallback::MemberCallback): (CppBoundClass::MemberCallback::~MemberCallback): (CppBoundClass::MemberGetterCallback::MemberGetterCallback): (CppBoundClass::MemberGetterCallback::~MemberGetterCallback): * DumpRenderTree/chromium/CppVariant.h: * DumpRenderTree/chromium/DRTDevToolsAgent.h: (DRTDevToolsAgent::~DRTDevToolsAgent): * DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::sendFrontendLoaded): * DumpRenderTree/chromium/DRTDevToolsClient.h: * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/EventSender.cpp: (SavedEvent::SavedEvent): (EventSender::EventSender): (EventSender::keyDown): * DumpRenderTree/chromium/EventSender.h: * DumpRenderTree/chromium/ImageDiff.cpp: (Image::Image): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::WorkQueue::reset): (WorkItemBackForward::WorkItemBackForward): (WorkItemLoadingScript::WorkItemLoadingScript): (WorkItemNonLoadingScript::WorkItemNonLoadingScript): (WorkItemLoad::WorkItemLoad): (WorkItemLoadHTMLString::WorkItemLoadHTMLString): (LayoutTestController::pathToLocalResource): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::WorkItem::~WorkItem): (LayoutTestController::WorkQueue::WorkQueue): * DumpRenderTree/chromium/MockSpellCheck.cpp: (MockSpellCheck::MockSpellCheck): (MockSpellCheck::~MockSpellCheck): * DumpRenderTree/chromium/MockSpellCheck.h: * DumpRenderTree/chromium/NotificationPresenter.h: (NotificationPresenter::NotificationPresenter): * DumpRenderTree/chromium/Task.cpp: (WebTask::WebTask): * DumpRenderTree/chromium/Task.h: (TaskList::TaskList): * DumpRenderTree/chromium/TestEventPrinter.cpp: (DRTPrinter::DRTPrinter): (TestShellPrinter::TestShellPrinter): * DumpRenderTree/chromium/TestNavigationController.cpp: (TestNavigationEntry::TestNavigationEntry): (TestNavigationEntry::~TestNavigationEntry): (TestNavigationController::TestNavigationController): (TestNavigationController::reload): (TestNavigationController::loadEntry): (TestNavigationController::didNavigateToEntry): * DumpRenderTree/chromium/TestNavigationController.h: (TestShellExtraData::TestShellExtraData): * DumpRenderTree/chromium/TestShell.cpp: (dumpHistoryItem): * DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams): * DumpRenderTree/chromium/TestShellWin.cpp: (TestShell::waitTestFinished): * DumpRenderTree/chromium/TestWebWorker.h: (TestWebWorker::startWorkerContext): (TestWebWorker::terminateWorkerContext): (TestWebWorker::postMessageToWorkerContext): (TestWebWorker::clientDestroyed): (TestWebWorker::postMessageToWorkerObject): (TestWebWorker::postExceptionToWorkerObject): (TestWebWorker::postConsoleMessageToWorkerObject): (TestWebWorker::confirmMessageFromWorkerObject): (TestWebWorker::reportPendingActivity): (TestWebWorker::workerContextClosed): (TestWebWorker::~TestWebWorker): * DumpRenderTree/chromium/TextInputController.cpp: * DumpRenderTree/chromium/WebThemeControlDRTWin.h: * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: (WebThemeEngineDRTWin::paintButton): (WebThemeEngineDRTWin::paintMenuList): (WebThemeEngineDRTWin::paintTrackbar): * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: (WebThemeEngineDRTWin::WebThemeEngineDRTWin): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::navigate): (WebViewHost::updateSessionHistory): (WebViewHost::paintInvalidatedRegion): * DumpRenderTree/chromium/WebViewHost.h: 2011-05-19 Dmitry Lomov Reviewed by Adam Roben. Detect hangs in run-api-tests https://bugs.webkit.org/show_bug.cgi?id=48043 * Scripts/run-api-tests: Added test timeouts 2011-05-19 Dmitry Lomov Reviewed by Adam Roben. run-api-tests should run one test per process https://bugs.webkit.org/show_bug.cgi?id=61088 * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, return code, and parsing GTest output format. 2011-05-15 Robert Hogan Reviewed by Antonio Gomes. [Qt][GTK] plugins/get-url-with-javascript-url.html fails https://bugs.webkit.org/show_bug.cgi?id=60834 Fix unix test plugin for plugins/get-url-with-javascript-url.html * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_stream): (webkit_test_plugin_write_ready): (webkit_test_plugin_write): 2011-05-19 Sheriff Bot Unreviewed, rolling out r86869, r86873, r86875, and r86877. http://trac.webkit.org/changeset/86869 http://trac.webkit.org/changeset/86873 http://trac.webkit.org/changeset/86875 http://trac.webkit.org/changeset/86877 https://bugs.webkit.org/show_bug.cgi?id=61139 broke builds and debug DRT (Requested by rniwa on #webkit). * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): 2011-05-18 Dimitri Glazkov Reviewed by Darin Adler. Add build logistics and plumbing for window.internals object. https://bugs.webkit.org/show_bug.cgi?id=60313 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto. 2011-05-19 Zsolt Fehér Reviewed by Csaba Osztrogonác. [Qt] Implement eventSender.scalePageBy https://bugs.webkit.org/show_bug.cgi?id=60015 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::scalePageBy): * DumpRenderTree/qt/EventSenderQt.h: 2011-05-19 Kenichi Ishibashi Reviewed by Kent Tamura. [Chromium] IME candidate window appears wrong position in an iframe https://bugs.webkit.org/show_bug.cgi?id=61023 Call the focused frame's firstRectForCharacterRange() instead of the main frame so that DRT behaves as the same as Chromium. * DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::firstRectForCharacterRange): 2011-05-18 Adam Roben Add a new page to build.webkit.org to help find when tests started failing The page is accessible at . It is pretty minimalist right now, but already shows some useful information. It's somewhat similar to webkit-patch failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a little more convenient than either of them, though, because it's all done in the browser (and thus it's easy to go directly to the relevant test results). * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added. (Buildbot): This class represents a Buildbot server. (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build. (Buildbot.prototype.builderNamed): Returns a Builder with the given name. (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the callback. (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must be implemented by a derived class that understands this server's build naming scheme. (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a particular build. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added. (Builder): This class represents one builder on the buildbot. (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build. (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more information about a particular test failure. (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with information about when tests started failing. (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a particular build. (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the callback. (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and extracts all the failing tests listed in it, passing them to the callback. (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified build, merges them into the build history, and calls the callback telling it whether the next build should be fetched to provide more information. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Added. Just some simple styles. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added. (createDefinitionList): Takes an array of pairs and turns them into a DL element. (getResource): Wrapper around XMLHttpRequest. (Array.prototype.findFirst): Finds the first element matching the given predicate and returns it. (Array.prototype.last): Returns the last element of the array. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added. (ViewController): This class contains the main logic for displaying the page. (ViewController.loaded): Just calls through to parseHash. (ViewController.parseHash): Either starts analyzing failures on a particular builder, or shows the list of all testers so one can be chosen. This function is called when the page loads and whenever we get a hashchange event. (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it as it is fetched. The display ends up grouping tests by when they started failing. (ViewController._displayTesters): Gets the list of testers and displays it. (ViewController._domForBuildName): (ViewController._domForFailedTest): Helper functions to create descriptions and links for a particular build or failed test. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added. (WebKitBuildbot): Calls up to the base class constructor with the correct base URL. (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just loads all the files and sets up a ViewController, which does the rest. * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new page. 2011-05-18 Kristóf Kosztyó Reviewed by Csaba Osztrogonác. [Qt] Implement layoutTestController.setValueForUser() https://bugs.webkit.org/show_bug.cgi?id=60956 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setValueForUser): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2011-05-16 Robert Hogan Reviewed by Kenneth Rohde Christiansen. plugins/invalidate_rect.html fails on linux ports - Make the unix test netscape plugin recognize the onPaintEvent and windowedPlugin parameters. https://bugs.webkit.org/show_bug.cgi?id=54051 * DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventX11): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::displayInvalidatedRegion): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_handle_event): 2011-05-17 Tony Chang Reviewed by Ojan Vafai. [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux https://bugs.webkit.org/show_bug.cgi?id=60895 Update the tools to handle the move. Lucid 32 results now go in chromium-linux-x86 and the default platform on Linux is now x86_64. * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid * Scripts/webkitpy/layout_tests/port/base.py: ditto * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup. 2011-05-17 Adam Roben Make run-api-tests work on Windows when there are spaces in the path Fixes REGRESSION (r86511): run-api-tests fails if there are spaces in the path to TestWebKitAPI.exe Reviewed by David Levin. * Scripts/run-api-tests: (runTestTool): Use the "direct object" form of system() to avoid having the path to TestWebKitAPI.exe be split by the shell. 2011-05-16 Ian Henderson Reviewed by Joseph Pecoraro. Page::goToItem doesn't work while loading is deferred https://bugs.webkit.org/show_bug.cgi?id=60412 Add setDefersLoading and goBack methods to LayoutTestController. We need to use goBack() instead of history.back() because the latter goes through NavigationScheduler, hence doesn't exhibit the bug. * DumpRenderTree/LayoutTestController.cpp: (goBackCallback): (setDefersLoadingCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading): 2011-05-16 Sam Weinig Reviewed by Anders Carlsson. TestWebKitAPI should build with clang if it can https://bugs.webkit.org/show_bug.cgi?id=60918 * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Update CompilerVersion.xcconfig to match others. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add CompilerVersion.xcconfig to the project. * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: (TestWebKitAPI::didSameDocumentNavigationForFrame): Add some casts to quiet warnings from clang. 2011-05-16 Dirk Pranke Reviewed by David Levin. add dpranke as a reviewer https://bugs.webkit.org/show_bug.cgi?id=60919 * Scripts/webkitpy/common/config/committers.py: 2011-05-16 Robert Hogan Reviewed by Anders Carlsson. [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot https://bugs.webkit.org/show_bug.cgi?id=60838 The unix test plugin needs to call the test's NPP_URLNotify rather than the browsers. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_url_notify): 2011-05-16 Brent Fulgham Rubber-stamped by Adam Roben. Adding myself as a reviewer. * Scripts/webkitpy/common/config/committers.py: 2011-05-16 Sam Weinig Fix typo pointed out by Dave Levin. * TestWebKitAPI/PlatformUtilities.h: (TestWebKitAPI::Util::assertWKStringEqual): Strig -> String. 2011-05-16 Sam Weinig Reviewed by David Levin. Convert api tester over to using gtest expectations directly https://bugs.webkit.org/show_bug.cgi?id=60862 * TestWebKitAPI/PlatformUtilities.cpp: (TestWebKitAPI::Util::toSTD): * TestWebKitAPI/PlatformUtilities.h: (TestWebKitAPI::Util::assertWKStrigEqual): Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make the implementation of the macro simpler. * TestWebKitAPI/Test.h: Remove TEST_ASSERT forwarder. [Test changes elided] 2011-05-16 David Kilzer C++ exceptions should not be enabled when building with llvm-gcc-4.2 Reviewed by Mark Rowe. * MiniBrowser/Configurations/Base.xcconfig: Fixed typo. * TestWebKitAPI/Configurations/Base.xcconfig: Ditto. * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. 2011-05-16 Jon Lee Reviewed by Simon Fraser. Can't horizontally scroll iframes and overflow because wheel events are always accepted https://bugs.webkit.org/show_bug.cgi?id=60779 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil. 2011-05-16 Ademar de Souza Reis Jr. Reviewed by Csaba Osztrogonác. [Qt] Tools.pro misses include(common.pri) https://bugs.webkit.org/show_bug.cgi?id=60883 It includes features.pri, which depends on common.pri (the build is not broken today with the default options, but this is the right thing to do). * Tools.pro: 2011-05-15 Dominic Cooney Unreviewed: adding myself to committers.py. * Scripts/webkitpy/common/config/committers.py: 2011-05-15 Daniel Bates Reviewed by Chris Jerdonek. svn-apply can't handle Git diff that only changes executable bit https://bugs.webkit.org/show_bug.cgi?id=60848 Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file that only has an executable bit change. * Scripts/VCSUtils.pm: - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo(). (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards fixing . * Scripts/svn-apply: (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch). * Scripts/svn-unapply: (patch): Ditto. * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: - Updated expected results for test cases to account for numTextChunks. - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff". - Added test case "Git: file that only has an executable bit change". * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: - Updated expected results for test cases to account for numTextChunks. 2011-05-15 Sam Weinig Fix windows build. * TestWebKitAPI/win/main.cpp: (main): 2011-05-15 Sam Weinig Reviewed by David Levin. Make API tester more gtest friendly https://bugs.webkit.org/show_bug.cgi?id=60859 * Scripts/run-api-tests: Numerous changes: - Remove logic to run tests one at a time. - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to the test runner and allow gtest to print it for us. - Forward stdout from the test tool to stdout, even in non-verbose runs. - Run test tool from the current working directory instead of the root webkit directory. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Move plist to be with other bundle sources. * TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::run): * TestWebKitAPI/TestsController.h: * TestWebKitAPI/mac/main.mm: Simplify TestController down to a single run function. We should consider removing the class entirely at some point. 2011-05-15 Sheriff Bot Unreviewed, rolling out r86504. http://trac.webkit.org/changeset/86504 https://bugs.webkit.org/show_bug.cgi?id=60853 "Broke Qt EventSender in editing/selection tests" (Requested by mwenge on #webkit). * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::initJSObjects): * DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::eventSender): * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event): 2011-05-12 Robert Hogan Reviewed by Benjamin Poulain. [Qt] fix http/tests/plugins/plugin-document-has-focus.html The support for this test added to the unix test plugin here may allow other platforms to pass it (nearly everyone skips it). On Qt it required a bit of trickiness with the page's EventSender object to get it working fully though, so only unskipping Qt here. https://bugs.webkit.org/show_bug.cgi?id=60722 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::eventSender): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event): 2011-05-14 Arno Renevier Reviewed by Martin Robinson. make run-gtk-tests executable https://bugs.webkit.org/show_bug.cgi?id=59278 * Scripts/run-gtk-tests: 2011-05-14 Anders Carlsson Reviewed by Kevin Decker. NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load https://bugs.webkit.org/show_bug.cgi?id=60823 Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added. (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad): (GetURLNotifyWithURLThatFailsToLoad::NPP_New): (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify): * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: * GNUmakefile.am: 2011-05-14 Sheriff Bot Unreviewed, rolling out r86476. http://trac.webkit.org/changeset/86476 https://bugs.webkit.org/show_bug.cgi?id=60832 It made plugins/get-url-notify-with-url-that-fails-to- load.html crash on GTK (Requested by Ossy on #webkit). * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: * GNUmakefile.am: 2011-05-13 Anders Carlsson Reviewed by Sam Weinig. NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load https://bugs.webkit.org/show_bug.cgi?id=60823 Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added. (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad): (GetURLNotifyWithURLThatFailsToLoad::NPP_New): (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify): * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: * GNUmakefile.am: 2011-05-13 Anders Carlsson Build fix. * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: 2011-05-13 Anders Carlsson Reviewed by Sam Weinig. NPN_GetURL with a javascript: URL doesn't send back the result in the stream https://bugs.webkit.org/show_bug.cgi?id=60810 Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: * GNUmakefile.am: Add files. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added. (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL): (GetURLWithJavaScriptURL::NPP_New): (GetURLWithJavaScriptURL::NPP_NewStream): (GetURLWithJavaScriptURL::NPP_DestroyStream): (GetURLWithJavaScriptURL::NPP_WriteReady): (GetURLWithJavaScriptURL::NPP_Write): * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_NewStream): (NPP_WriteReady): (NPP_Write): (NPP_URLNotify): call the PluginTest NPP wrappers. 2011-05-13 Sheriff Bot Unreviewed, rolling out r86447. http://trac.webkit.org/changeset/86447 https://bugs.webkit.org/show_bug.cgi?id=60809 "Broke some uses of EventSender object on Qt" (Requested by mwenge on #webkit). * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow): * DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::eventSender): * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event): 2011-05-13 Robert Hogan Reviewed by Benjamin Poulain. [Qt] fix http/tests/plugins/plugin-document-has-focus.html The support for this test added to the unix test plugin here may allow other platforms to pass it (nearly everyone skips it). On Qt it required a bit of trickiness with the page's EventSender object to get it working fully though, so only unskipping Qt here. https://bugs.webkit.org/show_bug.cgi?id=60722 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::eventSender): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event): 2011-05-13 Adam Roben Exclude the Leopard NRWT bot from the core builder set Fixes Leopard Intel Release (NRWT) shouldn't be a core builder Reviewed by Darin Adler. * Scripts/webkitpy/common/net/buildbot/buildbot.py: (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots in the core builder set. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and regexps. 2011-05-13 Adam Roben Group all the NRWT bots together This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT bots are experimental, it seems best not to clutter up the non-experimental bots with experimental ones. Fixes New "(NRWT)" bots are right in the middle of Apple's bots on build.webkit.org Reviewed by Dan Bernstein. * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the Chromium testers, which also use new-run-webkit-tests. 2011-05-13 Adam Roben Add a plugin test that dumps the plugin window's rect Part of the test for REGRESSION (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled Reviewed by Dan Bernstein. * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added. (DumpWindowRect::DumpWindowRect): Just call up to the base class. (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test harness window and log it. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect. 2011-05-13 Adam Roben Move code required for most tests of plugin window geometry into a base class WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By having all the trickiness in a shared base class, writing new window geometry tests will be much easier. Fixes It's hard to write tests that check plugin window geometry Reviewed by Anders Carlsson. * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new WindowGeometryTest base class. Most of the code from this class was moved to the new base class. (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion. This is called by the base class when it is safe to check the window's geometry. Note that the m_didCheckWindowRegion logic was removed completely; it has never been needed and was just vestigial code from an earlier version of this test. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new WindowGeometryTest class. * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from WindowRegionIsSetToClipRect. (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect. We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion. Subclasses can implement that function to perform their own tests. * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added. 2011-05-13 Zoltan Herczeg Reviewed by Csaba Osztrogonác. Missing 2nd #EOF if WebProcess is killed. https://bugs.webkit.org/show_bug.cgi?id=60761 If the WebProcess is killed, only one #EOF is yielded by WebKitTestRunner. However, run-webkit-test wait for a second #EOF, which signals the finishing of pixel dump. Since this never happens, run-webkit-test waits forever. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dump): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): * WebKitTestRunner/TestInvocation.h: 2011-05-13 Kristóf Kosztyó Reviewed by Csaba Osztrogonác. [NRWT] chromium-linux tests shouldn't run on other platforms https://bugs.webkit.org/show_bug.cgi?id=60162 Remove _tests_for_other_platforms defs because r82753 implemented it properly in the baseclass in webkit.py. * Scripts/webkitpy/layout_tests/port/gtk.py: * Scripts/webkitpy/layout_tests/port/qt.py: * Scripts/webkitpy/layout_tests/port/win.py: 2011-05-12 Ryuan Choi Reviewed by Antonio Gomes. [EFL] Remove unused option of EWeblauncher https://bugs.webkit.org/show_bug.cgi?id=60747 Remove sudo-workaround option. This option is not used and make other option wrong. * EWebLauncher/main.c: 2011-05-12 Lucas Forschler Reviewed by Stephanie Lewis. Fix config.json to address missing WK2 builder/tester config. Fix naming of machines (xserve not macpro) * BuildSlaveSupport/build.webkit.org-config/config.json: 2011-05-12 Lucas Forschler Reviewed by Stephanie Lewis. Add SnowLeopard Debug builder and Test bot. apple-xserve-8 = SL Debug Tester. apple-xserve-9 = SL Debug Builder. * BuildSlaveSupport/build.webkit.org-config/config.json: 2011-05-12 Adam Barth This patch disables sheriffbot's bug postings. He's just been way too spammy recently due to test flakiness. * Scripts/webkitpy/tool/commands/sheriffbot.py: * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 2011-05-11 Brian Weinstein Reviewed by Anders Carlsson. After relaunching an unresponsive web process, web page stops responding to mouse movement https://bugs.webkit.org/show_bug.cgi?id=60669 This test follows the steps needed to reproduce this bug: 1) Hang the web process 2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event) 3) Kill and restart the WebProcess 4) Move the mouse We are testing that we receive mouse move events after the WebProcess has restarted. * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added. (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading. (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive. (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process. (TestWebKitAPI::setPageLoaderClient): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added. (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest): (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage): * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added. * TestWebKitAPI/PlatformWebView.h: * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move. * TestWebKitAPI/win/PlatformWebViewWin.cpp: (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto. Add new files. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/win/TestWebKitAPI.vcproj: * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: * TestWebKitAPI/win/copy-resources.cmd: 2011-05-12 Tomasz Morawski Reviewed by Antonio Gomes. [EFL] Added initialization/shutdown for ecore_file library https://bugs.webkit.org/show_bug.cgi?id=60457 Added initialization and shuthown for ecore_file library and replaced realpath function to ecore_file_realpath. * EWebLauncher/main.c: (quit): (findThemePath): (main): 2011-05-12 Young Han Lee Reviewed by Kenneth Rohde Christiansen. [Qt] Implement layoutTestController.layerTreeAsText() https://bugs.webkit.org/show_bug.cgi?id=60367 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::layerTreeAsText): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2011-05-11 Eric Seidel Reviewed by David Levin. Teach validate-committer-lists how to validate committers bugzilla_email() https://bugs.webkit.org/show_bug.cgi?id=60651 It turns out we currently have 9 committers with invalid values for their bugzilla_email field (meaning we don't know what email is their bugzilla account). "Alexander Kellett" "Andre Boule" "Cameron McCormack" "Chris Petersen" "Eli Fidler" "Matt Lilek" "Pierre d'Herbemont" "Scott Violet" "Adam Treat" Most of those haven't committed in a very long time, so it's not suprising that we haven't noticed that their bugzilla emails are bogus. * Scripts/validate-committer-lists: * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: 2011-05-11 Dmitry Lomov Reviewed by David Levin. https://bugs.webkit.org/show_bug.cgi?id=59561 Switch TestWebKitAPI to GTest Fixes Makefiles and WinCairo build as well * Makefile: * Scripts/build-api-tests: * Scripts/run-api-tests: * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: * TestWebKitAPI/Test.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::dumpTestNames): (TestWebKitAPI::TestsController::runTestNamed): (TestWebKitAPI::TestsController::runAllTests): * TestWebKitAPI/TestsController.h: * TestWebKitAPI/mac/main.mm: (main): 2011-05-11 Eric Seidel Reviewed by Alexey Proskuryakov. Add Luke Macpherson to committers.py as a Contributor https://bugs.webkit.org/show_bug.cgi?id=60639 * Scripts/webkitpy/common/config/committers.py: 2011-05-11 Noam Rosenthal Reviewed by Kenneth Rohde Christiansen. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch https://bugs.webkit.org/show_bug.cgi?id=60439 Patch 4/12: Update the build script to enable 3D rendering by default for Qt. * Scripts/build-webkit: 2011-05-11 Brian Weinstein Reviewed by Adam Roben. REGRESSION (r86161): WKPreferences API test failing on Windows https://bugs.webkit.org/show_bug.cgi?id=60658 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: (TestWebKitAPI::TEST): 2011-05-11 Alice Boxhall Reviewed by Ojan Vafai. Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON. https://bugs.webkit.org/show_bug.cgi?id=60521 First steps towards making the results JSON all hierarchical. * TestResultServer/model/jsonresults.py: * TestResultServer/model/jsonresults_unittest.py: 2011-05-11 Kevin Ollivier [wx] Build fix, adding new LayoutTestController method stubs. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::localStorageDiskUsageForOrigin): (LayoutTestController::applicationCacheDiskUsageForOrigin): 2011-05-11 Jessie Berlin Reviewed by Darin Adler. [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information about the usage for both the origin overall and the database in question. https://bugs.webkit.org/show_bug.cgi?id=60573 * WebKitTestRunner/TestController.cpp: (WTR::exceededDatabaseQuota): 2011-05-10 Stephen White Reviewed by David Levin. Adding myself as a reviewer. https://bugs.webkit.org/show_bug.cgi?id=60587 * Scripts/webkitpy/common/config/committers.py: 2011-05-11 Eric Seidel Reviewed by Csaba Osztrogonác. queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit https://bugs.webkit.org/show_bug.cgi?id=60614 AppEngine has a result limit of 1000. We hit that when trying to find out how many patches the style-queue (and other queues) have passed in the last 30 days. So lets display 1000+ instead of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.) I also made the status pages show "never" instead of just "ago" when we haven't seen a pass or boot message in the last 1000 messages. * QueueStatusServer/handlers/queuestatus.py: * QueueStatusServer/templates/queuestatus.html: 2011-05-11 Adam Barth Reviewed by Eric Seidel. sheriffbot shouldn't spam bugs when it can't figure out who to blame https://bugs.webkit.org/show_bug.cgi?id=60613 This patch limits the number of bugs sheriffbot will spam to three. Ideally, we'd come up with some smarter huerstics, but hopefully this will cut down on the bugmail spam for slow bots. * Scripts/webkitpy/tool/commands/sheriffbot.py: 2011-05-10 Eric Seidel Reviewed by Adam Barth. EWS bots should be robust against test-webkitpy hangs https://bugs.webkit.org/show_bug.cgi?id=60579 Added a killAfterTimeout subroutine, which takes a child_pid and timeout, and will setup a watchdog process to kill that child after the timeout. killAfterTimeout will waitpid on the child. * EWSTools/start-queue.sh: 2011-05-10 MORITA Hajime Unreviewed, moved myself to the reviewers list. * Scripts/webkitpy/common/config/committers.py: 2011-05-10 Anton D'Auria Reviewed by David Levin. StorageTracker should report actual local storage usage on disk https://bugs.webkit.org/show_bug.cgi?id=60558 * DumpRenderTree/LayoutTestController.cpp: (localStorageDiskUsageForOriginCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::localStorageDiskUsageForOrigin): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::localStorageDiskUsageForOrigin): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::localStorageDiskUsageForOrigin): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::localStorageDiskUsageForOrigin): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::localStorageDiskUsageForOrigin): 2011-05-10 Anton D'Auria Reviewed by Alexey Proskuryakov. Add ApplicationCache API to get disk usage per origin https://bugs.webkit.org/show_bug.cgi?id=57127 Added test that loads two frames with ~15Kb image, checks usage, deletes app cache, verifies usage is 0. * DumpRenderTree/LayoutTestController.cpp: (applicationCacheDiskUsageForOriginCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub. (LayoutTestController::LayoutTestController): (LayoutTestController::applicationCacheDiskUsageForOrigin): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::applicationCacheDiskUsageForOrigin): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin): 2011-05-10 Lucas De Marchi Unreviewed, adding Rafael Antognolli as a committer. * Scripts/webkitpy/common/config/committers.py: 2011-05-10 Chris Evans Reviewed by Adam Barth. Add WebCore::Setting to block displaying and/or running insecure content on secure pages https://bugs.webkit.org/show_bug.cgi?id=58378 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setAllowDisplayOfInsecureContent): (LayoutTestController::setAllowRunningOfInsecureContent): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: Add plumbing for new settings to Chromium DRT. 2011-05-10 Enrica Casucci Reviewed by Beth Dakin. Added my name to the reviewers list and removed my name from to committer-only list. * Scripts/webkitpy/common/config/committers.py: 2011-05-10 David Levin Reviewed by Shinichiro Hamaji. check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers. https://bugs.webkit.org/show_bug.cgi?id=60466 * Scripts/webkitpy/style/checker.py: (unrelated) style fix. * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since that property was removed. * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line filtering for errors. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to verify that the line filtering is turned off. * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors and remove the unused file_path parameter. * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the line filtering is turned off (and fix test_no_error). * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering of errors based on the lines changed in the patch. * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off the filtering. 2011-05-10 Adam Roben Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows Fixes REGRESSION (r85795): platform/win/plugins/window-geometry-initialized-before-set-window.html and platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release (WebKit2 Tests) Reviewed by Anders Carlsson. * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new WindowedPluginTest::testHarnessWindow function. * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not its position. In WebKit2, the position won't have been set yet, so we can't test it. But it turns out only the size mattered for , which this test was created for. * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a WindowedPluginTest, and initialized new members. (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible. (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect, then clean up and tell the test harness we're done. (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog(). (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own window becomes visible. (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window if it was hidden at the start of the test. (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint. This should cause our window to become visible and our window region to get set. When we get a WM_WINDOWPOSCHANGED message, we can finally finish the test. (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object. (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method: "startTest". (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object. * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: (WindowedPluginTest::testHarnessWindow): * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow. 2011-05-10 Csaba Osztrogonác Reviewed by Kenneth Rohde Christiansen. [Qt] Add new qt-4.8 platform for layout testing https://bugs.webkit.org/show_bug.cgi?id=60544 * Scripts/old-run-webkit-tests: * Scripts/webkitdirs.pm: 2011-05-09 Sheriff Bot Unreviewed, rolling out r86108. http://trac.webkit.org/changeset/86108 https://bugs.webkit.org/show_bug.cgi?id=60533 Broke makefile based builds and Cairo (Requested by weinig on #webkit). * Scripts/build-api-tests: * Scripts/run-api-tests: * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: * TestWebKitAPI/Test.h: (TestWebKitAPI::Test::~Test): (TestWebKitAPI::Test::name): (TestWebKitAPI::Test::Register::Register): (TestWebKitAPI::Test::Register::create): (TestWebKitAPI::Test::Test): * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::dumpTestNames): (TestWebKitAPI::TestsController::runTestNamed): (TestWebKitAPI::TestsController::testFailed): (TestWebKitAPI::TestsController::registerCreateTestFunction): * TestWebKitAPI/TestsController.h: * TestWebKitAPI/mac/main.mm: (main): 2011-05-09 Hayato Ito Reviewed by Ojan Vafai. Skip reftests if pixel tests are disabled. https://bugs.webkit.org/show_bug.cgi?id=59078 * Scripts/webkitpy/layout_tests/layout_package/manager.py: * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: * Scripts/webkitpy/layout_tests/layout_package/worker.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: 2011-05-09 Chang Shu Reviewed by Kenneth Rohde Christiansen. [Qt] DumpRenderTreeQt needs an implementation of unmarkText https://bugs.webkit.org/show_bug.cgi?id=60499 The implementation is similar to gtk. * DumpRenderTree/qt/TextInputControllerQt.cpp: (TextInputController::unmarkText): * DumpRenderTree/qt/TextInputControllerQt.h: 2011-05-09 James Robinson Reviewed by Eric Seidel. [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux https://bugs.webkit.org/show_bug.cgi?id=60520 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 2011-05-09 Dmitry Lomov Reviewed by Sam Weinig. Switch TestWebKitAPI to GTest https://bugs.webkit.org/show_bug.cgi?id=59561 * Scripts/build-api-tests: * Scripts/run-api-tests: * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: * TestWebKitAPI/Test.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::dumpTestNames): (TestWebKitAPI::TestsController::runTestNamed): (TestWebKitAPI::TestsController::runAllTests): * TestWebKitAPI/TestsController.h: * TestWebKitAPI/mac/main.mm: (main): 2011-05-09 Igor Oliveira Reviewed by Andreas Kling. [Qt] DRT eventSender.addTouchPoint method is not setting the start position https://bugs.webkit.org/show_bug.cgi?id=60487 When adding a new touch point, the start position of this point needs to be set. * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::addTouchPoint): 2011-05-09 Robert Hogan Reviewed by Adam Roben. https://bugs.webkit.org/show_bug.cgi?id=57137 Unskip plugins/embed-prefers-plugins-for-images.html Add image/png mime-type to test netscape plugin on Unix. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_GetMIMEDescription): 2011-05-09 Alice Boxhall Reviewed by Ojan Vafai. Pull jsonresults_unittest test cases out into separate test methods. https://bugs.webkit.org/show_bug.cgi?id=60418 * TestResultServer/model/jsonresults_unittest.py: 2011-05-09 Mahesh Kulkarni Reviewed by Andreas Kling. [Qt] fix fast/dom/Geolocation/window-close-crash.html https://bugs.webkit.org/show_bug.cgi?id=60458 Update all pages with Mock position/error/permission. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setMockGeolocationPosition): 2011-05-09 Shishir Agrawal Reviewed by Tony Gentilcore. Implement Page Visibility API. https://bugs.webkit.org/show_bug.cgi?id=54181 * DumpRenderTree/LayoutTestController.cpp: (setPageVisibilityCallback): (resetPageVisibilityCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController::setPageVisibility): (LayoutTestController::resetPageVisibility): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::resetPageVisibility): (LayoutTestController::setPageVisibility): * DumpRenderTree/chromium/LayoutTestController.h: 2011-05-07 Adam Barth Reviewed by Eric Seidel. Testing EWS spins on patches with a large number of failures https://bugs.webkit.org/show_bug.cgi?id=60441 In cases where the tree has a small number of persistent failures but a patch has a large number of failures, we weren't believing any results. That lead to us retrying the patch forever while we waited for trustworthy results that would never come. This patch loosens the semantics of unexpected_failures to return a subset (rather than the exact set) of unexpected failures. In the case where the tree has a bounded number of failures and the patch has an unbounded number of failures, we can accurately compute such a subset and reject the patch. * Scripts/webkitpy/tool/bot/expectedfailures.py: * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: * Scripts/webkitpy/tool/bot/patchanalysistask.py: * Scripts/webkitpy/tool/commands/earlywarningsystem.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 2011-05-07 Joe Mason Reviewed by Daniel Bates. FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect https://bugs.webkit.org/show_bug.cgi?id=52211 Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended. (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.) * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willPerformClientRedirect): (WebViewHost::didStartProvisionalLoad): * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): 2011-05-07 Daniel Bates Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007 (bug #60438). * Scripts/old-run-webkit-tests: - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and file local variable. 2011-05-07 Pratik Solanki Reviewed by Darin Adler. Remove references to Tiger in scripts https://bugs.webkit.org/show_bug.cgi?id=60438 Remove isTiger() and all of the code that depends on it. * Scripts/build-webkit: * Scripts/ensure-valid-python: * Scripts/gdb-safari: * Scripts/webkitdirs.pm: 2011-05-06 David Grogan Reviewed by Eric Seidel. update link to message about mac 64bit git binaries https://bugs.webkit.org/show_bug.cgi?id=60411 The original message implied (correctly, at-the-time) that http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit binaries. The new message notes that they do. This might prevent someone else from spending a few minutes confused. * Scripts/webkitpy/common/checkout/scm/git.py: 2011-05-06 Dirk Pranke Reviewed by Ojan Vafai. new-run-webkit-tests: crashes in race with crashing DRT https://bugs.webkit.org/show_bug.cgi?id=60238 This fixes a race where if we wrote the URL to DRT and DRT crashed immediately, we could get a broken pipe error back during the write() and not handle it correctly, causing NRWT to also crash. * Scripts/webkitpy/layout_tests/port/server_process.py: * Scripts/webkitpy/layout_tests/port/webkit.py: 2011-05-06 Adam Barth Reviewed by Eric Seidel. Add a --skip-integrationtests mode to test-webkitpy https://bugs.webkit.org/show_bug.cgi?id=60354 These two test suites account for 2/3 of test-webkitpy's running time because they're not actually unit tests. They're integration tests. This patch adds the ability to skip integration tests by passing a command line argument to test-webkitpy. The buildbots will continue to run these integration tests to make sure they don't regress. This option is for use by developers when working on parts of the code that are well-covered by unit tests. * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py. * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed. * Scripts/webkitpy/test/main.py: 2011-05-06 Adam Barth Reviewed by Eric Seidel. The results.zip generated by the Chromium EWS are too big https://bugs.webkit.org/show_bug.cgi?id=60352 Currently results.zip created by the Chromium EWS bot contain roughly 1000 tests that we expect to fail. These test results are not helpful to contributors. There are several approaches to solving this problem: 1) We could be more selective about which files to include in the zip. 2) We could ask new-run-webkit-tests not to generate results for expected failures. 3) We could ask new-run-webkit-tests not to run tests that we expect to fail. This patch takes approach (3). Currently, we're ignoring the outcome of failing tests anyway, so there's not much point in actually running them. As a side benefit, this will speed up the test run by about 6%. In the future, we might revisit this decision and choose another approach. * Scripts/webkitpy/common/config/ports.py: * Scripts/webkitpy/common/config/ports_unittest.py: 2011-05-06 Gabor Rapcsanyi Reviewed by Csaba Osztrogonác. [Qt] Use qt-arm platform instead of qt-linux on ARM platform. * Scripts/old-run-webkit-tests: 2011-05-06 Adam Barth Reviewed by Ojan Vafai. Add an option to NRWT to skip failing tests https://bugs.webkit.org/show_bug.cgi?id=60295 This option is similar to the way old-run-webkit-tests works. We're planning to use this option on the testing EWS bots because they don't use information from failing tests yet. * Scripts/webkitpy/layout_tests/layout_package/manager.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2011-05-04 Philippe Normand Reviewed by Dimitri Glazkov. Implement LayoutTestController::pseudoShadowId() https://bugs.webkit.org/show_bug.cgi?id=60034 shadowPseudoId support in the various LayoutTestController implementations. * DumpRenderTree/LayoutTestController.cpp: (shadowPseudoIdCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::shadowPseudoId): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowPseudoId): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::shadowPseudoId): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::shadowPseudoId): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::shadowPseudoId): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::shadowPseudoId): * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowPseudoId): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2011-05-06 Adam Barth EWS can't reject patches https://bugs.webkit.org/show_bug.cgi?id=60345 We're supposed to use patch.id() for the attachment ID, silly. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 2011-05-05 Steve Lacey Reviewed by Ojan Vafai. Fix generation of results html file by passing relative path to scm methods. Generate diff images for results html file. https://bugs.webkit.org/show_bug.cgi?id=60086 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 2011-05-05 Andy Estes Reviewed by Daniel Bates. update-webkit should handle Internal using a different VCS than OpenSource. https://bugs.webkit.org/show_bug.cgi?id=60310 isGit() and isSVN() cache their results, so Internal will always be updated using the VCS commands used for OpenSource. If Internal uses a different VCS, this will fail. Fix this by calling isGitDirectory() and isSVNDirectory() instead, which do not cache their results. * Scripts/update-webkit: 2011-05-05 Dirk Pranke Reviewed by Ojan Vafai. nrwt: revamp integration tests incl. tests for servers https://bugs.webkit.org/show_bug.cgi?id=59985 This change adds the ability to run "integration tests" that depend on (and affect) the local environment on your machine. These tests can be run manually by invoking python on the test file in question and passing the '-i' flag, but are not run automatically as part of test-webkitpy. Integration tests are identified by being methods named as "integration_test_*" instead of "test_*", and we use a custom TestLoader instead of the default one provided by unittest. This change also adds a protected "_default_to_apache" method to the port object so we can do the right thing when starting and stopping web servers with less mechanism. * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: * Scripts/webkitpy/layout_tests/port/mac_unittest.py: * Scripts/webkitpy/layout_tests/port/port_testcase.py: 2011-05-05 Adam Roben Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the alpha channel will even get filled with zeros (like when ::GradientFill is used). To safeguard against this, we fill the alpha channel with constant full opacity after the WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel results need an alpha channel, too.) Fixes draws-gradient.html's pixel results can't be correctly generated due to alpha channel weirdness Reviewed by Sam Weinig. * DumpRenderTree/win/PixelDumpSupportWin.cpp: (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with constant full opacity. (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it in a CGContext or cairo_surface. 2011-05-05 Adam Roben Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner Passing true tells the test harness to dump pixels even though we're not dumping a render tree. Fixes Calling layoutTestController.dumpAsText(true) in WebKitTestRunner doesn't result in pixel results being generated Reviewed by Sam Weinig. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels argument to dumpAsText. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Updated for dumpAsText change. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change. * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows developers. 2011-05-05 Dirk Pranke Reviewed by Ojan Vafai. new-run-webkit-tests: merge os, version fields in test config https://bugs.webkit.org/show_bug.cgi?id=60004 This change removes the 'o/s' field from the TestConfiguration object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in the expectations file to macros that expand to the version names for each platform. This means that you can once again put any subset of the operating system versions on a single line, e.g.: BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL This change will break any existing test_expectations.txt file that uses the "OS-VERSION" macros, which are no longer needed. It turns out they were never needed, as just VERSION by itself was sufficient. The test_expectations.txt file should be updated accordingly prior to landing this change. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: * Scripts/webkitpy/layout_tests/port/base.py: 2011-05-05 Tony Chang Reviewed by Adam Barth. [chromium] switch from Lucida to free fonts for Hindi and Thai https://bugs.webkit.org/show_bug.cgi?id=60287 The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts packages on Lucid. There are actually multiple Thai fonts in the package, so I just picked one. * DumpRenderTree/chromium/TestShellGtk.cpp: (setupFontconfig): 2011-05-05 Tony Chang Reviewed by Ojan Vafai. [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results https://bugs.webkit.org/show_bug.cgi?id=60290 It used to be that google-chrome-32 was hardy32, google-chrome-64 was hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was lucid64. Because of that, google-chrome-64 used to skip the chromium-linux-x86_64 results since they were more incorrect. Now that we're switching to lucid for google-chrome, we want google-chrome-64 to fall back to chromium-linux-x86_64. * Scripts/webkitpy/layout_tests/port/google_chrome.py: 2011-05-05 Dirk Pranke Reviewed by Ojan Vafai. new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes https://bugs.webkit.org/show_bug.cgi?id=60002 * Scripts/webkitpy/layout_tests/layout_package/manager.py: * Scripts/webkitpy/layout_tests/layout_package/printing.py: * Scripts/webkitpy/layout_tests/layout_package/result_summary.py: * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: * Scripts/webkitpy/style/checkers/test_expectations.py: 2011-05-05 Eric Seidel Reviewed by Adam Barth. commit-queue should reject patches which fail ewses https://bugs.webkit.org/show_bug.cgi?id=47534 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: * Scripts/webkitpy/tool/commands/earlywarningsystem.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 2011-05-05 Chang Shu Reviewed by Andreas Kling. [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors https://bugs.webkit.org/show_bug.cgi?id=59638 1. Call QGraphicsWKView constructor with pageGroupRef. 2. Disable setFontFamily calls as it breaks Qt test fonts. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WebView::WebView): (WTR::PlatformWebView::PlatformWebView): 2011-05-05 Joseph Pecoraro Reviewed by David Kilzer. Add --only-webkit option to build-webkit https://bugs.webkit.org/show_bug.cgi?id=60245 * Scripts/build-webkit: If --only-webkit was specified just build the WebKit project, and not its dependencies. 2011-05-05 Jeff Miller Reviewed by Darin Adler. Add didNotHandleWheelEvent callback to WKPageUIClient https://bugs.webkit.org/show_bug.cgi?id=60203 * MiniBrowser/gtk/BrowserWindow.c: (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback. * MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Stub out didNotHandleWheelEvent callback. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback. (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback. 2011-05-04 Eric Seidel Reviewed by Adam Barth. Add more missing imports from scm refactor https://bugs.webkit.org/show_bug.cgi?id=60239 * Scripts/webkitpy/common/checkout/scm/git.py: * Scripts/webkitpy/common/checkout/scm/svn.py: 2011-05-04 Eric Seidel Reviewed by Adam Barth. sheriff-bot is having more exception trouble https://bugs.webkit.org/show_bug.cgi?id=60233 A webpage-forced build was causing SB to throw an exception. We've long had this bug, but we just didn't notice it until now. In debugging this I found we fetch an absurd amount of data now that we use buildbot's json (instead of xmlrpc), so I added the filter=1 parameter to reduce it a little. That required me to handle the case where filter=1 would strip result=0 in some cases (it's unclear why it does that). * Scripts/webkitpy/common/net/buildbot/buildbot.py: * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 2011-05-04 Cris Neckar Unreviewed, Adding Cris Neckar as a committer * Scripts/webkitpy/common/config/committers.py: 2011-05-04 Siddharth Mathur Reviewed by Laszlo Gombos. [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian https://bugs.webkit.org/show_bug.cgi?id=59462 * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 2011-05-04 Eric Seidel Reviewed by Adam Barth. The testing EWS bots should upload layout-test-results.zip to bugs after failures https://bugs.webkit.org/show_bug.cgi?id=60223 This required sharing a bit of code between the commit-queue (which already knew how to do this) and the new EWS testing bots. In the process I also cleaned up EWS testing a little and removed some dead code from the commit-queue. * Scripts/webkitpy/common/config/committervalidator.py: * Scripts/webkitpy/tool/commands/earlywarningsystem.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2011-05-04 James Kozianski Reviewed by Eric Seidel. Add method to make a Port able to retrieve TestOutputSets from its builders. https://bugs.webkit.org/show_bug.cgi?id=58211 This will be used in the new rebaseline script - TestOutputs are potential new baselines. * Scripts/webkitpy/common/config/urls.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/factory.py: * Scripts/webkitpy/layout_tests/port/webkit.py: 2011-05-04 Eric Seidel Reviewed by Ojan Vafai. sheriff-bot can't parse results.html https://bugs.webkit.org/show_bug.cgi?id=60196 The problem was that the NRWT bots are currently core and so sheriff-bot was trying to diagnose failures on them. It was trying to parse their results.html file and BeautifulSoup was throwing an exception. It seems our version of BeautifulSoup was quite old and unable to handle