2011-09-05 Adam Barth Add a tab to garden-o-matic for viewing expected failures https://bugs.webkit.org/show_bug.cgi?id=67619 Reviewed by Dimitri Glazkov. This patch adds a basic tab to garden-o-matic that shows all the tests failing on the bots, including the expected failures. This patch mostly involves refactoring existing classes to allow new subclasses. This view is useful for when gardeners mark tests as expected to fail and then rebaseline them later. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: 2011-09-05 Adam Barth Fix global variable leak in garden-o-matic https://bugs.webkit.org/show_bug.cgi?id=67617 Reviewed by Dimitri Glazkov. Caught by running the unit tests with noglobals turned on. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: 2011-09-05 Balazs Kelemen [Qt][WK2] Add pixel test support https://bugs.webkit.org/show_bug.cgi?id=66283 Reviewed by Andreas Kling. Implemented pixel result generation by reusing the logic that we have in DumpRenderTree. * WebKitTestRunner/qt/TestInvocationQt.cpp: (WTR::dumpImage): (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): 2011-09-04 Robin Dunn [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK. https://bugs.webkit.org/show_bug.cgi?id=67577 Reviewed by Kevin Ollivier. * waf/build/settings.py: 2011-09-03 Kevin Ollivier [wx] Unreviewed build fix. Add wtf/dtoa directory to build. * waf/build/settings.py: 2011-09-03 Dan Bernstein 32-bit build fix. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: (TestWebKitAPI::Util::toSTD): 2011-09-03 Dan Bernstein Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=67559 Reviewed by Darin Adler. * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed the call to it. * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *) * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm. * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added. (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: (TestWebKitAPI::Util::toSTD): Added. 2011-09-03 Adam Barth garden-o-matic results view should have a better results selector https://bugs.webkit.org/show_bug.cgi?id=67542 Reviewed by Dimitri Glazkov. This patch adds a basic grid-based results selector to the results view. Currently, this grid just shows how the tests fail on the various bots. A future patch will let you select which failure to view and to mark the failures for rebaselining. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: - Add some more basic functions for manipulating dictionaries. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: 2011-09-03 Adam Barth garden-o-matic results view should show Actual and Expected results for text failures https://bugs.webkit.org/show_bug.cgi?id=67536 Reviewed by Eric Seidel. In the past, we didn't show actual and expected text results (we just showed the diff) because we didn't have the awesome six-by-two results grid. Now that we do, we can move show these results. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: - Fixed some typos that were preventing these unit tests from running. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: (.): * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: - Report -actual.txt and -expected.txt as possible results URLs. 2011-09-03 Adam Barth garden-o-matic shows "ghost" failures that are already fixed https://bugs.webkit.org/show_bug.cgi?id=67535 Reviewed by Eric Seidel. About 10% of writes fail to stick on test-results.appspot.com. This patch causes us to fetch the full_results.json blob directly from build.chromium.org rather than relying upon AppEngine. Unforuntately, we still need to get historical information from AppEngine. That will take several patches to fix becuase I need to change the bots to write the full_results.json file to the build-specific directory in addition to the zip file. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: 2011-09-03 Sheriff Bot Unreviewed, rolling out r94458. http://trac.webkit.org/changeset/94458 https://bugs.webkit.org/show_bug.cgi?id=67558 Caused appcache test to fail on various bots (Requested by rniwa on #webkit). * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: 2011-09-03 Sheriff Bot Unreviewed, rolling out r94453. http://trac.webkit.org/changeset/94453 https://bugs.webkit.org/show_bug.cgi?id=67557 Caused appcache test to fail on various bots (Requested by rniwa on #webkit). * Scripts/webkitpy/layout_tests/port/webkit.py: 2011-09-02 Michael Saboff Add JSC:RegExp functional tests https://bugs.webkit.org/show_bug.cgi?id=67339 New perl script to build JavaScriptCore and run the RegExp tests. Reviewed by Gavin Barraclough. * Scripts/run-regexp-tests: Added. 2011-09-02 Michael Saboff Add JSC:RegExp functional tests https://bugs.webkit.org/show_bug.cgi?id=67339 New perl script to build JavaScriptCore and run the RegExp tests. Reviewed by Gavin Barraclough. * Scripts/run-regexp-tests: Added. 2011-09-02 Eric Seidel Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately https://bugs.webkit.org/show_bug.cgi?id=67530 Unreviewed. Fixing typo from previous commit. Turns out there was *no* unittesting of WebKitDriver. Added a basic test of _read_block which exercises the code I previously made a typo in. * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: 2011-09-02 Eric Seidel Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately https://bugs.webkit.org/show_bug.cgi?id=67530 Reviewed by Adam Barth. No functional change, just reshuffling code. * Scripts/webkitpy/layout_tests/port/webkit.py: 2011-09-02 Darin Adler Added Subversion ignore for .pyc generated files. * Scripts/webkitpy/layout_tests/models: Added property svn:ignore. * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore. * Scripts/webkitpy/tool/servers: Added property svn:ignore. 2011-09-02 Adam Barth Enable testing on mac-ews https://bugs.webkit.org/show_bug.cgi?id=67505 Reviewed by Eric Seidel. This patch enables testing on the Mac EWS, which should help contributors not turn the Mac bots red. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 2011-09-01 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=67451 Add a test for going back to a cached page after changing the device scale factor Reviewed by Adam Roben. New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added. (TestWebKitAPI::DeviceScaleFactorOnBack::url): (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL): (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow): (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView): (TestWebKitAPI::DeviceScaleFactorOnBack::runTest): (TestWebKitAPI::TEST_F): Added new function to WebKitAgnosticTest to goBack. Separated waitForLoadToFinish() into its own function (instead of being a part of loadAndWaitUntilFinished()) so that it can be called from goBack as well. Also added initializeView() so we can set the cache model. * TestWebKitAPI/mac/WebKitAgnosticTest.h: (TestWebKitAPI::WebKitAgnosticTest::initializeView): * TestWebKitAPI/mac/WebKitAgnosticTest.mm: (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest): (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): (TestWebKitAPI::WebKitAgnosticTest::loadURL): (TestWebKitAPI::WebKitAgnosticTest::goBack): (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish): 2011-09-02 Anders Carlsson Build fix. * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: (PrivateBrowsing::ScriptableObject::pluginTest): 2011-09-02 Anders Carlsson Move private browsing test to a PluginTest subclass https://bugs.webkit.org/show_bug.cgi?id=67498 Reviewed by Darin Adler. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginGetProperty): * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPP_SetValue): * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added. (PrivateBrowsing::PrivateBrowsing): (PrivateBrowsing::privateBrowsingEnabled): (PrivateBrowsing::cachedPrivateBrowsingEnabled): (PrivateBrowsing::ScriptableObject::hasProperty): (PrivateBrowsing::ScriptableObject::getProperty): (PrivateBrowsing::ScriptableObject::pluginTest): (PrivateBrowsing::NPP_New): (PrivateBrowsing::NPP_GetValue): (PrivateBrowsing::NPP_SetValue): * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (NPP_SetValue): * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: * GNUmakefile.am: 2011-09-02 Csaba Osztrogonác [Qt] Build dependency problems https://bugs.webkit.org/show_bug.cgi?id=38054 Trivial fix after r94288. Rubber-stamped by Andras Becsi. * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines. (buildQMakeProject): 2011-09-02 Andras Becsi Remove my old e-mail address and add my new one. Rubber-stamped by Tor Arne Vestbø. * Scripts/webkitpy/common/config/committers.py: 2011-09-02 Philippe Normand [GTK] run-gtk-tests leaves a zombie Xvfb process https://bugs.webkit.org/show_bug.cgi?id=67389 Reviewed by Martin Robinson. * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the child process instead of doing shell redirection. 2011-09-01 Mark Rowe Fix the build by adding some more missing return types. * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): 2011-09-01 Eric Seidel REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT https://bugs.webkit.org/show_bug.cgi?id=66228 Reviewed by Dirk Pranke. ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames. The LeaksViewer tool globs for all *-leaks.txt files. This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match. In order to test this I had to fix a limitation in our MockFileSystem.glob method. However, doing so uncovered a typo and bug in the integration tests. I've disabled the offending integration tests. * Scripts/webkitpy/common/system/filesystem_mock.py: * Scripts/webkitpy/layout_tests/port/leakdetector.py: * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: 2011-09-01 Dominic Mazzoni Adds a LayoutTestController method to make it possible to test starting speech input via an API call. https://bugs.webkit.org/show_bug.cgi?id=60170 Reviewed by Dimitri Glazkov. * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::startSpeechInput): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::startSpeechInput): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::startSpeechInput): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::startSpeechInput): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::startSpeechInput): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::startSpeechInput): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::startSpeechInput): 2011-09-01 Tim Horton Fix TestWebKitAPI build on clang-2.0 * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: 2011-09-01 Adam Barth Remove unused "extension" parameter from rebaseline gardeningserver handler https://bugs.webkit.org/show_bug.cgi?id=67384 Reviewed by James Robinson. This parameter hasn't done anything in a while. * Scripts/webkitpy/tool/commands/rebaseline.py: * Scripts/webkitpy/tool/servers/gardeningserver.py: * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: 2011-09-01 Eric Seidel Unreviewed. Fix a typo in unittests. Unfortunately fixing it caused several assertions. Just disabling the test instead, since it was providing no value before due to the typo. * Scripts/webkitpy/layout_tests/port/test.py: 2011-09-01 Adam Barth Add a "rebaseline" button to the garden-o-matic summary page https://bugs.webkit.org/show_bug.cgi?id=67382 Reviewed by Dimitri Glazkov. As much as we might wish folks to not rebaseline entire test groups at once, the truth is that doing so is a common operation. Adding a button for this operation is likely to make folks happy. This patch also cleans up a bunch of plumbing surrounding failureInfo objects. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: 2011-09-01 Adam Barth garden-o-matic should let the gardener assign blame for a group of test failures https://bugs.webkit.org/show_bug.cgi?id=67379 Reviewed by Dimitri Glazkov. If a group of test failures has a large revision range, the gardener might wish to blame a specific revision for the failure. Currently, this only effect of assigning blame in this way is to hide the other suspect commits. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: 2011-09-01 Adam Barth Hide garden-o-matic failure table until hover https://bugs.webkit.org/show_bug.cgi?id=67376 Reviewed by Dimitri Glazkov. This patch removes the failure table for build failures (because it does not make sense) and hides the failure table for test groups until the user hovers over the test failure block, reducing visual noise. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: 2011-09-01 Adam Barth Switch garden-o-matic from commitData.title to commitData.summary https://bugs.webkit.org/show_bug.cgi?id=67375 Reviewed by Dimitri Glazkov. commitData.title is a string provided by Trac, which isn't great in all cases. commitData.summary is my attempt to find the most important one-line summary of the commit. This patch switches garden-o-matic over to summary. Also, this patch tweaks a bunch of CSS to tighten up the summary page and reduce visual noise. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: 2011-09-01 Adam Barth Group failing tests in garden-o-matic if there are more than three in a folder https://bugs.webkit.org/show_bug.cgi?id=67373 Reviewed by Dimitri Glazkov. Sometimes a failure will cause many tests in a given directory to fail. When that happens, it's better to list the directory as a single item (with a count) rather than spamming all the test names. (This patch also updates a bunch of unit test expected results after my last commit.) * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: 2011-09-01 Adam Barth Lower the visual noise from the failing builders display https://bugs.webkit.org/show_bug.cgi?id=67369 Reviewed by Dimitri Glazkov. This patch ensures that the "Building" row in the failing builders display is always last and dims it by 50% to reduce visual noise. This lets the gardener focus on the actual failures. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added. 2011-09-01 Kristóf Kosztyó [Qt] Build dependency problems https://bugs.webkit.org/show_bug.cgi?id=38054 Make clean build after the defines are changed. Reviewed by Csaba Osztrogonác. * Scripts/webkitdirs.pm: (buildQMakeProject): 2011-08-31 Adam Barth Move DumpRenderTree to WebKitPlatformSupport https://bugs.webkit.org/show_bug.cgi?id=67331 Reviewed by Darin Fisher. This patch update DumpRenderTree to account for the WebKitClient => WebKitPlatformSupport rename. * DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::show): * DumpRenderTree/chromium/Task.cpp: (postTask): 2011-08-31 Eric Seidel Add queues.webkit.org/active-bots page to make it easy to see which bots are down https://bugs.webkit.org/show_bug.cgi?id=67314 Reviewed by Adam Barth. Very simple page. Just lists all the bots, what queue they belong to and what we last heard from them. If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here. This makes it very easy for me to see which of my cr-jail bots might be down at any one time. I also moved a bunch of code into dashboard.css which belonged there. * QueueStatusServer/handlers/activebots.py: Added. * QueueStatusServer/main.py: * QueueStatusServer/stylesheets/dashboard.css: (.queue_bubble): (.queue_name): (.last_heard_from): (.status_text): (.alive): (.behind): (.dead): * QueueStatusServer/templates/activebots.html: Added. * QueueStatusServer/templates/dashboard.html: * QueueStatusServer/templates/recentstatus.html: 2011-08-31 Oliver Hunt Move CheckedArithmeticOperations.cpp to the intended location * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp. 2011-08-31 Elliot Poger add unittest to validate the complete set of Chromium configurations https://bugs.webkit.org/show_bug.cgi?id=67211 Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 2011-08-31 Nico Weber Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled() https://bugs.webkit.org/show_bug.cgi?id=67297 Reviewed by Tony Chang. Explicitly disable smooth scrolling in chromium's DRT. * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): 2011-08-31 Oliver Hunt Add Checked<> tests to windows build * TestWebKitAPI/win/TestWebKitAPI.vcproj: 2011-08-30 Oliver Hunt Add support for checked arithmetic https://bugs.webkit.org/show_bug.cgi?id=67095 Reviewed by Sam Weinig. Add test cases for Checked<> * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added. 2011-08-31 Adam Barth Move summary.html to garden-o-matic.html. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed. 2011-08-31 Noel Gordon [chromium] DRT linux should pass nativeKeyCode to plugins https://bugs.webkit.org/show_bug.cgi?id=66679 Reviewed by Tony Chang. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Call a Chromium Linux GTK helper routine that returns the (simulated) nativeKeyCode for the given input keyboard code. 2011-08-31 Adam Barth Tighen up UI for garden-o-matic tab strip https://bugs.webkit.org/show_bug.cgi?id=67266 Reviewed by Dimitri Glazkov. This patch add CSS to move the tab strip to the edges of the page and to remove some gratuitous border-radius. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: 2011-08-31 Adam Barth garden-o-matic results view shouldn't be horrifically ugly https://bugs.webkit.org/show_bug.cgi?id=67264 Reviewed by Dimitri Glazkov. Minor tweak to the results view CSS to make it fit in better with the new tabbed UI. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: 2011-08-31 Adam Barth garden-o-matic needs a tabstrip https://bugs.webkit.org/show_bug.cgi?id=67263 Reviewed by Dimitri Glazkov. This patch adds a basic tabstrip to garden-o-matic. The results details view now opens in the "Results" tab, and the user can flip back and forth between the Summary and the Results tab quickly. There's also a stub for a "Commits" tab, which is disabled. This patch isn't the most beautiful in the world, but it gets the ball rolling on a multi-modal UI. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: 2011-08-31 Ai Makabi Extract reference links from reftest test file. https://bugs.webkit.org/show_bug.cgi?id=66838 Reviewed by Shinichiro Hamaji. * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added. * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added. * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added. 2011-08-03 Philippe Normand [webkitpy] missing log import in common/net/resultsjsonparser.py https://bugs.webkit.org/show_bug.cgi?id=65606 Reviewed by Martin Robinson. * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module. 2011-08-30 Philippe Normand [stylechecker] complains about NULL usage in some gst_structure_ calls https://bugs.webkit.org/show_bug.cgi?id=67194 Reviewed by Martin Robinson. Don't warn about NULL in some gst_structure_ calls. 0 can't be used for these, a proper sentinel is required. * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2011-08-30 Adam Barth Remove old-style UI from garden-o-matic https://bugs.webkit.org/show_bug.cgi?id=67257 Reviewed by Dimitri Glazkov. This code is nowhere near as awesome as the new hotness. Let's remove it so it doesn't weigh us down. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed. 2011-08-30 Takashi Toyoshima [WebSocket] update pywebsocket to 0.6b5. https://bugs.webkit.org/show_bug.cgi?id=66924 Reviewed by Kent Tamura. pywebsocket 0.6b2 supported minimum features of Hybi-08 specification. Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification. 0.6b3 or later supports a closing handshake handler and it is useful to verify client's closing handshake implementation. 0.6b4 supports AbortedByUserException. It is useful to eliminate unnecessary server warning messages on intended abnormal closures. 0.6b5 supports Python 2.5.1 or Mac 10.5. * Scripts/webkitpy/thirdparty/__init__.py: Update download URL and directory path. 2011-08-30 Dan Bernstein Test for Add text search API for getting the DOM range of a text match https://bugs.webkit.org/show_bug.cgi?id=67230 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added. * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added. (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]): (TestWebKitAPI::TEST): 2011-08-30 Aaron Colwell Add MediaSource API to HTMLMediaElement https://bugs.webkit.org/show_bug.cgi?id=64731 Reviewed by Eric Carlson. * Scripts/build-webkit: 2011-08-30 Caio Marcelo de Oliveira Filho Emit last progress notification before calling dispatchDidFinishLoad https://bugs.webkit.org/show_bug.cgi?id=28851 Reviewed by Adam Barth. Implement dumpProgressFinishedCallback() in the layoutTestController for Qt, Chromium and GTK ports. The first two were simple changes. Some refactoring was needed in GTK port to assure that the dumps are emitted correctly and the processing after the page load finished is in the right place. To detect the load finished, we use the callback for the "load-status" notifier signal of the top loading frame. And we use the deprecated "load-finished" signal for dumping (if enabled) the progress finished expected output. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpProgressFinishedCallbackCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpProgressFinishedCallback): (LayoutTestController::setDumpProgressFinishedCallback): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpProgressFinishedCallback): (LayoutTestController::reset): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::shouldDumpProgressFinishedCallback): (LayoutTestController::setShouldDumpProgressFinishedCallback): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didStopLoading): * DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadFinished): (topLoadingFrameLoadFinished): (webFrameLoadStatusNotified): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpProgressFinishedCallback): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2011-08-30 Filip Pizlo JavaScriptCore does not have a good mechanism for performance regression testing https://bugs.webkit.org/show_bug.cgi?id=67177 Reviewed by Darin Adler. Added a new script, which allows for testing one, two, or more VMs at once on SunSpider, V8, and Kraken benchmarks. Benchmark/VM runs are interleaved at random to minimize systematics. The results that bencher prints includes all possible relevant information about how bencher was invoked. Bencher can be easily used to measure performance changes down to fractions of a percent. Bencher also includes experimental support for running benchmarks in a DumpRenderTree release build. This works in SunSpider and V8, but not yet in Kraken. Running benchmarks in DumpRenderTree more closely mimics the performance when running in browser. * Scripts/bencher: Added. 2011-08-29 Alexey Proskuryakov DumpRenderTree should begin each test with an empty cookie store https://bugs.webkit.org/show_bug.cgi?id=63545 Reviewed by Darin Adler. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): (setDefaultsToConsistentValuesForTesting): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAlwaysAcceptCookies): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Use new SPIs to manipulate sessions. 2011-08-30 Sheriff Bot Unreviewed, rolling out r94055 and r94057. http://trac.webkit.org/changeset/94055 http://trac.webkit.org/changeset/94057 https://bugs.webkit.org/show_bug.cgi?id=67191 Many failures on Mac 10.5 (Requested by toyoshim on #webkit). * Scripts/webkitpy/thirdparty/__init__.py: 2011-08-30 Adam Barth Chromium Android should not be a core builder https://bugs.webkit.org/show_bug.cgi?id=67184 Reviewed by Ryosuke Niwa. This bot hasn't been consistently green yet because it has never actually run! * Scripts/webkitpy/common/net/buildbot/buildbot.py: * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 2011-08-30 Takashi Toyoshima [WebSocket] update pywebsocket to 0.6b4. https://bugs.webkit.org/show_bug.cgi?id=66924 Reviewed by Kent Tamura. pywebsocket 0.6b2 supported minimum features of Hybi-08 specification. Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification. 0.6b3 or later supports a closing handshake handler and it is useful to verify client's closing handshake implementation. 0.6b4 supports AbortedByUserException. It is useful to eliminate unnecessary server warning messages on intended abnormal closures. * Scripts/webkitpy/thirdparty/__init__.py: Update download URL and directory path. 2011-08-29 Tom Zakrajsek sheriffbot "usage" help statements are wrong https://bugs.webkit.org/show_bug.cgi?id=67170 Reviewed by Adam Barth. * Scripts/webkitpy/tool/bot/irc_command.py: * Scripts/webkitpy/tool/bot/irc_command_unittest.py: * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 2011-08-29 Adam Barth Add support for chomium-mac (non-CoreGraphics) baselines https://bugs.webkit.org/show_bug.cgi?id=67163 Reviewed by Eric Seidel. This patch teaches the non-CG chromium-mac bots to look at non-CG baselines. However, the patch still leaves CG as the default set of baselines. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: * Scripts/webkitpy/common/config/build.py: * Scripts/webkitpy/common/config/build_unittest.py: * Scripts/webkitpy/layout_tests/port/builders.py: * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_mac.py: * Scripts/webkitpy/layout_tests/port/factory.py: * Scripts/webkitpy/layout_tests/port/factory_unittest.py: * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: 2011-08-29 Shawn Singh Small fix in chromium port of new-run-webkit-tests. https://bugs.webkit.org/show_bug.cgi?id=67078 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/port/chromium.py: 2011-08-29 Sheriff Bot Unreviewed, rolling out r93987, r93992, r93995, r93998, and r93999. http://trac.webkit.org/changeset/93987 http://trac.webkit.org/changeset/93992 http://trac.webkit.org/changeset/93995 http://trac.webkit.org/changeset/93998 http://trac.webkit.org/changeset/93999 https://bugs.webkit.org/show_bug.cgi?id=67147 Many failing tests (Requested by ap on #webkit). * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): 2011-08-26 Alexey Proskuryakov DumpRenderTree should begin each test with an empty cookie store https://bugs.webkit.org/show_bug.cgi?id=63545 Reviewed by Darin Adler. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Tell WebCore to use a temporary session, starting with a clean cookie store. 2011-08-23 Chris Marrin [mac] requestAnimationFrame support for mac port https://bugs.webkit.org/show_bug.cgi?id=59146 Reviewed by Simon Fraser. Add support for request-animation-callback flag * Scripts/build-webkit: 2011-08-27 Peter Beverloo Add a build bot for Chromium with OS(ANDROID) https://bugs.webkit.org/show_bug.cgi?id=66687 Reviewed by Adam Barth. * BuildSlaveSupport/build.webkit.org-config/config.json: 2011-08-27 Peter Beverloo Update the master build bot configuration script to properly deal with the --chromium-android switch. https://bugs.webkit.org/show_bug.cgi?id=66687 The --chromium-android switch is needed when running update-webkit-chromium and build-webkit, as it'll tell the scripts to pull in the right dependencies and cross-compile WebKit using the Android NDK. Reviewed by Adam Barth. * BuildSlaveSupport/build.webkit.org-config/master.cfg: 2011-08-27 Peter Beverloo Teach the update and build scripts how to handle dependencies and cross-compiling rules for the Chromium port on OS(ANDROID). https://bugs.webkit.org/show_bug.cgi?id=66687 Reviewed by Adam Barth. * Scripts/build-webkit: * Scripts/update-webkit: * Scripts/update-webkit-chromium: * Scripts/webkitdirs.pm: (argumentsForConfiguration): (isChromium): (isChromiumAndroid): (determineIsChromiumAndroid): (buildChromium): 2011-08-26 Adam Barth garden-o-matic should let me know that I need to run the local server https://bugs.webkit.org/show_bug.cgi?id=66985 Reviewed by Dimitri Glazkov. The patch triggers an alert dialog whenever the user tries to use a feature that requires the local server. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: 2011-08-26 Dimitri Glazkov garden-o-matic summary view should have pretty commit data information. https://bugs.webkit.org/show_bug.cgi?id=67069 Reviewed by Adam Barth. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data. 2011-08-26 Dimitri Glazkov Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux. https://bugs.webkit.org/show_bug.cgi?id=67066 Reviewed by Adam Barth. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto. 2011-08-26 Raphael Kubo da Costa [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too. https://bugs.webkit.org/show_bug.cgi?id=67041 Reviewed by Martin Robinson. This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes PixelDumpSupportCairo.h, but the latter was #including cairo.h only when the GTK+ port was being built. * DumpRenderTree/cairo/PixelDumpSupportCairo.h: 2011-08-26 Dimitri Glazkov Clean up and line up layout in garden-o-matic summary view. https://bugs.webkit.org/show_bug.cgi?id=67057 1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing; 2) Rearranged DOM structure a bit to accommodate recent changes; 3) Added minimal CSS to line things up. Reviewed by Adam Barth. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto. 2011-08-26 Alice Liu https://bugs.webkit.org/show_bug.cgi?id=66823 Add the request info to the WebPageProxy::CreateNewPage message Reviewed by Anders Carlsson. Update function declarations with additional parameter: * MiniBrowser/gtk/BrowserWindow.c: (createNewPage): * MiniBrowser/mac/BrowserWindowController.m: (createNewPage): * MiniBrowser/win/BrowserView.cpp: (createNewPage): * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): * WebKitTestRunner/TestController.h: 2011-08-26 Noel Gordon Make show-pretty-diff work on linux https://bugs.webkit.org/show_bug.cgi?id=67017 Reviewed by Adam Barth. * Scripts/show-pretty-diff: 2011-08-25 Dimitri Glazkov Reorganize garden-o-matic CSS files to match JS-built views. https://bugs.webkit.org/show_bug.cgi?id=66998 Reviewed by Adam Barth. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto. 2011-08-25 Adam Barth garden-o-matic should be able to roll out patches https://bugs.webkit.org/show_bug.cgi?id=66982 Reviewed by Dimitri Glazkov. This patch just wires the rollout event through the controller to the local server, which is already set up to perform rollouts. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: 2011-08-25 Viatcheslav Ostapenko [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch https://bugs.webkit.org/show_bug.cgi?id=66951 Reviewed by Andreas Kling. Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets width and height one by one and setWidth cause geometryChange event in QTouchWebView. * MiniBrowser/qt/BrowserView.cpp: (BrowserView::resizeEvent): 2011-08-25 Dimitri Glazkov garden-o-matic summary view should provide information on builders still in flight. https://bugs.webkit.org/show_bug.cgi?id=66992 Reviewed by Adam Barth. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests. 2011-08-25 Adam Barth webkit-patch rebaseline-expectations don't work when run outside the root https://bugs.webkit.org/show_bug.cgi?id=66966 Reviewed by Eric Seidel. Turns out tool.path() used to be relative, which caused problems when running webkit-patch outside the root directory. This patch makes it absolute. I checked all callers, and they all appear to want this behavior. It was unclear to me how to test this change because we only really have a testing strategy for webkitpy, not for the main script. * Scripts/webkit-patch: 2011-08-25 Dimitri Glazkov garden-o-matic summary needs a mock view that could be used for working on styling https://bugs.webkit.org/show_bug.cgi?id=66971 Reviewed by Adam Barth. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added. 2011-08-25 Anders Carlsson Return the correct value for NPNVsupportsCarbonBool https://bugs.webkit.org/show_bug.cgi?id=66964 Add a test. Reviewed by Adam Roben. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added. (SupportsCarbonEventModel::SupportsCarbonEventModel): (SupportsCarbonEventModel::testConvert): (SupportsCarbonEventModel::runTest): (SupportsCarbonEventModel::NPP_New): 2011-08-25 Dimitri Glazkov garden-o-matic summary view should not be broken. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: (table.comparison): Added more specificity. 2011-08-25 Adam Barth This command has been broken for a while. This patch updates the callsite to the new API. * Scripts/webkitpy/tool/commands/rebaseline.py: 2011-08-25 Dimitri Glazkov garden-o-matic needs a way to report where and how tests are failing in the summary view. https://bugs.webkit.org/show_bug.cgi?id=66955 Introduce FailureGrid, your one-stop failure-indicating destination. Reviewed by Adam Barth. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts. 2011-08-25 Igor Oliveira Add myself to the committers list https://bugs.webkit.org/show_bug.cgi?id=66941 Reviewed by Andreas Kling. * Scripts/webkitpy/common/config/committers.py: 2011-08-25 Sheriff Bot Unreviewed, rolling out r93767. http://trac.webkit.org/changeset/93767 https://bugs.webkit.org/show_bug.cgi?id=66931 Broke Qt bot. (Requested by yutak on #webkit). * Scripts/webkitpy/thirdparty/__init__.py: 2011-08-25 Takashi Toyoshima [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test https://bugs.webkit.org/show_bug.cgi?id=66924 Reviewed by Kent Tamura. * Scripts/webkitpy/thirdparty/__init__.py: 2011-08-24 Adam Barth The user can't close the details view in garden-o-matic https://bugs.webkit.org/show_bug.cgi?id=66911 Reviewed by Dimitri Glazkov. In addition to adding a close button, this patch changes the test selector to use a 's selection changes https://bugs.webkit.org/show_bug.cgi?id=64504 Reviewed by Alice Liu. * DumpRenderTree/AccessibilityController.h: Added m_notificationsEventHook for addNotificationListener(). m_allEventsHook will now be used for setLogAccessibilityEvents(). * DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::AccessibilityController): Initialize m_notificationsEventHook. (AccessibilityController::~AccessibilityController): Turn off logging of all accessibility events. If m_notificationsEventHook is non-null, unhook it. (logEventProc): Add handling of EVENT_OBJECT_SELECTION. (AccessibilityController::setLogAccessibilityEvents): If the state of logging is not changing, return early. If we're turning off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a hook for all events. (AccessibilityController::addNotificationListener): Use m_notificationsEventHook rather than m_allEventsHook. 2011-07-18 Eric Seidel webkit-patch apply-attachment does not work when not called from the root of the checkout https://bugs.webkit.org/show_bug.cgi?id=64751 Unreviewed. Just updating unit test results after bug 64751. * Scripts/webkitpy/layout_tests/port/chromium_win.py: * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 2011-07-18 Adam Barth simplejson has trouble on chromium-linux https://bugs.webkit.org/show_bug.cgi?id=64757 Reviewed by Eric Seidel. Use the native JSON, if available. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 2011-07-18 Ojan Vafai update the flakiness dashboard to understand the new platforms/formats in test_expectations https://bugs.webkit.org/show_bug.cgi?id=64743 Reviewed by Adam Barth. The test expectations format changed a long time ago and the flakiness dashboard was never updated to match. * TestResultServer/static-dashboards/dashboard_base.js: * TestResultServer/static-dashboards/flakiness_dashboard.html: * TestResultServer/static-dashboards/flakiness_dashboard_tests.js: * TestResultServer/static-dashboards/timeline_explorer.html: 2011-07-18 Eric Seidel webkit-patch apply-attachment does not work when not called from the root of the checkout https://bugs.webkit.org/show_bug.cgi?id=64751 Reviewed by Adam Barth. Last week I removed a os.chdir in EnsureWorkingDirectoryClean, which is a step that we run for most commands (as one of the earliest steps). EnsureWorkingDirectoryClean was incorrectly calling os.chdir to change the CWD to the checkout root. This magically made a bunch of otherwise wrong code work. When I realized that apply-attachment no longer worked as expected today, I went and fixed the bug, then realizing that we were not testing what the cwd was when running various commands. I fixed our MockExecutive to always log what the cwd is and fixed a whole bunch of places where we needed to be setting the cwd. Hopefully this will solve our cwd problems once and for-all, and webkit-patch will again correctly work when called from any directory (including outside of a webkit checkout). * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: * Scripts/webkitpy/common/system/executive.py: * Scripts/webkitpy/common/system/workspace_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: * Scripts/webkitpy/layout_tests/port/mac_unittest.py: * Scripts/webkitpy/layout_tests/port/qt_unittest.py: * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: * Scripts/webkitpy/tool/bot/irc_command.py: * Scripts/webkitpy/tool/bot/irc_command_unittest.py: * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/queuestest.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/servers/gardeningserver.py: * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: * Scripts/webkitpy/tool/steps/build.py: * Scripts/webkitpy/tool/steps/checkstyle.py: * Scripts/webkitpy/tool/steps/editchangelog.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: * Scripts/webkitpy/tool/steps/runtests.py: * Scripts/webkitpy/tool/steps/steps_unittest.py: * Scripts/webkitpy/tool/steps/update.py: 2011-07-18 Adam Barth Increase information garden-o-matic information density by switching to a table https://bugs.webkit.org/show_bug.cgi?id=64642 Reviewed by Dimitri Glazkov. The old layout couldn't handle the large number of failures we had today. This patch switches garden-o-matic to a table-based layout, which can handle many more failures gracefully. (I expect we'll need more UI iterations.) * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: 2011-07-18 Adam Barth garden-o-matic should be able to determine when compile breaks https://bugs.webkit.org/show_bug.cgi?id=64190 Reviewed by Dimitri Glazkov. This patch adds a red-ish box to the top of the page whenever there is a compile error on the bots. The box automatically opens and closes as appropriate and links to the waterfall display. In the future, we might want to compute a regression range. * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: - Add the build-only bots to the config. We use these to check whether the build failed, which is faster than waiting for the tester bots to cycle. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: - Add DOM for the alert bar. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: - CSS to support the alert bar. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: - Wiring up events to poll the buildbot to see whether compile has failed. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: - Infrastructure for fetching and parsing the buildbot status JSON blob. This code could be better factored for testability. :( * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: - UI for displaying compile errors. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: 2011-07-18 Sheriff Bot Unreviewed, rolling out r91132 and r91135. http://trac.webkit.org/changeset/91132 http://trac.webkit.org/changeset/91135 https://bugs.webkit.org/show_bug.cgi?id=64681 Broke GTK and Chromium debug bots (Requested by rniwa on #webkit). * DumpRenderTree/AccessibilityController.h: * DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (logEventProc): (AccessibilityController::setLogAccessibilityEvents): (AccessibilityController::addNotificationListener): 2011-07-17 Philippe Normand test-webkitpy failing with Python 2.5 https://bugs.webkit.org/show_bug.cgi?id=64594 Reviewed by Eric Seidel. Updated simplejson to version 2.1.6 that fixes an issue when dumping slashes. Also use cgi.parse_qs instead of the urlparse version to be compatible with Python2.5. Verified the fix with test-webkitpy on python 2.5 and python 2.6. * Scripts/webkitpy/thirdparty/simplejson/README.txt: * Scripts/webkitpy/thirdparty/simplejson/__init__.py: * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: (json_PyOS_string_to_double): (_convertPyInt_AsSsize_t): (_convertPyInt_FromSsize_t): (ascii_escape_char): (ascii_escape_unicode): (ascii_escape_str): (raise_errmsg): (join_list_unicode): (join_list_string): (_build_rval_index_tuple): (scanstring_str): (scanstring_unicode): (py_scanstring): (py_encode_basestring_ascii): (scanner_dealloc): (scanner_traverse): (scanner_clear): (_parse_object_str): (_parse_object_unicode): (_parse_array_str): (_parse_array_unicode): (_parse_constant): (_match_number_str): (_match_number_unicode): (scan_once_str): (scan_once_unicode): (scanner_call): (scanner_new): (scanner_init): (encoder_new): (encoder_init): (encoder_call): (_encoded_const): (encoder_encode_float): (encoder_encode_string): (_steal_list_append): (encoder_listencode_obj): (encoder_listencode_dict): (encoder_listencode_list): (encoder_dealloc): (encoder_traverse): (encoder_clear): (init_speedups): * Scripts/webkitpy/thirdparty/simplejson/decoder.py: * Scripts/webkitpy/thirdparty/simplejson/encoder.py: * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Added. * Scripts/webkitpy/thirdparty/simplejson/scanner.py: * Scripts/webkitpy/thirdparty/simplejson/tool.py: Added. * Scripts/webkitpy/tool/servers/reflectionhandler.py: 2011-07-17 Dimitri Glazkov Rename ModifierMatcher to SpecificityCalculator. https://bugs.webkit.org/show_bug.cgi?id=64660 It's a little longer than before, but it is much clearer. Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Renamed and adjusted all callsites, also rewrote the comments. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted callsites and renamed tests. 2011-07-15 Adam Barth gardening server should proxy buildbot status for garden-o-matic https://bugs.webkit.org/show_bug.cgi?id=64588 Reviewed by Eric Seidel. This information will be used to detect build breaks. I took this opportunity to make ChromiumBuildBot non-static. * Scripts/webkitpy/common/host.py: * Scripts/webkitpy/tool/commands/rebaseline.py: * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/servers/gardeningserver.py: * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: 2011-07-15 Julien Chaffraix [NRWT] Add support for --no-http https://bugs.webkit.org/show_bug.cgi?id=64564 Reviewed by Dirk Pranke. Added support for --no-http, which disables both HTTP and websockets tests. It also matches the old-run-webkit-tests behavior if --force is used. * Scripts/webkitpy/layout_tests/controllers/manager.py: Fixed HTTP_SUBDIR and WEBSOCKET_SUBDIR as tests do not start with a leading separator. We check if --no-http is set and add the HTTP / websockets tests to the skipped list prior to looking at the expectation file. Fixed the _test_requires_lock function to use the same code path to determine what is worth have an HTTP lock as --no-http to avoid badness. * Scripts/webkitpy/layout_tests/port/test.py: Added 2 new tests to our mock filesystem to validate that we do skip properly HTTP / websocket tests inside platform/. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added tests that we properly skip all the tests. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Added checks for the command line arguments. 2011-07-13 Jon Honeycutt Focus and selection events are not fired when a