2011-12-02 Martin Robinson Try to fix the GTK+ build. * gtk/jhbuild.modules: Properly specify the glib-networking dependency for soup. 2011-12-02 Martin Robinson Fix a syntax error in the committers.py file. * Scripts/webkitpy/common/config/committers.py: Add a missing comma. 2011-12-02 Ryosuke Niwa Add Alan Stearns and Peter Linss to the contributors list. * Scripts/webkitpy/common/config/committers.py: 2011-12-02 Kent Tamura [Chromium] Fix compilation warnings for ASSERT() https://bugs.webkit.org/show_bug.cgi?id=73623 Reviewed by Tony Chang. * DumpRenderTree/chromium/ImageDiff.cpp: - Fix fprintf format: %s -> %d for __LINE__ - Do nothing for ASSERT() if NDEBUG. 2011-12-02 Eric Seidel Enable parallel testing for all Mac bots. Unreviewed. * Scripts/run-webkit-tests: (platformIsReadyForParallelTesting): 2011-12-02 Eric Seidel Enable parallel testing for run-webkit-tests on Mac Lion. I plan to move all the machines to parallel testing shortly but we're starting with Lion. Unreviewed. * Scripts/run-webkit-tests: (platformIsReadyForParallelTesting): 2011-12-02 Kausalya Madhusudhanan Added helper method to identify whether the page has custom page size style. https://bugs.webkit.org/show_bug.cgi?id=73585 Reviewed by Darin Fisher. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::hasCustomPageSizeStyle): * DumpRenderTree/chromium/LayoutTestController.h: 2011-12-01 Ryosuke Niwa [NRWT] reftest should support having multiple references per test https://bugs.webkit.org/show_bug.cgi?id=73613 Reviewed by Dirk Pranke. Add a support for having multiple reference files for a single test. Because a reftest succeeds when it matches at least one of expected matches and fails when it matches at least one of expected mismatches, we compare expected mismatches first in order to minimize the number of reference files to open on DRT. * Scripts/webkitpy/layout_tests/controllers/manager.py: (interpret_test_failures): Remove checks no longer applicable. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ResultSummaryTest.test_interpret_test_failures): Ditto. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files. (SingleTestRunner._driver_input): (SingleTestRunner.run): (SingleTestRunner._run_reftest): Compare the output of the test to each reference file. * Scripts/webkitpy/layout_tests/models/test_input.py: (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used. * Scripts/webkitpy/layout_tests/port/base.py: (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs. (_parse_reftest_list): Now supports parsing multiple entries for a single test. * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_parse_reftest_list): * Scripts/webkitpy/layout_tests/port/test.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_unexpected_failures): (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results. (EndToEndTest.test_end_to_end): (EndToEndTest.test_reftest_with_two_notrefs): Added. 2011-12-02 Gustavo Noronha Silva Build libsoup without gnome dependencies (like keyring). * gtk/jhbuild.modules: 2011-12-02 Gustavo Noronha Silva Also build gcrypt and p11-kit, and make them dependencies of gnutls. * gtk/jhbuild.modules: 2011-12-02 Kevin Ollivier [wx] Unreviewed build fixes for Windows build. * waf/build/wxpresets.py: 2011-12-01 Eric Seidel Reviewed by Adam Barth. webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it https://bugs.webkit.org/show_bug.cgi?id=32006 I decided not to make it warn, and just have it re-open the bug. That's not that different from today's behavior which will just silently attach the patch. This patch makes behavior between upload and land-safely consistent (previously one would assign patches and the other would not) as well as adds the ability for both to ensure that the bug is open. To test this I had to add a few more methods to MockBugzilla which (positively) affected a few other test results. I also made AbstractStep keep a cached copy of the Bug object and used the cached copy where appropriate (including for 'bug_title'). This should reduce the number of bug fetches we perform. * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/commands/upload.py: * Scripts/webkitpy/tool/commands/upload_unittest.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/__init__.py: * Scripts/webkitpy/tool/steps/abstractstep.py: * Scripts/webkitpy/tool/steps/closebug.py: * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added. * Scripts/webkitpy/tool/steps/postdiff.py: * Scripts/webkitpy/tool/steps/postdiffforcommit.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: * Scripts/webkitpy/tool/steps/steps_unittest.py: * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 2011-12-02 Gustavo Noronha Silva Also pass --no-interact to jhbuild when updating dependencies. * Scripts/update-webkitgtk-libs: 2011-12-02 Alice Boxhall Make _build_path check more thoroughly that build paths exist. https://bugs.webkit.org/show_bug.cgi?id=73601 Reviewed by Ojan Vafai. * Scripts/webkitpy/layout_tests/port/chromium_mac.py: (ChromiumMacPort._build_path): 2011-12-02 Gustavo Noronha Silva Add libffi to the jhbuild modules list as a glib dependency. Rubber-stamped by Martin Robinson. * gtk/jhbuild.modules: 2011-12-02 Gustavo Noronha Silva Build fix. Use internal pcre on glib, make gnutls a dependency of glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild in non-interactive mode. * Scripts/update-webkitgtk-libs: * gtk/jhbuild.modules: * gtk/run-with-jhbuild: 2011-12-02 Adam Roben Fix for Python 2.6 * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when searching for "Tests that timed out:" etc. This makes our check less strict, but it shouldn't matter given the kinds of content we parse. 2011-12-02 Adam Roben Fix names of failed/timed out tests in run-api-tests output Fixes run-api-tests prints suite names twice for failed or timed out tests We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash"). Reviewed by Simon Fraser. * Scripts/run-api-tests: (runTest): Don't prepend the suite name to $test. It's already been prepended at the start of this function. 2011-11-29 Martin Robinson [GTK] generate-gtkdoc should respect build type https://bugs.webkit.org/show_bug.cgi?id=73296 Reviewed by Philippe Normand. * Scripts/webkitdirs.pm: (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script. * gtk/common.py: If --build is passed give preference to the Debug build directory. 2011-12-02 Tony Chang [nrwt] fix wdiff output https://bugs.webkit.org/show_bug.cgi?id=73604 Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/port/base.py: (Port.wdiff_text): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_wdiff_text): 2011-12-02 Adam Roben Teach build.webkit.org to display how many unit tests failed or timed out Fixes It's hard to tell how many unit tests are failing on build.webkit.org We now display something like "5 unit tests failed or timed out". Eventually we might want to split out how many failure vs. timeouts there were. Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (TestWithFailureCount): Moved this class up to the top of the file so it is before any other classes that may want to subclass it. (RunUnitTests): Changed to inherit from TestWithFailureCount. (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that timed out:" and "Tests that failed:" lines, if present. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (StubStdio): (StubRemoteCommand): Added these two stub classes to mimic buildbot's RemoteCommand and log classes. (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of the test run correctly. (RunUnitTestsTest.test_no_failures_or_timeouts): (RunUnitTestsTest.test_one_failure): (RunUnitTestsTest.test_multiple_failures): (RunUnitTestsTest.test_one_timeout): (RunUnitTestsTest.test_multiple_timeouts): (RunUnitTestsTest.test_multiple_failures_and_timeouts): Test various cases. 2011-12-02 Adam Roben Teach prepare-ChangeLog to treat master.cfg as a Python file Fixes prepare-ChangeLog doesn't show modified classes/functions in buildbot's master.cfg Reviewed by Darin Adler. * Scripts/prepare-ChangeLog: (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is master.cfg. 2011-12-02 Martin Robinson [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it https://bugs.webkit.org/show_bug.cgi?id=73669 Reviewed by Gustavo Noronha Silva. Add a wrapper script that knows how to install jhbuild and also to wrap commands in the jhbuild shell. * Scripts/webkitdirs.pm: (runAutogenForAutotoolsProject): Use the new wrapper script. (mustReRunAutogen): Ditto. (buildAutotoolsProject): Ditto. * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkDriver.cmd_line): Ditto. * gtk/run-with-jhbuild: Added. 2011-12-01 Adam Roben Teach check-webkit-style how to check the syntax of JSON files Fixes check-webkit-style doesn't flag JSON syntax errors I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This patch is identical to that one except for two change: assertIn(a, b) (which is new to Python 2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has been removed, since its output differs by platform. Reviewed by Darin Adler. * Scripts/webkitpy/style/checker.py: (_all_categories): Added JSONChecker's categories to the set of all categories. (FileType): Added a JSON type. Incremented other types. (CheckerDispatcher._file_type): Use the JSON file type for .json files. (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files. * Scripts/webkitpy/style/checker_unittest.py: (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method. (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths. * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json", which would have matched our other checkers, because I couldn't figure out how to call "json.loads" without hitting namespace conflicts.) (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not just the modified lines from a patch. (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an exception. (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to try to extract a line number. * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added. (MockErrorHandler.__init__): (MockErrorHandler.turn_off_line_filtering): (MockErrorHandler.__call__): Helper class. Copied from xml_unittest.py. (JSONCheckerTest.test_line_number_from_json_exception): Test the line_number_from_json_exception helper method. (JSONCheckerTest.assert_no_error): (JSONCheckerTest.assert_error): Helper methods to assert that we did or didn't get an error. (JSONCheckerTest.mock_handle_style_error): Helper method. (JSONCheckerTest.test_conflict_marker): (JSONCheckerTest.test_single_quote): (JSONCheckerTest.test_init): (JSONCheckerTest.test_no_error): Test various cases. 2011-12-02 Gustavo Noronha Silva [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild https://bugs.webkit.org/show_bug.cgi?id=73664 Reviewed by Martin Robinson. This patch adds our HTTP library and its main dependencies; this should not affect layout or rendering. * gtk/jhbuild.modules: 2011-12-02 Gustavo Noronha Silva [GTK] Also run DumpRenderTree under jhbuild https://bugs.webkit.org/show_bug.cgi?id=73646 Reviewed by Martin Robinson. * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkDriver.cmd_line): 2011-12-02 Hajime Morrita Unreviewed, rolling out r101751 and r101775. http://trac.webkit.org/changeset/101751 http://trac.webkit.org/changeset/101775 https://bugs.webkit.org/show_bug.cgi?id=73191 breaks Windows build * DumpRenderTree/chromium/config.h: * DumpRenderTree/config.h: * TestWebKitAPI/config.h: * WebKitTestRunner/config.h: 2011-12-02 Kentaro Hara Move run-bindings-tests implementation to webkitpy/bindings/main.py https://bugs.webkit.org/show_bug.cgi?id=73619 Reviewed by Adam Barth. As run-bindings-tests has been growing, this patch just moves its implementation to webkitpy/bindings/main.py to integrate with the rest of webkitpy. No change in behavior. * Scripts/run-bindings-tests: (main): * Scripts/webkitpy/bindings/__init__.py: Added. * Scripts/webkitpy/bindings/main.py: Added. (BindingsTests.__init__): (BindingsTests.generate_from_idl): (BindingsTests.generate_supplemental_dependency): (BindingsTests.detect_changes): (BindingsTests.run_tests): 2011-12-01 Ilya Tikhonovsky Tools/Scripts: eliminate find_test_files from Port class. https://bugs.webkit.org/show_bug.cgi?id=73553 rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests() I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files. Also I'll move _is_test_file() and related functions close to Port.tests(). Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/port/base.py: (Port.tests): (Port.is_reference_html_file): (Port._has_supported_extension): (Port._is_test_file): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_find_no_paths_specified): (PortTest.test_find_one_test): (PortTest.test_find_glob): (PortTest.test_find_with_skipped_directories): (PortTest.test_find_with_skipped_directories_2): (PortTest.test_is_test_file): * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: (_default_tests_paths): (ChromiumGpuLinuxPort.tests): (ChromiumGpuCgMacPort.tests): (ChromiumGpuMacPort.tests): * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: (ChromiumGpuTest.test_default_tests_paths.test_paths): (ChromiumGpuTest.test_default_tests_paths): (ChromiumGpuTest.test_test_files.test_paths): (ChromiumGpuTest): (ChromiumGpuTest.test_test_files): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (get_tests_run.RecordingTestDriver.run_test): * Scripts/webkitpy/tool/commands/rebaseline.py: (OptimizeBaselines._optimize_baseline): (OptimizeBaselines.execute): (AnalyzeBaselines._analyze_baseline): (AnalyzeBaselines.execute): 2011-12-01 Hajime Morrita JS_INLINE and WTF_INLINE should be visible from WebCore https://bugs.webkit.org/show_bug.cgi?id=73191 Reviewed by Kevin Ollivier. Removed macro definitions which is now provided by Platform.h * DumpRenderTree/chromium/config.h: * DumpRenderTree/config.h: * TestWebKitAPI/config.h: * WebKitTestRunner/config.h: 2011-12-01 Hayato Ito Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure. https://bugs.webkit.org/show_bug.cgi?id=73406 Reviewed by Ryosuke Niwa. WebKitPort's image_diff uses tolerance='0.1' in default. When reftests fail, we should use tolerace=0 when diff-ing images. Since ImageDiff on chromium port doesn't use tolerance value as of now, this change doesn't affect chromium port's behavior. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (write_test_result): * Scripts/webkitpy/layout_tests/port/base.py: (Port.diff_image): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort.diff_image): * Scripts/webkitpy/layout_tests/port/test.py: (TestPort.diff_image): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort.diff_image): (WebKitPort._start_image_diff_process): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_tolerance.ImageDiffTestPort.diff_image): 2011-12-01 Adam Klein Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=73599 Reviewed by Ojan Vafai. * TestResultServer/static-dashboards/builders.js: * TestResultServer/static-dashboards/dashboard_base.js: (): (htmlForTestTypeSwitcher): * TestResultServer/static-dashboards/flakiness_dashboard_tests.js: (testHtmlForTestTypeSwitcherGroup): 2011-12-01 Ryosuke Niwa Parse reftest.list and extract types of ref tests https://bugs.webkit.org/show_bug.cgi?id=66837 Reviewed by Dirk Pranke. Add support for reftest.list to base port. * Scripts/webkitpy/common/find_files.py: (find): * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): * Scripts/webkitpy/layout_tests/port/base.py: (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory to a dictionary of {test path: ("==" or "!=", reference file path)} (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list. (Port._reference_file_for): Added; obtains the reference file name given a test name. (Port.is_reftest): Added; Calls _reference_file_for. (Port.reftest_expected_filename): Calls _reference_file_for. (Port.reftest_expected_mismatch_filename): Ditto. (Port.find_test_files): (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with -expected, -expected-mismach, -ref, or -notref as a reference file. (_is_test_file): (_parse_reftest_list): Added. * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_is_test_file): (PortTest.test_parse_reftest_list): * Scripts/webkitpy/layout_tests/port/dryrun.py: (DryrunDriver.run_test): * Scripts/webkitpy/layout_tests/port/test.py: (unit_test_filesystem.add_test_file): (unit_test_filesystem.add_file): (unit_test_filesystem): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (get_tests_run.RecordingTestDriver.run_test): (MainTest.test_unexpected_failures): (MainTest.test_missing_and_unexpected_results): (EndToEndTest.test_end_to_end): * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: (Rebaseliner._compile_rebaselining_tests): 2011-12-01 Sheriff Bot Unreviewed, rolling out r101711. http://trac.webkit.org/changeset/101711 https://bugs.webkit.org/show_bug.cgi?id=73605 Broke 3 webkitpy tests (Requested by rniwa on #webkit). * Scripts/webkitpy/style/checker.py: (_all_categories): (FileType): (CheckerDispatcher._file_type): (CheckerDispatcher._create_checker): * Scripts/webkitpy/style/checker_unittest.py: (CheckerDispatcherDispatchTest.assert_checker_cpp): (CheckerDispatcherDispatchTest.test_cpp_paths): * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed. * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed. 2011-12-01 Gustavo Noronha Silva Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists. * Scripts/webkitpy/common/config/watchlist: 2011-12-01 Martin Robinson [GTK] Read fonts from the jhbuild root https://bugs.webkit.org/show_bug.cgi?id=73487 Reviewed by Gustavo Noronha Silva. Read fonts from the jhbuild root instead of from the system. This will ensure that all testers use the same fonts instead of leaving this up to luck. * DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Load fonts from jhbuild root. * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkPort.setup_environ_for_server): Pass an environment variable containing the path to the jhbuild root. * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root. 2011-12-01 Adam Roben Teach check-webkit-style how to check the syntax of JSON files Fixes check-webkit-style doesn't flag JSON syntax errors Reviewed by Darin Adler. * Scripts/webkitpy/style/checker.py: (_all_categories): Added JSONChecker's categories to the set of all categories. (FileType): Added a JSON type. Incremented other types. (CheckerDispatcher._file_type): Use the JSON file type for .json files. (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files. * Scripts/webkitpy/style/checker_unittest.py: (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method. (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths. * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json", which would have matched our other checkers, because I couldn't figure out how to call "json.loads" without hitting namespace conflicts.) (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not just the modified lines from a patch. (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an exception. (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to try to extract a line number. * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added. (MockErrorHandler.__init__): (MockErrorHandler.turn_off_line_filtering): (MockErrorHandler.__call__): Helper class. Copied from xml_unittest.py. (JSONCheckerTest.test_line_number_from_json_exception): Test the line_number_from_json_exception helper method. (JSONCheckerTest.assert_no_error): (JSONCheckerTest.assert_error): Helper methods to assert that we did or didn't get an error. (JSONCheckerTest.mock_handle_style_error): Helper method. (JSONCheckerTest.test_conflict_marker): (JSONCheckerTest.test_single_quote): (JSONCheckerTest.test_init): (JSONCheckerTest.test_missing_closing_brace): (JSONCheckerTest.test_no_error): Test various cases. 2011-12-01 Martin Robinson [GTK] Add a helper function to find the current executable's path https://bugs.webkit.org/show_bug.cgi?id=73473 Reviewed by Gustavo Noronha Silva. Update MiniBrowser to not pass the binary directory as an environment variable. This means that you can move the binaries around without it breaking. * MiniBrowser/gtk/main.c: (main): No longer set the environment variable. * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define. * WebKitTestRunner/gtk/main.cpp: Ditto. 2011-12-01 Gustavo Noronha Silva Unreviewed. Fix bad file =(. * gtk/jhbuild.modules: * Scripts/webkitdirs.pm: (runAutogenForAutotoolsProject): 2011-12-01 Gustavo Noronha Silva [GTK] Add freetype to our jhbuild setup https://bugs.webkit.org/show_bug.cgi?id=73488 Reviewed by Martin Robinson. This adds the first library to our jhbuild setup, and makes sure build-webkit calls autogen.sh and make with jhbuild, so that the environment is properly set. * Scripts/webkitdirs.pm: (saveSum): (hashFile): (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and call autogen under jhbuild run; (mustRunAutogen): generalized the arguments change checking to also force running autogen when jhbuild files change; (buildAutotoolsProject): run make under jhbuild; * gtk/jhbuild.modules: add freetype. 2011-12-01 Dominic Mazzoni Fix WebKitTestRunner compile warnings with XCode 3.2 https://bugs.webkit.org/show_bug.cgi?id=73378 Reviewed by Chris Fleizach. * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: (WTR::AccessibilityTextMarker::AccessibilityTextMarker): * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::AccessibilityUIElement): (WTR::AccessibilityUIElement::verticalScrollbar): 2011-12-01 Adam Roben Allow committers to use their Trac credentials to force builds on the buildbots Fixes A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses three files to do its job: a config file that contains a list of WebKit committer usernames, an htdigest file that contains Trac credentials, and JSON file that gives the paths for those two files. Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added. (Error): Basic wrapper around Exception that we use for cases where we couldn't even check whether credentials were valid or not. (CommitterAuth.__init__): Just store the path to auth.json. (CommitterAuth.auth_json): Load, parse, and return auth.json. (CommitterAuth.auth_json_filename): Return the path to auth.json. (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their credentials are valid Trac credentials. Return false otherwise or if an error occurred while checking those conditions. (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return false otherwise or if an exception was thrown. (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the Trac credentials htdigest file. Return false otherwise or if an exception was thrown. (CommitterAuth.open_auth_json_file): (CommitterAuth.open_trac_credentials_file): (CommitterAuth.open_webkit_committers_file): Open the specified file. These are mostly useful for testing purposes. (CommitterAuth.trac_credentials_filename): (CommitterAuth.webkit_committers_filename): Return the path to the specified file by retrieving it from auth.json. (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list of WebKit committers from it. * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added. (CMStringIO.__enter__): (CMStringIO.__exit__): Helper class that makes it possible to use StringIO with the "with" statement. (open_override): Helper context manager for overriding the global "open" function temporarily. (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most tests. (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of "open" to test that the expected path was opened. (CommitterAuthTest.test_authentication_success): Test that committers can authenticate successfully. (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who somehow have no Trac account can't authenticate. (CommitterAuthTest.test_fail_to_open_auth_json_file): (CommitterAuthTest.test_fail_to_open_trac_credentials_file): (CommitterAuthTest.test_fail_to_open_webkit_committers_file): Test what happens when we can't open the three files we depend upon. (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for an authentication class. (CommitterAuthTest.test_invalid_auth_json_file): (CommitterAuthTest.test_invalid_committers_file): (CommitterAuthTest.test_invalid_trac_credentials_file): (CommitterAuthTest.test_missing_auth_json_keys): Test what happens when the three files we depend upon are invalid in some way. (CommitterAuthTest.test_open_auth_json_file): (CommitterAuthTest.test_open_trac_credentials_file): (CommitterAuthTest.test_open_webkit_committers_file): Test that we open the expected paths. (CommitterAuthTest.test_trac_credentials_filename): (CommitterAuthTest.test_webkit_committers_filename): Test that we extract filenames out of auth.json correctly. (CommitterAuthTest.test_non_committer_fails): (CommitterAuthTest.test_unknown_user_fails): (CommitterAuthTest.test_username_is_prefix_of_valid_user): (CommitterAuthTest.test_wrong_password_fails): Test various failed authentication attempts. (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit committers out of the committers file correctly. (CommitterAuthTest.fake_auth_json_file): (CommitterAuthTest.invalid_auth_json_file): (CommitterAuthTest.fake_committers_file): (CommitterAuthTest.invalid_committers_file): (CommitterAuthTest.fake_htdigest_file): (CommitterAuthTest.invalid_htdigest_file): Return various fake files for testing. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth to be used for authentication in the web interface, and specify that only authenticated users may force builds. 2011-12-01 Adam Roben Add an HTDigestParser class to webkitpy Fixes webkitpy doesn't provide a way to parse htdigest files This class can be used to parse Apache's htdigest files and check whether a given username/realm/password tuple is present in the file. Eventually this will be used for authenticating users on build.webkit.org (). Reviewed by Eric Seidel. * Scripts/webkitpy/common/net/htdigestparser.py: Added. (HTDigestParser.__init__): Stores the parsed representation of the file. (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed password and returns whether the resulting tuple is present in the file. (HTDigestParser.entries): Just returns the parsed representation of the file. (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the whole file as invalid and all authentication attempts will fail. * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added. (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file, optionally appended with some extra data, generates the expected entries. (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can authenticate, and tuples not present cannot. (HTDigestParserTest.test_entries): Tests that we get the expected entries from fake_htdigest_file. (HTDigestParserTest.test_empty_file): (HTDigestParserTest.test_too_few_colons): (HTDigestParserTest.test_too_many_colons): (HTDigestParserTest.test_invalid_hash): Test various forms of invalid files. (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing. 2011-12-01 Philippe Normand [GTK] Make the new 64-bit Release bot part of the core set https://bugs.webkit.org/show_bug.cgi?id=73570 Reviewed by Adam Roben. The 64-bit Release bot re-introduced in r101676 replaces the 64-bit Debug bot which was already part of the core set. The GTK gardeners are willing to actively maintain it. * Scripts/webkitpy/common/net/buildbot/buildbot.py: (BuildBot.__init__): * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: (test_builder_name_regexps): 2011-12-01 Philippe Normand [GTK] Buildslave switch from 32-bit Debug to 64-bit Release https://bugs.webkit.org/show_bug.cgi?id=73547 Reviewed by Adam Roben. * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the 32-bit Debug configuration to 64-bit Release. The new slave is a 64-bit machine already. The 32-bit slave will be shut down. 2011-12-01 Martin Robinson [GTK] build-jsc should not trigger gtkdoc generation https://bugs.webkit.org/show_bug.cgi?id=73552 Reviewed by Philippe Normand. Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures that build-jsc does not try to generate gtkdoc. * Scripts/webkitdirs.pm: (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit". 2011-12-01 Kristóf Kosztyó tests_run0.txt gets clobbered when re-running failing tests https://bugs.webkit.org/show_bug.cgi?id=63844 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.results_directory): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (AbstractWorker.__init__): (_ManagerConnection.start_worker): (_InlineManager.start_worker): (_MultiProcessManager.start_worker): (_WorkerConnection.__init__): (_InlineWorkerConnection.__init__): (_MultiProcessWorkerConnection.__init__): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: (_TestWorker.__init__): (_TestsMixin.test_cancel): (_TestsMixin.test_done): (_TestsMixin.test_unknown_message): (InterfaceTest.test_managerconnection_is_abstract): (InterfaceTest.test_workerconnection_is_abstract): * Scripts/webkitpy/layout_tests/controllers/worker.py: (Worker.__init__): (Worker.safe_init): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_retries_directory): 2011-12-01 Adam Roben Buildbot fix * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes it possible for build steps to reference things like the buildbotURL property of the config. 2011-11-30 Adam Roben Use curl for downloading builds to test slaves Buildbot's built-in file transfer capabilities are transferring files much more slowly than curl does. This seems to be due to a combination of buildbot being single-threaded (and thus often busy servicing web requests, etc.) and using an IPC mechanism with fairly high overhead (courtesy of the Twisted framework). Eventually we'd like to make Buildbot's built-in transferring more efficient. In the meantime we'll try using curl for downloads and keep thinking about a solution for uploads. This should make the test slaves quite a bit faster, and should ease the CPU load on build.webkit.org a bit. Part of Mac slaves take 7+ minutes to upload or download a build Reviewed by Mark Rowe. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory to Test slaves. It's run just before DownloadBuiltProduct. (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the download. (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave. FileDownload used to do this for us automatically. 2011-11-21 Philippe Normand [GTK] enable-webaudio websetting https://bugs.webkit.org/show_bug.cgi?id=69836 Reviewed by Martin Robinson. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): Update WebKitGTK enable-webaudio setting when a layout test requests it. 2011-11-30 Ilya Tikhonovsky Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector. https://bugs.webkit.org/show_bug.cgi?id=73079 The idea is to have performance tests for WebInspector. I was suggested to put these tests into PerformanceTests/inspector. They produce output in a format that is suitable for chromium perf bot drawing scripts. I'd like to reuse code for scanning folders for test files. Because of the fact that original test_files.py has common and layout specific parts I decided to extract the generic part and put it into webkitpy/common I think the two packages with name test_files look strange but I have no idea about a better name. Reviewed by Dirk Pranke. * Scripts/run-inspector-perf-tests.py: Added. * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py. (find): (_normalize): * Scripts/webkitpy/common/find_files_unittest.py: Added. (MockWinFileSystem.join): (MockWinFileSystem): (MockWinFileSystem.normpath): (TestWinNormalize.assert_filesystem_normalizes): (TestWinNormalize.test_mocked_win): (TestWinNormalize): (TestWinNormalize.test_win): * Scripts/webkitpy/layout_tests/port/base.py: (Port.tests): (Port.find_test_files): (Port._driver_class): (is_reference_html_file): (_has_supported_extension): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_find_no_paths_specified): (PortTest.test_find_one_test): (PortTest.test_find_glob): (PortTest.test_find_with_skipped_directories): (PortTest.test_find_with_skipped_directories_2): (PortTest): (PortTest.test_is_test_file): * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: (_tests): * Scripts/webkitpy/layout_tests/port/test.py: * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: * Scripts/webkitpy/performance_tests/__init__.py: Added. * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added. (PerfTestsRunner.__init__): (PerfTestsRunner._parse_args): (PerfTestsRunner._collect_tests._is_test_file): (PerfTestsRunner._collect_tests): (PerfTestsRunner.run): (PerfTestsRunner._run_tests_set): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added. (MainTest.TestPort): (MainTest.TestPort.create_driver): (MainTest.TestDriver.run_test): (MainTest.TestDriver): (MainTest.TestDriver.stop): (MainTest.create_runner): (MainTest.run_test): (MainTest.test_run_passing_test): (MainTest.test_run_silent_test): (MainTest.test_run_failed_test): (MainTest.test_run_tonguey_test): (MainTest.test_run_timeout_test): (MainTest.test_run_crash_test): (MainTest.test_run_test_set): (MainTest.test_collect_tests): (MainTest): (MainTest.test_parse_args): * Scripts/webkitpy/tool/commands/rebaseline.py: (OptimizeBaselines.execute): (AnalyzeBaselines.execute): 2011-11-30 nduca@chromium.org [chromium] Enable threaded compositing via CCThreadProxy::hasThread only https://bugs.webkit.org/show_bug.cgi?id=70838 Reviewed by James Robinson. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): * DumpRenderTree/chromium/TestShell.h: (TestShell::threadedCompositingEnabled): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::WebViewHost): (WebViewHost::~WebViewHost): 2011-11-30 Chris Fleizach AX: Nodes are reporting that focus can be set when they really can't https://bugs.webkit.org/show_bug.cgi?id=72791 Reviewed by Beth Dakin. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isFocusable): * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::isFocusable): 2011-11-30 Alejandro G. Castro Moved myself to the reviewers list. * Scripts/webkitpy/common/config/committers.py: 2011-11-30 David Levin [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient. https://bugs.webkit.org/show_bug.cgi?id=73415 Reviewed by Darin Fisher. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for it being moved to a new interface and having the parameter removed. * DumpRenderTree/chromium/WebViewHost.h: Ditto. 2011-11-30 Adam Roben Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed This will make it a lot easier to investigate build failures on the bots. Fixes NRWT doesn't show build output when building DRT Reviewed by Eric Seidel. * Scripts/webkitpy/common/system/executive_mock.py: (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output seen in practice. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer. The Printer was modifying the root logger in way that would cause my new tests in WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't seem important to the functioning of this test, and passing False makes Printer not modify the root logger. * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show up when --verbose is passed but not otherwise. (WebKitPort._build_driver): When an error occurs, log the error message and the script's output at the ERROR level so it will always show up. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful cases. Test that the build scripts' output is logged when --verbose is passed or the build fails. 2011-11-30 Adam Roben Add a way to set OutputCapture's log level This will be used by some unit tests I'm planning to add. Fixes OutputCapture can't be used to capture DEBUG messages Reviewed by Eric Seidel. * Scripts/webkitpy/common/system/outputcapture.py: (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only level we ever used before this patch. (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is being tested uses. Sets the log level for any current or future logging handlers. (OutputCapture.capture_output): Use our internal logging level instead of always using INFO. * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added. (OutputCaptureTest.setUp): Create an OutputCapture to test. (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level. (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings was logged. (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level. (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log level. 2011-11-29 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=72751 WebKit2.MouseMoveAfterCrash API test is failing Reviewed by Sam Weinig. Like DumpRenderTree, the NSWindow should act as an active window. * TestWebKitAPI/mac/PlatformWebViewMac.mm: (-[ActiveOffscreenWindow isKeyWindow]): (TestWebKitAPI::PlatformWebView::PlatformWebView): 2011-11-30 Gustavo Noronha Silva Add step to update gtk dependencies to the buildbot https://bugs.webkit.org/show_bug.cgi?id=73455 Reviewed by Martin Robinson. * BuildSlaveSupport/build.webkit.org-config/master.cfg: 2011-11-30 Jocelyn Turcotte [Qt] Add a fullscreen option to MiniBrowser. https://bugs.webkit.org/show_bug.cgi?id=73445 Reviewed by Noam Rosenthal. This bypasses the compositor on the N9 to increase performances and remove the huge useless gray bar part of the window frame at the bottom. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): * MiniBrowser/qt/MiniBrowserApplication.cpp: (printHelp): (MiniBrowserApplication::handleUserOptions): * MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::setStartFullScreen): (WindowOptions::startFullScreen): 2011-11-30 Martin Robinson [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild https://bugs.webkit.org/show_bug.cgi?id=73425 Reviewed by Gustavo Noronha Silva. Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will ensure that the jhbuild root is up-to-date. Currently the only module is the font module. * Scripts/update-webkitgtk-libs: Added. * gtk/common.py: Added a helper to get the number of CPUs. * gtk/jhbuild.modules: Added. * gtk/jhbuildrc: Added. 2011-11-30 Simon Hausmann [Qt] Remove dependency of Qt DRT on JavaScriptCore. Reviewed by Csaba Osztrogonác. * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway, instead of one that pulls in JavaScriptCore headers. * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers with load(javascriptcore). 2011-11-30 Sheriff Bot Unreviewed, rolling out r101440 and r101442. http://trac.webkit.org/changeset/101440 http://trac.webkit.org/changeset/101442 https://bugs.webkit.org/show_bug.cgi?id=73429 multiple crashes on layout tests (Requested by hayato on #webkit). * DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): * DumpRenderTree/chromium/TestShell.h: * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::WebViewHost): (WebViewHost::~WebViewHost): 2011-11-30 Fady Samuel [Chromium] Fix broken DRT build for Aura Linux https://bugs.webkit.org/show_bug.cgi?id=72667 Reviewed by Tony Chang. DRT now builds for Aura Linux. This, more or less, shares the same code as Android. The following changes have been made: 1. Renamed TestShellAndroid to TestShellLinux. 2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds. 3. Code common to Gtk, Aura, and Android moved to TestShellLinux. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed. * DumpRenderTree/chromium/TestShellGtk.cpp: * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp. (AlarmHandler): (TestShell::waitTestFinished): (setupFontconfig): (platformInit): * DumpRenderTree/chromium/TestShellStub.cpp: Added. (checkLayoutTestSystemDependencies): (openStartupDialog): 2011-11-30 Fady Samuel [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController https://bugs.webkit.org/show_bug.cgi?id=73328 Reviewed by Kent Tamura. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::enableFixedLayoutMode): (LayoutTestController::setFixedLayoutSize): 2011-11-29 Hayato Ito Skip writing the result of diff_image since non-chromium ports don't implement diff_image. https://bugs.webkit.org/show_bug.cgi?id=73381 Reviewed by Ryosuke Niwa. This is a quick fix for the breakage of tests on non-chromium port. We should implement diff_image later on non-chromium ports. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (write_test_result): 2011-11-29 Balazs Ankes [NRWT] Fix --platform=qt-5.0 --new-baseline combo https://bugs.webkit.org/show_bug.cgi?id=72489 Reviewed by Eric Seidel. Before the this fix always added "qt" option for the option list * Scripts/run-webkit-tests: * Scripts/webkitpy/layout_tests/port/qt.py: 2011-11-29 David Levin Add a way to revert a variable to its previous value after leaving a scope. https://bugs.webkit.org/show_bug.cgi?id=73371 Reviewed by Adam Barth. * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added. * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto. * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added. (TestWebKitAPI::TEST): Added a test for TemporarilyChange. 2011-11-28 Kentaro Hara Implement [Supplemental] IDL and support it in run-bindings-tests https://bugs.webkit.org/show_bug.cgi?id=73162 Reviewed by Adam Barth. run-bindings-tests supports the [Supplemental] IDL in the following way. (1) It creates a file |x| listing all IDL files. (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|. (3) For each IDL file |z|, it runs generate-bindings.pl with |y|. Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|, including all attributes in IDL files that are supplementing the IDL file |z|. * Scripts/run-bindings-tests: (generate_from_idl): (generate_supplemental_dependency): (detect_changes): (run_tests): (main): 2011-11-18 Nat Duca [chromium] Enable threaded compositing via CCThreadProxy::hasThread only https://bugs.webkit.org/show_bug.cgi?id=70838 Reviewed by James Robinson. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): * DumpRenderTree/chromium/TestShell.h: (TestShell::threadedCompositingEnabled): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::WebViewHost): (WebViewHost::~WebViewHost): 2011-11-29 Ojan Vafai List of builders in the flakiness dashboard is out of date https://bugs.webkit.org/show_bug.cgi?id=73347 Reviewed by Adam Barth. The chromium gpu bots no longer run layout tests, so kill that group entirely. * TestResultServer/static-dashboards/builders.js: * TestResultServer/static-dashboards/dashboard_base.js: 2011-11-29 Tor Arne Vestbø [Qt] Don't hard-code the list of WebKit2 generated sources The generated sources are... wait for it... generated. So use the generator itself to figure out which sources we need to compile. Reviewed by Simon Hausmann. * qmake/mkspecs/features/default_post.prf: 2011-11-29 Martin Robinson [GTK] Add a method to detect 'make dist' errors without running 'make dist' https://bugs.webkit.org/show_bug.cgi?id=73216 Reviewed by Philippe Normand. Add a script that tries to sniff out 'make dist' problems without running 'make dist.' 'make distcheck' takes a very long time to run and this should reduce the amount of times it needs to be run consecutively. * gtk/common.py: (get_build_path.is_valid_build_directory): Guess the source directory by the existence of the GNUmakefile instead of the .libs directory. This allows one to run the script after running autogen.sh but before fully building. * gtk/find-make-dist-errors: Added. 2011-11-29 Tor Arne Vestbø [Qt] Remove use of internal headers in the MiniBrowser Reviewed by Simon Hausmann. * MiniBrowser/qt/MiniBrowser.pro: 2011-11-29 Simon Hausmann [Qt] Fix debug-shlib build without webkit2 Reviewed by Tor Arne Vestbø. * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2. 2011-11-28 Csaba Osztrogonác [Qt][WK2] Unreviewed buildfix after r101307. * qmake/mkspecs/features/webkit2.prf: Add missing includepath. 2011-11-29 Roland Steiner