2008-06-26 Anders Carlsson Reviewed by Darin. Add a new MainThreadObjectDeallocator which can schedule dealloc calls on the main thread if necessary. Use this for the WebView class. * WebView/MainThreadObjectDeallocator.h: Added. * WebView/MainThreadObjectDeallocator.mm: Added. (deallocCallback): (scheduleDeallocateOnMainThread): * WebView/WebView.mm: (-[WebViewPrivate dealloc]): (+[WebView initialize]): 2008-06-25 Anders Carlsson Reviewed by Mark. REGRESSION (Tiger only) : Mail crashes because message load is being processed on a secondary thread * WebView/WebView.mm: (tigerMailReleaseIMP): New method that makes sure that the final release happens on the main thread. (-[WebView release]): New method that just calls [super release]; (+[WebView initialize]): When running under Tiger mail, replace the release method with tigerMailReleaseIMP. 2008-06-19 Alexey Proskuryakov Reviewed by Geoff. Make Machine per-JSGlobalData. * WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): 2008-06-17 Alexey Proskuryakov Reviewed by Darin. Prepare JavaScript heap for being per-thread. * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): (+[WebCoreStatistics javaScriptGlobalObjectsCount]): (+[WebCoreStatistics javaScriptProtectedObjectsCount]): (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): Use JSGlobalData::threadInstance()->heap instead of static Collector calls. 2008-06-17 Darin Adler Reviewed by Sam. * WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new to create a CSSMutableStyleDeclaration. 2008-06-16 Mark Rowe Reviewed by Darin Adler. WebHTMLHighlighter mistakenly gained two new methods, causing compile warnings _pauseNullEventsForAllNetscapePlugins and _resumeNullEventsForAllNetscapePlugins ended up being declared both in WebHTMLViewInternal.h and as members of the WebHTMLHighlighter protocol in WebHTMLViewPrivate.h. They don't belong in the protocol, but they do need to be available outside of WebKit so they're being moved to the correct location in WebHTMLViewPrivate.h and removed from WebHTMLViewInternal.h. * WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): * WebView/WebHTMLViewInternal.h: * WebView/WebHTMLViewPrivate.h: 2008-06-15 Darin Adler - give Frame object functions shorter names: scriptProxy() -> script(), selectionController() -> selection(), animationController() -> animation() * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerSelectionColor]): * WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]): (-[WebFrame _hasSelection]): (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebFrame _convertToNSRange:]): (-[WebFrame _convertToDOMRange:]): (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): (-[WebFrame _insertParagraphSeparatorInQuotedContent]): (-[WebFrame _selectedNSRange]): (-[WebFrame _selectNSRange:]): (-[WebFrame globalContext]): * WebView/WebHTMLView.mm: (-[WebHTMLView _selectedRange]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): (-[WebHTMLView _updateFocusedAndActiveState]): (-[WebHTMLView readSelectionFromPasteboard:]): (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView maintainsInactiveSelection]): (-[WebHTMLView paste:]): (isTextInput): (-[WebHTMLView inputContext]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView selectAll]): (-[WebHTMLView deselectAll]): (-[WebHTMLView selectedAttributedString]): * WebView/WebView.mm: (-[WebView aeDescByEvaluatingJavaScriptFromString:]): (-[WebView setSelectedDOMRange:affinity:]): (-[WebView selectedDOMRange]): (-[WebView selectionAffinity]): 2008-06-15 Darin Adler - rename KJS::List to KJS::ArgList * WebView/WebScriptDebugger.h: 2008-06-15 Darin Adler - new names for more JavaScriptCore files * WebView/WebView.mm: 2008-06-15 Darin Adler - new names for a few key JavaScriptCore files * ForwardingHeaders/kjs/JSFunction.h: Copied from WebKit/mac/ForwardingHeaders/kjs/function.h. * ForwardingHeaders/kjs/JSObject.h: Copied from WebKit/mac/ForwardingHeaders/kjs/object.h. * ForwardingHeaders/kjs/JSString.h: Copied from WebKit/mac/ForwardingHeaders/kjs/internal.h. * ForwardingHeaders/kjs/JSValue.h: Copied from WebKit/mac/ForwardingHeaders/kjs/value.h. * ForwardingHeaders/kjs/function.h: Removed. * ForwardingHeaders/kjs/internal.h: Removed. * ForwardingHeaders/kjs/object.h: Removed. * ForwardingHeaders/kjs/value.h: Removed. * WebView/WebScriptDebugDelegate.mm: 2008-06-15 Darin Adler Rubber stamped by Sam. - use JS prefix and simpler names for basic JavaScriptCore types, to complement JSValue and JSObject * WebView/WebView.mm: (aeDescFromJSValue): 2008-06-14 Darin Adler Rubber stamped by Sam. - new names for kjs_binding.h and kjs_proxy.h * WebView/WebFrame.mm: * WebView/WebScriptDebugDelegate.mm: * WebView/WebView.mm: 2008-06-14 Darin Adler Rubber stamped by Sam. - renamed HTMLGenericFormElement to HTMLFormControlElement * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementWithName:inForm:]): (-[WebHTMLRepresentation controlsInForm:]): 2008-06-14 Darin Adler Reviewed by Sam. - more of https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader): Use create instead of new. (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by a ref call inside the Frame constructor. The lifetime rules for Frame are now the conventional ones without a special case. * WebView/WebDataSource.mm: (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since this function takes ownership of the DocumentLoader. (-[WebDataSource initWithRequest:]): Use create instead of new. * WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a PassRefPtr and also cleaned up the header a bit. * WebView/WebDocumentLoaderMac.h: (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual functions private. * WebView/WebFrame.mm: (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead of new. 2008-06-14 Darin Adler Reviewed by Sam. - more work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed * WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): 2008-06-13 Darin Adler Reviewed by John Sullivan. - updated for addition of FormState argument to action policy functions - added WebActionFormKey * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::actionDictionary): * WebKit.exp: * WebView/WebPolicyDelegate.mm: * WebView/WebPolicyDelegatePrivate.h: 2008-06-12 John Sullivan Reviewed by Dan and Darin Clear up the confusion about _close (older private method) vs -close (newer public method). * WebView/WebView.mm: (-[WebView _isClosed]): simplified style (-[WebView _close]): added a comment about how clients and subclasses should use -close instead (-[WebView dealloc]): call -close instead of _close, so subclasses that override the public method will have the intended behavior (-[WebView close]): added a comment (-[WebView _windowWillClose:]): call -close instead of _close, so subclasses that override the public method will have the intended behavior * WebView/WebViewPrivate.h: added a comment about how clients and subclasses should use -close instead 2008-06-07 Darin Adler Reviewed by Mitz. - work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed * History/WebHistoryItem.mm: (-[WebHistoryItem init]): (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]): * WebView/WebView.mm: (+[WebView _decodeData:]): 2008-06-03 Oliver Hunt Reviewed by Tim. Bug 12983: Web Inspector break on the debugger keyword Add stubs to allow old webkit debugger interface to build. * WebView/WebScriptDebugger.h: * WebView/WebScriptDebugger.mm: 2008-06-03 Anders Carlsson Reviewed by Darin. In 64-bit Web Kit, converting between float and double, can cause rounding errors which in turn causes newBottom to be larger than oldBottom which is illegal. * WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): 2008-06-02 Anders Carlsson Reviewed by Mitz. Speculative fix for CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62 Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause layouts to be triggered. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView _createPlugin]): 2008-05-29 Justin Garcia Reviewed by Darin. REGRESSION: Can't paste screen captures into Mail AppKit started putting PNG instead of PICT onto the pasteboard for screen captures. Added support for PNG with kUTTypePNG. Tiger doesn't support setting and retrieving pasteboard types with UTIs, but we don't know of any applications on Tiger that put only PNG on the pasteboard. * WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): 2008-05-29 Anders Carlsson Reviewed by Brady. icon file specified for stand alone web app causes crash if the icon can't be found Handle the case where iconData is null. * Misc/WebIconFetcher.mm: (WebIconFetcherClient::finishedFetchingIcon): 2008-05-29 Anders Carlsson Reviewed by Mitz. https://bugs.webkit.org/show_bug.cgi?id=19313 Add version member to NPCocoaEvent Initialize the version member to 0 for all events. * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (initializeEvent): (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged): 2008-05-29 Dan Bernstein Reviewed by Jessica Kahn. - fix Page 2 does not print correctly When printing, _recursiveDisplayRectIfNeededIgnoringOpacity:... and _recursiveDisplayAllDirtyWithLockFocus:... can be invoked without -viewWillDraw being sent first, which could lead to painting without valid layout. The fix is to ensure up-to-date layout in those methods when printing. * WebView/WebHTMLView.mm: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): 2008-05-28 Anders Carlsson Reviewed by Jon. Remove workaround, this is no longer a problem. * WebView/WebView.mm: (-[WebView _removeObjectForIdentifier:]): 2008-05-27 Geoffrey Garen Reviewed by Tim Hatcher. Fixed https://bugs.webkit.org/show_bug.cgi?id=19183 REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when clicking button in returnEvent-crash.html Added implementations for willExecuteProgram and didExecuteProgram, which take care of making sure we're not hanging on to stale data. 2008-05-27 Timothy Hatcher Fixes a bug where unplugging the monitor from a video card and moving it to another video card would no longer show OpenGL plugins until you relaunched Safari. Add AllowOfflineDisplays pixel format attribute to OpenGL contexts Reviewed by Kevin Decker. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds. (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto. 2008-05-25 Mark Rowe Reviewed by Darin Adler. _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined Follow-up for r33052. _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit. * WebView/WebFrame.mm: (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): * WebView/WebFrameInternal.h: * WebView/WebFramePrivate.h: 2008-05-23 Timothy Hatcher Fix attaching and detaching the Web Inspector. This change removes the clunky animation that never looked right and was causing issues where the inspected WebView would get into a no useable state. Attaching and Detaching the Web Inspector can cause the inspected WebVIew to be unusable Reviewed by Adam Roben. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close]): Removes animation code. Sets the frame directly and does a displayIfNeeded to prevent showing the Inspector in the page and in the Inspector window. (-[WebInspectorWindowController showWindow:]): Removes animation code. Sets the frame directly. (-[WebInspectorWindowController attach]): Simplified. (-[WebInspectorWindowController detach]): Ditto. 2008-05-22 Dan Bernstein Reviewed by Darin Adler. - fix broken documentation of webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame: * WebView/WebUIDelegate.h: Fixed method name in HeaderDoc for -webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame: 2008-05-22 Timothy Hatcher Update the Develop menu to match the new Inspector items Reviewed by Adam Roben. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWebInspector:]): (-[WebInspectorWindowController showErrorConsole:]): (-[WebInspectorWindowController toggleDebuggingJavaScript:]): (-[WebInspectorWindowController toggleProfilingJavaScript:]): (-[WebInspectorWindowController validateUserInterfaceItem:]): * WebInspector/WebInspector.h: * WebInspector/WebInspector.mm: (-[WebInspector showConsole:]): (-[WebInspector showTimeline:]): (-[WebInspector isDebuggingJavaScript]): (-[WebInspector toggleDebuggingJavaScript:]): (-[WebInspector startDebuggingJavaScript:]): (-[WebInspector stopDebuggingJavaScript:]): (-[WebInspector isProfilingJavaScript]): (-[WebInspector toggleProfilingJavaScript:]): (-[WebInspector startProfilingJavaScript:]): (-[WebInspector stopProfilingJavaScript:]): 2008-05-22 Josh Aas Reviewed by Anders. https://bugs.webkit.org/show_bug.cgi?id=19192 remove NPNVpluginEventModel, fix example plugin * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView getVariable:value:]): 2008-05-21 Anders Carlsson Reviewed by Maciej. Add WebIconFetcher. * Misc/WebIconFetcher.h: Added. * Misc/WebIconFetcher.mm: Added. (WebIconFetcherClient::WebIconFetcherClient): (WebIconFetcherClient::finishedFetchingIcon): (WebIconFetcherClient::setFetcher): (-[WebIconFetcher init]): (-[WebIconFetcher dealloc]): (-[WebIconFetcher finalize]): (-[WebIconFetcher cancel]): (-[WebIconFetcher _initWithIconFetcher:client:]): (+[WebIconFetcher _fetchApplicationIconForFrame:target:selector:]): * Misc/WebIconFetcherInternal.h: Added. * WebView/WebFrame.mm: (-[WebFrame fetchApplicationIcon:selector:]): * WebView/WebFramePrivate.h: === End merge of squirrelfish === 2008-05-21 Geoffrey Garen Reviewed by Tim Hatcher. Updated for API changes from merging with trunk WebCore's new debugger. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]): Explicitly check for an exception return, since the DebuggerCallFrame no longer automatically substitutes the exception for the return value. * WebView/WebScriptDebugger.mm: Use the dynamic global object, not the lexical global object, since the debugger attaches based on dynamic global object. 2008-05-17 Geoffrey Garen Reviewed by Oliver Hunt. Re-enabled previously disabled debugging functionality. There are two major changes from how the WebKit debugger used to work: (1) All the interesting bits are implemented down in JavaScriptCore. The debugger just calls through to KJS::DebuggerCallFrame for everything. (2) Instead of copyihng a pointer to an ExecState once, the debugger copies the DebuggerCallFrame passed to it in each callback. This is because the VM no longer maintains a fully transparent execution state to which you can hold a pointer, and the DebuggerCallFrames it vends are temporaries. Also, we NULL out a WebScriptCallFrame's DebuggerCallFrame upon return from its function. This is safer than the old method, which was to hold a stale ExecState* and hope for the best. 2008-05-13 Geoffrey Garen Reviewed by Oliver Hunt. Updated for API changes in KJS::Debugger. * WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]): Changed the order of operations to fix an ASSERT that can happen when re-entering _attachScriptDebugger. 2008-05-13 Geoffrey Garen Reviewed by Oliver Hunt. Updated WebScriptDebugger API to accept a SourceProvider instead of a WebCore::String, to avoid copying. (WebScriptDebugger::sourceParsed): Updated this function not to return a value. 2008-04-30 Geoffrey Garen Build fix: #ifdef'd out some code that doesn't work anymore. 2008-04-30 Geoffrey Garen Reviewed by Oliver Hunt. #ifdef'd out some debugger code that doesn't work anymore. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): 2008-04-21 Geoffrey Garen Build fix. * ChangeLog: * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): 2008-03-30 Geoffrey Garen Reviewed by Oliver Hunt. Build fix. === Start merge of squirrelfish === 2008-05-21 Darin Adler - fix build * WebView/WebViewPrivate.h: Remove declaration of closeWithFastTeardown. We can add it back later if we want, but if we do, we should probably make some refinements like checking _private->closed and applicationIsTerminating. 2008-05-21 Darin Adler Reviewed by Anders and Kevin Decker. - fix REGRESSION: crash on quit after reopening windows from previous session * WebView/WebView.mm: (-[WebViewPrivate dealloc]): Fix assertions to not complain when fast teardown is used. (-[WebView _closePluginDatabases]): Factored out some common code from both versions of close. (-[WebView _closeWithFastTeardown]): Added an underscore to this method's name, since it's internal. Streamlined the code a bit. Added a line of code to set _private->closed (this is the bug fix). (-[WebView _close]): Changed for new method name and to use _closePluginDatabases. 2008-05-19 Stephanie Lewis Reviewed by Darin. more fast teardown performance work * Misc/WebDownload.m: (-[WebDownloadInternal downloadDidBegin:]): (-[WebDownloadInternal downloadDidFinish:]): (-[WebDownloadInternal download:didFailWithError:]): * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::disableSuddenTermination): (WebChromeClient::enableSuddenTermination): 2008-05-18 Dan Bernstein Reviewed by Sam Weinig. - fix IDNs are displayed as punycode in the authentication panel * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): 2008-05-16 Timothy Hatcher Removes WebScriptDebugServer files and related calls. This removes the hooks that Drosera uses for debugging. Now that the Web Inspector has a better debugger, we don't need these anymore. Reviewed by Sam Weinig. * DefaultDelegates/WebScriptDebugServer.h: Removed. * DefaultDelegates/WebScriptDebugServer.m: Removed. * DefaultDelegates/WebScriptDebugServerPrivate.h: Removed. * WebCoreSupport/WebFrameLoaderClient.mm: * WebKit.exp: * WebView/WebScriptDebugDelegate.mm: * WebView/WebScriptDebugger.mm: (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception): * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): * WebView/WebViewPrivate.h: 2008-05-16 Brady Eidson Reviewed by Anders - Need to standardize LocalStorage persistence path Took the opportunity to touch up another pref that needs the same standardization. That pref is currently not in use on Mac. * WebView/WebPreferences.m: (-[WebPreferences _setFTPDirectoryTemplatePath:]): (-[WebPreferences _localStorageDatabasePath]): (-[WebPreferences _setLocalStorageDatabasePath:]): (-[WebPreferences _ftpDirectoryTemplatePath]): 2008-05-16 Chris Fleizach Reviewed by Alice Liu REGRESSION:Selecting ranges of text should be possible using the keyboard (15310) * WebView/WebFrame.mm: (-[WebFrame _accessibilityTree]): 2008-05-15 Stephanie Lewis fix mac build * WebView/WebView.mm: (-[WebView closeWithFastTeardown]): 2008-05-15 Stephanie Lewis Reviewed by Anders. Turn on fast teardown. I added a preference for using full teardown because the LEAKS output will be useless without a full teardown. preference for fullteardown * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.m: (-[WebPreferences setFullDocumentTeardownEnabled:]): (-[WebPreferences fullDocumentTeardownEnabled]): * WebView/WebPreferencesPrivate.h: on application quit dispatch unload events and destroy plugins then exit * WebView/WebView.mm: (-[WebView closeWithFastTeardown]): (-[WebView _close]): * WebView/WebViewPrivate.h: 2008-05-15 Stephanie Lewis Reviewed by Anders. get the pending frame unload count from WebCore * WebView/WebFrame.mm: (-[WebFrame _pendingFrameUnloadEventCount]): * WebView/WebFramePrivate.h: 2008-05-15 John Sullivan Reviewed by Kevin Decker - fixed Inspector highlighting moves to bottom-left corner of screen when new tab appears The highlight should go away entirely, but this simple patch just makes it not jump away. The issue with it not going away entirely is harder to fix and covered by * WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight _repositionHighlightWindow]): Bail out if target view isn't in a window 2008-05-15 Stephanie Lewis Reviewed by Anders. Track views that contain plugin instances so that they can be destroyed at application quit without walking the entire document tree. Add/Remove Netscape plugin views from instance list. Start/stop are when netscape plugins are created and destroyed * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): Add/remove WebKit plugin views from instance list * Plugins/WebPluginController.mm: (-[WebPluginController addPlugin:]): (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]): Add a set of views with plugin instances to the WebPluginDatabase * Plugins/WebPluginDatabase.h: * Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase init]): (-[WebPluginDatabase dealloc]): (-[WebPluginDatabase addPluginInstanceView:]): (-[WebPluginDatabase removePluginInstanceView:]): (-[WebPluginDatabase removePluginInstanceViewsFor:]): (-[WebPluginDatabase destroyAllPluginInstanceViews]): Handle cases where plugin views are detached before the plugin is destroyed. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::transitionToCommittedFromCachedPage): (WebFrameLoaderClient::transitionToCommittedForNewPage): Add plugin instances to the set in the WebPluginDatabase by way of the WebView * WebView/WebHTMLView.mm: (-[WebHTMLView _destroyAllWebPlugins]): * WebView/WebHTMLViewInternal.h: * WebView/WebView.mm: (-[WebView addPluginInstanceView:]): (-[WebView removePluginInstanceView:]): (-[WebView removePluginInstanceViewsFor:]): * WebView/WebViewInternal.h: 2008-05-15 Brady Eidson Reviewed by Tim Hatcher Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path before setting the page group of the new page. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Set the LocalStorage path immediately after creating the page so it is in place for initializing the LocalStorageThread 2008-05-15 Timothy Hatcher Fixes the bug where the Web Inspector would flash white while resizing. This was cause by deferring the window creation. REGRESSION: Inspector flickers horribly while resizing (17979) Reviewed by Darin Adler. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]): Don't defer the window creation. 2008-05-15 Alexey Proskuryakov Tiger build fix. * Misc/WebNSAttributedStringExtras.mm: Import WebTypesInternal.h for NSUInteger. 2008-05-15 Adele Peterson Reviewed and landed by Alexey. Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:]. * Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]): 2008-05-14 Eric Seidel Reviewed by Oliver. Add missing NULL check to match rest of file, this was found by the editing fuzzer. * WebView/WebResource.mm: (-[WebResource data]): 2008-05-14 Alexey Proskuryakov Reviewed by Dan Bernstein. NPP_ValidAttributesForMarkedText should return NSArray*, not NSArray. * Plugins/nptextinput.h: 2008-05-13 Anders Carlsson Reviewed by Sam. Don't empty the application cache in _setCacheModel, since it will be called during initialization. Instead, do it in [WebCache empty]. * Misc/WebCache.mm: (+[WebCache empty]): * WebView/WebView.mm: (+[WebView _setCacheModel:]): 2008-05-13 chris fleizach Reviewed by Beth Dakin WebKit application has its window announced as HTML content * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory AXWebAreaText]): 2008-05-13 Timothy Hatcher Fixes a crash seen in Xcode where CallUIDelegateReturningBoolean was referencing a nil WebView under validateUserInterfaceItem. The validateUserInterfaceItem methods was being called at a time when the WebHTMLView is being torndown. A crash occurs at CallUIDelegateReturningBoolean() while mousing down on menu bar after Xcode News window is opened Reviewed by Ada Chan. * WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItem:]): NULL check the WebView and return NO when it is nil. Adds a comment. * WebView/WebPDFView.mm: (-[WebPDFView validateUserInterfaceItem:]): Ditto. 2008-05-13 Mark Rowe Reviewed by John Sullivan. HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework * Carbon/HIWebView.h: Remove HIWebViewCreateWithClass. * Carbon/HIWebView.m: Ditto. (HIWebViewCreate): (HIWebViewConstructor): 2008-05-12 Dan Bernstein Reviewed by Ada Chan. - WebKit/mac changes for https://bugs.webkit.org/show_bug.cgi?id=17097 CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound Added font cache statistics and a function to purge inactive font data. * Misc/WebCoreStatistics.h: * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics cachedFontDataCount]): (+[WebCoreStatistics cachedFontDataInactiveCount]): (+[WebCoreStatistics purgeInactiveFontData]): (+[WebCoreStatistics glyphPageCount]): 2008-05-12 Mark Rowe Reviewed by Tim Hatcher. Decorate some deprecated delegate methods with the availability macros. The compiler doesn't appear to warn if a delegate implements these methods, but using the availability macros is good for consistency and documentation. * WebView/WebFrameLoadDelegate.h: * WebView/WebUIDelegate.h: 2008-05-12 Mark Rowe Reviewed by Tim Hatcher. Deprecate HIWebView Use of HIWebView is deprecated in favor of embedding a WebView in a HICocoaView. * Carbon/CarbonUtils.h: Include the availability macro header and decorate the functions appropriately. * Carbon/HIWebView.h: Ditto. 2008-05-12 Kevin Decker Reviewed by Anders. Fixed: _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined Re-added these SPI methods because they are needed by some clients. They were accidentally removed in changeset * Plugins/WebBaseNetscapePluginView.h: Added stopTimers, restartTimers to the header. * WebView/WebFrame.mm: (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Re-addd. (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Ditto. * WebView/WebFrameInternal.h: Ditto. * WebView/WebHTMLView.mm: Ditto. (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Ditto. (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto. * WebView/WebHTMLViewInternal.h: Ditto. * WebView/WebHTMLViewPrivate.h: Ditto. 2008-05-12 Anders Carlsson Reviewed by Alexey. Empty the application cache when changing the cache model. * WebView/WebView.mm: (+[WebView _setCacheModel:]): 2008-05-12 Anders Carlsson Reviewed by Oliver. Make Unicode text input possible in Netscape-style plug-ins * Plugins/WebBaseNetscapePluginView.h: * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView start]): Get the plug-in text input vtable pointer. (-[WebBaseNetscapePluginView stop]): Set the plug-in text input vtable pointer to 0. (-[WebBaseNetscapePluginView inputContext]): Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them. (-[WebBaseNetscapePluginView hasMarkedText]): (-[WebBaseNetscapePluginView insertText:]): (-[WebBaseNetscapePluginView markedRange]): (-[WebBaseNetscapePluginView selectedRange]): (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]): (-[WebBaseNetscapePluginView unmarkText]): (-[WebBaseNetscapePluginView validAttributesForMarkedText]): (-[WebBaseNetscapePluginView attributedSubstringFromRange:]): (-[WebBaseNetscapePluginView characterIndexForPoint:]): (-[WebBaseNetscapePluginView doCommandBySelector:]): (-[WebBaseNetscapePluginView firstRectForCharacterRange:]): (-[WebBaseNetscapePluginView conversationIdentifier]): Implement NSTextInput and call into the plug-in text input vtable. (browserTextInputFuncs): New method which returns the browser input vtable. (-[WebBaseNetscapePluginView getVariable:value:]): Support getting the browser input vtable pointer. * Plugins/WebNetscapePluginEventHandlerCocoa.h: * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::keyDown): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent, it means that the event should be passed on to the input manager. * Plugins/npapi.mm: (NPN_MarkedTextAbandoned): (NPN_MarkedTextSelectionChanged): Add implementations of browser input method methods. * Plugins/nptextinput.h: Added. Add file with new text input API. 2008-05-12 Alexey Proskuryakov Roll out recent threading changes (r32807, r32810, r32819, r32822) to simplify SquirrelFish merging. * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): (+[WebCoreStatistics javaScriptGlobalObjectsCount]): (+[WebCoreStatistics javaScriptProtectedObjectsCount]): (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]): 2008-05-07 Anders Carlsson Reviewed by Mitz. REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view https://bugs.webkit.org/show_bug.cgi?id=18880 Stop suspending key up events before calling handleEvent. * Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::sendEvent): 2008-05-06 Stephanie Lewis Reviewed by Andersca. prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file. * Plugins/WebPluginDatabase.m: Removed. * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m. * Plugins/npapi.m: Removed. * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m. 2008-05-06 Anders Carlsson Reviewed by Darin. Initialize numArchs to 0. * Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage isNativeLibraryData:]): 2008-05-06 Anders Carlsson Reviewed by Darin. Add implementation of NPN_PopUpContextMenu. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView popUpContextMenu:]): * Plugins/WebBaseNetscapePluginViewPrivate.h: * Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): * Plugins/npapi.m: (NPN_PopUpContextMenu): 2008-05-06 Anders Carlsson Fix typo (don't read random memory). * Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage isNativeLibraryData:]): 2008-05-05 Anders Carlsson Reviewed by Darin. Change the isNativeLibraryData: method to handle universal binaries. * Plugins/WebBasePluginPackage.m: (swapIntsInHeader): (-[WebBasePluginPackage isNativeLibraryData:]): 2008-05-06 Brady Eidson Reviewed by Darin Adler Preparation for upcoming work making LocalStorage persistent. When the application terminates, all LocalStorage areas must be sync'ed out to disk first. * WebView/WebView.mm: (+[WebView _applicationWillTerminate]): Close all LocalStorage areas before quitting. 2008-05-05 Sam Weinig Reviewed by Darin Adler. Fix for Escape look-a-like characters from the the entire url. * Misc/WebNSURLExtras.mm: (escapeUnsafeCharacters): (-[NSURL _web_userVisibleString]): 2008-05-05 Justin Garcia Reviewed by Darin. REGRESSION: Creating a new quote places caret at beginning of quote instead of the end * WebView/WebView.mm: (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to the document for Tiger and Leopard Mail. There is code in Mail that does it, and the two interfere. 2008-05-05 Sam Weinig Reviewed by Tim Hatcher. Make the Inspector's localizable strings file match the format used by Dashboard widgets. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::localizedStringsURL): 2008-05-05 Anders Carlsson Reviewed by Jess. Apparently preflighting can cause hangs for some reason. Revert this for now. * Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]): * Plugins/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): 2008-05-05 Darin Adler Reviewed by Mitz. - https://bugs.webkit.org/show_bug.cgi?id=18789 fix some shouldCloseWithWindow edge cases * WebView/WebView.mm: (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the NSWindowWillCloseNotification if the view was moved out of the window but still had that window set as the host window. Also make sure this function doesn't do anything if the WebView is already closed. (-[WebView setHostWindow:]): Ditto. 2008-05-04 David Kilzer Make parameters match for WebChromeClient::addMessageToConsole() Reviewed by John. * WebCoreSupport/WebChromeClient.h: (WebChromeClient::addMessageToConsole): Renamed sourceID parameter to sourceURL to match implementation in WebChromeClient.mm. 2008-05-02 Anders Carlsson Reviewed by Mark. Various Cocoa event model and 64-bit plug-in fixes. * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): Set click count. (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): Don't try to get the mouse location for keyboard events. * Plugins/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit. 2008-05-02 Anders Carlsson Reviewed by Sam. The event union is now named. * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged): 2008-05-02 Anders Carlsson Reviewed by Mark. Make sure that 32-bit only plug-ins aren't shown when running as 64-bit. Call preflightAndReturnError on the bundle, which will check if any of the architectures in the bundle match the current architecture. * Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]): 2008-05-02 Alexey Proskuryakov Reviewed by Geoffrey Garen. https://bugs.webkit.org/show_bug.cgi?id=18826 Make JavaScript heap per-thread * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): (+[WebCoreStatistics javaScriptGlobalObjectsCount]): (+[WebCoreStatistics javaScriptProtectedObjectsCount]): (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): Replaced static Collector calls with calls to a current thread's instance. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]): Pass ExecState to jsString(). 2008-05-01 Anders Carlsson Reviewed by Mark. 64-bit NPAPI plugin build fixes. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView updateAndSetWindow]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView windowBecameKey:]): * Plugins/WebNetscapeDeprecatedFunctions.c: * Plugins/WebNetscapeDeprecatedFunctions.h: * Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create): * Plugins/WebNetscapePluginEventHandlerCarbon.h: * Plugins/WebNetscapePluginEventHandlerCarbon.mm: * Plugins/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): 2008-05-01 Anders Carlsson Reviewed by Tim. Remove duplicate npfunctions.h header from WebKit. * MigrateHeaders.make: Migrate npfunctions.h * Plugins/npfunctions.h: Removed. 2008-05-01 Anders Carlsson Reviewed by John. Add null checks for the event handler. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): 2008-05-01 Anders Carlsson Fix 64-bit build. * Plugins/WebNetscapePluginEventHandlerCocoa.h: * Plugins/WebNetscapePluginEventHandlerCocoa.mm: * WebCoreSupport/WebFrameLoaderClient.mm: 2008-05-01 Anders Carlsson Fix build. * Plugins/npfunctions.h: 2008-05-01 Anders Carlsson Reviewed by Adam. Forward mouse move events to the Netscape plug-in view. * Plugins/WebBaseNetscapePluginView.h: * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView handleMouseMoved:]): New method that just calls the current event handler. * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::flagsChanged): NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors don't work on it so don't call them. * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): New Widget subclass to be used for Netscape plug-ins. (NetscapePluginWidget::handleEvent): Forward NSMouseMoved events to the plug-in. (WebFrameLoaderClient::createPlugin): Wrap the plug-in view in a NetscapePluginWidget. 2008-05-01 Alp Toker Rubber-stamped by Anders. GTK+ build fix for changes in r32752. Use int32, not int32_t types in npapi.h. Additional fix to use same signedness in npapi.h and Mac for the interval parameter. * Plugins/WebBaseNetscapePluginView.h: * Plugins/WebBaseNetscapePluginView.mm: (PluginTimer::PluginTimer): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): (-[WebBaseNetscapePluginView unscheduleTimer:]): * Plugins/WebBaseNetscapePluginViewPrivate.h: * Plugins/npapi.m: (NPN_ScheduleTimer): (NPN_UnscheduleTimer): * Plugins/npfunctions.h: 2008-04-30 Anders Carlsson Reviewed by Adam. Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods. * Plugins/WebBaseNetscapePluginView.h: * Plugins/WebBaseNetscapePluginView.mm: (PluginTimer::PluginTimer): (PluginTimer::start): (PluginTimer::fired): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView eventModel]): (-[WebBaseNetscapePluginView fini]): (-[WebBaseNetscapePluginView getVariable:value:]): (-[WebBaseNetscapePluginView setVariable:value:]): (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): (-[WebBaseNetscapePluginView unscheduleTimer:]): * Plugins/WebBaseNetscapePluginViewInternal.h: * Plugins/WebBaseNetscapePluginViewPrivate.h: * Plugins/WebNetscapePluginEventHandler.h: * Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create): * Plugins/WebNetscapePluginEventHandlerCarbon.h: * Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::scrollWheel): (WebNetscapePluginEventHandlerCarbon::flagsChanged): (WebNetscapePluginEventHandlerCarbon::platformWindow): * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added. (WebNetscapePluginEventHandlerCocoa::startTimers): (WebNetscapePluginEventHandlerCocoa::stopTimers): * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added. (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa): (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::mouseDown): (WebNetscapePluginEventHandlerCocoa::mouseDragged): (WebNetscapePluginEventHandlerCocoa::mouseEntered): (WebNetscapePluginEventHandlerCocoa::mouseExited): (WebNetscapePluginEventHandlerCocoa::mouseMoved): (WebNetscapePluginEventHandlerCocoa::mouseUp): (WebNetscapePluginEventHandlerCocoa::scrollWheel): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::keyDown): (WebNetscapePluginEventHandlerCocoa::keyUp): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged): (WebNetscapePluginEventHandlerCocoa::platformWindow): (WebNetscapePluginEventHandlerCocoa::sendEvent): * Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): * Plugins/npapi.m: (NPN_ScheduleTimer): (NPN_UnscheduleTimer): * Plugins/npfunctions.h: 2008-04-30 Brady Eidson Fix my WebPreferences revert check-in * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): 2008-04-30 Brady Eidson Rubberstamped by John Sullivan Revert the remainder of my original preferences changes from last week. They caused a massive PLT regression (too many notifications being sent out or listened to that weren't previously) and it's not in my schedule to refine the preferences code instead of working on my feature! * WebView/WebView.mm: (-[WebView _updateSettingsFromPreferences:]): (-[WebView _commonInitializationWithFrameName:groupName:]): 2008-04-30 Anders Carlsson Fix the 64-bit build. * Plugins/WebNetscapePluginEventHandler.h: * Plugins/WebNetscapePluginEventHandler.mm: * Plugins/WebNetscapePluginEventHandlerCarbon.h: * Plugins/WebNetscapePluginEventHandlerCarbon.mm: 2008-04-29 David D. Kilzer BUILD FIX for Release build. * Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent separately so the compiler doesn't complain about an unused variable. (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto. 2008-04-29 Anders Carlsson Reviewed by Adam. Refactor the Carbon event handling code out into a separate class in preparation for adding the Cocoa event handling code. * Plugins/WebBaseNetscapePluginView.h: * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView fini]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView windowDidMiniaturize:]): (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView _viewHasMoved]): * Plugins/WebBaseNetscapePluginViewInternal.h: * Plugins/WebNetscapePluginEmbeddedView.h: * Plugins/WebNetscapePluginEventHandler.h: Added. (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler): (WebNetscapePluginEventHandler::currentEventIsUserGesture): (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler): * Plugins/WebNetscapePluginEventHandler.mm: Added. (WebNetscapePluginEventHandler::create): * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added. * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added. (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon): (getCarbonEvent): (modifiersForEvent): (WebNetscapePluginEventHandlerCarbon::sendNullEvent): (WebNetscapePluginEventHandlerCarbon::drawRect): (WebNetscapePluginEventHandlerCarbon::mouseDown): (WebNetscapePluginEventHandlerCarbon::mouseUp): (WebNetscapePluginEventHandlerCarbon::mouseEntered): (WebNetscapePluginEventHandlerCarbon::mouseExited): (WebNetscapePluginEventHandlerCarbon::mouseDragged): (WebNetscapePluginEventHandlerCarbon::mouseMoved): (WebNetscapePluginEventHandlerCarbon::keyDown): (keyMessageForEvent): (WebNetscapePluginEventHandlerCarbon::keyUp): (WebNetscapePluginEventHandlerCarbon::focusChanged): (WebNetscapePluginEventHandlerCarbon::windowFocusChanged): (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler): (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler): (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired): (WebNetscapePluginEventHandlerCarbon::startTimers): (WebNetscapePluginEventHandlerCarbon::stopTimers): (WebNetscapePluginEventHandlerCarbon::sendEvent): 2008-04-29 Mark Rowe Reviewed by David Harrison. Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building. * WebKit.exp: * WebView/WebDynamicScrollBarsView.h: * WebView/WebDynamicScrollBarsView.m: 2008-04-29 Greg Bolsinga Reviewed by Darin. Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT) * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: * WebView/WebClipView.m: (-[WebClipView scrollWheel:]): * WebView/WebHTMLView.mm: (-[WebHTMLView addMouseMovedObserver]): (-[WebHTMLView removeMouseMovedObserver]): (-[WebHTMLView acceptsFirstMouse:]): * WebView/WebUIDelegatePrivate.h: * WebView/WebView.mm: (-[WebViewPrivate init]): * WebView/WebViewPrivate.h: 2008-04-28 Rob Buis Reviewed by Maciej. Build fix for Tiger. * WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): 2008-04-28 Adele Peterson Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler. WebKit part of fix for Safari should have a way to upload bundles from the file upload control (as zip) Added UIDelegate methods to let the application handle generating replacement files for uploads. In this case, Safari will create archived files for bundles so they can be uploaded properly. * DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]): (-[WebDefaultUIDelegate webView:generateReplacementFile:]): * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldReplaceWithGeneratedFileForUpload): (WebChromeClient::generateReplacementFile): * WebView/WebUIDelegatePrivate.h: 2008-04-28 Anders Carlsson Reviewed by Sam, Mark, Adele and Darin. Initialize the application cache path. * WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): (-[WebView _commonInitializationWithFrameName:groupName:]): 2008-04-28 Alice Liu Reviewed by Darin. Fix Add tabindex property to all children of HTMLElement (7138) http://bugs.webkit.org/show_bug.cgi?id=7138 * MigrateHeaders.make: Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h because now that focus() has been moved to DOMHTMLElement.h, these files are no longer needed. 2008-04-25 Alexey Proskuryakov Reviewed by Darin. Fix run-webkit-tests --threading and provisionally fix Proxy server issue in Sunday's Nightly * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was only done from icon database code, which is not robust enough. 2008-04-20 Adam Barth Reviewed by Adam Roben and Sam Weinig. Updated WebSecurityOrigin to match new SecurityOrigin API. Collin Jackson also contributed to this patch. * Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin host]): (-[WebSecurityOrigin domain]): * Storage/WebSecurityOriginPrivate.h: 2008-04-25 Mark Rowe Rubber-stamped by Sam Weinig. Add some content to an empty ICU header file to prevent verification errors. * icu/unicode/utf_old.h: 2008-04-25 Anders Carlsson Reviewed by Sam. Add offlineWebApplicationCacheEnabled preference. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences offlineWebApplicationCacheEnabled]): (-[WebPreferences setOfflineWebApplicationCacheEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _updateSettingsFromPreferences:]): 2008-04-24 Mark Rowe Reviewed by Sam Weinig. Remove code for calculating the glyph cache size. * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove unused symbol. 2008-04-24 Mark Rowe Reviewed by Sam Weinig. Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER. * WebKitPrefix.h: 2008-04-24 Brady Eidson Reviewed by Darin Fix layout test regressions from my earlier preferences/settings tweak. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting the notification to update the settings, each WebView still needs to register for the notification - restore that behavior. 2008-04-24 Dan Bernstein Reviewed by Darin Adler. - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729 REGRESSION: arrow keys move insertion bar backwards in RTL text * WebView/WebFrame.mm: (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use VisiblePosition::caretRect() instead of the RenderObject method which was removed. 2008-04-24 Brady Eidson Reviewed by Darin Rework the Settings population again. * WebView/WebView.mm: (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification and directly from WebView's common init function. (-[WebView _preferencesChangedNotification:]): (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately after creating the new Page 2008-04-24 Darin Adler Reviewed by Geoff. - fix crash in regression test where we'd ask a frame for a user agent string after the WebView was already closed * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also added some code to prevent the crash in release builds if this problem happens again. 2008-04-24 Anders Carlsson Reviewed by Sam. Change some String arguments to be const references instead. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldInsertText): 2008-04-24 John Sullivan Mac build fix * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory AXButtonActionVerb]): implement this method using the text in WebCoreLocalizedStrings.cpp (-[WebViewFactory AXRadioButtonActionVerb]): ditto (-[WebViewFactory AXTextFieldActionVerb]): ditto (-[WebViewFactory AXCheckedCheckBoxActionVerb]): ditto (-[WebViewFactory AXUncheckedCheckBoxActionVerb]): ditto (-[WebViewFactory AXLinkActionVerb]): ditto 2008-04-23 Brady Eidson Reviewed by Sam Weinig In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings object before the Settings object is initialized. It seems quite prudent to post the preferences changed notification, thereby populating the Settings object, immediately after the Page is created. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created 2008-04-24 John Sullivan Reviewed by Jess - fixed JavaScript input panel automatic resizing doesn't work right with HiDPI * Misc/WebNSControlExtras.m: (-[NSControl sizeToFitAndAdjustWindowHeight]): deploy userSpaceScaleFactor when using view distances on the window 2008-04-22 Anders Carlsson Reviewed by Darin. Add NPN_Construct and NPN_PluginThreadAsyncCall declarations. * Plugins/npfunctions.h: 2008-04-20 Matt Lilek Mysteriously reviewed by mitz|away. Bug 18111: Closing a tab while dragging crashes Safari https://bugs.webkit.org/show_bug.cgi?id=18111 Null check the page before handling drag events. * WebView/WebView.mm: (-[WebView draggingUpdated:]): (-[WebView draggingExited:]): 2008-04-19 Brady Eidson Reviewed by Tim Hatcher Add a WebPreference for the path of the local storage persistent store. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.m: (-[WebPreferences _localStorageDatabasePath]): (-[WebPreferences _setLocalStorageDatabasePath:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): 2008-04-18 Brady Eidson Reviewed by Sam Weinig Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this. No reason to do the work twice... * WebView/WebView.mm: (-[WebView _close]): 2008-04-17 Eric Seidel Reviewed by beth. Rename Frame::renderer() to contentRenderer() and fix uses. * Misc/WebCoreStatistics.mm: * WebView/WebRenderNode.mm: (-[WebRenderNode initWithWebFrameView:]): 2008-04-17 Jon Honeycutt Reviewed by mrowe. * WebView/WebFrame.mm: Remove temporary build fix. 2008-04-17 Mark Rowe Reviewed by Dan Bernstein. Fix REGRESSION (r30741): Attachments don't appear in the iChat message window after sending The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order. 2008-04-17 Mark Rowe Rubber-stamped by Dan Bernstein. Fix the Mac build. * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building for now. This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place for this to live going forward. 2008-04-15 Kevin Decker Reviewed by Anders. CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403 In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading a bundle out from underneath itself. * Plugins/WebBasePluginPackage.h: Added unload method. * Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload. (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload. * Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage unload]): Added. 2008-04-15 Anders Carlsson Reviewed by Adam. Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES. * Configurations/WebKit.xcconfig: 2008-04-15 Brady Eidson Reviewed by John Sullivan Do a more complete job adding the "WebArchiveDebugMode" pref * WebView/WebPreferences.m: Add both getter *and* setter (-[WebPreferences webArchiveDebugModeEnabled]): (-[WebPreferences setWebArchiveDebugModeEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Call the renamed getter 2008-04-14 Brady Eidson Reviewed by Anders Add a hidden pref to debug WebArchive loading. With this pref on, when loading a WebArchive, if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the network and will instead fail the load as "cancelled." * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences _webArchiveDebugModeEnabled]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): 2008-04-11 David Hyatt Rename CachedResource ref/deref methods to addClient/removeClient. Reviewed by olliej * WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate finalize]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]): 2008-04-07 Brady Eidson Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project * Configurations/WebKit.xcconfig: 2008-04-04 Adam Roben Use WebCore's ICU headers instead of our own copy Rubberstamped by Tim Hatcher. * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's PrivateHeaders. 2008-04-04 Adam Roben Fix Would like to use WebCore's ForwardingHeaders in WebKit without manually creating copies Patch by Tim Hatcher, typed by me. * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in WebCore's PrivateHeaders instead of our own copy. 2008-04-04 Ada Chan Now we pass width and height directly as integers to format the window title for a standalone image. Reviewed by Dan. * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory imageTitleForFilename:width:height:]): 2008-04-03 Nicholas Shanks Updated by Dan Bernstein. Reviewed by Dave Hyatt. - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484 font-weight does not properly support graded weights * WebView/WebHTMLView.mm: (-[WebHTMLView _styleFromFontAttributes:]): (-[WebHTMLView _originalFontB]): (-[WebHTMLView _addToStyle:fontA:fontB:]): 2008-04-02 Mark Rowe Reviewed by Oliver Hunt. Ensure that debug symbols are generated for x86_64 and ppc64 builds. * Configurations/Base.xcconfig: 2008-03-31 Alice Liu Reviewed by Darin. * WebView/WebFrame.mm: (-[WebFrame _accessibilityTree]): The syntax for fetching an object from the AXObjectCache changed slightly 2008-03-31 Brady Eidson Reviewed by Jon Honeycutt Move a WebArchive loading check into WebCore * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now responsible for checking that state 2008-03-31 Brady Eidson Reviewed by Darin and Mitz's rubber stamp Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore * WebCoreSupport/WebEditorClient.mm: * WebCoreSupport/WebEditorClient.h: 2008-03-28 Brady Eidson Rubberstamped by Darin Adler Remove WebArchiver.h/mm * WebView/WebArchiver.h: Removed. * WebView/WebArchiver.mm: Removed. * DOM/WebDOMOperations.mm: * WebCoreSupport/WebDragClient.mm: * WebCoreSupport/WebEditorClient.mm: * WebView/WebDataSource.mm: * WebView/WebHTMLView.mm: 2008-03-28 Brady Eidson Reviewed by Darin Adler Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::dataForArchivedSelection): * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users * WebView/WebArchiver.mm: Ditto * WebView/WebHTMLView.mm: (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]): 2008-03-28 Brady Eidson Reviewed by Darin Adler More Kit->Core WebArchive changes. Create an archive from the current selection in a frame * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off easily in a followup 2008-03-28 Brady Eidson Reviewed by Sam Weinig WebArchive saga continues - Can now make archives from ranges in WebCore * DOM/WebDOMOperations.mm: (-[DOMRange webArchive]): (-[DOMRange markupString]): * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:] * WebView/WebArchiver.mm: 2008-03-28 Brady Eidson Reviewed by Sam Weinig More Kit->Core webarchive code movement * DOM/WebDOMOperations.mm: (-[DOMNode markupString]): Call createFullMarkup() instead * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode * WebView/WebFrameInternal.h: Ditto 2008-03-28 Brady Eidson Reviewed by Sam Weinig Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller * WebView/WebArchiver.h: * WebView/WebArchiver.mm: * WebView/WebDataSource.mm: (-[WebDataSource webArchive]): 2008-03-28 Brady Eidson Reviewed by Sam Weinig Remove unused [WebArchiver archiveNode:], made obsolete in r31400 * WebView/WebArchiver.h: * WebView/WebArchiver.mm: 2008-03-28 Brady Eidson Reviewed by Darin "Yet another transitional step" to empty out WebKit-based code for archiving. With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place entirely within WebCore, and opens the door to saving WebArchives on Windows. * DOM/WebDOMOperations.mm: * WebView/WebArchiver.mm: (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): 2008-03-27 Brady Eidson Reviewed by Adam Roben Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore as the push to core-ify WebArchives continues. This patch also introduces a behavior change. WebCore allows ArchiveResources with null or empty data. WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null. Since WebResource is API, I decided to leave it be to avoid a behavior change. But internally created resources (as in "while archiving a page") are accepting of null or empty data. This actually fixes a bug where not all subframes are archived, and resulted in a layout test change. * WebView/WebDataSource.mm: (-[WebDataSource mainResource]): Call DocumentLoader implementation (-[WebDataSource subresources]): Ditto * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete * WebView/WebFrameInternal.h: 2008-03-27 Brady Eidson Reviewed by Adam Change the "init from WebCore resource" version of WebResource to take PassRefPtr (more efficient) * WebView/WebResource.mm: (-[WebResource _initWithCoreResource:]): * WebView/WebResourceInternal.h: 2008-03-26 Brady Eidson Build fix - accidentally checked in this change which was work in progress * DOM/WebDOMOperations.mm: 2008-03-26 Brady Eidson Reviewed by Darin When we create a WebArchive, we walk every node from some starting point, asking each node along the way "What are your subresource URLs?" That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into WebCore::Node * DOM/WebDOMOperations.mm: (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by calling into individual WebCore::Node implementations * DOM/WebDOMOperationsPrivate.h: 2008-03-26 Brady Eidson Reviewed by Mark Rowe Part of the continued push to move WebArchive-related code down to WebCore, this moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource() * WebView/WebDataSource.mm: (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use has now been ported down to WebCore * WebView/WebFrameInternal.h: 2008-03-26 Mark Rowe Rubber-stamped by Brady Eidson. Update FEATURE_DEFINES to be consistent with the other locations in which it is defined. * Configurations/WebKit.xcconfig: 2008-03-26 Mark Rowe Reviewed by David Hyatt. Make the Ahem font antialias correctly on Acid3 on Tiger. * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): 2008-03-26 Mark Rowe Fix the Mac build. * MigrateHeaders.make: Copy the newly generated header into the right place. 2008-03-25 Brady Eidson Reviewed by Beth Dakin Remove entirely unused internal method * WebView/WebArchiver.h: * WebView/WebArchiver.mm: 2008-03-25 Brady Eidson Reviewed by Adam Roben - View Source is empty when view webarchives * WebCore.base.exp: * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setParsedArchiveData): (WebCore::DocumentLoader::parsedArchiveData): * loader/DocumentLoader.h: * loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData in the DocumentLoader 2008-03-25 Dan Bernstein Reviewed by Darin Adler. - fix http://bugs.webkit.org/show_bug.cgi?id=17933 Reopen All Windows From Last Session causes crash * WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null check. 2008-03-25 Brady Eidson Reviewed by Jon Honeycutt's rubberstamp Fix a leak with the new WebArchive setup * WebView/WebArchive.mm: (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive 2008-03-25 Brady Eidson Reviewed by Darin Removed the concept of "pending archive resources" and the "archive resources delivery timer" from WebFrameLoaderClient, as those concepts have been pushed into WebCore * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::WebFrameLoaderClient): 2008-03-25 Brady Eidson Reviewed by Darin Remove newly obsolete FrameLoaderClient methods * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: 2008-03-25 Brady Eidson Release build fix * WebView/WebArchive.mm: (-[WebArchive subresources]): (-[WebArchive subframeArchives]): 2008-03-25 Brady Eidson Reviewed by Darin - Support WebArchives on Windows And paves the way for many future WebArchive bug fixes and enhancements This change moves most of the real workhorse code about WebArchives into WebCore. It maintains 1-to-1 relationships between a few objects in WebCore and WebKit. Such as: * WebArchive <-> LegacyWebArchive * WebResource <-> ArchiveResource * WebUnarchivingState <-> ArchiveResourceCollection The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives and now exist in WebCore * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::createFrame): * WebView/WebArchive.mm: (+[WebArchivePrivate initialize]): (-[WebArchivePrivate init]): (-[WebArchivePrivate initWithCoreArchive:]): (-[WebArchivePrivate coreArchive]): (-[WebArchivePrivate setCoreArchive:]): (-[WebArchivePrivate dealloc]): (-[WebArchivePrivate finalize]): (-[WebArchive init]): (-[WebArchive initWithMainResource:subresources:subframeArchives:]): (-[WebArchive initWithData:]): (-[WebArchive initWithCoder:]): (-[WebArchive encodeWithCoder:]): (-[WebArchive mainResource]): (-[WebArchive subresources]): (-[WebArchive subframeArchives]): (-[WebArchive data]): (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]): (-[WebArchive WebCore::]): * WebView/WebArchiveInternal.h: Added. * WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _addSubframeArchives:]): (-[WebDataSource _documentFragmentWithArchive:]): (-[WebDataSource subresourceForURL:]): (-[WebDataSource addSubresource:]): * WebView/WebDataSourceInternal.h: * WebView/WebFrame.mm: (-[WebFrame loadArchive:]): * WebView/WebFrameInternal.h: * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): * WebView/WebResource.mm: (+[WebResourcePrivate initialize]): (-[WebResourcePrivate init]): (-[WebResourcePrivate initWithCoreResource:]): (-[WebResourcePrivate dealloc]): (-[WebResourcePrivate finalize]): (-[WebResource initWithCoder:]): (-[WebResource encodeWithCoder:]): (-[WebResource data]): (-[WebResource URL]): (-[WebResource MIMEType]): (-[WebResource textEncodingName]): (-[WebResource frameName]): (-[WebResource _initWithCoreResource:WebCore::]): (-[WebResource WebCore::]): (-[WebResource _ignoreWhenUnarchiving]): (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): (-[WebResource _fileWrapperRepresentation]): (-[WebResource _response]): (-[WebResource _stringValue]): * WebView/WebResourceInternal.h: Added. * WebView/WebResourcePrivate.h: * WebView/WebUnarchivingState.h: Removed. * WebView/WebUnarchivingState.m: Removed. 2008-03-24 Oliver Hunt Reviewed by Mark Rowe. Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page Rollout keyDown changes from r31236 -- fix for keyDown behaviour is tracked by Bug 18057: keyDown incorrectly propagates up the frame tree * WebView/WebHTMLView.mm: (-[WebHTMLView keyDown:]): 2008-03-24 Cameron Zwarich Reviewed by Maciej, landed by Brady Bug 3580: iFrames Appear to be Cached Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs Bug 15554: Reload causes to use old data If a page is reloaded, a child frame's URL can not be taken from a history item. * WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): 2008-03-24 Darin Adler Reviewed by Beth. - fix -[WebDataSource unreachableURL] invokes KURL's copy constructor * History/WebHistoryItem.mm: (-[WebHistoryItem URL]): Use a reference to avoid making a copy. * WebView/WebDataSource.mm: (-[WebDataSource _URL]): Ditto. (-[WebDataSource unreachableURL]): Ditto. * WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto. * DefaultDelegates/WebDefaultContextMenuDelegate.mm: * History/WebHistory.mm: * Misc/WebElementDictionary.mm: * Misc/WebNSAttributedStringExtras.mm: Remove unneeded imports of KURL.h. 2008-03-24 Brady Eidson Reviewed by Darin's rubberstamp Rename this file for upcoming work. * WebView/WebArchive.m: Removed. * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m. 2008-03-24 Alexey Proskuryakov Build fix. * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h. 2008-03-23 Oliver Hunt Reviewed by Maciej. Bug 17670: Key events may improperly propagate from iframe to parent frame Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus Prevent the Cocoa event system from propagating key events to the parent WebHTMLView, as that results in us dispatching the key events for each frame going up the frame tree. * WebView/WebHTMLView.mm: (-[WebHTMLView keyDown:]): (-[WebHTMLView keyUp:]): (-[WebHTMLView flagsChanged:]): 2008-03-21 Timothy Hatcher Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL http://bugs.webkit.org/show_bug.cgi?id=17980 Reviewed by Adam. The new highlight drawing was not honoring the fade value, so it was always drawing at full opacity. The animation code didn't match Windows and the new highlight anyway, so it has been removed. The highlight how just detaches when it is hidden. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight. (-[WebInspectorWindowController close]): Ditto. (-[WebInspectorWindowController highlightNode:]): Call attach. (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight. * WebInspector/WebNodeHighlight.h: * WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight initWithTargetView:inspectorController:]): (-[WebNodeHighlight dealloc]): Assert we have no _highlightView. (-[WebNodeHighlight attach]): Renamed from attachHighlight. (-[WebNodeHighlight detach]): Renamed from detachHighlight. (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:. * WebInspector/WebNodeHighlightView.h: * WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:. 2008-03-20 Mark Rowe Reviewed by Sam Weinig. Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit. This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the command-line. * Configurations/WebKit.xcconfig: 2008-03-20 Adam Roben Make WebNodeHighlightView use InspectorController to do its painting Reviewed by Tim Hatcher. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController highlightNode:]): Pass the InspectorController to the WebNodeHighlight, and don't call setHighlightedNode: (which has been removed). (-[WebInspectorWindowController hideHighlight]): Removed call to setHighlightedNode:. * WebInspector/WebNodeHighlight.h: - Replaced _highlightNode with _inspectorController - Removed _highlightedNode accessors - Added -inspectorController method * WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now takes an InspectorController* and stores it in _inspectorController. (-[WebNodeHighlight dealloc]): Removed code dealing with _highlightedNode. (-[WebNodeHighlight inspectorController]): Added. * WebInspector/WebNodeHighlightView.m: Removed FileInternal category. (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all GraphicsContexts to be based on a flipped CGContext, so we have to specify that this view is flipped. (-[WebNodeHighlightView drawRect:]): Changed to create a GraphicsContext and pass it to InspectorController::drawNodeHighlight. 2008-03-18 David Hyatt Add support for a preference in WebKit that can be used in nightly builds to test full page zoom. Reviewed by Antti * WebView/WebPreferenceKeysPrivate.h: * WebView/WebView.mm: (-[WebView setTextSizeMultiplier:]): (-[WebView canMakeTextSmaller]): (-[WebView makeTextSmaller:]): (-[WebView canMakeTextLarger]): (-[WebView makeTextLarger:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]): 2008-03-17 Eric Seidel Reviewed by darin. Export _NPN_IntFromIdentifier as part of our NPAPI interface * Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): 2008-03-14 Brady Eidson Reviewed by Brian Dash's rubberstamp Remove a class declaration for a class that has never existed * WebView/WebResource.h: 2008-03-14 David D. Kilzer Unify concept of enabling the Mac Java bridge. Reviewed by Darin and Anders. * Plugins/WebPluginJava.h: Removed unused file. * WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard. * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method. (WebFrameLoaderClient::javaApplet): Ditto. 2008-03-13 Antti Koivisto Reviewed by Darin. * ForwardingHeaders/wtf/Deque.h: Added. 2008-03-13 Anders Carlsson Reviewed by Adam. Call originalRequest, not initialRequest. * WebView/WebDataSource.mm: (-[WebDataSource initialRequest]): 2008-03-12 Darin Adler Reviewed by John Sullivan. - cleanup after removing the bridge * DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]): Call computeURL directly. * Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of _frameLoader method. (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Ditto. * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame method. Without this we could leave a stale frame pointer around. (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single caller of the _isMainFrame method. (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of _frameLoader method. (WebFrameLoaderClient::createFrame): Moved code here from _addChild. * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others turned out to be unused. (core): Added overload for DocumentFragment. (kit): Ditto. (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and to FrameLoader with _private->coreFrame->loader(). (-[WebFrame _attachScriptDebugger]): Ditto. (-[WebFrame _clearCoreFrame]): Added. (-[WebFrame _updateBackground]): More of the same. (-[WebFrame _unmarkAllBadGrammar]): Ditto. (-[WebFrame _unmarkAllMisspellings]): Ditto. (-[WebFrame _hasSelection]): Ditto. (-[WebFrame _atMostOneFrameHasSelection]): Ditto. (-[WebFrame _findFrameWithSelection]): Ditto. (-[WebFrame _dataSource]): Ditto. (-[WebFrame _addData:]): Streamlined code a bit. (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto. (-[WebFrame _receivedData:textEncodingName:]): Ditto. (-[WebFrame _isDescendantOfFrame:]): Ditto. (-[WebFrame _bodyBackgroundColor]): Ditto. (-[WebFrame _isFrameSet]): Ditto. (-[WebFrame _firstLayoutDone]): Ditto. (-[WebFrame _loadType]): Ditto. (-[WebFrame _isDisplayingStandaloneImage]): Ditto. (-[WebFrame name]): Ditto. (-[WebFrame DOMDocument]): Ditto. (-[WebFrame frameElement]): Ditto. (-[WebFrame provisionalDataSource]): Ditto. (-[WebFrame dataSource]): Ditto. (-[WebFrame loadRequest:]): Ditto. (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto. (-[WebFrame loadArchive:]): Ditto. (-[WebFrame stopLoading]): Ditto. (-[WebFrame reload]): Ditto. (-[WebFrame findFrameNamed:]): Ditto. (-[WebFrame parentFrame]): Ditto. (-[WebFrame childFrames]): Ditto. (-[WebFrame windowObject]): Ditto. (-[WebFrame globalContext]): Ditto. * WebView/WebFrameInternal.h: Added overloads of core and kit. Removed method declarations. * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame. (formElementFromDOMElement): Ditto. (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto. (inputElementFromDOMElement): Ditto. (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto. (-[WebHTMLRepresentation elementIsPassword:]): Ditto. (-[WebHTMLRepresentation formForElement:]): Ditto. (-[WebHTMLRepresentation currentForm]): Ditto. (-[WebHTMLRepresentation controlsInForm:]): Ditto. (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto. (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto. * WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Call createFragmentFromText directly instead of via WebFrame. (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Moved layout calls here from WebFrame. (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto. (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection. (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity. (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange. (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit. (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Moved code here from WebFrame. (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto. (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto. (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto. (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto. (-[WebHTMLView unmarkAllTextMatches]): Ditto. (-[WebHTMLView rectsForTextMatches]): Ditto. * WebView/WebHTMLViewInternal.h: Removed unused method declarations. * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of _frameLoader method. * WebView/WebRenderNode.mm: (copyRenderNode): Moved code here from WebFrame. (-[WebRenderNode initWithWebFrameView:]): Ditto. * WebView/WebResource.mm: (-[WebResource _stringValue]): Moved code here from WebFrame. * WebView/WebView.mm: (-[WebView _close]): Use core function intsead of _frameLoader method. (-[WebView setCustomTextEncodingName:]): Ditto. (-[WebView setHostWindow:]): Moved code here from WebFrame. (aeDescFromJSValue): Moved this here from WebFrame. (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame. 2008-03-12 Darin Adler Reviewed by Anders. - http://bugs.webkit.org/show_bug.cgi?id=17640 eliminate WebCoreFrameBridge Moved all the code from the bridge into WebFrame. This need not be the final home of these methods -- they can be moved closer to their callers and improved further -- but it eliminates the bridge without requiring a rewrite of the code. It's a fairly mechanical process (just adding underscores to method names really). There's even a chance that some of the methods are unused. Those we can remove after checking if that's so. * DOM/WebDOMOperations.mm: (-[DOMNode markupString]): Use WebFrame rather than bridge. (-[DOMDocument webFrame]): Changed to use the core and kit functions instead of using the bridge. (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge. (-[DOMRange markupString]): Ditto. * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods. * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import. * History/WebHistoryItem.mm: Ditto. * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h. * Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge. * Misc/WebElementDictionary.mm: Removed unneeded import. * Misc/WebKitStatistics.m: (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0. * Misc/WebKitStatisticsPrivate.h: Ditto. * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import. * Misc/WebNSPasteboardExtras.mm: Ditto. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame rather than bridge. * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import. * Plugins/WebNetscapePluginStream.mm: Ditto. * Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than bridge to get to the WebCore::Frame. * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method. * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame rather than bridge. * WebCoreSupport/WebEditorClient.mm: (selectorForKeyEvent): Tweaked comment. * WebCoreSupport/WebFrameBridge.h: Removed. * WebCoreSupport/WebFrameBridge.mm: Removed. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion. (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code. I could remove this function entirely, but it looks like the Qt port is using it. * WebCoreSupport/WebViewFactory.mm: Removed unneeded import. * WebView/WebArchiver.mm: (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge. (+[WebArchiver archiveNode:]): Ditto. (+[WebArchiver archiveSelectionInFrame:]): Ditto. * WebView/WebDataSource.mm: (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto. (-[WebDataSource _documentFragmentWithArchive:]): Ditto. (-[WebDataSource subresources]): Ditto. (-[WebDataSource subresourceForURL:]): Ditto. * WebView/WebDataSourceInternal.h: Removed _bridge method. * WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): Removed code to release the bridge. (core): Go directly to the core frame, not via the bridge. (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Remove the code to deal with the bridge. (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the shouldCreateRenderers flag, formerly on the bridge. (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge. (aeDescFromJSValue): Moved here from bridge. (-[WebFrame _domain]): Ditto. (-[WebFrame _addData:]): Ditto. (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto. (-[WebFrame _nodesFromList:]): Ditto. (-[WebFrame _markupStringFromNode:nodes:]): Ditto. (-[WebFrame _markupStringFromRange:nodes:]): Ditto. (-[WebFrame _selectedString]): Ditto. (-[WebFrame _stringForRange:]): Ditto. (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto. (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto. (-[WebFrame _sendScrollEvent]): Ditto. (-[WebFrame _drawRect:]): Ditto. (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto. (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto. (-[WebFrame _copyRenderNode:copier:]): Ditto. (-[WebFrame _copyRenderTree:]): Ditto. (inputElementFromDOMElement): Ditto. (formElementFromDOMElement): Ditto. (-[WebFrame _elementWithName:inForm:]): Ditto. (-[WebFrame _elementDoesAutoComplete:]): Ditto. (-[WebFrame _elementIsPassword:]): Ditto. (-[WebFrame _formForElement:]): Ditto. (-[WebFrame _currentForm]): Ditto. (-[WebFrame _controlsInForm:]): Ditto. (-[WebFrame _searchForLabels:beforeElement:]): Ditto. (-[WebFrame _matchLabels:againstElement:]): Ditto. (-[WebFrame _URLWithAttributeString:]): Ditto. (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto. (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto. (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto. (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto. (-[WebFrame _unmarkAllTextMatches]): Ditto. (-[WebFrame _rectsForTextMatches]): Ditto. (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto. (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto. (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto. (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto. (-[WebFrame _firstRectForDOMRange:]): Ditto. (-[WebFrame _scrollDOMRangeToVisible:]): Ditto. (-[WebFrame _baseURL]): Ditto. (-[WebFrame _stringWithData:]): Ditto. (+[WebFrame _stringWithData:textEncodingName:]): Ditto. (-[WebFrame _needsLayout]): Ditto. (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto. (-[WebFrame _accessibilityTree]): Ditto. (-[WebFrame _setBaseBackgroundColor:]): Ditto. (-[WebFrame _setDrawsBackground:]): Ditto. (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): Ditto. (-[WebFrame _selectionGranularity]): Ditto. (-[WebFrame _convertToNSRange:]): Ditto. (-[WebFrame _convertToDOMRange:]): Ditto. (-[WebFrame _convertNSRangeToDOMRange:]): Ditto. (-[WebFrame _convertDOMRangeToNSRange:]): Ditto. (-[WebFrame _markDOMRange]): Ditto. (-[WebFrame _markedTextNSRange]): Ditto. (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto. (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto. (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto. (-[WebFrame _documentFragmentWithText:inContext:]): Ditto. (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto. (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto. (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto. (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto. (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto. (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto. (-[WebFrame _visiblePositionForPoint:]): Ditto. (-[WebFrame _characterRangeAtPoint:]): Ditto. (-[WebFrame _typingStyle]): Ditto. (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto. (-[WebFrame _fontForSelection:]): Ditto. (-[WebFrame _dragSourceMovedTo:]): Ditto. (-[WebFrame _dragSourceEndedAt:operation:]): Ditto. (-[WebFrame _getData:andResponse:forURL:]): Ditto. (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto. (-[WebFrame _canProvideDocumentSource]): Ditto. (-[WebFrame _canSaveAsWebArchive]): Ditto. (-[WebFrame _receivedData:textEncodingName:]): Ditto. (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting function. Couldn't just keep the bridge method because this was already here with the same name. (-[WebFrame _selectedNSRange]): Ditto. (-[WebFrame _selectNSRange:]): Ditto. (-[WebFrame dealloc]): Remove bridge-related code. (-[WebFrame finalize]): Ditto. * WebView/WebFrameInternal.h: Added all the method declarations from the bridge. Removed the bridge parameter from the init method. Removed the #if blocks that tried to make this header work in non-C++ ObjC files -- they were broken and unused. Removed the _bridge method. * WebView/WebFrameView.mm: Removed the _bridge method. * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge field. (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge. (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto. (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto. (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto. (-[WebHTMLRepresentation documentSource]): Ditto. (-[WebHTMLRepresentation DOMDocument]): Ditto. (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto. (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto. (-[WebHTMLRepresentation elementIsPassword:]): Ditto. (-[WebHTMLRepresentation formForElement:]): Ditto. (-[WebHTMLRepresentation currentForm]): Ditto. (-[WebHTMLRepresentation controlsInForm:]): Ditto. (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto. (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto. * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method. * WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge. (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto. (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto. (-[WebHTMLView _updateTextSizeMultiplier]): Ditto. (-[WebHTMLView _frameOrBoundsChanged]): Ditto. (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto. (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto. (-[WebHTMLView drawSingleRect:]): Ditto. (-[WebHTMLView draggedImage:movedTo:]): Ditto. (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto. (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto. (-[WebHTMLView knowsPageRange:]): Ditto. (-[WebHTMLView accessibilityAttributeValue:]): Ditto. (-[WebHTMLView accessibilityFocusedUIElement]): Ditto. (-[WebHTMLView accessibilityHitTest:]): Ditto. (-[WebHTMLView _accessibilityParentForSubview:]): Ditto. (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto. (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto. (-[WebHTMLView _changeSpellingToWord:]): Ditto. (-[WebHTMLView startSpeaking:]): Ditto. (-[WebHTMLView _updateFontPanel]): Ditto. (-[WebHTMLView _canSmartCopyOrDelete]): Ditto. (-[WebHTMLView _layoutIfNeeded]): Ditto. (-[WebHTMLView characterIndexForPoint:]): Ditto. (-[WebHTMLView firstRectForCharacterRange:]): Ditto. (-[WebHTMLView selectedRange]): Ditto. (-[WebHTMLView markedRange]): Ditto. (-[WebHTMLView attributedSubstringFromRange:]): Ditto. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView insertText:]): Ditto. (-[WebTextCompleteController _insertMatch:]): Ditto. (-[WebTextCompleteController doCompletion]): Ditto. (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto. (-[WebHTMLView string]): Ditto. (-[WebHTMLView selectedString]): Ditto. (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto. (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto. (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto. (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto. (-[WebHTMLView unmarkAllTextMatches]): Ditto. (-[WebHTMLView rectsForTextMatches]): Ditto. * WebView/WebRenderNode.mm: (-[WebRenderNode initWithWebFrameView:]): Ditto. * WebView/WebResource.mm: (-[WebResource _stringValue]): Ditto. * WebView/WebScriptDebugDelegate.mm: Removed unneeded include. * WebView/WebView.mm: (-[WebView _dashboardRegions]): Use WebFrame instead of bridge. (-[WebView setProhibitsMainFrameScrolling:]): Ditto. (-[WebView _setInViewSourceMode:]): Ditto. (-[WebView _inViewSourceMode]): Ditto. (-[WebView _executeCoreCommandByName:value:]): Ditto. (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto. (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto. (-[WebView scrollDOMRangeToVisible:]): Ditto. (-[WebView setSelectedDOMRange:affinity:]): Ditto. (-[WebView setEditable:]): Ditto. (-[WebView setTypingStyle:]): Ditto. (-[WebView typingStyle]): Ditto. (-[WebView replaceSelectionWithNode:]): Ditto. (-[WebView replaceSelectionWithText:]): Ditto. (-[WebView replaceSelectionWithMarkupString:]): Ditto. (-[WebView replaceSelectionWithArchive:]): Ditto. (-[WebView _insertNewlineInQuotedContent]): Ditto. (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto. 2008-03-12 David Hyatt Make the zoom factor a float and not a percent. Reviewed by antti * WebView/WebView.mm: (-[WebView _setZoomMultiplier:isTextOnly:]): 2008-03-11 David Hyatt This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom). New API is added that is parallel to the text zoom public API. You can get/set a pageSizeMultiplier and you can zoom the page in, out or reset it to the standard size. In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode and set the common zoom factor. In other words you can't combine text zoom and page zoom. One will always win. Reviewed by Tim H. * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]): * WebView/WebDocumentInternal.h: * WebView/WebHTMLView.mm: (-[WebHTMLView viewDidMoveToSuperview]): * WebView/WebPDFView.h: * WebView/WebPDFView.mm: (-[WebPDFView _zoomOut:]): (-[WebPDFView _zoomIn:]): (-[WebPDFView _resetZoom:]): (-[WebPDFView _canZoomOut]): (-[WebPDFView _canZoomIn]): (-[WebPDFView _canResetZoom]): * WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView setTextSizeMultiplier:]): (-[WebView textSizeMultiplier]): (-[WebView _setZoomMultiplier:isTextOnly:]): (-[WebView _zoomMultiplier:]): (-[WebView _realZoomMultiplier]): (-[WebView _realZoomMultiplierIsTextOnly]): (-[WebView _canZoomOut:]): (-[WebView _canZoomIn:]): (-[WebView _zoomOut:isTextOnly:]): (-[WebView _zoomIn:isTextOnly:]): (-[WebView _canResetZoom:]): (-[WebView _resetZoom:isTextOnly:]): (-[WebView canMakeTextSmaller]): (-[WebView makeTextSmaller:]): (-[WebView canMakeTextLarger]): (-[WebView makeTextLarger:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]): (-[WebView setPageSizeMultiplier:]): (-[WebView pageSizeMultiplier]): (-[WebView canZoomPageIn]): (-[WebView zoomPageIn:]): (-[WebView canZoomPageOut]): (-[WebView zoomPageOut:]): (-[WebView canResetPageZoom]): (-[WebView resetPageZoom:]): (-[WebView _searchWithSpotlightFromMenu:]): * WebView/WebViewInternal.h: * WebView/WebViewPrivate.h: 2008-03-12 Dan Bernstein Reviewed by Darin Adler and Sam Weinig. - use CoreText API instead of SPI on Leopard * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and WKGetNSFontATSUFontId Tiger-only. 2008-03-12 Darin Adler - fix http://bugs.webkit.org/show_bug.cgi?id=17794 REGRESSION (r30980): 23 tests hanging on the Mac buildbot * WebView/WebFrame.mm: (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set up pointer from the bridge to the frame. (My next check-in removes the bridge entirely, but we need this until then.) 2008-03-11 Darin Adler Reviewed by Sam. - remove all bridge-related things from WebCore except the bridge itself * DOM/WebDOMOperations.mm: (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method. * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include. * Plugins/WebPluginController.mm: Ditto. * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the init and close methods. Added a setWebFrame: method. * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge setWebFrame:]): Added. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion. (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the bridge here. Soon we will be able to remove this entirely! (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved into WebFrame from the bridge. * WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's now owned by the frame. (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script debugger under GC without this! (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to use WebFrameLoaderClient instead of the bridge. (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added. This is code that used to live in the bridge's init function. (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto. (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto. (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since the WebView is now the bridge's owner. (-[WebFrame _updateBackground]): Changed this one call site that was calling the WebCore::Frame::bridge function directly to use the kit function instead. (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge. This code won't last long -- we're eliminating the bridge soon. (-[WebFrame finalize]): Ditto. * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods for creating frames. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom where we have to allocate a WebFrameBridge and then immediately release it. 2008-03-11 Darin Adler Reviewed by Anders. - remove code depending on the bridge to get from an NSView to a WebCore::Frame * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call to setView. A couple lines later, there is a call to _install, which sets the view to the scroll view. * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method. * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of this file, since it's used by Safari. * WebView/WebDynamicScrollBarsViewInternal.h: Added. * WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Ditto. (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto. (-[WebDynamicScrollBarsView allowsScrolling]): Ditto. (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto. (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto. (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto. (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto. (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto. (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto. (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto. (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto. (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto. (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto. (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto. (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto. * WebView/WebFrameView.mm: (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method. * WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h. (-[WebView alwaysShowVerticalScroller]): Ditto. (-[WebView setAlwaysShowHorizontalScroller:]): Ditto. (-[WebView alwaysShowHorizontalScroller]): Ditto. 2008-03-11 Darin Adler Reviewed by Sam. - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace bridge methods. * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS to recently-created functions. (WebChromeClient::firstResponder): Moved code here from the bridge. (WebChromeClient::makeFirstResponder): Ditto. (WebChromeClient::runOpenPanel): Ditto. (WebChromeClient::willPopUpMenu): Ditto. * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left is related to creating the bridge and connecting it to WebCore, which will go next when I eliminate use of the bridge to get to/from the Frame*. * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge close]): Moved the code to track the bridge count here instead of the dealloc and finalize methods. 2008-03-11 Darin Adler Reviewed by Mitz. - update code affected by Range changes * Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes. * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): Use Range::create. * WebView/WebHTMLView.mm: (-[WebHTMLView attributedString]): Ditto. 2008-03-10 Darin Adler Reviewed by Sam. - eliminate keyboard UI mode method from WebCoreFrameBridge * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::keyboardUIMode): Ditto. Calls WebView. * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the fields for keyboard UI mode. * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini method. (-[WebFrameBridge finalize]): Ditto. * WebView/WebView.mm: Moved the keyboard mode code in here. (-[WebView _close]): Remove observer from the distributed notification center as well as the normal one. (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved here from the bridge. (-[WebView _keyboardUIMode]): Ditto. * WebView/WebViewInternal.h: Added _keyboardUIMode method. 2008-03-10 Darin Adler Reviewed by Sam. - eliminate Java applet methods from WebCoreFrameBridge * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations. * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including the ones that load Java applets. * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function. * WebCoreSupport/WebFrameLoaderClient.mm: Ditto. 2008-03-07 Simon Hausmann Reviewed by Darin. Done with Lars. Simplified WebViewFactory's refreshPlugins method to only refresh the plugins and not reload the frames anymore since that's now done in a platform independent manner by WebCore::Page. Also removed the now unused pluginNameForMIMEType and pluginSupportsMIMEType methods. * WebCoreSupport/WebViewFactory.mm: * WebView/WebFrame.mm: * WebView/WebFrameInternal.h: * WebView/WebView.mm: 2008-03-08 Mark Rowe Reviewed by Darin Adler. Fix 64-bit build with GCC 4.2. * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required. * DefaultDelegates/WebDefaultUIDelegate.m: Ditto. * History/WebHistoryItem.mm: Ditto. * Misc/WebElementDictionary.mm: Ditto. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the variable being unused in 64-bit. * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required. * WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required. (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required. 2008-03-08 Darin Adler Reviewed by Adele. - eliminate custom highlight methods from WebCoreFrameBridge * WebCoreSupport/WebChromeClient.h: Added custom highlight functions. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::customHighlightRect): Moved code here from bridge. (WebChromeClient::paintCustomHighlight): Ditto. * WebCoreSupport/WebFrameBridge.mm: Removed code here. 2008-03-07 David D. Kilzer Unify concept of enabling Netscape Plug-in API (NPAPI). Reviewed by Darin. * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView. * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h. * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with #if ENABLE(NETSCAPE_PLUGIN_API). * Plugins/WebBaseNetscapePluginStream.mm: Ditto. * Plugins/WebBaseNetscapePluginView.h: Ditto. * Plugins/WebBaseNetscapePluginView.mm: Ditto. * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto. * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto. * Plugins/WebBasePluginPackage.h: Ditto. * Plugins/WebBasePluginPackage.m: Ditto. (+[WebBasePluginPackage pluginWithPath:]): * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto. * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto. * Plugins/WebNetscapePluginEmbeddedView.h: Ditto. * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto. * Plugins/WebNetscapePluginPackage.h: Ditto. * Plugins/WebNetscapePluginPackage.m: Ditto. * Plugins/WebNetscapePluginStream.h: Ditto. * Plugins/WebNetscapePluginStream.mm: Ditto. * Plugins/WebPluginDatabase.m: Ditto. (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): * Plugins/npapi.m: Ditto. * WebCoreSupport/WebFrameLoaderClient.mm: Ditto. (WebFrameLoaderClient::objectContentType): (WebFrameLoaderClient::createPlugin): * WebView/WebHTMLView.mm: Ditto. (-[NSArray _web_makePluginViewsPerformSelector:withObject:]): * WebView/WebHTMLViewInternal.h: Ditto. * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate) category to (WebInternal) category so we don't expose the ENABLE() macro from the private header. (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): * WebView/WebFrameInternal.h: Ditto. * WebView/WebFramePrivate.h: Ditto. 2008-03-07 Alexey Proskuryakov Reviewed by Darin. REGRESSION: (safari 2-3): "Default default" encoding for Korean changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites * WebView/WebPreferences.m: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match the one used in Safari. 2008-03-07 Mark Rowe Reviewed by Oliver Hunt. Fix WebKit build with GCC 4.2. * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature. 2008-03-07 Darin Adler Reviewed by Adam. - eliminated WebCoreFrameBridge runOpenPanel * WebCoreSupport/WebChromeClient.h: Added runOpenPanel. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel): Added. (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the FileChooser so it can get a result from the UI delegate. (-[WebOpenPanelResultListener dealloc]): Added. (-[WebOpenPanelResultListener finalize]): Added. (-[WebOpenPanelResultListener cancel]): Added. (-[WebOpenPanelResultListener chooseFilename:]): Added. 2008-03-06 Darin Adler Reviewed by Mitz. - fix regression test failures from the visited-link change * History/WebHistory.mm: (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks to turn off visited links if there is no history object. Also call removeAllVisitedLinks so we can start over from scratch with the new history. 2008-03-06 Dan Bernstein Reviewed by Darin Adler. - fix a regression from r30741: a crash under WebFrameLoaderClient::createPlugin() when showing a Mail message with an attachment * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): 2008-03-06 Darin Adler - fix Tiger build * History/WebHistory.mm: Added include of WebTypesInternal.h. 2008-03-06 Darin Adler - fix Release build * History/WebHistory.mm: (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore. (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if. (-[WebHistoryPrivate saveToURL:error:]): Ditto. 2008-03-06 Darin Adler Reviewed by Mitz. - fix http://bugs.webkit.org/show_bug.cgi?id=17526 REGRESSION: iframes are added to Safari's History menu by separating the visited link machinery from global history * History/WebHistory.mm: Moved WebHistoryPrivate inside this file. (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this method name, since it's on a private object. (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the PageGroup::removeAllVisitedLinks function if the last URL was removed. (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this method name, since it's on a private object. (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks. (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this method name, since it's on a private object. (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Ditto. (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this to correctly return the error by using the newer version of writeToURL: and removed the FIXME about that. (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink for every link in the history. (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now. (-[WebHistory addItem:]): Moved into the WebPrivate category. (-[WebHistory addItemForURL:]): Ditto. (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we create an item and already know its title. (-[WebHistory ageLimitDate]): Moved into the WebPrivate category. (-[WebHistory containsItemForURLString:]): Ditto. (-[WebHistory removeItem:]): Ditto. (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto. (-[WebHistory _itemForURLString:]): Ditto. (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit. * History/WebHistoryInternal.h: Added. * History/WebHistoryItemInternal.h: Tweaked formatting and includes. * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header. Also reorganized what was left behind. * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::populateVisitedLinks): Added a call to the new -[WebHistory _addVisitedLinksToPageGroup:] method. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new -[WebHistory _addItemForURL:title:] method. 2008-03-05 Adam Roben Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm} Reviewed by Kevin M. * WebView/WebFrame.mm: * WebView/WebScriptDebugDelegate.mm: * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h. * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm. 2008-03-05 Adam Roben Rename WebCoreScriptDebuggerImp to WebScriptDebugger Reviewed by Kevin M. * WebView/WebCoreScriptDebuggerImp.h: * WebView/WebCoreScriptDebuggerImp.mm: * WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]): * WebView/WebFrameInternal.h: 2008-03-05 Adam Roben Remove WebScriptDebugger Uses of WebScriptDebugger have been replaced with WebCoreScriptDebuggerImp. Reviewed by Kevin M. * WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): Use delete instead of release since WebCoreScriptDebuggerImp is a C++ class. (-[WebFrame _attachScriptDebugger]): Updated to use early returns and WebCoreScriptDebuggerImp. (-[WebFrame _detachScriptDebugger]): Ditto. * WebView/WebFrameInternal.h: * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger * WebView/WebScriptDebugDelegatePrivate.h: Removed. * WebView/WebView.mm: 2008-03-05 Adam Roben Remove -webFrame and -globalObject from WebScriptDebugger WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger Reviewed by Kevin M. * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger* parameter to the constructor. * WebView/WebCoreScriptDebuggerImp.mm: (toWebFrame): Added. (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame. (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's WindowScriptObject ourselves instead of asking WebScriptDebugger for it. (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame. (WebCoreScriptDebuggerImp::returnEvent): Ditto. (WebCoreScriptDebuggerImp::exception): Ditto. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger initWithWebFrame:]): Updated for change to WebScriptDebuggerImp's constructor. * WebView/WebScriptDebugDelegatePrivate.h: Removed -webFrame/-globalObject. 2008-03-05 Adam Roben Remove -enterFrame: and -leaveFrame from WebScriptDebugger Reviewed by Kevin M. * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its lifetime. * WebView/WebCoreScriptDebuggerImp.mm: - Added declaration of -[WebScriptCallFrame _initWithGlobalObject:caller:state:]. - Changed most uses of m_topCallFrame to m_topCallFrame.get() (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed now-unnecessary initialization of m_topCallFrame. (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame: with its implementation. The one difference between this implementation and the old enterFrame: method is that we don't hand our reference to m_topCallFrame to _initWithGlobalObject: -- that method must now retain the passed-in WebScriptCallFrame manually. (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame with its implementation. (WebCoreScriptDebuggerImp::exception): * WebView/WebScriptDebugDelegate.mm: Removed declaration of -[WebScriptCallFrame _initWithGlobalObject:caller:state:]. (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed to retain the passed-in caller. * WebView/WebScriptDebugDelegatePrivate.h: - Removed _current ivar - Removed enterFrame:/leaveFrame declarations. 2008-03-05 Adam Roben Remove -parsedSource: from WebScriptDebugger Reviewed by Kevin M. * WebView/WebCoreScriptDebuggerImp.mm: (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:] * WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:. * WebView/WebScriptDebugDelegatePrivate.h: Ditto. 2008-03-05 Adam Roben Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger Reviewed by Kevin M. * WebView/WebCoreScriptDebuggerImp.mm: (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call trhough to callEvent instead of duplicating its code here. (WebCoreScriptDebuggerImp::callEvent): Moved code from -[WebScriptDebugger enteredFrame:sourceId:line:] here. (WebCoreScriptDebuggerImp::returnEvent): Moved code from -[WebScriptDebugger leavingFrame:sourceId:line:] here. (WebCoreScriptDebuggerImp::exception): Moved code from -[WebScriptDebugger exceptionRaised:sourceId:line:] here. * WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:, -leavingFrame:, and -exceptionRaised:. * WebView/WebScriptDebugDelegatePrivate.h: Ditto. 2008-03-05 Adam Roben Remove -[WebScriptDebugger hitStatement:sourceId:line:] Reviewed by Kevin M. * WebView/WebCoreScriptDebuggerImp.mm: (WebCoreScriptDebuggerImp::atStatement): Moved code here from -[WebScriptDebugger hitStatement:sourceId:line:]. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger webFrame]): Added. * WebView/WebScriptDebugDelegatePrivate.h: 2008-03-05 Adam Roben Remove WebCoreScriptDebugger Reviewed by Kevin M. * WebView/WebCoreScriptDebugger.h: Removed. * WebView/WebCoreScriptDebugger.mm: Removed. * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger with WebScriptDebugger. * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger delegate] with just m_debugger. (toNSString): Moved here from WebCoreScriptDebugger.mm. (toNSURL): Ditto. (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (WebCoreScriptDebuggerImp::exception): * WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a WebCoreScriptDebuggerImp, so initialize it properly. * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a WebCoreScriptDebuggerImp. 2008-03-05 Adam Roben Move WebCoreScriptDebuggerImp to its own source files Also changed WebCoreScriptDebuggerImp coding style to match our style guidelines. Reviewed by Kevin M. * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL function. * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp implementation. (toNSURL): Made no longer static. * WebView/WebCoreScriptDebuggerImp.h: Added. * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from WebCoreScriptDebugger.mm and cleaned up. (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (WebCoreScriptDebuggerImp::exception): 2008-03-05 Adam Roben Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger Reviewed by Kevin M. * WebView/WebCoreScriptDebugger.h: - Removed newFrameWithGlobalObject:caller:state: from WebScriptDebugger protocol - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol - Removed _current ivar from WebCoreScriptDebugger * WebView/WebCoreScriptDebugger.mm: (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on the delegate. (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger dealloc]): Added code to release _current. (-[WebScriptDebugger enterFrame:]): Added. Code came from WebCoreScriptDebugger. (-[WebScriptDebugger leaveFrame]): Ditto. * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar. 2008-03-05 Adam Roben Remove WebCoreScriptCallFrame Reviewed by Tim. * WebView/WebCoreScriptDebugger.h: - Replaced WebCoreScriptCallFrame with WebScriptCallFrame - Replaced -newWrapperForFrame: with -newFrameWithGlobalObject:caller:state: - Removed WebCoreScriptCallFrame interface. * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame with WebScriptCallFrame. (-[WebCoreScriptDebugger _enterFrame:]): Changed to call -newFrameWithGlobalObject:caller:state. (-[WebCoreScriptDebugger _leaveFrame]): * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's _private ivar to be of type WebScriptCallFramePrivate*. * WebView/WebScriptDebugDelegate.mm: - Replaced WebCoreScriptCallFrame with WebScriptCallFrame - Added WebScriptCallFramePrivate (-[WebScriptDebugger enteredFrame:sourceId:line:]): (-[WebScriptDebugger hitStatement:sourceId:line:]): (-[WebScriptDebugger leavingFrame:sourceId:line:]): (-[WebScriptDebugger exceptionRaised:sourceId:line:]): (-[WebScriptCallFramePrivate dealloc]): Added. (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added. Code came from WebCoreScriptCallFrame. (-[WebScriptCallFrame dealloc]): Added a call to release the _private ivar. (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to _private with direct access of _private's ivars. (-[WebScriptCallFrame caller]): Ditto. (-[WebScriptCallFrame scopeChain]): Ditto. (-[WebScriptCallFrame evaluateWebScript:]): Ditto. 2008-03-05 Adam Roben Move -_convertValueToObjcValue to WebScriptCallFrame Reviewed by Darin. * WebView/WebCoreScriptDebugger.h: Removed declaration of -_convertValueToObjcValue. * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came from -[WebCoreScriptCallFrame _convertValueToObjcValue]. (-[WebScriptCallFrame scopeChain]): Changed to call -_convertValueToObjcValue on self instead of _private. (-[WebScriptCallFrame exception]): Ditto. (-[WebScriptCallFrame evaluateWebScript:]): Ditto. 2008-03-05 Adam Roben Move -exception and -evaluateWebScript: to WebScriptCallFrame Reviewed by Darin. * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception and -evaluateWebScript:. * WebView/WebCoreScriptDebugger.mm: Removed -exception and -evaluateWebScript:. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame exception]): Added. Code came from -[WebCoreScriptCallFrame exception]. (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from -[WebCoreScriptCallFrame evaluateWebScript:]. 2008-03-05 Adam Roben Move -scopeChain to WebScriptCallFrame Reviewed by Darin. * WebView/WebCoreScriptDebugger.h: - Added declarations of -globalObject and -_convertValueToObjcValue: to WebCoreScriptCallFrame - Removed declaration of -scopeChain. * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue within the main WebCoreScriptCallFrame implementation. (-[WebCoreScriptCallFrame globalObject]): Added. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): Added. Code came from -[WebCoreScriptCallFrame scopeChain]. 2008-03-05 Adam Roben Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame Reviewed by Darin. * WebView/WebCoreScriptDebugger.h: - Removed #else case of #ifdef __cplusplus since this file is only ever used by C++ Objective-C files - Removed 'using KJS::ExecState' statement since we prefer not to have using statements in header files - Consequently prefixed uses of ExecState with KJS:: - Added declaration of toNSString method that takes a const UString& - Added declaration of -[WebCoreScriptCallFrame state] - Removed declaration of -[WebCoreScriptCallFrame functionName] * WebView/WebCoreScriptDebugger.mm: (toNSString): Made this no longer static. (-[WebCoreScriptCallFrame state]): Added. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame functionName]): Added. Code came from -[WebCoreScriptCallFrame functionName], though I changed some nested ifs into early returns. 2008-03-05 Adam Roben Move WebCoreScriptDebugger to WebKit Reviewed by Darin. * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h. * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm. (toNSString): (toNSURL): (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (WebCoreScriptDebuggerImp::exception): (+[WebCoreScriptDebugger initialize]): (-[WebCoreScriptDebugger initWithDelegate:]): (-[WebCoreScriptDebugger dealloc]): (-[WebCoreScriptDebugger finalize]): (-[WebCoreScriptDebugger delegate]): (-[WebCoreScriptDebugger _enterFrame:]): (-[WebCoreScriptDebugger _leaveFrame]): (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]): (-[WebCoreScriptCallFrame _setWrapper:]): (-[WebCoreScriptCallFrame _convertValueToObjcValue:]): (-[WebCoreScriptCallFrame dealloc]): (-[WebCoreScriptCallFrame wrapper]): (-[WebCoreScriptCallFrame caller]): (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame exception]): (-[WebCoreScriptCallFrame evaluateWebScript:]): * WebView/WebScriptDebugDelegate.mm: Updated header path. * WebView/WebScriptDebugDelegatePrivate.h: Ditto. 2008-03-05 Anders Carlsson Reviewed by Geoff. Include file changes. * Plugins/WebBaseNetscapePluginView.mm: * Plugins/WebNetscapePluginPackage.m: 2008-03-04 Timothy Hatcher Reviewed by Darin Adler. Browser windows "do nothing" while modal dialog or menu is up due to run loop modes (or while scrolling) Add new API that lets a WebView be scheduled with multiple runloops and modes. This lets loading continue when in a nested runloop or in a different mode. * Misc/WebKitVersionChecks.h: Add a new version define: WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise. (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page. (-[WebView unscheduleFromRunLoop:forMode:]): Ditto. * WebView/WebViewPrivate.h: Add the new pending API methods. 2008-03-04 Anders Carlsson Reviewed by Darin. Fix crash that happens when trying to load a page with a Java applet. * WebCoreSupport/WebFrameLoaderClient.mm: Don't release the names and values array - the kit method returns an autoreleased array. 2008-03-04 Darin Adler Reviewed by Adam. - fix 200+ failing regression tests - fix http://bugs.webkit.org/show_bug.cgi?id=17668 Vertical scrollbar at slashdot.org is randomly not shown * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting code here to exactly match the way it was before it was moved from WebCore. I had introduced a storage leak and that was causing problems with scroll bars! 2008-03-04 Darin Adler Reviewed by Adam. - remove WebCoreFrameBridge reapplyStyles method * WebView/WebHTMLView.mm: (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge. 2008-03-04 Darin Adler Reviewed by Adam. - eliminate WebCoreFrameBridge createFrameViewWithNSView * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Moved code here from createFrameViewWithNSView. 2008-03-04 Darin Adler Reviewed by Adam. - removed WebCoreFrameBridge scrollOverflowInDirection * WebView/WebFrameView.mm: (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call EventHandler directly instead of using the bridge. (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead of the ones from the bridge. (-[WebFrameView scrollToEndOfDocument:]): Ditto. (-[WebFrameView _pageVertically:]): Ditto. (-[WebFrameView _pageHorizontally:]): Ditto. (-[WebFrameView _scrollLineVertically:]): Ditto. (-[WebFrameView _scrollLineHorizontally:]): Ditto. 2008-03-04 Darin Adler Reviewed by Adam. - remove WebCoreFrameBridge installInFrame: method * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Call -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:]. * WebView/WebFrameView.mm: (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:]. (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire method isn't nested inside an if statement. Call -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:]. * WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be used in WebFrameLoaderClient.mm. 2008-03-04 Darin Adler Reviewed by Adam. - remove WebCoreFrameBridge window method * WebCoreSupport/WebFrameBridge.mm: Removed window method. 2008-03-04 Darin Adler Reviewed by Adam. - move code from WebFrameBridge into WebFrameLoaderClient * WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration, removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed, redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods. * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]): Changed to use WebCore::String. (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here and added a FIXME. (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here. (WebFrameLoaderClient::objectContentType): Ditto. (parameterValue): Added. Helper function, based on code originally in WebFrameBridge. (pluginView): Ditto. (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here. 2008-03-04 Darin Adler Reviewed by Adam. - remove -[WebCoreFrameBridge dashboardRegionsChanged:] * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge. The WebCore side now calls this only when there's an actual change. * WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions. * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions. Removed _compareDashboardRegions: and dashboardRegionsChanged: methods. 2008-03-04 Darin Adler Reviewed by Adam. - remove WebCoreFrameBridge issuePasteComand method * WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method. * WebView/WebHTMLViewInternal.h: Removed declaration of paste: method. 2008-03-03 Darin Adler Reviewed by Adam. - some "cleanup" on the path to removing WebCoreFrameBridge * Storage/WebDatabaseManager.mm: Tweak includes. * Storage/WebDatabaseTrackerClient.mm: Ditto. * Storage/WebSecurityOrigin.mm: Ditto. * Storage/WebSecurityOriginInternal.h: Ditto. * WebView/WebFrame.mm: (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly match WebCore::EditableLinkBehavior. * WebView/WebFrameInternal.h: Removed unused kit function. * WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here. * WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here. * WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations. * WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment. 2008-03-01 Mark Rowe Reviewed by Tim Hatcher. Update Xcode configuration to support building debug and release from the mysterious future. * Configurations/DebugRelease.xcconfig: 2008-02-29 Mark Rowe Reviewed by Anders Carlsson. Replace use of WKPathFromFont with implementation in terms of public API. * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove unused symbol. 2008-02-29 Mark Rowe Reviewed by Oliver Hunt. Fix spelling of "request" in name of WKNSURLProtocolClassForRequest. * Misc/WebNSURLExtras.mm: (-[NSURL _webkit_canonicalize]): * WebKit.order: 2008-02-29 Mark Rowe Reviewed by Oliver Hunt. Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest. * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): 2008-02-29 Mark Rowe Reviewed by Oliver Hunt. Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari. * Misc/WebNSViewExtras.m: Remove _web_superviewOfClass:stoppingAtClass:. * Misc/WebNSWindowExtras.m: Remove _webkit_displayThrottledWindows. * Misc/WebSearchableTextView.m: Remove selectionImageForcingWhiteText:. * WebCoreSupport/WebImageRendererFactory.m: Update comment to mention the last version of Safari that requires this class. * WebInspector/WebInspector.mm: Remove sharedWebInspector and update comments to mention the last version of Safari that calls other obsolete methods. * WebView/WebDocumentPrivate.h: Remove selectionImageForcingWhiteText:. * WebView/WebHTMLView.mm: Ditto. * WebView/WebPDFView.mm: Ditto. * WebView/WebView.mm: Update comment to mentoin the last version of Safari that requires the obsolete method. 2008-02-29 Mark Rowe Rubber-stamped by Eric Seidel. Remove unneeded includes of WebKitSystemInterface.h. * History/WebHistoryItem.mm: * Misc/WebNSViewExtras.m: * WebCoreSupport/WebFrameLoaderClient.mm: * WebView/WebDataSource.mm: * WebView/WebPDFView.mm: 2008-02-29 Mark Rowe Reviewed by Oliver Hunt and Oliver Hunt. WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI. * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove unused symbol. * WebKit.order: Ditto. 2008-02-28 Mark Rowe Reviewed by Dave Hyatt. Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call. * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger. 2008-02-27 Brady Eidson Reviewed by Mark Rowe (code) and Darin (concept) Much better fix for (see r19549) Original fix for (and 14 dupes) Let me tell you a story: A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit. WebArchive code was intertwined with that code in bizarre and complex ways. During the months long loader re-factoring where we pushed much loader code down into WebCore, many portions of the WebKit loader were thinned out until they ceased to exist. Others remained with a sole purpose. One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader to WebLoader was originally rooted in the method [WebLoader loadRequest:]. This method was the single entry point for almost all loading (network or web archives) This method would check various headers and other fields on the NSURLRequest and NSURLResponse to make decisions about the load. If the cache control fields were expired or other conditions in the headers were met, the load would be forced to go out to the network. As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored. At some point, all that remained was the special cases for loading WebArchives. Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed to be WebArchive specific, further cementing the assumed design. Problem is, the design was bad. A WebArchive is meant to be a static snapshot of a WebPage at a specific point in time. Referring to the request to see if the resource should be reloaded seems nonsensical, as does referring to the response headers to see if the resource is "expired". In the context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least during the initial load! After discovering the secret to reproducing all of these bugs is both emptying our your Foundation cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases that were all symptoms of this bug, and easy to verify that they are fixed with this patch. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that inspect the request or response objects - We are loading from a WebArchive, and we should never make the decision to go out to the network when we actually have the resource available. * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove two methods that are no longer used anywhere in WebKit 2008-02-27 Matt Lilek Reviewed by Adam Roben. Bug 14348: Messing up the inspector by dragging an URL into it http://bugs.webkit.org/show_bug.cgi?id=14348 and * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Remove duplicate preference setting. (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]): 2008-02-25 Darin Adler Reviewed by Adam. * WebView/WebArchiver.mm: (+[WebArchiver archiveSelectionInFrame:]): Use blankURL. * WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the variable name URL to avoid clashing with the renamed KURL in the future. Also use blankURL. (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto. (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto. (-[WebFrame loadHTMLString:baseURL:]): Ditto. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto. 2008-02-24 Darin Adler Reviewed by Sam. - remove separate client calls for "standard" and "reload' history * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): 2008-02-23 Alexey Proskuryakov Reviewed by Darin. Move basic threading support from WebCore to WTF. * ForwardingHeaders/wtf/Threading.h: Added. * ForwardingHeaders/wtf/Locker.h: Added. 2008-02-23 David Kilzer Please clarify licensing for some files Reviewed by Darin. * Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement and added Apple BSD-style license. * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto. 2008-02-22 John Sullivan Reviewed by Adam Roben Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing pasteAsPlainText: has the same behavior. * WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): (-[WebHTMLView readSelectionFromPasteboard:]): (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView pasteAsRichText:]): (-[WebHTMLView paste:]): * WebView/WebView.mm: * WebView/WebViewPrivate.h: 2008-02-21 Anders Carlsson Reviewed by Sam. Use BackForwardList::create instead. * History/WebBackForwardList.mm: (-[WebBackForwardList init]): 2008-02-21 John Sullivan Reviewed by Jessica Kahn support for pasteAndMatchStyle: command (see ) * WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]): added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge) (-[WebHTMLView readSelectionFromPasteboard:]): pass NO for new matchStyle parameter to match old behavior (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): validate pasteAndMatchStyle the same way as pasteAsRichText (-[WebHTMLView pasteAndMatchStyle:]): just like pasteAsRichText but passes YES for matchStyle (-[WebHTMLView pasteAsRichText:]): pass NO for new matchStyle parameter to match old behavior (-[WebHTMLView paste:]): ditto * WebView/WebView.mm: added macro(pasteAndMatchStyle) * WebView/WebViewPrivate.h: added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category 2008-02-20 Sam Weinig Reviewed by Darin and Geoff. - WebKit part of work around missing video on YouTube front page with a site-specific hack * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks. There are currently no site-specific quirks on Mac, but we will propagate the state to WebCore to avoid possible mistakes later. 2008-02-19 Anders Carlsson Reviewed by Darin. Move back WebKit methods that were unused in WebCore. * Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_isEmpty]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isFileURL]): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setTitle): * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): 2008-02-18 Darin Adler Reviewed by Sam. * Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of DeprecatedString. 2008-02-17 Sam Weinig Reviewed by Dan Bernstein. Fix for http://bugs.webkit.org/show_bug.cgi?id=17365 document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR * MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were mistakenly not migrated. 2008-02-15 Dan Bernstein Reviewed by Alexey Proskuryakov. - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360 REGRESSION: mp4 file downloaded from server is downloaded as html * WebView/WebDataSource.mm: (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _responseMIMEType]): (-[WebDataSource subresources]): (-[WebDataSource subresourceForURL:]): * WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:]): * WebView/WebResourcePrivate.h: 2008-02-15 Adam Roben Make WebKit's FEATURE_DEFINES match WebCore's Reviewed by Mark. * Configurations/WebKit.xcconfig: 2008-02-14 Darin Adler Reviewed by Eric Seidel. - updated for WebCore KURL changes * History/WebHistoryItem.mm: (-[WebHistoryItem URL]): Removed getNSURL call. * Misc/WebElementDictionary.mm: (-[WebElementDictionary _absoluteImageURL]): Ditto. (-[WebElementDictionary _absoluteLinkURL]): Ditto. * Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement): Ditto. (+[NSAttributedString _web_attributedStringFromRange:]): Ditto. * Misc/WebNSURLExtras.mm: (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated for function name change. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::downloadURL): Removed getNSURL call. * WebCoreSupport/WebDragClient.mm: (WebDragClient::createDragImageForLink): Ditto. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto. (WebFrameLoaderClient::startDownload): Ditto. (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto. (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto. (WebFrameLoaderClient::cancelledError): Ditto. (WebFrameLoaderClient::blockedError): Ditto. (WebFrameLoaderClient::cannotShowURLError): Ditto. (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto. (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto. (WebFrameLoaderClient::fileDoesNotExistError): Ditto. (WebFrameLoaderClient::willUseArchive): Ditto. (WebFrameLoaderClient::setTitle): Ditto. (WebFrameLoaderClient::actionDictionary): Ditto. (WebFrameLoaderClient::createFrame): Ditto. (WebFrameLoaderClient::objectContentType): Ditto. (WebFrameLoaderClient::createPlugin): Ditto. (WebFrameLoaderClient::createJavaAppletWidget): Ditto. * WebView/WebDataSource.mm: (-[WebDataSource _URL]): Ditto. (-[WebDataSource _initWithDocumentLoader:]): Ditto. (-[WebDataSource unreachableURL]): Ditto. * WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto. 2008-02-14 Stephanie Lewis Reviewed by Geoff. Update order files. * WebKit.order: 2008-02-14 Alexey Proskuryakov Reviewed by Adam Roben. http://bugs.webkit.org/show_bug.cgi?id=17207 Database example doesn't work (requires not-yet-released Safari) * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage if it's too old. 2008-02-11 Darin Adler - roll out fix for REGRESSION: Xcode News window renders incorrectly due to visibility fix Removed the Xcode-specific quirk at the request of some folks on the Xcode team. * Misc/WebKitVersionChecks.h: Removed the constant. * WebView/WebView.mm: (-[WebView _needsXcodeVisibilityQuirk]): Removed. (-[WebView _preferencesChangedNotification:]): Removed call to setNeedsXcodeVisibilityQuirk. 2008-02-12 Anders Carlsson Reviewed by Mitz. * WebCoreSupport/WebFrameBridge.mm: * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory imageTitleForFilename:size:]): Move implementation from WebFrameBridge to WebViewFactory. 2008-02-11 Darin Adler Reviewed by Mitz. - fix REGRESSION: Xcode News window renders incorrectly due to visibility fix Added an Xcode-specific quirk. * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after" part of the check. * WebView/WebView.mm: (-[WebView _needsXcodeVisibilityQuirk]): Added. (-[WebView _preferencesChangedNotification:]): Added a call to setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk. 2008-02-10 Darin Adler - fix http://bugs.webkit.org/show_bug.cgi?id=17274 REGRESSION: User Agent string broken in r30119 * WebView/WebView.mm: (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Fix wrong variable name. Doh! 2008-02-09 Darin Adler Reviewed by Tim Hatcher. - fix crash every time you open the Xcode documentation window * WebView/WebView.mm: (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the garbage collector's Objective C++ support by not initializing a static to an object that needs to be marked when running under GC. 2008-02-05 Dan Bernstein Reviewed by Darin Adler. - WebKit part of Should implement writing direction shortcuts The key bindings are Command-Control-left arrow and Command-Control-right arrow. To match AppKit, the bindings are enabled only when certain user defaults are set. * WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call Frame::baseWritingDirectionForSelectionStart() and Editor::setBaseWritingDirection() directly. (-[WebHTMLView changeBaseWritingDirection:]): Ditto. (writingDirectionKeyBindingsEnabled): Added. (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper method. (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added. (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added. * WebView/WebView.mm: 2008-02-05 Mark Rowe Unreviewed build fix. * WebView/WebView.mm: Add missing #import. 2008-02-05 Mark Rowe Reviewed by Oliver Hunt. Update versioning to support the mysterious future. * Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060. 2008-01-30 Justin Garcia Reviewed by Darin Adler. REGRESSION: Words selected with a double click and copied won't paste into Mail * WebView/WebHTMLView.mm: (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought this back, it's used by Mail. (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is also used by Mail. Moved to WebPrivate. * WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't accidently remove them in the future. 2008-01-30 Mark Rowe Reviewed by Oliver Hunt. Move off deprecated NSTableView methods. * WebView/WebHTMLView.mm: (-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:. (-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:. (-[WebTextCompleteController filterKeyDown:]): Ditto. 2008-01-26 Mark Rowe Reviewed by Darin Adler. Fix leaks seen after loading . * Misc/WebNSDataExtras.m: (-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers to the new CFString so that they will be freed when no longer needed. 2008-01-26 Greg Bolsinga WebDashboardRegion.h duplicated between WebCore / WebKit Reviewed by Darin. * WebCoreSupport/WebDashboardRegion.h: Removed. * WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore. 2008-01-21 Darin Adler Reviewed by John Sullivan. - fix Delegate-less WebKit clients should have no databases - add a missing export of WebDatabaseExpectedSizeKey - implement deleteOrigin: and remove deleteDatabasesWithOrigin: * Storage/WebDatabaseManager.mm: (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null name instead of calling isValid(). (-[WebDatabaseManager deleteOrigin:]): Implemented. (WebKitInitializeDatabasesIfNecessary): Updated for name change. * Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:. * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions we had before with a single one. * WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey. * WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey. * WebView/WebPreferences.m: (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey. * WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and setDefaultDatabaseQuota:. * WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate methods we had before with a single one. * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Removed the code to set the default database origin quota in WebCore::Settings based on WebPreferences. * WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual types of parameters that the database UI delegate methods had before. 2008-01-20 Mark Rowe Reviewed by Dan Bernstein. Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer interested in supporting Safari 2 with TOT WebKit. * WebView/WebView.mm: (+[WebView initialize]): 2008-01-17 Timothy Hatcher Reviewed by Adam Roben. REGRESSION (r29581): no form field focus rings and inactive text selection after loading a page Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance The problem was other frames were changing the FocusController's active status to false after the first responder frame set it to true. The last frame to call _updateActiveState would win. * WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive() if the first responder is the current WebHTMLView or the WebFrameView. (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState. 2008-01-18 Adam Roben Rename _updateActiveState to _updateFocusedAndActiveState Also renamed any related methods/members similarly. Reviewed by Adele. * WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]): (-[WebHTMLView close]): (_updateFocusedAndActiveStateTimerCallback): (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]): (-[WebHTMLView windowDidBecomeKey:]): (-[WebHTMLView windowDidResignKey:]): (-[WebHTMLView becomeFirstResponder]): (-[WebHTMLView resignFirstResponder]): * WebView/WebHTMLViewInternal.h: * WebView/WebHTMLViewPrivate.h: 2008-01-17 John Sullivan Reviewed by Darin - fixed -1 WebFrameView world leaks reported after closing view source window * WebView/WebFrameView.mm: (-[WebFrameView initWithCoder:]): override to bump the global WebFrameView count 2008-01-16 Adam Roben Updated for renames/removal of WebCore methods. Reviewed by Darin. * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerSelectionColor]): Changed to ask isFocusedAndActive directly, instead of going through the frame bridge. * WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Updated for method renames. 2008-01-16 John Sullivan Reviewed by Adam and Dan - cleaned up some existing logging * WebView/WebHTMLView.mm: (-[WebHTMLView setNeedsDisplay:]): add method name to log, use "YES" and "NO" instead of (int)flag (-[WebHTMLView setNeedsLayout:]): ditto (-[WebHTMLView setNeedsToApplyStyles:]): ditto 2008-01-15 Geoffrey Garen Reviewed by Andre Boule. Fixed [WebCache empty] implementation should not disable/enable the cache Toggle the cache model instead -- toggling disable/enable just causes the cache to forget about resources, not reclaim their memory. * Misc/WebCache.mm: (+[WebCache empty]): * WebView/WebView.mm: * WebView/WebViewInternal.h: 2008-01-15 Adele Peterson Reviewed by Adam and Antti. WebKit part of fix for Add load progress indicator to video controls * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Removed initialization for GetMediaControlBackgroundImageData. Added initialization for DrawMediaSliderTrack. 2008-01-10 Geoffrey Garen Reviewed by John Sullivan. Fixed some world leak reports: * PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite * PLT complains about world leak if browser window is open when PLT starts These were both bugs in the reporting mechanism, so I took the opportunity to do some house cleaning there. * Misc/WebCoreStatistics.h: Did a little renaming, to match JavaScriptCore better. I kept the methods with the old names around, though, because old versions of Safari need them. * Misc/WebCoreStatistics.mm: Removed dependence on WebCore::JavaScriptStatistics, which is gone now. These two methods are now distinct, for the sake of world leak reporting: (+[WebCoreStatistics javaScriptGlobalObjectsCount]): (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): 2008-01-10 Maciej Stachowiak Not reviewed. Build fix. - Attempt to fix mac build. * Storage/WebDatabaseManager.mm: 2008-01-10 Maciej Stachowiak Reviewed by Sam. - remove SecurityOriginData and fold its functionality into SecurityOrigin * Storage/WebDatabaseManager.mm: (-[WebDatabaseManager origins]): (-[WebDatabaseManager databasesWithOrigin:]): (-[WebDatabaseManager detailsForDatabase:withOrigin:]): (-[WebDatabaseManager deleteDatabasesWithOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]): * Storage/WebDatabaseTrackerClient.h: * Storage/WebDatabaseTrackerClient.mm: (WebDatabaseTrackerClient::dispatchDidModifyOrigin): (WebDatabaseTrackerClient::dispatchDidModifyDatabase): * Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): (-[WebSecurityOrigin isEqual:]): (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin finalize]): (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]): (-[WebSecurityOrigin _core]): * Storage/WebSecurityOriginInternal.h: * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): 2008-01-10 Sam Weinig Reviewed by Anders Carlsson. Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522 * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation to ensure the shouldAllowNavigation check is made. 2008-01-07 Nikolas Zimmermann Reviewed by Mark. Enable SVG_FONTS by default. * Configurations/WebKit.xcconfig: 2008-01-07 Adele Peterson Reviewed by Antti, Adam, and Mitz. WebKit part of fix for Updated look for