2010-02-08 Kwang Yul Seo Reviewed by Darin Adler. Use fastStrDup instead of strdup https://bugs.webkit.org/show_bug.cgi?id=33943 Replace strdup/free with fastStrDup/fastFree. * bridge/IdentifierRep.h: (WebCore::IdentifierRep::IdentifierRep): * bridge/jni/JNIBridge.cpp: (JavaMethod::~JavaMethod): (appendClassName): (JavaMethod::signature): * bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass): * platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): * platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::setCookieJarFileName): (WebCore::ResourceHandleManager::initializeHandle): * plugins/PluginStream.cpp: (WebCore::PluginStream::~PluginStream): (WebCore::PluginStream::startStream): * xml/XSLTProcessorLibxslt.cpp: (WebCore::xsltParamArrayFromParameterMap): (WebCore::freeXsltParamArray): 2010-02-08 Tor Arne Vestbø Reviewed by Simon Hausmann. Fix Qt build on Windows. nmake fails to pick the right cpp file, so we have to rename the file to to a unique name. * WebCore.pro: * platform/graphics/qt/FontCustomPlatformDataQt.cpp: Renamed from WebCore/platform/graphics/qt/FontCustomPlatformData.cpp. 2010-02-08 Nikolas Zimmermann Reviewed by Dirk Schulze. All SVG *-expected.txt files contain wrong results https://bugs.webkit.org/show_bug.cgi?id=34703 Finally dump meaningful information for SVG layout tests. Use 'absoluteClippedOverflowRect' which goes through the same code paths used to actually calculate repaint rects etc - instead of the legacy CSS-unaware code path that mapped 'repaintRectInLocalCoordinates' through 'absoluteTransform'. Remove absoluteTransform() - a long standing TODO, finally not needed anymore. Despite SVGRenderTreeAsText, SVGPaintServerGradient was also using absoluteTransform(). Rewrite the code in question, fixing svg/W3C-SVG-1.1/pserver-grad-08-b.svg alignment issues when scaling/panning text using gradient on stroke/fill. Affects some other gradient tests as well. As we're now dumping clipped overflow rects any problems with repaint rects will become immediate visible - it turns out we're not supporting the overflow rules on the outermost element properly (repaint rects and bounding boxes need to take special SVG overflow rules into account). Fixing that magically gives pixel-perfect clipped overflow rects for all types of shapes/text/containers. Note: This will break any overriden platform-specific SVG results, need to wait for build bots in order to update them. * rendering/RenderObject.cpp: Remove absoluteTransform() method, centralize overflow query code in SVGRenderSupport::isOverflowHidden(). * rendering/RenderObject.h: Remove absoluteTransform() method. * rendering/RenderSVGHiddenContainer.h: Ditto. * rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode. (WebCore::RenderSVGRoot::computeRectForRepaint): Respect SVG overflow rules here: clip repaintRect against overflow rect _before_ passing along to RenderBox. This is the key issue behind wrong absoluteClippedOverflowRect() values. (WebCore::RenderSVGRoot::nodeAtPoint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode. * rendering/RenderSVGRoot.h: Remove absoluteTransform(). Don't expose viewportSize() anymore. * rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): Fix default stroke width to 1. This was the only wrong place -> fixes repaint rects for stroked text. * rendering/RenderSVGViewportContainer.cpp: Remove absoluteTransform() method. (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode. * rendering/RenderSVGViewportContainer.h: Remove absoluteTransform() method. * rendering/SVGRenderSupport.cpp: Refactored overflow queries in one place, centralizing SVG specific assumptions about overflowX/Y. (WebCore::SVGRenderBase::isOverflowHidden): * rendering/SVGRenderSupport.h: * rendering/SVGRenderTreeAsText.cpp: Dump absoluteClippedOverflowRect() instead of absoluteTransform().mapRect(repaintRectInLocalCoordinates()). (WebCore::writePositionAndStyle): Affects all layout tests dumping render trees. * svg/graphics/SVGPaintServerGradient.cpp: Rewrite Gradient on text fill/stroke support on Cg, to avoid using absoluteTransform(). (WebCore::absoluteTransformForRenderer): (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup): 2010-02-07 Daniel Bates Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=34402 Implements all of the numeric CSS3 list-style-types as per section 4.3 of the CSS3 Lists module . Test: fast/lists/w3-css3-list-styles-numeric.html * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSValueKeywords.in: * inspector/front-end/SourceCSSTokenizer.re2js: * platform/text/CharacterNames.h: Added constant hyphenMinus. * rendering/RenderListMarker.cpp: (WebCore::): Defined enum SequenceType. (WebCore::toAlphabeticOrNumeric): Added. (WebCore::toAlphabetic): Modified to call WebCore::toAlphabeticOrNumeric. (WebCore::toNumeric): Added. (WebCore::listMarkerSuffix): (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::getRelativeMarkerRect): * rendering/style/RenderStyle.h: (WebCore::): * rendering/style/RenderStyleConstants.h: Added numeric list style types and fixed indent level for the enum values. (WebCore::): 2010-02-07 Ismail Donmez Reviewed by Darin Adler. Include wtf/StringExtras.h for strdup definition, which is needed for WinCE. * bridge/IdentifierRep.h: 2010-02-07 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: Fragment-held Elements Not Shown in Inspector. https://bugs.webkit.org/show_bug.cgi?id=34680 * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): * inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo): 2010-02-07 Jian Li Reviewed by Darin Fisher. [chromium] Change chromium interface to handle DownloadURL format. https://bugs.webkit.org/show_bug.cgi?id=34655 * platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::ChromiumDataObject): * platform/chromium/ChromiumDataObject.h: * platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::setData): 2010-02-06 Dimitri Glazkov No review, rolling out r54364. http://trac.webkit.org/changeset/54364 https://bugs.webkit.org/show_bug.cgi?id=34464 Introduced asserts in layout tests, needs more testing locally. * accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): * page/chromium/ChromeClientChromium.h: 2010-02-06 Dimitri Glazkov Reviewed by Adam Barth. Using inlines and function-level statics don't mix, according to gcc. https://bugs.webkit.org/show_bug.cgi?id=34663 De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines. It appears that the initialization check, generated by gcc doesn't account for a possibility that the function may be inlined, resulting in lazy initialization failure for more than one inlined instance of the function. No behavior change, so no new tests. * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::deviceRGBColorSpaceRef): * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: 2010-02-05 Geoffrey Garen Reviewed by Dan Bernstein. Added an ASSERT to catch an implausible but theoretically possible leak. In theory, if malloc allocated a UChar buffer directly after a StringImpl, the StringImpl might incorrecly assume that the UChar buffer was inline, and fail to delete it. This ASSERT is somewhat academic, since we don't use the same allocator in debug builds, but oh well. * platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::createUninitialized): * platform/text/StringImpl.h: Separated the inline buffer StringImpl constructor from the out-of-line buffer StringImpl constructor. Made the former ASSERT that its buffer was indeed inline, and the latter ASSERT that its buffer was indeed not inline. 2010-02-05 Chris Marrin Reviewed by Simon Fraser. Fixed changed virtual function in GraphicsLayerCACF and call order issues https://bugs.webkit.org/show_bug.cgi?id=34348 The correct virtual function in GraphicsLayerCACF is now being called. We also fixed an issue in QTMovieWin where the size of the movie was not being set correctly because the call order was changed. I also changed the order of a couple of calls in QTMovieWin to account for changed calling order from the logic above. * platform/graphics/win/GraphicsLayerCACF.cpp:Update to new virtual function API (WebCore::GraphicsLayerCACF::setContentsToMedia): (WebCore::GraphicsLayerCACF::updateContentsMedia): * platform/graphics/win/GraphicsLayerCACF.h:Update to new virtual function API (WebCore::GraphicsLayerCACF::): * platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::cacheMovieScale):Fix a bug where ratio was computed wrong because it was using integer math (QTMovieWinPrivate::task):Compute movie scale before computing movie size so values are correct (QTMovieWinPrivate::setSize):Move movie size update to updateMovieSize() (QTMovieWinPrivate::updateMovieSize):Wrap size update in a new call so it can be used from multiple places 2010-02-05 Enrica Casucci Reviewed by Simon Fraser. Horizontal scrollbar works in reverse at milliondollarcu.be https://bugs.webkit.org/show_bug.cgi?id=33848 Added a manual test. * manual-tests/win: Added. * manual-tests/win/horizontal-scroll-composited.html: Added. * platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::setScrollFrame): (WebCore::WKCACFLayerRenderer::setRootChildLayer): 2010-02-05 Ryan Leavengood Reviewed by David Levin. Implementation of GlyphPage::fill() for Haiku port. https://bugs.webkit.org/show_bug.cgi?id=34527 Covered by existing tests. * platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp 2010-01-19 Kenneth Rohde Christiansen Reviewed by Dave Hyatt. Implement flattening of framesets https://bugs.webkit.org/show_bug.cgi?id=32717 The following patch, builds ontop of Antti Koivisto's frameset flattening code from the iPhone source, which itself is based on the old Nokia Series 60 source. Layout tests have been added to test the functionality and the original code which has then been fixed to make these pass, as well as support frameset grids. Tests: fast/frames/flattening/frameset-flattening-advanced.html fast/frames/flattening/frameset-flattening-grid.html fast/frames/flattening/frameset-flattening-simple.html fast/frames/flattening/frameset-flattening-subframe-resize.html fast/frames/flattening/frameset-flattening-subframesets.html * page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::scheduleRelayout): * page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setFrameSetFlatteningEnabled): * page/Settings.h: (WebCore::Settings::frameSetFlatteningEnabled): * rendering/RenderFrame.cpp: (WebCore::RenderFrame::layoutWithFlattening): * rendering/RenderFrame.h: * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::positionFramesWithFlattening): (WebCore::RenderFrameSet::flattenFrameSet): (WebCore::RenderFrameSet::userResize): * rendering/RenderFrameSet.h: 2010-02-05 Simon Fraser Reviewed by Dan Bernstein. Changing display type of parent of input on focus causes input field to not receive key events https://bugs.webkit.org/show_bug.cgi?id=34620 When layout affects a text input, the RenderTextControl gets destroyed and recreated, which in turn makes a new innerTextElement. However, if the text field was focused, the VisibleSelection is left pointing to the old innerTextElement, so text input no longer works. The fix is to call updateFocusAppearanceSoon() when attaching the input element, which will update the selection if necessary. Test: fast/forms/restore-selection-after-layout.html * dom/Document.h: Add a paramter to updateFocusAppearanceSoon() and a member variable, m_updateFocusAppearanceRestoresSelection, to store its value until the timer fires. * dom/Document.cpp: (WebCore::Document::Document): Initialize m_updateFocusAppearanceRestoresSelection (WebCore::Document::updateFocusAppearanceSoon): New restorePreviousSelection parameter. (WebCore::Document::updateFocusAppearanceTimerFired): Pass m_updateFocusAppearanceRestoresSelection down. * dom/Element.cpp: (WebCore::Element::attach): Call updateFocusAppearanceSoon() with false. * dom/Element.h: The updateFocusAppearanceSoonAfterAttach() was undefined. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach): Call document()->updateFocusAppearanceSoon() with true. 2010-02-05 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns. https://bugs.webkit.org/show_bug.cgi?id=34646 * inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.show): (WebInspector.CookieItemsView.prototype._update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): (WebInspector.CookieItemsView.prototype._createDataGrid): (WebInspector.CookieItemsView.prototype._populateDataGrid.expiresCompare): (WebInspector.CookieItemsView.prototype._populateDataGrid): (WebInspector.CookieItemsView.prototype._createSimpleDataGrid): (WebInspector.CookieItemsView.prototype._populateSimpleDataGrid): (WebInspector.CookieItemsView.prototype._deleteCookieCallback): (WebInspector.CookieItemsView.prototype._refreshButtonClicked): * inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries): (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries): * inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.autoSizeColumns): * inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished): * inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished): * inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult): 2010-02-04 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: group cookies by frame, show total cookies size, allow sorting cookie table. https://bugs.webkit.org/show_bug.cgi?id=34617 * English.lproj/localizedStrings.js: * inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie): * inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._cookiesForDomain): (WebInspector.CookieItemsView.prototype.dataGridForCookies): (WebInspector.CookieItemsView.prototype._createNodes): (WebInspector.CookieItemsView.prototype._sortData.localeCompare): (WebInspector.CookieItemsView.prototype._sortData.numberCompare): (WebInspector.CookieItemsView.prototype._sortData.expiresCompare): (WebInspector.CookieItemsView.prototype._sortData): * inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect): (WebInspector.CookieSidebarTreeElement.prototype.get subtitle): (WebInspector.CookieSidebarTreeElement.prototype.set subtitle): * inspector/front-end/inspector.js: (WebInspector.updateResource): 2010-02-05 Maxime Simone Reviewed by David Levin. More robust conversion from BString to String for Haiku port. https://bugs.webkit.org/show_bug.cgi?id=34527 Covered by existing tests. * platform/text/haiku/StringHaiku.cpp: Fixed include order, Improved coversion from BString. 2010-02-05 Steve Falkenburg Reviewed by Adam Roben. Windows build fix. * WebCore.vcproj/WebCore.make: 2010-02-05 Csaba Osztrogonác Reviewed by Dirk Schulze. Rubber-stamped by Kenneth Rohde Christiansen. [Qt] Modifying SVG path dumping to equal to other ports https://bugs.webkit.org/show_bug.cgi?id=33784 * platform/graphics/qt/PathQt.cpp: (WebCore::Path::debugString): Path dumping style is aproached to Mac. 2010-02-05 Sebastian Dröge Reviewed by Gustavo Noronha. Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure https://bugs.webkit.org/show_bug.cgi?id=34317 * GNUmakefile.am: * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit): * platform/graphics/gtk/WebKitWebSourceGStreamer.cpp: * platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube. 2010-02-05 Nate Chapin Reviewed by Dimitri Glazkov. [V8] Clean up code for getting a v8::FunctionTemplate. https://bugs.webkit.org/show_bug.cgi?id=34606 * bindings/scripts/CodeGeneratorV8.pm: Making GetTemplate() public * bindings/v8/V8Binding.cpp: (WebCore::configureTemplate): * bindings/v8/V8DOMWrapper.cpp: Remove getTemplate(), use V8ClassIndex::getTemplate() instead. (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::instantiateV8Object): * bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::lookupDOMWrapper): * bindings/v8/V8Index.cpp: Remove duplicate caching of FunctionTemplates. (WebCore::V8ClassIndex::getTemplate): * bindings/v8/V8Index.h: * bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::toV8): * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate): * bindings/v8/custom/V8HTMLAudioElementConstructor.h: * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate): * bindings/v8/custom/V8HTMLImageElementConstructor.h: * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate): * bindings/v8/custom/V8HTMLOptionElementConstructor.h: * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScriptHostV8Wrapper): 2010-02-05 Siddharth Mathur Reviewed by Ariya Hidayat. [Qt] Build break in QtWebkit on Symbian https://bugs.webkit.org/show_bug.cgi?id=34597 * plugins/PluginView.h: 2010-02-05 Yury Semikhatsky Reviewed by Pavel Feldman. - Use SerializedScriptValue for passing data between injected script and inspector frontend. - Remove custom JSON implementation from the instpector utility script. - Make sure that only objects created in the same ScriptState can be values of ScriptObject/Array properties and arguments to ScriptFunctionCall. We don't want ScriptObjects to leak between contexts. - Use ScriptState of the 'this' object in ScriptFunctionCall instead of passing it as additional parameter. https://bugs.webkit.org/show_bug.cgi?id=33592 * bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript): * bindings/js/ScriptArray.cpp: (WebCore::ScriptArray::set): * bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument): * bindings/js/ScriptFunctionCall.h: * bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set): * bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::ScriptValue::deserialize): * bindings/js/ScriptValue.h: * bindings/v8/ScriptArray.cpp: (WebCore::ScriptArray::set): * bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument): * bindings/v8/ScriptFunctionCall.h: * bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set): * bindings/v8/ScriptState.h: * bindings/v8/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::deserialize): * bindings/v8/ScriptValue.h: * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback): * inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup): * inspector/InjectedScript.h: * inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript): * inspector/InjectedScriptHost.h: * inspector/InjectedScriptHost.idl: * inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): * inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::didPause): (WebCore::InspectorController::didEvaluateForTestInFrontend): * inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::newScriptArray): (WebCore::InspectorFrontend::newScriptObject): (WebCore::InspectorFrontend::populateFrontendSettings): (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount): (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::didGetResourceContent): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::addRecordToTimeline): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::setDocument): (WebCore::InspectorFrontend::setDetachedRoot): (WebCore::InspectorFrontend::setChildNodes): (WebCore::InspectorFrontend::childNodeCountUpdated): (WebCore::InspectorFrontend::childNodeInserted): (WebCore::InspectorFrontend::childNodeRemoved): (WebCore::InspectorFrontend::attributesUpdated): (WebCore::InspectorFrontend::didRemoveNode): (WebCore::InspectorFrontend::didGetChildNodes): (WebCore::InspectorFrontend::didApplyDomChange): (WebCore::InspectorFrontend::didGetEventListenersForNode): (WebCore::InspectorFrontend::didGetCookies): (WebCore::InspectorFrontend::didDispatchOnInjectedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::didGetDatabaseTableNames): (WebCore::InspectorFrontend::addDOMStorage): (WebCore::InspectorFrontend::selectDOMStorage): (WebCore::InspectorFrontend::didGetDOMStorageEntries): (WebCore::InspectorFrontend::didSetDOMStorageItem): (WebCore::InspectorFrontend::didRemoveDOMStorageItem): (WebCore::InspectorFrontend::updateDOMStorage): (WebCore::InspectorFrontend::addNodesToSearchResult): (WebCore::InspectorFrontend::contextMenuItemSelected): (WebCore::InspectorFrontend::evaluateForTestInFrontend): (WebCore::InspectorFrontend::callSimpleFunction): * inspector/InspectorFrontend.h: (WebCore::InspectorFrontend::scriptState): * inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.): * inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler): * inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.addConsoleMessage): 2010-02-05 Tor Arne Vestbø Reviewed by Simon Hausmann. [Qt] Generate convenience headers (QWebView, etc) using qmake In Qt this is done using syncqt, but we use a pro-file instead that generates makefile-rules for each of the extra headers. These extra headers are installed alongside the normal headers. * WebCore.pro: Use headers.pri based on DerivedSources instead of the one previously checked in in the source tree. 2010-02-05 Mikhail Naganov Reviewed by Pavel Feldman. Enable JAVASCRIPT_DEBUGGER in chromium port. https://bugs.webkit.org/show_bug.cgi?id=34638 * page/Console.cpp: * page/Console.h: * page/Console.idl: 2010-02-05 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: Tab width for javascript source is 8, should be 4 https://bugs.webkit.org/show_bug.cgi?id=31248 * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): * inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.set replaceTabsWithSpaces): (WebInspector.TextEditorModel.prototype._innerSetText): (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded): 2010-02-05 Tony Chang Reviewed by Eric Seidel. https://bugs.webkit.org/show_bug.cgi?id=24872 When pasting a list into another list should not indent another level. If the cursor is at the beginning of the line, it should insert the list items before the current list item. If the cursor is at the end of the line, it should insert the list items after the current list item. This matches Firefox and IE and makes the common activity of reordering a list work as expected. This also adds a small helper method (isListItem) to htmlediting.h. Test: editing/pasteboard/paste-list-002.html * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertAsListItems): * editing/ReplaceSelectionCommand.h: * editing/htmlediting.cpp: (WebCore::isListItem): (WebCore::appendedSublist): * editing/htmlediting.h: 2010-02-04 Mark Rowe Reviewed by Timothy Hatcher. Build fix. Remove a symbol corresponding to an inline function from the linker export file to prevent a weak external failure. * WebCore.base.exp: Remove symbol. * WebCore.xcodeproj/project.pbxproj: Accommodate rename of script. 2010-02-04 Geoffrey Garen Reviewed by Oliver Hunt. Updated to use new WeakGCPtr::clear interface. * bindings/js/JSEventListener.cpp: * bindings/js/JSEventListener.h: (WebCore::JSEventListener::invalidateJSFunction): 2010-02-04 Geoffrey Garen Build fix: Added a forwarding header. * ForwardingHeaders/runtime/WeakGCPtr.h: Added. 2010-02-04 Geoffrey Garen Reviewed by Alexey Proskuryakov and Darin Adler. REGRESSION (r52082): Missing event handlers on JQuery demo page (33383) https://bugs.webkit.org/show_bug.cgi?id=33383 There were two bugs here: 1. A stale wrapper would invalidate a node's event listeners, even if the node had a fresh wrapper keeping it alive. The fix for this is for an event listener to keep a WeakGCPtr back-pointer to the wrapper it expects to mark it. The wrapper destructor checks this back-pointer, and only invalidates the event listener in the case of a match. 2. Conversely, a stale wrapper would not invalidate a node's event listeners soon enough, if its destructor didn't have a chance to run before an event fired on the node. (This can only happen in cases where we've made some other error and failed to mark a wrapper that was circuitously observable in the DOM. But we know we have edge case bugs like this, and we don't want them to be crashes.) The fix for this is to check the wrapper back-pointer before firing the event listener. As long as the the wrapper back-pointer is not null, it's safe to fire the listener. * ForwardingHeaders/runtime/WeakGCPtr.h: Added. Appease build gods. * bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener): * bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener): * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::markChildren): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): Updated to pass a wrapper to the JSEventListener constructor. * bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::initializeJSFunction): (WebCore::JSEventListener::invalidateJSFunction): * bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): (WebCore::JSEventListener::isolatedWorld): (WebCore::JSEventListener::wrapper): (WebCore::JSEventListener::setWrapper): (WebCore::JSEventListener::jsFunction): (WebCore::createJSAttributeEventListener): Implemented the back-pointer described above. Refactored the jsFunction() accessor to return 0 if the wrapper back-pointer is 0. * bindings/js/JSEventSourceCustom.cpp: (WebCore::JSEventSource::addEventListener): (WebCore::JSEventSource::removeEventListener): * bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::initializeJSFunction): * bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): * bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::markChildren): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener): * bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener): (WebCore::JSNode::markChildren): * bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener): * bindings/js/JSWebSocketCustom.cpp: (WebCore::JSWebSocket::addEventListener): (WebCore::JSWebSocket::removeEventListener): * bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::markChildren): (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener): * bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::markChildren): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener): * bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::markChildren): (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): Updated to pass a wrapper to the JSEventListener constructor. * bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Updated to pass a wrapper to the JSEventListener constructor. (WebCore::getEventListenerHandlerBody): Updated for the fact that jsFunction() is no longer a virtual accessor on the EventHandler base class. * bindings/scripts/CodeGeneratorJS.pm: Updated for the fact that jsFunction() is no longer a virtual accessor on the EventHandler base class. Added a "JS" to invalidateEventListeners and markEventListeners to clarify that these actions are for JS event listeners only. Added a wrapper parameter to invalidateEventListeners for the back-pointer check explained above. * dom/EventListener.h: (WebCore::EventListener::invalidateJSFunction): ditto * dom/EventTarget.h: (WebCore::EventTarget::markJSEventListeners): (WebCore::EventTarget::invalidateJSEventListeners): ditto 2010-02-04 Tony Chang Reviewed by Eric Seidel. https://bugs.webkit.org/show_bug.cgi?id=25002 When inserting a new paragraph, avoid nesting empty divs. When pasting near the end of a paragraph, this prevents each paste command for getting nested one level deeper. Test: editing/inserting/paragraph-outside-nested-divs.html * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::highestVisuallyEquivalentDiv): (WebCore::InsertParagraphSeparatorCommand::doApply): 2010-02-04 Dumitru Daniliuc Reviewed by Eric Seidel. 1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always succeeds. 2. Jump straight to the transaction error callback when a statement fails in a way that makes sqlite automatically rollback the transaction. 3. Fix the code that handles the "quota reached" failure, as it is one of the failures that lead to an automatic transaction rollback. https://bugs.webkit.org/show_bug.cgi?id=34280 * platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::isAutoCommitOn): * platform/sql/SQLiteDatabase.h: * platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::begin): (WebCore::SQLiteTransaction::commit): (WebCore::SQLiteTransaction::rollback): (WebCore::SQLiteTransaction::transactionWasRolledBackBySqlite): * platform/sql/SQLiteTransaction.h: * storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::runStatements): (WebCore::SQLTransaction::runCurrentStatement): (WebCore::SQLTransaction::handleCurrentStatementError): (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): 2010-02-04 Peter Kasting Not reviewed, rollback. Rollback r54387, it doesn't fix builds and Chromium doesn't want this behavior. * platform/chromium/ScrollbarThemeChromiumMac.h: 2010-02-04 Stephen White Unreviewed, build fix. Fix for Chromium/Mac after palindromic scrollbar change (54345). Covered by many layout tests. * platform/chromium/ScrollbarThemeChromiumMac.h: (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages): 2010-02-04 Clemmitt Sigler Reviewed by David Levin. WebKitGTK doesn't build GtkLauncher when --enable-mathml is specified. Updated WebCore/GNUmakefile.am to include needed files in build. https://bugs.webkit.org/show_bug.cgi?id=34387 No new tests. * GNUmakefile.am: 2010-02-04 Stephan Aßmus Reviewed by David Levin. Misc coding style fixes in Haiku port code. https://bugs.webkit.org/show_bug.cgi?id=34527 No tests needed. * platform/haiku/ContextMenuItemHaiku.cpp: Trailing white space, NULL -> 0 * platform/haiku/DragImageHaiku.cpp: Trailing white space. * platform/haiku/FileChooserHaiku.cpp: Sorted headers. * platform/haiku/LocalizedStringsHaiku.cpp: Needed to include NotImplemented.h 2010-02-04 Enrica Casucci Reviewed by Csaba Osztrogonac. Fixed crash on QT introduced with the fix for https://bugs.webkit.org/show_bug.cgi?id=34609 The test has been added with the original patch. * platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writePlainText): Added missing allocation of m_writeData. 2010-02-04 Christian Dywan Reviewed by Xan Lopez. Conditionalize third party cookie policy for libsoup 2.29.90. * platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies): * platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS): * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): (WebCore::startHttp): * platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage): 2010-02-04 Christian Dywan Rubber-stamped by Gustavo Noronha Silva. Add ENABLE(VIDEO) guards around freeOwnedGPtr implementation. * platform/gtk/GOwnPtrGtk.cpp: 2010-02-04 Alexey Proskuryakov Reviewed by Darin Adler. Assertion failure in CheckedRadioButtons::removeButton when using jQuery 1.4.1 https://bugs.webkit.org/show_bug.cgi?id=34520 Test: fast/dom/HTMLInputElement/cloned-input-checked-state.html * dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Copy non-attribute properties before attributes. Otherwise, copying "checked" attribute would make the cloned node checked, unchecking original (they share a name, and are thus in the same radio group). We do want the original to be unchecked, but we also want to know its original state in HTMLInputElement::copyNonAttributeProperties(). * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties): Use setChecked instead of plain assignment to prevent m_checked getting out of sync with checkedRadioButtons. Also, copy field related to default checked state, so that m_checked won't be overridden when copying attributes. 2010-02-04 Kevin Ollivier [wx] Build fix after addition of Clipboard::writePlainText method. * platform/wx/ClipboardWx.cpp: (WebCore::ClipboardWx::writePlainText): * platform/wx/ClipboardWx.h: 2010-02-04 Enrica Casucci Reviewed by Oliver Hunt. REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info. https://bugs.webkit.org/show_bug.cgi?id=34609 Test: editing/pasteboard/drop-inputtext-acquires-style.html The dragging code did not distinguish the case of dragging the content of an input control as a special case. The markup placed in the pasteboard included the style information. I've modified the Clipboard class interface adding a new method writePlainText to match the behavior of the copy and cut commands and modified the drag code to detect the special case. I've modified all the platform specific implementations of the Clipboard class. * dom/Clipboard.h: Added writePlainText pure virtual function. * editing/Editor.cpp: (WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl. (WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl. * editing/htmlediting.cpp: (WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name in Editor.cpp * editing/htmlediting.h: * page/DragController.cpp: (WebCore::DragController::startDrag): * platform/Pasteboard.h: * platform/android/ClipboardAndroid.cpp: (WebCore::ClipboardAndroid::writePlainText): Added. * platform/android/ClipboardAndroid.h: * platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writePlainText): Added. * platform/chromium/ClipboardChromium.h: * platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::writePlainText): Added. * platform/gtk/ClipboardGtk.h: * platform/haiku/ClipboardHaiku.cpp: (WebCore::ClipboardHaiku::writePlainText): Added. * platform/haiku/ClipboardHaiku.h: * platform/mac/ClipboardMac.h: * platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::writePlainText): Added. * platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writePlainText): Added helper function. * platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writePlainText): Added. * platform/qt/ClipboardQt.h: * platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writePlainText): Added. * platform/win/ClipboardWin.h: 2010-02-04 Steve Block Reviewed by Nate Chapin. Fix bug in V8 convertNPVariantToJValue when converting float and double types https://bugs.webkit.org/show_bug.cgi?id=34593 No new tests, build fix only. * bridge/jni/v8/JNIUtilityPrivate.cpp: Modified. (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum. 2010-02-04 Chris Guillory Reviewed by Darin Fisher. [Chromium] Notify ChromeClientChromium of AccessibilityObject state change notifications. https://bugs.webkit.org/show_bug.cgi?id=34464 * accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::toChromeClientChromium): (WebCore::AXObjectCache::postPlatformNotification): * page/chromium/ChromeClientChromium.h: 2010-02-04 Stephen White Unreviewed, build fix for Chromium. Revert r54341 ("[v8] Remove clear method from DOM object maps"), since it causes the worker tests to fail on Chromium. * bindings/v8/DOMData.h: (WebCore::DOMData::removeObjectsFromWrapperMap): * bindings/v8/DOMDataStore.h: (WebCore::ChunkedTable::clear): (WebCore::ChunkedTable::clearEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear): * bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThreadHelper): (WebCore::removeAllDOMObjectsInCurrentThread): * bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::clear): * bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController): 2010-02-04 Gustavo Noronha Silva Reviewed by Xan Lopez. [GTK] Crashes when an invalid hostname is pre-fetched https://bugs.webkit.org/show_bug.cgi?id=34602 * platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS): NULL-check the SoupURI that is created from the hostname; that will happen for invalid hostnames. 2010-02-04 José Millán Soto Reviewed by Xan Lopez. [Gtk] webkitgtk crashed when Orca open https://bugs.webkit.org/show_bug.cgi?id=34463 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForObject): Checking if render objects are texts before calling toRenderText 2010-02-04 Xan Lopez Reviewed by Gustavo Noronha. Set first party URI in all SoupMessages. This allows libsoup to implement a "no third party cookies" policy in case it wants to. Also start a non-JSC-specific, gtk-specific GOwnPtr module and use it for SoupURI. * platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies): * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): (WebCore::startHttp): * platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage): 2010-02-04 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: group cookies by domains, not frame's domains. https://bugs.webkit.org/show_bug.cgi?id=34599 * inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._cookiesForDomain): * inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addCookieDomain): 2010-02-04 Nate Chapin Reviewed by Dimitri Glazkov. [V8] Delete V8CustomBinding.h and all references to V8Custom https://bugs.webkit.org/show_bug.cgi?id=32638 * bindings/v8/NPV8Object.cpp: * bindings/v8/V8DOMWindowShell.h: * bindings/v8/V8NPObject.cpp: * bindings/v8/V8Utilities.cpp: * bindings/v8/custom/V8AbstractWorkerCustom.cpp: * bindings/v8/custom/V8AttrCustom.cpp: * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: * bindings/v8/custom/V8ClipboardCustom.cpp: * bindings/v8/custom/V8CoordinatesCustom.cpp: * bindings/v8/custom/V8CustomBinding.h: Removed. * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: * bindings/v8/custom/V8DOMWindowCustom.cpp: * bindings/v8/custom/V8DataGridColumnListCustom.cpp: * bindings/v8/custom/V8DatabaseCustom.cpp: * bindings/v8/custom/V8ElementCustom.cpp: * bindings/v8/custom/V8EventSourceConstructor.cpp: * bindings/v8/custom/V8EventSourceCustom.cpp: * bindings/v8/custom/V8GeolocationCustom.cpp: * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate): * bindings/v8/custom/V8HTMLCollectionCustom.cpp: * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate): * bindings/v8/custom/V8HTMLInputElementCustom.cpp: * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate): * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: * bindings/v8/custom/V8HistoryCustom.cpp: * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: * bindings/v8/custom/V8LocationCustom.cpp: * bindings/v8/custom/V8MessagePortCustom.cpp: * bindings/v8/custom/V8NodeCustom.cpp: * bindings/v8/custom/V8NodeFilterCustom.cpp: * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: * bindings/v8/custom/V8SQLTransactionCustom.cpp: * bindings/v8/custom/V8SVGElementInstanceCustom.cpp: * bindings/v8/custom/V8SVGLengthCustom.cpp: * bindings/v8/custom/V8SharedWorkerCustom.cpp: * bindings/v8/custom/V8StorageCustom.cpp: * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: * bindings/v8/custom/V8WebGLArrayCustom.h: * bindings/v8/custom/V8WebGLByteArrayCustom.cpp: * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: * bindings/v8/custom/V8WebGLIntArrayCustom.cpp: * bindings/v8/custom/V8WebGLShortArrayCustom.cpp: * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: * bindings/v8/custom/V8WebKitPointConstructor.cpp: * bindings/v8/custom/V8WorkerContextCustom.cpp: * bindings/v8/custom/V8WorkerCustom.cpp: * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: 2010-02-04 Ariya Hidayat Reviewed by Simon Hausmann. [Qt] Unnecessary QBrush construction for doing a solid fill https://bugs.webkit.org/show_bug.cgi?id=34559 Use the similar trick like r37421, i.e. use the special brush for solid color to avoid creating QBrush again and again. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformFillColor): 2010-02-04 Dan Bernstein Reviewed by Simon Fraser. REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big https://bugs.webkit.org/show_bug.cgi?id=34371 Allow ScrollbarTheme to cap the overlap between pages, and set a cap of 40 in ScrollbarThemeMac. * WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages(). * editing/EditorCommand.cpp: (WebCore::verticalScrollDistance): Use Scrollbar methods instead of constants, and cap the scroll distance if needed. * platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars): Ditto. (WebCore::ScrollView::wheelEvent): Ditto. * platform/Scrollbar.cpp: (WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the value from the native scrollbar theme. * platform/Scrollbar.h: Replaced scroll amount constants with static methods. (WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep. (WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging. * platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation that returns the largest int. * platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of constants. * platform/haiku/PlatformWheelEventHaiku.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of constants. * platform/mac/ScrollbarThemeMac.h: (WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override that returns 40. * platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep. * platform/wx/MouseWheelEventWx.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of constants. * platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar methods instead of constants, and cap the scroll distance if needed. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto. 2010-02-04 No'am Rosenthal Reviewed by Ariya Hidayat. [Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary recaching, remove QTimer::singleShot and QPixmap::scaled, more accurate strategy of handling transform operation blends. Rotating a bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5. https://bugs.webkit.org/show_bug.cgi?id=34062 This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements. * platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs (WebCore::OpacityAnimationQt::updateState): style change 2010-02-04 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: Cookies for resources are not shown in storage panel. https://bugs.webkit.org/show_bug.cgi?id=34594 * inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies): * inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource): * inspector/InspectorResource.h: (WebCore::InspectorResource::requestURL): 2010-02-04 Anton Muhin Reviewed by Adam Barth. [v8] Remove clear method from DOM object maps https://bugs.webkit.org/show_bug.cgi?id=34530 No new tests. Should be covered by existent testing infrastructure. * bindings/v8/DOMData.h: * bindings/v8/DOMDataStore.h: * bindings/v8/V8DOMMap.cpp: * bindings/v8/V8DOMMap.h: * bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController): 2010-02-04 Holger Hans Peter Freyther Reviewed by Xan Lopez. [Gtk] Check if the renderer() exists in textForObject. This is fixing a crash in the textForObject method. It can happen when inspecting AtkObjects in the accerciser, then navigating to a new page and still inspecting the old tree. In this case the AccessibilityObjectWrapperAtk was still valid but the included renderer() was returning 0. Add a check for the accObject->renderer() before trying to use the result. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForObject): 2010-02-04 Yury Semikhatsky Reviewed by Pavel Feldman. Provide strongly typed C++ interface for inspector's injected script. https://bugs.webkit.org/show_bug.cgi?id=33616 * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor): * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor): * inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringifyForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup): * inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue): * inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup): * inspector/InjectedScriptHost.h: * inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId): * inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState): * inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): * inspector/front-end/InjectedScript.js: (injectedScriptConstructor): 2010-02-04 Philippe Normand Rubber stamped by Xan Lopez. Missing include, build fix after landing of patch from the bug 34435. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: 2010-02-02 Philippe Normand Reviewed by Gustavo Noronha Silva. [Gtk] libsoup critical warning in media player http cookies injection code https://bugs.webkit.org/show_bug.cgi?id=34435 Fixed the critical warning and refactored the User-Agent/Referer/cookies injection code, in that order. Previous order (cookies first) was wrong because if cookies injection could not be done neither the User-Agent nor Referer were injected. Also started a non-JSC-specific, gtk-specific GOwnPtr module. * GNUmakefile.am: * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): * platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement): * platform/gtk/GOwnPtrGtk.h: Added. 2010-02-04 Mikhail Naganov Reviewed by Timothy Hatcher. Put JSC-specific debugger & profiler code under "USE(JSC)" defines. The plan is to enable "JAVASCRIPT_DEBUGGER" in Chromium and then make this code engine-agnostic. https://bugs.webkit.org/show_bug.cgi?id=34531 * inspector/InjectedScriptHost.cpp: * inspector/InjectedScriptHost.h: * inspector/InspectorBackend.cpp: * inspector/InspectorBackend.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad): * inspector/InspectorController.h: * inspector/InspectorFrontend.cpp: * inspector/InspectorFrontend.h: * inspector/JavaScriptCallFrame.cpp: * inspector/JavaScriptCallFrame.h: * inspector/JavaScriptDebugListener.h: * inspector/JavaScriptDebugServer.cpp: * inspector/JavaScriptDebugServer.h: * inspector/JavaScriptProfile.cpp: * inspector/JavaScriptProfile.h: * inspector/JavaScriptProfileNode.cpp: * inspector/JavaScriptProfileNode.h: * loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): * page/Page.cpp: (WebCore::Page::Page): 2010-02-03 Nicholas Young Reviewed by Eric Carlson. Defer formatting of times displayed on media controls to the current theme. https://bugs.webkit.org/show_bug.cgi?id=34405 No new tests needed. Refactoring Only. * rendering/MediaControlElements.cpp: Removed formatTime() (WebCore::MediaControlTimeDisplayElement::setCurrentValue): No longer sets inner text * rendering/MediaControlElements.h: * rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateTimeDisplay): Asks the theme to format the time display elements * rendering/RenderTheme.cpp: (WebCore::RenderTheme::formatMediaControlsTime): new virtual method (WebCore::RenderTheme::formatMediaControlsCurrentTime): new virtual method (WebCore::RenderTheme::formatMediaControlsRemainingTime): new virtual method * rendering/RenderTheme.h: 2010-02-03 Steve Falkenburg Windows Debug_All build fix. * platform/graphics/win/WKCACFLayer.cpp: 2010-02-03 Brady Eidson Reviewed by Alexey Proskuryakov. REGRESSION (r51644): WebCore/manual-tests/linkjump-1.html fails and https://bugs.webkit.org/show_bug.cgi?id=34550 Tests: fast/loader/document-with-fragment-url-1.html fast/loader/document-with-fragment-url-2.html fast/loader/document-with-fragment-url-3.html fast/loader/document-with-fragment-url-4.html * platform/KURL.cpp: (WebCore::KURL::init): When resolving new URL from an empty reference relative to an absolute URL, any fragment identifier from the absolute URL should be removed from the resulting resolution. 2010-02-03 Kwang Yul Seo Reviewed by Eric Seidel. [BREWMP] Port TextBreakIteratorInternalICU https://bugs.webkit.org/show_bug.cgi?id=34515 Port TextBreakIteratorInternalICU. * platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Added. (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID): 2010-02-03 Adele Peterson Reviewed by Simon Fraser. Fix for https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/ CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319 Test: fast/css/counters/counter-before-selector-crash.html * rendering/RenderCounter.cpp: (WebCore::updateCounters): nil check. 2010-02-03 Adele Peterson Reviewed by Brady Eidson. Initialize the variable in the last checkin to false. I didn't realize DRT relies on this being false. So ports that want visited link tracking need to set that flag. * page/PageGroup.cpp: 2010-02-03 Adele Peterson Reviewed by Brady Eidson. Fix for https://bugs.webkit.org/show_bug.cgi?id=34547 static shouldTrackVisitedLinks is not initialized For ports that don't call into WebKit to initialize this, we should initialize to true so they get the visited link behavior by default. * page/PageGroup.cpp: 2010-02-03 Dan Bernstein Reviewed by Simon Fraser. Drag and Drop: background elements are bleeding through https://bugs.webkit.org/show_bug.cgi?id=34546 * manual-tests/drag-image-table-part-decorations.html: Added. * rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t paint within the current painting root. * rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): Ditto. * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto. (WebCore::RenderTableCell::paintBoxDecorations): Ditto. 2010-02-03 Nate Chapin Unreviewed, Chromium mac build fix. [V8] Remove unused V8Proxy* variable from generated wrapping code. * bindings/scripts/CodeGeneratorV8.pm: 2010-02-03 Nate Chapin Reviewed by Dimitri Glazkov. [V8] Use toV8() to wrap in the custom bindings, and remove the old wrapping code from V8DOMWrapper. https://bugs.webkit.org/show_bug.cgi?id=32563 * bindings/scripts/CodeGeneratorV8.pm: * bindings/v8/ScriptController.cpp: * bindings/v8/ScriptObject.cpp: * bindings/v8/V8AbstractEventListener.cpp: * bindings/v8/V8Collection.h: * bindings/v8/V8DOMWindowShell.cpp: * bindings/v8/V8DOMWrapper.cpp: * bindings/v8/V8DOMWrapper.h: * bindings/v8/V8NodeFilterCondition.cpp: * bindings/v8/V8Proxy.cpp: * bindings/v8/WorkerContextExecutionProxy.h * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: * bindings/v8/custom/V8CustomPositionCallback.cpp: * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: * bindings/v8/custom/V8DOMWindowCustom.cpp: * bindings/v8/custom/V8DataGridColumnListCustom.cpp: * bindings/v8/custom/V8DocumentCustom.cpp: * bindings/v8/custom/V8DocumentLocationCustom.cpp: * bindings/v8/custom/V8ElementCustom.cpp: * bindings/v8/custom/V8EventCustom.cpp: * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: * bindings/v8/custom/V8HTMLCollectionCustom.cpp: * bindings/v8/custom/V8HTMLDocumentCustom.cpp: * bindings/v8/custom/V8HTMLFormElementCustom.cpp: * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: * bindings/v8/custom/V8MessageChannelConstructor.cpp: * bindings/v8/custom/V8MessageEventCustom.cpp: * bindings/v8/custom/V8NamedNodeMapCustom.cpp: * bindings/v8/custom/V8NodeIteratorCustom.cpp: * bindings/v8/custom/V8NodeListCustom.cpp: * bindings/v8/custom/V8NotificationCenterCustom.cpp: * bindings/v8/custom/V8SVGMatrixCustom.cpp: * bindings/v8/custom/V8StyleSheetListCustom.cpp: * bindings/v8/custom/V8TreeWalkerCustom.cpp: * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: * bindings/v8/custom/V8XSLTProcessorCustom.cpp: 2010-02-03 Sam Weinig Reviewed by Anders Carlsson. Fix drawing buttons in viewless WebKit. * platform/mac/ThemeMac.mm: (WebCore::paintButton): If there is no view, make sure to flip the context so that the button is drawn correctly. 2010-02-03 Yael Aharon Reviewed by Kenneth Rohde Christiansen. [Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork https://bugs.webkit.org/show_bug.cgi?id=34425 Reverting r54279, it was a misunderstanding. * platform/network/qt/SocketStreamHandlePrivate.h: * platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::send): (WebCore::SocketStreamHandlePrivate::close): 2010-02-03 Drew Wilson Reviewed by Alexey Proskuryakov. SharedWorkerScriptLoader should not be an ActiveDOMObject https://bugs.webkit.org/show_bug.cgi?id=34513 Test: Existing tests suffice (fixes test downstream in Chrome). * workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to no longer derive from ActiveDOMObject (handles its own refcounting). (WebCore::SharedWorkerScriptLoader::load): Now increments own refcount when a load is pending. (WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to decrement refcount when load is complete. * workers/WorkerScriptLoaderClient.h: Documentation change about reliability of notifyFinished() when used from worker context. 2010-02-03 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: Inspector renders blank scripts on reloading the webpage. https://bugs.webkit.org/show_bug.cgi?id=34537 * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): 2010-02-03 Yury Semikhatsky Reviewed by Pavel Feldman. Provide strongly typed C++ interface for inspector's injected script. https://bugs.webkit.org/show_bug.cgi?id=33616 * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor): * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor): * inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringify): (WebCore::InjectedScript::releaseWrapperObjectGroup): * inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue): * inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup): * inspector/InjectedScriptHost.h: * inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId): * inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState): * inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): 2010-02-03 Andras Becsi Unreviewed build fix. [Qt] Roll-out r54281 because it broke the build on the Qt Release bot. * platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::State::State): (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::setBaseTransform): (WebCore::GraphicsLayerQtImpl::drawContents): (WebCore::GraphicsLayerQtImpl::notifyChange): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setNeedsDisplayInRect): (WebCore::applyTimingFunction): (WebCore::webkitAnimationToQtAnimationValue): (WebCore::AnimationQtBase::updateState): (WebCore::AnimationQt::updateCurrentTime): (WebCore::TransformAnimationQt::TransformAnimationQt): (WebCore::TransformAnimationQt::~TransformAnimationQt): (WebCore::TransformAnimationQt::applyFrame): (WebCore::TransformAnimationQt::updateState): (WebCore::OpacityAnimationQt::updateState): (WebCore::GraphicsLayerQt::pauseAnimation): 2010-02-02 Bryan Yeung Reviewed by Darin Adler. Avoid using an invalidated KURL object in baseURI. https://bugs.webkit.org/show_bug.cgi?id=34492 This change fixes baseURI for Chromium (where the KURL implementation does not allow invalid KURLs to carry relative paths). This is regression tested by LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg This is a re-application of this patch since it was mistakenly identified as the cause of a big chromium test regression and rolled out in r54264. * dom/Element.cpp: (WebCore::Element::baseURI): 2010-02-02 Joel Stanley Reviewed by David Levin. [Chromium] Make setCaretBlinkInterval static. https://bugs.webkit.org/show_bug.cgi?id=31704 This is so it can be called from the newly exposed Chromium API setter method. * rendering/RenderThemeChromiumLinux.cpp: * rendering/RenderThemeChromiumLinux.h: 2010-02-02 Yael Aharon Reviewed by Kenneth Rohde Christiansen. [Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork https://bugs.webkit.org/show_bug.cgi?id=34425 Buffer the sent data in SocketStreamHandlePrivate instead of relying on the network layer to do it. This is more robust and more consistent with how Qt's HTTP stack works. Close the socket in SocketStreamHandlePrivate::close() regardless of its state. No new tests, since no new functionality is introduced. * platform/network/qt/SocketStreamHandlePrivate.h: * platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::send): (WebCore::SocketStreamHandlePrivate::close): (WebCore::SocketStreamHandlePrivate::socketBytesWritten): 2010-02-03 Shinichiro Hamaji Unreviewed revert of r54259 as it seems to break chromium's unit tests. The tests pass with r54257 but fail with r54260. As r54258 and r54260 don't touch code, I'm reverting this change. [V8] Generate toV8 conversion helpers, a la JSC bindings. https://bugs.webkit.org/show_bug.cgi?id=32563 * bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement): * bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set): * bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): * bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::toNativeCollection): (WebCore::getNamedPropertyOfCollection): (WebCore::collectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::collectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter): (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionIndexedGetter): (WebCore::setCollectionNamedGetter): (WebCore::setCollectionStringOrNullIndexedGetter): (WebCore::setCollectionStringIndexedGetter): * bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): * bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object): * bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object): * bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): * bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException): * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8Object): (WebCore::V8CanvasRenderingContext2D::createPatternCallback): * bindings/v8/custom/V8CustomPositionCallback.cpp: (WebCore::V8CustomPositionCallback::handleEvent): * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: (WebCore::V8CustomPositionErrorCallback::handleEvent): * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent): * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent): * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent): * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): * bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openCallback): (WebCore::V8DOMWindow::indexedPropertyGetter): (WebCore::V8DOMWindow::namedPropertyGetter): * bindings/v8/custom/V8DataGridColumnListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): * bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::evaluateCallback): (WebCore::V8Document::getCSSCanvasContextCallback): (WebCore::V8Document::implementationAccessorGetter): * bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorGetter): * bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNodeNSCallback): * bindings/v8/custom/V8EventCustom.cpp: (WebCore::V8Event::dataTransferAccessorGetter): (WebCore::V8Event::clipboardDataAccessorGetter): * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLAllCollection::callAsFunctionCallback): * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8Custom::v8HTMLAudioElementConstructorCallback): * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback): * bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLCollection::callAsFunctionCallback): * bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorGetter): * bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::V8HTMLFormElement::indexedPropertyGetter): (WebCore::V8HTMLFormElement::namedPropertyGetter): * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::V8HTMLFrameSetElement::namedPropertyGetter): * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8Custom::v8HTMLImageElementConstructorCallback): * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::V8HTMLOptionsCollection::indexedPropertyGetter): * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::V8HTMLSelectElement::namedPropertyGetter): (WebCore::V8HTMLSelectElement::indexedPropertyGetter): * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): (WebCore::V8InjectedScriptHost::nodeForIdCallback): (WebCore::V8InjectedScriptHost::databaseForIdCallback): * bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback): * bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::portsAccessorGetter): * bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::indexedPropertyGetter): (WebCore::V8NamedNodeMap::namedPropertyGetter): * bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::namedPropertyGetter): (WebCore::V8NodeList::callAsFunctionCallback): * bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback): * bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::V8SVGMatrix::multiplyCallback): (WebCore::V8SVGMatrix::inverseCallback): (WebCore::V8SVGMatrix::rotateFromVectorCallback): * bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::V8StyleSheetList::namedPropertyGetter): * bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8Object): * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object): * bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::V8XSLTProcessor::transformToFragmentCallback): (WebCore::V8XSLTProcessor::transformToDocumentCallback): 2010-02-03 Mikhail Naganov Reviewed by Pavel Feldman. Start unforking debugger and profiler code. Remove custom implementation of Console. Add 'ScriptProfiler' and 'ScriptProfile' types. Start migration to engine-neutral types in InspectorController. https://bugs.webkit.org/show_bug.cgi?id=34481 * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSBindingsAllInOne.cpp: * bindings/js/JSConsoleCustom.cpp: * bindings/js/ScriptProfile.h: Added. * bindings/js/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop): * bindings/js/ScriptProfiler.h: Added. * bindings/scripts/CodeGeneratorV8.pm: * bindings/v8/ScriptProfile.h: Added. (WebCore::ScriptProfile::create): (WebCore::ScriptProfile::~ScriptProfile): (WebCore::ScriptProfile::title): (WebCore::ScriptProfile::uid): (WebCore::ScriptProfile::ScriptProfile): * bindings/v8/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop): * bindings/v8/ScriptProfiler.h: Added. * bindings/v8/custom/V8ConsoleCustom.cpp: Removed. * inspector/InspectorController.cpp: (WebCore::InspectorController::endGroup): (WebCore::InspectorController::show): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::createProfileHeader): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::specialPanelForJSName): * inspector/InspectorController.h: (WebCore::InspectorController::searchingForNodeInPage): * page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd): * page/Console.h: (WebCore::): (WebCore::Console::create): (WebCore::Console::profiles): * page/Console.idl: 2010-02-02 Kent Tamura Reviewed by Darin Adler. Fix a bug that changes for some constraint attributes doesn't update validation CSS selectors. https://bugs.webkit.org/show_bug.cgi?id=31716 - Rename HTMLFormControlElement::updateValidity() to setNeedsValidityCheck() - Introduce HTMLFormControlElement::setNeedsWillValidate() - Introduce HTMLFormControlElement::m_hasName to make willValidate() work in parseMappedAttribute(). - We need to call setNeedsValidityCheck() when HTMLInputElement::step or HTMLTextAreaElement::maxLength is changed. * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::insertedIntoTree): (WebCore::HTMLFormControlElement::removedFromTree): (WebCore::HTMLFormControlElement::formDestroyed): (WebCore::HTMLFormControlElement::willValidate): Avoids function calls. (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): (WebCore::HTMLFormControlElement::setNeedsValidityCheck): * html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::disabled): Move the code from .cpp. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer): * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::setValue): * rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged): 2010-02-02 Roland Steiner Reviewed by Adele Peterson. Bug 34198 - Ruby text should not inherit line-height (https://bugs.webkit.org/show_bug.cgi?id=34198) Resetting line-height to 'normal' in the default UA style sheet. Adding layout-test to check for this. Test: fast/ruby/ruby-line-height.html * css/html.css: 2010-02-02 James Robinson Reviewed by Dmitry Titov. Add a null check for image, which might be NULL if tileSize is empty https://bugs.webkit.org/show_bug.cgi?id=34510 Test: fast/gradients/crash-on-1px-border.html * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): 2010-02-02 Kent Tamura Reviewed by Darin Adler. rangeOverflow/rangeUnderflow support for type=datetime, datetime-local, month, time and week https://bugs.webkit.org/show_bug.cgi?id=34483 Tests: fast/forms/ValidityState-rangeOverflow.html fast/forms/ValidityState-rangeUnderflow.html * html/HTMLInputElement.cpp: Defines the hard limits for the types as double values. (WebCore::HTMLInputElement::rangeUnderflow): Supports the types. (WebCore::HTMLInputElement::rangeOverflow): Supports the types. (WebCore::HTMLInputElement::minimum): Supports the types. (WebCore::HTMLInputElement::maximum): Supports the types. 2010-02-02 Fumitoshi Ukai Reviewed by Alexey Proskuryakov. WebSocket set pending activity to avoid unexpected GC. https://bugs.webkit.org/show_bug.cgi?id=34014 Test: websocket/tests/websocket-pending-activity.html * websockets/WebSocket.cpp: (WebCore::WebSocket::connect): set pending activity until it receives didClose. (WebCore::WebSocket::contextDestroyed): check socket is already closed. (WebCore::WebSocket::stop): close the connection and unset pending activity when it stops. (WebCore::WebSocket::didClose): unset pending activity. * websockets/WebSocket.h: * websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): protect this while it processes received data. 2010-02-02 Gustavo Noronha Silva No review, rolling out r54261. http://trac.webkit.org/changeset/54261 https://bugs.webkit.org/show_bug.cgi?id=34435 Causes crashes on release builds * GNUmakefile.am: * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): * platform/gtk/GOwnPtrGtk.cpp: Removed. * platform/gtk/GOwnPtrGtk.h: Removed. 2010-02-02 David Levin No review, rolling out r54245. http://trac.webkit.org/changeset/54245 https://bugs.webkit.org/show_bug.cgi?id=34492 This patch seems to have broken thousands of chromium tests on Windows (and since it was for chromium, I'm rolling it out). * dom/Element.cpp: (WebCore::Element::baseURI): 2010-02-02 Steve Falkenburg Reviewed by Darin Adler. Copyright year updating for Windows version resources should be automatic https://bugs.webkit.org/show_bug.cgi?id=34503 * WebCore.vcproj/QTMovieWin.rc: 2010-02-02 Dimitri Glazkov No review, rolling out r54257. http://trac.webkit.org/changeset/54257 https://bugs.webkit.org/show_bug.cgi?id=34491 [Chromium] broke thousands of Win tests and a few of Linux tests. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): * platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::applyAntiAliasedClipPaths): * platform/graphics/skia/PlatformContextSkia.h: 2010-02-02 Philippe Normand Reviewed by Gustavo Noronha Silva. [Gtk] libsoup critical warning in media player http cookies injection code https://bugs.webkit.org/show_bug.cgi?id=34435 Fixed the critical warning and refactored the User-Agent/Referer/cookies injection code, in that order. Previous order (cookies first) was wrong because if cookies injection could not be done neither the User-Agent not Referer were injected. Also started a non-JSC-specific, gtk-specific GOwnPtr module. * GNUmakefile.am: * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): * platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement): * platform/gtk/GOwnPtrGtk.h: Added. 2010-02-02 Nate Chapin Reviewed by Dimitri Glazkov. [V8] Use toV8() to wrap in the custom bindings, and remove the old wrapping code from V8DOMWrapper. https://bugs.webkit.org/show_bug.cgi?id=32563 * bindings/v8/ScriptController.cpp: * bindings/v8/ScriptObject.cpp: * bindings/v8/V8AbstractEventListener.cpp: * bindings/v8/V8Collection.h: * bindings/v8/V8DOMWindowShell.cpp: * bindings/v8/V8DOMWrapper.cpp: * bindings/v8/V8DOMWrapper.h: * bindings/v8/V8NodeFilterCondition.cpp: * bindings/v8/V8Proxy.cpp: * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: * bindings/v8/custom/V8CustomPositionCallback.cpp: * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: * bindings/v8/custom/V8DOMWindowCustom.cpp: * bindings/v8/custom/V8DataGridColumnListCustom.cpp: * bindings/v8/custom/V8DocumentCustom.cpp: * bindings/v8/custom/V8DocumentLocationCustom.cpp: * bindings/v8/custom/V8ElementCustom.cpp: * bindings/v8/custom/V8EventCustom.cpp: * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: * bindings/v8/custom/V8HTMLCollectionCustom.cpp: * bindings/v8/custom/V8HTMLDocumentCustom.cpp: * bindings/v8/custom/V8HTMLFormElementCustom.cpp: * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: * bindings/v8/custom/V8MessageChannelConstructor.cpp: * bindings/v8/custom/V8MessageEventCustom.cpp: * bindings/v8/custom/V8NamedNodeMapCustom.cpp: * bindings/v8/custom/V8NodeIteratorCustom.cpp: * bindings/v8/custom/V8NodeListCustom.cpp: * bindings/v8/custom/V8NotificationCenterCustom.cpp: * bindings/v8/custom/V8SVGMatrixCustom.cpp: * bindings/v8/custom/V8StyleSheetListCustom.cpp: * bindings/v8/custom/V8TreeWalkerCustom.cpp: * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: * bindings/v8/custom/V8XSLTProcessorCustom.cpp: 2010-02-02 Garret Kelly Reviewed by David Levin. When using the Skia graphics context, the beginTransparencyLayer call currently creates a new layer, but does not keep the current compositing mode for use when merging the created layer back onto the rest of the context. This patch fixes that. https://bugs.webkit.org/show_bug.cgi?id=34491 fast/backgrounds/svg-as-mask.html is affected by this change in Chromium, but not fixed. This is the first of a series of patches to fix it. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): * platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::beginTransparencyLayer): * platform/graphics/skia/PlatformContextSkia.h: 2010-02-02 Kwang Yul Seo Reviewed by Eric Seidel. Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument https://bugs.webkit.org/show_bug.cgi?id=34409 Platform guards for localtime_r are not needed because we already have WTF::getLocalTime which does the same thing. * loader/FTPDirectoryDocument.cpp: (WebCore::processFileDateString): * loader/FTPDirectoryParser.cpp: (WebCore::gmtimeQt): 2010-02-02 Adam Roben Copy WebCore's bindings generation scripts to the PrivateHeaders directory on Mac This will allow other projects to use these scripts. Fixes . Reviewed by Mark Rowe. * WebCore.xcodeproj/project.pbxproj: Added the bindings generation scripst to the Copy Headers phase, and marked them as Private. 2010-02-02 Adam Roben Copy WebCore's bindings generation scripts to a more sensible location Part of Bug 34496: Clean up WebCore's IDL/script copying Reviewed by Steve Falkenburg. * WebCore.vcproj/WebCore.make: * WebCore.vcproj/WebCoreGenerated.vcproj: Instead of copying to obj/WebKit/DOMInterfaces, copy to obj/WebCore/scripts. 2010-02-02 Adam Roben Rename the scripts used to copy WebCore's bindings generation scripts Part of Bug 34496: Clean up WebCore's IDL/script copying Reviewed by Steve Falkenburg. * WebCore.vcproj/MigrateScripts: Renamed from WebCore/WebCore.vcproj/MigrateIDLAndScripts. * WebCore.vcproj/migrate-scripts.sh: Renamed from WebCore/WebCore.vcproj/migrate-idls.sh. * WebCore.vcproj/WebCoreGenerated.vcproj: Updated for renames. 2010-02-02 Adam Roben Stop copying IDL files into $(WebKitOutputDir) No one uses these anymore (as of r52921). Part of Bug 34496: Clean up WebCore's IDL/script copying Reviewed by Steve Falkenburg. * WebCore.vcproj/MigrateIDLAndScripts: Don't copy the IDL files anymore. Keep copying the scripts, though, since other projects (outside of the WebKit repository) do use those. 2010-02-02 Bryan Yeung Reviewed by Darin Adler. Avoid using an invalidated KURL object in baseURI. https://bugs.webkit.org/show_bug.cgi?id=34492 This change fixes baseURI for Chromium (where the KURL implementation does not allow invalid KURLs to carry relative paths). This is regression tested by LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg * dom/Element.cpp: (WebCore::Element::baseURI): 2010-02-02 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=34076 Crash in mangleme in WebCore::Element::getAttribute Test: fast/forms/misplaced-img-form-registration.html * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerImgElement): Assert that the same image isn't added to vector again. (WebCore::HTMLFormElement::removeImgElement): Similarly, assert that we're removing something that's actually registered. * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): If parser fails to insert the image element, then there will be no removed from tree notification either, need to unregister right away. 2010-02-02 Alexander Pavlov Reviewed by Pavel Feldman. Web Inspector: Eliminate some of the platform flavor-specific stylesheet selectors Extract OS version into WebInspector.platformFlavor https://bugs.webkit.org/show_bug.cgi?id=34469 * inspector/front-end/InspectorBackendStub.js: * inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.platform): * inspector/front-end/inspector.css: * inspector/front-end/inspector.js: (WebInspector.pendingDispatches.0.URLRegExp.i.get platform): (WebInspector.get platformFlavor): (WebInspector._detectPlatformFlavor): (WebInspector.loaded): (WebInspector.toolbarDragStart): (WebInspector.isMac): 2010-02-02 Steve Block Reviewed by Ariya Hidayat. Adds utility functions for converting between JavaInstance and NPAPI types https://bugs.webkit.org/show_bug.cgi?id=34468 This is required by Android for injecting objects into V8 JavaScript. No new tests, added utility functions only. * Android.v8bindings.mk: Modified. Added JavaNPObjectV8.cpp * bridge/jni/v8/JavaNPObjectV8.cpp: Added. (JSC::Bindings::AllocJavaNPObject): (JSC::Bindings::FreeJavaNPObject): (JSC::Bindings::): (JSC::Bindings::JavaInstanceToNPObject): (JSC::Bindings::ExtractJavaInstance): (JSC::Bindings::JavaNPObjectHasMethod): (JSC::Bindings::JavaNPObjectInvoke): (JSC::Bindings::JavaNPObjectHasProperty): (JSC::Bindings::JavaNPObjectGetProperty): * bridge/jni/v8/JavaNPObjectV8.h: Added. 2010-02-02 Benjamin Poulain Reviewed by Ariya Hidayat. [Qt] Symbian plugins include a wrong header file for QPixmap https://bugs.webkit.org/show_bug.cgi?id=34475 * plugins/symbian/PluginViewSymbian.cpp: 2010-02-02 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: URLs are not syntax-higlighted as links in source view. This change enables linkifier in the NativeTextViewer. It adds "linkify" and "a_node" parse states into the highlighter in order to detect links and distinguish between resource and external ones. Contains drive-by fix for the webkit-html-* styles and moves them to the common location. https://bugs.webkit.org/show_bug.cgi?id=34364 * inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer): (WebInspector.NativeTextViewer.prototype._createSpan): (WebInspector.NativeTextViewer.prototype._createLink): (WebInspector.NativeTextViewer.prototype._rewriteHref): * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype._createEditorIfNeeded): * inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType): (WebInspector.SourceHTMLTokenizer.prototype.nextToken): * inspector/front-end/SourceHTMLTokenizer.re2js: * inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded): * inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): * inspector/front-end/inspector.css: * inspector/front-end/inspectorSyntaxHighlight.css: 2010-02-02 Simon Hausmann Reviewed by Ariya Hidayat. [Qt] Install libraries and headers in package builds https://bugs.webkit.org/show_bug.cgi?id=34325 Add the QtWebKit libraries to the installable items, except on Symbian where the libraries are always linked in their final destination. Also include the headers generated by syncqt in the installation. * WebCore.pro: 2010-02-02 Kavita Kanetkar Reviewed by Dmitry Titov. [V8] Raising an exception while setting timeout/interval from a detached frame https://bugs.webkit.org/show_bug.cgi?id=34453 This fixes the issue/failing test mentioned in Chromium bug: http://code.google.com/p/chromium/issues/detail?id=32671 * bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl): 2010-02-02 Kwang Yul Seo Reviewed by Eric Seidel. [BREWMP] Port Screen https://bugs.webkit.org/show_bug.cgi?id=34299 Get the screen size and depth from the main display bitmap. * platform/brew/ScreenBrew.cpp: Added. (WebCore::getDisplayInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): 2010-02-02 Kwang Yul Seo Reviewed by Eric Seidel. [BREWMP] Port LocalizedStrings https://bugs.webkit.org/show_bug.cgi?id=34257 Port LocalizedStrings to BREWMP. * platform/brew/LocalizedStringsBrew.cpp: Added. (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::unknownFileSizeText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::imageTitle): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::AXButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXMenuListPopupActionVerb): (WebCore::AXMenuListActionVerb): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText): 2010-02-02 Kwang Yul Seo Reviewed by Eric Seidel. [BREWMP] Port systemBeep https://bugs.webkit.org/show_bug.cgi?id=33601 Implement systemBeep with IShell_Beep. * platform/brew/SoundBrew.cpp: Added. (WebCore::systemBeep): 2010-02-02 Shinichiro Hamaji Reviewed by Eric Seidel. [Win] Utilize PrintContext to share the printing code with other ports https://bugs.webkit.org/show_bug.cgi?id=34312 No new tests as this is just a small refactoring. 2010-02-02 Kwang Yul Seo Reviewed by Eric Seidel. [BREWMP] Add conversions between IntPoint and AEEPoint https://bugs.webkit.org/show_bug.cgi?id=34194 Make it easy to convert between IntPoint and AEEPoint. * platform/graphics/IntPoint.h: * platform/graphics/brew/IntPointBrew.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator AEEPoint): 2010-02-02 Steve Block Reviewed by Adam Barth. Adds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap::Visitor https://bugs.webkit.org/show_bug.cgi?id=34434 No new tests, build fix only. * bindings/v8/V8DOMMap.h: Modified. (WebCore::AbstractWeakReferenceMap::~AbstractWeakReferenceMap): Added. (WebCore::AbstractWeakReferenceMap::Visitor::~Visitor): Added. 2010-02-02 Avi Drissman Reviewed by Eric Seidel. Sync up Chromium Mac render theme to Mac render theme https://bugs.webkit.org/show_bug.cgi?id=34340 Covered by existing layout tests. * platform/chromium/ThemeChromiumMac.mm: (WebCore::updateStates): (WebCore::checkbox): (WebCore::paintCheckbox): (WebCore::radio): (WebCore::paintRadio): (WebCore::listButtonSizes): (WebCore::setupButtonCell): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::controlBorder): (WebCore::ThemeChromiumMac::paint): * rendering/RenderThemeChromiumMac.h: * rendering/RenderThemeChromiumMac.mm: (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]): (WebCore::convertNSColorToColor): (WebCore::RenderThemeChromiumMac::systemColor): (WebCore::RenderThemeChromiumMac::isControlStyled): (WebCore::RenderThemeChromiumMac::adjustRepaintRect): (WebCore::RenderThemeChromiumMac::convertToPaintingRect): (WebCore::RenderThemeChromiumMac::paintCapsLockIndicator): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintMenuListButton): (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): (WebCore::RenderThemeChromiumMac::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::setSearchFieldSize): (WebCore::RenderThemeChromiumMac::adjustSearchFieldStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::popupButton): (WebCore::RenderThemeChromiumMac::sliderThumbHorizontal): (WebCore::RenderThemeChromiumMac::sliderThumbVertical): 2010-02-02 Kwang Yul Seo Reviewed by Eric Seidel. [BREWMP] Port Logging https://bugs.webkit.org/show_bug.cgi?id=34300 Log calls to notImplemented() by default. * platform/brew/LoggingBrew.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary): 2010-02-02 Kwang Yul Seo Reviewed by Eric Seidel. [BREWMP] Port FileChooser https://bugs.webkit.org/show_bug.cgi?id=34261 Port FileChooser to BREWMP. * platform/brew/FileChooserBrew.cpp: Added. (WebCore::FileChooser::basenameForWidth): 2010-02-01 Zoltan Horvath Reviewed by Darin Adler. Allow custom memory allocation control for IconDatabaseClient class https://bugs.webkit.org/show_bug.cgi?id=33252 Inherits the following struct from Noncopyable because it is instantiated by 'new' and no need to be copyable: class name - instantiated at: WebCore/'location' class IconDatabaseClient - loader/icon/IconDatabase.cpp:89 * loader/icon/IconDatabaseClient.h: 2010-02-01 Kwang Yul Seo Reviewed by Eric Seidel. [BREWMP] Port MIMETypeRegistry https://bugs.webkit.org/show_bug.cgi?id=34220 Port MIMETypeRegistry with an extension map as other ports do. * platform/brew: Added. * platform/brew/MIMETypeRegistryBrew.cpp: Added. (WebCore::): (WebCore::MIMETypeRegistry::getMIMETypeForExtension): 2010-02-01 Dmitry Titov Not reviewed, revert r54194 that fails new test on Qt and Chromium. https://bugs.webkit.org/show_bug.cgi?id=34382 * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setNameAndOpenURL): (WebCore::HTMLFrameElementBase::insertedIntoDocument): * html/HTMLFrameElementBase.h: * page/Frame.cpp: * page/Frame.h: 2010-02-01 Shinichiro Hamaji Reviewed by Eric Seidel. Provide a way to get page number with layoutTestController https://bugs.webkit.org/show_bug.cgi?id=33840 Test: printing/page-break-always.html * WebCore.base.exp: * WebCore.xcodeproj/project.pbxproj: * page/PrintContext.cpp: (WebCore::PrintContext::pageRect): Added a getter function. (WebCore::PrintContext::computePageRects): Move its logic into computePageRectsWithPageSize. (WebCore::PrintContext::computePageRectsWithPageSize): Factored out from computePageRects for pageNumberForElement. (WebCore::enclosingBoxModelObject): Added for pageNumberForElement. (WebCore::PrintContext::pageNumberForElement): Added for testing. * page/PrintContext.h: 2010-02-01 Kwang Yul Seo Reviewed by Eric Seidel. [BREWMP] Add conversions between IntSize and AEESize https://bugs.webkit.org/show_bug.cgi?id=34197 Make it easy to convert between IntSize and AEESize. * platform/graphics/IntSize.h: * platform/graphics/brew/IntSizeBrew.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator AEESize): 2010-02-01 Stephen White Reviewed by Eric Seidel. Fix for Pattern transformations in Chromium/Skia. This required reworking Pattern a bit to be more like the Gradient implementation. In particular, it now holds an m_pattern reference to the platform-specific implementation, and passes along changes to the m_patternSpaceTransformation, in the same way that Gradient does for m_gradientSpaceTransformation. This is necessary since Skia creates the platform-specific pattern (SkShader) once, rather than recreating it on each draw. For platforms other than Skia, m_pattern is unused, they will continue to use the static createPlatformPattern(), and the new notification functions are stubbed out. Other platforms can switch to the new implementation if they so choose. https://bugs.webkit.org/show_bug.cgi?id=24534 Covered by svg/custom/pattern-y-offset.svg, svg/custom/pattern-cycle-detection.svg, and many more. * platform/graphics/Pattern.cpp: (WebCore::Pattern::Pattern): Initializer for m_pattern. (WebCore::Pattern::~Pattern): call platformDestroy(). (WebCore::Pattern::setPatternSpaceTransform): Pass along the transform via setPlatformPatternSpaceTransform(). (WebCore::Pattern::platformDestroy): (WebCore::Pattern::setPlatformPatternSpaceTransform): Stub implementations for non-skia platforms. * platform/graphics/Pattern.h: * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): Call platformPattern() instead of static version. Since Pattern now owns its SkShader, no need to unref here. * platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformDestroy): Unref the SkShader on destroy. (WebCore::Pattern::platformPattern): Create the platform pattern (SkShader) once, and cache it. (WebCore::Pattern::setPlatformPatternSpaceTransform): Set the shader's local matrix from the m_patternSpaceTransformation. 2010-02-01 Daniel Bates Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=27312 Implements support for full page blocking via the X-XSS-Protection header. Tests: http/tests/security/xssAuditor/full-block-base-href.html http/tests/security/xssAuditor/full-block-get-from-iframe.html http/tests/security/xssAuditor/full-block-iframe-javascript-url.html http/tests/security/xssAuditor/full-block-iframe-no-inherit.php http/tests/security/xssAuditor/full-block-javascript-link.html http/tests/security/xssAuditor/full-block-link-onclick.html http/tests/security/xssAuditor/full-block-object-tag.html http/tests/security/xssAuditor/full-block-post-from-iframe.html http/tests/security/xssAuditor/full-block-script-tag-with-source.html http/tests/security/xssAuditor/full-block-script-tag.html http/tests/security/xssAuditor/malformed-xss-protection-header.html * page/XSSAuditor.cpp: (WebCore::XSSAuditor::shouldFullPageBlockForXSSProtectionHeader): Added. (WebCore::XSSAuditor::findInRequest): Modified to call method XSSAuditor::shouldFullPageBlockForXSSProtectionHeader. * page/XSSAuditor.h: Defined method shouldFullPageBlockForXSSProtectionHeader and fixed misspelled words in large comment block. 2010-02-01 Kwang Yul Seo Reviewed by Eric Seidel. [BREWMP] Port SharedTimer with IShell_SetTimerEx. https://bugs.webkit.org/show_bug.cgi?id=33599 As fireTime passed in setSharedTimerFireTime is the absolute time, we must calcalute the interval by subtracting currentTime() from fireTime and pass the result to ISHELL_SetTimerEx. * platform/brew/SharedTimerBrew.cpp: Added. (WebCore::invokeCallback): (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer): 2010-02-01 Shinichiro Hamaji [Chromium] Unreviewed attempt to fix the chromium build. Corresponding change: http://trac.webkit.org/changeset/54182 * bindings/scripts/CodeGeneratorV8.pm: * bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): * bindings/v8/ScriptController.h: 2010-02-01 Dmitry Titov Reviewed by David Levin. When a live iframe element is moved between pages, it still depends on the old page. https://bugs.webkit.org/show_bug.cgi?id=34382 Test: fast/frames/iframe-reparenting-new-page.html * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setName): Move the code setting the frame name into a separate function. (WebCore::HTMLFrameElementBase::setNameAndOpenURL): (WebCore::HTMLFrameElementBase::updateLiveFrame): Update frame tree, reset page in the contentFrame and re-set the name. (WebCore::HTMLFrameElementBase::insertedIntoDocument): * html/HTMLFrameElementBase.h: * page/Frame.cpp: (WebCore::Frame::setPage): * page/Frame.h: Add setPage method. It is only currently used when iframe is moved between pages (so the ASSERT(m_ownerElement). 2010-02-01 Brady Eidson Reviewed by Tim Hatcher. Add common IRC ports to port blocking. and https://bugs.webkit.org/show_bug.cgi?id=34451 * platform/KURL.cpp: (WebCore::portAllowed): 2010-01-29 Jeremy Orlow Reviewed by Nate Chapin. [V8] Add compile time guards for IndexedDB custom functions https://bugs.webkit.org/show_bug.cgi?id=34368 * bindings/v8/custom/V8IDBRequestCustom.cpp: * bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: 2010-01-29 Gavin Barraclough Reviewed by Sam Weinig + Oliver Hunt. Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds Change HTMLMediaElement methods that require checking whether the event is a user gesture to be passed a boolean. This may be passed from the JSC bindings (where we have an exec state), or read from the event. Add a Flag to the IDL to mark this information is required. * WebCore.Video.exp: * bindings/js/JSDOMBinding.cpp: (WebCore::processingUserGesture): * bindings/js/JSDOMWindowCustom.cpp: (WebCore::domWindowAllowPopUp): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog): * bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation): * bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::processingUserGestureEvent): (WebCore::ScriptController::anyPageIsProcessingUserGesture): * bindings/js/ScriptController.h: * bindings/scripts/CodeGeneratorJS.pm: * dom/Event.cpp: (WebCore::Event::isUserEvent): * dom/Event.h: * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::beginScrubbing): (WebCore::HTMLMediaElement::documentDidBecomeActive): (WebCore::HTMLMediaElement::webkitEnterFullScreen): * html/HTMLMediaElement.h: * html/HTMLMediaElement.idl: * loader/FrameLoader.cpp: (WebCore::FrameLoader::isProcessingUserGesture): * loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler): * page/DOMWindow.cpp: (WebCore::DOMWindow::allowPopUp): * rendering/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::defaultEventHandler): 2010-02-01 Andreas Kling Reviewed by Kenneth Rohde Christiansen. [Qt] Use the fallback style on Maemo 5 https://bugs.webkit.org/show_bug.cgi?id=34376 * platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::fallbackStyle): (WebCore::RenderThemeQt::qStyle): (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists): * platform/qt/RenderThemeQt.h: 2010-02-01 Kavita Kanetkar Reviewed by Nate Chapin. [V8] Making V8 generated classes' GetTemplate() function public https://bugs.webkit.org/show_bug.cgi?id=34026 * bindings/scripts/CodeGeneratorV8.pm: Generated code need not depend on V8CustomBinding.h, made GetTemplate() signature public. 2010-02-01 Steve Block Reviewed by Ariya Hidayat. Adds V8-specific JNI bridge classes https://bugs.webkit.org/show_bug.cgi?id=34166 This is the V8 equivalent of bridge/jni/jsc/JNIBridgeJSC. No new tests, build fix only. * Android.v8bindings.mk: Modified. Added JNIBridge.cpp and JNIBridgeV8.cpp * bridge/Bridge.h: Modified. Added missing include for Noncopyable.h * bridge/jni/v8/JNIBridgeV8.cpp: Added. (JavaField::JavaField): * bridge/jni/v8/JNIBridgeV8.h: Added. (JSC::Bindings::JavaField::name): (JSC::Bindings::JavaField::type): (JSC::Bindings::JavaField::getJNIType): 2010-02-01 Steve Block Reviewed by Ariya Hidayat. Adds V8-specific JNI utility functions. https://bugs.webkit.org/show_bug.cgi?id=33901 This is the V8 equivalent of bridge/jni/jsc/JNIUtilityPrivate. No new tests, build fix only. * Android.v8bindings.mk: Modified. Add JNIUtilityPrivate.cpp * bridge/jni/v8/JNIUtilityPrivate.cpp: Added. (JSC::Bindings::convertNPVariantToJValue): (JSC::Bindings::convertJValueToNPVariant): * bridge/jni/v8/JNIUtilityPrivate.h: Added. 2010-02-01 Steve Block Reviewed by Ariya Hidayat. Adds V8 version of JavaClass https://bugs.webkit.org/show_bug.cgi?id=33898 This is the V8 equivalent of bridge/jni/jsc/JavaClassJSC No new tests, build fix only. * Android.v8bindings.mk: Modified. Added JavaClassV8.cpp * bridge/jni/v8/JavaClassV8.cpp: Added. (JavaClass::JavaClass): (JavaClass::~JavaClass): (JavaClass::methodsNamed): (JavaClass::fieldNamed): * bridge/jni/v8/JavaClassV8.h: Added. 2010-02-01 Steve Block Reviewed by Ariya Hidayat. Adds V8 version of JavaInstance https://bugs.webkit.org/show_bug.cgi?id=33951 This is the V8 equivalent of bridge/jni/jsc/JavaInstanceJSC. Also fixes a typo in a comment in JavaInstanceJSC.cpp. No new tests, build fix only. * Android.v8bindings.mk: Modified. Added JavaInstanceV8.cpp * bridge/jni/jsc/JavaInstanceJSC.cpp: Modified. (JavaInstance::invokeMethod): Modified. Fixed comment * bridge/jni/v8/JavaInstanceV8.cpp: Added. (JavaInstance::JavaInstance): (JavaInstance::~JavaInstance): (JavaInstance::getClass): (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper): (JObjectWrapper::~JObjectWrapper): * bridge/jni/v8/JavaInstanceV8.h: Added. (JSC::Bindings::JObjectWrapper::instance): (JSC::Bindings::JObjectWrapper::setInstance): (JSC::Bindings::JObjectWrapper::ref): (JSC::Bindings::JObjectWrapper::deref): (JSC::Bindings::JavaInstance::javaInstance): (JSC::Bindings::JavaInstance::begin): (JSC::Bindings::JavaInstance::end): (JSC::Bindings::JavaInstance::virtualBegin): (JSC::Bindings::JavaInstance::virtualEnd): 2010-02-01 Dumitru Daniliuc Reviewed by Eric Seidel. Making sure that all in-progress transactions are rolled back on the database thread before they're destroyed. Otherwise, SQLiteTransaction's destructor will try to do a rollback and that would cause an assertion failure, if the object is not destroyed on the DB thread. https://bugs.webkit.org/show_bug.cgi?id=34152 * platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop): * storage/SQLTransaction.cpp: (WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown): * storage/SQLTransaction.h: * storage/SQLTransactionCoordinator.cpp: (WebCore::SQLTransactionCoordinator::shutdown): 2010-02-01 Sam Weinig Reviewed by Beth Dakin. Fix EXPERIMENTAL_SINGLE_VIEW_MODE build. * page/EventHandler.h: * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::currentNSEvent): (WebCore::EventHandler::currentKeyboardEvent): (WebCore::EventHandler::mouseDown): (WebCore::EventHandler::mouseDragged): (WebCore::EventHandler::mouseUp): (WebCore::EventHandler::mouseMoved): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::wheelEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): 2010-02-01 Nate Chapin Unreviewed, Chromium build fix. Failed to properly add new files for http://trac.webkit.org/changeset/54150. * bindings/v8/custom/V8BarInfoCustom.cpp: Added. * bindings/v8/custom/V8CSSRuleCustom.cpp: Added. * bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added. * bindings/v8/custom/V8CSSValueCustom.cpp: Added. * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added. * bindings/v8/custom/V8DOMSelectionCustom.cpp: Added. * bindings/v8/custom/V8HTMLElementCustom.cpp: Added. * bindings/v8/custom/V8SVGDocumentCustom.cpp: Added. * bindings/v8/custom/V8SVGElementCustom.cpp: Added. * bindings/v8/custom/V8SVGPathSegCustom.cpp: Added. * bindings/v8/custom/V8ScreenCustom.cpp: Added. * bindings/v8/custom/V8StyleSheetCustom.cpp: Added. * bindings/v8/custom/V8WebGLArrayCustom.cpp: Added. 2010-01-27 Matt Perry Reviewed by Eric Seidel. Add support for addUserScript to chromium port. * bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): * bindings/v8/ScriptController.h: 2010-02-01 Eric Carlson Reviewed by Dan Bernstein. https://bugs.webkit.org/show_bug.cgi?id=34448 RenderVideo::intrinsicSizeChanged infinite recursion * rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Make protected instead of private so it can be called by RenderVideo. * rendering/RenderVideo.cpp: (WebCore::RenderVideo::intrinsicSizeChanged): Call RenderMedia::intrinsicSizeChanged, not RenderVideo::intrinsicSizeChanged. (WebCore::RenderVideo::imageChanged): Call RenderMedia::imageChanged instead of RenderImage::imageChanged. 2010-02-01 Nate Chapin Reviewed by Dimitri Glazkov. [V8] Generate toV8() converter for most WebCore->V8 conversions, and defined custom converters in their respective V8Custom.cpp. Old converters in V8DOMWrapper will be deleted in a later patch. https://bugs.webkit.org/show_bug.cgi?id=32563 * Android.v8bindings.mk: * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * bindings/scripts/CodeGeneratorV8.pm: * bindings/v8/V8Collection.h: * bindings/v8/V8DOMWrapper.cpp: * bindings/v8/V8DOMWrapper.h: * bindings/v8/V8Proxy.h: * bindings/v8/custom/V8BarInfoCustom.cpp: Added. * bindings/v8/custom/V8CSSRuleCustom.cpp: Added. * bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added. * bindings/v8/custom/V8CSSValueCustom.cpp: Added. * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added. * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: * bindings/v8/custom/V8ConsoleCustom.cpp: * bindings/v8/custom/V8DOMSelectionCustom.cpp: Added. * bindings/v8/custom/V8DOMWindowCustom.cpp: * bindings/v8/custom/V8DocumentCustom.cpp: * bindings/v8/custom/V8ElementCustom.cpp: * bindings/v8/custom/V8EventCustom.cpp: * bindings/v8/custom/V8HTMLDocumentCustom.cpp: * bindings/v8/custom/V8HTMLElementCustom.cpp: Added. * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: * bindings/v8/custom/V8HistoryCustom.cpp: * bindings/v8/custom/V8LocationCustom.cpp: * bindings/v8/custom/V8NamedNodeMapCustom.cpp: * bindings/v8/custom/V8NavigatorCustom.cpp: * bindings/v8/custom/V8NodeCustom.cpp: * bindings/v8/custom/V8SVGDocumentCustom.cpp: Added. * bindings/v8/custom/V8SVGElementCustom.cpp: Added. * bindings/v8/custom/V8SVGPathSegCustom.cpp: Added. * bindings/v8/custom/V8ScreenCustom.cpp: Added. * bindings/v8/custom/V8StyleSheetCustom.cpp: Added. * bindings/v8/custom/V8TreeWalkerCustom.cpp: * bindings/v8/custom/V8WebGLArrayCustom.cpp: Added. * bindings/v8/custom/V8WebGLByteArrayCustom.cpp: * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: * bindings/v8/custom/V8WebGLIntArrayCustom.cpp: * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: * bindings/v8/custom/V8WebGLShortArrayCustom.cpp: * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: * dom/make_names.pl: Add options to generate wrapper factory for V8 bindings. 2010-02-01 Alexander Pavlov Reviewed by Pavel Feldman. Web Inspector: lazy-load textual resources to avoid UI hangup https://bugs.webkit.org/show_bug.cgi?id=34332 * inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab): * inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.contentTabSelected): 2010-02-01 Brady Eidson Reviewed by Adele Peterson. Crash in Safari opening new tabs to "same page" and https://bugs.webkit.org/show_bug.cgi?id=34444 Test: fast/loader/crash-copying-backforwardlist.html * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Null check currentItem(). * page/Page.cpp: (WebCore::Page::goToItem): Ditto. 2010-02-01 Kevin Watters Reviewed by Kevin Ollivier. [wx] Remove unused file that doesn't seem to belong to the port. https://bugs.webkit.org/show_bug.cgi?id=34445 * platform/wx/KeyEventWin.cpp: Removed. 2010-02-01 Eric Carlson Reviewed by Adele Peterson. Fullscreen API should be on HTMLVideoElement https://bugs.webkit.org/show_bug.cgi?id=34438 Move fullscreen DOM APIs from HTMLMediaElement to HTMLVideoElement. * html/HTMLMediaElement.cpp: * html/HTMLMediaElement.h: * html/HTMLMediaElement.idl: * html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::paint): Removed outdated FIXME. (WebCore::HTMLVideoElement::paintCurrentFrameInContext): Ditto. (WebCore::HTMLVideoElement::webkitEnterFullScreen): Moved from HTMLMediaElement. (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto. (WebCore::HTMLVideoElement::webkitSupportsFullscreen): Ditto. (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto. * html/HTMLVideoElement.h: * html/HTMLVideoElement.idl: 2010-02-01 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: Syntax highlighting in source view of Resources pane stops half-way. There were two problems here: (1) styles for html highlighter were not added into the css file (they used to be injected manually in the SourceFrame before). (2) 'Tag' needed to be lexer's state, not parser's. Otherwise unbalanced quotes in the text nodes were matching too match into the string tokens. https://bugs.webkit.org/show_bug.cgi?id=34359 * inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer.prototype._createLineDivs): (WebInspector.NativeTextViewer.prototype._lineHeight): (WebInspector.NativeTextViewer.prototype.initFontMetrics): * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createEditorIfNeeded): * inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.nextToken): * inspector/front-end/SourceHTMLTokenizer.re2js: * inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype.initFontMetrics): (WebInspector.TextEditor.prototype._registerShortcuts): * inspector/front-end/inspectorSyntaxHighlight.css: 2010-02-01 Ben Murdoch Reviewed by Darin Adler. ScriptCallFrame's do not get line numbers/source id's if the caller is unkown. https://bugs.webkit.org/show_bug.cgi?id=34335 * bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed. 2010-02-01 Dirk Schulze Reviewed by Simon Fraser. Add back an AffineTransform class for use by SVG https://bugs.webkit.org/show_bug.cgi?id=33750 These are the first steps on reimplementing AffineTransform. Unlike the old affine code, this one is platform independent like TransformationMatrix. AffineTransform has the benefit, that it stores just 6 doubles instead of 16 in TransformationMatrix. The calculations of transformations are not that complex and can improve the memory usage and speed of SVG. AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at least for the moment). HTML Canvas is the first that makes use of the new AffineTransform. Next patches will introduce the affine code to SVG. No new tests. The new AffineTransformation code is tested by fast/canvas. * Android.mk: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw): * html/canvas/CanvasRenderingContext2D.h: * platform/graphics/GraphicsContext.h: * platform/graphics/Path.h: * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform): * platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t): * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform): * platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform): * platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform): * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform): * platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform): * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform): * platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix): * platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend): (WebCore::AffineTransform::toTransformationMatrix): * platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix): * platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform): * platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix): 2010-01-29 Philippe Normand Reviewed by Eric Carlson. [GTK] set playbin mute property depending on volume value https://bugs.webkit.org/show_bug.cgi?id=31586 New API in MediaPlayer for mute control. 3 new methods are introduced: - bool supportsMuting() const; - bool muted() const; - void setMuted(bool); Platform MediaPlayer implementations can support it easily if the underlying sound daemon/API supports muting (eg. not only setting volume to 0) like PulseAudio for instance on Linux. At the moment the only player supporting this new API is the MediaPlayerPrivateGStreamer. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): (WebCore::HTMLMediaElement::mediaPlayerMuteChanged): * html/HTMLMediaElement.h: * platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::supportsMuting): (WebCore::NullMediaPlayerPrivate::setMuted): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::muted): (WebCore::MediaPlayer::supportsMuting): (WebCore::MediaPlayer::setMuted): (WebCore::MediaPlayer::volumeChanged): (WebCore::MediaPlayer::muteChanged): * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerMuteChanged): * platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsMuting): (WebCore::MediaPlayerPrivateInterface::setMuted): * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::notifyMuteIdleCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedCallback): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::supportsMuting): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::muteChangedCallback): (WebCore::MediaPlayerPrivate::muteChanged): (WebCore::MediaPlayerPrivate::createGSTPlayBin): * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: 2010-02-01 Henry Haverinen Reviewed by Simon Hausmann. [Qt] Build without SSL support is broken Added missing #ifdefs for OpenSSL support and one null-pointer check for the socket. https://bugs.webkit.org/show_bug.cgi?id=34416 * platform/network/qt/SocketStreamHandlePrivate.h: * platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::send): 2010-02-01 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: Fix rest of the NativeTextViewer (line numbers, conditional breakpoints, selection). * inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer): (WebInspector.NativeTextViewer.prototype._updatePreferredSize): (WebInspector.NativeTextViewer.prototype._registerMouseListeners): (WebInspector.NativeTextViewer.prototype._mouseDown): (WebInspector.NativeTextViewer.prototype._contextMenu): (WebInspector.NativeTextViewer.prototype._lineForMouseEvent): (WebInspector.NativeTextViewer.prototype._lineHeight): * inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._registerMouseListeners): (WebInspector.TextEditor.prototype._offsetToLine): (WebInspector.TextEditor.prototype._lineHeight): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._paint): (WebInspector.TextEditor.prototype._updateDivDecorations): (WebInspector.TextEditor.prototype._paintSelection): 2010-02-01 Steve Block Reviewed by Ariya Hidayat. Adds implementation of JavaString for V8. https://bugs.webkit.org/show_bug.cgi?id=33953 No new tests, build fix only. * bridge/jni/JNIBridge.h: Modified. Include JavaStringV8.h for V8 * bridge/jni/v8: Added. * bridge/jni/v8/JavaStringV8.h: Added. (JSC::Bindings::JavaStringImpl::init): (JSC::Bindings::JavaStringImpl::UTF8String): (JSC::Bindings::JavaStringImpl::uchars): (JSC::Bindings::JavaStringImpl::length): 2010-02-01 Alex Milowski Reviewed by Darin Adler. Added compile time debug support for mathml layout (block boundary & baseline) * mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::stretchToHeight): (WebCore::RenderMathMLBlock::paint): * mathml/RenderMathMLBlock.h: 2010-02-01 Philippe Normand Rubber stamped by Xan Lopez. Fixed compilation warning about unsigned vs signed comparison. * plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint): 2010-01-31 Kent Tamura Unreviewed. Revert r54112 and r54124 because of Windows build error. * Android.mk: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw): * html/canvas/CanvasRenderingContext2D.h: * platform/graphics/GraphicsContext.h: * platform/graphics/Path.h: * platform/graphics/cairo/GraphicsContextCairo.cpp: * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: * platform/graphics/cairo/PathCairo.cpp: * platform/graphics/cairo/TransformationMatrixCairo.cpp: * platform/graphics/cg/GraphicsContextCG.cpp: * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: * platform/graphics/cg/PathCG.cpp: * platform/graphics/cg/TransformationMatrixCG.cpp: * platform/graphics/haiku/GraphicsContextHaiku.cpp: * platform/graphics/haiku/PathHaiku.cpp: * platform/graphics/qt/GraphicsContextQt.cpp: * platform/graphics/qt/PathQt.cpp: * platform/graphics/qt/TransformationMatrixQt.cpp: * platform/graphics/skia/GraphicsContextSkia.cpp: * platform/graphics/skia/PathSkia.cpp: * platform/graphics/skia/TransformationMatrixSkia.cpp: * platform/graphics/transforms/AffineTransform.cpp: Removed. * platform/graphics/transforms/AffineTransform.h: Removed. * platform/graphics/wince/GraphicsContextWince.cpp: * platform/graphics/wx/GraphicsContextWx.cpp: * platform/graphics/wx/PathWx.cpp: * platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::TransformationMatrix::operator wxGraphicsMatrix): 2010-01-31 Kwang Yul Seo Reviewed by Darin Adler. Limit the scope of packing alignment to avoid MSVC C4103 warning. https://bugs.webkit.org/show_bug.cgi?id=34390 Use pack(push, 16) and pack(pop) to limit the scope of packing alignment change. * bindings/js/JSSVGPODTypeWrapper.h: 2010-01-31 Kent Tamura Reviewed by Darin Adler. Fix valueAsNumber calculation for type=month. https://bugs.webkit.org/show_bug.cgi?id=34304 valueAsNumber calculation for type=month which was checked in as r53893 was the number of milliseconds since UNIX epoch, and it was wrong. The correct way is the number months since UNIX epoch. * html/DateComponents.cpp: (WebCore::DateComponents::setMonthsSinceEpoch): (WebCore::DateComponents::monthsSinceEpoch): * html/DateComponents.h: Declare setMonthsSinceEpoch() and monthsSinceEpoch(). * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): Switch to monthsSinceEpoch() for type=MONTH. (WebCore::HTMLInputElement::valueAsDate): Add code with millisecondsSinceEpoch() for MONTH because parseToDouble() changed its behavior. (WebCore::HTMLInputElement::setValueAsNumber): Use setMonthsSinceEpoch() for MONTH. 2010-01-31 Dan Bernstein Reviewed by Timothy Hatcher. Web Inspector: REGRESSION: Numbers in bubbles are vertically off-center https://bugs.webkit.org/show_bug.cgi?id=34398 * inspector/front-end/inspector.css: Specify line-height: normal for ".console-message .bubble" and ".sidebar-tree-item .status .bubble". 2010-01-28 Ojan Vafai Reviewed by Darin Adler. Implement CSSOM Range.getClientRects for collapsed selections https://bugs.webkit.org/show_bug.cgi?id=34239 When getting the quads for a range on a text node, allow returning zero width quads. This leaves the case of collapsed selections inside elements still not fixed, but no worse. * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): * rendering/RenderText.cpp: (WebCore::RenderText::absoluteQuadsForRange): 2010-01-31 Oliver Hunt Reviewed by Simon Fraser. Animated scaling of background-image is too slow https://bugs.webkit.org/show_bug.cgi?id=33808 Implement a version of the RenderImage animated scaling optimisation for background images. Due to the possibility of arbitrary transforms being applied to containing elements we explicitly check the current CTM of the context for scaling or rotation. * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage): * platform/graphics/GraphicsContext.h: * platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer): (WebCore::RenderBoxModelScaleData::size): (WebCore::RenderBoxModelScaleData::setSize): (WebCore::RenderBoxModelScaleData::lastPaintTime): (WebCore::RenderBoxModelScaleData::setLastPaintTime): (WebCore::RenderBoxModelScaleData::useLowQualityScale): (WebCore::RenderBoxModelScaleData::transform): (WebCore::RenderBoxModelScaleData::setTransform): (WebCore::RenderBoxModelScaleData::setUseLowQualityScale): (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed): (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired): (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended): * rendering/RenderBoxModelObject.h: 2010-01-31 Dirk Schulze Reviewed by Simon Fraser. Add back an AffineTransform class for use by SVG https://bugs.webkit.org/show_bug.cgi?id=33750 These are the first steps on reimplementing AffineTransform. Unlike the old affine code, this one is platform independent like TransformationMatrix. AffineTransform has the benefit, that it stores just 6 doubles instead of 16 in TransformationMatrix. The calculations of transformations are not that complex and can improve the memory usage and speed of SVG. AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at least for the moment). HTML Canvas is the first that makes use of the new AffineTransform. Next patches will introduce the affine code to SVG. No new tests. The new AffineTransformation code is tested by fast/canvas. * Android.mk: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw): * html/canvas/CanvasRenderingContext2D.h: * platform/graphics/GraphicsContext.h: * platform/graphics/Path.h: * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform): * platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t): * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform): * platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform): * platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform): * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform): * platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform): * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform): * platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix): * platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend): * platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix): * platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM): * platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM): * platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform): * platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix): 2010-01-31 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: [REGRESSION] Breakpoint source line is not displayed in the breakpoint manager. * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addBreakpointToSource): 2010-01-31 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: Introduce NativeTextViewer. This change handles rendering highlighted text, using browser's selection/drag/drop/click logic. Breakpoint decorations and program counter is working. Todo: line numbers are painted 'under' the text when scrolling horizontally, search is not yet implemented. https://bugs.webkit.org/show_bug.cgi?id=34391 * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/DivBasedTextViewer.js: Added. (WebInspector.DivBasedTextViewer): (WebInspector.DivBasedTextViewer.prototype._textChanged): (WebInspector.DivBasedTextViewer.prototype._createLineDivs): (WebInspector.DivBasedTextViewer.prototype._updatePreferredSize): (WebInspector.DivBasedTextViewer.prototype._scroll): (WebInspector.DivBasedTextViewer.prototype._registerMouseListeners): (WebInspector.DivBasedTextViewer.prototype._registerKeyboardListeners): (WebInspector.DivBasedTextViewer.prototype._registerClipboardListeners): (WebInspector.DivBasedTextViewer.prototype._paintSelection): (WebInspector.DivBasedTextViewer.prototype._positionDivDecoration): (WebInspector.DivBasedTextViewer.prototype._mouseDown): (WebInspector.DivBasedTextViewer.prototype._contextMenu): (WebInspector.DivBasedTextViewer.prototype._caretForMouseEvent): (WebInspector.DivBasedTextViewer.prototype._paintLine): (WebInspector.DivBasedTextViewer.prototype._createSpan): * inspector/front-end/Settings.js: * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype._createEditorIfNeeded): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype.resize): * inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._registerMouseListeners): (WebInspector.TextEditor.prototype._registerKeyboardListeners): (WebInspector.TextEditor.prototype._registerClipboardListeners): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype.revalidateDecorationsAndPaint): (WebInspector.TextEditor.prototype._updatePreferredSize): (WebInspector.TextEditor.prototype.resize): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._paintLine): (WebInspector.TextEditor.prototype._contextMenu): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._changeFont): * inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype._lex): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: * inspector/front-end/textEditor.css: 2010-01-31 Benjamin Poulain Reviewed by Eric Seidel. [Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms https://bugs.webkit.org/show_bug.cgi?id=34168 Enable FAST_MOBILE_SCROLLING for Qt on Maemo 5, Linux embedded and Symbian * WebCore.pro: 2010-01-31 Yury Semikhatsky Reviewed by Pavel Feldman. Make ScriptState destructor protected since all non-empty ScriptStates are managed by GC. Remove obsolete constructor. https://bugs.webkit.org/show_bug.cgi?id=34266 * bindings/v8/ScriptState.cpp: * bindings/v8/ScriptState.h: 2010-01-30 Simon Fraser Reviewed by Dan Bernstein. Use CGGradient on Leopard and later, since it's faster than CGShading https://bugs.webkit.org/show_bug.cgi?id=34384 Use CGGradient on Leopard and later, rather than CGShading, for performance. * platform/graphics/Gradient.h: * platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary): Utility method to sort stops. Did not call this from getColor() to avoid overhead of a function call. * platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformDestroy): Use CGGradientRelease() post-Tiger. (WebCore::Gradient::platformGradient): Create and return a CGGradientRef post-Tiger. (WebCore::Gradient::fill): Call new paint() method. (WebCore::Gradient::paint): New convenence method that avoids testing isRadial() in a bunch of other places. * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): Call the gradient's paint() method. (WebCore::GraphicsContext::strokePath): Ditto (WebCore::GraphicsContext::fillRect): Ditto (WebCore::GraphicsContext::strokeRect): Ditto 2010-01-30 Simon Fraser Reviewed by Adele Peterson. Do color animations on premultiplied colors https://bugs.webkit.org/show_bug.cgi?id=34383 Convert colors to premultiplied alpha before interpolating them, then convert the result back to non-premultiplied. This gives better results when animating from transparent colors. Test: transitions/color-transition-premultiplied.html * page/animation/AnimationBase.cpp: (WebCore::blendFunc): 2010-01-30 Gustavo Noronha Silva Build fixes needed for make distcheck. * GNUmakefile.am: 2010-01-29 Mark Rowe Stop copying an IDL file in to the framework wrapper. * WebCore.xcodeproj/project.pbxproj: 2010-01-29 Mark Rowe Sort Xcode projects. * WebCore.xcodeproj/project.pbxproj: == Rolled over to ChangeLog-2010-01-29 ==