2017-06-25 Michael Catanzaro Unreviewed, rolling out r215190. Broke product select element on GNOME Bugzilla Reverted changeset: "[GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()" https://bugs.webkit.org/show_bug.cgi?id=170553 http://trac.webkit.org/changeset/215190 2017-06-13 Carlos Garcia Campos [GTK] Blob download doesn't work https://bugs.webkit.org/show_bug.cgi?id=172442 Reviewed by Carlos Alberto Lopez Perez. Add a unit test to check blob downloads. * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: (testBlobDownload): (beforeAll): 2017-06-12 Carlos Garcia Campos [GTK] Stop dismissing menus attached to the web view for every injected event https://bugs.webkit.org/show_bug.cgi?id=172708 Reviewed by Alex Christensen. It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send events while the menu is open. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus(). 2017-04-10 Adrian Perez de Castro [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup() https://bugs.webkit.org/show_bug.cgi?id=170553 Reviewed by Michael Catanzaro. Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend to properly position popup menus, and also avoids using functions which were deprecated starting at that GTK+ release. * MiniBrowser/gtk/BrowserSearchBar.c: (searchEntryMenuIconPressedCallback): Update MiniBrowser to use gtk_menu_popup_at_pointer(). 2017-05-27 Zalan Bujtas enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer. https://bugs.webkit.org/show_bug.cgi?id=172676 Reviewed by Simon Fraser. * TestWebKitAPI/Tests/WebCore/FloatRect.cpp: (TestWebKitAPI::TEST): 2017-05-20 Ting-Wei Lan [GTK] gtkdoc-fixxref needs --module argument to work https://bugs.webkit.org/show_bug.cgi?id=172415 Reviewed by Michael Catanzaro. * gtk/gtkdoc.py: (GTKDoc._run_gtkdoc_fixxref): 2017-05-18 Daniel Bates REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent window CSP when object-src 'none' is set https://bugs.webkit.org/show_bug.cgi?id=172038 Reviewed by Andy Estes. Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl. When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone(). * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): 2017-05-21 Michael Catanzaro [GTK] Remove Firefox user agent quirk for Google domains https://bugs.webkit.org/show_bug.cgi?id=171941 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted. 2017-05-10 Michael Catanzaro Remove user agent quirk for Slack https://bugs.webkit.org/show_bug.cgi?id=171869 Reviewed by Carlos Garcia Campos. Remove the corresponding test. * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): 2017-05-08 Carlos Garcia Campos Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404. Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send characters to the input. Also fix typo in the function name. * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewJavaScriptDialogs): 2017-05-04 Mark Lam DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock. https://bugs.webkit.org/show_bug.cgi?id=171716 Reviewed by Saam Barati. setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which does JS conversion and therefore, potentially JS allocations) and accessing methods of internal JS data structures (which may do JS invocation, etc). * DumpRenderTree/TestRunner.cpp: (setAudioResultCallback): 2017-05-05 Carlos Garcia Campos [GTK] TestController timeout source callback should return G_SOURCE_REMOVE https://bugs.webkit.org/show_bug.cgi?id=171724 Reviewed by Michael Catanzaro. It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped. * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::timeoutSource): 2017-05-04 Konstantin Tokarev Fix compilation with ICU 59.1 https://bugs.webkit.org/show_bug.cgi?id=171612 Reviewed by Mark Lam. ICU 59.1 has broken source compatibility. Now it defines UChar as char16_t, which does not allow automatic type conversion from unsigned short in C++ code. * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback): 2017-05-07 Michael Catanzaro [GTK] Cannot sign in with new Google sign-in page https://bugs.webkit.org/show_bug.cgi?id=171770 Unreviewed. This just adds a test. * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): 2017-05-03 Michael Catanzaro YouTube user agent quirk breaks new YouTube https://bugs.webkit.org/show_bug.cgi?id=171603 Reviewed by Carlos Garcia Campos. Remove the YouTube quirk test. * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): 2017-04-25 Alex Christensen REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set https://bugs.webkit.org/show_bug.cgi?id=171297 Reviewed by Geoffrey Garen. * TestWebKitAPI/PlatformWebView.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added. (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::mouseDidMoveOverElement): (TestWebKitAPI::setClients): (TestWebKitAPI::TEST): * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::simulateRightClick): (TestWebKitAPI::PlatformWebView::simulateMouseMove): 2017-04-25 Brent Fulgham Limit allowed size of document.title to avoid locking WebKit clients https://bugs.webkit.org/show_bug.cgi?id=165113 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files. * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added. * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added. * TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added. 2017-04-07 Myles C. Maxfield REGRESSION(r211382): Complex text with justification erroneously overflows containers https://bugs.webkit.org/show_bug.cgi?id=170399 Reviewed by Simon Fraser. Check for the invariant that the sum of the advances is equal to m_totalWidth. * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: (TestWebKitAPI::TEST_F): 2017-04-07 Brent Fulgham WebKit should percent encode single quotes in query strings https://bugs.webkit.org/show_bug.cgi?id=170561 Reviewed by Alex Christensen. Add a test case for single-quote in the URL query string. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: 2017-03-25 Adrian Perez de Castro [GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperation() in TestPrinting.cpp https://bugs.webkit.org/show_bug.cgi?id=170059 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Use "void" as return type in the declaration, the only use of the method in this same file ignores the returned value anyway. 2017-03-24 Carlos Garcia Campos Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r214277. Since r214277 beforeunload events are not fired unless there's some user interaction, so we need to simulate it in our unit tests to work. * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewJavaScriptDialogs): 2017-03-15 Tim Horton Null deref under callAfterNextPresentationUpdate https://bugs.webkit.org/show_bug.cgi?id=169710 Reviewed by Simon Fraser. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm: Added. (TEST): 2017-03-13 Carlos Garcia Campos MiniBrowser: a tab closed from javascript always closes the window https://bugs.webkit.org/show_bug.cgi?id=169415 Reviewed by Michael Catanzaro. When I implemented tabs support in MiniBrowser I forgot about web view close. We connect to the signal (only for the active tab) and close the window. That worked when we didn't have tabs, but now we should close the tab, or the window if it's the last tab. * MiniBrowser/gtk/BrowserWindow.c: (webViewClose): Destroy the window if therte's only one tab, otherwise search for the tab corresponding to the web view and destroy it. (browserWindowSwitchTab): Re-connect to close signal, we want to handle close on all tabs. 2017-03-07 Alex Christensen [URLParser] Fix file URLs that are just file:// and a Windows drive letter https://bugs.webkit.org/show_bug.cgi?id=169242 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2017-03-06 Carlos Alberto Lopez Perez [GTK] Mark WTF_Lock.ContendedLongSection and WTF_WordLock.ContendedLongSection as slow. Unreviewed test gardening. The ContendedShortSection version of this tests were already marked as slow. And the ContendedLongSection version takes more or less the same time to run. They cause time outs on the bot sometimes. * Scripts/run-gtk-tests: (TestRunner): 2017-03-06 Alex Christensen Fix URLs relative to file URLs with paths beginning with Windows drive letters https://bugs.webkit.org/show_bug.cgi?id=169178 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2017-03-03 Alex Christensen [URLParser] Fix file: as a relative file URL https://bugs.webkit.org/show_bug.cgi?id=169122 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2017-03-02 Tomas Popela [WK2] Keyboard menu key should show context menu https://bugs.webkit.org/show_bug.cgi?id=72099 Show the context menu when the GtkWidget::popup-menu signal is emitted. This signal is triggered by pressing a key (usually the Menu key or the Shift + F10 shortcut) or it could be emitted on WebKitWebView. Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (testContextMenuDefaultMenu): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::emitPopupMenuSignal): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2017-02-22 Carlos Garcia Campos Better handle Thread and RunLoop initialization https://bugs.webkit.org/show_bug.cgi?id=167828 Reviewed by Yusuke Suzuki. Remove unnecessary calls to WTF::initializeMainThread(). * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: (TestWebKitAPI::ComplexTextControllerTest::SetUp): * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::ContentExtensionTest::SetUp): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2017-02-22 Carlos Garcia Campos [GTK] Do not use g_return_if_fail in EventSenderProxy::continuousMouseScrollBy https://bugs.webkit.org/show_bug.cgi?id=168721 Reviewed by Michael Catanzaro. Use WTFLogAlways instead. It's still shown in stderr, but it won't crash if we ever run tests with fatal criticals. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR::EventSenderProxy::continuousMouseScrollBy): 2017-02-20 Filip Pizlo The collector thread should only start when the mutator doesn't have heap access https://bugs.webkit.org/show_bug.cgi?id=167737 Reviewed by Keith Miller. Make more tests collect continuously. * Scripts/run-jsc-stress-tests: 2017-02-20 Florian Bruhin Handle EINTR during webkitpy server process select() https://bugs.webkit.org/show_bug.cgi?id=168361 Reviewed by Michael Catanzaro. Otherwise, on my machine, resizing the terminal run-webkit-tests is running in makes it die. * Scripts/webkitpy/port/server_process.py: (ServerProcess._wait_for_data_and_update_buffers_using_select): 2017-02-20 Carlos Garcia Campos Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/default-menu. It can happen that the window onload event is dispatched after the load finished is received in the UI process. Move the script to select the text to the body instead of using a window onload handler. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (testContextMenuDefaultMenu): 2017-02-20 Manuel Rego Casasnovas [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT https://bugs.webkit.org/show_bug.cgi?id=167693 Reviewed by Sergio Villar Senin. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: (TestWebKitAPI::computeNumberOfTracks): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: (TestWebKitAPI::TEST): 2017-02-19 Commit Queue Unreviewed, rolling out r212466. https://bugs.webkit.org/show_bug.cgi?id=168577 causes crashes on AArch64 on linux, maybe it's causing crashes on iOS too (Requested by pizlo on #webkit). Reverted changeset: "The collector thread should only start when the mutator doesn't have heap access" https://bugs.webkit.org/show_bug.cgi?id=167737 http://trac.webkit.org/changeset/212466 2017-02-17 Aakash Jain Fix failure from r212579. Unreviewed build-fix. * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now. 2017-02-17 Srinivasan Vijayaraghavan EWS should run JavaScriptCore tests https://bugs.webkit.org/show_bug.cgi?id=162458 Reviewed by Alexey Proskuryakov. * QueueStatusServer/config/queues.py: Add jsc-ews queue. * QueueStatusServer/model/queuestatus.py: (QueueStatus.did_skip): Returns whether patch was skipped, based on status. * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc. * Scripts/webkitpy/common/checkout/scm/scm_mock.py: (MockSCM.__init__): Add _mockChangedFiles variable. (MockSCM.changed_files): Change to use _mockChangedFiles variables. * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS. * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port. (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command. (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit). (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests. (MacPort.run_webkit_tests_command): Check for JSC. * Scripts/webkitpy/common/config/ports_mock.py: (MockPort.run_javascriptcore_tests_command): Add build_style argument. * Scripts/webkitpy/common/config/ports_unittest.py: (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command. * Scripts/webkitpy/common/net/abstracttestresults.py: Added. (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults. (AbstractTestResults.test_results): Stub. (AbstractTestResults.failing_tests): Stub. (AbstractTestResults.did_exceed_test_failure_limit): Stub. * Scripts/webkitpy/common/net/jsctestresults.py: Added. (JSCTestResults): Added. (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects. (JSCTestResults.results_from_string): Use json library to parse results. (JSCTestResults.__init__): Initialize members. (JSCTestResults.equals): This enables unit testing. (JSCTestResults.is_subset): Checks if one set of failures is a subset of another. (JSCTestResults.all_passed): Getter. (JSCTestResults.failing_tests): Getter. (JSCTestResults.did_exceed_test_failure_limit): Getter. * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added. (JSCTestResultsTest): Class to test JSCTestResults. (JSCTestResultsTest.test_results_from_string): Tests parsing. (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method. (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method. (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method. * Scripts/webkitpy/port/base.py: (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file. * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: (EarlyWarningSystemTask.run): Add check_patch_relevance step. * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added. (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands. (MockPatchAnalysisTask.__init__): Sets attributes. (MockPatchAnalysisTask._test): Override to not run command. (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command. (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic. (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic. (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results. (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc. (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader. (JSCEarlyWarningSystemTest): Class to test retry logic in below situations. (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code. (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True. (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree. (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree. (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness. (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree. (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures. (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree. (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable. (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run. (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable. (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures. (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures. (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests. (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake. * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added. (JSCTestResultsReader): Reads results file. (JSCTestResultsReader.__init__): Sets attributes. (JSCTestResultsReader._read_file_contents): Reads file. (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object. * Scripts/webkitpy/tool/bot/patchanalysistask.py: (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes. (PatchAnalysisTask._check_patch_relevance): Added. (PatchAnalysisTask._build): Check for JSC. (PatchAnalysisTask._build_without_patch): Check for JSC. (PatchAnalysisTask._test): Check for JSC. (PatchAnalysisTask._build_and_test_without_patch): Check for JSC. (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS. (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS. (PatchAnalysisTask._test_patch): Add retry logic for JSC. * Scripts/webkitpy/tool/commands/download.py: (CheckPatchRelevance): Add check-patch-relevance command. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking. (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS. (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable. (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader. (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader. (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC). (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: (TestEWS): Sample layout test EWS class used for unit testing. (TestJSCEWS): Sample JSC EWS class used for unit testing. (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group. (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message. (AbstractEarlyWarningSystemTest): Add _group variable. (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group. (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs(). (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive. (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added. (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result. (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added. (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask). * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import. * Scripts/webkitpy/tool/steps/build.py: (Build.options): Check for JSC. (Build.build): Check for JSC. (Build.run): Check for JSC. * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added. (CheckPatchRelevance): Added. (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching. (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders. * Scripts/webkitpy/tool/steps/options.py: (Options): Add --group command line option. * Scripts/webkitpy/tool/steps/runtests.py: (RunTests.options): Add group. (RunTests.run): Check for JSC. (RunTests._run_webkit_tests): Check for JSC. (RunTests): Add _group attribute. (RunTests._run_javascriptcore_tests): New. * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests. 2017-02-17 Aakash Jain Fix tools that were broken by Efl removal https://bugs.webkit.org/show_bug.cgi?id=168496 Reviewed by Alexey Proskuryakov. * QueueStatusServer/config/queues.py: * Scripts/webkitpy/common/config/ews.json: * TestResultServer/static-dashboards/builders.jsonp: * TestResultServer/static-dashboards/flakiness_dashboard.js: * TestResultServer/static-dashboards/loader_unittests.js: 2017-02-16 Lucas Forschler https://bugs.webkit.org/show_bug.cgi?id=168442 Move the SVN checkout from http -> https. Update unit tests. Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CheckOutSource.__init__): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (SVNMirrorTest.get_SVNMirrorFromConfig): * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: 2017-02-16 Commit Queue Unreviewed, rolling out r212514. https://bugs.webkit.org/show_bug.cgi?id=168489 broke test runner (Requested by alexchristensen on #webkit). Reverted changeset: "Remove EFL-specific files in Tools." http://trac.webkit.org/changeset/212514 2017-02-16 Alex Christensen Remove EFL-specific files in Tools. Rubber-stamped by Anders Carlsson. * ImageDiff/efl: Removed. * ImageDiff/efl/ImageDiff.cpp: Removed. * MiniBrowser/efl: Removed. * MiniBrowser/efl/CMakeLists.txt: Removed. * MiniBrowser/efl/main.c: Removed. * Scripts/run-efl-tests: Removed. * Scripts/update-webkitefl-libs: Removed. * Scripts/webkitpy/port/efl.py: Removed. * Scripts/webkitpy/port/efl_unittest.py: Removed. * TestWebKitAPI/Tests/WebKit2/efl: Removed. * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed. * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed. * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed. * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed. * TestWebKitAPI/efl: Removed. * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed. * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed. * TestWebKitAPI/efl/PlatformWebView.cpp: Removed. * TestWebKitAPI/efl/main.cpp: Removed. * WebKitTestRunner/InjectedBundle/efl: Removed. * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed. * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed. * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed. * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed. * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed. * WebKitTestRunner/efl: Removed. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed. * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed. * WebKitTestRunner/efl/main.cpp: Removed. * efl: Removed. * efl/install-dependencies: Removed. * efl/jhbuild-optional.modules: Removed. * efl/jhbuild.modules: Removed. * efl/jhbuildrc: Removed. * efl/patches: Removed. * efl/patches/evas-fix-build-with-giflib5.patch: Removed. * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed. * efl/patches/gst-libav.patch: Removed. * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed. * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed. * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed. * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed. 2017-02-16 Myles C. Maxfield font-weight in @font-face can cause a font to be downloaded even when it's not used https://bugs.webkit.org/show_bug.cgi?id=168114 Reviewed by Darin Adler. LastResort needs to be usable in tests. * DumpRenderTree/mac/DumpRenderTree.mm: (allowedFontFamilySet): * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: (WTR::allowedFontFamilySet): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::allowedFontFamilySet): 2017-02-16 Alex Christensen Remove old URL parser https://bugs.webkit.org/show_bug.cgi?id=168483 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkURL): (TestWebKitAPI::checkRelativeURL): (TestWebKitAPI::checkURLDifferences): (TestWebKitAPI::checkRelativeURLDifferences): 2017-02-16 Wenson Hsieh [WK2] Add additional test infrastructure and unit tests for data interaction https://bugs.webkit.org/show_bug.cgi?id=168439 Reviewed by Tim Horton. Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to support data interaction from See per-method descriptions below for more details. * Configurations/TestWebKitAPI.xcconfig: Add MobileCoreServices to the list of additional frameworks to link against on iOS. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists. * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: (-[TestWKWebView editorContainsImageElement]): (-[TestWKWebView editorValue]): New helper methods for querying information from the "editor" element in a test page. (TestWebKitAPI::TEST): (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted. Moves logic for capturing events during a simulated data interaction run from the test file to DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames]. * TestWebKitAPI/cocoa/TestWKWebView.h: * TestWebKitAPI/cocoa/TestWKWebView.mm: (-[TestMessageHandler removeMessage:]): (-[TestWKWebView clearMessageHandlers:]): Add the ability to clear message handlers from the TestWKWebView. * TestWebKitAPI/ios/DataInteractionSimulator.h: * TestWebKitAPI/ios/DataInteractionSimulator.mm: (dataInteractionEventNames): (-[DataInteractionSimulator initWithWebView:]): (-[DataInteractionSimulator _resetSimulatedState]): Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when simulating data interaction. (-[DataInteractionSimulator observedEventNames]): Returns a list of the names of events relevant to data interaction that were observed over the course of the most recent run. (-[DataInteractionSimulator runFrom:to:]): Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness to run the same data interaction for multiple simulated gestures. (-[DataInteractionSimulator _advanceProgress]): (-[DataInteractionSimulator _finishDataInteraction]): (-[DataInteractionSimulator externalItemProvider]): (-[DataInteractionSimulator setExternalItemProvider:]): Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition phase of a test run. (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]): (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]): (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]): While a request to start data interaction is in flight, put the remainder of the test on hold until the web process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition wherein the the web process might take longer than usual to process the request to start data interaction, and in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from the web process is received, which then causes no simulated delegate methods to be fired. (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted. (-[DataInteractionSimulator run]): Deleted. 2017-02-16 Wenson Hsieh Remove unused test pages in TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=168462 Reviewed by Anders Carlsson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed. * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed. * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed. * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed. * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed. 2017-02-16 Alex Christensen Special URLs without a host are invalid https://bugs.webkit.org/show_bug.cgi?id=168461 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2017-02-10 Filip Pizlo The collector thread should only start when the mutator doesn't have heap access https://bugs.webkit.org/show_bug.cgi?id=167737 Reviewed by Keith Miller. Make more tests collect continuously. * Scripts/run-jsc-stress-tests: 2017-02-16 Tim Horton WKWebView inside a UICollectionView flashes when items are inserted above it https://bugs.webkit.org/show_bug.cgi?id=168376 Reviewed by Simon Fraser. * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView _setStableStateOverride:]): Update the one external caller of this internal method... * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::doAfterVisibleContentRectUpdate): * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::doAfterVisibleContentRectUpdate): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::doAfterVisibleContentRectUpdate): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::doAfterVisibleContentRectUpdate): * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::doAfterVisibleContentRectUpdate): Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called back after we dispatch a visible content rect update from the UI process to the Web Content process, so any messages sent from the block will arrive after the visible content rect update. 2017-02-16 Carlos Alberto Lopez Perez [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS. https://bugs.webkit.org/show_bug.cgi?id=168321 This bots should be added to the trunk build scheduler. Unreviewed fix after r212429. * BuildSlaveSupport/build.webkit.org-config/config.json: 2017-02-16 Carlos Alberto Lopez Perez [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS https://bugs.webkit.org/show_bug.cgi?id=168321 Reviewed by Michael Catanzaro. The additionalArgument --default-cmake-features is used both to skip the JHBuild (InstallGtkDependencies) build step and to build with the default features from the CMake config. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (Factory.__init__): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: 2017-02-15 Lucas Forschler https://bugs.webkit.org/show_bug.cgi?id=168386 Remove EFL from build.webkit.org Reviewed by Alex Christensen * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (DeleteStaleBuildFiles.start): (appendCustomBuildFlags): (RunWebKitTests.start): (RunBuiltinsTests): (Factory.__init__): (TestFactory.__init__): (loadBuilderConfig): (InstallEflDependencies): Deleted. (RunEflAPITests): Deleted. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: (BubbleQueueServer): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: (Analyzer.prototype._triggeringQueue): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.linux-efl img.logo): Deleted. * BuildSlaveSupport/build.webkit.org-config/templates/root.html: * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: (_should_file_trigger_build): 2017-02-15 Alex Christensen Unreviewed, rolling out r212169. Broke iOS WebInspector Reverted changeset: "WebInspector: refactor RemoteInspector to move cocoa specific code to their own files" https://bugs.webkit.org/show_bug.cgi?id=166681 http://trac.webkit.org/changeset/212169 2017-02-15 Jonathan Bedard webkitpy: Fix DarwinPort._get_crash_log() https://bugs.webkit.org/show_bug.cgi?id=168372 Reviewed by Daniel Bates. Callers of _get_crash_log expect a pair to be returned and do not check it's return value. DarwinPort should return the expected return value for _get_crash_log. * Scripts/webkitpy/port/darwin.py: (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log. 2017-02-15 Chris Dumez [iOS] Form Validation Bubble should be sensitive to Dynamic Type https://bugs.webkit.org/show_bug.cgi?id=168291 Reviewed by Tim Horton. Drop overridePreference() implementation in iOS's UIScriptController as it was only used for the minimum font size setting and this setting is not exposed on iOS. * DumpRenderTree/ios/UIScriptControllerIOS.mm: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::overridePreference): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: 2017-02-15 Jonathan Bedard webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log https://bugs.webkit.org/show_bug.cgi?id=168329 Reviewed by Daniel Bates. When testing on device, app_identifier_from_bundle is repeatedly called but the return value will never change given the same input arguments. Memoize function for efficiency. * Scripts/webkitpy/port/darwin.py: Add memoized import. (DarwinPort): (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy. 2017-02-15 Jonathan Bedard webkitpy: Remove unused import from darwin.py https://bugs.webkit.org/show_bug.cgi?id=168371 Reviewed by Alex Christensen. * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module. 2017-02-15 Carlos Garcia Campos [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials https://bugs.webkit.org/show_bug.cgi?id=168364 Reviewed by Michael Catanzaro. This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have patches for them, let's patch out jhbuild until we have a new libsoup version to depend on. Fixes: http/tests/security/credentials-from-different-domains.html http/tests/xmlhttprequest/cross-origin-no-authorization.html * gtk/jhbuild.modules: * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added. * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added. 2017-02-14 Carlos Garcia Campos [GTK] Update cookie manager API to properly work with ephemeral sessions https://bugs.webkit.org/show_bug.cgi?id=168230 Reviewed by Michael Catanzaro. Update unit tests and add new cases for the new API. * MiniBrowser/gtk/main.c: (gotWebsiteDataCallback): * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: (testCookieManagerEphemeral): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextEphemeral): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewEphemeral): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: (serverCallback): (testWebsiteDataEphemeral): (testWebsiteDataCookies): (beforeAll): 2017-02-14 Wenson Hsieh [WK2] Support data interaction on links https://bugs.webkit.org/show_bug.cgi?id=168331 Reviewed by Tim Horton. Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an editable area results in the link URL being inserted. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added. * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: (TestWebKitAPI::TEST): 2017-02-14 Jason Rinn Add a test for new WebKit Cocoa API, _getContentsAsString. https://bugs.webkit.org/show_bug.cgi?id=168147 Reviewed by Tim Horton. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added. (TEST): 2017-02-14 Matt Rajca Website policies: iframes should respect the autoplay policy of the top-level document https://bugs.webkit.org/show_bug.cgi?id=168333 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added. * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): (TEST): 2017-02-14 Chris Dumez HTML Form Validation bubble should take minimum font size setting into consideration https://bugs.webkit.org/show_bug.cgi?id=168271 Reviewed by Simon Fraser. Extend UIScriptController's contentsOfUserInterfaceItem() to also return the font size of the validation bubble. Add an overridePreference() method to UIScriptController. This is currently used to override the value of the minimumFontSize setting. testRunner's overridePreference() is not usable on WK2 because it does not update the value of the preference on the UIProcess side. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::overridePreference): * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::overridePreference): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::overridePreference): * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::contentsOfUserInterfaceItem): (WTR::UIScriptController::overridePreference): 2017-02-14 Florian Bruhin Use a set instead of a list for tests when parsing expectations https://bugs.webkit.org/show_bug.cgi?id=168304 In _collect_matching_tests, a lot of membership tests are done on a giant list of strings. By making it a set instead, we can make those much faster, and there's no reason for it to be a list. With ~45k tests and some 1000 expectations, this reduces the parse time from 34s to 3s on my machine. Reviewed by Ryosuke Niwa. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser.__init__): (TestExpectationParser._collect_matching_tests): 2017-02-14 Jonathan Bedard Unreviewed build-fix after r212297. * Scripts/webkitpy/port/simulator_process.py: (SimulatorProcess.stop): Should return value of the ServerProcess's stop. 2017-02-14 Carlos Alberto Lopez Perez [CMake] build-webkit should allow building with the default cmake configuration https://bugs.webkit.org/show_bug.cgi?id=168323 Reviewed by Michael Catanzaro. Add a --default-cmake-features switch that makes the script pass no value for any of the features defined by build-webkit, that way the default values from the port cmake config will be used. * Scripts/build-webkit: (cMakeArgsFromFeatures): 2017-02-14 Jonathan Bedard Unreviewed build-fix after r212297. * Scripts/webkitpy/port/simulator_process.py: (SimulatorProcess.stop): Handle case where there is no process to kill. 2017-02-14 Carlos Alberto Lopez Perez [CMake] build-webkit should print the cmake command executed https://bugs.webkit.org/show_bug.cgi?id=168318 Reviewed by Michael Catanzaro. Run the cmake commands to configure or start the build through a wrapper that prints the command before executing it. * Scripts/webkitdirs.pm: (systemVerbose): (generateBuildSystemFromCMakeProject): (buildCMakeGeneratedProject): (cleanCMakeGeneratedProject): 2017-02-14 Jonathan Bedard run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out https://bugs.webkit.org/show_bug.cgi?id=168150 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/simulator_process.py: (SimulatorProcess.stop): Close app before calling ServerProcess's stop. (SimulatorProcess._kill): Move closing of app into stop(). * Scripts/webkitpy/xcode/simulator.py: (Device.launch_app): (Device.terminate_app): Deleted. 2017-02-14 Carlos Garcia Campos REGRESSION(r212192): [GTK] Broke downloads API tests https://bugs.webkit.org/show_bug.cgi?id=168193 Unreviewed. Update test expectations after r212192. The suggested filename now includes a file extensions if the MIME type is known. * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: (testDownloadRemoteFile): (testDownloadMIMEType): 2017-02-14 Commit Queue Unreviewed, rolling out r212237. https://bugs.webkit.org/show_bug.cgi?id=168298 This was a wrong fix (Requested by rniwa on #webkit). Reverted changeset: "Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff" https://bugs.webkit.org/show_bug.cgi?id=168221 http://trac.webkit.org/changeset/212237 2017-02-13 Alex Christensen URLs with an invalid IPv4 address should be invalid https://bugs.webkit.org/show_bug.cgi?id=168260 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): Update tests to reflect new correct behavior. 2017-02-13 Don Olmstead [WinCairo] Add Build Slave https://bugs.webkit.org/show_bug.cgi?id=168263 Reviewed by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/config.json: 2017-02-13 Wenson Hsieh Fix the build after r212254 * TestWebKitAPI/ios/DataInteractionSimulator.mm: (-[DataInteractionSimulator _currentLocation]): 2017-02-13 Wenson Hsieh [WK2] Add test infrastructure and unit tests for data interaction https://bugs.webkit.org/show_bug.cgi?id=168159 Reviewed by Tim Horton. Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the gesture has already been recognized) at regular intervals over the course of the test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added. New test pages for data interaction. * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added. (TestWebKitAPI::runTestsExpectingToObserveEvents): (TestWebKitAPI::TEST): * TestWebKitAPI/cocoa/TestWKWebView.mm: (-[TestWKWebView stringByEvaluatingJavaScript:]): * TestWebKitAPI/ios/DataInteractionSimulator.h: Added. * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added. (-[MockLongPressGestureRecognizer initWithWindow:]): (-[MockLongPressGestureRecognizer locationInView:]): (-[MockLongPressGestureRecognizer state]): (-[MockLongPressGestureRecognizer numberOfTouches]): (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): (-[DataInteractionSimulator dealloc]): (-[DataInteractionSimulator run]): Performs a data interaction gesture from the start location to the end location with linear interpolation. For now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete in a little under 1 second, though this can be easily changed to be configurable in the future if needed. (-[DataInteractionSimulator _advanceProgress]): Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is completed, and calls _finishDataInteraction when progress is at 1. (-[DataInteractionSimulator _finishDataInteraction]): (-[DataInteractionSimulator _currentLocation]): (-[DataInteractionSimulator _scheduleAdvanceProgress]): (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]): (-[DataInteractionSimulator dataInteractionGestureRecognizer]): (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]): 2017-02-13 Alex Christensen Percent should be allowed in non-special URL hosts https://bugs.webkit.org/show_bug.cgi?id=168255 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2017-02-13 Fujii Hironori Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff https://bugs.webkit.org/show_bug.cgi?id=168221 Reviewed by Ryosuke Niwa. There is a logic error in comparing mismatch ref test images. In mismatch ref tests, it should be failed if two images has no diff. But, if the hashes are different, nwtr unexpectedly pass the mismatch ref test. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner._compare_output_with_reference): Fail the mismatch ref test if hashes of two images are equal. Invoke ImageDiff if the hashes don't match. 2017-02-13 Myles C. Maxfield Update custom line breaking iterators to the latest version of Unicode https://bugs.webkit.org/show_bug.cgi?id=168182 Reviewed by Zalan Bujtas. Treat the system's ICU as the source of truth to compare breaking positions against. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added. (generateJavaScriptForTest): (breakingLocationsFromICU): (testAFewStrings): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg. * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added. 2017-02-12 Michael Catanzaro [GTK] Several failing WebViewEditor API tests https://bugs.webkit.org/show_bug.cgi?id=161608 Reviewed by Carlos Garcia Campos. Selection.collapse() requires arguments; passing no arguments means the JS that selects the text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests except the first one, which is still broken due to unrelated bug #151654. * Scripts/run-gtk-tests: (TestRunner): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: 2017-02-12 Michael Catanzaro Unreviewed, skip flaky WebKitPrintOperation/custom-widget test * Scripts/run-gtk-tests: (TestRunner): 2017-02-12 Michael Catanzaro Unreviewed, skip flaky form-controls-associated-signal test * Scripts/run-gtk-tests: (TestRunner): 2017-02-12 Carlos Garcia Campos [GTK] Handle caps lock indicator in event modifiers https://bugs.webkit.org/show_bug.cgi?id=168186 Reviewed by Michael Catanzaro. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey. 2017-02-11 Simon Fraser MiniBrowser WK1 fails to update URL for within-page navigations https://bugs.webkit.org/show_bug.cgi?id=168173 Reviewed by Tim Horton. Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named anchors updates the URL field. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]): 2017-02-10 John Wilander Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction https://bugs.webkit.org/show_bug.cgi?id=167474 This patch adds test infrastructure to allow testing of the various rules in place for data records removal. Reviewed by Andy Estes. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): Callback mechanism to tell pages that a website data store scan has happened. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setStatisticsPrevalentResource): (WTR::TestRunner::isStatisticsPrevalentResource): (WTR::TestRunner::setStatisticsHasHadUserInteraction): (WTR::TestRunner::isStatisticsHasHadUserInteraction): (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction): (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback): (WTR::TestRunner::statisticsDidModifyDataRecordsCallback): (WTR::TestRunner::statisticsFireDataModificationHandler): (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned): (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval): (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval): (WTR::TestRunner::statisticsResetToConsistentState): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::setStatisticsPrevalentResource): (WTR::TestController::isStatisticsPrevalentResource): (WTR::TestController::setStatisticsHasHadUserInteraction): (WTR::TestController::isStatisticsHasHadUserInteraction): (WTR::TestController::setStatisticsTimeToLiveUserInteraction): (WTR::TestController::statisticsFireDataModificationHandler): (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned): (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval): (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval): (WTR::TestController::statisticsResetToConsistentState): * WebKitTestRunner/TestController.h: These are all configuration and test functions. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): 2017-02-10 Carlos Alberto Lopez Perez REGRESSION(r182916) run-perf-tests never timeouts https://bugs.webkit.org/show_bug.cgi?id=167626 Reviewed by Ryosuke Niwa. The --time-out-ms value (defaults to 600 seconds) of run-perf-tests was beeing ignored because the driver was created with no_timeout=True unconditionally. This adds a new parameter --no-timeout (disabled by default), that allows to use the driver with the expected timeout values. It also passes --no-timeout to DRT/WTR to ensure that timeouts are always controlled by the Python Driver. * Scripts/webkitpy/performance_tests/perftest.py: (PerfTest._create_driver): Only disable timeout if --no-timeout is passed. (PerfTest.run): Disabling timeout should be done when the Driver is created. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR (PerfTestsRunner._parse_args): Add a --no-timeout parameter. (_run_tests_set): Pass the no-timeout parameter. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout. (MainTest.test_parse_args): Test that the argument no-timeout. 2017-02-10 Daniel Bates Detach frame from document when entering page cache https://bugs.webkit.org/show_bug.cgi?id=166774 Reviewed by Chris Dumez. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2017-02-10 Tim Horton Infinite UI process hang under ensurePositionInformationIsUpToDate https://bugs.webkit.org/show_bug.cgi?id=168154 Reviewed by Simon Fraser. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added. (recursiveFindHighlightLongPressRecognizer): (TEST): Add a somewhat nasty test that does an async interaction information update, but kills the Web process before it arrives, and then does a sync interaction information update, which will wait for the oustanding async interaction information update if we still think it's coming. Before the patch, this test times out with the UI process stuck under ensurePositionInformationIsUpToDate. 2017-02-10 Simon Fraser Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections https://bugs.webkit.org/show_bug.cgi?id=168127 rdar://problem/30467120 Reviewed by Tim Horton. Reparent the web view before we try to fetch it via: [[[window contentView] subviews] objectAtIndex:0]; which would throw an exception if the test unparented it. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): (runTest): 2017-02-10 Joseph Pecoraro [Resource Timing] Enable Resource Timing by default in Tests https://bugs.webkit.org/show_bug.cgi?id=168145 Reviewed by Ryosuke Niwa. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2017-02-10 Jonathan Bedard Removing LayoutTestRelay https://bugs.webkit.org/show_bug.cgi?id=165927 Reviewed by Daniel Bates. Part 2 LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on simulators through simctl (iOS 10 and later), use this functionality instead. * BuildSlaveSupport/built-product-archive: (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built. Added a FIXME that we will need to implement similar archiving machinery once we build ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK. * BuildSlaveSupport/kill-old-processes: (main): Remove LayoutTestRelay from list of processes. * LayoutTestRelay: Removed LayoutTestRelay. * Makefile: * Scripts/build-layouttestrelay: Removed. * Scripts/build-webkit: Removed LayoutTestRelay references. 2017-02-10 Jiewen Tan [WebCrypto] Add WebCryptoAPI to watchlist https://bugs.webkit.org/show_bug.cgi?id=168138 Reviewed by Youenn Fablet. * Scripts/webkitpy/common/config/watchlist: 2017-02-10 Brady Eidson Replace all WebKit Library Version checks in WK2 with SDK version checks. https://bugs.webkit.org/show_bug.cgi?id=168124 Reviewed by Geoffrey Garen. For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting. * MiniBrowser/mac/main.m: (main): * MobileMiniBrowser/MobileMiniBrowser/main.m: (main): * TestWebKitAPI/ios/mainIOS.mm: (main): * TestWebKitAPI/mac/mainMac.mm: (main): * WebKitTestRunner/ios/mainIOS.mm: (main): * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): 2017-02-10 Alex Christensen Fix El Capitan build. * Scripts/build-webkit: Don't build libwebrtc anywhere for now. 2017-02-10 Andy Estes Move two MiniBrowserBundle settings out of the .pbxproj https://bugs.webkit.org/show_bug.cgi?id=168106 Reviewed by Tim Horton. INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in the project file. This removes the project file override. WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig. * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 2017-02-10 Alex Christensen Fix 32-and-64-bit build on El Capitan. * Scripts/build-webkit: Somebody's building with something like this: build-webkit ARCHS="i386 x86_64" We want this to also not build libwebrtc for now. 2017-02-10 Alex Christensen Fix 32-bit build on El Capitan. * Scripts/build-webkit: The bot uses ARCHS=i386 instead of --32-bit. This is a hack, but it should fix the bot until I can do a better fix in the morning. 2017-02-10 Alex Christensen Fix 32-bit build on El Capitan. * Scripts/build-webkit: Don't build i386 libwebrtc. 2017-02-09 Alex Christensen Unreviewed, rolling out r212040. Broke build. I'm not surprised Reverted changeset: "[WebRTC][Mac] Activate libwebrtc" https://bugs.webkit.org/show_bug.cgi?id=167293 http://trac.webkit.org/changeset/212040 2017-02-09 Alex Christensen Build libwebrtc on bots without using it yet https://bugs.webkit.org/show_bug.cgi?id=168062 Reviewed by Brent Fulgham. * Scripts/build-webkit: 2017-02-09 Alex Christensen Don't build libwebrtc. * Scripts/build-webkit: Not ready yet. It broke El Capitan and iOS. 2017-02-09 Alex Christensen Build libwebrtc on bots without using it yet https://bugs.webkit.org/show_bug.cgi?id=168062 Reviewed by Brent Fulgham. * Scripts/build-webkit: 2017-02-09 Alex Christensen Rename isAppleMacWebKit to isAppleCocoaWebKit https://bugs.webkit.org/show_bug.cgi?id=168075 Reviewed by Geoffrey Garen. It returns true for Mac and iOS. "isAppleMacWebKit" is confusing and wrong. * Scripts/build-api-tests: * Scripts/build-dumprendertree: * Scripts/build-jsc: (buildMyProject): * Scripts/build-layouttestrelay: * Scripts/build-webkit: * Scripts/build-webkittestrunner: * Scripts/run-api-tests: (isSupportedPlatform): (runTest): (listAllTests): (prepareEnvironmentForRunningTestTool): * Scripts/run-content-extension-tester: * Scripts/run-javascriptcore-tests: * Scripts/run-minibrowser: * Scripts/show-pretty-diff: * Scripts/webkitdirs.pm: (determineBaseProductDir): (determineArchitecture): (determinePassedArchitecture): (safariPath): (builtDylibPathForName): (checkFrameworks): (isAppleWebKit): (isAppleCocoaWebKit): (determineNmPath): (launcherName): (wrapperPrefixIfNeeded): (isCMakeBuild): (mobileSafariBundle): (debugSafari): (runSafari): (runMiniBrowser): (debugMiniBrowser): (runWebKitTestRunner): (debugWebKitTestRunner): (isAppleMacWebKit): Deleted. * Scripts/webkitperl/FeatureList.pm: 2017-02-09 Alex Christensen Revert r211991 https://bugs.webkit.org/show_bug.cgi?id=168062 * Scripts/build-webkit: Not quite ready yet. 2017-02-09 Alex Christensen Build libwebrtc on bots without using it yet https://bugs.webkit.org/show_bug.cgi?id=168062 Reviewed by Brent Fulgham. * Scripts/build-webkit: Build libwebrtc on Mac when we build ANGLE. 2017-02-09 Youenn Fablet Improve W3C importer command line options https://bugs.webkit.org/show_bug.cgi?id=167448 Reviewed by Ryosuke Niwa. Making the list of test paths to import the main arguments of the script. Allow passing the source directory to import as a -s option. Adding a warning when given test paths are skipped by default in ImportExpectations. Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests. Link conversion rules do not change when imported tests are downloaded by the script. * Scripts/webkitpy/w3c/test_importer.py: (main): (parse_args): (TestImporter.__init__): (TestImporter.do_import): (TestImporter): (TestImporter.check_imported_expectations): 2017-02-08 Chris Dumez Update web-platform-tests resources https://bugs.webkit.org/show_bug.cgi?id=168026 Reviewed by Youenn Fablet. Stop copying testharness.js from resources/ to web-platform-tests/resources. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._copy_webkit_test_files): 2017-02-08 Andy Estes Custom protocols should not continue loading after a network process crash https://bugs.webkit.org/show_bug.cgi?id=168028 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: (processGroup): (-[CloseWhileStartingProtocol startLoading]): (-[CloseWhileStartingProtocol stopLoading]): (TestWebKitAPI::runTest): (TestWebKitAPI::TEST): 2017-02-08 Dan Bernstein [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize https://bugs.webkit.org/show_bug.cgi?id=168031 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]): 2017-02-08 Chris Dumez Use smaller tiles in windows that are not active to facilitate App Napping https://bugs.webkit.org/show_bug.cgi?id=167997 Reviewed by Simon Fraser. * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::setWindowIsKey): Actually update windowIsKey state of NSWindow so the WebView properly updates its activity state. 2017-02-08 Wenson Hsieh Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData https://bugs.webkit.org/show_bug.cgi?id=167942 Reviewed by Tim Horton. Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a contenteditable area. An image element and the plain text content, respectively, should be inserted into the contenteditable in these cases. The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and performDragOperation:) directly. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added. (+[FrameLoadCompletionListener listenerWithCompletionBlock:]): (-[FrameLoadCompletionListener initWithCompletionBlock:]): (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]): (-[DragSource draggingSourceOperationMaskForLocal:]): (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]): (-[DragInfo lastMousePosition]): (-[DragInfo setLastMousePosition:]): (-[DragInfo draggingDestinationWindow]): (-[DragInfo draggingSourceOperationMask]): (-[DragInfo draggingLocation]): (-[DragInfo draggedImageLocation]): (-[DragInfo draggedImage]): (-[DragInfo draggingPasteboard]): (-[DragInfo draggingSource]): (-[DragInfo draggingSequenceNumber]): (-[DragInfo slideDraggedImageTo:]): (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]): (-[DragInfo draggingFormation]): (-[DragInfo setDraggingFormation:]): (-[DragInfo animatesToDestination]): (-[DragInfo setAnimatesToDestination:]): (-[DragInfo numberOfValidItemsForDrop]): (-[DragInfo setNumberOfValidItemsForDrop:]): (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]): (-[DragInfo springLoadingHighlight]): (-[DragInfo resetSpringLoading]): (TestWebKitAPI::getTestImage): (TestWebKitAPI::webViewAfterPerformingDragOperation): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added. 2017-02-08 Jer Noble Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView. https://bugs.webkit.org/show_bug.cgi?id=168007 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm: (didFinishLoadForFrame): (TestWebKitAPI::TEST): 2017-02-08 Commit Queue Unreviewed, rolling out r211873. https://bugs.webkit.org/show_bug.cgi?id=168001 It's in jhbuild for consistent layout tests (Requested by mcatanzaro on #webkit). Reverted changeset: "[GTK] Add icu packages to Tools/gtk/install-dependencies" https://bugs.webkit.org/show_bug.cgi?id=167993 http://trac.webkit.org/changeset/211873 2017-02-08 Adrian Perez de Castro [GTK] Add icu packages to Tools/gtk/install-dependencies https://bugs.webkit.org/show_bug.cgi?id=167993 Reviewed by Michael Catanzaro. * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel" depending in the GNU/Linux distribution) 2017-02-07 Ryan Haddad Update flakiness dashboard configuration. https://bugs.webkit.org/show_bug.cgi?id=167957 Reviewed by Alexey Proskuryakov. * TestResultServer/static-dashboards/builders.jsonp: 2017-02-07 Ryan Haddad Replace a bot that has an incorrect configuration. https://bugs.webkit.org/show_bug.cgi?id=167747 Rubber-stamped by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/config.json: 2017-02-07 Myles C. Maxfield [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController https://bugs.webkit.org/show_bug.cgi?id=167927 Reviewed by Brent Fulgham. Enable ComplexTextController API tests on the Win and GTK ports. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/PlatformWin.cmake: 2017-02-07 Jonathan Bedard File index appended to previous file in svn-create-patch with SVN 1.9 https://bugs.webkit.org/show_bug.cgi?id=167903 Reviewed by Daniel Bates. * Scripts/VCSUtils.pm: (fixSVNPatchForAdditionWithHistory): Append a trailing newline character. * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove trailing newline character from the expected result before comparing it to the actual result. 2017-02-07 Olivier Blin [webkitdirs] remove unused host_processor variable in determineArchitecture() https://bugs.webkit.org/show_bug.cgi?id=167936 Reviewed by Michael Catanzaro. * Scripts/webkitdirs.pm: (determineArchitecture): The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore, since r195083. 2017-02-07 Youenn Fablet Use a JSON file to define which WPT files/folders to import https://bugs.webkit.org/show_bug.cgi?id=167923 Reviewed by Alex Christensen. * Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader.__init__): (TestDownloader._init_paths_from_expectations): * Scripts/webkitpy/w3c/test_importer.py: (parse_args): * Scripts/webkitpy/w3c/test_importer_unittest.py: 2017-02-06 Fujii Hironori [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found https://bugs.webkit.org/show_bug.cgi?id=167916 Reviewed by Carlos Garcia Campos. URL of mesa-11.0.6.tar.xz has been moved. * gtk/jhbuild.modules: Fix the module path. 2017-02-06 Joseph Pecoraro Static Analyzer: Address some leaks in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=167897 Reviewed by Alexey Proskuryakov. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]): * MiniBrowser/mac/ExtensionManagerWindowController.m: (-[ExtensionManagerWindowController add:]): (-[ExtensionManagerWindowController remove:]): * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController togglePerWindowWebProcessesDisabled:]): Address obvious leaks caught by the static analyzer. 2017-02-06 Myles C. Maxfield Migrate ComplexTextController to use platform-independent types https://bugs.webkit.org/show_bug.cgi?id=167833 Reviewed by Brent Fulgham. Migrate tests away from platform-dependent types. * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: (TestWebKitAPI::TEST_F): 2017-02-06 Brent Fulgham Correct File Path Handling in SecurityOrigin and FileSystem https://bugs.webkit.org/show_bug.cgi?id=167894 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files, and perform same-volume checks using filesystem-compatible paths. * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from filesystem paths, and perform validation of same-volume checks. (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added. (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added. (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added. (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added. 2017-02-06 Jer Noble Playback stalls when a SourceBuffer append causes frame eviction https://bugs.webkit.org/show_bug.cgi?id=167834 Reviewed by Eric Carlson. Add new correctness tests for the Webcore::SampleMap class. Add additional subtests for the WTF::MediaTime class. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/MediaTime.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added. (WTF::operator<<): (TestWebKitAPI::TestSample::create): (TestWebKitAPI::TestSample::TestSample): (TestWebKitAPI::TEST_F): 2017-02-06 Ryan Haddad Change capitalization in platform name after r211735. Unreviewed dashboard fix. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): 2017-02-06 Alexey Proskuryakov Move the Leaks bot to Sierra https://bugs.webkit.org/show_bug.cgi?id=167886 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: (LeaksViewer._displayURLPrompt): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): 2017-02-06 Jonathan Bedard Prevent app crash on launch during simctl install workaround https://bugs.webkit.org/show_bug.cgi?id=167685 Reviewed by Daniel Bates. * Scripts/webkitpy/port/simulator_process.py: (SimulatorProcess.__init__): Pass environment to install. * Scripts/webkitpy/xcode/simulator.py: (Device.install_app): Accept environment, pass environment to launch. 2017-02-06 Alex Christensen Rebase API tests after r211638 https://bugs.webkit.org/show_bug.cgi?id=167779 * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): URLs with non-special schemes and characters like % in the host now fail to parse, more like their special counterparts and according to spec. 2017-02-06 Csaba Osztrogonác Unreviewed trivial fix after r211697. https://bugs.webkit.org/show_bug.cgi?id=167863 * Scripts/run-javascriptcore-tests: (runJSCStressTests): Renamed ES6SampleBench to ARES-6. 2017-02-04 Simon Fraser Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays https://bugs.webkit.org/show_bug.cgi?id=167850 Reviewed by Tim Horton. * DumpRenderTree/TestRunner.cpp: (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings. 2017-02-04 Andreas Kling Plug some leaks in TestController and UIScriptContext. Reviewed by Alexey Proskuryakov. Fix a couple of the leaks seen on the leaks bot. * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: (UIScriptContext::runUIScript): * WebKitTestRunner/TestController.cpp: (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): 2017-02-03 Jeremy Jones WK1 mouse events are missing movementX and movementY for pointerlock. https://bugs.webkit.org/show_bug.cgi?id=167775 rdar://problem/30343810 Reviewed by Alexey Proskuryakov. Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events. * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController mouseMoveToX:Y:]): * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseMoveTo): 2017-02-03 Simon Fraser Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic https://bugs.webkit.org/show_bug.cgi?id=167774 Reviewed by Tim Horton. Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the web process are async, so the callback fires after the web process gets the new state. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::removeViewFromWindow): (WTR::UIScriptController::addViewToWindow): * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/mac/DumpRenderTreeMac.h: * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::removeViewFromWindow): (WTR::UIScriptController::addViewToWindow): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::removeViewFromWindow): (WTR::UIScriptController::addViewToWindow): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/PlatformWebView.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::removeFromWindow): (WTR::PlatformWebView::addToWindow): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::removeViewFromWindow): (WTR::UIScriptController::addViewToWindow): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::removeFromWindow): (WTR::PlatformWebView::addToWindow): * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::removeViewFromWindow): (WTR::UIScriptController::addViewToWindow): 2017-02-03 Alexey Proskuryakov Remove check for SkipSafariExecutableEntitlementChecks https://bugs.webkit.org/show_bug.cgi?id=167762 Reviewed by Dan Bernstein. Follow-up fix: don't break internal behavior. * Scripts/webkitdirs.pm: (safariPath): (executableHasEntitlements): Deleted. (safariPathFromSafariBundle): Deleted. (installedSafariPath): Deleted. 2017-02-03 Daniel Bates [Mac][WK2] Add SPI to override the Content Security Policy of a page https://bugs.webkit.org/show_bug.cgi?id=167810 Reviewed by Anders Carlsson. Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:]. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added. (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added. 2017-02-02 Alex Christensen URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters https://bugs.webkit.org/show_bug.cgi?id=167773 Reviewed by Ryosuke Niwa. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2017-02-02 Alexey Proskuryakov Remove check for SkipSafariExecutableEntitlementChecks https://bugs.webkit.org/show_bug.cgi?id=167762 rdar://problem/22480673 Reviewed by Dan Bernstein. * Scripts/webkitdirs.pm: (safariPathFromSafariBundle): (skipSafariExecutableEntitlementChecks): Deleted. 2017-02-02 Jonathan Bedard Undefined subroutine in svn-create-patch https://bugs.webkit.org/show_bug.cgi?id=167742 Unreviewed build-fix after r211543. * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported. 2017-02-02 Xabier Rodriguez Calvar Unreviewed. Fix jhbuild dependencies build. * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Patch updated. 2017-02-02 Xabier Rodriguez Calvar [EME][GStreamer] Fixed decryptor selection https://bugs.webkit.org/show_bug.cgi?id=167588 Reviewed by Žan Doberšek. This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107 * gtk/jhbuild.modules: Added patches to gstreamer and gst-plugins-good packages. * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added. * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added. 2017-02-01 Dewei Zhu Make run-benchmark script supports 'config' key in test plan. https://bugs.webkit.org/show_bug.cgi?id=167715 Reviewed by Ryosuke Niwa. Add support for 'config' key in test paln. 'config' key is a dictionary that specifies environment configurations while test is running. Specifies orientation to be portrait in MotionMark benchmark. * Scripts/webkitpy/benchmark_runner/README.md: * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): (BenchmarkRunner._run_benchmark): * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: (BrowserDriver.prepare_env): * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: (LinuxBrowserDriver.prepare_env): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver.prepare_env): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver.prepare_env): * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: 2017-02-01 Daniel Bates REGRESSION (r210820): svn-create-patch does not emit property change only diff https://bugs.webkit.org/show_bug.cgi?id=167169 Reviewed by David Kilzer. More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff header from the output of "svn diff" on a file that was copied or moved. Following r210820 svn-create-patch emits to standard output a diff only if it has at least one chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff" of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:" line followed by a separator line) with an empty body; => no chunk range lines. However a diff of a file with only a property change also does not contain any chunk range lines. Therefore svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting a SVN diff header with an empty body by counting the number of chunk range lines in the diff we should directly test for the presence of a leading SVN diff header with an empty body and remove such lines from the diff. * Scripts/VCSUtils.pm: (fixSVNPatchForAdditionWithHistory): Added. * Scripts/svn-create-patch: (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when we have a non empty patch for an added file with history (i.e. a copied or moved file). * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added. 2017-02-01 Eric Carlson [Mac] Update CARingBuffer class https://bugs.webkit.org/show_bug.cgi?id=167656 Reviewed by Jer Noble. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added. (TestWebKitAPI::CARingBufferTest::SetUp): (TestWebKitAPI::CARingBufferTest::setup): (TestWebKitAPI::CARingBufferTest::setListDataBuffer): (TestWebKitAPI::CARingBufferTest::description): (TestWebKitAPI::CARingBufferTest::bufferList): (TestWebKitAPI::CARingBufferTest::ringBuffer): (TestWebKitAPI::CARingBufferTest::capacity): (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream): (TestWebKitAPI::CARingBufferTest::configureBufferListForStream): (TestWebKitAPI::TEST_F): (TestWebKitAPI::MixingTest::run): 2017-02-01 Alexey Proskuryakov [Mac] TestWebKitAPI includes system frameworks incorrectly https://bugs.webkit.org/show_bug.cgi?id=167703 rdar://problem/30301498 Reviewed by Ryosuke Niwa. FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system. Make TestWebKitAPI use -iframework instead, like the rest of WebKit does. Also, reduced the number of subframework search paths, looks like we only need one now. * TestWebKitAPI/Configurations/Base.xcconfig: 2017-02-01 Brent Fulgham Correct "filesHaveSameVolume" predicate https://bugs.webkit.org/show_bug.cgi?id=167696 Reviewed by David Kilzer. Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles percent-escaped path inputs. * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: (TestWebKitAPI::FileSystemTest::spaceContainingFilePath): (TestWebKitAPI::FileSystemTest::bangContainingFilePath): (TestWebKitAPI::FileSystemTest::quoteContainingFilePath): (TestWebKitAPI::TEST_F): 2017-02-01 Tomas Popela Unreviewed. Fix coding style in MiniBrowser * MiniBrowser/gtk/BrowserWindow.c: (editingCommandCallback): (insertImageCommandCallback): (insertLinkCommandCallback): 2017-02-01 Tomas Popela [GTK] Add an API to add a custom tab into the print dialog https://bugs.webkit.org/show_bug.cgi?id=151998 Reviewed by Carlos Garcia Campos. Add a new WebKitPrintOperation/custom-widget test in TestPrinting that is testing a newly added API. * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: (testPrintCustomWidget): (beforeAll): 2017-02-01 Enrique Ocaña González [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream https://bugs.webkit.org/show_bug.cgi?id=166529 Reviewed by Xabier Rodriguez-Calvar. * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: New patch version accepted in GStreamer upstream. 2017-02-01 Xabier Rodriguez Calvar [GTK] Install either libxfont1-dev or libxfont-dev as dependency https://bugs.webkit.org/show_bug.cgi?id=167498 Reviewed by Carlos Garcia Campos. Depending on the distro version you can need either libxfont1-dev or libfont-dev to build with jhbuild. * gtk/install-dependencies: 2017-01-31 Ryan Haddad Disable API test WebKit2.WKWebProcessPlugInRangeHandle https://bugs.webkit.org/show_bug.cgi?id=167594 Unreviewed test gardening. Disabling this test while we investigate the cause of a timeout on ios-simulator. * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: (TEST): 2017-01-31 Filip Pizlo Move slow-running microbenchmarks out of JSTests/microbenchmarks https://bugs.webkit.org/show_bug.cgi?id=167676 Reviewed by Saam Barati. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Add slowMicrobenchmarks.yaml. 2017-01-31 Megan Gardner Make Dump Render Tree not crash https://bugs.webkit.org/show_bug.cgi?id=167667 DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS. So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash. This does not fix any tests, it just fixes the crash. Reviewed by Simon Fraser. * DumpRenderTree/TestRunner.cpp: (TestRunner::callUIScriptCallback): 2017-01-31 Jonathan Bedard Workaround for simctl install failing to report install failure https://bugs.webkit.org/show_bug.cgi?id=167654 Reviewed by Daniel Bates. simctl install will sometimes report success even though install has failed. To workaround this bug, we attempt an app launch after install to ensure install has succeeded. * Scripts/webkitpy/xcode/simulator.py: (Device.install_app): Attempt app launch after install, retry install if launch fails. (Device.launch_app): Correct comment. 2017-01-31 Jonathan Bedard Unreviewed webkitpy fix after r211405. * Scripts/webkitpy/xcode/simulator.py: (Device.launch_app): Remove @staticmethod on _log_debug_error. 2017-01-31 Carlos Garcia Campos Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs. * gtk/manifest.txt.in: 2017-01-31 Chris Fleizach AX: enable search predication for iOS https://bugs.webkit.org/show_bug.cgi?id=167558 Reviewed by Joanmarie Diggs. * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::uiElementForSearchPredicate): * DumpRenderTree/mac/AccessibilityCommonMac.h: * DumpRenderTree/mac/AccessibilityCommonMac.mm: (searchPredicateParameterizedAttributeForSearchCriteria): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (searchPredicateParameterizedAttributeForSearchCriteria): Deleted. * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): (WTR::AccessibilityUIElement::uiElementForSearchPredicate): * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h: * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: (WTR::searchPredicateParameterizedAttributeForSearchCriteria): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 2017-01-30 Jonathan Bedard Workaround for simctl launch bug https://bugs.webkit.org/show_bug.cgi?id=167613 Reviewed by Daniel Bates. simctl launch will sometimes fail because of a race condition when many simulators are being run simultaneously. These failures will always have an exit code of 1. This change attempts to launch an app multiple times before reporting a failure to workaround this bug. * Scripts/webkitpy/xcode/simulator.py: (Device.launch_app): Execute multiple launch attempts, better logging of failures. 2017-01-30 Alexey Proskuryakov Commit queue fails to look at real name aliases for the reviewer https://bugs.webkit.org/show_bug.cgi?id=167422 Reviewed by Joseph Pecoraro. * Scripts/webkitpy/common/checkout/changelog_unittest.py: (test_has_valid_reviewer): Added tests. * Scripts/webkitpy/common/config/committers.py: (CommitterList._name_to_contributor_map): Made _name_to_contributor_map include alias names. * Scripts/webkitpy/common/config/committers_unittest.py: (CommittersTest.test_contributors_by_fuzzy_match): Removed subtests that are now obsolete, as these matches are strict. It is not obvious if distance based fuzzy matching for names is useful at all, but we can look into that some other time. 2017-01-30 Aakash Jain QueueStatusServer should have an explicit timeout for _fetch_url https://bugs.webkit.org/show_bug.cgi?id=167467 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/net/statusserver.py: (StatusServer._fetch_url): Add an explicit timeout of 300s. 2017-01-30 Kocsen Chung Add support for Trac instances that host multiple projects. https://bugs.webkit.org/show_bug.cgi?id=167524 Reviewed by Alexey Proskuryakov. When multiple projects are hosted on a single Trac instance, the current behavior will retrieve changesets from all tracked projects. This patch teaches Trac.js to get project-specific changesets from Trac. We do this by replacing the parameter `changeset=on` to `repo-projectname=on` when querying the Trac timeline. To tell Trac to be aware of multi-project instances we leverage the `options` parameter when creating a new instance: new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" }); If this option is not provided, the original behaviour will prevail. Additionally, add corresponding tests. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js: (Trac): Reason about new optional parameter 'projectIdentifier'. (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL. (Trac.prototype._xmlTimelineURL): Given a projectIdentifier, replace default parameter `changeset=on` with `repo-projectname=on`. (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: (MockTrac): Add support for instantiating Trac with a projectIdentifier. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: (setup): Provide a multiple-project MockTrac instance to all test cases for testing. Add the following tests: test("revisionURL") test("revisionURL with Trac Identifier") test("_xmlTimelineURL") test("_xmlTimelineURL with Trac Identifier") (this.view._latestProductiveIteration): Fix missing ';'. 2017-01-30 Myles C. Maxfield Correct spacing regression on inter-element complex path shaping on some fonts https://bugs.webkit.org/show_bug.cgi?id=166013 Reviewed by Simon Fraser. Unskip existing tests and make some new tests: - Testing complex text with no origins - Testing initial expansions - Testing the sign of vertical advances * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: (TestWebKitAPI::TEST_F): 2017-01-30 Carlos Alberto Lopez Perez [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step. https://bugs.webkit.org/show_bug.cgi?id=167596 Reviewed by Daniel Bates. We avoid needing a thin directory by invoking the zip program with the list of directories from the build directory to be zipped, and by using the zip feature to exclude files matching a pattern. * BuildSlaveSupport/built-product-archive: (copyBuildFiles): (createZipFromList): (archiveBuiltProduct): 2017-01-30 Jonathan Bedard Use simctl instead of LayoutTestRelay https://bugs.webkit.org/show_bug.cgi?id=165927 Reviewed by Daniel Bates. Part 1 LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on simulators through simctl (iOS 10 and later), use this functionality instead. * Scripts/webkitpy/port/base.py: (Port.__init__): Added _test_runner_process_constructor. * Scripts/webkitpy/port/darwin.py: (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist. * Scripts/webkitpy/port/driver.py: (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use. (IOSSimulatorDriver): Deleted. * Scripts/webkitpy/port/driver_unittest.py: (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing. (DriverTest.test_two_starts_cleans_up_properly): Ditto. (DriverTest.test_start_actually_starts): Ditto. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort): Remove relay_name. (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort. (IOSSimulatorPort._create_simulators): Formatting change. (IOSSimulatorPort.relay_path): Deleted. (IOSSimulatorPort._check_relay): Deleted. (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation (IOSSimulatorPort._build_relay): Deleted. (IOSSimulatorPort._build_driver): Deleted. Use base class implementation (IOSSimulatorPort._driver_class): Deleted. Use base class implementation * Scripts/webkitpy/port/ios_unittest.py: (iosTest.test_32bit): Update test. (iosTest.test_64bit): Update test. * Scripts/webkitpy/port/server_process.py: (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device. (ServerProcess._set_file_nonblocking): Added to share common code. * Scripts/webkitpy/port/server_process_mock.py: (MockServerProcess.__init__): Added argument worker_number. * Scripts/webkitpy/port/simulator_process.py: Added. (SimulatorProcess): Added. (SimulatorProcess.Popen): Added. (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid. (SimulatorProcess.Popen.poll): Added. Check if the process is running. (SimulatorProcess.Popen.wait): Added. Wait for process to close. (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number. (SimulatorProcess._reset): Added. Unlink fifos. (SimulatorProcess._start): Added. Launch app on simulator, link fifos. (SimulatorProcess._kill): Added. Shutdown app on simulator. * Scripts/webkitpy/xcode/simulator.py: (Device.__init__): Accept host to run install/launch/terminate. (Device.install_app): Install app to target Device. (Device.launch_app): Launch app on target Device. (Device.terminate_app): Shutdown app on target Device. (Simulator._parse_devices): Pass host to Device. 2017-01-30 Carlos Alberto Lopez Perez [GTK] pixman fails to compile on Raspberry Pi (GCC crash) https://bugs.webkit.org/show_bug.cgi?id=167411 Reviewed by Michael Catanzaro. Disable the ARM iwMMXt fast path for pixman, because it triggers a GCC bug on the RPi with Raspbian/PIXEL causing a build failure. * gtk/jhbuild.modules: 2017-01-30 Carlos Garcia Campos [GTK] Add API to handle the accelerated compositing policy https://bugs.webkit.org/show_bug.cgi?id=167509 Reviewed by Michael Catanzaro. Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled as a special case. Also add test cases to the get/set API. * MiniBrowser/gtk/BrowserSettingsDialog.c: (hardwareAccelerationPolicyToString): (stringToHardwareAccelerationPolicy): (cellRendererChanged): (browserSettingsDialogConstructed): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: (testWebKitSettings): 2017-01-29 Andy Estes [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=167563 Reviewed by Andreas Kling. * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): (runTest): (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]): (TEST): 2017-01-29 Dan Bernstein [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle https://bugs.webkit.org/show_bug.cgi?id=167565 Reviewed by Sam Weinig. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added. (-[BundleRangeHandleRemoteObject textFromBodyRange:]): (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added. (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]): (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]): * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added. 2017-01-28 Yoav Weiss Add Link Preload as an off-by-default experimental feature menu item. https://bugs.webkit.org/show_bug.cgi?id=167201 Reviewed by Ryosuke Niwa. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): 2017-01-28 Joseph Pecoraro Add User Timing Experimental Feature https://bugs.webkit.org/show_bug.cgi?id=167542 Reviewed by Ryosuke Niwa. * DumpRenderTree/mac/DumpRenderTree.mm: (enableExperimentalFeatures): (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (enableExperimentalFeatures): 2017-01-28 Joseph Pecoraro Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line https://bugs.webkit.org/show_bug.cgi?id=167519 Reviewed by Ryosuke Niwa. * QueueStatusServer/templates/statusbubble.html: To measure the bubbleContainer's width, it must not be wrapping based on its parent container. So when measuring the width temporarily set the parent to a very large width so as to not artificially wrap us. Restore the parent's width after measuring. 2017-01-27 Andy Estes [iOS] Add a test for _WKNSFileManagerExtras https://bugs.webkit.org/show_bug.cgi?id=167478 Reviewed by Andreas Kling. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added. (expectAttributes): (TEST): 2017-01-27 Keith Miller run-benchmarks should make sure it passes the test url to the right application https://bugs.webkit.org/show_bug.cgi?id=167533 Reviewed by Joseph Pecoraro. This fixes an issue when trying to run-benchmark script with the system default browser set to STP. Previously, it would run the test in STP rather than the provided build. Now, it should run in the provided build. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver.launch_url): 2017-01-27 Myles C. Maxfield [Cocoa] Prepare ComplexTextController for unit testing https://bugs.webkit.org/show_bug.cgi?id=167493 Reviewed by Simon Fraser. Addressing post-review comments from Simon Fraser. * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: (TestWebKitAPI::TEST_F): 2017-01-27 Myles C. Maxfield [Cocoa] Prepare ComplexTextController for unit testing https://bugs.webkit.org/show_bug.cgi?id=167493 Reviewed by Dean Jackson. Create four unit tests. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added. (TestWebKitAPI::ComplexTextControllerTest::SetUp): (TestWebKitAPI::TEST_F): 2017-01-26 Chris Dumez Crash when navigating back to a page in PacheCache when one of its frames has been removed https://bugs.webkit.org/show_bug.cgi?id=167421 Reviewed by Darin Adler. Add a new setting allowing layout tests to enable PageCache in a window that has an opener, for convenience. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2017-01-26 Keith Miller classInfo should take a VM so it is not materialized from the object on each call https://bugs.webkit.org/show_bug.cgi?id=167424 Rubber Stamped by Michael Saboff. Previously, classInfo() would get the VM from the target's MarkedBlock. Most callers already have a VM on hand, so it is wasteful to compute the VM from the marked block every time. This patch refactors some of the most common callers of classInfo(), jsDynamicCast and inherits to take a VM as well. * DumpRenderTree/TestRunner.cpp: (setAudioResultCallback): 2017-01-26 Jer Noble Autoplay muted videos stop playback of any streaming app in the background https://bugs.webkit.org/show_bug.cgi?id=163993 Reviewed by Eric Carlson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added. 2017-01-26 Ryan Haddad Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay. https://bugs.webkit.org/show_bug.cgi?id=167466 Unreviewed test gardening. * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: (TEST): 2017-01-26 Matt Rajca Notify clients when the user plays media otherwise prevented from autoplaying https://bugs.webkit.org/show_bug.cgi?id=167390 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added. * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: (didPlayMediaPreventedFromPlayingWithoutUserGesture): (TEST): * TestWebKitAPI/cocoa/TestWKWebView.h: * TestWebKitAPI/cocoa/TestWKWebView.mm: (-[TestWKWebViewHostWindow _mouseUpAtPoint:]): (-[TestWKWebView waitForLoad]): (-[TestWKWebView mouseUpAtPoint:]): * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): 2017-01-26 Per Arne Vollan Crash when setting custom scale factor. https://bugs.webkit.org/show_bug.cgi?id=167369 Reviewed by Sam Weinig. Added API test. * TestWebKitAPI/PlatformWin.cmake: * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added. (TestWebKitAPI::WebKitCreateInstance): (TestWebKitAPI::ScaleWebView::SetUp): (TestWebKitAPI::ScaleWebView::TearDown): (TestWebKitAPI::TEST_F): 2017-01-25 Ryosuke Niwa run-benchmark nests MotionMark results by the suite name twice https://bugs.webkit.org/show_bug.cgi?id=164948 Reviewed by Said Abou-Hallawa. Use a single level MotionMark now that this is the name of the benchmark, and we no longer have tests that aren't part of the MotionMark suite. * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: 2017-01-25 Ryan Haddad Unreviewed, rolling out r211193. This change broke internal builds. Reverted changeset: "Notify clients when the user plays media otherwise prevented from autoplaying" https://bugs.webkit.org/show_bug.cgi?id=167390 http://trac.webkit.org/changeset/211193 2017-01-25 Matt Rajca Notify clients when the user plays media otherwise prevented from autoplaying https://bugs.webkit.org/show_bug.cgi?id=167390 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added. * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: (didPlayMediaPreventedFromPlayingWithoutUserGesture): (TEST): * TestWebKitAPI/cocoa/TestWKWebView.h: * TestWebKitAPI/cocoa/TestWKWebView.mm: (-[TestWKWebViewHostWindow _mouseUpAtPoint:]): (-[TestWKWebView waitForLoad]): (-[TestWKWebView mouseUpAtPoint:]): * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): 2017-01-25 Matt Rajca [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out https://bugs.webkit.org/show_bug.cgi?id=167385 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises. * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: (TEST): Allow inline (rather than full screen) media playback on iOS. 2017-01-25 Carlos Garcia Campos [GTK] Icon Database should be in private browsing mode for ephemeral web views https://bugs.webkit.org/show_bug.cgi?id=167414 Reviewed by Michael Catanzaro. Add a test case to check ephemeral web views don't write favicons to the database. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: (ephemeralViewLoadChanged): (testPrivateBrowsing): (testFaviconDatabase): 2017-01-25 Carlos Garcia Campos [GTK] Add a private browsing mode to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=167413 Reviewed by Michael Catanzaro. Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create private windows, even on non-private instances. * MiniBrowser/gtk/BrowserWindow.c: (webViewTitleChanged): Add [Private] to title window for private windows. (webViewCreate): Pass web context to browser_window_new. (openPrivateWindow): Create a new ephemeral web view and add it to a new window. (browserWindowFinalize): Disconnect web context signal handlers. (browser_window_init): Add shortcut for opening private window. (browser_window_new): It now receives the context and connect to download-started here. (browser_window_get_web_context): Return the context. * MiniBrowser/gtk/BrowserWindow.h: * MiniBrowser/gtk/main.c: (createBrowserTab): Create the web view for the window web context. (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one. (aboutDataHandleRequest): Ditto. (aboutURISchemeRequestCallback): Ditto. (main): Create ephemeral web context if private command line option is used. 2017-01-25 Ryosuke Niwa collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree https://bugs.webkit.org/show_bug.cgi?id=167409 Reviewed by Antti Koivisto. Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree as well as tests for the newly added matchingElementInFlatTree. * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: (TestWebKitAPI::runJavaScriptAlert): * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp: (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: 2017-01-24 Carlos Garcia Campos [GTK] Add API to create ephemeral web views and deprecate the private browsing setting https://bugs.webkit.org/show_bug.cgi?id=167370 Reviewed by Michael Catanzaro. Add several test cases of ephemeral web views. * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: (testWebViewAuthenticationStorage): * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: (ephemeralViewloadChanged): (testCookieManagerEphemeral): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: (testWebKitSettings): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextEphemeral): (ephemeralViewloadChanged): (testWebContextProxySettings): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (ephemeralViewloadChanged): (testWebViewEphemeral): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: (ephemeralViewloadChanged): (testWebsiteDataEphemeral): (beforeAll): 2017-01-24 Alex Christensen REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs https://bugs.webkit.org/show_bug.cgi?id=167402 Reviewed by Ryosuke Niwa. * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: (TestWebKitAPI::TEST): 2017-01-24 Zalan Bujtas Add simple line layout toggle to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=167405 Reviewed by Andreas Kling. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleSimpleLineLayoutEnabled:]): (-[SettingsController simpleLineLayoutEnabled]): * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController didChangeSettings]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): 2017-01-24 Joseph Pecoraro WKR does not include my nick when commit-queue lands my patch https://bugs.webkit.org/show_bug.cgi?id=167388 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/tool/commands/newcommitbot.py: (NewCommitBot._summarize_commit_log): * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Perform nickname insertion before grabbing "Patch by" details. This way we can include the nickname with the full name. 2017-01-24 Joseph Pecoraro Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature https://bugs.webkit.org/show_bug.cgi?id=167394 Reviewed by Ryosuke Niwa. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2017-01-24 Youenn Fablet [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc https://bugs.webkit.org/show_bug.cgi?id=167353 Reviewed by Alex Christensen. * Scripts/webkitpy/libwebrtc/generate_cmake.py: (CMakeGenerator.initialize_targets): 2017-01-24 Michael Catanzaro WKR should not confuse Miguel Gomez with Andres Gomez https://bugs.webkit.org/show_bug.cgi?id=167389 Reviewed by Lucas Forschler. Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to "mAndres Gomez". Fix this. * Scripts/webkitpy/tool/commands/newcommitbot.py: (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a space on each side of the email address, so expect both spaces to be there before considering the email for replacement. * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test. 2017-01-24 Matt Rajca Pass down website autoplay policies to media elements https://bugs.webkit.org/show_bug.cgi?id=167355 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions. * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added. * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): (TEST): 2017-01-24 Nan Wang AX: Speak Selection does not work in an iframe https://bugs.webkit.org/show_bug.cgi?id=166794 Reviewed by Chris Fleizach. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::retrieveSpeakSelectionContent): (WTR::UIScriptController::accessibilitySpeakSelectionContent): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::retrieveSpeakSelectionContent): (WTR::UIScriptController::accessibilitySpeakSelectionContent): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView dealloc]): (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]): (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::retrieveSpeakSelectionContent): (WTR::UIScriptController::accessibilitySpeakSelectionContent): 2017-01-24 Daniel Bates StringView.split() should use an iterator design pattern instead of allocating a Vector https://bugs.webkit.org/show_bug.cgi?id=163225 Reviewed by Darin Adler. Add unit tests for StringView.split(). * TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be used in the StringView.split() unit tests. (TestWebKitAPI::stringViewFromUTF8): Ditto. (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult object to a Vector of String objects. (TestWebKitAPI::TEST): Added the following tests: - WTF.StringViewSplitEmptyAndNullStrings - WTF.StringViewSplitBasic - WTF.StringViewSplitWithConsecutiveSeparators 2017-01-23 Anders Carlsson The Score Esports crashes on launch https://bugs.webkit.org/show_bug.cgi?id=167338 rdar://problem/29948645 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: (TestWebKitAPI::TEST): Add a test. 2017-01-23 Carlos Garcia Campos [GTK] Add API to WebKitWebsiteDataManager to handle website data https://bugs.webkit.org/show_bug.cgi?id=146589 Reviewed by Michael Catanzaro. Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the new API, moving the WebKitWebsiteDataManager configuration API to the new file too. * MiniBrowser/gtk/BrowserWindow.c: (webViewDecidePolicy): (newTabCallback): * MiniBrowser/gtk/main.c: (createBrowserTab): (aboutDataRequestFree): (aboutDataRequestNew): (aboutDataRequestForView): (websiteDataRemovedCallback): (websiteDataClearedCallback): (aboutDataScriptMessageReceivedCallback): (domainListFree): (aboutDataFillTable): (gotWebsiteDataCallback): (aboutDataHandleRequest): (aboutURISchemeRequestCallback): (main): * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (serverCallback): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added. (serverCallback): (WebsiteDataTest::WebsiteDataTest): (WebsiteDataTest::~WebsiteDataTest): (WebsiteDataTest::fetch): (WebsiteDataTest::remove): (WebsiteDataTest::clear): (testWebsiteDataConfiguration): (testWebsiteDataCache): (testWebsiteDataStorage): (testWebsiteDataDatabases): (testWebsiteDataAppcache): (beforeAll): (afterAll): 2017-01-23 Commit Queue Unreviewed, rolling out r211062. https://bugs.webkit.org/show_bug.cgi?id=167354 broke API tests (Requested by alexchristensen on #webkit). Reverted changeset: "Pass down website autoplay policies to media elements" https://bugs.webkit.org/show_bug.cgi?id=167132 http://trac.webkit.org/changeset/211062 2017-01-23 Alex Christensen URLParser should fail to parse percent-encoded invalid UTF-8 sequences https://bugs.webkit.org/show_bug.cgi?id=167330 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2017-01-23 Alex Christensen Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible https://bugs.webkit.org/show_bug.cgi?id=167317 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2017-01-23 Jonathan Bedard svn-create-patch should emit properties when files are moved or copied https://bugs.webkit.org/show_bug.cgi?id=167264 Reviewed by Daniel Bates. * Scripts/svn-create-patch: (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties. 2017-01-23 Youenn Fablet [WebRTC] Filter libwebrtc link flags https://bugs.webkit.org/show_bug.cgi?id=167287 Reviewed by Alex Christensen. * Scripts/webkitpy/libwebrtc/generate_cmake.py: (CMakeGenerator._compute_link_flags): (CMakeGenerator._compute_link_flags.keep_flag): (CMakeGenerator._generate_compile_target_options): 2017-01-23 Youenn Fablet [WebRTC] Make VP8 optional in libwebrtc https://bugs.webkit.org/show_bug.cgi?id=167257 Reviewed by Darin Adler. * Scripts/webkitpy/libwebrtc/generate_cmake.py: (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system. 2017-01-23 Jer Noble Video details does not apear and missing scrubber in Control Center https://bugs.webkit.org/show_bug.cgi?id=167233 Reviewed by Alex Christensen. Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to NowPlayingControlTests for iOS. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: (-[NowPlayingTestWebView setWindowVisible:]): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h. * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm. (SOFT_LINK_CLASS): (-[TestMessageHandler addMessage:withHandler:]): (-[TestMessageHandler userContentController:didReceiveScriptMessage:]): (__simulated_forceClickAssociatedEventsMask): (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]): (-[TestWKWebViewHostWindow isKeyWindow]): (-[TestWKWebViewHostWindow makeKeyWindow]): (-[TestWKWebViewHostWindow resignKeyWindow]): (-[TestWKWebView initWithFrame:]): (-[TestWKWebView initWithFrame:configuration:]): (-[TestWKWebView _setUpTestWindow:]): (-[TestWKWebView performAfterReceivingMessage:action:]): (-[TestWKWebView loadTestPageNamed:]): (-[TestWKWebView synchronouslyLoadTestPageNamed:]): (-[TestWKWebView stringByEvaluatingJavaScript:]): (-[TestWKWebView waitForMessage:]): (-[TestWKWebView performAfterLoading:]): (-[TestWKWebView mouseDownAtPoint:simulatePressure:]): (-[TestWKWebView typeCharacter:]): 2017-01-21 Carlos Garcia Campos Unreviewed. Bring back gtk-doc error messages after r209981. Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's impossible to know what's wrong. * gtk/gtkdoc.py: (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages. 2017-01-20 Youenn Fablet [WebRTC] Update build system to make G711 optional in libwebrtc https://bugs.webkit.org/show_bug.cgi?id=167256 Reviewed by Alex Christensen. * Scripts/webkitpy/libwebrtc/generate_cmake.py: (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions. 2017-01-20 Joseph Pecoraro Cleanup RuntimeEnabledFeatures https://bugs.webkit.org/show_bug.cgi?id=167228 Reviewed by Simon Fraser. * DumpRenderTree/mac/DumpRenderTree.mm: (enableExperimentalFeatures): (resetWebPreferencesToConsistentValues): (setWebPreferencesForTestOptions): (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/win/DumpRenderTree.cpp: (enableExperimentalFeatures): (resetWebPreferencesToConsistentValues): More closely match WebKitTestRunner initialization of preferences for experimental features. 2017-01-20 Alex Christensen Build Fix for Windows DumpRenderTree after r210976 https://bugs.webkit.org/show_bug.cgi?id=167115 * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): 2017-01-20 Joseph Pecoraro Remove outdated ENABLE(CSP_NEXT) build flag https://bugs.webkit.org/show_bug.cgi?id=167252 Reviewed by Brent Fulgham. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2017-01-20 Joseph Pecoraro Build Fix for Windows DumpRenderTree after r210976 * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): 2017-01-20 Antoine Quint Web Animations should be off by default and enabled as an experimental feature https://bugs.webkit.org/show_bug.cgi?id=167115 Reviewed by Joseph Pecoraro. Turn Web Animations on in DRT. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): 2017-01-20 Youenn Fablet [WebRTC] Add libwebrtc build infrastructure https://bugs.webkit.org/show_bug.cgi?id=167207 Reviewed by Alex Christensen. Adding a script doing the libwebrtc project json to CMake file conversion. * Scripts/generate-libwebrtc-cmake: Added. * Scripts/webkitpy/libwebrtc/__init__.py: Added. * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added. 2017-01-20 Joseph Pecoraro Mini Browser: Show tooltip for Experimental Features https://bugs.webkit.org/show_bug.cgi?id=167225 Reviewed by Alex Christensen. * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): Include the full details string as a tooltip. 2017-01-20 Per Arne Vollan [Win] Test output results should not be written twice. https://bugs.webkit.org/show_bug.cgi?id=167197 Reviewed by Brent Fulgham. Prevent test output from being written twice by returning early from the dump() function, if it already has been called. This patch also adds a missing newline to a test output line. * DumpRenderTree/win/DumpRenderTree.cpp: (dump): 2017-01-20 Antoine Quint [Modern Media Controls] Turn modern media controls on by default https://bugs.webkit.org/show_bug.cgi?id=165668 Reviewed by Dean Jackson. Enabled modern media controls by default in test runners. * DumpRenderTree/TestOptions.h: * WebKitTestRunner/TestOptions.h: 2017-01-19 Chris Dumez iterable<> should be enabled on WK1 https://bugs.webkit.org/show_bug.cgi?id=167221 Reviewed by Youenn Fablet. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setDOMIteratorEnabled): Deleted. * WebKitTestRunner/InjectedBundle/TestRunner.h: 2017-01-19 Aakash Jain Ensure status server logs go to log file https://bugs.webkit.org/show_bug.cgi?id=167210 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.next_work_item): Change log level from debug to info in order to facilitate deubgging issues. (StatusServer.update_work_items): Same. 2017-01-19 Megan Gardner Additional selection tests and interpolation fix https://bugs.webkit.org/show_bug.cgi?id=167171 Reviewed by Simon Fraser. We weren't adding the final event when interpolating event streams. * WebKitTestRunner/ios/HIDEventGenerator.mm: (-[HIDEventGenerator interpolatedEvents:]): 2017-01-19 Myles C. Maxfield [Cocoa] Variation fonts are erroneously disabled on iOS https://bugs.webkit.org/show_bug.cgi?id=167172 Reviewed by Simon Fraser. OpenSource builders don't seem to understand sdk=embedded*. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2017-01-19 Carlos Garcia Campos Unreviewed. Fix GTK+ unit tests failing since r210531. Avoid using paths to files that don't actually exist. * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: (testWebKitConsoleMessageNetworkError): * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (testContextMenuDefaultMenu): * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added. * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added. * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added. 2017-01-19 Carlos Garcia Campos [GTK] Provide API to set proxy settings https://bugs.webkit.org/show_bug.cgi?id=128674 Reviewed by Michael Catanzaro. Add tests for new proxy settings API. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (serverCallback): (ProxyTest::ProxyTest): (ProxyTest::~ProxyTest): (ProxyTest::loadURIAndGetMainResourceData): (ProxyTest::proxyServerPortAsString): (testWebContextProxySettings): (beforeAll): 2017-01-19 Timothy Hatcher Add back my old email address so old commits will still match it. * Scripts/webkitpy/common/config/contributors.json: 2017-01-19 Timothy Hatcher Remove my old email address from contributors.json and watchlist. * Scripts/validate-committer-lists: (CommitterListFromGit): Change the mapping to the correct email. * Scripts/webkitpy/common/config/contributors.json: * Scripts/webkitpy/common/config/watchlist: 2017-01-18 Ryan Haddad Unreviewed, rolling out r210848. This change introduced media-related LayoutTest failures and crashes on macOS. Reverted changeset: "[Modern Media Controls] Turn modern media controls on by default" https://bugs.webkit.org/show_bug.cgi?id=165668 http://trac.webkit.org/changeset/210848 2017-01-18 Andreas Kling Document::securityOrigin() should return a reference. Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: (TestWebKitAPI::TEST_F): 2017-01-18 Per Arne Vollan [Win] Clipboard tests are flaky. https://bugs.webkit.org/show_bug.cgi?id=167088 Reviewed by Brent Fulgham. Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. We can fix this by assigning each DRT a separate window station (each window station has its own clipboard). * DumpRenderTree/win/DumpRenderTree.cpp: (main): 2017-01-18 Antoine Quint [Modern Media Controls] Turn modern media controls on by default https://bugs.webkit.org/show_bug.cgi?id=165668 Reviewed by Dean Jackson. Enabled modern media controls by default in test runners. * DumpRenderTree/TestOptions.h: * WebKitTestRunner/TestOptions.h: 2017-01-17 Michael Catanzaro Unreviewed, rolling out r210834 https://bugs.webkit.org/show_bug.cgi?id=165668 It introduced dozens of test timeouts. Reverted changeset: "[Modern Media Controls] Turn modern media controls on by default" https://bugs.webkit.org/show_bug.cgi?id=165668 http://trac.webkit.org/changeset/210834 2017-01-17 Antoine Quint [Modern Media Controls] Turn modern media controls on by default https://bugs.webkit.org/show_bug.cgi?id=165668 Reviewed by Dean Jackson. Enabled modern media controls by default in test runners. * DumpRenderTree/TestOptions.h: * WebKitTestRunner/TestOptions.h: 2017-01-17 Chris Dumez Document title changed twice when setting document.title https://bugs.webkit.org/show_bug.cgi?id=167065 Reviewed by Darin Adler. Add WebKit2GTK API test that was written by Michael Catanzaro. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewTitleChange): (beforeAll): 2017-01-17 Joseph Pecoraro ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports https://bugs.webkit.org/show_bug.cgi?id=116551 Reviewed by Alex Christensen. * Scripts/webkitperl/FeatureList.pm: Remove stale RESOURCE_TIMING references which are now a runtime enabled feature that is part of the existing WEB_TIMING feature. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2017-01-17 Jonathan Bedard 'webkit-patch post' no longer works with moved/copied files https://bugs.webkit.org/show_bug.cgi?id=166914 Reviewed by Daniel Bates. SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new file outputs only the "Index:" line with an empty body. This workaround ignores such output from svn diff. A issue has been filed with SVN, a link to the public email list tracking this bug is below. http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e * Scripts/svn-create-patch: (generateDiff): Ignore an "Index:" line with an empty body. 2017-01-16 Joseph Pecoraro Remove the REQUEST_ANIMATION_FRAME flag https://bugs.webkit.org/show_bug.cgi?id=156980 Reviewed by Simon Fraser. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2017-01-15 Sam Weinig Add the ability to use numbers in makeString() https://bugs.webkit.org/show_bug.cgi?id=167087 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added. Add tests for StringConcatenate, focusing on new numeric additions. 2017-01-15 Michael Catanzaro Unreviewed, remove stale comment. This test was fixed by r163173. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: 2017-01-14 Yusuke Suzuki Annotate large string tests with largeHeap https://bugs.webkit.org/show_bug.cgi?id=167054 Reviewed by Filip Pizlo. * Scripts/run-javascriptcore-tests: * Scripts/run-jsc-stress-tests: 2017-01-14 Joseph Pecoraro Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES https://bugs.webkit.org/show_bug.cgi?id=167043 Reviewed by Darin Adler. * Scripts/webkitperl/FeatureList.pm: 2017-01-13 Joseph Pecoraro Remove ENABLE(DETAILS_ELEMENT) guards https://bugs.webkit.org/show_bug.cgi?id=167042 Reviewed by Alex Christensen. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2017-01-13 Said Abou-Hallawa 26 MotionMark performance tests failing https://bugs.webkit.org/show_bug.cgi?id=166854 Reviewed by Ryosuke Niwa. Unrelated change. This is the last place that we need to rename Animometer to MotionMark. * Scripts/webkitpy/common/config/watchlist: 2017-01-13 Yusuke Suzuki run-jsc-benchmarks' echo should have -e option https://bugs.webkit.org/show_bug.cgi?id=167009 Reviewed by Sam Weinig. echo requires `-e` option to use escape sequence. Without it, in some environment (in my Fedora 25), the escape sequence is not recognized and just dumped as `\c` etc. * Scripts/run-jsc-benchmarks: 2017-01-12 Chris Dumez Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig https://bugs.webkit.org/show_bug.cgi?id=166995 Reviewed by Jer Noble. Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig as some people are having trouble building without it. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2017-01-12 Sam Weinig Add the ability to filter the set of bindings tests you want to run https://bugs.webkit.org/show_bug.cgi?id=166977 Reviewed by Tim Horton. Allows doing things like: run-bindings-tests TestObj* TestCEReactions* to run only those tests that match the patterns. * Scripts/run-bindings-tests: (main): Switch to using optparse and pass the remaining args as the filters. * Scripts/webkitpy/bindings/main.py: (BindingsTests.__init__): Store the pattens. (BindingsTests.test_matches_patterns): Add helper predicate to determine if a test should be run. When no patterns are present, all tests should run. (BindingsTests.run_tests): Filter tests using the passed in patterns. 2017-01-12 Per Arne Vollan Followup fix after r210503. https://bugs.webkit.org/show_bug.cgi?id=166887 Reviewed by Alex Christensen. After , test results are written to a duplicated file handle on Windows. This patch fixes the remaining call sites. * DumpRenderTree/PixelDumpSupport.cpp: * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired): * DumpRenderTree/TestRunner.h: * DumpRenderTree/win/AccessibilityControllerWin.cpp: * DumpRenderTree/win/DumpRenderTree.cpp: * DumpRenderTree/win/DumpRenderTreeWin.h: * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::setSpellCheckerLoggingEnabled): 2017-01-11 Megan Gardner Add committer status for Megan https://bugs.webkit.org/show_bug.cgi?id=166954 Reviewed by Tim Horton. Add committer status for Megan Gardner * Scripts/webkitpy/common/config/contributors.json: 2017-01-11 Brent Fulgham Unreviewed test fix after r210599. * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout. 2017-01-11 Brent Fulgham Unreviewed build fix after r210599. Add missing files. * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added. * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added. 2017-01-11 Brent Fulgham File scheme should not allow access of a resource on a different volume. https://bugs.webkit.org/show_bug.cgi?id=158552 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files. * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added. * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added. 2017-01-11 Ryan Haddad Unreviewed, rolling out r210571. This change broke the 32-bit macOS build and caused LayoutTest failures. Reverted changeset: "File scheme should not allow access of a resource on a different volume." https://bugs.webkit.org/show_bug.cgi?id=158552 http://trac.webkit.org/changeset/210571 2017-01-10 Carlos Alberto Lopez Perez [GTK] install-dependencies script misses gdb https://bugs.webkit.org/show_bug.cgi?id=166917 Reviewed by Michael Catanzaro. gdb is needed for generating the crash logs. * gtk/install-dependencies: 2017-01-10 Michael Catanzaro [GTK] No way for applications to set notification permissions without waiting for permission request https://bugs.webkit.org/show_bug.cgi?id=163366 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewNotification): (setInitialNotificationPermissionsAllowedCallback): (setInitialNotificationPermissionsDisallowedCallback): (testWebViewNotificationInitialPermissionAllowed): (testWebViewNotificationInitialPermissionDisallowed): (beforeAll): * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h: * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::WebViewTest): (WebViewTest::initializeWebView): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2017-01-10 Tim Horton MobileMiniBrowser tests don't work by default https://bugs.webkit.org/show_bug.cgi?id=166910 Reviewed by Alex Christensen. * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added. Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least. 2017-01-10 Brent Fulgham File scheme should not allow access of a resource on a different volume. https://bugs.webkit.org/show_bug.cgi?id=158552 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files. * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added. * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added. 2017-01-10 Mark Lam Reverting run-jsc-stress-tests' $buildType to use string values. https://bugs.webkit.org/show_bug.cgi?id=166912 Rubber stamped by Filip Pizlo. This is so that we can test for it in the tests e.g. //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end * Scripts/run-jsc-stress-tests: 2017-01-10 Ryosuke Niwa Temporarily add back the file removed in r210463 to unbreak internal bots. * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch. 2017-01-10 Jonathan Bedard svn-apply failed to apply a patch (deleting file with svn property) https://bugs.webkit.org/show_bug.cgi?id=165953 Reviewed by Daniel Bates. * Scripts/VCSUtils.pm: (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines. * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties. 2017-01-10 Ryan Haddad Update flakiness dashboard configuration. https://bugs.webkit.org/show_bug.cgi?id=166869 Reviewed by Alexey Proskuryakov. * TestResultServer/static-dashboards/builders.jsonp: * TestResultServer/static-dashboards/flakiness_dashboard.js: 2017-01-10 Carlos Alberto Lopez Perez [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY https://bugs.webkit.org/show_bug.cgi?id=165232 Unreviewed follow-up patch after r210539 and r210523. Instead of using that environment variable, the argument --display-server=xorg should be passed now. The GTK+ performance bot was the only bot using this, and is already passing --display-server=xorg after r210539. * Scripts/webkitpy/port/gtk.py: (GtkPort._driver_class): 2017-01-10 Carlos Alberto Lopez Perez [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot. https://bugs.webkit.org/show_bug.cgi?id=166872 Reviewed by Michael Catanzaro. Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot. Define the required "--display-server=driver" in the bot additionalArguments config entry. Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps. The step RunWebKitTests already has support for it. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunGtkAPITests.start): (RunAndUploadPerfTests.start): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: 2017-01-09 Ryan Haddad Unreviewed, rolling out r210531. This change broke the 32-bit macOS build and caused LayoutTest failures. Reverted changeset: "File scheme should not allow access of a resource on a different volume." https://bugs.webkit.org/show_bug.cgi?id=158552 http://trac.webkit.org/changeset/210531 2017-01-09 Brent Fulgham File scheme should not allow access of a resource on a different volume. https://bugs.webkit.org/show_bug.cgi?id=158552 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files. * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added. * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added. 2017-01-09 Carlos Alberto Lopez Perez [GTK][Wayland] Allow running the layout tests under a native Wayland environment. https://bugs.webkit.org/show_bug.cgi?id=165232 Reviewed by Michael Catanzaro. Add a new WaylandDriver to run the tests in the user current wayland session. Also merge all the configuration options for selecting the display server inside one switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb). This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests. * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger. (TestRunner._create_driver): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): * Scripts/webkitpy/port/gtk.py: (GtkPort.__init__): (GtkPort._driver_class): (GtkPort._search_paths): * Scripts/webkitpy/port/waylanddriver.py: Added. (WaylandDriver): (WaylandDriver.check_driver): (WaylandDriver._setup_environ_for_test): (WaylandDriver._start): 2017-01-09 Andy Estes [QuickLook] Add a layout test for webkit.org/b/135651 https://bugs.webkit.org/show_bug.cgi?id=166855 Reviewed by Andreas Kling. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for errors with code WebKitErrorCannotShowURL. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output not specific to WebKit2 error codes. 2017-01-09 Antoine Quint Support webkit-test-runner key-value pairs in http tests in DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=166837 Reviewed by Alex Christensen. We now correctly handle the --absolutePath argument in DumpRenderTree and use the provided value when trying to determine the path to the test file. Failing that, we use the computed URL or the raw path provided to cover all cases. This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668 by applying this patch and seeing the number test failures dramatically reduced with WK1 due to the option to turn modern media controls off for older media controls tests. * DumpRenderTree/DumpRenderTree.h: * DumpRenderTree/DumpRenderTreeCommon.cpp: (parseInputLine): * DumpRenderTree/TestOptions.h: * DumpRenderTree/TestOptions.mm: (TestOptions::TestOptions): * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): 2017-01-09 Milan Crha prepare-ChangeLog: Correct help string for --style option https://bugs.webkit.org/show_bug.cgi?id=166725 Reviewed by Alexey Proskuryakov. * Scripts/prepare-ChangeLog: (main): 2017-01-09 Lucas Forschler https://bugs.webkit.org/show_bug.cgi?id=166839 Add php7 support for macOS. Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file. Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/base.py: (Port._is_darwin_php_version_7): (Port._debian_php_version): (Port): (Port._darwin_php_version): (Port._apache_config_file_name_for_platform): 2017-01-06 Gustavo Noronha Silva [GTK] Should support key and code properties on keyboard events https://bugs.webkit.org/show_bug.cgi?id=166759 Reviewed by Carlos Garcia Campos. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only on tests. 2017-01-06 Per Arne Vollan [Win] Some tests are flaky because certain DLLs are writing to stdout. https://bugs.webkit.org/show_bug.cgi?id=166760 Reviewed by Darin Adler. Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results. We can work around that by duplicating and redirecting stdout. * DumpRenderTree/PixelDumpSupport.cpp: (dumpWebViewAsPixelsAndCompareWithExpected): (printPNG): * DumpRenderTree/win/AccessibilityControllerWin.cpp: (logEventProc): * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: (DRTDesktopNotificationPresenter::showDesktopNotification): (DRTDesktopNotificationPresenter::cancelDesktopNotification): (DRTDesktopNotificationPresenter::requestNotificationPermission): * DumpRenderTree/win/DumpRenderTree.cpp: (dumpFrameScrollPosition): (dumpHistoryItem): (dumpBackForwardList): (dump): (runTest): (main): * DumpRenderTree/win/DumpRenderTreeWin.h: * DumpRenderTree/win/EditingDelegate.cpp: (EditingDelegate::shouldBeginEditingInDOMRange): (EditingDelegate::shouldEndEditingInDOMRange): (EditingDelegate::shouldInsertNode): (EditingDelegate::shouldInsertText): (EditingDelegate::shouldDeleteDOMRange): (EditingDelegate::shouldChangeSelectedDOMRange): (EditingDelegate::shouldApplyStyle): (EditingDelegate::shouldChangeTypingStyle): (EditingDelegate::doPlatformCommand): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection): * DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didStartProvisionalLoadForFrame): (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (FrameLoadDelegate::didChangeLocationWithinPageForFrame): (FrameLoadDelegate::didFailProvisionalLoadWithError): (FrameLoadDelegate::didCommitLoadForFrame): (FrameLoadDelegate::didReceiveTitle): (FrameLoadDelegate::didFinishLoadForFrame): (FrameLoadDelegate::didFailLoadWithError): (FrameLoadDelegate::willPerformClientRedirectToURL): (FrameLoadDelegate::didCancelClientRedirectForFrame): (FrameLoadDelegate::windowScriptObjectAvailable): (FrameLoadDelegate::didFinishDocumentLoadForFrame): (FrameLoadDelegate::didHandleOnloadEventsForFrame): (FrameLoadDelegate::didDisplayInsecureContent): (FrameLoadDelegate::didRunInsecureContent): (FrameLoadDelegate::webViewProgressFinishedNotification): * DumpRenderTree/win/HistoryDelegate.cpp: (HistoryDelegate::didNavigateWithNavigationData): (HistoryDelegate::didPerformClientRedirectFromURL): (HistoryDelegate::didPerformServerRedirectFromURL): (HistoryDelegate::updateHistoryTitle): (HistoryDelegate::populateVisitedLinksForWebView): * DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::decidePolicyForNavigationAction): (PolicyDelegate::unableToImplementPolicyWithError): * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest): (ResourceLoadDelegate::didReceiveAuthenticationChallenge): (ResourceLoadDelegate::didReceiveResponse): (ResourceLoadDelegate::didFinishLoadingFromDataSource): (ResourceLoadDelegate::didFailLoadingWithError): * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::addDisallowedURL): (TestRunner::originsWithApplicationCache): (TestRunner::setStorageDatabaseIdleInterval): (TestRunner::closeIdleLocalStorageDatabases): (TestRunner::copyDecodedHostName): (TestRunner::copyEncodedHostName): (TestRunner::numberOfPendingGeolocationPermissionRequests): (TestRunner::isGeolocationProviderActive): (TestRunner::pathToLocalResource): (TestRunner::setMockDeviceOrientation): (TestRunner::setMockGeolocationPosition): (TestRunner::setMockGeolocationPositionUnavailableError): (TestRunner::setSpatialNavigationEnabled): (TestRunner::setAutomaticLinkDetectionEnabled): (TestRunner::isCommandEnabled): (TestRunner::authenticateSession): (TestRunner::addChromeInputField): (TestRunner::removeChromeInputField): (TestRunner::focusWebView): (TestRunner::grantWebNotificationPermission): (TestRunner::denyWebNotificationPermission): (TestRunner::removeAllWebNotificationPermissions): (TestRunner::simulateWebNotificationClick): (TestRunner::imageCountInGeneralPasteboard): * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::runJavaScriptAlertPanelWithMessage): (UIDelegate::runJavaScriptConfirmPanelWithMessage): (UIDelegate::runJavaScriptTextInputPanelWithPrompt): (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): (UIDelegate::webViewAddMessageToConsole): (UIDelegate::exceededDatabaseQuota): (UIDelegate::setStatusText): (UIDelegate::didPressMissingPluginButton): 2017-01-07 Tim Horton Add a setting to create editable MiniBrowser windows by default https://bugs.webkit.org/show_bug.cgi?id=166806 Reviewed by Beth Dakin. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate createBrowserWindowController:]): (-[BrowserAppDelegate applicationDidFinishLaunching:]): (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]): * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleCreateEditorByDefault:]): (-[SettingsController createEditorByDefault]): Add a setting and update the key equivalents accordingly. Also make sure to make the right kind of window on launch. 2017-01-07 Tim Horton Fix the 32-bit build. * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: 2017-01-07 Tim Horton Fix the 32-bit build. * MiniBrowser/mac/BrowserWindowController.m: 2017-01-07 Tim Horton Make it possible to drop HTML files on the MiniBrowser icon https://bugs.webkit.org/show_bug.cgi?id=166802 Reviewed by Simon Fraser. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate application:openFile:]): * MiniBrowser/mac/Info.plist: If you're using an editable window, the usual trick of dropping on the window doesn't work anymore (it makes an instead). 2017-01-07 Tim Horton MiniBrowser window gets smaller each time it is instantiated https://bugs.webkit.org/show_bug.cgi?id=166807 Reviewed by Andy Estes. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): * MiniBrowser/mac/BrowserWindow.xib: Turn on full-window content view support with IB, instead of waiting until after the views have been loaded. This seems to resolve the longstanding ever-shrinking-window problem. 2017-01-07 Tim Horton Add indent/outdent items to MiniBrowser's new format menu https://bugs.webkit.org/show_bug.cgi?id=166805 Reviewed by Dan Bernstein. * MiniBrowser/mac/MainMenu.xib: 2017-01-07 Tim Horton Add a stock Format menu to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=166804 Reviewed by Andy Estes. * MiniBrowser/mac/MainMenu.xib: Many of the features automatically work with editable web views. However, this seems to expose a bug where none of the font-related features (Cmd-B, for example) work until the first time the font panel is shown, per process, which will need to be investigated separately. 2017-01-07 Tim Horton Remove unused applicationWillTerminate methods from MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=166803 Reviewed by Andy Estes. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate applicationWillTerminate:]): Deleted. * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController applicationTerminating]): Deleted. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController applicationTerminating]): Deleted. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController applicationTerminating]): Deleted. 2017-01-07 Tim Horton Add the ability to create empty contentEditable windows in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=166801 Reviewed by Wenson Hsieh. * MiniBrowser/mac/AppDelegate.h: * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate createBrowserWindowController:]): (-[BrowserAppDelegate newWindow:]): (-[BrowserAppDelegate newEditorWindow:]): (-[BrowserAppDelegate openDocument:]): (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]): * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController loadHTMLString:]): (-[BrowserWindowController toggleEditable:]): * MiniBrowser/mac/MainMenu.xib: * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController awakeFromNib]): (-[WK1BrowserWindowController loadHTMLString:]): (-[WK1BrowserWindowController validateMenuItem:]): (-[WK1BrowserWindowController setEditable:]): (-[WK1BrowserWindowController updateTitle:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]): (-[WK2BrowserWindowController validateMenuItem:]): (-[WK2BrowserWindowController setEditable:]): (-[WK2BrowserWindowController updateTitle:]): (-[WK2BrowserWindowController loadHTMLString:]): Merge more functionality from WebEditingTester. Add two menu items for creating empty editable WebKit1/2 windows. Add a menu item to the Edit menu to toggle editability on any window. 2017-01-07 Tim Horton Implement find-in-page in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=166799 Reviewed by Andy Estes. * MiniBrowser/mac/BrowserWindow.xib: * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController find:]): Deleted. * MiniBrowser/mac/MainMenu.xib: * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController toggleShrinkToFit:]): (-[WK1BrowserWindowController find:]): Deleted. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]): (-[WK2BrowserWindowController dealloc]): (-[WK2BrowserWindowController validateMenuItem:]): (-[WK2BrowserWindowController performTextFinderAction:]): (-[WK2BrowserWindowController findBarView]): (-[WK2BrowserWindowController setFindBarView:]): (-[WK2BrowserWindowController isFindBarVisible]): (-[WK2BrowserWindowController setFindBarVisible:]): (-[WK2BrowserWindowController contentView]): (-[WK2BrowserWindowController findBarViewDidChangeHeight]): (-[WK2BrowserWindowController performFindPanelAction:]): Deleted. (-[WK2BrowserWindowController find:]): Deleted. Implement find-in-page using WKWebView's conformance to the NSTextFinderClient protocol. At first glance, it's pretty broken, but vaguely works. 2017-01-07 Tim Horton Share the implementation of MiniBrowser view hiding functionality https://bugs.webkit.org/show_bug.cgi?id=166800 Reviewed by Andy Estes. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController showHideWebView:]): (-[BrowserWindowController removeReinsertWebView:]): * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController showHideWebView:]): Deleted. (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController showHideWebView:]): Deleted. (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted. Move the implementation of these two things to the shared superclass, since they don't depend on WebKit-specific things. Also, there was no reason to retain the (WK)WebView while it was unparented, as the BrowserWindowController maintains a reference the entire time. 2017-01-06 Andy Estes [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport https://bugs.webkit.org/show_bug.cgi?id=166789 Reviewed by Alex Christensen. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/PlatformMac.cmake: * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed. * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed. * DumpRenderTree/mac/DumpRenderTree.mm: Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of createXMLStringFromWebArchiveData(). * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed. * WebKitTestRunner/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dumpDOMAsWebArchive): Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of createXMLStringFromWebArchiveData(). * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed. * WebKitTestRunner/PlatformMac.cmake: * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed. 2017-01-06 Tim Horton Minor cleanups to IndentOutdentCommand and related code https://bugs.webkit.org/show_bug.cgi?id=166791 Reviewed by Simon Fraser. * WebEditingTester/EditingOperations.m: (editingOperations): Add the outdent operation to WebEditingTester. 2017-01-06 Said Abou-Hallawa Create a plan and a patch files for MotionMark and delete the Animometer's ones https://bugs.webkit.org/show_bug.cgi?id=166785 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch. * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan. 2017-01-06 Antoine Quint Support webkit-test-runner key-value pairs in http tests https://bugs.webkit.org/show_bug.cgi?id=149812 Reviewed by Alex Christensen. We pass the absolute path for a test through to WKTR so that we can parse tests that are running as URLs for webkit-test-runner options. * DumpRenderTree/DumpRenderTreeCommon.cpp: (parseInputLine): Explicitly skip the --absolute-path option in DRT or else we'd crash. * Scripts/webkitpy/port/driver.py: (Driver._command_from_driver_input): Pass the absolute path to the file through the CLI. * WebKitTestRunner/TestController.cpp: (WTR::updateTestOptionsFromTestHeader): (WTR::TestController::testOptionsForTest): (WTR::parseInputLine): (WTR::TestController::runTest): * WebKitTestRunner/TestController.h: 2017-01-06 Tim Horton Warning about unconnectable outlets when opening a MiniBrowser window https://bugs.webkit.org/show_bug.cgi?id=166756 Reviewed by Dan Bernstein. * MiniBrowser/mac/BrowserWindow.xib: When launching MiniBrowser, it says: Failed to connect (Share) outlet from (WK1BrowserWindowController) to (MBToolbarItem): missing setter or instance variable Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to (NSButtonCell): missing setter or instance variable. It looks like someone added the connection from the share button to the BrowserWindowController three times; only one of the connections is valid. Remove the other two. 2017-01-05 Keith Rollin Add WebCore::URL::protocolHostAndPort https://bugs.webkit.org/show_bug.cgi?id=166426 Reviewed by Alex Christensen. Add test for protocolHostAndPort. * TestWebKitAPI/Tests/WebCore/URL.cpp: (TestWebKitAPI::TEST_F): 2017-01-05 Per Arne Vollan [Win] Archive test result is failing. https://bugs.webkit.org/show_bug.cgi?id=166720 Reviewed by Alex Christensen. Deleting the layout test result folder is sometimes failing on Windows. This is not a critical error. * BuildSlaveSupport/test-result-archive: (archiveTestResults): 2017-01-04 Tomas Popela [GTK] Minibrowser: Add printing support https://bugs.webkit.org/show_bug.cgi?id=165298 Open a print dialog when the Ctrl + P shortcut is pressed. If there is an error during the print, it's printed on the console. Reviewed by Michael Catanzaro. * MiniBrowser/gtk/BrowserWindow.c: (webKitPrintOperationFailedCallback): (printPage): (browser_window_init): 2017-01-04 Manuel Rego Casasnovas [css-grid] Fix crash clamping grid lines https://bugs.webkit.org/show_bug.cgi?id=166637 Reviewed by Darin Adler. Creates new unit test to verify that the maximum tracks limit is used in GridPosition too. * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/PlatformWin.cmake: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added. (TestWebKitAPI::TEST): 2017-01-04 Wenson Hsieh Move editing history scripts to WebCore PrivateHeaders https://bugs.webkit.org/show_bug.cgi?id=166709 Reviewed by Dan Bernstein. Update references to editing script files in WebCore that were moved. * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: 2017-01-04 Yusuke Suzuki Unreviewed, build fix after r210313 part 2 https://bugs.webkit.org/show_bug.cgi?id=166676 Add 'U' suffix. * TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/WTFString.cpp: (TestWebKitAPI::TEST): 2017-01-04 Yusuke Suzuki Limit thread name appropriately https://bugs.webkit.org/show_bug.cgi?id=166676 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/WTFString.cpp: (TestWebKitAPI::TEST): 2017-01-04 Andy Estes [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening https://bugs.webkit.org/show_bug.cgi?id=166696 Reviewed by Tim Horton. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/PlatformWin.cmake: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}. * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp. * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto. * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added. (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal. (TestWebKitAPI::TEST_F): Added a test for createNSDataArray. 2017-01-03 Brian Burg Web Inspector: teach the protocol generator about platform-specific types, events, and commands https://bugs.webkit.org/show_bug.cgi?id=166003 Reviewed by Joseph Pecoraro. Teach run-inspector-generator-tests to generate test output using the platform name derived from the directory that the test is in. For example, tests in the /generic/ subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py. * Scripts/webkitpy/inspector/main.py: (InspectorGeneratorTests.generate_from_json): (InspectorGeneratorTests.run_tests): (InspectorGeneratorTests.main): 2017-01-04 Csaba Osztrogonác Unreviewed cmake buildfix after r210266. * DumpRenderTree/PlatformMac.cmake: 2017-01-04 Tim Horton Provide a setting for clients to always prefer low-power WebGL https://bugs.webkit.org/show_bug.cgi?id=166675 Reviewed by Dan Bernstein. * MiniBrowser/mac/Info.plist: Have MiniBrowser claim to be a modern app that supports automatic graphics switching. WebKit needs to support automatic graphics switching, so our test app might as well. Without this Info.plist parameter, this change has no effect, and bringing up a WebGL context still brings up the discrete GPU (also true of the existing web-exposed preferLowPowerToHighPerformance API). 2017-01-03 Yusuke Suzuki WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread https://bugs.webkit.org/show_bug.cgi?id=166645 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: (TestWebKitAPI::TEST): 2017-01-03 Andy Estes Place all the Cocoa WebCore API tests in the same directory https://bugs.webkit.org/show_bug.cgi?id=166673 Reviewed by Michael Catanzaro. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm. * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm. * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm. 2017-01-03 Tim Horton NSSpellChecker's recordResponse isn't called for unseen automatic corrections https://bugs.webkit.org/show_bug.cgi?id=166450 Reviewed by Darin Adler. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestRunner.cpp: (TestRunner::staticFunctions): * DumpRenderTree/mac/TestRunnerMac.mm: (setSpellCheckerLoggingEnabledCallback): * DumpRenderTree/win/TestRunnerWin.cpp: (setSpellCheckerLoggingEnabledCallback): * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added. * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added. (stringForCorrectionResponse): (drt_NSSpellChecker_recordResponseToCorrection): (swizzleNSSpellCheckerMethodsIfNeeded): (setSpellCheckerLoggingEnabled): Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when set to true, logs to stdout (which ends up in the test result) whenever NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag: is called, and then calls the original method. It is reset to false between tests. 2017-01-03 Sam Weinig Make WTF::Expected support Ref template parameters https://bugs.webkit.org/show_bug.cgi?id=166662 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WTF/Expected.cpp: (TestWebKitAPI::TEST): Add tests for using Ref with Expected. 2017-01-03 Michael Catanzaro [GTK] Expose WebKitSecurityOrigin API https://bugs.webkit.org/show_bug.cgi?id=166632 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added. (testSecurityOriginBasicConstructor): (testSecurityOriginURIConstructor): (testSecurityOriginDefaultPort): (testSecurityOriginFileURI): (testSecurityOriginDataURI): (beforeAll): (afterAll): 2017-01-03 Carlos Garcia Campos [GTK] HTTP auth layout tests are flaky https://bugs.webkit.org/show_bug.cgi?id=158919 Reviewed by Michael Catanzaro. * gtk/jhbuild.modules: Update libsoup to version 2.57.1. * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of missing valac in the bots. 2017-01-03 Carlos Garcia Campos REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs https://bugs.webkit.org/show_bug.cgi?id=165797 Reviewed by Michael Catanzaro. Move directory ruleset after all exclude rules of Source rulset. * gtk/manifest.txt.in: 2017-01-02 Yusuke Suzuki Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl https://bugs.webkit.org/show_bug.cgi?id=166636 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): 2017-01-02 Manuel Rego Casasnovas [GTK] WebCore/CSSParser unit test is not being built https://bugs.webkit.org/show_bug.cgi?id=166492 Reviewed by Michael Catanzaro. This test was introduced in r175930, but we were not building it on GTK+ port since r176015. This patch marks the test to be built again on GTK+. JFTR, the test is passing right now. * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors. 2017-01-02 Chris Fleizach AX: Expose block quote level to iOS API https://bugs.webkit.org/show_bug.cgi?id=166629 Reviewed by Darin Adler. * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::numberAttributeValue): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::numberAttributeValue): 2016-12-31 Michael Catanzaro SecurityOrigin::create triplet constructor does not canonicalize port https://bugs.webkit.org/show_bug.cgi?id=166624 Reviewed by Daniel Bates. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/PlatformWin.cmake: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added. (TestWebKitAPI::SecurityOriginTest::SetUp): (TestWebKitAPI::TEST_F): 2016-12-30 Michael Catanzaro [GTK] Improve user agent construction https://bugs.webkit.org/show_bug.cgi?id=142074 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk): (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk): (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk): (TestWebKitAPI::TEST): 2016-12-27 Michael Catanzaro [GTK] Improve user agent construction https://bugs.webkit.org/show_bug.cgi?id=142074 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): 2016-12-23 Simon Fraser REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad https://bugs.webkit.org/show_bug.cgi?id=166472 rdar://problem/29675551 Reviewed by Tim Horton. These changes are necessary to allow the mouse to leave the WTR window while drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged (which DRT does); we'd always go through mouseMoved, which hits an early return in WebViewImpl::mouseMoved() when the point is outside the view. * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseMoveTo): 2016-12-23 Andy Estes [iOS] Fix some crashing webarchive tests https://bugs.webkit.org/show_bug.cgi?id=166470 Reviewed by Andreas Kling. Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too, so this change uses that on both platforms. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES. * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm. * WebKitTestRunner/PlatformMac.cmake: * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed. 2016-12-22 Saam Barati WebAssembly: Silence the output of the spec-tests https://bugs.webkit.org/show_bug.cgi?id=166417 Reviewed by Mark Lam. * Scripts/run-jsc-stress-tests: 2016-12-22 Zhuo Li [Cocoa] SPI for setloadsImagesAutomatically. https://bugs.webkit.org/show_bug.cgi?id=166401. Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm: (TEST): Test the _setLoadsImagesAutomatically SPI. By default, _loadsImagesAutomatically returns YES. 2016-12-22 Wenson Hsieh fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent https://bugs.webkit.org/show_bug.cgi?id=161328 Reviewed by Darin Adler. Running a test that scales the viewport and listens to a didEndZooming callback (such as viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page load, should prevent this from happening, but from reading documentation and code inspection, this is not intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them for later. Instead, what we need in this case is to clear out any started but not yet completed animations after we finish running a test and before we load the next test. One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children, recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the previous test started zooming and then finished before zooming completed. Since this happens before the next test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test. * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformResetStateToConsistentValues): 2016-12-22 Jer Noble Muted media element playback should not interrupt other audio playback https://bugs.webkit.org/show_bug.cgi?id=166347 Reviewed by Eric Carlson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added. 2016-12-22 Alejandro G. Castro [WebRTC] Add support for runtime PeeConnection setting, required after r209757 https://bugs.webkit.org/show_bug.cgi?id=166346 Reviewed by Carlos Garcia Campos. Enable WebRTC by default to simplify testing. * MiniBrowser/gtk/main.c: (main): 2016-12-21 Alexey Proskuryakov REGRESSION: API test failure: WKWebView.LocalStorageClear https://bugs.webkit.org/show_bug.cgi?id=166032 Reviewed by Simon Fraser. Add an @autoreleasepool around the code that allocates then clears the WKWebView, to ensure that the view is destroyed before the callback fires. * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: (TEST): 2016-12-21 Saam Barati WebAssembly: Import spec tests https://bugs.webkit.org/show_bug.cgi?id=166395 Rubber stamped by Keith Miller. * Scripts/run-jsc-stress-tests: 2016-12-21 Alexey Proskuryakov REGRESSION: API test failure: _WKDownload.OriginatingWebView https://bugs.webkit.org/show_bug.cgi?id=166033 Reviewed by Simon Fraser. Add an @autoreleasepool around the code that allocates the WKWebView, so that it can be destroyed by removing the last reference in _downloadDidStart. * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (TEST): 2016-12-21 Daniel Bates WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows() https://bugs.webkit.org/show_bug.cgi?id=166356 Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose as a means to allow a test to explicit allow an embedding client to open a new windows such that the default behavior is for the embedding client to forbid such an action. The test plugins/get-url-with-blank-target.html assumes this default behavior though it is currently skipped on WebKit2 because questions were raised in the patch for about its correctness and usefulness. We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip this test. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setCanOpenWindows): 2016-12-20 Simon Fraser REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash https://bugs.webkit.org/show_bug.cgi?id=166031 Reviewed by Tim Horton. Add an @autoreleasepool around the code that allocates then clears the WKWebView, to ensure that the view is destroyed before the callback fires. * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: 2016-12-20 Megan Gardner Throw Exception when test doesn't clean up HID Events properly https://bugs.webkit.org/show_bug.cgi?id=166271 Reviewed by Simon Fraser. Add in a check when UIScriptController is deleted to make sure that the HID event callback dictionary is empty. If it is not, and a HID event is hit, this will cause the program to crash without any good information. Crashes are race-y, and will still happen with malformed test, but the information will be much more helpful. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::checkForClean): * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: (UIScriptContext::~UIScriptContext): * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::checkForClean): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/HIDEventGenerator.h: * WebKitTestRunner/ios/HIDEventGenerator.mm: (-[HIDEventGenerator checkHIDCallbacksClear]): * WebKitTestRunner/ios/TestControllerIOS.mm: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::checkForClean): 2016-12-20 Andy Estes [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash https://bugs.webkit.org/show_bug.cgi?id=165992 Reviewed by Brady Eidson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added. (expectException): (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]): (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]): (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]): (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added. 2016-12-20 Dean Jackson Remove INDIE_UI https://bugs.webkit.org/show_bug.cgi?id=165881 Reviewed by Simon Fraser. The Indie UI work has been discontinued. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-12-19 Yusuke Suzuki [ES6] Enable ES6 Modules https://bugs.webkit.org/show_bug.cgi?id=165849 Reviewed by Geoffrey Garen. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setES6ModulesEnabled): Deleted. * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-12-19 Ryan Haddad Repurpose bots and clean up dashboard. https://bugs.webkit.org/show_bug.cgi?id=166045 Reviewed by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: (BubbleQueueServer): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted. 2016-12-19 Michael Catanzaro [CMake] TestWebKitAPIBase links to itself https://bugs.webkit.org/show_bug.cgi?id=165985 Reviewed by Alex Christensen. Fix CMake warning about a target linking to itself, which makes no sense. * TestWebKitAPI/CMakeLists.txt: 2016-12-19 Michael Catanzaro [GTK] GtkDoc build should be quieter https://bugs.webkit.org/show_bug.cgi?id=165994 Reviewed by Carlos Garcia Campos. Make it not print by default. * gtk/generate-gtkdoc: (get_generator_for_config): (generate_doc): * gtk/gtkdoc.py: (GTKDoc._run_command): (GTKDoc._copy_doc_files_to_output_dir): 2016-12-18 Simon Fraser Expose a way for MiniBrowser to simulate header and footer banners https://bugs.webkit.org/show_bug.cgi?id=166005 Reviewed by Wenson Hsieh. Add a MiniBrowser menu item and setting to toggle adding space for header and footer banners. This only works in WebKit2. We need to reset these on each navigation, since newly created FrameViews don't re-fetch the header and footer height stored on Page. Also fix the signature of webView:didFinishNavigation: to follow API changes, as well as fixing webViewWebContentProcessDidTerminate: * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleReserveSpaceForBanners:]): (-[SettingsController isSpaceReservedForBanners]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): (-[WK2BrowserWindowController webView:didFinishNavigation:]): (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]): (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted. (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted. 2016-12-17 Simon Fraser Fix iOS test results after r209967. Subtracting out the status bar height was erroneously happening for all tests, not just for flexible viewport tests. Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame(). * WebKitTestRunner/PlatformWebView.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: (WTR::PlatformWebView::resizeTo): (WTR::PlatformWebView::setWindowFrame): * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::resizeTo): (WTR::PlatformWebView::setWindowFrame): * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::resizeTo): (WTR::PlatformWebView::setWindowFrame): * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformConfigureViewForTest): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::resizeTo): (WTR::PlatformWebView::setWindowFrame): 2016-12-17 Joonghun Park [EFL] bump EFL version to 1.18.4 https://bugs.webkit.org/show_bug.cgi?id=166004 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1. 2016-12-17 Wenson Hsieh Visual viewports: bottom fixed elements disappear behind the keyboard https://bugs.webkit.org/show_bug.cgi?id=165983 Reviewed by Simon Fraser. Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of the keyboard when it is up. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::inputViewBounds): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::inputViewBounds): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::viewRectForWindowRect): Previously, we accounted for the status bar height by translating the entire web view down by the height of the status bar. However, we did not shrink the height of the web view itself, which means that for tests which involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window. (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::setWindowFrame): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::inputViewBounds): 2016-12-16 Ryosuke Niwa Deleting a character converted from pinyin after an image causes a Safari crash https://bugs.webkit.org/show_bug.cgi?id=165839 Reviewed by Wenson Hsieh. Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView while the proposed range contains an image. This should not cause a WebProcess to crash or send an invalid message to the UIProcess. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added. * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added. (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::processDidCrash): (TestWebKitAPI::invalidMessageFunction): (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage): 2016-12-16 Wenson Hsieh Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements https://bugs.webkit.org/show_bug.cgi?id=165767 Reviewed by Simon Fraser. Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See WebKit2 ChangeLog for more details. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::doAfterNextStablePresentationUpdate): (WTR::UIScriptController::textSelectionCaretRect): * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::doAfterNextStablePresentationUpdate): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::doAfterNextStablePresentationUpdate): (WTR::UIScriptController::textSelectionCaretRect): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView _setStableStateOverride:]): Force the WKWebView to update its visible content rects when changing the stable state override. * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::toNSDictionary): (WTR::UIScriptController::doAfterNextStablePresentationUpdate): (WTR::UIScriptController::selectionRangeViewRects): (WTR::UIScriptController::textSelectionCaretRect): * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::doAfterNextStablePresentationUpdate): 2016-12-15 Brent Fulgham Arguments called in wrong order https://bugs.webkit.org/show_bug.cgi?id=165923 Reviewed by Simon Fraser. The 'audioDeviceUIDs' array is being passed to the argument that expects video devices, and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this. * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The order of arguments to WKUserMediaPermissionRequestAllow are flipped. 2016-12-16 Hunseop Jeong [EFL] Disable non-srcdir builds for failing libraries https://bugs.webkit.org/show_bug.cgi?id=165896 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: Set non srcdir builds to no 2016-12-15 Daniel Bates check-style should not complain about code in icu directories https://bugs.webkit.org/show_bug.cgi?id=53929 Reviewed by Darin Adler. Skip style checking of imported ICU headers to avoid a deluge of style issues as they do not conform to the WebKit Code Style guideline. We want to preserve the formatting of these headers so as to make it straightforward to merge changes to them, if necessary. * Scripts/webkitpy/style/checker.py: 2016-12-15 Alexey Proskuryakov Move JSC testers from Yosemite to Sierra https://bugs.webkit.org/show_bug.cgi?id=165925 Reviewed by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): 2016-12-15 Megan Gardner Add coordinate space to event streams and streamline tests https://bugs.webkit.org/show_bug.cgi?id=165119 Reviewed by Simon Fraser. Update event streams to allow for both content and global coordinate space. Update example script to more accurately show all the available options. * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * WebKitTestRunner/ios/HIDEventGenerator.h: * WebKitTestRunner/ios/HIDEventGenerator.mm: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::convertCoordinates): (WTR::UIScriptController::sendEventStream): 2016-12-15 Claudio Saavedra [GTK] Ensure gst* docs are not built with update-webkitgtk-libs https://bugs.webkit.org/show_bug.cgi?id=165855 Reviewed by Philippe Normand. GStreamer's autogen.sh enables gtk-doc always so we end up building docs even if we disable them. Use the configure script instead, since we build from packages and these include it already. * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for upstream gstreamer packages. 2016-12-15 Alex Christensen REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix https://bugs.webkit.org/show_bug.cgi?id=165885 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::utf16String): Deleted. * TestWebKitAPI/Tests/mac/PublicSuffix.mm: (TestWebKitAPI::TEST_F): * TestWebKitAPI/WTFStringUtilities.h: (utf16String): Moved from URLParser to share with other tests. 2016-12-14 Ryosuke Niwa iOS: An element with tabindex is not focusable unless there is no mouse event handler https://bugs.webkit.org/show_bug.cgi?id=165843 Reviewed by Antti Koivisto. Add testRunner.isWebKit2 which is always true in WebKitTestRunner. Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner, and DumpRenderTree's runUIScript would hit an assertion :( * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::isWebKit2): 2016-12-14 Brady Eidson IndexedDB 2.0: Massively speedup IDBIndex.get(). https://bugs.webkit.org/show_bug.cgi?id=165802 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added. 2016-12-14 Carlos Alberto Lopez Perez [GTK][EFL] Update the JHBuild version. https://bugs.webkit.org/show_bug.cgi?id=165838 Reviewed by Michael Catanzaro. * jhbuild/jhbuild-wrapper: This new version fixes a bug with the usage of the JHBUILD_MIRROR feature with git repositories. 2016-12-14 Carlos Alberto Lopez Perez [GTK] Yasm is needed for building the JHBuild after r208940 https://bugs.webkit.org/show_bug.cgi?id=165837 Reviewed by Alejandro G. Castro. * gtk/install-dependencies: Yasm is needed for building libvpx. 2016-12-14 Youenn Fablet Test infrastructure should allow to filter out text output before doing a comparison with the baseline https://bugs.webkit.org/show_bug.cgi?id=161310 Reviewed by Ryosuke Niwa. Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR. When set, WTR and DRT output JS console log in the stderr and not the test output. This allows removing potentially flaky information while still being able to read it for investigation. Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier. Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations. This test should have this option when fetch API will start logging resource loader errors. * DumpRenderTree/DumpRenderTree.h: (TestCommand::TestCommand): Deleted. * DumpRenderTree/DumpRenderTreeCommon.cpp: (parseInputLine): * DumpRenderTree/TestRunner.h: (TestRunner::setDumpJSConsoleLogInStdErr): (TestRunner::dumpJSConsoleLogInStdErr): * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:withSource:]): * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole): * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser._tokenize_line): * Scripts/webkitpy/port/driver.py: (Driver._command_from_driver_input): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::InjectedBundle::dumpToStdErr): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::dumpJSConsoleLogInStdErr): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willAddMessageToConsole): * WebKitTestRunner/TestController.cpp: (WTR::parseInputLine): (WTR::TestController::runTest): (WTR::TestCommand::TestCommand): Deleted. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): * WebKitTestRunner/TestInvocation.h: (WTR::TestInvocation::setDumpJSConsoleLogInStdErr): 2016-12-14 Enrique Ocaña González REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early https://bugs.webkit.org/show_bug.cgi?id=164022 Reviewed by Xabier Rodriguez-Calvar. * Scripts/webkitperl/FeatureList.pm: Re-enable MEDIA_SOURCE for the GTK+ port. 2016-12-13 Alex Christensen Fix CMake build. * DumpRenderTree/PlatformMac.cmake: Define NS_RETURNS_RETAINED as nothing for now. 2016-12-13 Jer Noble Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible https://bugs.webkit.org/show_bug.cgi?id=165697 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: (TestWebKitAPI::TEST): 2016-12-13 Andy Estes [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate https://bugs.webkit.org/show_bug.cgi?id=165785 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added expectations for the text, range, and action. (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a plain-text string to the pasteboard, executed a paste action, and verified that the selected text in the web view did not change. * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle parameter. (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]): Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy and returned the value of _editingDelegateShouldInsertText. * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared -shouldInsertText:replacingRange:givenAction:. 2016-12-13 Chris Dumez Unreviewed, rolling out r209544. Looks like r209489 did not cause the performance regression after all Reverted changeset: "Unreviewed, rolling out r209489." https://bugs.webkit.org/show_bug.cgi?id=165550 http://trac.webkit.org/changeset/209544 2016-12-12 Sam Weinig [WebIDL] Remove use of Dictionary in ApplePaySession https://bugs.webkit.org/show_bug.cgi?id=165787 Reviewed by Anders Carlsson. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): (WTR::TestController::platformCreateWebView): Enable ApplePay for the tests (where supported). 2016-12-13 Eric Carlson Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag https://bugs.webkit.org/show_bug.cgi?id=165251 Reviewed by Youenn Fablet. * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which the preferences have been set. 2016-12-08 Antti Koivisto Enable network cache speculative revalidation in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=165616 Reviewed by Darin Adler. Match Safari. Also add a menu item to disable it. * MiniBrowser/mac/AppDelegate.m: (defaultConfiguration): * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController networkCacheSpeculativeRevalidationDisabled]): (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]): 2016-12-12 Alexey Proskuryakov ChangeLogs become readonly after resolving a conflict https://bugs.webkit.org/show_bug.cgi?id=165440 rdar://problem/29491002 Reviewed by Darin Adler. * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when moving the file. 2016-12-12 Filip Pizlo Re-enable collectContinuously since it doesn't crash anymore Rubber stamped by Michael Saboff. * Scripts/run-jsc-stress-tests: 2016-12-11 Konstantin Tokarev Unreviewed attempt to fix EFL and Mac/cmake builds after r209665. https://bugs.webkit.org/show_bug.cgi?id=165686 * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target so that right config.h comes first in include path. 2016-12-11 Dave Hyatt [CSS Parser] Make sure content extensions initialize AtomicString https://bugs.webkit.org/show_bug.cgi?id=165737 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::makeBackend): 2016-12-08 Dave Hyatt [CSS Parser] Remove the old CSS Parser https://bugs.webkit.org/show_bug.cgi?id=165645 Reviewed by Daniel Bates. * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: (TestWebKitAPI::TEST): 2016-12-10 Konstantin Tokarev [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them https://bugs.webkit.org/show_bug.cgi?id=165686 Reviewed by Michael Catanzaro. This change reduces duplication of include path lists between modules, and reduces future need for fixes like r209605 (broken build because of WebCore header suddenly becoming used in WebKit2). * DumpRenderTree/CMakeLists.txt: * DumpRenderTree/PlatformMac.cmake: * ImageDiff/CMakeLists.txt: * MiniBrowser/gtk/CMakeLists.txt: * MiniBrowser/mac/CMakeLists.txt: * MiniBrowser/win/CMakeLists.txt: * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformJSCOnly.cmake: * TestWebKitAPI/PlatformMac.cmake: * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: * WebKitTestRunner/CMakeLists.txt: * WebKitTestRunner/PlatformGTK.cmake: * WebKitTestRunner/PlatformMac.cmake: 2016-12-09 Csaba Osztrogonác Unreviewed buildfix after r209630. * Scripts/build-jsc: Remove building the non-existing testWASM. 2016-12-09 Eric Carlson Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag https://bugs.webkit.org/show_bug.cgi?id=165251 Reviewed by Dean Jackson. Based on a patch by Dr Alex Gouaillard * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Ditto. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setMediaStreamEnabled): New. (WTR::TestRunner::setPeerConnectionEnabled): New. * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-12-09 Brady Eidson Re-landing: Add _WKIconLoadingDelegate SPI. https://bugs.webkit.org/show_bug.cgi?id=164894 Reviewed by Alex Christensen. Add MiniBrowser support for this new SPI, configurable with a setting. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController loadsAllSiteIcons]): (-[SettingsController toggleLoadsAllSiteIcons:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]): (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 2016-12-09 Ryan Haddad Fix the 32-bit build. Unreviewed build fix. * MiniBrowser/mac/SettingsController.h: 2016-12-09 Gustavo Noronha Silva Fedora also needs a PHP7 config file alternative https://bugs.webkit.org/show_bug.cgi?id=165606 Reviewed by Michael Catanzaro. * Scripts/webkitpy/port/base.py: (Port._is_fedora_php_version_7): check for the php7 library. (Port._fedora_php_version): get the appropriate filename for Fedora. (Port._apache_config_file_name_for_platform): 2016-12-09 Ryan Haddad Complete the revert of r208865. https://bugs.webkit.org/show_bug.cgi?id=164894 Unreviewed build fix. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController loadsAllSiteIcons]): Deleted. (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]): (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted. 2016-12-09 Gustavo Noronha Silva [GTK] Force GDK backend to x11 when running with XvfbDriver https://bugs.webkit.org/show_bug.cgi?id=165612 Reviewed by Michael Catanzaro. When the developer is running a Wayland session, GDK may get confused and try to use its Wayland backend (which is higher priority) instead. This ensures it will use the appropriate backend when running under Xvfb. * Scripts/webkitpy/port/gtk.py: (GtkPort.setup_environ_for_server): when running with XvfbDriver, force GDK_BACKEND to x11. 2016-12-08 Keith Miller Add 64-bit signed LEB decode method https://bugs.webkit.org/show_bug.cgi?id=165630 Reviewed by Ryosuke Niwa. Add tests for LEB int64 and uint64 decode since I guess I forgot to add tests before. * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: (TestWebKitAPI::testUInt32LEBDecode): (TestWebKitAPI::TEST): (TestWebKitAPI::testUInt64LEBDecode): (TestWebKitAPI::testInt32LEBDecode): (TestWebKitAPI::testInt64LEBDecode): (TestWebKitAPI::testUnsignedLEBDecode): Deleted. 2016-12-08 Filip Pizlo Make it easy to enable --force-collectContinuously https://bugs.webkit.org/show_bug.cgi?id=165638 Reviewed by Keith Miller. * Scripts/run-javascriptcore-tests: (runJSCStressTests): 2016-12-08 Filip Pizlo Disable the collectContinuously mode until I investigate failures. Rubber stamped by Keith Miller. I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode while I investigate. * Scripts/run-jsc-stress-tests: 2016-12-08 Alex Christensen REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL https://bugs.webkit.org/show_bug.cgi?id=165621 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-12-06 Filip Pizlo Concurrent GC should be stable enough to land enabled https://bugs.webkit.org/show_bug.cgi?id=164990 Reviewed by Geoffrey Garen. Add a new mode that runs GC continuously. Also made eager modes run GC continuously. It's clear that this works just fine in release, but I'm still trying to figure out if it's safe for debug. It might be too slow for debug. * Scripts/run-jsc-stress-tests: 2016-12-08 Alex Christensen Add SPI for sending WebsiteSettings to WebProcess during navigation https://bugs.webkit.org/show_bug.cgi?id=165517 Reviewed by Anders Carlsson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added. (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): (TEST): 2016-12-08 Chris Dumez Unreviewed, rolling out r209489. Likely caused large regressions on JetStream, Sunspider and Speedometer Reverted changeset: "Add system trace points for JavaScript VM entry/exit" https://bugs.webkit.org/show_bug.cgi?id=165550 http://trac.webkit.org/changeset/209489 2016-12-08 Keith Miller Move LEB tests to API tests https://bugs.webkit.org/show_bug.cgi?id=165586 Reviewed by Saam Barati. Move the tests from testWasm.cpp and make them functions rather than macros. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added. (TestWebKitAPI::testUnsignedLEBDecode): (TestWebKitAPI::TEST): (TestWebKitAPI::testInt32LEBDecode): 2016-12-08 Chris Dumez Support running the layout tests offline https://bugs.webkit.org/show_bug.cgi?id=165534 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/common/system/autoinstall.py: (AutoInstaller._download_to_stream): getcode() returns None for file URLs so handle this. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._install_modules): Deal with local path in the json file and resolve them into file URLs before using AutoInstall. 2016-12-08 Alex Christensen Fix CMake build. * DumpRenderTree/PlatformMac.cmake: Remove CheckedMalloc.cpp after r209516. 2016-12-07 Mark Lam DumpRenderTree should stop using CheckedMalloc. https://bugs.webkit.org/show_bug.cgi?id=165563 Reviewed by Geoffrey Garen. 1. WebKitTestRunner does not have equivalent behavior to that which is implemented in CheckedMalloc. 2. bmalloc does not honor the settings of CheckedMalloc. The only time CheckedMalloc comes into play is when DRT uses gmalloc or system malloc. As a result, DRT exhibits different behavior from the normal way we run our tests. We should obsolete CheckedMalloc and make DRT behave consistently with WKTR. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/mac/CheckedMalloc.cpp: Removed. * DumpRenderTree/mac/CheckedMalloc.h: Removed. * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment): 2016-12-07 Dean Jackson Remove runtime toggle for pointer-lock https://bugs.webkit.org/show_bug.cgi?id=165577 Reviewed by Jon Lee. Remove any runtime calls to check if pointer-lock is enabled. It's either compiled in or out. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2016-12-07 Eric Carlson [MediaStream][Mac] Revoke sandbox extensions when capture ends https://bugs.webkit.org/show_bug.cgi?id=165476 Reviewed by Brady Eidson. Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy is reset and recreated when a web page exits and is reloaded. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added. (TestWebKitAPI::checkUserMediaPermissionCallback): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added. 2016-12-07 Jeremy Jones One esc to exit fullscreen and pointer lock https://bugs.webkit.org/show_bug.cgi?id=165416 rdar://problem/29430711 Reviewed by Jer Noble. Implement WKPageUIClientV8 for pointer lock support. Add "escape" key support in EventSenderProxy. * WebKitTestRunner/TestController.cpp: (WTR::requestPointerLock): (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::keyDown): 2016-12-07 Simon Fraser Add system trace points for JavaScript VM entry/exit https://bugs.webkit.org/show_bug.cgi?id=165550 Reviewed by Tim Horton. Add trace points for entry/exit into/out of the JS VM. * Tracing/SystemTracePoints.plist: 2016-12-07 ChangSeok Oh [GTK] Cannot build GTK+ with CUPS 2.* versions https://bugs.webkit.org/show_bug.cgi?id=163591 Reviewed by Michael Catanzaro. GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4 does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration. GTK+ upstream fixed this issue but it is not easy to apply the original patch to our old gtk+ since it requires not only bumping up glib accordingly and its consequence causes many printing test failures. So, I propose to fix the configuration issue by applying the change to the configure file directly. By doing this, we don't need to upgrade glib and worry about any test failures as a consequence of the upgraded glib. * gtk/jhbuild.modules: * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added. 2016-12-07 Simon Fraser Fix use of enum in a WK2 C SPI header. rdar://problem/28725583 Followup to correctly prefix the enum values. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::prepare): 2016-12-07 Simon Fraser Fix use of enum in a WK2 C SPI header. rdar://problem/28725583 Reviewed by Dan Bernstein. Use correct enum style for a C SPI header and fix the callers. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::prepare): 2016-12-07 Wenson Hsieh Add a new project for recording and playing back editing commands in editable web content https://bugs.webkit.org/show_bug.cgi?id=165114 Reviewed by Beth Dakin. Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may then be dragged into the playback test harness. Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following steps: 1. Load the capture harness and perform test-specific editing on the web view. 2. Let originalState be a dump of the DOM at this point in time. 3. Extract the JSON-serialized editing history data and load the playback harness with this data. 4. Rewind all editing to the beginning. 5. Playback all editing to the end. 6. Dump the state of the DOM. This should be identical to originalState. * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added. * EditingHistory/EditingHistory/Info.plist: Added. * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added. * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added. * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added. * EditingHistory/EditingHistory/TestRunner.h: Added. * EditingHistory/EditingHistory/TestRunner.m: Added. (injectedMessageEventHandlerScript): (-[TestRunner init]): (-[TestRunner deleteBackwards:]): (-[TestRunner typeString:]): (-[TestRunner bodyElementSubtree]): (-[TestRunner bodyTextContent]): (-[TestRunner editingHistoryJSON]): (-[TestRunner loadPlaybackTestHarnessWithJSON:]): (-[TestRunner numberOfUpdates]): (-[TestRunner jumpToUpdateIndex:]): (-[TestRunner expectEvents:afterPerforming:]): (-[TestRunner loadCaptureTestHarness]): (-[TestRunner setTextObfuscationEnabled:]): (-[TestRunner isDoneWaitingForPendingEvents]): (-[TestRunner userContentController:didReceiveScriptMessage:]): The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses) or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness). * EditingHistory/EditingHistory/TestUtil.h: Added. * EditingHistory/EditingHistory/TestUtil.m: Added. (waitUntilWithTimeout): (waitUntil): Provides utilities for running tests. For now, this is just spinning the runloop on a given condition. * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added. * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added. (-[WKWebView loadPageFromBundleNamed:]): (-[WKWebView typeCharacter:]): (-[WKWebView keyPressWithCharacters:keyCode:]): (-[WKWebView stringByEvaluatingJavaScriptFromString:]): Provides utilities for simulating interaction in a web view. * EditingHistory/EditingHistory/main.m: Added. (main): * EditingHistory/EditingHistoryTests/Info.plist: Added. * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added. (-[RewindAndPlaybackTests setUp]): (-[RewindAndPlaybackTests tearDown]): (-[RewindAndPlaybackTests testTypingSingleLineOfText]): (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]): (-[RewindAndPlaybackTests testTypingAndDeletingText]): (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]): (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]): 2016-12-07 Philippe Normand [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good https://bugs.webkit.org/show_bug.cgi?id=165525 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: gst-plugins-good should depend on the libvpx package built within jhbuild. 2016-12-07 Philippe Normand [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0 https://bugs.webkit.org/show_bug.cgi?id=165520 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: Added missing dependency on openh264 in gst-plugins-bad, along with 2 upstream patches fixing the build against OpenSSL 1.1.0. * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added. * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added. 2016-12-06 Alexey Proskuryakov Correct SDKROOT values in xcconfig files https://bugs.webkit.org/show_bug.cgi?id=165487 rdar://problem/29539209 Reviewed by Dan Bernstein. Fix suggested by Dan Bernstein. * ContentExtensionTester/Configurations/DebugRelease.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebEditingTester/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 2016-12-06 Daniel Bates WebKitTestRunner: Plugins are disabled in new windows https://bugs.webkit.org/show_bug.cgi?id=165410 Reviewed by Alex Christensen. Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens a new window and loads a plugin will fail. We should enable plugins in all windows by default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows. Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html in WebKitTestRunner (we still need to fix ) and will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of WKBundleSetPluginsEnabled(). * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled() and make use of WKBundleOverrideBoolPreferenceForTestRunner(). 2016-12-05 Dean Jackson pointer lock needs to be feature detectable https://bugs.webkit.org/show_bug.cgi?id=165426 Reviewed by Antoine Quint. Expose the comment line to turn on/off pointer lock. * DumpRenderTree/TestOptions.h: * DumpRenderTree/TestOptions.mm: (TestOptions::TestOptions): * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): (WTR::updateTestOptionsFromTestHeader): * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::viewSupportsOptions): 2016-12-05 Jonathan Bedard Make it possible to use an existing simulator instance for one-off testing https://bugs.webkit.org/show_bug.cgi?id=164568 Reviewed by Daniel Bates. With this patch, if a simulator is currently running on the machine and '--dedicated-simulators' is not passed into the application, only one simulator instance will be used, and this instance will be the existing instance. If no simulator is running or '--dedicated-simulators' is passed to the script, previous behavior will be used. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator. (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators. (IOSSimulatorPort.setup_test_run): Don't open already running simulators. (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them. (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance. (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices. * Scripts/webkitpy/xcode/simulator.py: (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator. (Simulator.current_device): Get currently running device. 2016-12-05 Dan Bernstein Disable a crashing test on iOS. * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: 2016-12-04 Gyuyoung Kim Fix a build break on EFL since r209303. Unreviewed build fix. * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily. 2016-12-03 Yusuke Suzuki Refactor SymbolImpl layout https://bugs.webkit.org/show_bug.cgi?id=165247 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): 2016-12-03 Dan Bernstein Fixed the build after r209307. * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: (TEST): 2016-12-03 Dan Bernstein [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI https://bugs.webkit.org/show_bug.cgi?id=165276 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added. (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]): (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added. (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]): (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]): (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]): * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added. 2016-12-02 Andy Estes [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting https://bugs.webkit.org/show_bug.cgi?id=164492 Reviewed by Dan Bernstein. * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}. * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}. * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree. * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin. * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier). * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to com.apple.$(PRODUCT_NAME:rfc1034identifier). * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}. * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}. * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to com.apple.$(PRODUCT_NAME:rfc1034identifier). * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to com.apple.$(PRODUCT_NAME:rfc1034identifier). * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}. * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the value ${PRODUCT_BUNDLE_IDENTIFIER}. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to com.apple.WebKitTestRunner.InjectedBundle. * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier). * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}. * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}. 2016-12-02 Brady Eidson Make IndexedDB.WebProcessKillIDBCleanup even more reliable. https://bugs.webkit.org/show_bug.cgi?id=165330 Reviewed by Alex Christensen. The test currently nulls out a RetainPtr to try to destroy the view and kill the process. Problem is that doesn't reliably destroy the view. We should explicitly kill the process instead. Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism. e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first. * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: (TEST): 2016-12-02 Commit Queue Unreviewed, rolling out r209136. https://bugs.webkit.org/show_bug.cgi?id=165337 broke 36 webkitpy tests (Requested by mcatanzaro on #webkit). Reverted changeset: "Make it possible to use an existing simulator instance for one-off testing" https://bugs.webkit.org/show_bug.cgi?id=164568 http://trac.webkit.org/changeset/209136 2016-12-02 Chris Dumez [Mac][WK1] Implement new HTML interactive form validation user interface https://bugs.webkit.org/show_bug.cgi?id=164483 Reviewed by Simon Fraser. Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble") on Mac DRT as this is needed by the HTML form validation layout tests. * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::contentsOfUserInterfaceItem): 2016-12-02 Brady Eidson IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout. https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001 Reviewed by Alexey Proskuryakov. These tests had "run-loop races." The test spins the runloop waiting for one message. Two messages might come in from the WebProcess in short succession, and both be delivered to the UIProcess in the same spin of the runloop. Therefore by the time the test stops spinning the runloop, notified that a message was received, the first message has been overwritten by the second. These tests are fixed by queueing the incoming messages instead of just storing one. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]): (getNextMessage): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]): (getNextMessage): (TEST): 2016-12-01 Jiewen Tan Add a runtime flag for SubtleCrypto https://bugs.webkit.org/show_bug.cgi?id=164982 Reviewed by Brent Fulgham. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setSubtleCryptoEnabled): * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-12-01 Alexey Proskuryakov Remove webkitpy dependency on Eliza https://bugs.webkit.org/show_bug.cgi?id=164979 Reviewed by Daniel Bates. This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too! * Scripts/webkitpy/thirdparty/__init__.py: * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to test buildbot instead of eliza. * Scripts/webkitpy/tool/bot/ircbot.py: * Scripts/webkitpy/tool/bot/ircbot_unittest.py: 2016-12-01 Beth Dakin Force clicking tests fail on some machines https://bugs.webkit.org/show_bug.cgi?id=165263 Reviewed by Tim Horton. Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on the user account having this feature enabled. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): 2016-12-01 Yusuke Suzuki Introduce StringImpl::StaticStringImpl with constexpr constructor https://bugs.webkit.org/show_bug.cgi?id=165093 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): 2016-11-30 Antoine Quint [Modern Media Controls] Add an HTML comment flag to turn the feature on https://bugs.webkit.org/show_bug.cgi?id=165226 Reviewed by Dean Jackson. Add a new flag to turn Modern Media Controls on in the test runners. * DumpRenderTree/TestOptions.h: * DumpRenderTree/TestOptions.mm: (TestOptions::TestOptions): * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): (WTR::updateTestOptionsFromTestHeader): * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::viewSupportsOptions): 2016-11-30 Said Abou-Hallawa Add separate settings and preferences to enable/disable async decoding for large images and animated images https://bugs.webkit.org/show_bug.cgi?id=165177 Reviewed by Simon Fraser. Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleLargeImageAsyncDecodingEnabled:]): (-[SettingsController largeImageAsyncDecodingEnabled]): (-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]): (-[SettingsController animatedImageAsyncDecodingEnabled]): (-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted. (-[SettingsController asyncImageDecodingEnabled]): Deleted. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController didChangeSettings]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): 2016-11-30 Jonathan Bedard Make it possible to use an existing simulator instance for one-off testing https://bugs.webkit.org/show_bug.cgi?id=164568 Reviewed by Daniel Bates. With this patch, if a simulator is currently running on the machine and '--dedicated-simulators' is not passed into the application, only one simulator instance will be used, and this instance will be the existing instance. If no simulator is running or '--dedicated-simulators' is passed to the script, previous behavior will be used. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator. (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators. (IOSSimulatorPort.setup_test_run): Don't open already running simulators. (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them. (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance. (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices. * Scripts/webkitpy/xcode/simulator.py: (Simulator.current_device): Get currently running device. 2016-11-29 Carlos Alberto Lopez Perez [Linux] run-benchmark should be able to execute the benchmarks with more browsers. https://bugs.webkit.org/show_bug.cgi?id=164792 Reviewed by Michael Catanzaro. This removes the GTKBrowserDriver (and the platform 'gtk') from the run-benchmark script, and adds a new LinuxBrowserDriver with a platform 'linux'. It add also drivers for Chrome (Chromium), Firefox, Epiphany and MiniBrowser-GTK (previously MiniBrowser). The detection of the platform is now done automatically, so it is not longer needed to pass a "--platform" parameter. The tracking of the browser process is now more robust, we track the pid of the browser process and we only try to kill the ones that were executed by this script, instead of doing a 'killall $browser' (like before). We also check for browser process childs and we kill them if they are still alive after the main browser process has been killed. This depends on psutil, so this will only be done if psutil is installed. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunBenchmarkTests.start): The platform is now autodetected and the MiniBrowser driver is renamed to MiniBrowser-GTK. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner._run_benchmark): Fix a bug that caused close_browsers to be called twice. Its already called inside BenchmarkRunner._run_one_test. * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: Added. (LinuxBrowserDriver): Implement base class that has all the needed functionality for driving the browsers. (LinuxBrowserDriver.__init__): (LinuxBrowserDriver.prepare_env): (LinuxBrowserDriver.restore_env): (LinuxBrowserDriver.close_browsers): Made the dependency on psutil optional (because it was listed as such on the README file ) (LinuxBrowserDriver.launch_url): (LinuxBrowserDriver._get_first_executable_path_from_list): (LinuxBrowserDriver._screen_size): * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py. (LinuxChromeDriver): (LinuxChromeDriver.launch_url): * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py. (EpiphanyBrowserDriver): (EpiphanyBrowserDriver.launch_url): * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py. (LinuxFirefoxDriver): (LinuxFirefoxDriver.launch_url): * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py. (GTKMiniBrowserDriver): (GTKMiniBrowserDriver.launch_url): * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: (SimpleHTTPServerDriver): * Scripts/webkitpy/benchmark_runner/run_benchmark.py: (getplatform): (getdefaultbrowser): (parse_args): * Scripts/webkitpy/benchmark_runner/utils.py: (load_subclasses): The loading of subclasses was still (even after r196979) sensitive to the order in which the modules are loaded. We have to ensure that the files containing subclasses of the base_class_file are loaded after the base_class_file, we can do that by matching against the base_class_file pattern when the list is created. 2016-11-29 Andy Estes [Cocoa] Enable two clang warnings recommended by Xcode https://bugs.webkit.org/show_bug.cgi?id=164498 Reviewed by Mark Lam. * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE. * MiniBrowser/Configurations/Base.xcconfig: Ditto. * TestWebKitAPI/Configurations/Base.xcconfig: Ditto. * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. 2016-11-29 Eric Carlson [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context https://bugs.webkit.org/show_bug.cgi?id=164760 Reviewed by Youenn Fablet. Allow scripts to determine the number of times the user has been prompted for capture device access. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin): (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin): (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin): (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted. * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin): (WTR::TestRunner::userMediaPermissionRequestCountForOrigin): (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin): (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): (WTR::OriginSettings::incrementRequestCount): (WTR::OriginSettings::resetRequestCount): (WTR::OriginSettings::requestCount): (WTR::TestController::saltForOrigin): (WTR::TestController::setUserMediaPersistentPermissionForOrigin): (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): (WTR::TestController::settingsForOrigin): (WTR::TestController::userMediaPermissionRequestCountForOrigin): (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin): (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): (WTR::TestController::setUserMediaPermissionForOrigin): Deleted. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): 2016-11-29 Simon Fraser intersection-observer-entry-interface.html test fails on the bots https://bugs.webkit.org/show_bug.cgi?id=165133 Reviewed by Darin Adler. Tests that enabled Intersection Observer via would fail sometimes, because TestController::ensureViewSupportsOptionsForTest() failed to check to see if this option required creating a new web view, so would just use the old view without even resetting preferences. In general, TestController doesn't distinguish properly between options that require the creation of a new view (like mock scrollbars), and those that can be simply reset as resetPreferencesToConsistentValues() does. Do the easy fix of having viewSupportsOptions() check options.enableIntersectionObserver. We should probably just call resetPreferencesToConsistentValues() even when re-use the same view. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::viewSupportsOptions): 2016-11-28 Ryan Haddad Unreviewed, rolling out r209008. This change appears to have caused two fast/mediastrem LayoutTests to fail. Reverted changeset: "[MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context" https://bugs.webkit.org/show_bug.cgi?id=164760 http://trac.webkit.org/changeset/209008 2016-11-28 Daniel Bates Teach webkitpy how to read CSSProperties.json r209001 https://bugs.webkit.org/show_bug.cgi?id=165108 Reviewed by Simon Fraser. Fix webkitpy logic so that it can read CSS property names from CSSProperties.json following r209001. Following r209001 CSSPropertyNames.in no longer exists as it was replaced with CSSProperties.json. We need to modify the webkitpy machinery that processed CSSPropertyNames.in to process CSSProperties.json. * Scripts/webkitpy/w3c/test_converter.py: (_W3CTestConverter.__init__): Make self._css_property_file and self._css_property_value_file local variables as it is unnecessary for them to be instance variables. Call read_webkit_prefixed_css_property_list() to read the property names from file CSSProperties.json. Call legacy_read_webkit_prefixed_css_property_list() to read CSS keyword values from CSSValueKeywords.in. (_W3CTestConverter.read_webkit_prefixed_css_property_list): Added. (_W3CTestConverter): (_W3CTestConverter.legacy_read_webkit_prefixed_css_property_list): Renamed from read_webkit_prefixed_css_property_list. * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.test_harnesslinks_conversion): Substitute CSSProperties.json for CSSPropertyNames.in. 2016-11-28 Eric Carlson [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context https://bugs.webkit.org/show_bug.cgi?id=164760 Reviewed by Youenn Fablet. Allow scripts to determine the number of times the user has been prompted for capture device access. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin): (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin): (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin): (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted. * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin): (WTR::TestRunner::userMediaPermissionRequestCountForOrigin): (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin): (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): (WTR::OriginSettings::incrementRequestCount): (WTR::OriginSettings::resetRequestCount): (WTR::OriginSettings::requestCount): (WTR::TestController::saltForOrigin): (WTR::TestController::setUserMediaPersistentPermissionForOrigin): (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): (WTR::TestController::settingsForOrigin): (WTR::TestController::userMediaPermissionRequestCountForOrigin): (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin): (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): (WTR::TestController::setUserMediaPermissionForOrigin): Deleted. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): 2016-11-18 Jer Noble Add some performance tests for various aspects of media loading and playback. https://bugs.webkit.org/show_bug.cgi?id=164977 Reviewed by Darin Adler. Allow callers to pass in extra alias/directory pairs to run-webkit-httpd. * Scripts/run-webkit-httpd: (parse_args): (main): 2016-11-27 Simon Fraser Another fix for CMake. * DumpRenderTree/TestOptions.h: * DumpRenderTree/TestOptions.mm: 2016-11-26 Simon Fraser Better fix for the Mac CMake build. * DumpRenderTree/PlatformMac.cmake: 2016-11-26 Simon Fraser Attempt to fix Mac CMake build. * DumpRenderTree/PlatformMac.cmake: 2016-11-26 Yusuke Suzuki [WTF] Import std::optional reference implementation as WTF::Optional https://bugs.webkit.org/show_bug.cgi?id=164199 Reviewed by Saam Barati and Sam Weinig. Use WTF::Optional::value_or. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::stableStateOverride): (WTR::UIScriptController::setStableStateOverride): * TestRunnerShared/Bindings/JSWrappable.h: (WTR::JSValueMakeBooleanOrNull): (WTR::JSValueToNullableBoolean): * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::stableStateOverride): (WTR::UIScriptController::setStableStateOverride): * TestRunnerShared/UIScriptContext/UIScriptController.h: * TestWebKitAPI/Tests/WTF/Optional.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: (TestWebKitAPI::testParseHTMLInteger): (TestWebKitAPI::testParseHTMLNonNegativeInteger): * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkURL): (TestWebKitAPI::checkRelativeURL): (TestWebKitAPI::checkURLDifferences): (TestWebKitAPI::checkRelativeURLDifferences): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::stableStateOverride): (WTR::UIScriptController::setStableStateOverride): 2016-11-26 Sam Weinig Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script https://bugs.webkit.org/show_bug.cgi?id=164965 Reviewed by Simon Fraser. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add new files. * DumpRenderTree/TestOptions.h: Added. * DumpRenderTree/TestOptions.mm: Added. (parseBooleanTestHeaderValue): (TestOptions::TestOptions): Port TestOption parsing from WKTR to DRT. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): (resetWebViewToConsistentStateBeforeTesting): (runTest): * WebKitTestRunner/TestController.cpp: Pass TestOptions down to resetWebPreferencesToConsistentValues to allow setting preferences conditionally. (WTR::TestController::resetPreferencesToConsistentValues): (WTR::updateTestOptionsFromTestHeader): * WebKitTestRunner/TestOptions.h: Add a new test option header, enableIntersectionObserver, to enable IntersectionObserver. 2016-11-26 Simon Fraser Migrate some layout timer-related code from std::chrono to Seconds and MonotonicTime https://bugs.webkit.org/show_bug.cgi?id=164992 Reviewed by Darin Adler. Use Seconds::zero(). * TestWebKitAPI/Tests/WTF/Condition.cpp: 2016-11-26 Simon Fraser Add literals for various time units https://bugs.webkit.org/show_bug.cgi?id=165074 Reviewed by Filip Pizlo. Add tests for new time literals. Add new tests for units. * TestWebKitAPI/Tests/WTF/Time.cpp: (TestWebKitAPI::TEST): 2016-11-25 Csaba Osztrogonác Fix compile warnings after r208415 https://bugs.webkit.org/show_bug.cgi?id=165061 Reviewed by Andy Estes. * TestWebKitAPI/Tests/WTF/Time.cpp: (TestWebKitAPI::TEST): 2016-11-24 Michael Catanzaro [GTK] Notifications API does not expose or respect the "tag" attribute https://bugs.webkit.org/show_bug.cgi?id=164771 Reviewed by Gustavo Noronha Silva. Verify that showing a notification with the same tag as another notification closes the previous notification before the new notification is shown. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewNotification): 2016-11-24 Carlos Garcia Campos Unreviewed. Fix GTK+ test /webkit2/WebKitWebContext/get-plugins after r208429. Test plugin library was renamed as libTestNetscapePlugIn.so in r208429. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextGetPlugins): Update the library name. 2016-11-22 Darin Adler Make normal case fast in the input element limitString function https://bugs.webkit.org/show_bug.cgi?id=165023 Reviewed by Dan Bernstein. * TestWebKitAPI/CMakeLists.txt: Added TextBreakIterator.cpp. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto. * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp: Added. Contains some tests for the numGraphemeClusters and numCharactersInGraphemeClusters functions that I used to make sure that the new fast paths I added work correctly. 2016-11-22 Tomas Popela Unreviewed, add myself as a WebKit committer. * Scripts/webkitpy/common/config/contributors.json: 2016-11-21 Mark Lam Hasher::addCharacters() should be able to handle zero length strings. https://bugs.webkit.org/show_bug.cgi?id=165024 Reviewed by Yusuke Suzuki. * TestWebKitAPI/Tests/WTF/StringHasher.cpp: (TestWebKitAPI::TEST): 2016-11-21 Carlos Alberto Lopez Perez [CMake] build fails after update to cmake 3.7 https://bugs.webkit.org/show_bug.cgi?id=165008 Reviewed by Dan Bernstein. When we remove the CMake cache, we should remove both the CMakeCache.txt file and the CMakeFiles directory. See: https://gitlab.kitware.com/cmake/cmake/issues/14820 * Scripts/webkitdirs.pm: (cmakeFilesPath): (removeCMakeCache): 2016-11-16 Philippe Normand [GTK][WebRTC] Switch to downstream OpenWebRTC and more recent GStreamer https://bugs.webkit.org/show_bug.cgi?id=164817 Reviewed by Alejandro G. Castro. This is temporary, hopefully. The OpenWebRTC patches will/should be soon reviewed and upstream but meanwhile it makes sense to use the Igalia downstream fork so that the WebRTC testing is easier. Recent GStreamer patches are also needed for RTP bundling support and RTP retransmission fixes. * gtk/jhbuild.modules: * gtk/openwebrtc.modules: Removed. * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Added. * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Added. * gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added. 2016-11-20 Zan Dobersek [EncryptedMedia] Make EME API runtime-enabled https://bugs.webkit.org/show_bug.cgi?id=164927 Reviewed by Jer Noble. Enable the EME API via the WKTR InjectedBundle whenever testing commences. This does not have any effect unless the EME feature is enabled at compile-time, but it's still added to match other features and for future use. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setEncryptedMediaAPIEnabled): * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-11-19 Simon Fraser Fix the Mac and iOS bulds. * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView _stableStateOverride]): (-[TestRunnerWKWebView _setStableStateOverride:]): 2016-11-18 Simon Fraser Make it possible to test non-stable-state scrolling on iOS https://bugs.webkit.org/show_bug.cgi?id=164905 Reviewed by Dan Bernstein. Make it possible for an iOS layout test to force every visible rect update from the UI process to the web process to be in a non-stable state. This emulates what happens during panning and zooming interactions, and allows us to test the scrolling and layer trees in these transient states. This is done by adding a testing property on WKWebView, _stableStateOverride, whose getters and setters are overridden in TestRunnerWKWebView. When non-nil, we _updateVisibleContentRectAfterScrollInView consults the NSNumber's boolValue and uses it to override the stable state. To facilitate this kind of testing, also add immediateScrollToOffset() and immediateZoomToScale() to UIScriptController. Finally, add doAfterPresentationUpdate() which provides a callback that fires after one trip to the web process and back. Add code generation support for optional boolean attributes in IDL. Align CodeGeneratorDumpRenderTree.pm and CodeGeneratorTestRunner.pm. * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: (_generateImplementationFile): (_platformTypeConstructor): (_returnExpression): * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::doAfterPresentationUpdate): (WTR::contentOffsetBoundedInValidRange): (WTR::UIScriptController::scrollToOffset): (WTR::UIScriptController::immediateScrollToOffset): (WTR::UIScriptController::immediateZoomToScale): (WTR::UIScriptController::stableStateOverride): (WTR::UIScriptController::setStableStateOverride): * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::doAfterPresentationUpdate): * TestRunnerShared/Bindings/JSWrappable.h: (WTR::JSValueMakeBooleanOrNull): (WTR::JSValueToNullableBoolean): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::immediateScrollToOffset): (WTR::UIScriptController::immediateZoomToScale): (WTR::UIScriptController::stableStateOverride): (WTR::UIScriptController::setStableStateOverride): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: (_classRefGetter): (_platformTypeConstructor): (_returnExpression): * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView dealloc]): (-[TestRunnerWKWebView _stableStateOverride]): (-[TestRunnerWKWebView _setStableStateOverride:]): * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformResetStateToConsistentValues): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::doAsyncTask): (WTR::UIScriptController::doAfterPresentationUpdate): (WTR::UIScriptController::zoomToScale): (WTR::UIScriptController::immediateScrollToOffset): (WTR::UIScriptController::immediateZoomToScale): (WTR::UIScriptController::stableStateOverride): (WTR::UIScriptController::setStableStateOverride): * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::doAfterPresentationUpdate): 2016-11-19 Joanmarie Diggs AX: [ATK] Expose aria-busy via ATK_STATE_BUSY https://bugs.webkit.org/show_bug.cgi?id=164909 Reviewed by Chris Fleizach. Implement boolAttributeValue() for ATK so we can test AXElementBusy. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::boolAttributeValue): 2016-11-18 Simon Fraser [iOS WK2] Eliminate a source of flakiness in layout tests by forcing WebPage into "responsive" mode for all tests, with an internals override https://bugs.webkit.org/show_bug.cgi?id=164980 Reviewed by Chris Dumez. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::prepare): 2016-11-18 Dean Jackson AX: "(inverted-colors)" media query only matches on page reload; should match on change https://bugs.webkit.org/show_bug.cgi?id=163564 Reviewed by Simon Fraser. Add a UIScriptController method that tricks WebKit into thinking it has received a notification that accessibility settings have changed. Combined with our forced overrides, this allows us to test if a page would react to the notifications. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification): * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::simulateAccessibilitySettingsChangeNotification): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification): * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification): 2016-11-18 Alex Christensen Fix API test after r208902 https://bugs.webkit.org/show_bug.cgi?id=144194 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: (TestWebKitAPI::TEST): The fullwidth solidus, U+FF0F, changed encoding from IDN2003 to IDN2008, probably to prevent domains from using it to spoof other domains. https://webkit.org/blog/ and https://webkit.org\uFF0Fblog/ would otherwise look too similar when rendered. 2016-11-17 Alex Christensen Support IDN2008 with UTS #46 instead of IDN2003 https://bugs.webkit.org/show_bug.cgi?id=144194 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): Add some tests from http://unicode.org/faq/idn.html verifying that we follow UTS46's deviations from IDN2008. Add some tests based on https://tools.ietf.org/html/rfc5893 verifying that we check for bidirectional text. Add a test based on https://tools.ietf.org/html/rfc5892 verifying that we do not do ContextO check. Add a test for U+321D and U+321E which have particularly interesting punycode encodings. We match Firefox here now. Also add a test from http://www.unicode.org/reports/tr46/#IDNAComparison verifying we are not using IDN2003. We should consider importing all of http://www.unicode.org/Public/idna/9.0.0/IdnaTest.txt as URL domain tests. 2016-11-17 Carlos Garcia Campos Downloads started by context menu actions should also have a web view associated https://bugs.webkit.org/show_bug.cgi?id=164364 Reviewed by Michael Catanzaro. Add a GTK+ unit tests to check that downloads started by the context menu have a web view associated. * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: (downloadLocalFileSuccessfully): (testDownloadOverwriteDestinationDisallowed): (testDownloadLocalFileError): (testDownloadRemoteFile): (testDownloadRemoteFileError): (testDownloadMIMEType): (contextMenuCallback): (testContextMenuDownloadActions): (beforeAll): 2016-11-17 Ryosuke Niwa Add an experimental API to find elements across shadow boundaries https://bugs.webkit.org/show_bug.cgi?id=164851 Reviewed by Sam Weinig. Added test cases for window.collectMatchingElementsInFlatTree to WebKit2.InjectedBundleMakeAllShadowRootOpen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRoot*s*Open_Bundle.cpp: Renamed from InjectedBundleMakeAllShadowRootOpen_Bundle.cpp. (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): Added test cases for window.collectMatchingElementsInFlatTree by calling alert() many times. * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: (TestWebKitAPI::runJavaScriptAlert): Added expectations for multiple test cases. Each test case finishes with a call to alert, and moves testNumber forward. (TestWebKitAPI::TEST): Use the newly added closed-shadow-tree-test.html * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Added. Creates a shadow tree with slots and tests that window.collectMatchingElementsInFlatTree is not present when an event named "testnormalworld" is dispatched by the injected bundle. 2016-11-17 Brady Eidson Add _WKIconLoadingDelegate SPI. https://bugs.webkit.org/show_bug.cgi?id=164894 Reviewed by Alex Christensen. Add MiniBrowser support for this new SPI, configurable with a setting. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController loadsAllSiteIcons]): (-[SettingsController toggleLoadsAllSiteIcons:]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]): (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 2016-11-17 Caitlin Potter [JSC] remove leftover references to ES2017_ASYNCFUNCTION_SYNTAX flag https://bugs.webkit.org/show_bug.cgi?id=164879 Reviewed by Alex Christensen. The flag was referenced in FeatureList.pm and in one of the FeatureDefines.xcconfig files, despite being removed. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-11-17 Per Arne Vollan [Win] run-api-tests is failing. https://bugs.webkit.org/show_bug.cgi?id=164818 Reviewed by Alexey Proskuryakov. Make sure Visual Studio interprets string literal as utf8. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-11-17 Yusuke Suzuki [JSC] WTF::TemporaryChange with WTF::SetForScope https://bugs.webkit.org/show_bug.cgi?id=164761 Reviewed by Saam Barati. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/SetForScope.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp. (TestWebKitAPI::TEST): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): 2016-11-16 Alexey Proskuryakov REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing https://bugs.webkit.org/show_bug.cgi?id=164572 Reviewed by Tim Horton. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetStateToConsistentValues): Use the correct constant. 2016-11-16 Yusuke Suzuki [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag https://bugs.webkit.org/show_bug.cgi?id=164827 Reviewed by Ryosuke Niwa. Enabled ES6 Modules in test runners. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setES6ModulesEnabled): * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-11-16 Simon Fraser Hard to write reliable UIScriptController scrollingTreeAsText tests https://bugs.webkit.org/show_bug.cgi?id=164764 Reviewed by Wenson Hsieh. Fix one cause of flakiness by resetting the WKWebView's UIScrollView scale and scroll position between tests. * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformResetStateToConsistentValues): 2016-11-16 Simon Fraser UIScriptController: script with no async tasks fails if an earlier script registered a callback https://bugs.webkit.org/show_bug.cgi?id=164762 Reviewed by Wenson Hsieh. Make TestRunner::callUIScriptCallback() async in DumpRenderTree to match WebKitTestRunner behavior. This fixes ui-side-script-with-callback.html in WK1, which failed because the second runUIScript() would occur inside the completion callback from the first. This no longer happens. * DumpRenderTree/TestRunner.cpp: (TestRunner::callUIScriptCallback): * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback): 2016-11-16 Ryan Haddad Unreviewed, rolling out r208770. The test added with this change is timing out on mac-wk1. Reverted changeset: "UIScriptController: script with no async tasks fails if an earlier script registered a callback" https://bugs.webkit.org/show_bug.cgi?id=164762 http://trac.webkit.org/changeset/208770 2016-11-16 Per Arne Vollan [Win] WebCore test is failing. https://bugs.webkit.org/show_bug.cgi?id=164772 Reviewed by Brent Fulgham. The value of CGRectInfinite is not the same on Windows as on Mac. * TestWebKitAPI/Tests/WebCore/FloatRect.cpp: (TestWebKitAPI::TEST): 2016-11-15 Alexey Proskuryakov Update Youenn's e-mail addresses. * Scripts/webkitpy/common/config/contributors.json: 2016-11-15 Simon Fraser UIScriptController: script with no async tasks fails if an earlier script registered a callback https://bugs.webkit.org/show_bug.cgi?id=164762 Reviewed by Wenson Hsieh. UIScriptContext::runUIScript() considers a script to be "immediate" if that script doesn't queue any async tasks. However, if an earlier UI script registered a callback, UIScriptContext::runUIScript() would consider that an outstanding task. Fix by unregistering any callbacks associated with the current UI script when uiScriptComplete() is called. * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback): 2016-11-15 Simon Fraser UIScriptController: setting a callback to undefined should unregister it https://bugs.webkit.org/show_bug.cgi?id=164796 Reviewed by Dean Jackson. "Immediate" UI scripts (those that don't schedule any async tasks) should return immediately, without the need to call uiScriptComplete(). However, this is broken if an earlier UI script registered a callback (since no-one clears that callback after the first script completes). Make possible the workaround of setting the callback to undefined, which previously did not clear the callback registration. * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: (UIScriptContext::registerCallback): * TestRunnerShared/UIScriptContext/UIScriptContext.h: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::platformClearAllCallbacks): 2016-11-14 Mark Lam Enhance run-jsc-stress-test script to allow optional test specific options to be added for all test run configurations. https://bugs.webkit.org/show_bug.cgi?id=164695 Reviewed by Keith Miller. This gives us more flexibility when specific tests needs to enable special JSC options in order to exercise specific code paths to be tested. It also saves us from having to create duplicate test run configurations e.g. runMiscFTLNoCJITTest. We can now just use runFTLNoCJIT in its place. Also replaced the ifJSCArgIsntProvidedAreWeReleaseBuild variable with $buildType so that we have the ability to skip certain tests for release or debug builds. This will be needed in the upcoming patch for https://webkit.org/b/155145. * Scripts/run-jsc-stress-tests: 2016-11-14 Joanmarie Diggs AX: [ATK] Expose STATE_SINGLE_LINE and STATE_MULTI_LINE for ARIA searchbox role https://bugs.webkit.org/show_bug.cgi?id=164712 Reviewed by Chris Fleizach. Add AccessibilityUIElement::isSingleLine, AccessibilityUIElement::isMultiLine to DRT and WKTR. Implement it for ATK. * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::isSingleLine): (AccessibilityUIElement::isMultiLine): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isSingleLine): (AccessibilityUIElement::isMultiLine): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isSingleLine): (AccessibilityUIElement::isMultiLine): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::isSingleLine): (WTR::AccessibilityUIElement::isMultiLine): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::isSingleLine): (WTR::AccessibilityUIElement::isMultiLine): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::isSingleLine): (WTR::AccessibilityUIElement::isMultiLine): 2016-11-14 Youenn Fablet Support WPT templated tests https://bugs.webkit.org/show_bug.cgi?id=164707 Reviewed by Sam Weinig. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.write_html_files_for_templated_js_tests): Generating empty HTML files for templated JS tests. (TestImporter.import_tests): 2016-11-13 JF Bastien Implement WTF::Expected https://bugs.webkit.org/show_bug.cgi?id=164526 Reviewed by Yusuke Suzuki. std::expected isn't in C++17, and may be in C++20. It's a nice complement to std::any / std::optional because it's a type-tagged union which has a single expected result but could also contain an error. This would be useful in the WebAssembly parser, for example. Using this implementation will allow us to provide feedback to the standards committee and guide std::expected's design before it gets standardized. I've already sent a bunch of feedback to the author based on my experience implementing this. This could supplement WTF::Either and WTF::ExceptionOr. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/Expected.cpp: Added. (WTF::operator<<): (TestWebKitAPI::TEST): (TestWebKitAPI::foo::foo): (TestWebKitAPI::foo::~foo): (TestWebKitAPI::foo::operator==): (TestWebKitAPI::operator<<): 2016-11-12 Simon Fraser Add a way to get the UI-side scrolling tree as text via UIScriptController https://bugs.webkit.org/show_bug.cgi?id=164697 Reviewed by Zalan Bujtas. Add UIScriptController::scrollingTreeAsText(), which gets the state of the scrolling tree in the UI process, including the current positions of CALayers. This will be used to test UI-side scrolling and visual viewports. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::scrollingTreeAsText): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::scrollingTreeAsText): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::scrollingTreeAsText): 2016-11-12 Wenson Hsieh The main content heuristic should be robust when handling large media elements https://bugs.webkit.org/show_bug.cgi?id=164676 Reviewed by Eric Carlson. Added a new test verifying that enormous video elements are handled gracefully when put through the main content heuristic. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Added. 2016-11-12 Dan Bernstein run-safari does not work for open source contributors https://bugs.webkit.org/show_bug.cgi?id=164667 Reviewed by Joseph Pecoraro. * Scripts/run-api-tests: (archCommandLineArgumentsForRestrictedEnvironmentVariables): Moved from here… * Scripts/webkitdirs.pm: (archCommandLineArgumentsForRestrictedEnvironmentVariables): …to here (runMacWebKitApp): Have arch(1) carry the DYLD_* variables we set in our environmet over to the environment of the app being run. 2016-11-11 Joseph Pecoraro Removed unused INCLUDE_OPTIONS_FOR_DEBUGGING https://bugs.webkit.org/show_bug.cgi?id=164664 Reviewed by Dan Bernstein. * Scripts/debug-minibrowser: * Scripts/debug-safari: * Scripts/debug-test-runner: * Scripts/webkitdirs.pm: (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): There are no debug specific options anymore. 2016-11-11 Wenson Hsieh [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements https://bugs.webkit.org/show_bug.cgi?id=164538 Reviewed by Ryosuke Niwa. Adds support for being able to test autocorrect and autocapitalize attributes in contenteditable areas. To do this, we add removeAllDynamicDictionaries to UIScriptController in order to ensure that autocorrect suggestions are reset to their defaults prior to running contenteditable-autocorrect-off.html. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::removeAllDynamicDictionaries): * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort._createSimulatorApp): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::removeAllDynamicDictionaries): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView _keyboardDidShow:]): (-[TestRunnerWKWebView _keyboardDidHide:]): Work around an issue where consecutive UIKeyboardDidShowNotification would cause keyboard appearance callbacks to be fired multiple times. This was causing a single key press to cause two characters to be typed. While this does not affect the correctness of existing tests, the new autocorrection test requires this workaround. * WebKitTestRunner/ios/UIKitSPI.h: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): (WTR::UIScriptController::removeAllDynamicDictionaries): 2016-11-11 Alex Christensen Build all Mac API tests https://bugs.webkit.org/show_bug.cgi?id=164633 Reviewed by Gyuyoung Kim. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: 2016-11-11 Alex Christensen Allow mutable lambdas in HashMap::ensure https://bugs.webkit.org/show_bug.cgi?id=164642 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): 2016-11-10 Wenson Hsieh Composition state should be cleared when changing focus to a non-editable element https://bugs.webkit.org/show_bug.cgi?id=164595 Reviewed by Enrica Casucci. Adds support for window.textInputController in DumpRenderTree on iOS. So far, only the methods needed for the new layout test (editing/focus-change-with-marked-text.html) are supported. These are insertText, setMarkedText, and markedRange. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TextInputController.h: Renamed from Tools/DumpRenderTree/mac/TextInputController.h. Remove the PLATFORM(MAC) guard for defining the TextInputController. Also, move the TextInputController header out of the /mac platform directory. * DumpRenderTree/ios/TextInputControllerIOS.m: Added. (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController initWithWebView:]): (-[TextInputController markedRange]): (-[TextInputController insertText:]): (-[TextInputController setMarkedText:selectedFrom:length:]): Introduces TextInputControllerIOS.m, which contains an iOS implementation of TextInputController. Only a subset of the methods available on the Mac version will be available on iOS for now (see above). * DumpRenderTree/mac/FrameLoadDelegate.mm: Remove the PLATFORM(MAC) guard for initializing the TextInputController and binding it to the window object. (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): * DumpRenderTree/mac/TextInputControllerMac.m: Renamed from Tools/DumpRenderTree/mac/TextInputController.m. (-[WebHTMLView interpretKeyEvents:]): (-[WebNSRange initWithNSRange:]): (-[WebNSRange location]): (-[WebNSRange length]): (+[WebNSRange isSelectorExcludedFromWebScript:]): (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]): (+[NSMutableAttributedString webScriptNameForSelector:]): (-[NSMutableAttributedString getLength]): (-[NSMutableAttributedString ranges]): (-[NSMutableAttributedString attributeNamesAtIndex:]): (-[NSMutableAttributedString valueOfAttribute:atIndex:]): (-[NSMutableAttributedString addAttribute:value:]): (-[NSMutableAttributedString addAttribute:value:from:length:]): (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:]): (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:from:length:]): (-[NSMutableAttributedString addFontAttribute:fontName:size:]): (-[NSMutableAttributedString addFontAttribute:fontName:size:from:length:]): (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController initWithWebView:]): (-[TextInputController dealloc]): (-[TextInputController textInput]): (-[TextInputController insertText:]): (-[TextInputController doCommand:]): (-[TextInputController setMarkedText:selectedFrom:length:]): (-[TextInputController unmarkText]): (-[TextInputController hasMarkedText]): (-[TextInputController conversationIdentifier]): (-[TextInputController substringFrom:length:]): (-[TextInputController attributedSubstringFrom:length:]): (-[TextInputController legacyAttributedString:]): (-[TextInputController markedRange]): (-[TextInputController selectedRange]): (-[TextInputController firstRectForCharactersFrom:length:]): (-[TextInputController characterIndexForPointX:Y:]): (-[TextInputController validAttributesForMarkedText]): (-[TextInputController attributedStringWithString:]): (-[TextInputController stringWithUndoGroupingInsertion:]): (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]): (-[TextInputController setInputMethodHandler:]): (-[TextInputController interpretKeyEvents:withSender:]): Fixes miscellaneous style issues. 2016-11-11 Philippe Normand [GTK][JHbuild] bump libnice version in openwebrtc.modules https://bugs.webkit.org/show_bug.cgi?id=164586 Reviewed by Michael Catanzaro. Update to a recent libnice git snapshot and remove patches already upstream or not applying anymore. The patches not upstream yet will be reported in Phabricator. * gtk/openwebrtc.modules: * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Removed. * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Removed. * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Removed. * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Removed. * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Removed. 2016-11-10 Alex Christensen Fix assertion after r208534. https://bugs.webkit.org/show_bug.cgi?id=160497 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added. (TestWebKitAPI::TEST): Add a regression test. 2016-11-10 Chris Dumez REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=164570 Reviewed by Simon Fraser. Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to avoid flakiness. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): 2016-11-10 Miguel Gomez Unreviewed. Added myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2016-10-27 Sergio Villar Senin [GTK] New API to notify about dynamically added forms https://bugs.webkit.org/show_bug.cgi?id=164050 Reviewed by Carlos Garcia Campos. Added a new test case to verify that dinamically added forms correctly trigger the "form-controls-associated" signal from WebPage. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: (didAssociateFormControlsCallback): (testWebExtensionFormControlsAssociated): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (DelayedSignal::DelayedSignal): (emitFormControlsAssociated): (formControlsAssociatedCallback): (pageCreatedCallback): 2016-11-09 Ryosuke Niwa WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange https://bugs.webkit.org/show_bug.cgi?id=164501 Reviewed by Sam Weinig. * DumpRenderTree/mac/TextInputController.m: (-[TextInputController legacyAttributedString:]): 2016-11-09 Chris Dumez [WK2][NETWORK_SESSION] Add support for downloading file backed blobs https://bugs.webkit.org/show_bug.cgi?id=164458 Reviewed by Darin Adler. Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout tests can request that such resources are downloaded instead of being ignored. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForNavigationResponse): * WebKitTestRunner/TestController.h: (WTR::TestController::setShouldDownloadUndisplayableMIMETypes): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2016-11-09 Carlos Garcia Campos NetworkSession: Network process crash when converting main resource to download https://bugs.webkit.org/show_bug.cgi?id=164220 Reviewed by Alex Christensen. Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is converted to a download and another one to test the cancellation as the test was doing before. When doing the full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a download. * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: (testPolicyResponseDownload): (testPolicyResponseDownloadCancel): (beforeAll): 2016-11-09 KwangHyuk Kim [EFL] fix error message caused by eina log https://bugs.webkit.org/show_bug.cgi?id=164546 Reviewed by Gyuyoung Kim. Fix error message caused by eina log when MiniBrowser is working with help option. * MiniBrowser/efl/main.c: (quit): 2016-11-09 Brent Fulgham Unreviewed build fix after r208509. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::setNeedsStorageAccessFromFileURLsQuirk): Add missing TestRunner implementation." 2016-11-09 Alex Christensen Unreviewed, rolling out r208438. crashes Reverted changeset: "[WK2][NETWORK_SESSION] Add support for downloading file backed blobs" https://bugs.webkit.org/show_bug.cgi?id=164458 http://trac.webkit.org/changeset/208438 2016-11-04 Brent Fulgham Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked https://bugs.webkit.org/show_bug.cgi?id=155185 Reviewed by Brady Eidson. * DumpRenderTree/TestRunner.cpp: (setNeedsLocalStorageQuirkCallback): Added. (TestRunner::staticFunctions): * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Update for new quirk setting. * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setNeedsLocalStorageQuirk): * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Added. (-[LocalStorageQuirkMessageHandler userContentController:didReceiveScriptMessage:]): * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Update for new quirk setting. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setNeedsLocalStorageQuirk): Added. * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-11-09 Alex Christensen URLParser should not consider path of URLs with no host to start at the first slash after the colon https://bugs.webkit.org/show_bug.cgi?id=164555 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-11-09 Jonathan Bedard test-webkitpy failing test_create_patch_is_full_patch unit test https://bugs.webkit.org/show_bug.cgi?id=164385 Reviewed by Darin Adler. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Fixed expected output to match output. 2016-11-09 Chris Dumez [Mac] Stop using deprecated AppKit enumeration values https://bugs.webkit.org/show_bug.cgi?id=164494 Reviewed by Darin Adler. Stop using deprecated AppKit enumeration values. * DumpRenderTree/mac/EventSendingController.mm: (eventTypeForMouseButtonAndAction): (modifierFlags): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController contextClick]): (-[EventSendingController keyDown:withModifiers:withLocation:]): * DumpRenderTree/mac/TextInputController.m: (-[TextInputController interpretKeyEvents:withSender:]): * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: (simulateCommandArrow): * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: (UserInitiatedActionTest::SetUp): (UserInitiatedActionTest::click): * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: (TestWebKitAPI::AcceptsFirstMouse::runTest): * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: (TestWebKitAPI::contextMenuCopyLink): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: (TestWebKitAPI::FullscreenZoomInitialFrame::runTest): * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: (TestWebKitAPI::Util::isKeyDown): * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::initialize): (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): (TestWebKitAPI::PlatformWebView::simulateRightClick): (TestWebKitAPI::PlatformWebView::simulateMouseMove): (TestWebKitAPI::eventTypeForButton): (TestWebKitAPI::modifierFlagsForWKModifiers): * TestWebKitAPI/mac/TestWKWebViewMac.mm: (__simulated_forceClickAssociatedEventsMask): (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]): (-[TestWKWebView _setUpTestWindow:]): (-[TestWKWebView typeCharacter:]): * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::eventTypeForMouseButtonAndAction): (WTR::buildModifierFlags): (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents): (WTR::EventSenderProxy::mouseForceClick): (WTR::EventSenderProxy::startAndCancelMouseForceClick): (WTR::EventSenderProxy::mouseMoveTo): (WTR::EventSenderProxy::keyDown): (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetStateToConsistentValues): 2016-11-09 Beth Dakin Support TouchBar in WebKit https://bugs.webkit.org/show_bug.cgi?id=164437 -and corresponding- rdar://problem/28876524 Reviewed by Darin Adler. This makes MiniBrowser support TouchBar customization. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate awakeFromNib]): 2016-11-09 Gyuyoung Kim [EFL] Use libgcrypt instead of GnuTLS for CryptoDigest https://bugs.webkit.org/show_bug.cgi?id=164461 Reviewed by Michael Catanzaro. As GTK port in r208297, EFL port starts to use libgcrypt instead of GnuTLS as well. * efl/install-dependencies: Add libgcript package dependecy. 2016-11-09 Gyuyoung Kim [EFL] Remove unused function in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=164398 Reviewed by Darin Adler. * MiniBrowser/efl/main.c: (window_find_with_elm_window): Deleted because it is not used anywhere. 2016-11-09 Chris Dumez [WK2][NETWORK_SESSION] Add support for downloading file backed blobs https://bugs.webkit.org/show_bug.cgi?id=164458 Reviewed by Darin Adler. Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout tests can request that such resources are downloaded instead of being ignored. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForNavigationResponse): * WebKitTestRunner/TestController.h: (WTR::TestController::setShouldDownloadUndisplayableMIMETypes): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2016-11-09 Jonathan Bedard Make rpaths more robust for iOS Simulators https://bugs.webkit.org/show_bug.cgi?id=164521 Reviewed by Simon Fraser. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort._createSimulatorApp): Added more robust path. 2016-11-09 Csaba Osztrogonác Fix Tools build on case sensitive file systems https://bugs.webkit.org/show_bug.cgi?id=164474 Unreviewed buildfix. * DumpRenderTree/CMakeLists.txt: * DumpRenderTree/PlatformMac.cmake: * DumpRenderTree/PlatformWin.cmake: * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: * MiniBrowser/mac/CMakeLists.txt: 2016-11-04 Filip Pizlo WTF::ParkingLot should stop using std::chrono because std::chrono::duration casts are prone to overflows https://bugs.webkit.org/show_bug.cgi?id=152045 Reviewed by Andy Estes. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/Condition.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp: (TestWebKitAPI::ToUpperConverter::stopProducing): (TestWebKitAPI::ToUpperConverter::stopConsuming): * TestWebKitAPI/Tests/WTF/Time.cpp: Added. (WTF::operator<<): (TestWebKitAPI::TEST): 2016-11-04 Alex Christensen Unreviewed, rolling out r208293. asserts in API tests. Reverted changeset: "NetworkSession: Network process crash when converting main resource to download" https://bugs.webkit.org/show_bug.cgi?id=164220 http://trac.webkit.org/changeset/208293 2016-11-04 Said Abou-Hallawa Add a setting and preferences to enable/disable async image decoding https://bugs.webkit.org/show_bug.cgi?id=164417 Reviewed by Simon Fraser. Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleAsyncImageDecodingEnabled:]): (-[SettingsController asyncImageDecodingEnabled]): * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController didChangeSettings]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): 2016-11-04 Brady Eidson REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail https://bugs.webkit.org/show_bug.cgi?id=164390 Reviewed by Geoffrey Garen. Operating under the assumption that the behavior change is okay/desirable, this updates the test. * TestWebKitAPI/Tests/WTF/StringHasher.cpp: (TestWebKitAPI::TEST): 2016-11-04 Joanmarie Diggs AX: [ATK] Attempting to clear selection on ARIA listboxes results in crash https://bugs.webkit.org/show_bug.cgi?id=164331 Reviewed by Chris Fleizach. Add AccessibilityUIElement::clearSelectedChildren() to DRT and WKTR. Implement it for ATK. * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::clearSelectedChildren): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::clearSelectedChildren): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::clearSelectedChildren): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::clearSelectedChildren): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::clearSelectedChildren): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::clearSelectedChildren): 2016-11-04 Per Arne Vollan [Win] Page visibility tests are timing out. https://bugs.webkit.org/show_bug.cgi?id=164363 Reviewed by Brent Fulgham. Implement methods to set page visibility. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::resetPageVisibility): (TestRunner::setPageVisibility): 2016-11-03 Simon Fraser Give all the geometry classes a single-argument scale() function for consistency https://bugs.webkit.org/show_bug.cgi?id=164400 Reviewed by Zalan Bujtas. Test single-argument scale(). * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp: (TestWebKitAPI::TEST): 2016-11-03 Chris Dumez [WK2][Cocoa] Implement user interface for HTML form validation https://bugs.webkit.org/show_bug.cgi?id=164143 Reviewed by Simon Fraser. Add support for UIScriptController::contentsOfUserInterfaceItem("validationBubble") on both Mac and iOS to retrieve the currently displayed validation message. * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::contentsOfUserInterfaceItem): * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::contentsOfUserInterfaceItem): (WTR::UIScriptController::selectFormAccessoryPickerRow): * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::contentsOfUserInterfaceItem): 2016-11-03 Konstantin Tokarev Fixes to build JSCOnly on macOS https://bugs.webkit.org/show_bug.cgi?id=164379 Reviewed by Michael Catanzaro. * TestWebKitAPI/PlatformJSCOnly.cmake: Moved BUILDING_JSCONLY__ definition to OptionsJSCOnly.cmake 2016-11-03 Dan Bernstein WKWebView’s _observedRenderingProgressEvents not restored after web process crash https://bugs.webkit.org/show_bug.cgi?id=164368 Reviewed by Anders Carlsson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Added. (TEST): 2016-11-03 Alex Christensen Purge PassRefPtr from Tools https://bugs.webkit.org/show_bug.cgi?id=164358 Reviewed by Michael Catanzaro. * ImageDiff/efl/ImageDiff.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: (WTR::AccessibilityController::create): (WTR::AccessibilityController::rootElement): (WTR::AccessibilityController::focusedElement): (WTR::AccessibilityController::elementAtPoint): (WTR::AccessibilityController::addNotificationListener): Deleted. (WTR::AccessibilityController::removeNotificationListener): Deleted. (WTR::AccessibilityController::accessibleElementById): Deleted. (WTR::AccessibilityController::logAccessibilityEvents): Deleted. (WTR::AccessibilityController::resetToConsistentState): Deleted. (WTR::AccessibilityController::platformName): Deleted. * WebKitTestRunner/InjectedBundle/AccessibilityController.h: (WTR::AccessibilityController::logAccessibilityEvents): * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: (WTR::AccessibilityTextMarker::create): * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: (WTR::AccessibilityTextMarkerRange::create): * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::create): (WTR::AccessibilityUIElement::linkedElement): (WTR::AccessibilityUIElement::headerElementAtIndex): (WTR::AccessibilityUIElement::fieldsetAncestorElement): (WTR::AccessibilityUIElement::characterAtOffset): (WTR::AccessibilityUIElement::wordAtOffset): (WTR::AccessibilityUIElement::lineAtOffset): (WTR::AccessibilityUIElement::sentenceAtOffset): (WTR::AccessibilityUIElement::selectedTextMarkerRange): (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::AccessibilityUIElement): Deleted. (WTR::AccessibilityUIElement::~AccessibilityUIElement): Deleted. (WTR::AccessibilityUIElement::isEqual): Deleted. (WTR::AccessibilityUIElement::elementAtPoint): Deleted. (WTR::AccessibilityUIElement::childAtIndex): Deleted. (WTR::AccessibilityUIElement::indexOfChild): Deleted. (WTR::AccessibilityUIElement::childrenCount): Deleted. (WTR::AccessibilityUIElement::titleUIElement): Deleted. (WTR::AccessibilityUIElement::parentElement): Deleted. (WTR::AccessibilityUIElement::takeFocus): Deleted. (WTR::AccessibilityUIElement::takeSelection): Deleted. (WTR::AccessibilityUIElement::addSelection): Deleted. (WTR::AccessibilityUIElement::removeSelection): Deleted. (WTR::AccessibilityUIElement::allAttributes): Deleted. (WTR::AccessibilityUIElement::attributesOfLinkedUIElements): Deleted. (WTR::AccessibilityUIElement::linkedUIElementAtIndex): Deleted. (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Deleted. (WTR::AccessibilityUIElement::attributesOfChildren): Deleted. (WTR::AccessibilityUIElement::parameterizedAttributeNames): Deleted. (WTR::AccessibilityUIElement::increment): Deleted. (WTR::AccessibilityUIElement::decrement): Deleted. (WTR::AccessibilityUIElement::showMenu): Deleted. (WTR::AccessibilityUIElement::press): Deleted. (WTR::AccessibilityUIElement::stringAttributeValue): Deleted. (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): Deleted. (WTR::AccessibilityUIElement::uiElementAttributeValue): Deleted. (WTR::AccessibilityUIElement::numberAttributeValue): Deleted. (WTR::AccessibilityUIElement::boolAttributeValue): Deleted. (WTR::AccessibilityUIElement::isAttributeSupported): Deleted. (WTR::AccessibilityUIElement::isAttributeSettable): Deleted. (WTR::AccessibilityUIElement::isPressActionSupported): Deleted. (WTR::AccessibilityUIElement::isIncrementActionSupported): Deleted. (WTR::AccessibilityUIElement::isDecrementActionSupported): Deleted. (WTR::AccessibilityUIElement::role): Deleted. (WTR::AccessibilityUIElement::subrole): Deleted. (WTR::AccessibilityUIElement::roleDescription): Deleted. (WTR::AccessibilityUIElement::computedRoleString): Deleted. (WTR::AccessibilityUIElement::title): Deleted. (WTR::AccessibilityUIElement::description): Deleted. (WTR::AccessibilityUIElement::language): Deleted. (WTR::AccessibilityUIElement::stringValue): Deleted. (WTR::AccessibilityUIElement::accessibilityValue): Deleted. (WTR::AccessibilityUIElement::helpText): Deleted. (WTR::AccessibilityUIElement::orientation): Deleted. (WTR::AccessibilityUIElement::x): Deleted. (WTR::AccessibilityUIElement::y): Deleted. (WTR::AccessibilityUIElement::width): Deleted. (WTR::AccessibilityUIElement::height): Deleted. (WTR::AccessibilityUIElement::intValue): Deleted. (WTR::AccessibilityUIElement::minValue): Deleted. (WTR::AccessibilityUIElement::maxValue): Deleted. (WTR::AccessibilityUIElement::valueDescription): Deleted. (WTR::AccessibilityUIElement::insertionPointLineNumber): Deleted. (WTR::AccessibilityUIElement::selectedTextRange): Deleted. (WTR::AccessibilityUIElement::isEnabled): Deleted. (WTR::AccessibilityUIElement::isRequired): Deleted. (WTR::AccessibilityUIElement::isFocused): Deleted. (WTR::AccessibilityUIElement::isFocusable): Deleted. (WTR::AccessibilityUIElement::isSelected): Deleted. (WTR::AccessibilityUIElement::isSelectedOptionActive): Deleted. (WTR::AccessibilityUIElement::isSelectable): Deleted. (WTR::AccessibilityUIElement::isMultiSelectable): Deleted. (WTR::AccessibilityUIElement::setSelectedChild): Deleted. (WTR::AccessibilityUIElement::setSelectedChildAtIndex): Deleted. (WTR::AccessibilityUIElement::removeSelectionAtIndex): Deleted. (WTR::AccessibilityUIElement::selectedChildrenCount): Deleted. (WTR::AccessibilityUIElement::selectedChildAtIndex): Deleted. (WTR::AccessibilityUIElement::isExpanded): Deleted. (WTR::AccessibilityUIElement::isChecked): Deleted. (WTR::AccessibilityUIElement::isIndeterminate): Deleted. (WTR::AccessibilityUIElement::isVisible): Deleted. (WTR::AccessibilityUIElement::isOffScreen): Deleted. (WTR::AccessibilityUIElement::isCollapsed): Deleted. (WTR::AccessibilityUIElement::isIgnored): Deleted. (WTR::AccessibilityUIElement::hasPopup): Deleted. (WTR::AccessibilityUIElement::hierarchicalLevel): Deleted. (WTR::AccessibilityUIElement::clickPointX): Deleted. (WTR::AccessibilityUIElement::clickPointY): Deleted. (WTR::AccessibilityUIElement::documentEncoding): Deleted. (WTR::AccessibilityUIElement::documentURI): Deleted. (WTR::AccessibilityUIElement::url): Deleted. (WTR::AccessibilityUIElement::speak): Deleted. (WTR::AccessibilityUIElement::attributesOfColumnHeaders): Deleted. (WTR::AccessibilityUIElement::attributesOfRowHeaders): Deleted. (WTR::AccessibilityUIElement::attributesOfColumns): Deleted. (WTR::AccessibilityUIElement::attributesOfRows): Deleted. (WTR::AccessibilityUIElement::attributesOfVisibleCells): Deleted. (WTR::AccessibilityUIElement::attributesOfHeader): Deleted. (WTR::AccessibilityUIElement::indexInTable): Deleted. (WTR::AccessibilityUIElement::rowIndexRange): Deleted. (WTR::AccessibilityUIElement::columnIndexRange): Deleted. (WTR::AccessibilityUIElement::rowCount): Deleted. (WTR::AccessibilityUIElement::columnCount): Deleted. (WTR::AccessibilityUIElement::rowHeaders): Deleted. (WTR::AccessibilityUIElement::columnHeaders): Deleted. (WTR::AccessibilityUIElement::selectedRowAtIndex): Deleted. (WTR::AccessibilityUIElement::disclosedByRow): Deleted. (WTR::AccessibilityUIElement::disclosedRowAtIndex): Deleted. (WTR::AccessibilityUIElement::rowAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaIsGrabbed): Deleted. (WTR::AccessibilityUIElement::ariaDropEffects): Deleted. (WTR::AccessibilityUIElement::classList): Deleted. (WTR::AccessibilityUIElement::lineForIndex): Deleted. (WTR::AccessibilityUIElement::rangeForLine): Deleted. (WTR::AccessibilityUIElement::rangeForPosition): Deleted. (WTR::AccessibilityUIElement::boundsForRange): Deleted. (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted. (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted. (WTR::AccessibilityUIElement::stringForRange): Deleted. (WTR::AccessibilityUIElement::attributedStringForRange): Deleted. (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): Deleted. (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): Deleted. (WTR::AccessibilityUIElement::uiElementForSearchPredicate): Deleted. (WTR::AccessibilityUIElement::selectTextWithCriteria): Deleted. (WTR::AccessibilityUIElement::cellForColumnAndRow): Deleted. (WTR::AccessibilityUIElement::horizontalScrollbar): Deleted. (WTR::AccessibilityUIElement::verticalScrollbar): Deleted. (WTR::AccessibilityUIElement::addNotificationListener): Deleted. (WTR::AccessibilityUIElement::removeNotificationListener): Deleted. (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Deleted. (WTR::AccessibilityUIElement::textMarkerRangeForElement): Deleted. (WTR::AccessibilityUIElement::textMarkerRangeLength): Deleted. (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Deleted. (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Deleted. (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Deleted. (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Deleted. (WTR::AccessibilityUIElement::endTextMarkerForBounds): Deleted. (WTR::AccessibilityUIElement::startTextMarkerForBounds): Deleted. (WTR::AccessibilityUIElement::textMarkerForPoint): Deleted. (WTR::AccessibilityUIElement::previousTextMarker): Deleted. (WTR::AccessibilityUIElement::nextTextMarker): Deleted. (WTR::AccessibilityUIElement::startTextMarker): Deleted. (WTR::AccessibilityUIElement::endTextMarker): Deleted. (WTR::AccessibilityUIElement::stringForTextMarkerRange): Deleted. (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Deleted. (WTR::AccessibilityUIElement::indexForTextMarker): Deleted. (WTR::AccessibilityUIElement::isTextMarkerValid): Deleted. (WTR::AccessibilityUIElement::textMarkerForIndex): Deleted. (WTR::AccessibilityUIElement::scrollToMakeVisible): Deleted. (WTR::AccessibilityUIElement::scrollToGlobalPoint): Deleted. (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): Deleted. (WTR::AccessibilityUIElement::supportedActions): Deleted. (WTR::AccessibilityUIElement::mathPostscriptsDescription): Deleted. (WTR::AccessibilityUIElement::mathPrescriptsDescription): Deleted. (WTR::AccessibilityUIElement::pathDescription): Deleted. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::create): * WebKitTestRunner/InjectedBundle/EventSendingController.h: * WebKitTestRunner/InjectedBundle/GCController.cpp: (WTR::GCController::create): * WebKitTestRunner/InjectedBundle/GCController.h: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::create): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/InjectedBundle/TextInputController.cpp: (WTR::TextInputController::create): * WebKitTestRunner/InjectedBundle/TextInputController.h: * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: (WTR::AccessibilityController::accessibleElementById): (WTR::AccessibilityController::rootElement): (WTR::AccessibilityController::focusedElement): (WTR::AccessibilityController::logAccessibilityEvents): Deleted. * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: (WTR::AccessibilityNotificationHandler::create): * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::elementAtPoint): (WTR::AccessibilityUIElement::childAtIndex): (WTR::accessibilityElementAtIndex): (WTR::AccessibilityUIElement::linkedUIElementAtIndex): (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): (WTR::AccessibilityUIElement::disclosedRowAtIndex): (WTR::AccessibilityUIElement::rowAtIndex): (WTR::AccessibilityUIElement::selectedChildAtIndex): (WTR::AccessibilityUIElement::selectedRowAtIndex): (WTR::AccessibilityUIElement::titleUIElement): (WTR::AccessibilityUIElement::parentElement): (WTR::AccessibilityUIElement::disclosedByRow): (WTR::AccessibilityUIElement::uiElementAttributeValue): (WTR::AccessibilityUIElement::uiElementForSearchPredicate): (WTR::AccessibilityUIElement::cellForColumnAndRow): (WTR::AccessibilityUIElement::horizontalScrollbar): (WTR::AccessibilityUIElement::verticalScrollbar): (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::textMarkerRangeForElement): (WTR::AccessibilityUIElement::previousTextMarker): (WTR::AccessibilityUIElement::nextTextMarker): (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): (WTR::AccessibilityUIElement::endTextMarkerForBounds): (WTR::AccessibilityUIElement::startTextMarkerForBounds): (WTR::AccessibilityUIElement::textMarkerForPoint): (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): (WTR::AccessibilityUIElement::textMarkerForIndex): (WTR::AccessibilityUIElement::startTextMarker): (WTR::AccessibilityUIElement::endTextMarker): * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: (WTR::AccessibilityController::accessibleElementById): (WTR::AccessibilityController::logAccessibilityEvents): Deleted. * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::headerElementAtIndex): (WTR::AccessibilityUIElement::linkedElement): (WTR::AccessibilityUIElement::elementAtPoint): (WTR::AccessibilityUIElement::childAtIndex): (WTR::AccessibilityUIElement::linkedUIElementAtIndex): (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): (WTR::AccessibilityUIElement::disclosedRowAtIndex): (WTR::AccessibilityUIElement::rowAtIndex): (WTR::AccessibilityUIElement::selectedChildAtIndex): (WTR::AccessibilityUIElement::selectedRowAtIndex): (WTR::AccessibilityUIElement::titleUIElement): (WTR::AccessibilityUIElement::parentElement): (WTR::AccessibilityUIElement::disclosedByRow): (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): (WTR::AccessibilityUIElement::uiElementAttributeValue): (WTR::AccessibilityUIElement::rangeForLine): (WTR::AccessibilityUIElement::rangeForPosition): (WTR::AccessibilityUIElement::uiElementForSearchPredicate): (WTR::AccessibilityUIElement::fieldsetAncestorElement): (WTR::AccessibilityUIElement::cellForColumnAndRow): (WTR::AccessibilityUIElement::horizontalScrollbar): (WTR::AccessibilityUIElement::verticalScrollbar): (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::textMarkerRangeForElement): (WTR::AccessibilityUIElement::previousTextMarker): (WTR::AccessibilityUIElement::nextTextMarker): (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): (WTR::AccessibilityUIElement::endTextMarkerForBounds): (WTR::AccessibilityUIElement::startTextMarkerForBounds): (WTR::AccessibilityUIElement::textMarkerForPoint): (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): (WTR::AccessibilityUIElement::textMarkerForIndex): (WTR::AccessibilityUIElement::startTextMarker): (WTR::AccessibilityUIElement::endTextMarker): (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::mathPostscriptsDescription): (WTR::AccessibilityUIElement::mathPrescriptsDescription): (WTR::AccessibilityUIElement::supportedActions): * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: (WTR::AccessibilityController::accessibleElementById): (WTR::AccessibilityController::logAccessibilityEvents): Deleted. * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: (makeValueRefForValue): (-[AccessibilityNotificationHandler _notificationReceived:]): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::elementAtPoint): (WTR::AccessibilityUIElement::childAtIndex): (WTR::AccessibilityUIElement::linkedUIElementAtIndex): (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): (WTR::AccessibilityUIElement::disclosedRowAtIndex): (WTR::AccessibilityUIElement::rowAtIndex): (WTR::AccessibilityUIElement::selectedChildAtIndex): (WTR::AccessibilityUIElement::selectedRowAtIndex): (WTR::AccessibilityUIElement::titleUIElement): (WTR::AccessibilityUIElement::parentElement): (WTR::AccessibilityUIElement::disclosedByRow): (WTR::AccessibilityUIElement::uiElementAttributeValue): (WTR::AccessibilityUIElement::uiElementForSearchPredicate): (WTR::AccessibilityUIElement::cellForColumnAndRow): (WTR::AccessibilityUIElement::horizontalScrollbar): (WTR::AccessibilityUIElement::verticalScrollbar): (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::textMarkerRangeForElement): (WTR::AccessibilityUIElement::previousTextMarker): (WTR::AccessibilityUIElement::nextTextMarker): (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): (WTR::AccessibilityUIElement::selectedTextMarkerRange): (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): (WTR::AccessibilityUIElement::endTextMarkerForBounds): (WTR::AccessibilityUIElement::startTextMarkerForBounds): (WTR::AccessibilityUIElement::textMarkerForPoint): (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): (WTR::AccessibilityUIElement::textMarkerForIndex): (WTR::AccessibilityUIElement::startTextMarker): (WTR::AccessibilityUIElement::endTextMarker): (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: (WTR::keyPadName): (WTR::keyName): 2016-11-02 Alex Christensen Remove Battery Status API from the tree https://bugs.webkit.org/show_bug.cgi?id=164213 Reviewed by Sam Weinig. * Scripts/webkitperl/FeatureList.pm: * Scripts/webkitpy/common/config/watchlist: 2016-11-02 Olivier Blin [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation https://bugs.webkit.org/show_bug.cgi?id=163125 Reviewed by Michael Catanzaro. * gtk/install-dependencies: List libgcrypt for WebKitGTK+ build, and gnutls for jhbuild only. gnutls is useful for glib-networking in jhbuild. 2016-11-02 Carlos Garcia Campos NetworkSession: Network process crash when converting main resource to download https://bugs.webkit.org/show_bug.cgi?id=164220 Reviewed by Alex Christensen. Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is converted to a download and another one to test the cancellation as the test was doing before. When doing the full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a download. * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: (testPolicyResponseDownload): (testPolicyResponseDownloadCancel): (beforeAll): 2016-11-01 Alex Christensen Remove PassRefPtr from DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=164307 Reviewed by Sam Weinig. * DumpRenderTree/PixelDumpSupport.h: * DumpRenderTree/TestRunner.cpp: (TestRunner::create): * DumpRenderTree/TestRunner.h: * DumpRenderTree/cg/PixelDumpSupportCG.cpp: (createBitmapContext): * DumpRenderTree/cg/PixelDumpSupportCG.h: (BitmapContext::createByAdoptingBitmapAndContext): * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (createBitmapContextFromWebView): * DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView): (createPagedBitmapContext): * DumpRenderTree/mac/TestRunnerMac.mm: * DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView): * DumpRenderTree/win/TextInputController.h: 2016-11-02 Carlos Garcia Campos [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp https://bugs.webkit.org/show_bug.cgi?id=161481 Reviewed by Michael Catanzaro. * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp: (WebKitTestBus::WebKitTestBus): (WebKitTestBus::~WebKitTestBus): (WebKitTestBus::run): (WebKitTestBus::getOrCreateConnection): (WebKitTestBus::createProxy): * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h: 2016-11-02 Carlos Garcia Campos Unreviewed. Fix /webkit2/WebKitWebContext/get-plugins in the bots after r208273. The test fails now if WEBKIT_TEST_PLUGIN_DIR contains symlinks, which is the case of the GTK+ bots. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextGetPlugins): Use realpath with WEBKIT_TEST_PLUGIN_DIR when building the expected plugins path. 2016-11-02 Romain Bellessort [Readable Streams API] Enable creation of ReadableByteStreamController https://bugs.webkit.org/show_bug.cgi?id=164014 Reviewed by Youenn Fablet. Enable the byte stream part of Readable Streams API by default. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-11-01 Ryosuke Niwa Remove CUSTOM_ELEMENTS build flag https://bugs.webkit.org/show_bug.cgi?id=164267 Reviewed by Antti Koivisto. Removed the build flag. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-11-01 Alex Christensen Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes https://bugs.webkit.org/show_bug.cgi?id=164290 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkRelativeURL): (TestWebKitAPI::checkURLDifferences): (TestWebKitAPI::checkRelativeURLDifferences): Move helper functions to the top so I can use them from any tests. (TestWebKitAPI::shouldFail): (TestWebKitAPI::checkURL): (TestWebKitAPI::TEST_F): 2016-11-01 Hyowon Kim [GTK] Failed to generate GeoClue2Interface files. https://bugs.webkit.org/show_bug.cgi?id=164270 Reviewed by Michael Catanzaro. To generate codes for D-Bus interfaces, geoclue-2.0 package including D-Bus introspection XML files should be installed. * gtk/install-dependencies: add geoclue-2.0 package. 2016-11-01 Fujii Hironori [CMake] generate-bindings-all.pl uses USES_TERMINAL which leaves a noisy line in interactive Ninja build https://bugs.webkit.org/show_bug.cgi?id=163868 Reviewed by Michael Catanzaro. It takes long time for generate-bindings-all.pl to generate all bindings. So, it shows the progress while running and USES_TERMINAL option of add_custom_target have been used to invoke the command. However, USES_TERMINAL leaves a noisy line in Ninja's neat build log of interactive build. A new CMake option SHOW_BINDINGS_GENERATION_PROGRESS is added to stop using USES_TERMINAL only in case of interactive Ninja build. * Scripts/webkitdirs.pm: (generateBuildSystemFromCMakeProject): Enable SHOW_BINDINGS_GENERATION_PROGRESS not in case of interactive Ninja build. 2016-10-31 Simon Fraser Add basic visual/layout viewport support for fixed position layout https://bugs.webkit.org/show_bug.cgi?id=164261 Reviewed by Dean Jackson. Don't give tests in the "visual-viewport" directory a flexible viewport. * DumpRenderTree/mac/DumpRenderTree.mm: (shouldMakeViewportFlexible): * WebKitTestRunner/TestOptions.cpp: (WTR::shouldMakeViewportFlexible): 2016-10-29 Filip Pizlo JSC should support SharedArrayBuffer https://bugs.webkit.org/show_bug.cgi?id=163986 Reviewed by Keith Miller. Use the right kind of typed array API. * DumpRenderTree/TestRunner.cpp: (setAudioResultCallback): 2016-10-31 Simon Fraser Make UIScriptController::zoomToScale() work on Mac WK1 and WK2 https://bugs.webkit.org/show_bug.cgi?id=164238 Reviewed by Dean Jackson. Implement UIScriptController::zoomToScale() for WTR and DRT on Mac. * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::zoomToScale): * TestRunnerShared/UIScriptContext/UIScriptController.cpp: * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::zoomToScale): 2016-10-31 Dewei Zhu Update twisted version in webkitpy.thirdparty.autoinstalled module. https://bugs.webkit.org/show_bug.cgi?id=154667 Reviewed by Ryosuke Niwa. Use twisted_15_5_0 for the twisted module used by run-benchmark because there is a bug in twisted 12.1.0 which sometimes stops the test. Installing twisted was introduced in https://bugs.webkit.org/show_bug.cgi?id=147082 for run-benchmark script. Since buildbot relies on twisted 12.1.0 and has not been verified the compatibility on twisted 15.5.0, it would be more secure to use an individual version for run-benchmark script. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook.find_module): (AutoinstallImportHook._install_twisted_15_5_0): (AutoinstallImportHook._install_twisted): Deleted. 2016-10-31 Ryosuke Niwa Enable custom elements by default everywhere https://bugs.webkit.org/show_bug.cgi?id=164242 Reviewed by Antti Koivisto. Enable custom elements API on every port by default. * Scripts/webkitperl/FeatureList.pm: 2016-10-31 Nan Wang AX: aria-sort is not exposed on iOS https://bugs.webkit.org/show_bug.cgi?id=164245 Reviewed by Chris Fleizach. * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::stringAttributeValue): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::stringAttributeValue): 2016-10-31 Simon Fraser Implement IntersectionObserver https://bugs.webkit.org/show_bug.cgi?id=159475 Reviewed by Ryosuke Niwa. Add ENABLE_INTERSECTION_OBSERVER, enabled by default. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-10-31 Ryan Haddad Unreviewed, rolling out r208154. This change caused an assertion failure during API tests on macOS. Reverted changeset: "NetworkSession: Network process crash when converting main resource to download" https://bugs.webkit.org/show_bug.cgi?id=164220 http://trac.webkit.org/changeset/208154 2016-10-31 Said Abou-Hallawa Unreviewed, change my status to be a WebKit reviewer * Scripts/webkitpy/common/config/contributors.json: 2016-10-31 Carlos Garcia Campos NetworkSession: Network process crash when converting main resource to download https://bugs.webkit.org/show_bug.cgi?id=164220 Reviewed by Alex Christensen. Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is converted to a download and another one to test the cancellation as the test was doing before. When doing the full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a download. * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: (testPolicyResponseDownload): (testPolicyResponseDownloadCancel): (beforeAll): 2016-10-31 Keith Miller Unreviewed, fix watchlist regexp for wasm. * Scripts/webkitpy/common/config/watchlist: 2016-10-31 Keith Miller autogenerated files from wasm.json should be in derived sources. https://bugs.webkit.org/show_bug.cgi?id=164152 Reviewed by Filip Pizlo. Add message to make sure that people keep the wasm.jsons up to date. * Scripts/webkitpy/common/config/watchlist: 2016-10-31 Wenson Hsieh Holding down a key to choose an accented character should fire "insertReplacementText" input events https://bugs.webkit.org/show_bug.cgi?id=164209 Reviewed by Darin Adler. Adds test support for inserting replacement text on Mac. This is equivalent to holding down a vowel key (e.g. 'a') to bring up the menu containing accented version of the character, then selecting an accented character to insert in place of the typed character. This is exposed via UIScriptController.insertText, which takes a string and an insertion range. * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::insertText): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Note that there is no callback argument to insertText, since UIScriptController::insertText is synchronous in the UI process. The tests end when corresponding input events fired as a result of insertText have been received in the web process. Please see the new layout tests for more detail. * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::insertText): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::nsStringFromJSString): (WTR::UIScriptController::insertText): 2016-10-30 Sam Weinig [WebIDL] Restructure IDLParser structs to better match modern WebIDL concepts https://bugs.webkit.org/show_bug.cgi?id=164208 Reviewed by Darin Adler. * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Update for new struct types. 2016-10-29 Darin Adler Fix failing ExtendedColor tests. * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp: Changed the tests in two ways: First, use EXPECT_EQ instead of EXPECT_TRUE for the string equality comparisons. This required including WTFStringUtilities.h. Second, change expected results to match what the code is currently generating, so alpha channels are "0.25" rather than "0.25 / 1". I'll let Dean fix both these tests and the code if these results are incorrect. 2016-10-29 Wenson Hsieh UIScriptControllerIOS.mm should not be soft-linking UIKit https://bugs.webkit.org/show_bug.cgi?id=164171 Reviewed by Darin Adler. Follow-up to r208090. Instead of soft-linking, we can simply grab UIKeyboardPredictionView by name instead. * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): 2016-10-28 Darin Adler Move all classes in the HTML directory from ExceptionCode to Exception https://bugs.webkit.org/show_bug.cgi?id=163876 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: (TestWebKitAPI::ToString): Updated for changes to the TimeRanges class. (TestWebKitAPI::TEST): Ditto. 2016-10-28 Devin Rousso Unreviewed, changed Devin Rousso's email and nick. * Scripts/webkitpy/common/config/contributors.json: 2016-10-28 Wenson Hsieh Unreviewed, fix the iOS build after r208090. Use soft-linking as needed in UIScriptControllerIOS.mm. * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): 2016-10-28 Wenson Hsieh iOS autocorrection does not trigger an input event of inputType "insertReplacementText" https://bugs.webkit.org/show_bug.cgi?id=164077 Reviewed by Simon Fraser. Adds test support for inserting text candidates on iOS in the form of UIScriptController.selectTextCandidateAtIndex(index, callback), which selects the text candidate at a given index (this needs to be a value between 0-2 on iOS) and fires the callback when done. To implement this, we wait for the text prediction view to have predictions (we determine this by polling at a given interval) and then tap the center of the text prediction view at the given index. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::selectTextCandidateAtIndex): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::selectTextCandidateAtIndex): (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/UIKitSPI.h: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::selectTextCandidateAtIndex): (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): 2016-10-28 Commit Queue Unreviewed, rolling out r207700. https://bugs.webkit.org/show_bug.cgi?id=164168 We are ready after r208086 (Requested by alexchristensen on #webkit). Reverted changeset: "Unreviewed, rolling out r207582." https://bugs.webkit.org/show_bug.cgi?id=163819 http://trac.webkit.org/changeset/207700 2016-10-28 Alex Christensen Partially revert 207805 after resolution in URL spec issue 87 https://bugs.webkit.org/show_bug.cgi?id=164142 Reviewed by Andy Estes. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-28 Alex Christensen URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address https://bugs.webkit.org/show_bug.cgi?id=164154 Reviewed by Andy Estes. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-28 Sam Weinig [WebIDL] Update parser and code generators to only access type information through the type property https://bugs.webkit.org/show_bug.cgi?id=164141 Reviewed by Anders Carlsson. * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Update to always access type information through type accessors. Remove use of removed properties. 2016-10-28 Frederic Wang [GTK] Upgrade HarfBuzz to version 1.3.3 https://bugs.webkit.org/show_bug.cgi?id=162719 Reviewed by Michael Catanzaro. * gtk/jhbuild.modules: 2016-10-27 Chris Dumez Regression(r203601): Caused crashes in iBooks https://bugs.webkit.org/show_bug.cgi?id=164093 Reviewed by Darin Adler. Add API test coverage. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/DOMNode.mm: Added. (-[DOMNodeTest webView:didFinishLoadForFrame:]): (TestWebKitAPI::TEST): 2016-10-27 Sam Weinig [WebIDL] Move code generators off of domSignature::type and onto domSignature::idlType https://bugs.webkit.org/show_bug.cgi?id=164089 Reviewed by Alex Christensen. * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Update for the removal of domSignature::type, and new signatures of helper predicates. 2016-10-27 Commit Queue Unreviewed, rolling out r207992. https://bugs.webkit.org/show_bug.cgi?id=164070 triggered aclocal version conflict (Requested by mcatanzaro on #webkit). Reverted changeset: "[GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue)" https://bugs.webkit.org/show_bug.cgi?id=163689 http://trac.webkit.org/changeset/207992 2016-10-27 Joanmarie Diggs [GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue) https://bugs.webkit.org/show_bug.cgi?id=163689 Reviewed by Michael Catanzaro. In order to fix bug #163591, we need to apply an upstream patch to GTK+. But GTK+ won't build with that patch due to the following error: m4_copy: won't overwrite defined macro: glib_DEFUN There is an upstream GLib patch which solves that issue. We should apply that patch as well, until we bump GLib to 2.50.1 or later. * gtk/jhbuild.modules: Apply upstream GLib patch. * gtk/patches/glib-deprecate-am-glib-gnu-gettext.patch: Added. 2016-10-27 Xabier Rodriguez Calvar Unreviewed fix of GTK and EFL test bots. * Scripts/webkitperl/FeatureList.pm: Deactivated media-source and legacy-encrypted-media by default for GTK and EFL. 2016-10-26 Yusuke Suzuki [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly https://bugs.webkit.org/show_bug.cgi?id=163846 Reviewed by Michael Catanzaro. WebAssembly is now developed for Darwin right now. Disable WASM tests in the other platforms. * Scripts/run-jsc-stress-tests: 2016-10-26 Enrique Ocaña González [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring https://bugs.webkit.org/show_bug.cgi?id=162928 Reviewed by Xabier Rodriguez-Calvar. Explicitly enable MSE and EME on WebKitGTK+ buildbots. This patch is co-authored with Philippe Normand (EME support). * Scripts/webkitperl/FeatureList.pm: 2016-10-25 Antoine Quint [Modern Media Controls] Media Controller: skip back support https://bugs.webkit.org/show_bug.cgi?id=163725 Reviewed by Dean Jackson. * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may access the modern-media-controls source files through the web server. 2016-10-19 Jer Noble Add WKWebView fullscreen delegate SPI https://bugs.webkit.org/show_bug.cgi?id=163674 Reviewed by Anders Carlsson. Add a new API test which verifies that the fullscreen delegate receives notifications. * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm: (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]): (-[FullscreenDelegateMessageHandler _webViewWillEnterFullscreen:]): (-[FullscreenDelegateMessageHandler _webViewDidEnterFullscreen:]): (-[FullscreenDelegateMessageHandler _webViewWillExitFullscreen:]): (-[FullscreenDelegateMessageHandler _webViewDidExitFullscreen:]): (TestWebKitAPI::TEST): 2016-10-24 Alex Christensen URLParser should match old URL::parse with %2E in path https://bugs.webkit.org/show_bug.cgi?id=163929 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-24 Ryan Haddad Unreviewed, rolling out r207795. Introduced API test failures on iOS and macOS. Reverted changeset: "URLParser should match old URL::parse with %2E in path" https://bugs.webkit.org/show_bug.cgi?id=163929 http://trac.webkit.org/changeset/207795 2016-10-24 Alex Christensen URLParser should match old URL::parse with %2E in path https://bugs.webkit.org/show_bug.cgi?id=163929 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-21 Alex Christensen URL::port should return Optional https://bugs.webkit.org/show_bug.cgi?id=163806 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/URL.cpp: (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkURL): (TestWebKitAPI::checkRelativeURL): (TestWebKitAPI::checkURLDifferences): (TestWebKitAPI::checkRelativeURLDifferences): (TestWebKitAPI::TEST_F): 2016-10-24 Youenn Fablet Activate WEB_RTC compilation flags for Mac bots https://bugs.webkit.org/show_bug.cgi?id=163886 Reviewed by Eric Carlson. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-10-24 Wenson Hsieh Unreviewed, add myself as a WebKit reviewer * Scripts/webkitpy/common/config/contributors.json: 2016-10-22 Dan Bernstein Improve MiniBrowser window titles for URLs without paths and with no title Reviewed by Darin Adler. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController fetch:]): While we’re here, deploy +[NSURL _webkit_URLWithUserTypedString:] here to match the WK2BrowserWindowController version of this method. (-[WK1BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent, use the entire URL. (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): Also while we’re here, deploy +[NSURL _web_userVisibleString] here to match the WK2BrowserWindowController behavior. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent, use the entire URL. 2016-10-21 David Kilzer Bug 163762: IntSize::area() should used checked arithmetic Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/IntRect.cpp: (TestWebKitAPI::TEST): Call unsafeGet(). * TestWebKitAPI/Tests/WebCore/IntSize.cpp: (TestWebKitAPI::TEST): Ditto. 2016-10-21 James Craig Unreviewed: Added Aaron Chu to contributors list. * Scripts/webkitpy/common/config/contributors.json: 2016-10-21 Commit Queue Unreviewed, rolling out r207582. https://bugs.webkit.org/show_bug.cgi?id=163819 Not quite ready rdar://problem/28897179 (Requested by alexchristensen on #webkit). Reverted changeset: "Re-enable URLParser for non-Safari Cocoa apps after r207321" https://bugs.webkit.org/show_bug.cgi?id=163690 http://trac.webkit.org/changeset/207582 2016-10-21 Jonathan Bedard WebKitTestRunnerApp packages .idl file https://bugs.webkit.org/show_bug.cgi?id=163788 Reviewed by Darin Adler. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Removed .idl file from app package, removed bad reference to app icon. 2016-10-21 Csaba Osztrogonác [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package https://bugs.webkit.org/show_bug.cgi?id=163733 Reviewed by Gyuyoung Kim. * efl/install-dependencies: Added geoclue-2.0 package. 2016-10-21 Commit Queue Unreviewed, rolling out r207609. https://bugs.webkit.org/show_bug.cgi?id=163776 As glib bump was rollout, we need to rollout this too (Requested by rego on #webkit). Reverted changeset: "[GTK] Cannot build GTK+ with CUPS 2.* versions" https://bugs.webkit.org/show_bug.cgi?id=163591 http://trac.webkit.org/changeset/207609 2016-10-20 Chris Dumez "Download Linked File" context menu action should use 'download' attribute as suggested filename https://bugs.webkit.org/show_bug.cgi?id=163742 Reviewed by Darin Adler. Add API test coverage. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Added. * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Added. (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::getContextMenuFromProposedMenu): (TestWebKitAPI::decideDestinationWithSuggestedFilename): (TestWebKitAPI::TEST): 2016-10-20 Commit Queue Unreviewed, rolling out r207589. https://bugs.webkit.org/show_bug.cgi?id=163765 Introduced 17 new layout test failures (Requested by mcatanzaro on #webkit). Reverted changeset: "[GTK] Bump glib to 2.50.1" https://bugs.webkit.org/show_bug.cgi?id=163689 http://trac.webkit.org/changeset/207589 2016-10-19 Myles C. Maxfield [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9 https://bugs.webkit.org/show_bug.cgi?id=163374 Reviewed by Darin Adler. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-10-20 Sam Weinig Add convenience function that combines WTF::visit(...) with WTF::makeVisitor(...) https://bugs.webkit.org/show_bug.cgi?id=163713 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WTF/Variant.cpp: Add test for WTF::switchOn() 2016-10-20 Fujii Hironori [CMake] CMake does not support the dep files for implicit dependency https://bugs.webkit.org/show_bug.cgi?id=161433 Reviewed by Brent Fulgham. Created a Perl script to generate all IDL bindings for CMake. This script can regenerate outdated bindings by based on the supplemental dependency and dep files created by '--write-dependencies' switch of generate-bindings.pl. add_custom_target is used to invoke the script instead of add_custom_command because Ninja deletes all output files before executing the command in case of add_custom_command. USES_TERMINAL option of add_custom_target has two effects: 1) Not buffering output of the command 2) Invoking the command in the special Ninja pool which inhibits parallel build One needs to use CMake 3.2 or later to enable this feature. * DumpRenderTree/CMakeLists.txt: Specified a target name for GENERATE_BINDINGS. Added dependency for the target. * WebKitTestRunner/CMakeLists.txt: Ditto. 2016-10-20 Manuel Rego Casasnovas [GTK] Cannot build GTK+ with CUPS 2.* versions https://bugs.webkit.org/show_bug.cgi?id=163591 Reviewed by Michael Catanzaro. GTK+ is wrongly checking about the available CUPS version, so if you have CUPS 2.* the configure step fails. This has been already fixed upstream and included in 2.30 series: https://git.gnome.org/browse/gtk+/commit/?id=631f6b536485829a0bd00532f5826ad302b4951b Added patch on JHBuild so we can now build GTK+ with CUPS 2.*. * gtk/jhbuild.modules: Applied patch and avoid using "configure" script directly as the patch modifies "configure.ac". * gtk/patches/configure-fix-detecting-CUPS-2.x.patch: Added. 2016-10-20 Manuel Rego Casasnovas [GTK] Bump glib to 2.50.1 https://bugs.webkit.org/show_bug.cgi?id=163689 Reviewed by Michael Catanzaro. This is need in order to fix GTK+ build with CUPS 2.* (bug #163591). * gtk/jhbuild.modules: Bump glib version. Pass --disable-libmount to build properly. Also we don't need the patches anymore. * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed. * gtk/patches/glib-warning-fix.patch: Removed. 2016-10-19 Alex Christensen Re-enable URLParser for non-Safari Cocoa apps after r207321 https://bugs.webkit.org/show_bug.cgi?id=163690 Reviewed by Darin Adler. * DumpRenderTree/mac/DumpRenderTree.mm: (DumpRenderTreeMain): * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]): * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: (TestWebKitAPI::TEST): * WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): 2016-10-19 Ryan Haddad Unreviewed, rolling out r207557. This change caused animations/font-variations tests to time out on pre-Sierra Macs. Reverted changeset: "[macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9" https://bugs.webkit.org/show_bug.cgi?id=163374 http://trac.webkit.org/changeset/207557 2016-10-19 Andy Estes Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type https://bugs.webkit.org/show_bug.cgi?id=163476 Reviewed by Andreas Kling. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added. (TEST): Added an API test that passes a nil MIMEType to -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]. 2016-10-19 Jer Noble Modify testrunner to mute audio during tests https://bugs.webkit.org/show_bug.cgi?id=162582 Reviewed by Alexey Proskuryakov. * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): 2016-10-19 Joseph Pecoraro check-webkit-style: fix false-positive warnings about using #pragma once header guard https://bugs.webkit.org/show_bug.cgi?id=163575 Reviewed by Brady Eidson. There were some false positive warnings about header guards for ObjC headers that don't need guards. This changes the style checker to no longer warn if there is no #pragma once. It only warns if there are #ifndef that should be #pragma once. * Scripts/webkitpy/style/checkers/cpp.py: (check_for_header_guard): Change when we output an error. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_build_header_guard): Update tests. 2016-10-19 Myles C. Maxfield [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9 https://bugs.webkit.org/show_bug.cgi?id=163374 Reviewed by Darin Adler. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-10-18 Philippe Normand WebRTC: [GTK] Update jhbuild environment for OpenWebRTC https://bugs.webkit.org/show_bug.cgi?id=163330 Reviewed by Michael Catanzaro. Bring back the openwebrtc JHBuild moduleset in the time being. It should be removed after the bump to GStreamer 1.10 is complete and the libnice patches have been upstreamed. The GStreamer git snapshots used in this patch are the ones configured in Ericsson's GStreamer Cerbero fork. * gtk/openwebrtc.modules: Added. * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Added. * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Added. * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Added. * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Added. * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Added. * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Added. * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Added. 2016-10-18 Sam Weinig Replace std::experimental::variant with WTF::Variant (or similar) https://bugs.webkit.org/show_bug.cgi?id=163626 Reviewed by Chris Dumez. Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc. into the WTF namespace. * TestWebKitAPI/Tests/WTF/Variant.cpp: (TestWebKitAPI::TEST): 2016-10-18 Simon Fraser Add a MiniBrowser menu item to apply page scale in WK1 and WK2 https://bugs.webkit.org/show_bug.cgi?id=163627 Reviewed by Dean Jackson. Rename setScale: to setViewScale: and add setPageScale:, hooking it up for WK1 (via exisiting SPI) and WK2 (via new SPI). * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController pageScaleForMenuItemTag:]): (-[BrowserWindowController setPageScale:]): (-[BrowserWindowController setViewScale:]): (-[BrowserWindowController setScale:]): Deleted. * MiniBrowser/mac/MainMenu.xib: * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController setPageScale:]): (-[WK1BrowserWindowController setViewScale:]): (areEssentiallyEqual): (-[WK1BrowserWindowController validateMenuItem:]): (-[WK1BrowserWindowController setScale:]): Deleted. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController setPageScale:]): (-[WK2BrowserWindowController viewScaleForMenuItemTag:]): (-[WK2BrowserWindowController setViewScale:]): (areEssentiallyEqual): (-[WK2BrowserWindowController validateMenuItem:]): (viewScaleForMenuItemTag): Deleted. (-[WK2BrowserWindowController setScale:]): Deleted. 2016-10-18 Anders Carlsson Add an beforeunload alert to the WebKitLegacy MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=163634 Reviewed by Sam Weinig. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): 2016-10-18 Commit Queue Unreviewed, rolling out r207443. https://bugs.webkit.org/show_bug.cgi?id=163616 "Caused 5% PLT regression" (Requested by krollin on #webkit). Reverted changeset: "Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type" https://bugs.webkit.org/show_bug.cgi?id=163476 http://trac.webkit.org/changeset/207443 2016-10-18 Eric Carlson [MediaStream] Resolve constraints and enumerate devices in the UI process https://bugs.webkit.org/show_bug.cgi?id=162147 Reviewed by Darin Adler. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): Enable mock capture devices. (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update for API changes. 2016-10-17 Megan Gardner Add test and infrastructure for link popover https://bugs.webkit.org/show_bug.cgi?id=163406 Reviewed by Simon Fraser. Added functionality test for link popovers. Can query for what URL is loaded, and that the popover has appeared or has been dismissed. Added a link popover test. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback): (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback): (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted. * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptContext.h: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::setDidShowForcePressPreviewCallback): (WTR::UIScriptController::didShowForcePressPreviewCallback): (WTR::UIScriptController::setDidDismissForcePressPreviewCallback): (WTR::UIScriptController::didDismissForcePressPreviewCallback): (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback): (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback): (WTR::UIScriptController::didEndFormControlInteractionCallback): Deleted. (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted. * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView dealloc]): (-[TestRunnerWKWebView didShowForcePressPreview]): (-[TestRunnerWKWebView didDismissForcePressPreview]): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback): (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback): (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted. 2016-10-17 Tim Horton REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state https://bugs.webkit.org/show_bug.cgi?id=163573 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: (TEST): Add a test ensuring that canGoBack returns NO after restoring session state without navigating. 2016-10-17 Andy Estes Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type https://bugs.webkit.org/show_bug.cgi?id=163476 Reviewed by Tim Horton. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added. (TEST): Added an API test that passes a nil MIMEType to -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]. 2016-10-17 Dean Jackson Allow creation of ExtendedColors and make Color immutable https://bugs.webkit.org/show_bug.cgi?id=163557 Reviewed by Darin Adler and Dave Hyatt. API tests for ExtendedColor. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp: Added. (TestWebKitAPI::TEST): (TestWebKitAPI::makeColor): 2016-10-17 JF Bastien WebAssembly JS API: implement basic stub Implement the global WebAssembly JavaScript object, and its constructor + function properties as described in: https://github.com/WebAssembly/design/blob/master/JS.md These don't do anything at the moment, the parent bug will take care of adding more functionality and associated tests. WebAssembly JS API: implement basic stub https://bugs.webkit.org/show_bug.cgi?id=163404 Reviewed by Keith Miller. * Scripts/run-jsc-stress-tests: use the new JSC option which exposes the WebAssembly object. 2016-10-17 Fujii Hironori resolve-ChangeLogs: Specify --no-page to git diff https://bugs.webkit.org/show_bug.cgi?id=163441 Reviewed by Darin Adler. resolve-ChangeLogs shows the result after resolving by invoking 'git diff'. It runs a pager for every ChangeLog if it is under TTY. * Scripts/resolve-ChangeLogs: (showStatus): Specify '--no-page' to git diff. 2016-10-17 Michael Catanzaro Move user agent quirks to cross-platform location https://bugs.webkit.org/show_bug.cgi?id=163508 Reviewed by Carlos Garcia Campos. Move the test to a cross-platform location and improve it to better check the full list of sites we have defined quirks for. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp. (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk): (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk): (TestWebKitAPI::TEST): 2016-10-17 Carlos Garcia Campos [SOUP] Downloads should always sniff contents https://bugs.webkit.org/show_bug.cgi?id=163538 Reviewed by Michael Catanzaro. Add a test case to check that the MIME type is correctly guessed for downloads. * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: (writeNextChunk): (serverCallback): (testDownloadMIMEType): (beforeAll): (writeNextChunkIdle): Deleted. 2016-10-16 Daniel Bates Fix Perl warning about masked variable following (https://bugs.webkit.org/show_bug.cgi?id=163456) * Scripts/prepare-ChangeLog: (actuallyGenerateFunctionLists): 2016-10-16 Carlos Garcia Campos Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949. After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have g_assert_cmpstr for tests. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextLanguages): 2016-10-16 Carlos Garcia Campos [GTK] WebKitWebPage URI not updated after URI is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame https://bugs.webkit.org/show_bug.cgi?id=163389 Reviewed by Michael Catanzaro. Update /webkit2/WebKitWebPage/get-uri test to check that web view and page uri always match even when request is modified by WebKitWebPage::send-request signal. * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: (testWebPageURI): 2016-10-16 Carlos Garcia Campos Document request not updated after willSendRequest is called for a redirect https://bugs.webkit.org/show_bug.cgi?id=163436 Reviewed by Michael Catanzaro. Update /webkit2/WebKitWebView/active-uri test to check the active URI also when modified by WebKitPage::send-request signal in a web extension. * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: (testWebViewActiveURI): (serverCallback): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (sendRequestCallback): * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp: (loadChangedCallback): 2016-10-15 Dan Bernstein REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus https://bugs.webkit.org/show_bug.cgi?id=163492 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added. (-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]): (TestWebKitAPI::TEST): 2016-10-15 Daniel Bates prepare-ChangeLog erroneously said that a python __init__ method was deleted https://bugs.webkit.org/show_bug.cgi?id=163456 Reviewed by Simon Fraser. Fixes an issue where prepare-ChangeLog may list as deleted functions that are immediately above added code. Currently prepare-ChangeLog makes use of the same overlap detection algorithm to compute the list of deleted functions as it does to compute added and modified functions. We consider a function deleted if its entire function body and signature are removed. It is sufficient to compare the list of functions before the patch is applied and the list of functions are the patch is applied to identify these functions. * Scripts/prepare-ChangeLog: Fix some style nits, including using Camel Case for variable names. (actuallyGenerateFunctionLists): Modified to call computeModifiedFunctions(). Always compute the list of functions in the file after the patch regardless of whether the patch only contains deletions. We will compare this list against the list of functions before the patch was applied to determine the deleted functions. (computeModifiedFunctions): Renamed; formerly named generateFunctionListsByRanges. Removed out argument for the seen functions as we no longer make use of when computing the list of deleted functions. (diffCommand): Update comment. (generateFunctionListsByRanges): Deleted. * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added more unit tests. 2016-10-14 Simon Fraser REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name' https://bugs.webkit.org/show_bug.cgi?id=163478 Reviewed by Daniel Bates. Handle a None other in Contributor.__eq__. * Scripts/webkitpy/common/config/committers.py: (Contributor.__eq__): 2016-10-14 JF Bastien Basic WebAssembly testing Create a small DSL in JavaScript which can build WebAssembly binary modules based on the JSON description of the format as described in: https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md This DSL can then be used to write small text description of valid and invalid WebAssembly binaries, making testing the JSC implementation much easier. Details and example in README.md. Basic WebAssembly testing https://bugs.webkit.org/show_bug.cgi?id=163267 Reviewed by Keith Miller. * Scripts/run-javascriptcore-tests: (runJSCStressTests): run wasm.yaml tests * Scripts/run-jsc-stress-tests: add a WebAssembly-specific runner 2016-10-14 Simon Fraser Annotate bots in contributors.json and don't show them on webkit.org/team https://bugs.webkit.org/show_bug.cgi?id=163317 Reviewed by Daniel Bates. Add "class" : "bot" for non-humans in contributors.json and round-trip it. * Scripts/webkitpy/common/config/committers.py: (Contributor.__init__): (Contributor.as_dict): (Bot): (Bot.__init__): (CommitterList.load_json): * Scripts/webkitpy/common/config/contributors.json: 2016-10-14 Simon Fraser Fix printing in WK2 MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=163455 Reviewed by Tim Horton. Call the basic -_printOperationWithPrintInfo: which doens't require a frame argument. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController printWebView:]): 2016-10-14 Commit Queue Unreviewed, rolling out r207335. https://bugs.webkit.org/show_bug.cgi?id=163445 WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing out on Mac bots (Requested by youenn on #webkit). Reverted changeset: "Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds" https://bugs.webkit.org/show_bug.cgi?id=163440 http://trac.webkit.org/changeset/207335 2016-10-14 Youenn Fablet Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds https://bugs.webkit.org/show_bug.cgi?id=163440 Unreviewed. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Adding new test files introduced in https://bugs.webkit.org/show_bug.cgi?id=146306 patch. 2016-10-13 Carlos Garcia Campos Unreviewed. Removed myself from BindingsScripts watch list. * Scripts/webkitpy/common/config/watchlist: 2016-10-13 Carlos Garcia Campos WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame https://bugs.webkit.org/show_bug.cgi?id=146306 Reviewed by Darin Adler. Add unit test to check that the committed URL is updated when changed in willSendRequest callback. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Added. (TestWebKitAPI::didCommitLoadForFrame): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Added. (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::ProvisionalURLAfterWillSendRequestCallbackTest): (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame): (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::didCommitLoadForFrame): 2016-10-13 Alex Christensen Hosts of URLs with non-special schemes should be case-sensitive, and non-ASCII characters in such hosts should be punycode-encoded https://bugs.webkit.org/show_bug.cgi?id=163413 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): Update parsing results. There are now fewer differences between the new URLParser and the old URL::parse. 2016-10-13 Alex Christensen Rebase API tests after r207305. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Actually build Tests/mac/LoadInvalidURLRequest.mm so we are running the WebKit1.LoadInvalidURLRequest API test. * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]): * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Change results back to what they were before r207162, r207167, and r207184. 2016-10-13 Alex Christensen Disable URLParser for non-Safari iOS and Mac apps for now https://bugs.webkit.org/show_bug.cgi?id=163397 Reviewed by Tim Horton. * DumpRenderTree/mac/DumpRenderTree.mm: (DumpRenderTreeMain): * WebKitTestRunner/TestController.cpp: Enable the URLParser for testing. * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with WebCoreTestSupport so we can find setURLParserEnabled. 2016-10-13 Ryan Haddad Unreviewed, rolling out r207297. This change broke the iOS build. Reverted changeset: "Disable URLParser for non-Safari iOS and Mac apps for now" https://bugs.webkit.org/show_bug.cgi?id=163397 http://trac.webkit.org/changeset/207297 2016-10-13 Alex Christensen Disable URLParser for non-Safari iOS and Mac apps for now https://bugs.webkit.org/show_bug.cgi?id=163397 Reviewed by Tim Horton. * DumpRenderTree/mac/DumpRenderTree.mm: (DumpRenderTreeMain): * WebKitTestRunner/ios/mainIOS.mm: (main): * WebKitTestRunner/mac/main.mm: (main): 2016-10-12 Alex Christensen Fix out-of-bounds reading in URLParser when parsing improperly percent-encoded values https://bugs.webkit.org/show_bug.cgi?id=163376 Reviewed by Saam Barati. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-11 Dean Jackson Add preliminary support for extended colors to WebCore::Color https://bugs.webkit.org/show_bug.cgi?id=162878 Reviewed by Darin Adler. A new API test for Colors. * TestWebKitAPI/Tests/WebCore/Color.cpp: (TestWebKitAPI::TEST): 2016-10-12 Ryan Haddad Unreviewed, rolling out r207225. This change causes debug tests to exit early with crashes. Reverted changeset: "Optional's move-constructor and move-assignment operator don't disengage the value being moved from" https://bugs.webkit.org/show_bug.cgi?id=163309 http://trac.webkit.org/changeset/207225 2016-10-12 Alex Christensen Fix assertion after switching to URLParser https://bugs.webkit.org/show_bug.cgi?id=163350 rdar://problem/28739938 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: (TEST): 2016-10-11 Sam Weinig Optional's move-constructor and move-assignment operator don't disengage the value being moved from https://bugs.webkit.org/show_bug.cgi?id=163309 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WTF/Optional.cpp: (TestWebKitAPI::TEST): Add tests for Optional's move-constructor and move-assignment operator. 2016-10-12 Wenson Hsieh Now playing media sessions are always cleared for the active foreground tab https://bugs.webkit.org/show_bug.cgi?id=163310 Reviewed by Jer Noble. Tweaks existing unit tests to verify that media session info persists when backgrounding and foregrounding, but that media session info is correctly cleared out if the media session itself is no longer eligible for Now Playing (not accounting for foreground/active state). Previously, these tests were verifying that we would always clear out the information, but this is incorrect, and is the source of the problem. * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]): (TestWebKitAPI::TEST): 2016-10-12 Per Arne Vollan [Win] Parallel DRTs are sharing preferences and cache. https://bugs.webkit.org/show_bug.cgi?id=163013 Reviewed by Brent Fulgham. Use separate cache and preferences for each DRT instance. * DumpRenderTree/win/DumpRenderTree.cpp: (applicationId): (setApplicationId): (setCacheFolder): (setDefaultsToConsistentValuesForTesting): * Scripts/webkitpy/port/win.py: (WinPort.setup_test_run): 2016-10-11 Alex Christensen Update API test expectation after r207162. ​https://bugs.webkit.org/show_bug.cgi?id=162660 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]): Like r207167 but with a WebKit2 test. "https://www.example.com<>/" was an invalid URL with the old URL parser, is now valid with URLParser but not with NSURL's parser. 2016-10-11 Alex Christensen Update API test expectation after r207162. https://bugs.webkit.org/show_bug.cgi?id=162660 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): "https://www.example.com<>/" was an invalid URL with the old URL parser. It is now a valid URL, but NSURL still considers it invalid. This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127 2016-10-11 Edward O'Connor Update my name in contributors.json https://bugs.webkit.org/show_bug.cgi?id=163251 Reviewed by Simon Fraser. * Scripts/webkitpy/common/config/contributors.json: 2016-10-11 Said Abou-Hallawa Add SynchronizedFixedQueue class https://bugs.webkit.org/show_bug.cgi?id=162478 Reviewed by Geoffrey Garen. Add a new test for SynchronizedFixedQueue. The test defines a new class called ToUpperConverter which converts strings from lower case to upper case. It creates two threads : (1) produce thread and (2) consume thread. Here is what each thread does: 1. Main threads: Enqueues lower case strings into m_lowerQueue. 2. Produce thread: Dequeues lower case strings from m_lowerQueue and enqueue their upper case strings in the m_upperQueue. 3. Consume thread: Dequeues upper case strings from m_upperQueue. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp: Added. (TestWebKitAPI::textItem): A helper function which returns a lower case string given an index. (TestWebKitAPI::toUpper): A helper function which Returns the upper case of a string. (TestWebKitAPI::ToUpperConverter::ToUpperConverter): (TestWebKitAPI::ToUpperConverter::produceQueue): Returns a workQueue for the produce thread. (TestWebKitAPI::ToUpperConverter::consumeQueue): Returns a workQueue for the consume thread. (TestWebKitAPI::ToUpperConverter::startProducing): Creates a thread for the producer. (TestWebKitAPI::ToUpperConverter::startConsuming): Creates a thread for the consumer. (TestWebKitAPI::ToUpperConverter::start): Starts both the producer and the consumer threads. (TestWebKitAPI::ToUpperConverter::stopProducing): Terminates the producer thread. (TestWebKitAPI::ToUpperConverter::stopConsuming): Terminates the consumer thread. (TestWebKitAPI::ToUpperConverter::stop): Terminates both the producer and the consumer threads. (TestWebKitAPI::ToUpperConverter::enqueueLower): Adds a lower case string to the m_lowerQueue on the main thread. (TestWebKitAPI::ToUpperConverter::isProducing): Returns whether the producing thread is active. (TestWebKitAPI::ToUpperConverter::isConsuming): Returns whether the consuming thread is active. (TestWebKitAPI::ToUpperConverter::produceCount): Returns the number of produced elements. (TestWebKitAPI::ToUpperConverter::consumeCount): Returns the number of consumed elements. (TestWebKitAPI::TEST): 2016-10-11 Megan Gardner Extend event stream to include interpolated events and add a force press test that uses that interpolation https://bugs.webkit.org/show_bug.cgi?id=163161 Reviewed by Simon Fraser. Added functionality to the event stream to allow for interpolated events. Can now do long press, as well as a better way to do drag and other time-based events that require a large stream of descrete HID events. Added a basic force touch test to demostrate this interpolation. Also updated the script to allow for iPhone 7 specific tests, as force touch needs to be on a device that had force touch. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * WebKitTestRunner/ios/HIDEventGenerator.mm: (linearInterpolation): (simpleCurveInterpolation): (calculateNextCurveLocation): (phaseFromString): (interpolationFromString): (-[HIDEventGenerator eventMaskFromEventInfo:]): (-[HIDEventGenerator _createIOHIDEventWithInfo:]): (-[HIDEventGenerator moveToPoints:touchCount:duration:]): (-[HIDEventGenerator interpolatedEvents:]): (-[HIDEventGenerator processEventsArray:withStartTime:]): (-[HIDEventGenerator eventDispatchThreadEntry:]): (simpleDragCurve): Deleted. (calculateNextLocation): Deleted. 2016-10-11 Alex Christensen URLParser should percent-encode non-ASCII and non-printable characters in fragment https://bugs.webkit.org/show_bug.cgi?id=163287 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-11 Alex Christensen Remove dead networking code https://bugs.webkit.org/show_bug.cgi?id=163263 Reviewed by Daniel Bates. * DumpRenderTree/DumpRenderTree.h: * DumpRenderTree/config.h: * DumpRenderTree/win/DumpRenderTree.cpp: (main): 2016-10-11 John Wilander Modify check-webkit-style to prohibit sensitive phrases https://bugs.webkit.org/show_bug.cgi?id=163048 Terms considered or found to be too general to flag: ASSERT_WITH_SECURITY_IMPLICATION, bad cast, bug, bypass, crash, denial of service, dereference, disclosure, error, exploit, failure, heap, integer overflow, leak, null dereference, null pointer dereference, out of bounds, overflow, race condition, sensitive information, stack, type confusion. Reviewed by Brent Fulgham. * Scripts/webkitpy/style/checkers/changelog.py: (ChangeLogChecker.check_entry): Now calls ChangeLogChecker.check_for_unwanted_security_terms(). (ChangeLogChecker): (ChangeLogChecker.check_for_unwanted_security_terms): New function to check for sensitive terms. (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm): (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm.__init__): Convenience class. * Scripts/webkitpy/style/checkers/changelog_unittest.py: (ChangeLogCheckerTest.test_unwanted_security_terms): 2016-10-11 Ryan Haddad Unreviewed, rolling out r207067. This change caused webkitpy test failures. Reverted changeset: "[Win] Parallel DRTs are sharing preferences and cache." https://bugs.webkit.org/show_bug.cgi?id=163013 http://trac.webkit.org/changeset/207067 2016-10-11 Per Arne Vollan [Win] Parallel DRTs are sharing preferences and cache. https://bugs.webkit.org/show_bug.cgi?id=163013 Reviewed by Brent Fulgham. Use separate cache and preferences for each DRT instance. * DumpRenderTree/win/DumpRenderTree.cpp: (applicationId): (setApplicationId): (setCacheFolder): (setDefaultsToConsistentValuesForTesting): * Scripts/webkitpy/port/win.py: (WinPort.setup_test_run): 2016-10-10 Zan Dobersek Add ENABLE_ENCRYPTED_MEDIA configuration option https://bugs.webkit.org/show_bug.cgi?id=163219 Reviewed by Darin Adler. * Scripts/webkitperl/FeatureList.pm: Make the ENABLE_ENCRYPTED_MEDIA option overridable via build-webkit. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used to enable or disable the new EME implementation at build-time. 2016-10-10 Commit Queue Unreviewed, rolling out r206972. https://bugs.webkit.org/show_bug.cgi?id=163227 Making EWS flaky (Requested by bfulgham_ on #webkit). Reverted changeset: "[CMake] CMake does not support the dep files for implicit dependency" https://bugs.webkit.org/show_bug.cgi?id=161433 http://trac.webkit.org/changeset/206972 2016-10-10 Youenn Fablet W3C test downloader should be able to import specific files/sub-directories in a skipped directory https://bugs.webkit.org/show_bug.cgi?id=161789 Reviewed by Ryosuke Niwa. Removed tests_directory option and corresponding test. This option was allowing to import a sub-directory from a test repository. We can readd it if necessary. Adding support for finer-grained import rules. Previously skipped directories were fully removed. Now, directories may be skipped but sub directories of them may be imported. This currently happens in web-platform-tests repo. * Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader._add_test_suite_paths): Removing tests_directory option. (TestDownloader.copy_tests): Refactoring file copy by generating the list of all directories for which direct files should be imported. (TestDownloader.copy_tests.should_copy_dir): (TestDownloader.copy_tests.should_copy_file): * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.test_tests_directory): Deleted. (TestImporterTest.test_skip_test_import): Added. 2016-10-09 Simon Fraser Make validate-committer-lists show inactive reviewers https://bugs.webkit.org/show_bug.cgi?id=163193 Reviewed by Sam Weinig. In preparation for updating contributors.json with the WebKit policy of retiring inactive reviewers, make validate-committer-lists show the list of reviewers who have not reviewed in the past year. This list is computed by grepping the output of 'git log --since=1.year" for the reviewer line, and looking up reviewers via Contributor.mentioned_in_text(), which looks for full names, aliases, irc nicks and email addresses. Support for aliases is added to Contributor. Aliases are alternates or misspellings of the reviewer's name. Some common aliases were added to contributors.json by manual examination of "Reviewed by" lines. * Scripts/validate-committer-lists: (CommitterListFromGit.possibly_expired_committers): (CommitterListFromGit): (CommitterListFromGit.possibly_inactive_reviewers): (CommitterListFromGit.print_possibly_expired_committers): (CommitterListFromGit.print_possibly_inactive_reviewers): * Scripts/webkitpy/common/config/committers.py: (Contributor.__init__): (Contributor.contains_string): (Contributor.mentioned_in_text): (Contributor.as_dict): (Committer.__init__): (Reviewer.__init__): (CommitterList.load_json): * Scripts/webkitpy/common/config/contributors.json: 2016-10-09 Simon Fraser Convert contributors.json to a flat list https://bugs.webkit.org/show_bug.cgi?id=163183 Reviewed by Darin Adler. Make contributors.json easier to maintain by eliminating the big groupings ("Committers", "Reviewers" etc) and moving that data to a "status" property on each contributor. * Scripts/webkitpy/common/config/committers.py: (Contributor.__eq__): Implement this to fix unit tests, now that load_json() is not @memoized. (Contributor.as_dict): Include status in the dict. (CommitterList.__init__): Clean up to make the testing code path more explicit. (CommitterList.load_json): (CommitterList.load_test_data): (CommitterList.as_json): (Contributor.__unicode__): Deleted. * Scripts/webkitpy/common/config/contributors.json: * Scripts/webkitpy/tool/bot/irc_command_unittest.py: (IRCCommandTest.test_whois): The ordering here is now alphabetical. 2016-10-09 Fujii Hironori [CMake] CMake does not support the dep files for implicit dependency https://bugs.webkit.org/show_bug.cgi?id=161433 Reviewed by Brent Fulgham. Created a Perl script to generate all IDL bindings for CMake. This script can regenerate outdated bindings by based on the supplemental dependency and dep files created by '--write-dependencies' switch of generate-bindings.pl. add_custom_target is used to invoke the script instead of add_custom_command because Ninja deletes all output files before executing the command in case of add_custom_command. USES_TERMINAL option of add_custom_target has two effects: 1) Not buffering output of the command 2) Invoking the command in the special Ninja pool which inhibits parallel build One needs to use CMake 3.2 or later to enable this feature. * DumpRenderTree/CMakeLists.txt: Specified a target name for GENERATE_BINDINGS. Added dependency for the target. * WebKitTestRunner/CMakeLists.txt: Ditto. 2016-10-09 Simon Fraser Add support for canonicalizing contributors.json, and have check-webkit-style check the format. https://bugs.webkit.org/show_bug.cgi?id=163177 Follow-up fix. For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures. Rename it to as_dict(). * Scripts/webkitpy/common/config/committers.py: (Contributor.as_dict): (CommitterList._contributor_list_to_dict): (Contributor.__dict__): Deleted. 2016-10-08 Simon Fraser Add support for canonicalizing contributors.json, and have check-webkit-style check the format. https://bugs.webkit.org/show_bug.cgi?id=163177 Reviewed by Ryosuke Niwa. Make it possible to round-trip contributors.json through CommitterList, so we can support writing out contributors.json in canonical format. This requires saving the case-preserved email and expertise in Contributor. CommitterList also needs to be able to generate the "exclusive" lists, since it currently uses lists that are the union of, say, committers and reviewers. If contributors.json is malformed (invalid JSON), catch the Exception, report it and exit rather than allowing the exception to propagate. With an invalid file, an exception would be thrown before the JSON style checker reached this file, so the error was not correctly reported. Add style/checker/committer.py for checking that committers.json has the canonical format. Add support to validate-committer-lists to dump out the canonical json (-d) or update the file in-place (-c). * Scripts/validate-committer-lists: (CommitterListFromGit._print_three_column_row): (CommitterListFromGit.possibly_expired_committers): (CommitterListFromGit): (CommitterListFromGit.print_possibly_expired_committers): (main): * Scripts/webkitpy/common/config/committers.py: (Contributor.__init__): (Contributor.__dict__): (Committer.__init__): (Reviewer.__init__): (CommitterList.load_json): (CommitterList): (CommitterList._contributor_list_to_dict): (CommitterList.as_json): (CommitterList.reformat_in_place): (CommitterList._exclusive_contributors): (CommitterList._exclusive_committers): (Contributor.matches_glob): Deleted. (CommitterList.contributors): Deleted. * Scripts/webkitpy/common/config/contributors.json: * Scripts/webkitpy/style/checker.py: (CheckerDispatcher._create_checker): * Scripts/webkitpy/style/checkers/contributors.py: Added. (ContributorsChecker): (ContributorsChecker.__init__): (ContributorsChecker.check): (ContributorsChecker._unidiff_output): 2016-10-06 Darin Adler Next step on moving to modern way to return DOM exceptions https://bugs.webkit.org/show_bug.cgi?id=163016 Reviewed by Ryosuke Niwa. * Scripts/do-webcore-rename: Add proposed name change of setDOMException to propagateException, since this function is primarily used to take an exception already effectively "thrown" by setting an ExceptionCode out argument and propagate it into the JavaScript engine's exception machinery. 2016-10-07 Alex Christensen Non-special URL fragments should percent-encode non-ASCII characters https://bugs.webkit.org/show_bug.cgi?id=163153 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-07 Jonathan Bedard Build fix for “Move functionality common to Darwin ports into a base class” https://bugs.webkit.org/show_bug.cgi?id=160709 Unreviewed build fix. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort._get_crash_log): Added iOS implementation. * Scripts/webkitpy/port/mac.py: (MacPort._get_crash_log): Added Mac implementation. 2016-10-07 Chelsea Pugh Unreviewed. Added myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2016-10-07 Jonathan Bedard Move functionality common to Darwin ports into a base class https://bugs.webkit.org/show_bug.cgi?id=160709 Reviewed by Darin Adler. * Scripts/webkitpy/port/apple.py: (ApplePort.determine_full_port_name): Specific iOS port check. (ApplePort.__init__): Move leak detector to DarwinPort. (ApplePort._make_leak_detector): Moved to DarwinPort. (ApplePort.supports_per_test_timeout): Moved to Port. (ApplePort.check_for_leaks): Moved to DarwinPort. (ApplePort.print_leaks_summary): Moved to DarwinPort. (ApplePort._path_to_webcore_library): Moved to DarwinPort. (ApplePort.show_results_html_file): Moved to DarwinPort. (ApplePort._merge_crash_logs): Moved to DarwinPort. (ApplePort._look_for_all_crash_logs_in_log_dir): Moved to DarwinPort. (ApplePort._get_crash_log): Moved to DarwinPort. (ApplePort.look_for_new_crash_logs): Moved to DarwinPort. (ApplePort.sample_process): Moved to DarwinPort. (ApplePort.sample_file_path): Moved to DarwinPort. (ApplePort.look_for_new_samples): Moved to DarwinPort. * Scripts/webkitpy/port/base.py: (Port.supports_per_test_timeout): Return true for all ports. * Scripts/webkitpy/port/darwin.py: Added. (DarwinPort): Shared iOS and Mac functions. * Scripts/webkitpy/port/darwin_testcase.py: Added. (DarwinTest): Shared iOS and Mac testing. * Scripts/webkitpy/port/efl.py: (EflPort): (EflPort.supports_per_test_timeout): Moved to Port. * Scripts/webkitpy/port/gtk.py: (GtkPort._driver_class): (GtkPort): (GtkPort.supports_per_test_timeout): Moved to Port. * Scripts/webkitpy/port/ios.py: (IOSPort): (IOSPort.operating_system): (IOSSimulatorPort): (IOSSimulatorPort.__init__): Inherits from DarwinPort. (IOSSimulatorPort._port_specific_expectations_files): Moved to DarwinPort. (IOSSimulatorPort._get_crash_log): Deleted. (IOSSimulatorPort.xcrun_find): Deleted. * Scripts/webkitpy/port/ios_unittest.py: Added. (iosTest): Unit tests for the iOS port. * Scripts/webkitpy/port/mac.py: (MacPort): (MacPort.__init__): Inherits from DarwinPort. (MacPort._port_specific_expectations_files): Moved to DarwinPort. (MacPort.make_command): Moved to DarwinPort. (MacPort._get_crash_log): Moved to DarwinPort. (MacPort.nm_command): Moved to DarwinPort. * Scripts/webkitpy/port/mac_unittest.py: (MacTest): (MacTest.test_sdk_name): Added test. (MacTest.test_xcrun): Added test. (MacTest.assert_skipped_file_search_paths): Moved to DarwinTest. (MacTest.test_default_timeout_ms): Moved to DarwinTest. (MacTest.assert_name): Moved to DarwinTest. (MacTest.test_helper_starts): Moved to DarwinTest. (MacTest.test_helper_fails_to_start): Moved to DarwinTest. (MacTest.test_helper_fails_to_stop): Moved to DarwinTest. (MacTest.test_spindump): Moved to DarwinTest. (MacTest.test_sample_process): Moved to DarwinTest. (MacTest.test_sample_process_exception): Moved to DarwinTest. * Scripts/webkitpy/port/port_testcase.py: (PortTestCase): (PortTestCase.test_diff_image): Added is_simulator flag. (PortTestCase.test_diff_image): Skip test if on a simulator. (PortTestCase.test_diff_image_crashed): Skip test if on a simulator. * Scripts/webkitpy/port/win.py: (WinPort): (WinPort.look_for_new_samples): Used default, ApplePort no longer implements. (WinPort.sample_process): Ditto. (WinPort._make_leak_detector): Ditto. (WinPort.check_for_leaks): Ditto. (WinPort.print_leaks_summary): Ditto. (WinPort._path_to_webcore_library): Ditto. 2016-10-07 Anders Carlsson Get rid of WKPageSetSession https://bugs.webkit.org/show_bug.cgi?id=163129 Reviewed by Tim Horton. Rewrite this test to use WKPageConfigurationRef and WKWebsiteDataStoreRef. * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp: (TestWebKitAPI::TEST): 2016-10-07 Andreas Kling [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when evicting from PageCache. Reviewed by Antti Koivisto. Add an API test that puts a 10-subframe page into the page cache, then loads other pages until the first page gets kicked out. The test succeeds if we receive didRemoveFrameFromHierarchy callbacks for all the subframes. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Added. (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::setPageLoaderClient): (TestWebKitAPI::didReceivePageMessageFromInjectedBundle): (TestWebKitAPI::setInjectedBundleClient): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Added. (TestWebKitAPI::didRemoveFrameFromHierarchyCallback): (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::DidRemoveFrameFromHiearchyInPageCacheTest): (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::didCreatePage): * TestWebKitAPI/Tests/WebKit2/many-iframes.html: Added. 2016-10-07 Emanuele Aina Replace bug URL placeholders independently of the short desc one https://bugs.webkit.org/show_bug.cgi?id=161684 Reviewed by Darin Adler. Instead of adding the bug URL when replacing the short description placeholder and then ignoring the bug URL placeholder, use the former to set the short description and the latter for the bug URL. This means that developers can fully prepare the changelog with short and long description before submission leaving the bug placeholder in place, and the changelog machinery will make sure to replace the latter with the URL of the newly created bug while submitting. Note that this also means that the short description placeholder alone no longer causes the bug URL to be added. * Scripts/webkitpy/common/checkout/changelog.py: (ChangeLog.set_short_description_and_bug_url): * Scripts/webkitpy/common/checkout/changelog_unittest.py: (test_set_short_description_and_bug_url): 2016-10-07 Jonathan Bedard Style Checking Error when Objective C Blocks passed as Argument https://bugs.webkit.org/show_bug.cgi?id=162463 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cpp.py: (regex_for_lambdas_and_blocks): Consider case where block is passed as a function argument. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_objective_c_block_as_argument): Test case where block is passed as a function argument. 2016-10-07 Philippe Normand [GTK] Docs build failure https://bugs.webkit.org/show_bug.cgi?id=163102 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: Bump to gtk-doc 1.25 to fix build errors on Debian Testing. 2016-10-06 Joseph Pecoraro check-webkit-style: Enable the legal/copyright rule for cpp/h files https://bugs.webkit.org/show_bug.cgi?id=162707 Reviewed by Darin Adler. * Scripts/webkitpy/style/checker.py: Enable this rule by default. 2016-10-06 Joseph Pecoraro Header guard style should be updated to be "#pragma once" https://bugs.webkit.org/show_bug.cgi?id=159785 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cpp.py: (check_for_header_guard): (_process_lines): Simplify header_guard check to warn for a missing #pragma once in header files. For legacy files that contain an #ifndef only warn if the #ifndef line itself is changing. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTestBase.perform_header_guard_check): (CppStyleTestBase.assert_header_guard): Helpers for enabling just this warning. (CppStyleTest.test_build_header_guard): Test different header guard cases. * Scripts/webkitpy/style/error_handlers.py: (DefaultStyleErrorHandler.should_line_be_checked): Always allow warnings that output for "line 0" which won't be in the list of modified lines that are 1-based. 2016-10-06 Commit Queue Unreviewed, rolling out r206713. https://bugs.webkit.org/show_bug.cgi?id=163097 triggers apparent codegen bug on ARM 32-bit (Requested by smfr on #webkit). Reverted changeset: "Support transitions/animations of background-position with right/bottom-relative values" https://bugs.webkit.org/show_bug.cgi?id=162048 http://trac.webkit.org/changeset/206713 2016-10-06 Alex Christensen URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded https://bugs.webkit.org/show_bug.cgi?id=163089 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkURL): (TestWebKitAPI::TEST_F): 2016-10-06 Alex Christensen Skip tabs and newlines between end of query and beginning of fragment in non-UTF-8-encoded URLs https://bugs.webkit.org/show_bug.cgi?id=163071 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-06 Alex Christensen URLParser should parse file URLs with ports consistently https://bugs.webkit.org/show_bug.cgi?id=163075 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-06 John Wilander Update Resource Load Statistics https://bugs.webkit.org/show_bug.cgi?id=162811 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Change from USE(PUBLIC_SUFFIX_LIST) to ENABLE(PUBLIC_SUFFIX_LIST) 2016-10-05 Philippe Normand [GStreamer][OWR] GL rendering support https://bugs.webkit.org/show_bug.cgi?id=162972 Reviewed by Žan Doberšek. When GStreamer-GL is enabled the GL context needs to be properly passed to the GStreamer pipeline running within the OpenWebRTC video renderer. This is now supported using a new OpenWebRTC API that allows the renderer to request the context from the application using a callback registered within the renderer. * gtk/jhbuild.modules: Bump to latest OpenWebRTC for the new owr_video_renderer_set_request_context_callback API added recently. 2016-10-05 Youenn Fablet Reuse CodeGenerator::UpdateFile in Tools CodeGenerator https://bugs.webkit.org/show_bug.cgi?id=162960 Reviewed by Alex Christensen. * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: (WriteData): Using CodeGenerator::UpdateFile to do lazy generated file update when it is made feasible. * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: (WriteData): Ditto. 2016-10-05 Alex Christensen URLParser should parse IPv4 addresses as the last two pieces of an IPv6 address https://bugs.webkit.org/show_bug.cgi?id=162991 Reviewed by Saam Barati. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-05 Tim Horton Avoid automatically re-taking snapshots for back-forward items that were never loaded into the view https://bugs.webkit.org/show_bug.cgi?id=162955 Reviewed by Simon Fraser. * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: (-[SnapshotTestWKWebView init]): (forceRepaintCallback): (-[SnapshotTestWKWebView synchronouslyForceRepaint]): (-[SnapshotTestWKWebView synchronouslyLoadTestPageAndForceRepaint:]): (TEST): (makeRedSquareView): Add a test that restoring session state into a web view without navigating, then explicitly snapshotting and navigating away, leaves the original snapshot alone. Adjust the existing test, as well, to ensure that it will reliably fail if the feature is broken. Use an explicitly added and removed red square instead of scrolling, because we can't scroll in the restore-without-navigating case. Stop trying to override the window scale, because it's not working (we're getting partial snapshots) and isn't necessary; instead just multiply the expected value by the page scale. (-[SnapshotTestWKWebView loadPageNamed:]): Deleted. * TestWebKitAPI/mac/TestWKWebViewMac.h: * TestWebKitAPI/mac/TestWKWebViewMac.mm: (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Reorganize to reduce duplication. 2016-10-05 Tim Horton Make it possible to test ViewSnapshotStore behaviors https://bugs.webkit.org/show_bug.cgi?id=162983 Reviewed by Simon Fraser. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Added. (-[SnapshotTestWKWebView init]): (-[SnapshotTestWKWebView loadPageNamed:]): (imagesAreEqual): Add tests for existing basic snapshotting behavior: - a back-forward item shouldn't have a snapshot until it is navigated away from - causing a back-forward item to fall out of the back-forward list should remove the snapshot - calling the explicit snapshotting SPI, then navigating away from the page, should result in the snapshot being retaken 2016-10-05 Chris Dumez KeyboardEvent.getModifierState() should support "CapsLock" modifier https://bugs.webkit.org/show_bug.cgi?id=162861 Reviewed by Darin Adler. Add support for 'capsLockKey' modifier for EventSender.keyDown() so that we can test this new modifier support for layout tests. * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::modifierFlagsForWKModifiers): * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::parseModifier): * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::buildModifierFlags): 2016-10-05 Jeremy Jones Add MobileMiniBrowser tests for control center and looping fullscreen. https://bugs.webkit.org/show_bug.cgi?id=162748 Reviewed by Jer Noble. Refactor existing MobileMiniBrowserTests and add new tests for - fullscreen rotation - fullscreen looping (failing) - control center interruption (failing) * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: * MobileMiniBrowser/MobileMiniBrowserFramework/Resources/looping2s.html: Added. * MobileMiniBrowser/MobileMiniBrowserFramework/test2s.mp4: Added. * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: (-[MobileMiniBrowserUITests setUp]): (-[MobileMiniBrowserUITests waitToTapButtonNamed:forApp:]): (-[MobileMiniBrowserUITests loadURL:]): (-[MobileMiniBrowserUITests requireMinFPS:sampleDurationSeconds:message:]): (-[MobileMiniBrowserUITests ensureFullscreenControls]): (-[MobileMiniBrowserUITests timeForTimeString:]): (-[MobileMiniBrowserUITests testBasicVideoPlayback]): (-[MobileMiniBrowserUITests testBasicVideoFullscreen]): (-[MobileMiniBrowserUITests testVideoFullscreenAndRotationAnimation]): (-[MobileMiniBrowserUITests testVideoFullscreenControlCenter]): (-[MobileMiniBrowserUITests testLoopingFullscreenLockup]): 2016-10-05 Alex Christensen URLParser should correctly strip unnecessary 0's in IPv6 addresses https://bugs.webkit.org/show_bug.cgi?id=162979 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-05 Alex Christensen UTF-8 encode queries of nonspecial and websocket schemes https://bugs.webkit.org/show_bug.cgi?id=162956 Reviewed by Geoffrey Garen and Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-05 Alex Christensen Prepare to enable URLParser https://bugs.webkit.org/show_bug.cgi?id=162974 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): Added some tests that are unrelated to the code change, but these are reflected in changed LayoutTest results when enabling the URLParser, and they weren't in the URLParser tests yet. They should be. 2016-10-05 Zan Dobersek Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA https://bugs.webkit.org/show_bug.cgi?id=162903 Reviewed by Alex Christensen. Rename build guards for the remaining implementation of the legacy EME API to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Also remove the ENABLE_IOS_TEXT_AUTOSIZING feature define that was renamed in r206395 and was throwing up style checker errors. 2016-10-04 Andy Estes [iOS] Crash in WebResourceLoaderQuickLookDelegate when the client cancels the navigation to a QuickLook resource https://bugs.webkit.org/show_bug.cgi?id=162950 Reviewed by Brady Eidson. Added a new API test. * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Sorted imports and removed redundant initialization of static bools. (runTest): Factored out the common test logic between QuickLook.NavigationDelegate and QuickLook.CancelNavigationAfterResponse. (TEST): Added QuickLook.CancelNavigationAfterResponse. (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Canceled the navigation. (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true. 2016-10-04 Ryosuke Niwa Add the support for running ES6SampleBench to run-benchmark https://bugs.webkit.org/show_bug.cgi?id=162890 Reviewed by Saam Barati. Added the support for running ES6SampleBench as "es6bench". e.g. ./Tools/Scripts/run-benchmark --platform osx --plan es6bench --browser safari Instead of the default 10 iterations, run the test 4 iterations using 5 instances of browser for the total of 20 iterations. * Scripts/webkitpy/benchmark_runner/data/patches/ES6SampleBench.patch: Added. * Scripts/webkitpy/benchmark_runner/data/plans/es6bench.plan: Added. * Scripts/webkitpy/benchmark_runner/run_benchmark.py: (start): Fixed the bug that the linter will complain about the presence of "debugOutput" by removing it if it's present. 2016-10-04 Simon Fraser [iOS WK2] Make it possible for a test to describe a user gesture as a stream of events in JSON format https://bugs.webkit.org/show_bug.cgi?id=162934 Reviewed by Dean Jackson. With this change, a test can describe a user gesture in an "event stream", which is some JSON describing an array of events with their underlying touches. The added test describes a single tap. The implementation fires up an NSThread, and sleeps the thread between events to dispatch them at close to real time. In future, HIDEventGenerator could use this internally for all of the "compound" interactions. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::sendEventStream): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::sendEventStream): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/HIDEventGenerator.h: * WebKitTestRunner/ios/HIDEventGenerator.mm: (transducerTypeFromString): (phaseFromString): (-[HIDEventGenerator eventMaskFromEventInfo:]): (-[HIDEventGenerator touchFromEventInfo:]): (-[HIDEventGenerator _createIOHIDEventWithInfo:]): (-[HIDEventGenerator dispatchEventWithInfo:]): (-[HIDEventGenerator eventDispatchThreadEntry:]): (-[HIDEventGenerator sendEventStream:completionBlock:]): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::sendEventStream): 2016-10-04 Megan Gardner Add Megan to contributor's list https://bugs.webkit.org/show_bug.cgi?id=162944 Reviewed by Tim Horton. Add Megan to the contributor's lists so that her e-mail autocompletes for CC * Scripts/webkitpy/common/config/contributors.json: 2016-10-04 Alex Christensen Add tests verifying non-special URL hosts are parsed according to spec https://bugs.webkit.org/show_bug.cgi?id=162885 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-04 Anders Carlsson Properly kill web processes in the launching state https://bugs.webkit.org/show_bug.cgi?id=162938 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Enable this test again. 2016-10-04 Alex Christensen URLParser: query-only URLs relative to file URLs should just add a query https://bugs.webkit.org/show_bug.cgi?id=162888 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-04 Alex Christensen URLParser should match URL::parse and other browsers when parsing a URL containing only scheme:// https://bugs.webkit.org/show_bug.cgi?id=162909 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-04 Yusuke Suzuki [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information https://bugs.webkit.org/show_bug.cgi?id=162916 Reviewed by Filip Pizlo. * DumpRenderTree/CMakeLists.txt: 2016-10-04 Wenson Hsieh Media controls are displayed in the incorrect state momentarily after switching between tabs playing media https://bugs.webkit.org/show_bug.cgi?id=162766 Reviewed by Jer Noble. Adds new tests and tweaks existing tests to verify last updated Now Playing information. * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]): (TestWebKitAPI::TEST): (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: 2016-10-03 Alex Christensen URLParser should ignore tabs at all locations https://bugs.webkit.org/show_bug.cgi?id=162836 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkURL): (TestWebKitAPI::checkRelativeURL): (TestWebKitAPI::checkURLDifferences): (TestWebKitAPI::checkRelativeURLDifferences): (TestWebKitAPI::TEST_F): 2016-10-03 Alex Christensen URLParser: fragment-only URLs relative to file URLs should just add a fragment https://bugs.webkit.org/show_bug.cgi?id=162871 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-03 Per Arne Vollan [Win] DRT temp folder is not used. https://bugs.webkit.org/show_bug.cgi?id=162863 Reviewed by Alex Christensen. Convert DRT temp folder to DOS path, which DRT can use. * Scripts/webkitpy/port/driver.py: (Driver._setup_environ_for_driver): 2016-10-03 Alex Christensen URLParser: empty relative URLs should not copy fragment from the base URL https://bugs.webkit.org/show_bug.cgi?id=162864 Reviewed by Chris Dumez. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-10-03 Carlos Garcia Campos [SOUP] Cleanup persistent credential storage code https://bugs.webkit.org/show_bug.cgi?id=162777 Reviewed by Alex Christensen. Use USE(LIBSECRET) instead of ENABLE(CREDENTIAL_STORAGE). * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: (testWebViewAuthenticationStorage): 2016-10-02 Darin Adler Rename ExceptionCode-based exception handling to "legacy" https://bugs.webkit.org/show_bug.cgi?id=162859 Reviewed by Chris Dumez. * Scripts/do-webcore-rename: Updated script to do this round of renames. 2016-10-02 Wenson Hsieh Media controls for Soundcloud easily falls out of sync with what's actually playing https://bugs.webkit.org/show_bug.cgi?id=162843 Reviewed by Beth Dakin. Adds two new tests simulating audio playback behavior on soundcloud. Also tweaks some of the WKWebView test message handling logic to support having multiple message-handler mappings. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Added. * TestWebKitAPI/mac/TestWKWebViewMac.h: * TestWebKitAPI/mac/TestWKWebViewMac.mm: (-[TestMessageHandler addMessage:withHandler:]): (-[TestMessageHandler userContentController:didReceiveScriptMessage:]): (-[TestWKWebView performAfterReceivingMessage:action:]): (-[TestWKWebView performAfterLoading:]): (-[TestMessageHandler initWithMessage:handler:]): Deleted. 2016-09-30 Alex Christensen Fix off-by-one error in URLParser::parseIPv4Host https://bugs.webkit.org/show_bug.cgi?id=162789 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-30 Alex Christensen URLParser: parsing a URL with an empty host and a colon should fail https://bugs.webkit.org/show_bug.cgi?id=162795 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-30 Alex Christensen URLParser: handle syntax violations in non-UTF-8 encoded queries https://bugs.webkit.org/show_bug.cgi?id=162770 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkURL): (TestWebKitAPI::TEST_F): Tests with emoji change behavior when we insert a tab between the surrogates, so don't do the insert-tab-at-each-location verification that syntax violations are handled correctly. 2016-09-30 Megan Gardner Make it possible to test web-related user-interface features https://bugs.webkit.org/show_bug.cgi?id=162657 Reviewed by Simon Fraser. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::contentsOfUserInterfaceItem): (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted. * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::contentsOfUserInterfaceItem): (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted. * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::contentsOfUserInterfaceItem): (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted. 2016-09-29 Jiewen Tan Expose CryptoKey to web workers https://bugs.webkit.org/show_bug.cgi?id=162640 Reviewed by Brent Fulgham. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm: Added. (TestWebKitAPI::TEST_F): Add API tests for SerializedCryptoKeyWrap APIs. 2016-09-29 Alex Christensen Fix syntax violation handling in IPv4 address parsing https://bugs.webkit.org/show_bug.cgi?id=162756 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-29 Alex Christensen URLParser should correctly parse ports with leading 0's https://bugs.webkit.org/show_bug.cgi?id=162752 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-29 Alex Christensen URLParser: make parsing invalid IPv4 addresses more robust and correct https://bugs.webkit.org/show_bug.cgi?id=162746 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-29 Alex Christensen URLParser: IPv6 addresses followed by a colon are invalid https://bugs.webkit.org/show_bug.cgi?id=162747 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-29 Alexey Proskuryakov Make WKTR short timeout dynamic https://bugs.webkit.org/show_bug.cgi?id=162733 Reviewed by Alex Christensen. WebKitTestRunner has a hardcoded value for how long to wait for IPC responses, which is 5 seconds, or 10 seconds under ASan. But some of the operations can be fairly time consuming - e.g. launching Networking process on demand. These may take longer under load, especially with GuardMalloc. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::reattachPageToWebProcess): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::shortTimeout): (WTR::TestInvocation::invoke): (WTR::TestInvocation::dumpResults): * WebKitTestRunner/TestInvocation.h: (WTR::TestInvocation::customTimeout): Deleted, this function was unused. 2016-09-29 Alex Christensen URLParser should fail to parse unclosed IPv6 addresses https://bugs.webkit.org/show_bug.cgi?id=162715 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-29 Alex Christensen URLParser should ignore tabs at all possible locations https://bugs.webkit.org/show_bug.cgi?id=162711 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::ExpectedParts::isInvalid): (TestWebKitAPI::checkURL): (TestWebKitAPI::TEST_F): 2016-09-29 Gyuyoung Kim [EFL] Add search button to url bar in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=162716 Reviewed by Michael Catanzaro. As a bug title, it would be good to add a search button to URL bar. Additionally this patch changes color of button to recognize the buttons. * MiniBrowser/efl/main.c: (_search_button_clicked_cb): (_create_toolbar_button): (window_create): (create_toolbar_button): Deleted. 2016-09-28 Tim Horton API test WebKit2.AutoLayoutIntegration is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=160284 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): (-[AutoLayoutWKWebView beginLayoutAtMinimumWidth:andExpectContentSizeChange:]): (-[AutoLayoutWKWebView waitForContentSizeChangeResettingWidth:]): (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]): (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]): (TEST): Make the autolayout tests a bit more flexible regarding the ordering of invalidateIntrinsicContentSize, to avoid a race between the load completing and the invalidation. Also, move the newly added test to use its own WKWebView, since once in a while we get a first layout notification from the previous page, causing the test to fail. Un-disable the tests, which now run without any flakes for me with quite a few iterations. 2016-09-28 Alex Christensen URLParser should properly handle unexpected periods and overflows in IPv4 addresses https://bugs.webkit.org/show_bug.cgi?id=162655 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-28 Ryan Haddad Disable flaky API test WebKit2.AutoLayoutIntegration. https://bugs.webkit.org/show_bug.cgi?id=160284 Unreviewed test gardening. * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: (TEST): 2016-09-28 Alex Christensen URLParser should ignore tabs in authority https://bugs.webkit.org/show_bug.cgi?id=162694 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-28 Alex Christensen URLParser should ignore extra slashes after scheme:// and handle a missing slash after the port https://bugs.webkit.org/show_bug.cgi?id=162690 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-28 Alex Christensen URLParser should correctly canonicalize uppercase IPv6 addresses https://bugs.webkit.org/show_bug.cgi?id=162680 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-27 Wenson Hsieh Adopt MediaRemote SPI to achieve desired Now Playing behavior https://bugs.webkit.org/show_bug.cgi?id=162658 Reviewed by Jer Noble. Introduces 2 unit tests in the new NowPlayingControlsTests test suite. Also provides some basic support for mocking key window status for TestWKWebViews. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Added. (-[NowPlayingTestWebView hasActiveNowPlayingSession]): (-[NowPlayingTestWebView expectHasActiveNowPlayingSession:]): (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Added. * TestWebKitAPI/mac/TestWKWebViewMac.mm: (-[TestWKWebViewHostWindow isKeyWindow]): (-[TestWKWebViewHostWindow makeKeyWindow]): (-[TestWKWebViewHostWindow resignKeyWindow]): 2016-09-28 Per Arne Vollan [Win] Compile fix. https://bugs.webkit.org/show_bug.cgi?id=162670 Reviewed by Brent Fulgham. Make sure we include JavaScriptCore files from the forwarding headers folder. Otherwise we might get multiple definitions if a JSC file is included both from the forwarding headers folder and the JSC source folder, since #pragma once is used in the header files. * DumpRenderTree/TestRunner.cpp: 2016-09-28 Michael Catanzaro [GTK] Add Chrome UA quirk https://bugs.webkit.org/show_bug.cgi?id=162617 Reviewed by Carlos Garcia Campos. Update test. This portion of the commit was actually unreviewed. * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): 2016-09-28 Michael Catanzaro [GTK] Adjust OS X UA quirks list https://bugs.webkit.org/show_bug.cgi?id=162616 "Reviewed" by Carlos Garcia Campos. Update test. This portion of the commit was actually unreviewed. * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): 2016-09-28 Carlos Garcia Campos [GTK] Switch to use GMenu internally in the context menu implementation https://bugs.webkit.org/show_bug.cgi?id=162603 Reviewed by Michael Catanzaro. Remove smart separators test, since that's now done automatically by GTK+. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (beforeAll): (testContextMenuWebExtensionMenu): Deleted. 2016-09-27 Alex Christensen Correctly parse URLs with the first tab in the fragment https://bugs.webkit.org/show_bug.cgi?id=162650 Reviewed by Saam Barati. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-27 Alex Christensen URLParser: Handle windows drive letters after two slashes in relative URLs according to spec https://bugs.webkit.org/show_bug.cgi?id=162646 Reviewed by Saam Barati. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-27 Alex Christensen URLs with @ in the user should only search for the last @ until the end of the authority and host https://bugs.webkit.org/show_bug.cgi?id=162635 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-27 JF Bastien Speed up Heap::isMarkedConcurrently https://bugs.webkit.org/show_bug.cgi?id=162095 Reviewed by Filip Pizlo. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/Consume.cpp: Added. (testConsume): (TestWebKitAPI::TEST): 2016-09-26 Alex Christensen Implement URLParser::syntaxViolation https://bugs.webkit.org/show_bug.cgi?id=162593 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-27 Anders Carlsson Turns out OptionSet.cpp wasn't added to the right target. Add it and fix the build for real. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/OptionSet.cpp: (TestWebKitAPI::TEST): 2016-09-27 Anders Carlsson Try to fix the GTK+ build. * TestWebKitAPI/Tests/WTF/OptionSet.cpp: (TestWebKitAPI::TEST): 2016-09-27 Dan Bernstein [iOS] REGRESSION (r182126): Selection highlight and handles aren’t visible with WKSelectionGranularityCharacter https://bugs.webkit.org/show_bug.cgi?id=162577 Reviewed by Simon Fraser. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::selectionRangeViewRects): Returns null. * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Declared new selectionRangeViewRects attribute. * TestRunnerShared/UIScriptContext/UIScriptContext.h: (WTR::UIScriptContext::jsContext): Added this public accessor. * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::selectionRangeViewRects): Generic implementation that returns null. * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/TestController.cpp: (WTR::updateTestOptionsFromTestHeader): Parse the new useCharacterSelectionGranularity option. * WebKitTestRunner/TestOptions.h: Added new useCharacterSelectionGranularity option. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): Set the configuration’s selectionGranularity property based on the new option. * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::viewSupportsOptions): Compare selection granularity option values. * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::selectionRangeViewRects): iOS-specific implementation that calls the new -[WKWebView _uiTextSelectionRectViews] and returns an array of view frame dictionaries. 2016-09-27 Daniel Bates Cannot run dump-class-layout; dies with "global name 'lldb' is not defined" https://bugs.webkit.org/show_bug.cgi?id=162585 Reviewed by Simon Fraser. Import the lldb module into the global namespace. Currently dump-class-layout imports the lldb Python module using the import statement from the helper function import_lldb. The import statement imports the names of the specified module into the scope of import_lldb(); => the names imported from this module cannot be accessed outside the scope of import_lldb(). Other functions in this script assume that the lldb module was imported into the global scope. We should import the module lldb into the global scope, if it exists, so that these functions can find it. Otherwise, we should emit a human readable error message that explains that we failed to import the lldb module. Also remove some unnecessary semicolon characters. * Scripts/dump-class-layout: (import_lldb): 2016-09-27 Jer Noble Remove deprecated ENCRYPTED_MEDIA implementation. https://bugs.webkit.org/show_bug.cgi?id=161010 Reviewed by Eric Carlson. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-09-27 Chris Dumez [WK2] Navigating to a Blob URL does not trigger a download https://bugs.webkit.org/show_bug.cgi?id=162574 Reviewed by Darin Adler. Add API that tests navigating to a Blob URL and checks that that the load properly gets converted into a download. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[BlobDownloadDelegate _downloadDidStart:]): (-[BlobDownloadDelegate _download:didReceiveResponse:]): (-[BlobDownloadDelegate _download:didReceiveData:]): (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]): (-[BlobDownloadDelegate _downloadDidFinish:]): (-[DownloadBlobURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Added. 2016-09-27 Michael Catanzaro [GTK] Install binaries to pkglibexecdir rather than bindir https://bugs.webkit.org/show_bug.cgi?id=162602 Reviewed by Carlos Garcia Campos. Install MiniBrowser to LIBEXEC_INSTALL_DIR rather than EXEC_INSTALL_DIR. * MiniBrowser/gtk/CMakeLists.txt: 2016-09-27 Gyuyoung Kim [EFL] Locate color picker popup to center of window https://bugs.webkit.org/show_bug.cgi?id=162540 Reviewed by Michael Catanzaro. Color picker popup hasn't located in a center of main window, because elm_win_center() function doesn't work correctly. It looks a bug. To fix the problem, this patch uses evas_object_geometry_set() instead. * MiniBrowser/efl/main.c: (_color_picker_request_cb): 2016-09-27 Michael Catanzaro [GTK] Disable ACCELERATED_2D_CANVAS when using build-webkit https://bugs.webkit.org/show_bug.cgi?id=162600 Reviewed by Carlos Garcia Campos. * Scripts/webkitperl/FeatureList.pm: 2016-09-27 Michael Catanzaro PyGIWarnings printed by webkit-patch https://bugs.webkit.org/show_bug.cgi?id=152470 Reviewed by Carlos Garcia Campos. Update to a newer version of the keyring module, since this bug has been fixed upstream for a while. But be careful not to update to the latest version, since it has some compatibility breaks and requires the SecretService python module on Linux, but I couldn't figure out how to autoinstall it successfully. * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook._install_keyring): 2016-09-26 Ryan Haddad Add Sierra to the flakiness dashboard. https://bugs.webkit.org/show_bug.cgi?id=162509 Reviewed by Alexey Proskuryakov. * TestResultServer/static-dashboards/builders.jsonp: 2016-09-26 Daniel Bates Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING https://bugs.webkit.org/show_bug.cgi?id=162365 Reviewed by Simon Fraser. * DumpRenderTree/TestRunner.h: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-09-26 Tomas Popela [GTK] TestContextMenu is failing https://bugs.webkit.org/show_bug.cgi?id=162569 We cannot use the MP3 file in the TestContextMenu, as it will not work by default on most distributions (that don't have an MP3 codecs installed). Change the test to use OGG file instead. Reviewed by Michael Catanzaro. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (testContextMenuDefaultMenu): 2016-09-26 Yusuke Suzuki Using char16_t instead of wchar_t in TestWebKitAPI URLParser tests https://bugs.webkit.org/show_bug.cgi?id=162537 Reviewed by Alex Christensen. Some build bot (Linux ARM GTK port) fails since we cannot select the specific StringBuilder::append method for wchar_t. wchar_t implementation highly depends on platforms. sizeof(wchar_t) == 2 in Windows, while sizeof(wchar_t) == 4 in Linux and OS X. So, ICU uses wchar_t for UChar (UTF-16) in Windows while it doesn't in other platforms. StringBuilder::append is overloaded for UChar. In Windows, we can pass wchar_t since UChar is wchar_t. However, we cannot do that in other platforms. Instead of using wchar_t, we use more platform portable UTF-16 literal for testing. Use char16_t and C++11 UTF-16 literal. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::utf16String): (TestWebKitAPI::TEST_F): (TestWebKitAPI::wideString): Deleted. 2016-09-25 Gyuyoung Kim [EFL] Adjust EFL indentation to EFL MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=162542 Unreviewed, EFL simple coding style fix. Some functions wasn't applied EFL coding style in prefix fix. * MiniBrowser/efl/main.c: (_key_down_cb): (view_focus_set): (_mouse_down_cb): (title_set): (_title_changed_cb): (_url_changed_cb): (_back_forward_list_changed_cb): (_progress_cb): (_error_cb): (_download_request_cb): (close_file_picker): (_filepicker_parent_deletion_cb): (_filepicker_deletion_cb): (_fileselector_done_cb): (_file_chooser_request_cb): (_download_finished_cb): (_download_failed_cb): (_color_changed_cb): (_color_item_selected_cb): (_color_picker_ok_clicked_cb): (_color_picker_cancel_clicked_cb): (_color_picker_dismiss_cb): (_color_picker_request_cb): (quit): (has_scheme): (url_from_user_input): (url_load_from_user_input): (_url_bar_activated_cb): (_url_bar_clicked_cb): (_search_field_aborted_cb): (_search_field_activated_cb): (_search_field_clicked_cb): (_back_button_clicked_cb): (_forward_button_clicked_cb): (_search_backward_button_clicked_cb): (_search_forward_button_clicked_cb): (_search_case_option_changed): (_search_word_start_option_changed_cb): (_search_close_button_clicked_cb): (_refresh_button_clicked_cb): (_stop_button_clicked_cb): (list_item_label_get): (_list_item_select_cb): (navigation_button_longpress_process): (_forward_button_longpress_cb): (_back_button_longpress_cb): (quit_event_loop): (_ok_clicked_cb): (_file_entry_dialog_show): 2016-09-24 Chris Dumez [WK2] anchor.download attribute value is ignored by NETWORK_SESSION code path https://bugs.webkit.org/show_bug.cgi?id=162531 Reviewed by Darin Adler. Update decideDestinationWithSuggestedFilename() to return a actual file path instead of nullptr. The NETWORK_SESSION code path cancels the download when decideDestinationWithSuggestedFilename() returns an empty file path, unlike the !NETWORK_SESSION code path that just continue downloading without explicitely setting a destination path. This lead to different test results for NETWORK_SESSION and !NETWORK_SESSION code paths. Returns a valid destination path makes more sense and leads to consistent results. * WebKitTestRunner/TestController.cpp: (WTR::TestController::decideDestinationWithSuggestedFilename): 2016-09-23 Wenson Hsieh [mac-sierra] 2 WKWebViewCandidateTests API test failures https://bugs.webkit.org/show_bug.cgi?id=162470 Reviewed by Tim Horton. VideoControlsManager, WKWebViewCandidateTests and CandidateTests should not be running on 10.12.0. Guard these tests with an SDK check to prevent 10.12.0 bots from building them. * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: * TestWebKitAPI/Tests/mac/CandidateTests.mm: 2016-09-23 Alex Christensen Refactor URLParser https://bugs.webkit.org/show_bug.cgi?id=162516 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-23 Caitlin Potter [JSC] Implement parsing of Async Functions https://bugs.webkit.org/show_bug.cgi?id=161409 Reviewed by Yusuke Suzuki. * Scripts/build-jsc: (cMakeArgsFromFeatures): * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-09-23 Alex Christensen Refactor URLParser https://bugs.webkit.org/show_bug.cgi?id=162511 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): (TestWebKitAPI::checkURL): 2016-09-23 Alexey Proskuryakov iOS playback user action tests fail on some machines https://bugs.webkit.org/show_bug.cgi?id=162504 rdar://problem/28013994 Reviewed by Jer Noble. Avoid the need to have a timeout. * TestWebKitAPI/Tests/WebKit/ios/audio-only.html: * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: 2016-09-23 Carlos Garcia Campos REGRESSION(r204163): [GTK] API test /webkit2/WebKitSecurityManager/file-xhr is failing https://bugs.webkit.org/show_bug.cgi?id=161607 Reviewed by Michael Catanzaro. Since r204163, in case of cross origin error when loading the XHR, the load fails and an error message is shown in the console, but there isn't any js expcetion, which is what we were checking. Now, we check that there aren't exceptions, and that the error message is sent to the console. * Scripts/run-gtk-tests: (TestRunner): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (consoleMessageReceivedCallback): (testWebContextSecurityFileXHR): 2016-09-23 Ryan Haddad Use correct hardware for Sierra Debug WK2 testers. https://bugs.webkit.org/show_bug.cgi?id=162474 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/config.json: 2016-09-23 Carlos Garcia Campos [GTK] Make all WebView tests have a WebKitUserContentManager https://bugs.webkit.org/show_bug.cgi?id=162487 Reviewed by Michael Catanzaro. It simplifies tests using the user content manager, and allows to use it without having to subclass WebViewTest. * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: (ConsoleMessageTest::ConsoleMessageTest): (ConsoleMessageTest::~ConsoleMessageTest): * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: (testUserContentManagerInjectedStyleSheet): (testUserContentManagerInjectedScript): (UserScriptMessageTest::UserScriptMessageTest): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewIsPlayingAudio): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::WebViewTest): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: 2016-09-23 Antoine Quint Add a new runtime flag for work on modern media controls (off by default) https://bugs.webkit.org/show_bug.cgi?id=162420 Reviewed by Eric Carlson. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): * Scripts/webkitperl/FeatureList.pm: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setModernMediaControlsEnabled): * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-09-23 Carlos Garcia Campos REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale https://bugs.webkit.org/show_bug.cgi?id=162139 Reviewed by Michael Catanzaro. Add test cases to check the behavior when using the C locale and an invalid locale. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextLanguages): 2016-09-22 Hunseop Jeong [EFL] alert box is not displayed https://bugs.webkit.org/show_bug.cgi?id=156395 Reviewed by Gyuyoung Kim. Some popup objects(alert, confirm, prompt, file entry dialog) used the ecore_main_loop_begin() to make the modal popup but ecore_main_loop_begin() was not executed inside an exisiting main loop. So we have to use the ecore_main_loop_iterate() instead of the ecore_main_loop_begin(). * MiniBrowser/efl/main.c: (_ok_clicked_cb): (_file_entry_dialog_show): (_javascript_alert_cb): (_javascript_confirm_cb): (_javascript_prompt_cb): (quit_event_loop): Deleted. 2016-09-22 Matthew Hanson Add an API for getting the branch identifier from a Git or SVN checkout. https://bugs.webkit.org/show_bug.cgi?id=151570 rdar://problem/17959831 Reviewed by David Kilzer. This patch adds a function called svnIdentifierForPath. This function returns either "trunk", the name of the tag, or the name of the branch, as appropriate. This function is necessary for a VCSUtils client that is not checked in to the WebKit project. This patch also breaks up pathRelativeToSVNRepositoryRootForPath into four functions: - pathRelativeToSVNRepositoryRootForPath - svnInfoForPath - svnURLForPath - svnRepositoryRootForPath This allows us to reuse logic from pathRelativeToSVNRepositoryRootForPath in svnIdentifierForPath and allows clients of VCSUtils to extract what arbitrary information from the `svn info` command regardless of SCM. * Scripts/VCSUtils.pm: (svnInfoForPath): Copied logic that previously lived in pathRelativeToSVNRepositoryRootForPath. Make code safe to use for a path, and not just for the CWD. (svnURLForPath): Calls svnInfoForPath and extracts the URL. (svnRepositoryRootForPath): Calls svnInfoForPath and extracts the Repository Root. (svnIdentifierForPath): Calls pathRelativeToSVNRepositoryRootForPath and extracts the repository identifier. (pathRelativeToSVNRepositoryRootForPath): Now uses svnURLForPath and svnRepositoryRootForPath instead of being responsible for determining both values. 2016-09-22 Megan Gardner Add long press selection test https://bugs.webkit.org/show_bug.cgi?id=162367 Reviewed by Simon Fraser. Add support to UIScriptController to synthesize long press events on iOS. This required adding long-press functionality to HIDEventGenerator. HIDEventGenerator sends the touchDown, but must then send the touchUp with a dispatch_after (rather than sleeping, as we do for other events) in order for the gesture recognizers to correctly detect a long press. Use the long press synthesis in a test that detects whether a long press gesture triggers text selection. Fixed incorrect constants. NSTimeInterval is in seconds, original numbers were nanoseconds and typedefed to long without regard to the type differences. Redid constants to be the right value, and converted upon use. Cleaned up unused enum types. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::longPressAtPoint): (WTR::UIScriptController::forcePressAtPoint): (WTR::UIScriptController::dragFromPointToPoint): Deleted. * Scripts/webkitpy/common/config/contributors.json: * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::longPressAtPoint): (WTR::UIScriptController::forcePressAtPoint): (WTR::UIScriptController::dragFromPointToPoint): Deleted. * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/HIDEventGenerator.h: * WebKitTestRunner/ios/HIDEventGenerator.mm: (-[HIDEventGenerator _createIOHIDEventType:]): (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]): (-[HIDEventGenerator clearTap:]): (-[HIDEventGenerator longPressTimerCall:]): (-[HIDEventGenerator longPressFinish:completionBlock:]): (-[HIDEventGenerator longPress:completionBlock:]): (-[HIDEventGenerator forcePress:completionBlock:]): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::longPressAtPoint): (WTR::UIScriptController::forcePressAtPoint): (WTR::UIScriptController::dragFromPointToPoint): Deleted. 2016-09-22 Jonathan Bedard Automatic Text Replacement Testing in WebKit2 https://bugs.webkit.org/show_bug.cgi?id=161919 Reviewed by Ryosuke Niwa. Implemented test hooks for text replacement for WebKit2. Note that spell checking has not been implemented, so most tests which use text replacement still fail. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Removed setAutomaticLinkDetectionEnabled from TestRunner, moved to Internals. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto. (WTR::InjectedBundle::beginTesting): Ditto. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto. * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto. * WebKitTestRunner/TestController.cpp: (WTR::TestController::runTest): Place TextChecker into testing mode. 2016-09-21 Dan Bernstein [macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated https://bugs.webkit.org/show_bug.cgi?id=162359 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: (TEST): 2016-09-21 Keith Miller Fix build for future versions of Clang. https://bugs.webkit.org/show_bug.cgi?id=162346 Reviewed by Filip Pizlo. * TestWebKitAPI/Counters.cpp: * TestWebKitAPI/Counters.h: (DeleterCounter::deleterCount): (DeleterCounter::TestingScope::TestingScope): (DeleterCounter::operator()): * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): 2016-09-21 Commit Queue Unreviewed, rolling out r206222 and r206227. https://bugs.webkit.org/show_bug.cgi?id=162361 "broke the windows build" (Requested by keith_mi_ on #webkit). Reverted changesets: "Fix build for future versions of Clang." https://bugs.webkit.org/show_bug.cgi?id=162346 http://trac.webkit.org/changeset/206222 "Attempt to fix windows build after r206222." http://trac.webkit.org/changeset/206227 2016-09-21 Alex Christensen URLParser should match URL::parse when parsing data urls with slashes in them https://bugs.webkit.org/show_bug.cgi?id=162352 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-21 Alex Christensen URLParser should fail when parsing invalid relative URLs with no schemes https://bugs.webkit.org/show_bug.cgi?id=162355 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-21 Keith Miller Fix build for future versions of Clang. https://bugs.webkit.org/show_bug.cgi?id=162346 Reviewed by Filip Pizlo. * TestWebKitAPI/Counters.cpp: * TestWebKitAPI/Counters.h: (DeleterCounter::deleterCount): (DeleterCounter::TestingScope::TestingScope): (DeleterCounter::operator()): * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): 2016-09-21 Alex Christensen Prepare API tests for enabling URLParser by default https://bugs.webkit.org/show_bug.cgi?id=162341 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkURL): (TestWebKitAPI::checkRelativeURL): (TestWebKitAPI::checkURLDifferences): (TestWebKitAPI::checkRelativeURLDifferences): (TestWebKitAPI::shouldFail): 2016-09-21 Alex Christensen URLParser: Correctly parse URLs that are just nonspecialscheme:/ https://bugs.webkit.org/show_bug.cgi?id=162340 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-21 Alex Christensen URLParser: correctly parse relative URLs that are just one character https://bugs.webkit.org/show_bug.cgi?id=162344 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-20 Alex Christensen Optimize URLParser https://bugs.webkit.org/show_bug.cgi?id=162105 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-20 Aakash Jain enable remote_api (for debugging) in flakiness dashboard app https://bugs.webkit.org/show_bug.cgi?id=162325 Reviewed by Alexey Proskuryakov. * TestResultServer/app.yaml: enabled remote_api and datastore_admin. 2016-09-20 Ryan Haddad Unreviewed, rolling out r206180. Roll r206178 back in as the necessary changes have been made on the build master. Reverted changeset: "Unreviewed, rolling out r206178." https://bugs.webkit.org/show_bug.cgi?id=162249 http://trac.webkit.org/changeset/206180 2016-09-20 Alexey Proskuryakov Use a hardcoded patch for sRGB color profile https://bugs.webkit.org/show_bug.cgi?id=162320 rdar://problem/28387318 Reviewed by Simon Fraser. This is a workaround for rdar://problem/28392768 * DumpRenderTree/mac/LayoutTestHelper.m: (installLayoutTestColorProfile): 2016-09-20 Ryan Haddad Unreviewed, rolling out r206178. This change caused buildbot config issues. Reverted changeset: "Add Sierra bots to buildbot and dashboard." https://bugs.webkit.org/show_bug.cgi?id=162249 http://trac.webkit.org/changeset/206178 2016-09-20 Dean Johnson Add Sierra bots to buildbot and dashboard. https://bugs.webkit.org/show_bug.cgi?id=162249 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): 2016-09-20 Alex Christensen Reduce allocations in URLParser https://bugs.webkit.org/show_bug.cgi?id=162241 Reviewed by Chris Dumez. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): (TestWebKitAPI::checkURL): 2016-09-20 Alex Christensen Align URLParser with web platform tests when parsing non-special relative URLs ending in AuthorityOrHost state https://bugs.webkit.org/show_bug.cgi?id=162251 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkURL): (TestWebKitAPI::TEST_F): (TestWebKitAPI::checkRelativeURL): (TestWebKitAPI::checkURLDifferences): (TestWebKitAPI::checkRelativeURLDifferences): 2016-09-20 Alex Christensen URLParser should allow '@' in user https://bugs.webkit.org/show_bug.cgi?id=162272 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-20 Alex Christensen URLParser: Fix parsing relative URLs with one slash after the scheme: https://bugs.webkit.org/show_bug.cgi?id=162294 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-20 Alex Christensen Fix Windows file URL quirks in URLParser https://bugs.webkit.org/show_bug.cgi?id=162303 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-20 Filip Pizlo Make MarkedBlock state tracking support overlapped allocation and marking state https://bugs.webkit.org/show_bug.cgi?id=161581 Reviewed by Geoffrey Garen. Remove the always-trigger-copy-phase configuration. * Scripts/run-jsc-stress-tests: 2016-09-20 Don Olmstead [WinCairo] Use find_package cairo in build https://bugs.webkit.org/show_bug.cgi?id=162239 Reviewed by Alex Christensen. * DumpRenderTree/PlatformWin.cmake: * TestWebKitAPI/PlatformWin.cmake: 2016-09-20 Wenson Hsieh Unreviewed build fix on 10.10 bots. * TestWebKitAPI/mac/TestWKWebViewMac.h: 2016-09-20 Wenson Hsieh VideoControlsManager.VideoControlsManagerSingleLargeVideo fails intermittently on the Mac WK2 bot https://bugs.webkit.org/show_bug.cgi?id=162255 Reviewed by Jer Noble. This is reproducible by running the test repeatedly in a for loop (locally, I observed that running the test back-to-back would result in the second one failing). This suggests that even on the runloop after the video starts playing, the state of the playback controls manager may not be up to date in the UI process. Instead, we can just spin the runloop until the playback controls are shown, which makes back-to-back tests to succeed and will probably address flakiness on the bots for this test. * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: 2016-09-20 Per Arne Vollan [Win] Run layout tests in parallel. https://bugs.webkit.org/show_bug.cgi?id=162145 Reviewed by Brent Fulgham. To speed up layout tests, try running them in parallel. * Scripts/webkitpy/port/win.py: (WinPort.default_child_processes): Deleted. 2016-09-19 Wenson Hsieh Unreviewed build fix after r206135 NSEventMaskLeftMouseDown and friends are only available on 10.12. * TestWebKitAPI/mac/TestWKWebViewMac.mm: (__simulated_forceClickAssociatedEventsMask): 2016-09-19 Wenson Hsieh Add a unit test covering https://bugs.webkit.org/show_bug.cgi?id=162112 Reviewed by Beth Dakin. Adds a new unit test covering the changes in r205983 along with the infrastructure needed to support it. Also further refactors the TestWKWebView used by VideoControlsManager and WKWebViewCandidateTests so that in both cases, we add the WKWebView to a visible key window, and when sending a mouse down event, we propagate the event at the window level rather than the view level, allowing greater flexibility to simulate behaviors such as pressure-sensitive events that are needed for the new test. Also rewrites currently disabled unit tests in CandidateTests as WebKit2 unit tests in WKWebViewCandidateTests, checking whether or not to should be requesting candidates in password and non-password fields. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: (-[CandidateTestWebView typeString:inputMessage:]): (+[CandidateTestWebView setUpWithFrame:testPage:]): * TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Added. * TestWebKitAPI/mac/TestWKWebViewMac.h: * TestWebKitAPI/mac/TestWKWebViewMac.mm: (__simulated_forceClickAssociatedEventsMask): (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]): (-[TestWKWebView initWithFrame:]): (-[TestWKWebView initWithFrame:configuration:]): (-[TestWKWebView _setUpTestWindow:]): (-[TestWKWebView mouseDownAtPoint:simulatePressure:]): (-[TestWKWebView typeCharacter:]): (-[TestWKWebView mouseDownAtPoint:]): Deleted. 2016-09-19 Alex Christensen URLParser can read memory out of bounds https://bugs.webkit.org/show_bug.cgi?id=162206 Reviewed by Geoff Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-19 Daniel Bates Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code https://bugs.webkit.org/show_bug.cgi?id=162167 Reviewed by Simon Fraser. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-09-19 Nan Wang AX: Add accessibility support for details element on iOS https://bugs.webkit.org/show_bug.cgi?id=162041 Reviewed by Chris Fleizach. * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::isExpanded): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::isExpanded): 2016-09-18 Gyuyoung Kim [EFL] Bump efl library to 1.18.1 https://bugs.webkit.org/show_bug.cgi?id=162120 Reviewed by Michael Catanzaro. * efl/jhbuild.modules: Use efl-1.18.1 instead of 1.18. 2016-09-18 Gyuyoung Kim [EFL] Adjust EFL coding style to EFL MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=162119 Reviewed by Michael Catanzaro. Apply EFL coding style to main.c for MiniBrowser. - Use _foo_cb instead of on_foo for callback function - Use 3 spaces and use 2 spaces in keywords. - EFL coding style. https://phab.enlightenment.org/w/coding_convention/ Additionally this patch adds an exception rule that style checker doesn't check indentation rule in EFL MiniBrowser. * MiniBrowser/efl/main.c: (miniBrowserViewSmartClass): (window_find_with_ewk_view): (_tooltip_show): (window_tooltip_hide): (window_tooltip_update): (_mouse_in_cb): (_mouse_move_cb): (_mouse_out_cb): (_mouse_wheel_cb): (_window_resize_cb): (update_view_favicon): (_icon_changed_cb): (window_free): (window_close): (search_icon_show): (search_box_show): (search_box_hide): (history_list_hide): (save_page_contents_callback): (script_execute_callback): (toggle_window_fullscreen): (_key_down_cb): (_mouse_down_cb): (_title_changed_cb): (_url_changed_cb): (_back_forward_list_changed_cb): (_progress_cb): (_error_cb): (_download_request_cb): (close_file_picker): (_filepicker_parent_deletion_cb): (_filepicker_deletion_cb): (_fileselector_done_cb): (_file_chooser_request_cb): (_download_finished_cb): (_download_failed_cb): (_color_changed_cb): (_color_item_selected_cb): (_color_picker_ok_clicked_cb): (_color_picker_cancel_clicked_cb): (_color_picker_dismiss_cb): (_color_picker_request_cb): (_url_bar_activated_cb): (_url_bar_clicked_cb): (_search_field_aborted_cb): (_search_field_activated_cb): (_search_field_clicked_cb): (_back_button_clicked_cb): (_forward_button_clicked_cb): (_search_backward_button_clicked_cb): (_search_forward_button_clicked_cb): (_search_case_option_changed): (_search_word_start_option_changed_cb): (_search_close_button_clicked_cb): (_refresh_button_clicked_cb): (_stop_button_clicked_cb): (_list_item_select_cb): (navigation_button_longpress_process): (_forward_button_longpress_cb): (_back_button_longpress_cb): (_ok_clicked_cb): (_file_entry_dialog_show): (_javascript_alert_cb): (_javascript_confirm_cb): (_javascript_prompt_cb): (_javascript_before_unload_confirm_cb): (_popup_menu_item_clicked_cb): (popup_menu_populate): (_popup_menu_show): (_popup_menu_hide): (_window_geometry_get): (_window_geometry_set): (_fullscreen_accept_cb): (_fullscreen_deny_cb): (_fullscreen_enter_cb): (_fullscreen_exit_cb): (_window_create_cb): (_window_close_cb): (_context_menu_item_selected_cb): (context_menu_populate): (_context_menu_show): (_context_menu_hide): (auth_popup_close): (_auth_cancel_cb): (_auth_ok_cb): (_authentication_request_cb): (_search_text_found_cb): (_tooltip_text_set): (_tooltip_text_unset): (_navigation_policy_decision_cb): (_home_button_clicked_cb): (_window_deletion_cb): (create_toolbar_button): (window_create): (configuration): (parse_cookies_policy): (parse_window_size): (elm_main): (on_tooltip_show): Deleted. (on_mouse_in): Deleted. (on_mouse_move): Deleted. (on_mouse_out): Deleted. (on_mouse_wheel): Deleted. (on_window_resize): Deleted. (on_icon_changed_cb): Deleted. (on_key_down): Deleted. (on_mouse_down): Deleted. (on_title_changed): Deleted. (on_url_changed): Deleted. (on_back_forward_list_changed): Deleted. (on_progress): Deleted. (on_error): Deleted. (on_download_request): Deleted. (on_filepicker_parent_deletion): Deleted. (on_filepicker_deletion): Deleted. (on_fileselector_done): Deleted. (on_file_chooser_request): Deleted. (on_download_finished): Deleted. (on_download_failed): Deleted. (on_color_changed): Deleted. (on_color_item_selected): Deleted. (on_color_picker_ok_clicked): Deleted. (on_color_picker_cancel_clicked): Deleted. (on_color_picker_dismiss): Deleted. (on_color_picker_request): Deleted. (on_url_bar_activated): Deleted. (on_url_bar_clicked): Deleted. (on_search_field_aborted): Deleted. (on_search_field_activated): Deleted. (on_search_field_clicked): Deleted. (on_back_button_clicked): Deleted. (on_forward_button_clicked): Deleted. (on_search_backward_button_clicked): Deleted. (on_search_forward_button_clicked): Deleted. (on_search_case_option_changed): Deleted. (on_search_word_start_option_changed): Deleted. (on_search_close_button_clicked): Deleted. (on_refresh_button_clicked): Deleted. (on_stop_button_clicked): Deleted. (on_list_item_select): Deleted. (on_forward_button_longpress): Deleted. (on_back_button_longpress): Deleted. (on_ok_clicked): Deleted. (show_file_entry_dialog): Deleted. (on_javascript_alert): Deleted. (on_javascript_confirm): Deleted. (on_javascript_prompt): Deleted. (on_javascript_before_unload_confirm): Deleted. (on_popup_menu_item_clicked): Deleted. (on_popup_menu_show): Deleted. (on_popup_menu_hide): Deleted. (on_window_geometry_get): Deleted. (on_window_geometry_set): Deleted. (on_fullscreen_accept): Deleted. (on_fullscreen_deny): Deleted. (on_fullscreen_enter): Deleted. (on_fullscreen_exit): Deleted. (on_window_create): Deleted. (on_window_close): Deleted. (context_menu_item_selected_cb): Deleted. (on_context_menu_show): Deleted. (on_context_menu_hide): Deleted. (on_auth_cancel): Deleted. (on_auth_ok): Deleted. (on_authentication_request): Deleted. (on_search_text_found): Deleted. (on_tooltip_text_set): Deleted. (on_tooltip_text_unset): Deleted. (on_navigation_policy_decision): Deleted. (on_home_button_clicked): Deleted. (on_window_deletion): Deleted. * Scripts/webkitpy/style/checker.py: 2016-09-16 Dave Hyatt [CSS Parser] Get CSSPropertyParserHelpers.cpp compiling https://bugs.webkit.org/show_bug.cgi?id=162078 Reviewed by Dean Jackson. * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: (TestWebKitAPI::createTestValue): Convert to ValueRange. 2016-09-16 Alex Christensen Fix API tests after r206036 https://bugs.webkit.org/show_bug.cgi?id=162049 * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): An emoji had been UTF-8 encoded in the patch that was applied. The test needed to check the encoding of the emoji, not the UTF-8 encoding of the emoji. Everything was correct except applying the patch before committing. 2016-09-16 Wenson Hsieh RequiresUserActionForPlayback TestWebKitAPI tests are broken after r206033. https://bugs.webkit.org/show_bug.cgi?id=162080 Reviewed by Jer Noble. I renamed "playingHandler" to the more generalized "testHandler", but did not realize that the RequiresUserActionForPlayback tests also used "playingHandler". Renames the handler to account for this change. * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::SetUp): 2016-09-16 Alex Christensen URLParser should percent encode the user and password according to spec https://bugs.webkit.org/show_bug.cgi?id=162049 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-16 Alex Christensen Fix more edge cases in URLParser https://bugs.webkit.org/show_bug.cgi?id=162051 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-16 Wenson Hsieh Inserting a space after inserting an accepted candidate scrolls the document and causes a flicker https://bugs.webkit.org/show_bug.cgi?id=162009 Reviewed by Tim Horton. Adds 3 new text editing API tests covering candidate insertion, as well as support for testing candidates in WKWebViews. Refactors common WKWebView helpers across both VideoControlsManager tests and the new WKWebViewCandidateTests into a new utility class, TestWKWebView in TestWKWebView.mm, which is capable of simulating mouse and keyboard events as well as waiting for JavaScript messages sent from the web process and performing actions in response. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit/ios/audio-only.html: * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): (-[MessageHandler initWithMessage:handler:]): Deleted. (-[MessageHandler userContentController:didReceiveScriptMessage:]): Deleted. (-[VideoControlsManagerTestWebView mouseDownAtPoint:]): Deleted. (-[VideoControlsManagerTestWebView performAfterLoading:]): Deleted. (-[VideoControlsManagerTestWebView callJavascriptFunction:]): Deleted. (-[VideoControlsManagerTestWebView loadTestPageNamed:]): Deleted. (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Added. (-[TestCandidate initWithReplacementString:inRange:]): (-[TestCandidate replacementString]): (-[TestCandidate resultType]): (-[TestCandidate range]): (-[CandidateTestWebView insertCandidatesAndWaitForResponse:range:]): (-[CandidateTestWebView _didHandleAcceptedCandidate]): (-[CandidateTestWebView expectCandidateListVisibilityUpdates:whenPerformingActions:]): (-[CandidateTestWebView _didUpdateCandidateListVisibility:]): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: * TestWebKitAPI/mac/TestWKWebViewMac.h: Added. * TestWebKitAPI/mac/TestWKWebViewMac.mm: Added. (-[TestMessageHandler initWithMessage:handler:]): (-[TestMessageHandler userContentController:didReceiveScriptMessage:]): (-[TestWKWebView mouseDownAtPoint:]): (-[TestWKWebView performAfterReceivingMessage:action:]): (-[TestWKWebView loadTestPageNamed:]): (-[TestWKWebView typeCharacter:]): (-[TestWKWebView stringByEvaluatingJavaScript:]): (-[TestWKWebView waitForMessage:]): (-[TestWKWebView performAfterLoading:]): 2016-09-14 Jer Noble [media-source] fix imported/w3c/web-platform-tests/media-source/mediasource-duration.html https://bugs.webkit.org/show_bug.cgi?id=161999 Reviewed by Eric Carlson. * TestWebKitAPI/Tests/WTF/MediaTime.cpp: (TestWebKitAPI::TEST): 2016-09-16 Anders Carlsson Fix isValidEnum to work with older versions of GCC https://bugs.webkit.org/show_bug.cgi?id=162065 Reviewed by Michael Catanzaro. Add EnumTraits.cpp to the CMake build. * TestWebKitAPI/CMakeLists.txt: 2016-09-16 Nael Ouedraogo Unreviewed: Change my primary address for auto-complete in bugzilla. * Scripts/webkitpy/common/config/contributors.json: 2016-09-15 Alex Christensen URLParser: Check for invalid characters in the host https://bugs.webkit.org/show_bug.cgi?id=162023 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-15 Fujii Hironori [CMake] Refactor GENERATE_BINDINGS https://bugs.webkit.org/show_bug.cgi?id=161854 Reviewed by Gyuyoung Kim. * DumpRenderTree/CMakeLists.txt: Changed the arguments of GENERATE_BINDINGS to new style. * WebKitTestRunner/CMakeLists.txt: Ditto. 2016-09-15 Ryan Haddad Disable failing API WebKit2.DataDetectionReferenceDate until it can be investigated. https://bugs.webkit.org/show_bug.cgi?id=161967 Unreviewed test gardening. * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: (TEST): 2016-09-15 Per Arne Vollan [Win] run-api-tests is failing. https://bugs.webkit.org/show_bug.cgi?id=162015 Reviewed by Brent Fulgham. MSVC is not interpreting C++ string literals with unicode characters correctly when the source file doesn't contain encoding information. Save the file with utf8 encoding with signature. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: 2016-09-15 Jonathan Bedard Move --no-sample-on-timeout to config.json for each bot https://bugs.webkit.org/show_bug.cgi?id=161964 Reviewed by Daniel Bates. Roll out changes from 205573 and move them into config.json. At this time, only macOS and iOS simulator sample a process on timeout, —no-sample-on-timeout is unneeded for GTK, EFL and Windows. * BuildSlaveSupport/build.webkit.org-config/config.json: Each bot now independently defines if it will be running sample on timeout. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKitTests.start): Rolled out changes from 205573. 2016-09-15 Csaba Osztrogonác js/stringimpl-to-jsstring-on-large-strings tests consume huge memory https://bugs.webkit.org/show_bug.cgi?id=159807 Reviewed by Saam Barati. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunRemoteJavaScriptCoreTests.start): JSCOnly bots are memory limited devices, tests should run with --memory-limited option. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Pass through --memory-limited option to run-jsc-stress-tests. * Scripts/run-jsc-stress-tests: Typo fix. 2016-09-14 Wenson Hsieh Media controls behave strangely when changing media sources https://bugs.webkit.org/show_bug.cgi?id=161914 Reviewed by Tim Horton. Adds three new unit tests verifying that media controls remain stable during common `src` change scenarios. Also tweaks an existing test to account for new `ended` behavior. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (-[VideoControlsManagerTestWebView waitForMediaControlsToShow]): (-[VideoControlsManagerTestWebView waitForMediaControlsToHide]): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Added. 2016-09-14 Jonathan Bedard Fix mastercfg_unittest https://bugs.webkit.org/show_bug.cgi?id=161816 Reviewed by Daniel Bates. (RunWebKitTests.start): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Fixed broken unit tests. 2016-09-13 Alexey Proskuryakov Landing optimized .png files, forgot to do it initially. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: 2016-09-13 Alexey Proskuryakov Switch build.webkit.org to iOS 10 https://bugs.webkit.org/show_bug.cgi?id=161930 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKitTests.start): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: * Scripts/webkitpy/port/ios.py: * TestResultServer/static-dashboards/builders.jsonp: 2016-09-13 Tim Horton Provide a mechanism to specify the maximum width of WKThumbnailView snapshots https://bugs.webkit.org/show_bug.cgi?id=161896 Reviewed by Simon Fraser. * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: (TestWebKitAPI::TEST): Add a test for the new property. Also fix the old new test to run on arbitrary scale displays without failing. 2016-09-12 Brent Fulgham [Win][Direct2D] Provide Direct2D-based geometry and transform cast operations https://bugs.webkit.org/show_bug.cgi?id=161818 Reviewed by Dean Jackson. Add several new test suites for the various geometric primitives in WebCore. * TestWebKitAPI/PlatformWin.cmake: Add new files for test cases. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto. * TestWebKitAPI/Tests/WebCore/AffineTransform.cpp: Added. * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp: Added. * TestWebKitAPI/Tests/WebCore/FloatRect.cpp: Added. * TestWebKitAPI/Tests/WebCore/FloatSize.cpp: Added. * TestWebKitAPI/Tests/WebCore/IntPoint.cpp: Added. * TestWebKitAPI/Tests/WebCore/IntRect.cpp: Added. * TestWebKitAPI/Tests/WebCore/IntSize.cpp: Added. * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Add some new Windows-focused test cases. 2016-09-12 Chris Dumez Fix post-landing review comments after r205787 https://bugs.webkit.org/show_bug.cgi?id=161885 Reviewed by Darin Adler. Leverage new StringBuilder::append(CFStringRef) overload. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dumpDOMAsWebArchive): 2016-09-12 Alex Christensen URLParser: Correctly ignore spaces before relative URLs with no scheme https://bugs.webkit.org/show_bug.cgi?id=161889 Reviewed by Daniel Bates. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-12 Alex Christensen URLParser: Fix relative URLs containing only fragments https://bugs.webkit.org/show_bug.cgi?id=161882 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-12 Alex Christensen URLParser: Correctly handle relative URLs that are just a scheme and a colon https://bugs.webkit.org/show_bug.cgi?id=161876 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-12 DAN SAUNDERS AX: WKWebView for macOS does not allow configuration of tabsToLinks https://bugs.webkit.org/show_bug.cgi?id=161394 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (TEST): 2016-09-12 Alex Christensen Remove trailing control characters and spaces before parsing a URL https://bugs.webkit.org/show_bug.cgi?id=161870 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-12 Alex Christensen Fix more URLParser quirks https://bugs.webkit.org/show_bug.cgi?id=161834 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-10 Alex Christensen Optimize URLParser performance https://bugs.webkit.org/show_bug.cgi?id=161837 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): Added a test to verify the case insensitivity of the default port checks. 2016-09-10 Chris Dumez parseHTMLInteger() should take a StringView in parameter https://bugs.webkit.org/show_bug.cgi?id=161669 Reviewed by Ryosuke Niwa. Explicitly construct a String from the CFStringRef in order to call StringBuilder::append(). This is needed now that there is an append() overload taking an AtomicString in parameter. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dumpDOMAsWebArchive): 2016-09-10 Wenson Hsieh Apple.com keynote does not display media controls https://bugs.webkit.org/show_bug.cgi?id=161833 Reviewed by Tim Horton. New unit test verifying that wide videos (~2 aspect ratio) still get media controls. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Added. 2016-09-09 Tim Horton WKThumbnailView should expose a mode where it can be reparented without resnapshotting https://bugs.webkit.org/show_bug.cgi?id=161828 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Added. (-[SnapshotSizeObserver observeValueForKeyPath:ofObject:change:context:]): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::setPageLoaderClient): (TestWebKitAPI::TEST): Add a test ensuring that this behaves correctly. 2016-09-09 Alex Christensen URLParser: Keep track of cannot-be-a-base-url according to spec https://bugs.webkit.org/show_bug.cgi?id=161830 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-09 Alex Christensen Fix API tests after r205774. https://bugs.webkit.org/show_bug.cgi?id=161820 * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): I had committed the wrong expected path in one case. The functionality is correct. 2016-09-09 Michael Saboff Unreviewed, rolling r205759 back in with a fix. An expectation file, JSTests/ChakraCore/test/Lib/tostring.baseline-jsc, should be named "toString.baseline-jsc". For systems with case-insensitive filesystems, the wrong name isn't an issue. That rename is part of this fix. * Scripts/run-javascriptcore-tests: (runJSCStressTests): 2016-09-09 Johan K. Jensen Unreviewed. Added myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2016-09-09 Alex Christensen URLParser should convert ASCII hosts to lowercase https://bugs.webkit.org/show_bug.cgi?id=161820 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-09 Ryan Haddad Unreviewed, rolling out r205759. This change broke all JSC tests Reverted changeset: "Add ChakraCore tests to run-javascriptcore-tests" https://bugs.webkit.org/show_bug.cgi?id=161808 http://trac.webkit.org/changeset/205759 2016-09-09 Ryan Haddad Revert r205770 because Ricky is already a committer. Unreviewed. * Scripts/webkitpy/common/config/contributors.json: 2016-09-09 Ricky Mondello Unreviewed. Added myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2016-09-09 Alex Christensen URLParser: Fix and optimize parsing file URLs ending with a host but no slash https://bugs.webkit.org/show_bug.cgi?id=161815 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-08 Dean Jackson Expose Apple Pencil data to Touch events https://bugs.webkit.org/show_bug.cgi?id=161783 Reviewed by Beth Dakin. The values that IOHID expects are different from their documentation, and from what UITouch interprets. Tweak incoming data so it will produce the output we expect. * WebKitTestRunner/ios/HIDEventGenerator.mm: (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]): (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]): 2016-09-09 JF Bastien Unreviewed. Added myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2016-09-09 Michael Saboff Add ChakraCore tests to run-javascriptcore-tests https://bugs.webkit.org/show_bug.cgi?id=161808 Reviewed by Saam Barati. Added ChakraCore tests to the default list of tests to run. * Scripts/run-javascriptcore-tests: (runJSCStressTests): 2016-09-09 Alex Christensen URLParser: Handle \ in path according to spec https://bugs.webkit.org/show_bug.cgi?id=161805 Reviewed by Andy Estes. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-09 Alex Christensen URLParser should parse URLs with non-special schemes https://bugs.webkit.org/show_bug.cgi?id=161786 Reviewed by Andy Estes. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-08 Yusuke Suzuki [WTF] HashTable's rehash is not compatible to Ref and ASan https://bugs.webkit.org/show_bug.cgi?id=161763 Reviewed by Mark Lam. Add tests that inserts many Ref<>s. It incurs HashTable::rehash, and we can ensure that ASan crash does not occur with this patch. * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/HashSet.cpp: (TestWebKitAPI::TEST): 2016-09-08 Alex Christensen URLParser: Handle \ in paths of special URLs according to spec https://bugs.webkit.org/show_bug.cgi?id=161781 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-08 Simon Fraser Update the content-animation.plan file to run css-accelerated-animation.html and pull SVN revision r205680. * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: 2016-09-08 Simon Fraser Add a content-animation test with accelerated CSS animations https://bugs.webkit.org/show_bug.cgi?id=161776 Reviewed by Dean Jackson. * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: 2016-09-08 Alex Christensen URLParser: Parsing empty URLs with a base URL should return the base URL https://bugs.webkit.org/show_bug.cgi?id=161777 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-08 Alex Christensen URLParser failures should preserve the original input string https://bugs.webkit.org/show_bug.cgi?id=161769 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): (TestWebKitAPI::shouldFail): 2016-09-08 Alex Christensen URLParser should parse URLs with a user but no password https://bugs.webkit.org/show_bug.cgi?id=161773 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-08 Alex Christensen URLParser should parse ports after IPv4 and IPv6 hosts https://bugs.webkit.org/show_bug.cgi?id=161731 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-08 Alex Christensen URLParser should correctly handle \ in path https://bugs.webkit.org/show_bug.cgi?id=161762 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-08 Alex Christensen URLParser should handle URLs with empty authority https://bugs.webkit.org/show_bug.cgi?id=161711 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-08 Alex Christensen Re-land r205580 after r205649 fixed the test failures https://bugs.webkit.org/show_bug.cgi?id=161668 Re-landing changesets: "Punycode encode non-ascii hosts in URLParser" https://bugs.webkit.org/show_bug.cgi?id=161655 http://trac.webkit.org/changeset/205521 "Fix query-only and fragment-only relative URLs when using URLParser" https://bugs.webkit.org/show_bug.cgi?id=161657 http://trac.webkit.org/changeset/205526 "URLParser should parse / as a relative URL" https://bugs.webkit.org/show_bug.cgi?id=161667 http://trac.webkit.org/changeset/205532 2016-09-08 Dean Jackson Expose Apple Pencil input to testing system https://bugs.webkit.org/show_bug.cgi?id=161670 I fixed the internal builds, now try to fix the public builds. * WebKitTestRunner/ios/IOKitSPI.h: Add new enum values. 2016-09-07 Dean Jackson Expose Apple Pencil input to testing system https://bugs.webkit.org/show_bug.cgi?id=161670 Attempt to fix iOS 9 builds. * WebKitTestRunner/ios/HIDEventGenerator.mm: (-[HIDEventGenerator _createIOHIDEventType:]): 2016-09-07 Alex Christensen Roll out r205580 and r205582. https://bugs.webkit.org/show_bug.cgi?id=161668 I need to figure out why this is failing on the bots before landing any more URLParser progress. 2016-09-07 Alex Christensen Unreviewed, revert r205533. https://bugs.webkit.org/show_bug.cgi?id=161668 Re-landing changesets: "Punycode encode non-ascii hosts in URLParser" https://bugs.webkit.org/show_bug.cgi?id=161655 http://trac.webkit.org/changeset/205521 "Fix query-only and fragment-only relative URLs when using URLParser" https://bugs.webkit.org/show_bug.cgi?id=161657 http://trac.webkit.org/changeset/205526 "URLParser should parse / as a relative URL" https://bugs.webkit.org/show_bug.cgi?id=161667 http://trac.webkit.org/changeset/205532 2016-09-07 Simon Fraser Enable the element on iOS https://bugs.webkit.org/show_bug.cgi?id=161714 rdar://problem/8978410 Reviewed by Tim Horton. Define ENABLE_METER_ELEMENT unconditionally now. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-09-07 Jonathan Bedard Run spindumps on timeout on iOS 9 Simulator Release WK2 (Tests) https://bugs.webkit.org/show_bug.cgi?id=161699 Reviewed by Alexey Proskuryakov. This change does not have testing associated with it because the testing infrastructure does not exists, we cannot currently mock build-bot variables. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKitTests): Enable sample on timeout for everything. (RunWebKitTests.start): Disable sample on timeout for everything except iOS 9 WK2 release simulators. 2016-09-06 Dean Jackson Expose Apple Pencil input to testing system https://bugs.webkit.org/show_bug.cgi?id=161670 Reviewed by Simon Fraser. Add API to UIScriptController that allows a test to emulate stylus input, such as from the Apple Pencil. The code is only implemented for WebKitTestRunner. There are also four new tests that ensure an Apple Pencil operates similarly to a regular touch. The main difference is that you can't have multiple touches when using an Apple Pencil. * DumpRenderTree/ios/UIScriptControllerIOS.mm: New methods. Empty implementations. (WTR::UIScriptController::stylusDownAtPoint): (WTR::UIScriptController::stylusMoveToPoint): (WTR::UIScriptController::stylusUpAtPoint): (WTR::UIScriptController::stylusTapAtPoint): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: New methods. * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Empty implementations. (WTR::UIScriptController::stylusDownAtPoint): (WTR::UIScriptController::stylusMoveToPoint): (WTR::UIScriptController::stylusUpAtPoint): (WTR::UIScriptController::stylusTapAtPoint): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/HIDEventGenerator.h: * WebKitTestRunner/ios/HIDEventGenerator.mm: New StylusEvent types. Add some properties to SyntheticEventDigitizerInfo. (-[HIDEventGenerator _createIOHIDEventType:]): Add support for StylusEvent types. (-[HIDEventGenerator touchDownAtPoints:touchCount:]): Clear any old stylus info. (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]): (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]): (-[HIDEventGenerator stylusUpAtPoint:]): (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]): (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]): (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]): (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]): * WebKitTestRunner/ios/IOKitSPI.h: Add new include, and new SPI. * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Calls into the HIDEventGenerator for the new API. (WTR::UIScriptController::stylusDownAtPoint): (WTR::UIScriptController::stylusMoveToPoint): (WTR::UIScriptController::stylusUpAtPoint): (WTR::UIScriptController::stylusTapAtPoint): 2016-09-07 Daniel Bates Update WebKitSystemInterface Rubber-stamped by Dean Jackson. Copy WebKitSystemInterface for iOS 10 to the built products directory. * Scripts/copy-webkitlibraries-to-product-directory: 2016-09-07 Youenn Fablet [Streams API] Separate compile flag for ReadableStream and WritableStream https://bugs.webkit.org/show_bug.cgi?id=161044 Reviewed by Alex Christensen. Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-09-07 Carlos Garcia Campos [GTK] Move some GObject DOM unstable API to stable https://bugs.webkit.org/show_bug.cgi?id=161681 Reviewed by Žan Doberšek. Do not use user message handler unstable API in the tests, since we have stable convenient API for that. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: (testUserContentManagerScriptMessageFromDOMBindings): (serverCallback): Deleted. (beforeAll): Deleted. * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (documentLoadedCallback): (emitURIChanged): Deleted. 2016-09-07 Youenn Fablet Using tests-options.json to compute whether tests are slow https://bugs.webkit.org/show_bug.cgi?id=161626 Reviewed by Darin Adler. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Updated first test to use a MockHost. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.__init__): Loading tests-options.json (Manager._test_is_slow): Computing timeout value based on tests-options.json. 2016-09-07 Hunseop Jeong [EFL] Need the libosmesa to support the software backend drawing. https://bugs.webkit.org/show_bug.cgi?id=147065 Reviewed by Gyuyoung Kim. Added the libosmesa to support the software backend drawing. * efl/install-dependencies: 2016-09-06 Commit Queue Unreviewed, rolling out r205521, r205526, and r205532. https://bugs.webkit.org/show_bug.cgi?id=161668 broke API tests (Requested by alexchristensen on #webkit). Reverted changesets: "Punycode encode non-ascii hosts in URLParser" https://bugs.webkit.org/show_bug.cgi?id=161655 http://trac.webkit.org/changeset/205521 "Fix query-only and fragment-only relative URLs when using URLParser" https://bugs.webkit.org/show_bug.cgi?id=161657 http://trac.webkit.org/changeset/205526 "URLParser should parse / as a relative URL" https://bugs.webkit.org/show_bug.cgi?id=161667 http://trac.webkit.org/changeset/205532 2016-09-06 Alex Christensen URLParser should parse / as a relative URL https://bugs.webkit.org/show_bug.cgi?id=161667 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-06 Daniel Bates [iOS] DumpRenderTree and WebKitTestRunner fail to build - "Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'" https://bugs.webkit.org/show_bug.cgi?id=161661 Reviewed by Darin Adler. Allow ad-hoc code signing when building the dummy DumpRenderTree and WebKitTestRunner command line tools for simulator with the iOS 10 beta SDK. * DumpRenderTree/mac/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: 2016-09-06 Alex Christensen Fix query-only and fragment-only relative URLs when using URLParser https://bugs.webkit.org/show_bug.cgi?id=161657 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-06 Alex Christensen Punycode encode non-ascii hosts in URLParser https://bugs.webkit.org/show_bug.cgi?id=161655 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::wideString): (TestWebKitAPI::TEST_F): 2016-09-05 Alex Christensen Implement relative file urls and begin implementing character encoding in URLParser https://bugs.webkit.org/show_bug.cgi?id=161618 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-09-06 Commit Queue Unreviewed, rolling out r205480. https://bugs.webkit.org/show_bug.cgi?id=161630 tests-options.json is not known from knockout filesystem (Requested by youenn on #webkit). Reverted changeset: "Using tests-options.json to compute whether tests are slow" https://bugs.webkit.org/show_bug.cgi?id=161626 http://trac.webkit.org/changeset/205480 2016-09-06 Michael Catanzaro "Redundant argument in sprintf" warning spam from prepare-ChangeLog https://bugs.webkit.org/show_bug.cgi?id=161606 Reviewed by Darin Adler. Avoid extra arguments in call to sprintf, hopefully without introducing new warnings this time. * Scripts/prepare-ChangeLog: (statusDescription): 2016-09-06 Youenn Fablet Using tests-options.json to compute whether tests are slow https://bugs.webkit.org/show_bug.cgi?id=161626 Reviewed by Darin Adler. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.__init__): Loading tests-options.json (Manager._test_is_slow): Computing timeout value based on tests-options.json. 2016-09-06 Commit Queue Unreviewed, rolling out r205461. https://bugs.webkit.org/show_bug.cgi?id=161628 Introduced "Use of uninitialized value $original in sprintf" warning (Requested by mcatanzaro on #webkit). Reverted changeset: ""Redundant argument in sprintf" warning spam from prepare- ChangeLog" https://bugs.webkit.org/show_bug.cgi?id=161606 http://trac.webkit.org/changeset/205461 2016-09-06 Youenn Fablet W3C test importer should be able to identify slow test https://bugs.webkit.org/show_bug.cgi?id=161601 Reviewed by Darin Adler. Test parser is now identifying slow tests based on "meta element name=timeout content=long" elements. Test importer is updating test-options.json file according that information. In case of clean import, the test-options.json is cleaned from 'slow' options for all W3C tests. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.__init__): (TestImporter.find_importable_tests): (TestImporter.import_tests): (TestImporter.update_test_options): (TestImporter): (TestImporter.remove_slow_from_w3c_test_options): * Scripts/webkitpy/w3c/test_parser.py: (TestParser.analyze_test): (TestParser.is_slow_test): (TestParser.potential_ref_filename): 2016-09-06 Per Arne Vollan [Win] Crash logs have incorrect symbols. https://bugs.webkit.org/show_bug.cgi?id=161603 Reviewed by Darin Adler. Add build path to _NT_SYMBOL_PATH environment variable. * Scripts/webkitpy/port/win.py: (WinPort.setup_crash_log_saving): 2016-08-31 Filip Pizlo Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression https://bugs.webkit.org/show_bug.cgi?id=160125 Reviewed by Geoffrey Garen and Keith Miller. * DumpRenderTree/TestRunner.cpp: * DumpRenderTree/mac/DumpRenderTree.mm: (DumpRenderTreeMain): * Scripts/run-jsc-stress-tests: * TestWebKitAPI/Tests/WTF/Vector.cpp: (TestWebKitAPI::TEST): 2016-09-05 Michael Catanzaro "Redundant argument in sprintf" warning spam from prepare-ChangeLog https://bugs.webkit.org/show_bug.cgi?id=161606 Reviewed by Darin Adler. Avoid extra arguments in call to sprintf. * Scripts/prepare-ChangeLog: (statusDescription): 2016-09-05 Michael Catanzaro [GTK] Skip several failing API tests Unfortunately we don't have any form of test expectations for API tests, so we'll just skip them after bugs are filed. * Scripts/run-gtk-tests: (TestRunner): 2016-09-05 Youenn Fablet Fix W3C test importer unit tests after r205447 https://bugs.webkit.org/show_bug.cgi?id=161604 Unreviewed. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.__init__): Skip cleaning test_resource_files files if resource-files.json cannot be read. 2016-09-05 Philippe Normand WebRTC: Several media stream tests crashing https://bugs.webkit.org/show_bug.cgi?id=161582 Reviewed by Alejandro G. Castro. * gtk/jhbuild.modules: Bump to latest OpenWebRTC master fixing the crash on missing glvideoflip GStreamer element. 2016-09-05 Youenn Fablet W3C test importer should generate the list of resource files https://bugs.webkit.org/show_bug.cgi?id=161578 Reviewed by Ryosuke Niwa. Generating LayoutTests/imported/w3c/resources/resource-files.json when importing tests. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.__init__): Reading test resource files configuration file. (TestImporter.find_importable_tests): (TestImporter.import_tests): Update the test resource files based on test parsed files. (TestImporter): (TestImporter._already_identified_as_resource_file): Helper routine to know whether a file is already set as a resource file. (TestImporter._is_in_resources_directory: Helper routine to know whether a file is in a resources directory. 2016-09-03 Wenson Hsieh Media controls behave strangely when videos mute from within a playing handler https://bugs.webkit.org/show_bug.cgi?id=161559 Reviewed by Darin Adler. Accounts for changes when determining whether or not to show media controls for autoplaying videos that have not begun playing yet. Rather than check for a controlled media element upon page load, we force tests to wait until all autoplaying videos have actually begun playing. This extends to tests that involve interaction, such as clicking or scrolling. * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (-[VideoControlsManagerTestWebView callJavascriptFunction:]): (-[VideoControlsManagerTestWebView expectControlsManager:afterReceivingMessage:]): (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): (-[VideoControlsManagerTestWebView waitForPageToLoadWithAutoplayingVideos:]): (TestWebKitAPI::TEST): (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: 2016-09-03 Wenson Hsieh Refactor the heuristic for showing media controls to take all media sessions into account https://bugs.webkit.org/show_bug.cgi?id=161503 Reviewed by Darin Adler. Adds new unit tests verifying the behavior of media playback controls when scrolling another video into view. Please see the WebCore ChangeLog for more details about this change. Also refactors existing VideoControlsManager tests by folding duplicated setup and testing logic into helper methods to make the unit tests more readable. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (-[MessageHandler initWithMessage:handler:]): (-[MessageHandler userContentController:didReceiveScriptMessage:]): (-[VideoControlsManagerTestWebView performAfterLoading:]): (-[VideoControlsManagerTestWebView loadTestPageNamed:]): (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): (-[VideoControlsManagerTestWebView controlledElementID]): (-[VideoControlsManagerTestWebView _handleControlledElementIDResponse:]): (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager): (TestWebKitAPI::TEST): (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): Deleted. (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): Deleted. (-[OnLoadMessageHandler initWithWKWebView:handler:]): Deleted. (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): Deleted. (-[WKWebView performAfterLoading:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Added. 2016-09-03 Youenn Fablet run-webkit-tests should detect w3c test resource files https://bugs.webkit.org/show_bug.cgi?id=161307 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/port/base.py: (Port.__init__): Adding self._w3c_resource_files to store the list of resource files. (Port.potential_test_names_from_expected_file): (Port._real_tests): (Port.is_w3c_resource_file): Computing whether a file is a resource file based on imported/w3c/resources/resource-files.json. (Port._is_test_file): Updated to call Port.is_w3c_resource_file. _is_test_file is no longer static. (Port): Deleted. * Scripts/webkitpy/port/base_unittest.py: (PortTest.test_additional_platform_directory): (PortTest.test_find_no_paths_specified): (PortTest.test_is_test_file): Updated to use non-static version of _is_test_file. (PortTest.test_is_w3c_resource_file): Adding tests. 2016-09-02 Carlos Garcia Campos Unreviewed. Fix archive-built-product step in GTK+ bots after r205280. * BuildSlaveSupport/built-product-archive: (archiveBuiltProduct): Do not copy to the archive the files needed to run GObject DOM bindings API breaks tests that no longer exist. 2016-09-02 Alex Christensen URLParser should parse file URLs https://bugs.webkit.org/show_bug.cgi?id=161556 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): (TestWebKitAPI::checkURLDifferences): 2016-09-01 Michael Saboff Import Chakra tests to JSC https://bugs.webkit.org/show_bug.cgi?id=154697 Reviewed by Saam Barati. Added "runChakra" and "chakraPassFailErrorHandler" to support the running of Chakra tests. * Scripts/run-jsc-stress-tests: 2016-09-02 Jonathan Bedard WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode https://bugs.webkit.org/show_bug.cgi?id=42547 Reviewed by Darin Adler. Added JavaScript bindings and C++ implementation of setUseDashboardCompatibilityMode for the WebKit2 sTestRunner. Note: this bug mistakenly called this function setDashboardCompatibilityMode, it is actually setUseDashboardCompatibilityMode. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added dashboard compatiblity mode setter. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Reset dashboard compatibility mode. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setJavaScriptCanAccessClipboard): Code style changes. (WTR::TestRunner::setPrivateBrowsingEnabled): Code style changes. (WTR::TestRunner::setUseDashboardCompatibilityMode): Added dashboard compatiblity mode setter. (WTR::TestRunner::setPopupBlockingEnabled): Code style changes. (WTR::TestRunner::setAuthorAndUserStylesEnabled): Code style changes. (WTR::TestRunner::addOriginAccessWhitelistEntry): Code style changes. * WebKitTestRunner/InjectedBundle/TestRunner.h: Added dashboard compatiblity mode setter. 2016-09-02 Jer Noble Unreviewed build fix: restore storyboard files to Xcode 7-compatability. * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: 2016-09-02 Tim Horton REGRESSION (r205329): Two API tests time out on iOS Simulator https://bugs.webkit.org/show_bug.cgi?id=161542 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: (createAnimatedResizeWebView): (createFirstVisuallyNonEmptyWatchingNavigationDelegate): (TEST): (animatedResizeWebView): Deleted. The navigation delegate was being stored in a local and went out of scope before the test was over. Keep it around, instead. 2016-08-31 Jer Noble Refactor MobileMiniBrowser into an application framework to allow external XCTesting https://bugs.webkit.org/show_bug.cgi?id=161462 Reviewed by Eric Carlson. XCTest targets need to be in the same project as the application which they're testing. To facilitate having external projects with XCTest targets, move the application's implementation into a framework that can be included with a bare-bones application shell for testing. Simultaneously, add the ability to load files from within the new framework's bundle by using a 'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on an external server for testing. * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: * MobileMiniBrowser/MobileMiniBrowser/Info.plist: * MobileMiniBrowser/MobileMiniBrowser/main.m: * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h. * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m. (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view controller from the framework's bundle. * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json. * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard. * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added. * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h. * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h. * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m. * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h. * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m. (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method. (+[NSURL __fileURLForBundleURL:bundle:]): Ditto. (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs pointing to the framework's resources directory. (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto. * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: (-[MobileMiniBrowserUITests testBasicVideoPlayback]): 2016-09-02 Jonathan Bedard Fix --no-sample-on-timeout command line argument https://bugs.webkit.org/show_bug.cgi?id=161507 Reviewed by Alexey Proskuryakov. This patch fixes the —no-sample-on-timeout flag and correctly names spindumps as spindump.txt. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): Fixed —-no-sample-on-timeout. * Scripts/webkitpy/port/apple.py: (ApplePort.sample_process): Use correct file name. (ApplePort.spindump_file_path): Spindump and sample file names are different. * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_timeout): Check “sample_on_timeout” flag. * Scripts/webkitpy/port/mac_unittest.py: (MacTest.test_spindump): Modified for correct filename. 2016-09-02 Jonathan Bedard Unreviewed: moved myself to the reviewers list. * Scripts/webkitpy/common/config/contributors.json: 2016-09-02 Tomas Popela [GTK] Fix compiler warning in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=161529 We were missing a return statement in decidePermissionRequest() and also there was unused variable in browserWindowConstructed(). Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/BrowserTab.c: (decidePermissionRequest): * MiniBrowser/gtk/BrowserWindow.c: (browserWindowConstructed): 2016-09-01 Dan Bernstein Build fix. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-09-01 Tim Horton Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests https://bugs.webkit.org/show_bug.cgi?id=161413 Reviewed by Simon Fraser. Add TestNavigationDelegate, which provides block properties to make writing tests feel a little more natural (the callbacks can be inline), and also add WKWebView _test_waitForDidFinishNavigation, so that many tests don't even need to manually allocate a navigation delegate at all. Adopt in some of the simpler tests; there are a few navigation delegates left behind, which we can move to the new model in the future. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: (TEST): (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: (TEST): (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: (animatedResizeWebView): (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: (-[AutoLayoutWKWebView initWithFrame:configuration:]): (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): (TEST): (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: (TEST): (-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: (WebKit2_CommandBackForwardTestWKWebView::SetUp): (WebKit2_CommandBackForwardTestWKWebView::loadFiles): (TEST_F): (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: (expectLinkCount): (TEST): (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: (TEST): (-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: (TEST): (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: (TEST): (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: (TEST): (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted. (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::createWebView): (RequiresUserActionForPlaybackTest::testVideoWithAudio): (RequiresUserActionForPlaybackTest::testVideoWithoutAudio): (RequiresUserActionForPlaybackTest::testAudioOnly): (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: (TEST): (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: (TEST): (webViewForScriptMessageHandlerMultipleHandlerRemovalTest): * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm: (TEST): (-[SimpleDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: (TEST): (-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: (TEST): (-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: (TEST): (-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted. * TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added. * TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added. (-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]): (-[TestNavigationDelegate webView:didFinishNavigation:]): (-[TestNavigationDelegate _webView:renderingProgressDidChange:]): (-[TestNavigationDelegate waitForDidFinishNavigation]): (-[WKWebView _test_waitForDidFinishNavigation]): 2016-09-01 Ricky Mondello YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs https://bugs.webkit.org/show_bug.cgi?id=161478 Reviewed by Eric Carlson. * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: (TestWebKitAPI::TEST_F): Update expected results. 2016-09-01 Anders Carlsson add BlockPtr::fromCallable https://bugs.webkit.org/show_bug.cgi?id=161504 Reviewed by Tim Horton. Add a test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/BlockPtr.mm: Added. (TestWebKitAPI::TEST): 2016-09-01 Alex Christensen URLParser should handle . and .. in URL paths https://bugs.webkit.org/show_bug.cgi?id=161443 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::eq): (TestWebKitAPI::TEST_F): 2016-09-01 Commit Queue Unreviewed, rolling out r205295 and r205303. https://bugs.webkit.org/show_bug.cgi?id=161505 Broke the iOS build (Requested by ryanhaddad on #webkit). Reverted changesets: "Refactor MobileMiniBrowser into an application framework to allow external XCTesting" https://bugs.webkit.org/show_bug.cgi?id=161462 http://trac.webkit.org/changeset/205295 "Unreviewed build-fix; don't specify an explicit deployment target." http://trac.webkit.org/changeset/205303 2016-09-01 Ricky Mondello YouTube Flash plug-in replacement facility should more gracefully handle malformed queries https://bugs.webkit.org/show_bug.cgi?id=161476 Reviewed by Eric Carlson. * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: (TestWebKitAPI::TEST_F): New tests. The first two and second-to-last test cases cover the "malformed" query logic. A few other tests are added, too. 2016-09-01 Jer Noble Unreviewed build-fix; don't specify an explicit deployment target. * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: 2016-08-31 Jer Noble Refactor MobileMiniBrowser into an application framework to allow external XCTesting https://bugs.webkit.org/show_bug.cgi?id=161462 Reviewed by Eric Carlson. XCTest targets need to be in the same project as the application which they're testing. To facilitate having external projects with XCTest targets, move the application's implementation into a framework that can be included with a bare-bones application shell for testing. Simultaneously, add the ability to load files from within the new framework's bundle by using a 'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on an external server for testing. * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: * MobileMiniBrowser/MobileMiniBrowser/Info.plist: * MobileMiniBrowser/MobileMiniBrowser/main.m: * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h. * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m. (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view controller from the framework's bundle. * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json. * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard. * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added. * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h. * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h. * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m. * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h. * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m. (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method. (+[NSURL __fileURLForBundleURL:bundle:]): Ditto. (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs pointing to the framework's resources directory. (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto. * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: (-[MobileMiniBrowserUITests testBasicVideoPlayback]): 2016-09-01 Carlos Garcia Campos Unreviewed. Fix webkitpy unit tests after r205280. * Scripts/webkitpy/style/checker_unittest.py: (GlobalVariablesTest.test_path_rules_specifier): 2016-08-31 Carlos Garcia Campos [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them https://bugs.webkit.org/show_bug.cgi?id=161438 Reviewed by Michael Catanzaro. Remove scripts related to the GObject DOM bindings auto-generation. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunGtkAPITests.getText2): (TestFactory.__init__): (RunWebKit1Tests): Deleted. (RunWebKit1Tests.start): Deleted. (RunWebKit1LeakTests): Deleted. (RunWebKit1LeakTests.start): Deleted. (RunAndUploadPerfTests): Deleted. (RunAndUploadPerfTests.start): Deleted. (BuildAndRemoteJSCTestsFactory.__init__): Deleted. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (BuildStepsTest.test_unnecessary_expected_results): (RunAndUploadPerfTestsTest): Deleted. (RunAndUploadPerfTestsTest.assertResults): Deleted. (RunAndUploadPerfTestsTest.test_success): Deleted. (RunAndUploadPerfTestsTest.test_tests_failed): Deleted. (RunAndUploadPerfTestsTest.test_build_bad_build): Deleted. (RunAndUploadPerfTestsTest.test_build_bad_source_json): Deleted. (RunAndUploadPerfTestsTest.test_build_bad_marge): Deleted. (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading): Deleted. (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted. (RunAndUploadPerfTestsTest.test_buildbot_timeout): Deleted. (RunBenchmarkTest): Deleted. (RunBenchmarkTest.assertResults): Deleted. (RunBenchmarkTest.test_success): Deleted. * Scripts/run-bindings-tests: (main): * Scripts/webkitpy/style/checker.py: * gtk/check-for-webkitdom-api-breaks: Removed. * gtk/generate-gtkdoc: * gtk/webkitdom.py: Removed. 2016-08-31 Gyuyoung Kim [EFL] Small clean up in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=161428 Reviewed by Yusuke Suzuki. This patch resizes MiniBrowser, add *char* constants for scheme, does line breaking, and remove unnecessary spaces. * MiniBrowser/efl/main.c: (on_mouse_wheel): (history_list_hide): (script_execute_callback): (on_key_down): (on_url_changed): (on_error): (on_color_picker_request): (url_from_user_input): (url_load_from_user_input): (on_back_button_clicked): (on_search_case_option_changed): (on_search_word_start_option_changed): (on_list_item_select): (navigation_button_longpress_process): (on_navigation_policy_decision): (window_create): (parse_cookies_policy): 2016-08-31 Alex Christensen Implement IPv6 parsing in URLParser https://bugs.webkit.org/show_bug.cgi?id=161390 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): (TestWebKitAPI::checkURLDifferences): 2016-08-31 Brady Eidson WK2 Gamepad provider on iOS. https://bugs.webkit.org/show_bug.cgi?id=161412 Reviewed by Tim Horton. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-08-30 Ricky Mondello YouTubePluginReplacementTest's URL transformation logic should have tests https://bugs.webkit.org/show_bug.cgi?id=161406 Reviewed by Eric Carlson. Add some very basic tests. Future patches should expand on these to find and fix bugs. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add YouTubePluginReplacement.cpp. * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Added. (TestWebKitAPI::test): Added. (TestWebKitAPI::TEST_F): Added. 2016-08-30 Brady Eidson GameController.framework backend for gamepad API. https://bugs.webkit.org/show_bug.cgi?id=161086 Reviewed by Alex Christensen. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate awakeFromNib]): * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController usesGameControllerFramework]): (-[SettingsController toggleUsesGameControllerFramework:]): 2016-08-30 Brent Fulgham Use of uninitialised memory in TransformationMatrx::blend4() https://bugs.webkit.org/show_bug.cgi?id=134621 Reviewed by Dean Jackson. Change is based on the Blink change (patch by ): * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Added. (TestWebKitAPI::TEST): 2016-08-30 Alex Christensen URLParser should handle relative URLs that start with // https://bugs.webkit.org/show_bug.cgi?id=161364 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkRelativeURL): (TestWebKitAPI::TEST_F): 2016-08-29 Aakash Jain EWS patch status page should indicate bot corresponding to each status message https://bugs.webkit.org/show_bug.cgi?id=161280 Reviewed by Alexey Proskuryakov. * QueueStatusServer/templates/patch.html: Formatting changes. 2016-08-29 Aakash Jain EWS should indicate which bot processed the patch https://bugs.webkit.org/show_bug.cgi?id=161222 Reviewed by Alexey Proskuryakov. * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing. bot ids are now displayed in patch status page. 2016-08-29 Alex Christensen URLParser should parse about:blank https://bugs.webkit.org/show_bug.cgi?id=161324 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-08-29 JF Bastien Bug 161165 - check-webkit-style doesn't understand macros containing `else` or labels https://bugs.webkit.org/show_bug.cgi?id=161165 Reviewed by Geoffrey Garen. Fix handling of `else` in a macro. Don't handle labels in a macro: the checker is already pretty messy in that area and it should be a rare thing. * Scripts/webkitpy/style/checkers/cpp.py: (check_braces): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_else_clause_not_on_same_line_as_else): 2016-08-29 Alex Christensen API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED https://bugs.webkit.org/show_bug.cgi?id=161317 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::TEST_F): 2016-08-29 Jer Noble Unreviewed gardening; only build MiniBrowser against iOS SDK targets. * Makefile: 2016-08-29 Jonathan Bedard Sample Process on notifyDone timed out https://bugs.webkit.org/show_bug.cgi?id=161063 Reviewed by Darin Adler. * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_timeout): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Call sample_process during notifyDone timeouts. (WTR::TestRunner::waitToDumpWatchdogTimerFired): * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Log pid and name for testing harness. 2016-08-29 Jonathan Bedard Check-webkit-style does not work with Objective-C blocks https://bugs.webkit.org/show_bug.cgi?id=161247 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cpp.py: (regex_for_lambda_functions): Changed to regex_for_lambdas_and_blocks. (regex_for_lambdas_and_blocks): Added check for Objective-C blocks. (check_spacing_for_function_call): Pass file state for lambda check. (check_spacing): Pass file state for lambda check. (check_braces): Pass file state for lambda check. (check_style): Pass file state for lambda check. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_cpp_lambda_functions): Changed from ‘test_lambda_functions’. (CppStyleTest.test_objective_c_block): Tests Objective-C blocks. (CppStyleTest.test_lambda_functions): Changed to ‘test_cpp_lambda_functions’. 2016-08-29 Aakash Jain EWS patch status page should indicate bot corresponding to each status message https://bugs.webkit.org/show_bug.cgi?id=161280 Reviewed by Alexey Proskuryakov. * QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed for each status message. * QueueStatusServer/stylesheets/common.css: (.status-bot): Added corresponding stylesheet class. 2016-08-29 Per Arne Vollan Attempt to fix Windows build after r205090. Unreviewed build fix. * DumpRenderTree/win/DRTDataObject.cpp: (cfFileNameWFormat): (cfUrlWFormat): 2016-08-27 Alex Christensen URLParser should parse relative URLs https://bugs.webkit.org/show_bug.cgi?id=161282 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::TEST): Added some tests for the new operator=. Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects. Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested. * TestWebKitAPI/Tests/WebCore/URLParser.cpp: (TestWebKitAPI::checkURL): (TestWebKitAPI::TEST_F): (TestWebKitAPI::checkRelativeURL): (TestWebKitAPI::checkURLDifferences): (TestWebKitAPI::shouldFail): Add some relative URL tests. 2016-08-27 Jonathan Bedard WTR needs an implementation of setAutomaticLinkDetectionEnabled https://bugs.webkit.org/show_bug.cgi?id=87162 Reviewed by Darin Adler. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition. * WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration. 2016-08-27 Joseph Pecoraro Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8) https://bugs.webkit.org/show_bug.cgi?id=28685 Reviewed by Darin Adler. * Scripts/extract-localizable-js-strings: * Scripts/update-webkit-localizable-strings: WebInspectorUI localizedStrings.js is now UTF-8. Other clients of this script still use UTF-16, so keep that the default. 2016-08-27 Alexey Proskuryakov REGRESSION (r204052): Popovers on bot watcher's dashboard are broken https://bugs.webkit.org/show_bug.cgi?id=161254 Reviewed by Darin Adler. Simplify the CSS. My understanding that the CSS was correct, and the root cause is tracked in bug 160478. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css: 2016-08-27 Simon Fraser Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests https://bugs.webkit.org/show_bug.cgi?id=161217 Reviewed by Ryosuke Niwa. "run-webkit-tests --print-expectations" runs the same logic as running the tests, but dumps out the lists of tests that would be run and skipped, and, for each, the entry in TestExpectations that determines the expected outcome of the test. This is an improved version of webkit-patch print-expectations. See bug for sample output. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._print_expectations_for_subset): Print out the list of tests and expected outcome for some subset of tests. (Manager.print_expectations): Do the same splitting by device class that running tests does, and for each subset of tests, call _print_expectations_for_subset. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser.expectation_for_skipped_test): Set the flag expectation_line.not_applicable_to_current_platform (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default, even for skipped tests. This function returns a list relevant for display, taking the skipped modifier into account. (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set. (TestExpectations.readable_filename_and_line_number): Return something printable for lines with and without filenames * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (main): Handle options.print_expectations (parse_args): Add support for --print-expectations (_print_expectations): * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_child_processes): Make this a debug log. 2016-08-26 Dan Bernstein Keep trying to fix the build after r205057. * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: 2016-08-26 Dan Bernstein Keep trying to fix the build after r205057. * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent config.h. This file is only meant to be built with Xcode anyway. * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile with Xcode 7.3 and deploy to iOS 9.0. * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto. * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h. * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto. 2016-08-26 Dan Bernstein Start trying to fix the build after r205057. * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: 2016-08-26 Alexey Proskuryakov Remove Yosemite Leaks from the flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=161253 Reviewed by Anders Carlsson. * TestResultServer/static-dashboards/builders.jsonp: 2016-08-26 Sam Weinig Remove support for ENABLE_LEGACY_WEB_AUDIO https://bugs.webkit.org/show_bug.cgi?id=161262 Reviewed by Anders Carlsson. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-08-26 Jer Noble Add a test harness for running UI tests on the iOS Simulator https://bugs.webkit.org/show_bug.cgi?id=161265 Reviewed by Simon Fraser. Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which can serve as a test harness for WebKit UI tests. Also add a basic media playback test which verifies that a