2019-08-27 Mark Lam Refactor to use VM& instead of VM* at as many places as possible. https://bugs.webkit.org/show_bug.cgi?id=201172 Reviewed by Yusuke Suzuki. * DOM/DOM.mm: (+[DOMNode _nodeFromJSWrapper:]): * DOM/DOMUtility.mm: (createDOMWrapper): * Plugins/Hosted/NetscapePluginHostProxy.mm: (identifierFromIdentifierRep): * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate): (WebKit::getObjectID): (WebKit::NetscapePluginInstanceProxy::addValueToArray): (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): (WebKit::NetscapePluginInstanceProxy::retainLocalObject): (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::stringValue const): (WebKit::ProxyInstance::getPropertyNames): * WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 2019-08-23 Chris Dumez [geolocation] Rename interfaces and remove [NoInterfaceObject] https://bugs.webkit.org/show_bug.cgi?id=200885 Reviewed by Alex Christensen. * WebCoreSupport/WebGeolocationClient.h: * WebCoreSupport/WebGeolocationClient.mm: (WebGeolocationClient::lastPosition): * WebView/WebGeolocationPosition.mm: (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]): (core): (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]): (-[WebGeolocationPosition initWithGeolocationPosition:]): * WebView/WebGeolocationPositionInternal.h: 2019-08-22 Andy Estes [watchOS] Disable Content Filtering in the simulator build https://bugs.webkit.org/show_bug.cgi?id=201047 Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2019-08-21 Tim Horton [Mail] Tapping top of message scrolls back to copied text instead of top of the message https://bugs.webkit.org/show_bug.cgi?id=200999 Reviewed by Wenson Hsieh. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldAllowSingleClickToChangeSelection const): Copy the existing behavior from EventHandler. We do not fix the bug in WebKitLegacy for a multitude of reasons, primarily because we do not know of any user impact. 2019-08-21 Ryosuke Niwa Put keygen element behind a runtime flag and disable it by default https://bugs.webkit.org/show_bug.cgi?id=200850 Reviewed by Antti Koivisto. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences keygenElementEnabled]): (-[WebPreferences setKeygenElementEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2019-08-19 Sihui Liu Remove IDB-specific quota https://bugs.webkit.org/show_bug.cgi?id=196545 Reviewed by Youenn Fablet. * Storage/WebDatabaseManager.mm: (-[WebDatabaseManager setIDBPerOriginQuota:]): Deleted. * Storage/WebDatabaseManagerPrivate.h: 2019-08-18 Yusuke Suzuki [WTF] Add makeUnique, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part https://bugs.webkit.org/show_bug.cgi?id=200620 Reviewed by Geoffrey Garen. * History/WebHistory.mm: (-[WebHistoryPrivate init]): * History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetScriptableNPObjectReply): (WKPCBooleanReply): (WKPCBooleanAndDataReply): (WKPCInstantiatePluginReply): * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodNamed): (WebKit::ProxyInstance::fieldNamed): * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): * Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): * Storage/WebDatabaseManagerClient.mm: (DidModifyOriginData::dispatchToMainThread): * WebCoreSupport/WebFrameLoaderClient.mm: (addRedirectURL): (WebFrameLoaderClient::savePlatformDataToCachedFrame): * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openLocalFrontend): * WebView/WebDeviceOrientationProviderMock.mm: * WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]): * WebView/WebMediaPlaybackTargetPicker.mm: (WebMediaPlaybackTargetPicker::create): * WebView/WebTextIterator.mm: (-[WebTextIterator initWithRange:]): * WebView/WebView.mm: (-[WebView _injectOutlookQuirksScript]): (-[WebView _commonInitializationWithFrameName:groupName:]): (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]): (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]): (-[WebView _selectionServiceController]): (-[WebView _setTextIndicator:withLifetime:]): * WebView/WebViewData.mm: (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler): (-[WebViewPrivate init]): 2019-08-17 Darin Adler Tidy up checks to see if a character is in the Latin-1 range by using isLatin1 consistently https://bugs.webkit.org/show_bug.cgi?id=200861 Reviewed by Ross Kirsling. * Misc/WebKitNSStringExtras.mm: (canUseFastRenderer): Use isLatin1. 2019-08-16 Chris Dumez LocalStorageDatabaseTracker does not need to subclass ThreadSafeRefCounted https://bugs.webkit.org/show_bug.cgi?id=200825 Reviewed by Alex Christensen. * Misc/WebKitVersionChecks.h: * Storage/WebStorageManager.mm: (WebKitInitializeStorageIfNecessary): 2019-08-16 Ryosuke Niwa Split tabIndex computation for DOM and the rest of WebCore https://bugs.webkit.org/show_bug.cgi?id=200806 Reviewed by Chris Dumez. * DOM/DOMHTMLElement.mm: (-[DOMHTMLElement tabIndex]): (-[DOMHTMLElement setTabIndex:]): 2019-08-15 Yusuke Suzuki [WTF] Add makeUnique, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part https://bugs.webkit.org/show_bug.cgi?id=200620 Reviewed by Geoffrey Garen. * Plugins/Hosted/NetscapePluginInstanceProxy.h: * Plugins/Hosted/WebHostedNetscapePluginView.mm: * Plugins/WebNetscapePluginEventHandlerCocoa.h: * Storage/WebDatabaseManagerClient.mm: * WebCoreSupport/WebAlternativeTextClient.h: * WebCoreSupport/WebCachedFramePlatformData.h: * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebDragClient.h: * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebGeolocationClient.h: * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebSelectionServiceController.h: * WebView/WebMediaPlaybackTargetPicker.h: 2019-08-15 Tim Horton Yellow Lookup highlight gets stuck over Mail messages https://bugs.webkit.org/show_bug.cgi?id=200778 Reviewed by Wenson Hsieh. * WebView/WebView.mm: (-[WebView _showDictionaryLookupPopup:]): Add a dismissal callback so that when Reveal hides the panel, it also dismisses the yellow indicator. This matches the behavior in modern WebKit. 2019-08-15 Sihui Liu Some improvements on web storage https://bugs.webkit.org/show_bug.cgi?id=200373 Reviewed by Geoffrey Garen. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): notify storageNamespaceProvider about session change. 2019-08-15 Youenn Fablet Always create a Document with a valid SessionID https://bugs.webkit.org/show_bug.cgi?id=200727 Reviewed by Alex Christensen. Implement WebKit1 sessionID getter like done for WebKit2. Either the loader client has a page in which case the page session ID is used or the client has no page, in which case the default session ID is used. This is the same behavior as CachedResourceLoader. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::sessionID const): 2019-08-15 Simon Fraser Use ObjectIdentifier for frameIDs https://bugs.webkit.org/show_bug.cgi?id=199986 Reviewed by Ryosuke Niwa. Use the strongly-typed FrameIdentifier instead of uint64_t as frame identifiers everywhere. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameID const): 2019-08-14 Ryan Haddad Unreviewed, rolling out r248526. Caused two IndexedDB perf tests to fail Reverted changeset: "Remove IDB-specific quota" https://bugs.webkit.org/show_bug.cgi?id=196545 https://trac.webkit.org/changeset/248526 2019-08-14 Keith Rollin Remove support for macOS < 10.13 https://bugs.webkit.org/show_bug.cgi?id=200694 Reviewed by Youenn Fablet. Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >= 101300. This means that expressions like "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True. * WebCoreSupport/WebEditorClient.mm: * WebView/PDFViewSPI.h: * WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:]): (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:]): (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted. (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): * WebView/WebView.mm: (-[WebView performDragOperation:]): (LayerFlushController::flushLayers): (-[WebView updateMediaTouchBar]): * WebView/WebViewData.h: 2019-08-14 Youenn Fablet ThreadableBlobRegistry::blobSize should take a SessionID as parameter https://bugs.webkit.org/show_bug.cgi?id=200671 Reviewed by ALex Christensen. * WebCoreSupport/WebPlatformStrategies.mm: 2019-08-13 Youenn Fablet Blob registries should be keyed by session IDs https://bugs.webkit.org/show_bug.cgi?id=200567 Reviewed by Alex Christensen. * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createBlobRegistry): Ignore sessionID parameter for WK1. 2019-08-12 Chris Dumez Add threading assertions to RefCounted https://bugs.webkit.org/show_bug.cgi?id=200507 Reviewed by Ryosuke Niwa. * WebView/WebView.mm: (+[WebView initialize]): Enable new RefCounted threading assertions for WebKitLegacy. 2019-08-12 Chris Dumez Unreviewed, rolling out r248525. Revert new threading assertions while I work on fixing the issues they exposed Reverted changeset: "Add threading assertions to RefCounted" https://bugs.webkit.org/show_bug.cgi?id=200507 https://trac.webkit.org/changeset/248525 2019-08-12 Youenn Fablet Remove IDB-specific quota https://bugs.webkit.org/show_bug.cgi?id=196545 Reviewed by Alex Christensen. * Storage/WebDatabaseManager.mm: (-[WebDatabaseManager setIDBPerOriginQuota:]): Deleted. * Storage/WebDatabaseManagerPrivate.h: 2019-08-11 Chris Dumez Add threading assertions to RefCounted https://bugs.webkit.org/show_bug.cgi?id=200507 Reviewed by Ryosuke Niwa. * WebView/WebView.mm: (+[WebView initialize]): Enable new RefCounted threading assertions for WebKitLegacy. 2019-08-10 Tim Horton Remove some more unused 32-bit code https://bugs.webkit.org/show_bug.cgi?id=200607 Reviewed by Alexey Proskuryakov. * Configurations/WebKitLegacy.xcconfig: * Misc/WebSharingServicePickerController.mm: (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]): (-[WebSharingServicePickerController initWithSharingServicePicker:client:]): (-[WebSharingServicePickerController sharingService:didShareItems:]): * Plugins/WebNetscapePluginEventHandler.mm: * Plugins/WebNetscapePluginEventHandlerCarbon.h: Removed. * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Removed. * Plugins/WebNetscapePluginEventHandlerCocoa.h: (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): Deleted. (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): Deleted. * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa): (WebNetscapePluginEventHandlerCocoa::keyDown): (WebNetscapePluginEventHandlerCocoa::focusChanged): (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): Deleted. (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): Deleted. (WebNetscapePluginEventHandlerCocoa::TSMEventHandler): Deleted. (WebNetscapePluginEventHandlerCocoa::handleTSMEvent): Deleted. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuForEvent): * WebView/WebHTMLView.mm: (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): (-[WebHTMLView pressureChangeWithEvent:]): * WebView/WebView.mm: (LayerFlushController::flushLayers): 2019-08-08 Rob Buis Add runtime flag for lazy image loading https://bugs.webkit.org/show_bug.cgi?id=199794 Reviewed by Darin Adler. Set lazyImageLoading runtime flag if preference is set. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences lazyImageLoadingEnabled]): (-[WebPreferences setLazyImageLoadingEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2019-08-07 Priyanka Agarwal Allow clients to toggle a text input field between being viewable and having characters hidden while maintaining a yellow auto-filled appearance https://bugs.webkit.org/show_bug.cgi?id=200037 rdar://problem/51900961 Reviewed by Daniel Bates. * DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _isAutoFilledAndViewable]): (-[DOMHTMLInputElement _setAutoFilledAndViewable:]): * DOM/WebDOMOperationsPrivate.h: 2019-08-02 Keith Rollin Consistently use Obj-C boolean literals https://bugs.webkit.org/show_bug.cgi?id=200405 Reviewed by Simon Fraser, Joseph Pecoraro. There are places where we use equivalent but different expressions for Obj-C boolean objects. For example, we use both [NSNumber numberWithBool:YES] and @YES. There are places where both are used in the same function, such as -[WebPreferences initialize]. The boolean literal is in greater use and is more succinct, so standardize on that. Also, change @(YES/NO) to @YES/NO. * History/WebHistoryItem.mm: * WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): * WebView/WebPreferences.mm: (+[WebPreferences initialize]): 2019-08-01 Alex Christensen Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories https://bugs.webkit.org/show_bug.cgi?id=200102 Reviewed by Darin Adler. * DefaultDelegates/WebDefaultUIDelegate.mm: (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]): Deleted. (-[WebDefaultUIDelegate webView:generateReplacementFile:]): Deleted. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldReplaceWithGeneratedFileForUpload): Deleted. (WebChromeClient::generateReplacementFile): Deleted. * WebView/WebUIDelegatePrivate.h: 2019-07-25 Dean Jackson Add helper for ignoring deprecated implementation warnings https://bugs.webkit.org/show_bug.cgi?id=200135 Reviewed by Wenson Hsieh. Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which is IGNORE_WARNINGS_BEGIN("deprecated-implementations") * Misc/WebDownload.mm: (-[WebDownload initWithRequest:delegate:]): * Misc/WebIconDatabase.mm: * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (-[WebBaseNetscapePluginView IGNORE_WARNINGS_END]): Deleted. * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (-[WebDynamicScrollBarsView IGNORE_WARNINGS_END]): Deleted. * WebView/WebHTMLView.mm: (-[WebHTMLView draggingSourceOperationMaskForLocal:]): (-[WebHTMLView draggedImage:endedAt:operation:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView accessibilityAttributeValue:]): (-[WebHTMLView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView attributedSubstringFromRange:]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]): (-[WebHTMLView IGNORE_WARNINGS_END]): Deleted. 2019-07-23 Wenson Hsieh [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts https://bugs.webkit.org/show_bug.cgi?id=200021 Reviewed by Ryosuke Niwa. Implement a new editing client hook. In WebKit1, this always returns true on macOS and false on iOS. * WebCoreSupport/WebEditorClient.h: 2019-07-22 Simon Fraser Fix WebView iframe rendering in macOS Catalina https://bugs.webkit.org/show_bug.cgi?id=200022 rdar://problem/49102040 Reviewed by Darin Adler. Adapt to internal NSView method renames in Catalina. * WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted. 2019-07-22 Simon Fraser Enable CSSOMViewScrollingAPIEnabled in WebKit1 https://bugs.webkit.org/show_bug.cgi?id=200008 rdar://problem/53409062 Reviewed by Tim Horton. Default WebKitCSSOMViewScrollingAPIEnabledPreferenceKey to YES, so that CSSOMViewScrollingAPIEnabled is on for both WebKit1 and WebKit2. DumpRenderTree already turns this preference on, so this change is not detected by tests. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): 2019-07-22 Youenn Fablet Disable MediaRecorder for legacy WebKit https://bugs.webkit.org/show_bug.cgi?id=200001 Reviewed by Eric Carlson. Disable MediaRecorder by default in legacy WebKit. Add SPI to set/get this preference. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences _mediaRecorderEnabled]): (-[WebPreferences _setMediaRecorderEnabled:]): * WebView/WebPreferencesPrivate.h: 2019-07-18 Alex Christensen Unify builds in WebKitLegacy/mac/DOM https://bugs.webkit.org/show_bug.cgi?id=199771 Reviewed by Geoffrey Garen. * DOM/DOMAbstractView.mm: * DOM/DOMAttr.mm: * DOM/DOMBlob.mm: * DOM/DOMCDATASection.mm: * DOM/DOMCSSFontFaceRule.mm: * DOM/DOMCSSImportRule.mm: * DOM/DOMCSSMediaRule.mm: * DOM/DOMCSSPageRule.mm: * DOM/DOMCSSPrimitiveValue.mm: * DOM/DOMCSSRule.mm: * DOM/DOMCSSRuleList.mm: * DOM/DOMCSSStyleDeclaration.mm: * DOM/DOMCSSStyleRule.mm: * DOM/DOMCSSStyleSheet.mm: * DOM/DOMCSSUnknownRule.mm: * DOM/DOMCSSValue.mm: * DOM/DOMCSSValueList.mm: * DOM/DOMCharacterData.mm: * DOM/DOMComment.mm: * DOM/DOMCounter.mm: * DOM/DOMDocument.mm: * DOM/DOMDocumentFragment.mm: * DOM/DOMDocumentType.mm: * DOM/DOMEvent.mm: * DOM/DOMFile.mm: * DOM/DOMFileList.mm: * DOM/DOMHTMLAnchorElement.mm: * DOM/DOMHTMLAppletElement.mm: * DOM/DOMHTMLAreaElement.mm: * DOM/DOMHTMLBRElement.mm: * DOM/DOMHTMLBaseElement.mm: * DOM/DOMHTMLBaseFontElement.mm: * DOM/DOMHTMLBodyElement.mm: * DOM/DOMHTMLButtonElement.mm: * DOM/DOMHTMLCanvasElement.mm: * DOM/DOMHTMLCollection.mm: * DOM/DOMHTMLDListElement.mm: * DOM/DOMHTMLDirectoryElement.mm: * DOM/DOMHTMLDivElement.mm: * DOM/DOMHTMLDocument.mm: * DOM/DOMHTMLElement.mm: * DOM/DOMHTMLEmbedElement.mm: * DOM/DOMHTMLFieldSetElement.mm: * DOM/DOMHTMLFontElement.mm: * DOM/DOMHTMLFormElement.mm: * DOM/DOMHTMLFrameElement.mm: * DOM/DOMHTMLFrameSetElement.mm: * DOM/DOMHTMLHRElement.mm: * DOM/DOMHTMLHeadElement.mm: * DOM/DOMHTMLHeadingElement.mm: * DOM/DOMHTMLHtmlElement.mm: * DOM/DOMHTMLIFrameElement.mm: * DOM/DOMHTMLImageElement.mm: * DOM/DOMHTMLInputElement.mm: * DOM/DOMHTMLLIElement.mm: * DOM/DOMHTMLLabelElement.mm: * DOM/DOMHTMLLegendElement.mm: * DOM/DOMHTMLLinkElement.mm: * DOM/DOMHTMLMapElement.mm: * DOM/DOMHTMLMarqueeElement.mm: * DOM/DOMHTMLMediaElement.mm: * DOM/DOMHTMLMenuElement.mm: * DOM/DOMHTMLMetaElement.mm: * DOM/DOMHTMLModElement.mm: * DOM/DOMHTMLOListElement.mm: * DOM/DOMHTMLObjectElement.mm: * DOM/DOMHTMLOptGroupElement.mm: * DOM/DOMHTMLOptionElement.mm: * DOM/DOMHTMLOptionsCollection.mm: * DOM/DOMHTMLParagraphElement.mm: * DOM/DOMHTMLParamElement.mm: * DOM/DOMHTMLPreElement.mm: * DOM/DOMHTMLQuoteElement.mm: * DOM/DOMHTMLScriptElement.mm: * DOM/DOMHTMLSelectElement.mm: * DOM/DOMHTMLStyleElement.mm: * DOM/DOMHTMLTableCaptionElement.mm: * DOM/DOMHTMLTableCellElement.mm: * DOM/DOMHTMLTableColElement.mm: * DOM/DOMHTMLTableElement.mm: * DOM/DOMHTMLTableRowElement.mm: * DOM/DOMHTMLTableSectionElement.mm: * DOM/DOMHTMLTitleElement.mm: * DOM/DOMHTMLUListElement.mm: * DOM/DOMHTMLVideoElement.mm: * DOM/DOMKeyboardEvent.mm: * DOM/DOMMediaError.mm: * DOM/DOMMediaList.mm: * DOM/DOMMouseEvent.mm: * DOM/DOMMutationEvent.mm: * DOM/DOMNamedNodeMap.mm: * DOM/DOMNodeIterator.mm: * DOM/DOMNodeList.mm: * DOM/DOMOverflowEvent.mm: * DOM/DOMProcessingInstruction.mm: * DOM/DOMProgressEvent.mm: * DOM/DOMRGBColor.mm: * DOM/DOMRange.mm: * DOM/DOMRect.mm: * DOM/DOMStyleSheet.mm: * DOM/DOMStyleSheetList.mm: * DOM/DOMText.mm: * DOM/DOMTextEvent.mm: * DOM/DOMTimeRanges.mm: * DOM/DOMTokenList.mm: * DOM/DOMTreeWalker.mm: * DOM/DOMUIEvent.mm: * DOM/DOMWheelEvent.mm: * DOM/DOMXPath.mm: * DOM/DOMXPathExpression.mm: * DOM/DOMXPathResult.mm: 2019-07-17 Antoine Quint Disable Pointer Events prior to watchOS 6 https://bugs.webkit.org/show_bug.cgi?id=199890 Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2019-07-17 Zalan Bujtas Unable to tap buttons at top of Wells Fargo app’s Payees screen https://bugs.webkit.org/show_bug.cgi?id=199846 Reviewed by Simon Fraser. * WebView/WebFrame.mm: (-[WebFrame approximateNodeAtViewportLocation:]): 2019-07-17 Alex Christensen Add a runtime-disabled dialog element skeleton https://bugs.webkit.org/show_bug.cgi?id=199839 Reviewed by Ryosuke Niwa. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences dialogElementEnabled]): (-[WebPreferences setDialogElementEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Add SPI to enable the dialog element for tests. 2019-07-15 Dean Jackson [WebGL] Remove software rendering and simplify context creation on macOS https://bugs.webkit.org/show_bug.cgi?id=199789 Reviewed by Sam Weinig. Remove force software WebGL setting. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences forceSoftwareWebGLRendering]): Deleted. (-[WebPreferences setForceSoftwareWebGLRendering:]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2019-07-13 Zalan Bujtas Cannot bring up custom media controls at all on v.youku.com https://bugs.webkit.org/show_bug.cgi?id=199699 Reviewed by Simon Fraser. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary const): * WebView/WebFrame.mm: (-[WebFrame elementAtPoint:]): * WebView/WebHTMLView.mm: (-[WebHTMLView elementAtPoint:allowShadowContent:]): * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController performHitTestAtPoint:]): 2019-07-12 Alex Christensen Begin unifying WebKitLegacy sources https://bugs.webkit.org/show_bug.cgi?id=199730 Reviewed by Keith Miller. * Configurations/WebKitLegacy.xcconfig: 2019-07-11 Pablo Saavedra [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF https://bugs.webkit.org/show_bug.cgi?id=199625 Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY) with ENABLE(ACCESSIBILITY) in the code. Additionally, the TestRunner code generator now honors the Conditional IDL format. Reviewed by Konstantin Tokarev. * WebView/WebFrame.mm: (-[WebFrame setAccessibleName:]): (-[WebFrame enhancedAccessibilityEnabled]): (-[WebFrame setEnhancedAccessibility:]): (-[WebFrame accessibilityRoot]): 2019-07-08 Antoine Quint [Pointer Events] Enable only on the most recent version of the supported iOS family https://bugs.webkit.org/show_bug.cgi?id=199562 Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2019-07-03 Sam Weinig Adopt simple structured bindings in more places https://bugs.webkit.org/show_bug.cgi?id=199247 Reviewed by Alex Christensen. Replaces simple uses of std::tie() with structured bindings. Does not touch uses of std::tie() that are not initial declarations, use std::ignore or in case where the binding is captured by a lambda, as structured bindings don't work for those cases yet. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _animationControllerForText]): 2019-07-02 Devin Rousso Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side https://bugs.webkit.org/show_bug.cgi?id=198956 Reviewed by Matt Baker. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::resetWindowState): Added. 2019-06-28 Timothy Hatcher Rename effectiveAppearanceIsInactive and useInactiveAppearance to better match UIUserInterfaceLevel. https://bugs.webkit.org/show_bug.cgi?id=199336 rdar://problem/52348938 Reviewed by Tim Horton. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _setUseDarkAppearance:]): (-[WebView _useElevatedUserInterfaceLevel]): (-[WebView _setUseElevatedUserInterfaceLevel:]): (-[WebView _setUseDarkAppearance:useInactiveAppearance:]): (-[WebView _setUseDarkAppearance:useElevatedUserInterfaceLevel:]): (-[WebView _effectiveUserInterfaceLevelIsElevated]): (-[WebView viewDidChangeEffectiveAppearance]): (-[WebView _useInactiveAppearance]): Deleted. (-[WebView _setUseInactiveAppearance:]): Deleted. (-[WebView _effectiveAppearanceIsInactive]): Deleted. * WebView/WebViewPrivate.h: 2019-06-28 Konstantin Tokarev Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733 https://bugs.webkit.org/show_bug.cgi?id=199317 Reviewed by Michael Catanzaro. While IconDatabase and all code using it was removed, ENABLE_ICONDATABASE still exists as build option and C++ macro. * Configurations/FeatureDefines.xcconfig: * WebView/WebView.mm: (-[WebView _cacheFrameLoadDelegateImplementations]): Use PLATFORM(MAC) guard instead of ENABLE_ICONDATABASE, because ENABLE_ICONDATABASE was enabled for macOS only. 2019-06-27 Timothy Hatcher Move WebKitLegacy off of a couple AppKit ivars. https://bugs.webkit.org/show_bug.cgi?id=199279 rdar://problem/34983438 Reviewed by Tim Horton. * WebView/WebHTMLView.mm: (-[NSView _setSubviewsIvar:]): Added. Implement on older systems. (-[NSView _subviewsIvar]): Added. Ditto. (needsCursorRectsSupportAtPoint): Use _borderView property. (-[WebHTMLView _setAsideSubviews]): Use _subviewsIvar property. (-[NSWindow _web_borderView]): Deleted. 2019-06-27 Beth Dakin Upstream use of MACCATALYST https://bugs.webkit.org/show_bug.cgi?id=199245 rdar://problem/51687723 Reviewed by Tim Horton. * Configurations/Base.xcconfig: * Configurations/FeatureDefines.xcconfig: * Configurations/SDKVariant.xcconfig: 2019-06-27 Saam Barati Make WEBGPU enabled only on Mojave and later. Rubber-stamped by Myles C. Maxfield. * Configurations/FeatureDefines.xcconfig: 2019-06-16 Darin Adler Rename AtomicString to AtomString https://bugs.webkit.org/show_bug.cgi?id=195276 Reviewed by Michael Catanzaro. * many files: Let do-webcore-rename do the renaming. 2019-06-14 Megan Gardner Move Synthetic Editing Commands to behind an experimental feature flag https://bugs.webkit.org/show_bug.cgi?id=198842 Reviewed by Simon Fraser. Add plumbing for synthetic editing command feature flag. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences syntheticEditingCommandsEnabled]): (-[WebPreferences setSyntheticEditingCommandsEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2019-06-13 Antoine Quint REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out https://bugs.webkit.org/show_bug.cgi?id=198800 Reviewed by Tim Horton. Expose a private method that we need to use from DumpRenderTree. * WebView/WebHTMLView.mm: (-[WebHTMLView _hitViewForEvent:]): * WebView/WebHTMLViewPrivate.h: 2019-06-10 Sam Weinig Remove Dashboard support https://bugs.webkit.org/show_bug.cgi?id=198615 Reviewed by Ryosuke Niwa. Removes implementation, but keeps privatly exported interfaces and enums around until we can confirm there are no more users of them. * Configurations/FeatureDefines.xcconfig: * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]): * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::annotatedRegionsChanged): Deleted. * WebView/WebClipView.mm: (-[WebClipView _focusRingVisibleRect]): (-[WebClipView scrollWheel:]): * WebView/WebDashboardRegion.h: * WebView/WebDashboardRegion.mm: * WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView setDataSource:]): * WebView/WebPreferences.mm: (cacheModelForMainBundle): * WebView/WebUIDelegatePrivate.h: * WebView/WebView.mm: (-[WebView _needsPreHTML5ParserQuirks]): (-[WebView _preferencesChanged:]): (-[WebView _addScrollerDashboardRegions:]): (-[WebView _dashboardRegions]): (-[WebView _setDashboardBehavior:to:]): (-[WebView _dashboardBehavior:]): (-[WebView _addControlRect:clip:fromView:toDashboardRegions:]): Deleted. (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): Deleted. (-[WebView _addScrollerDashboardRegions:from:]): Deleted. * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebViewPrivate init]): * WebView/WebViewPrivate.h: 2019-06-10 Timothy Hatcher Integrate dark mode support for iOS. https://bugs.webkit.org/show_bug.cgi?id=198687 rdar://problem/51545643 Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2019-06-07 Said Abou-Hallawa REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately https://bugs.webkit.org/show_bug.cgi?id=198664 Reviewed by Simon Fraser. WK1 has to skip using DisplayRefreshMonitor when layers need to be updated. * WebCoreSupport/WebChromeClient.h: (WebChromeClient::needsImmediateScheduleCompositingLayerFlush): == Rolled over to ChangeLog-2019-06-05 ==