2020-08-27 Carlos Garcia Campos [GTK] Include the run loop source name in frame rendering timeline https://bugs.webkit.org/show_bug.cgi?id=215847 Reviewed by Adrian Perez de Castro. Show the frame name if present in timeline panel. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Controllers/TimelineManager.js: (WI.TimelineManager.prototype._processRecord): * UserInterface/Models/RenderingFrameTimelineRecord.js: (WI.RenderingFrameTimelineRecord): (WI.RenderingFrameTimelineRecord.prototype.get name): * UserInterface/Views/TimelineTabContentView.js: (WI.TimelineTabContentView.displayNameForRecord): 2020-08-12 Devin Rousso Web Inspector: REGRESSION(r259170): text inputs in box-shadow editor push sliders offscreen https://bugs.webkit.org/show_bug.cgi?id=215436 Reviewed by Darin Adler. * UserInterface/Views/BoxShadowEditor.js: (WI.BoxShadowEditor.createInputRow): Make sure the inputs are `type="text"` so that CSS is able to distinguish them from sliders. 2020-08-11 Nikita Vasilyev Web Inspector: Clicking on sortable Table headers should expand vertical borders https://bugs.webkit.org/show_bug.cgi?id=215140 Reviewed by Devin Rousso. * UserInterface/Views/Table.css: (.table > .header .cell:not(:first-child):active::before,): 2020-08-11 Nikita Vasilyev Web Inspector: Dark Mode: Timelines: wrong background colors of even/odd items https://bugs.webkit.org/show_bug.cgi?id=214565 Reviewed by Darin Adler. * UserInterface/Views/TimelineOverview.css: (.timeline-overview.edit-instruments > .tree-outline.timelines .item:nth-child(even),): (.timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:not(:first-child)): 2020-08-06 Nikita Vasilyev Web Inspector: Media & Animations timeline shouldn't shift when sorting https://bugs.webkit.org/show_bug.cgi?id=215085 Reviewed by Devin Rousso. * UserInterface/Views/DataGrid.css: (.data-grid): (.data-grid th): (.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after): * UserInterface/Views/TimelineDataGrid.css: (.data-grid.timeline th.graph-column > .timeline-ruler): Override padding defined in `.data-grid th > .header-cell-content`. (.data-grid.timeline th > .header-cell-content.timeline-ruler > .markers): (.data-grid.timeline th:matches(.sort-ascending, .sort-descending) > .header-cell-content.timeline-ruler:first-child::after): `.header-cell-content.timeline-ruler` is different from `.header-cell-content` in the sense that the former takes the entire height of DataGrid and has no padding. Place the chevron in the middle of `--data-grid-header-height`. 2020-08-05 Tim Horton Remove all references to non-existent 10.16 https://bugs.webkit.org/show_bug.cgi?id=215202 Reviewed by Wenson Hsieh. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: 2020-08-04 Nikita Vasilyev Web Inspector: Use border-inline-start/end properties instead of border-left/right for DataGrid and Table https://bugs.webkit.org/show_bug.cgi?id=215138 Reviewed by Devin Rousso. Simplify LTR/RTL CSS code by using logical CSS properties. This patch doesn't introduce any visual changes. * UserInterface/Views/DataGrid.css: (.data-grid): (.data-grid th:not(:last-child) > .header-cell-content): (.data-grid:focus tr.selected td:not(:last-child)): (body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content): Deleted. (body[dir=rtl] .data-grid th:not(:last-child) > .header-cell-content): Deleted. (body[dir=ltr] .data-grid:focus tr.selected td:not(:last-child)): Deleted. (body[dir=rtl] .data-grid:focus tr.selected td:not(:last-child)): Deleted. * UserInterface/Views/NetworkDetailView.css: (.network-table.showing-detail .network-detail): (body[dir=ltr] .network-table.showing-detail .network-detail): Deleted. (body[dir=rtl] .network-table.showing-detail .network-detail): Deleted. * UserInterface/Views/TimelineDataGrid.css: (.data-grid.timeline td.graph-column): (body[dir=ltr] .data-grid.timeline td.graph-column): Deleted. (body[dir=rtl] .data-grid.timeline td.graph-column): Deleted. 2020-08-03 Nikita Vasilyev Web Inspector: Change DataGrid and Table styles to closer match macOS https://bugs.webkit.org/show_bug.cgi?id=214563 Reviewed by Devin Rousso. - Remove vertical borders from table contents and only keep them on the table headers. - Use 1px borders instead of hairline (0.5px) borders to closer match macOS. - Refactoring: add "sorted" CSS class on sorted header columns to replace `th:matches(.sort-ascending, .sort-descending)` that is used 10 times with `.sorted`. * UserInterface/Views/CPUTimelineView.css: (.timeline-view.cpu :matches(.area-chart, .stacked-area-chart) .markers > div): * UserInterface/Views/DataGrid.css: (.data-grid): --data-grid-column-border-start is no longer used, remove it. (.data-grid.inline): (.data-grid th): (.data-grid th > .header-cell-content): (body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content): (body[dir=rtl] .data-grid th:not(:last-child) > .header-cell-content): (.data-grid th.sortable:active): (.data-grid th:matches(.sort-ascending, .sort-descending)): (.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child): (.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after): (body[dir=ltr] .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after): (body[dir=rtl] .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after): Remove styles that are no longer relevant because columns don't have vertical borders anymore. (.data-grid th.sort-ascending > .header-cell-content:first-child::after): (.data-grid th.sort-descending > .header-cell-content:first-child::after): (@media (prefers-color-scheme: dark) .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after): Don't change the background color of the sorted header cells to match macOS. (body[dir=ltr] .data-grid :matches(th, td):not(:last-child)): Deleted. (body[dir=rtl] .data-grid :matches(th, td):not(:last-child)): Deleted. (.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child): Deleted. (.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after): Deleted. (body[dir=ltr] .data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after): Deleted. (body[dir=rtl] .data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after): Deleted. (.data-grid th.sort-ascending > div:first-child::after): Deleted. (.data-grid th.sort-descending > div:first-child::after): Deleted. (.data-grid table:matches(.header, .data)): Deleted. (body[dir=ltr] .data-grid :matches(th, td):first-child): Deleted. (body[dir=rtl] .data-grid :matches(th, td):first-child): Deleted. (@media (-webkit-min-device-pixel-ratio: 2) .data-grid table:matches(.header, .data)): Deleted. (@media (-webkit-min-device-pixel-ratio: 2) .data-grid :matches(th, td):first-child): Deleted. (@media (prefers-color-scheme: dark) .data-grid th.sortable:active): Deleted. (@media (prefers-color-scheme: dark) .data-grid th.sort-ascending > div:first-child::after,): Deleted. * UserInterface/Views/DataGrid.js: (WI.DataGrid.prototype.insertColumn): * UserInterface/Views/NetworkDetailView.css: (body[dir=ltr] .network-table.showing-detail .network-detail): (body[dir=rtl] .network-table.showing-detail .network-detail): Now that columns don't have borders, add a vertical border to the Network details pane. * UserInterface/Views/NetworkTableContentView.css: (.network-table > .table .header .cell.waterfall:matches(.sort-ascending, .sort-descending)): (body[dir=ltr] .network-table > .table :not(.header) .cell.waterfall): (body[dir=rtl] .network-table > .table :not(.header) .cell.waterfall): Add a vertical border for the zeroth mark of the graph. * UserInterface/Views/RenderingFrameTimelineOverviewGraph.css: (.timeline-overview-graph.rendering-frame > .divider): * UserInterface/Views/Table.css: (.table): (.table > .header > .sortable:active): (.table > .header > :matches(.sort-ascending, .sort-descending)): (.table > .header .cell): (.table > .header .cell:not(:first-child)::before): (body[dir=ltr] .table > .header .cell:not(:first-child)::before): (body[dir=rtl] .table > .header .cell:not(:first-child)::before): (body[dir=ltr] .table .cell:not(:last-child)): Deleted. (body[dir=rtl] .table .cell:not(:last-child)): Deleted. (body[dir=ltr] .table .cell:first-child): Deleted. (body[dir=rtl] .table .cell:first-child): Deleted. (@media (prefers-color-scheme: dark) .table > .header > .sortable:active): Deleted. (@media (prefers-color-scheme: dark) .table > .header > :matches(.sort-ascending, .sort-descending)): Deleted. * UserInterface/Views/TimelineDataGrid.css: (.data-grid th.graph-column:matches(.sort-ascending, .sort-descending)): (.data-grid.timeline th.graph-column > .timeline-ruler): (body[dir=ltr] .data-grid.timeline td.graph-column): (body[dir=rtl] .data-grid.timeline td.graph-column): Add a vertical border for the zeroth mark of the graph. (.data-grid.timeline td.graph-column .timeline-record-bar): (@media (prefers-color-scheme: dark) .data-grid th:matches(.sort-ascending, .sort-descending)): Deleted. * UserInterface/Views/TimelineRuler.css: (.timeline-ruler > .header > .divider > .label): Reset font-weight from sorted column header. (.timeline-ruler > .markers > .divider): * UserInterface/Views/Variables.css: (:root): (@media (prefers-color-scheme: dark) :root): Use more precise color for --even-zebra-stripe-row-background-color. Drive-by: remove unused --border-color-dark variable. 2020-08-03 Brian Burg Web Inspector: "Show transparency grid" string needs to be disambiguated for localization https://bugs.webkit.org/show_bug.cgi?id=215101 Reviewed by Darin Adler. Add two different string keys with the same English translation. This is specifically needed for Portuguese, apparently. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Views/CanvasContentView.js: (WI.CanvasContentView): * UserInterface/Views/GraphicsOverviewContentView.js: (WI.GraphicsOverviewContentView): * UserInterface/Views/ImageResourceContentView.js: * UserInterface/Views/RecordingContentView.js: (WI.RecordingContentView): * UserInterface/Views/ResourceCollectionContentView.js: (WI.ResourceCollectionContentView): * UserInterface/Views/SettingsTabContentView.js: (WI.SettingsTabContentView.prototype._createSourcesSettingsView): 2020-08-03 Devin Rousso Web Inspector: REGRESSION(r243301): Network: initiator column missing https://bugs.webkit.org/show_bug.cgi?id=215044 Reviewed by Brian Burg. * UserInterface/Views/NetworkTimelineView.js: (WI.NetworkTimelineView): 2020-07-30 Nikita Vasilyev REGRESSION (r?): Web Inspector: Timelines: blue border below selected timeline when in edit mode https://bugs.webkit.org/show_bug.cgi?id=214979 Reviewed by Devin Rousso. Color the top border after the selected item with the same background as the selected item. When editing, don't color that border with the selected item background. * UserInterface/Views/TimelineOverview.css: (.timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),): (body:matches(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines .item.selected + .item): (body:not(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines:focus-within .item.selected + .item): (@media (prefers-color-scheme: dark) .timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:nth-child(even)): (.timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted. (body:not(.window-inactive, .window-docked-inactive) .timeline-overview > .tree-outline.timelines:focus-within .item.selected + .item): Deleted. (@media (prefers-color-scheme: dark) .timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),): Deleted. (@media (prefers-color-scheme: dark) .timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted. 2020-07-30 Devin Rousso Web Inspector: Add another Protocol Version (iOS 14.0) https://bugs.webkit.org/show_bug.cgi?id=214991 Reviewed by Brian Burg. * UserInterface/Protocol/Legacy/14.0/InspectorBackendCommands.js: Added. * Versions/Inspector-iOS-14.0.json: Added. 2020-07-30 Nikita Vasilyev Web Inspector: on Big Sur, match OS background, text, and border colors https://bugs.webkit.org/show_bug.cgi?id=214366 Reviewed by Devin Rousso. Refactoring: - Remove --background-color-code because it was always the same value as --background-color-content. - Replace commonly hardcoded `hsl(0, 0%, 97%)` background with --background-color-intermediate. * UserInterface/Views/AnimationDetailsSidebarPanel.css: (.sidebar > .panel.details.animation > .content > .details-section.animation-keyframes .details-section): (.sidebar > .panel.details.animation > .content > .details-section.animation-keyframes .details-section .row.styles .CodeMirror): * UserInterface/Views/BoxShadowEditor.css: (.box-shadow-editor > table > tr > td > input[type="text"]): * UserInterface/Views/BreakpointActionView.css: (@media (prefers-color-scheme: dark) .breakpoint-action-eval-editor): * UserInterface/Views/BreakpointPopoverController.css: (.edit-breakpoint-popover-condition): * UserInterface/Views/ChangesDetailsSidebarPanel.css: (.sidebar > .panel.changes-panel .css-rule): * UserInterface/Views/ComputedStyleSection.css: (.computed-style-section .computed-property-item.expanded): (.computed-style-properties.details-section > .content,): * UserInterface/Views/ConsolePrompt.css: (.console-prompt): (.console-prompt > .CodeMirror-scroll): * UserInterface/Views/CookiePopover.css: (.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"])): * UserInterface/Views/DetailsSection.css: (.details-section .details-section): (.details-section .details-section > .header): Refactor. --background-color-content is the same color value. (.details-section .details-section:not(.collapsed) > .header): Refactor. --border-color-secondary is the same color value. (.details-section > .content > .group:nth-child(even)): (.details-section > .content > .group > .row:matches(.empty, .text)): (@media (prefers-color-scheme: dark) .details-section > .header > label,): * UserInterface/Views/DividerNavigationItem.css: (.navigation-bar .item.divider): Don't use hairline dividers. MacOS Catalina and Big Sur don't use hairline borders. * UserInterface/Views/GraphicsOverviewContentView.css: (.content-view.graphics-overview > section > .header): (@media (prefers-color-scheme: dark) .content-view.graphics-overview): * UserInterface/Views/LocalResourceOverridePopover.css: (.popover .local-resource-override-popover-content .editor): * UserInterface/Views/LogContentView.css: (@media (prefers-color-scheme: dark) .console-messages): * UserInterface/Views/QuickConsole.css: (.quick-console): * UserInterface/Views/ScopeChainDetailsSidebarPanel.css: (@media (prefers-color-scheme: dark) .watch-expression-editor): * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css: (.spreadsheet-css-declaration): (.spreadsheet-css-declaration.locked): * UserInterface/Views/SyntaxHighlightingDefaultTheme.css: (@media (prefers-color-scheme: dark) .cm-s-default,): * UserInterface/Views/TabBar.css: (body.big-sur.docked .tab-bar > .border.bottom): * UserInterface/Views/URLBreakpointPopover.css: (.popover .url-breakpoint-content > .editor-wrapper > .editor): * UserInterface/Views/Variables.css: (:root): Add --separator-color, which has the same semantics as `separator` color from Apple HIG (https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/color/#dynamic-system-colors). --border-color-secondary was only defined in the dark mode. Define it in the light mode, too. (body.window-inactive): Remove unused variable. (body.big-sur): (@media (prefers-color-scheme: dark) :root): (@media (prefers-color-scheme: dark) body.big-sur): (@media (prefers-color-scheme: dark) body.window-inactive): (body.window-inactive *): Remove unnecessarily greedy selector. 2020-07-30 Devin Rousso Web Inspector: only show scrollbars when needed https://bugs.webkit.org/show_bug.cgi?id=214980 Reviewed by Brian Burg. Prefer `overflow: auto;` instead of `overflow: scroll;` wherever possible, as when using a hardware mouse scrollbars are always shown for the latter, even when the content fits. * UserInterface/Debug/UncaughtExceptionReporter.css: (.sheet-container): * UserInterface/Views/AuditTestContentView.css: (.content-view-container > .content-view.audit-test): * UserInterface/Views/CanvasOverviewContentView.css: (.content-view.canvas-overview > .content-view.canvas.saved-recordings .tree-outline): * UserInterface/Views/CanvasSidebarPanel.css: (.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content): * UserInterface/Views/DOMEventsBreakdownView.css: (.waterfall-popover-content .dom-events-breakdown): * UserInterface/Views/DOMNodeEventsContentView.css: (.dom-node-details.dom-events): * UserInterface/Views/GraphicsOverviewContentView.css: (.content-view.graphics-overview): * UserInterface/Views/LocalRemoteObjectContentView.css: (.content-view.local-remote-object): * UserInterface/Views/NetworkResourceDetailView.css: (.content-view.resource-details): * UserInterface/Views/OpenResourceDialog.css: (.open-resource-dialog > .tree-outline): * UserInterface/Views/SourceCodeTextEditor.css: (.popover .debugger-popover-content > .body): * UserInterface/Views/CPUTimelineView.css: (.timeline-view.cpu): Added. (body .timeline-view.cpu): Deleted. * UserInterface/Views/MemoryTimelineView.css: (.timeline-view.memory): Added. (body .timeline-view.memory): Deleted. Although `!important` is kind of a "hack", adding `body` to the selector is more of a "hack" and is easier to unintentionally break. 2020-07-28 Brian Burg Web Inspector: REGRESSION(r255396): Audit: button to exit edit mode in main content area is missing border https://bugs.webkit.org/show_bug.cgi?id=214898 Reviewed by Devin Rousso. * UserInterface/Base/Main.js: codify that this function only accepts ButtonNavigationItems. Future developers, you'll need to adjust the CSS for non-button navigation items to work out. * UserInterface/Views/Main.css: (.navigation-item-help > .navigation-bar > .item.button): (.navigation-item-help > .navigation-bar > .item.button:not(.text-only)): (.navigation-item-help > .navigation-bar > .item.button.text-only): (.navigation-item-help > .navigation-bar > .item): Deleted. (.navigation-item-help > .navigation-bar > .item:not(.text-only)): Deleted. (.navigation-item-help > .navigation-bar > .item.text-only): Deleted. Split out the rules for text-only buttons. The regressing change added more specificity for the text + image case which made the border transparent and removed extra padding. Also add .button since we only expect buttons to be used in this context. 2020-07-28 Brian Burg REGRESSION(r262716) Web Inspector: start button is misaligned in Audit content view https://bugs.webkit.org/show_bug.cgi?id=214891 Reviewed by Devin Rousso. In r262716, a rendering defect related to flexbox was fixed. Web Inspector layout inadvertently relied on the defect. Now that it's fixed, a CSS rule is pushing the outline for navigation help buttons out of vertical alignment with surrounding textt. * UserInterface/Views/Main.css: (.navigation-item-help): Remove line-height. It was previously ignored due to a layout bug, and now its presence messes up vertical alignment. 2020-07-27 Nikita Vasilyev Web Inspector: Change default tab order to display most commonly used tabs first https://bugs.webkit.org/show_bug.cgi?id=212189 Reviewed by Timothy Hatcher. Changet the default tab order to: Elements, Console, Sources, Network, Timelines, Storage, Graphics, Layers, Audit. * UserInterface/Base/Main.js: (WI.loaded): 2020-07-22 Conrad Shultz Update macOS Version macros https://bugs.webkit.org/show_bug.cgi?id=214653 Reviewed by Tim Horton. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: 2020-07-22 Brian Burg Web Inspector: Sources tab empty, sidebar nonfunctional https://bugs.webkit.org/show_bug.cgi?id=214611 Reviewed by Devin Rousso. This is caused when a subresource fails its initial load. This generates a networking IssueMessage without a source code location, which is not adequately handled. * UserInterface/Views/IssueTreeElement.js: (WI.IssueTreeElement.prototype._updateTitles): (WI.IssueTreeElement): If there is no sourceCodeLocation for the issue, then don't try to compute line numbers. 2020-07-21 Devin Rousso Web Inspector: unable to save files that are base64 encoded https://bugs.webkit.org/show_bug.cgi?id=214601 Reviewed by Brian Burg. * UserInterface/Models/SourceCode.js: (WI.SourceCode.prototype.get base64Encoded): Added. Expose if the current content is base64 encoded. The current content is already exposed. * UserInterface/Views/ContextMenuUtilities.js: (WI.appendContextMenuItemsForSourceCode): Include the base64 encoded state in the save data. 2020-07-21 Devin Rousso Web Inspector: Elements: Styles: don't blur the add class input when a class is added https://bugs.webkit.org/show_bug.cgi?id=214604 Reviewed by Brian Burg. * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js: (WI.GeneralStyleDetailsSidebarPanel.prototype._addClassInputKeyPressed): (WI.GeneralStyleDetailsSidebarPanel.prototype._addClassInputBlur): (WI.GeneralStyleDetailsSidebarPanel.prototype._addClassFromInput): Added. * UserInterface/Views/GeneralStyleDetailsSidebarPanel.css: (.sidebar > .panel.details.css-style > .content ~ .class-list-container): Drive-by: don't show a scrollbar unless needed. 2020-07-21 Devin Rousso Web Inspector: REGRESSION(?): file names are not shown in the open resource dialog https://bugs.webkit.org/show_bug.cgi?id=214605 Reviewed by Brian Burg. When a `DocumentFragment` is added to a parent node, the children of the `DocumentFragment` are added as children of the parent instead of the `DocumentFragment` itself, effectively emptying the `DocumentFragment`, meaning that adding that `DocumentFragment` to a parent node again will basically do nothing as there are no children for that `DocumentFragment`. * UserInterface/Views/GeneralTreeElement.js: (WI.GeneralTreeElement.prototype._updateTitleElements): Because the `_mainTitleElement`/`_subtitleElement` is cleared (`removeChildren`), if the `_mainTitle`/`_subtitle` is a `DocumentFragment` nothing will be added due to the above. Instead, if the `_mainTitle`/`_subtitle` is a `DocumentFragment`, change it to be the `textContent` of the `_mainTitleElement`/`_subtitleElement` so that the above does not happen and so that future calls to `_updateTitleElements` won't make any changes the `_mainTitle`/`_subtitle` is now a `String` which matches the `textContent`. 2020-07-15 Nikita Vasilyev Web Inspector: Tab bar colors of undocked Inspector should match Safari in Big Sur https://bugs.webkit.org/show_bug.cgi?id=214163 Reviewed by Brian Burg. * UserInterface/Views/Main.css: (#undocked-title-area): (body.big-sur #undocked-title-area): (body:not(.big-sur) #undocked-title-area): (body.window-inactive #undocked-title-area): (@media (prefers-color-scheme: dark) body.big-sur #undocked-title-area): (@media (prefers-color-scheme: dark) body:not(.big-sur) #undocked-title-area): (@media (prefers-color-scheme: dark) body.big-sur.window-inactive #undocked-title-area): (@media (prefers-color-scheme: dark) body:not(.big-sur).window-inactive #undocked-title-area): * UserInterface/Views/TabBar.css: (.tab-bar): (body.big-sur .tab-bar): (body:not(.docked) .tab-bar): (body.big-sur:not(.docked) .tab-bar): (body:not(.big-sur):not(.docked) .tab-bar): (body.big-sur:not(.docked).window-inactive .tab-bar,): (.tab-bar > .border): (.tab-bar > .tabs > .item): (body:not(.docked) .tab-bar > .tabs > .item): (body.big-sur:not(.docked) .tab-bar > .tabs > .item): (body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item): (body.big-sur:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): (body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): (body.big-sur:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): (body:not(.big-sur):not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): (body:not(.docked).window-inactive .tab-bar > .tabs > .item): (body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item,): (body:not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): (.tab-bar > .tabs.animating.inserting-tab > .item.being-inserted): (.tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected): (@media (prefers-color-scheme: dark) body.big-sur .tab-bar,): (@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar): (@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar): (@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item): (@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): (@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): (@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): (@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): (@media (prefers-color-scheme: dark) body:not(.docked).window-inactive .tab-bar): (@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar,): (@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item): (@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked).window-inactive .tab-bar > .tabs > .item): (@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): (@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): 2020-07-13 Brian Burg Web Inspector: wrong bundle version being used for WebInspectorUI.framework in macOS Big Sur https://bugs.webkit.org/show_bug.cgi?id=214274 Reviewed by Tim Horton. * Configurations/Version.xcconfig: Make this match other Version.xcconfig after the changes in . 2020-07-09 Nikita Vasilyev Web Inspector: title bar of undocked inspector should be white in BigSur https://bugs.webkit.org/show_bug.cgi?id=214161 Reviewed by Brian Burg. Make the title bar white when the window is focused. When the window is unfocused, the title bar background is the same on Big Sur and Catalina. No changes were needed. * UserInterface/Views/Main.css: (#undocked-title-area): (body.big-sur #undocked-title-area): (body:not(.big-sur) #undocked-title-area): (@media (prefers-color-scheme: dark) #undocked-title-area): (@media (prefers-color-scheme: dark) body.big-sur #undocked-title-area): (@media (prefers-color-scheme: dark) body:not(.big-sur) #undocked-title-area): 2020-07-08 Christopher Reid Heap Snapshot Object Graph view doesn't get populated in some cases when inspecting a JSContext https://bugs.webkit.org/show_bug.cgi?id=214054 Reviewed by Devin Rousso. When JSContexts are created with a custom globalObjectClass, that object is an instance of CallbackGlobalObject and not GlobalObject so the view doesn't get populated. Add instances of CallbackGlobalObject to the Object Graph view as top level nodes. * UserInterface/Views/HeapSnapshotDataGridTree.js: 2020-07-07 Devin Rousso Web Inspector: Canvas: show an error message if unable to fetch shader source https://bugs.webkit.org/show_bug.cgi?id=213661 Reviewed by Brian Burg. * UserInterface/Views/ShaderProgramContentView.js: (WI.ShaderProgramContentView): (WI.ShaderProgramContentView.prototype._refreshContent): * UserInterface/Views/ShaderProgramContentView.css: (.content-view.shader-program > .spinner-container): Added. (.content-view.shader-program > .spinner-container > .indeterminate-progress-spinner): Added. 2020-07-03 Sam Weinig Add "-Wliteral-conversion" warning to Xcode based builds and fix the issues it finds https://bugs.webkit.org/show_bug.cgi?id=213931 Reviewed by Darin Adler. * Configurations/Base.xcconfig: Add -Wliteral-conversion. 2020-07-02 Nikita Vasilyev Web Inspector: Allow selecting text of Response (DOM Tree) https://bugs.webkit.org/show_bug.cgi?id=213617 Reviewed by Joseph Pecoraro. * UserInterface/Views/DOMTreeOutline.css: (.tree-outline.dom.non-selectable): 2020-07-01 Devin Rousso Web Inspector: add back support for 10.3.1 https://bugs.webkit.org/show_bug.cgi?id=213764 Reviewed by Brian Burg. * UserInterface/Controllers/NetworkManager.js: (WI.NetworkManager.prototype.initializeTarget): (WI.NetworkManager.prototype.webSocketWillSendHandshakeRequest): (WI.NetworkManager.prototype.markResourceRequestAsServedFromMemoryCache): Added. (WI.NetworkManager.prototype.resourceRequestDidReceiveResponse): * UserInterface/Models/Resource.js: (WI.Resource.prototype.legacyMarkServedFromMemoryCache): Added. (WI.Resource.prototype.legacyMarkServedFromDiskCache): Added. * UserInterface/Models/WebSocketResource.js: (WI.WebSocketResource.prototype.addFrame): * UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js: Added. * UserInterface/Protocol/NetworkObserver.js: (WI.NetworkObserver.prototype.requestServedFromCache): Added. * UserInterface/Views/NetworkTableContentView.js: (WI.NetworkTableContentView): * UserInterface/Views/NetworkTimelineView.js: (WI.NetworkTimelineView): * UserInterface/Views/ResourceDetailsSidebarPanel.js: (WI.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse): * UserInterface/Views/WebSocketContentView.js: (WI.WebSocketContentView): (WI.WebSocketContentView.prototype._addRow): * Versions/Inspector-iOS-10.3.json: Added. 2020-06-30 Andy Estes [Xcode] Enable the "My Mac (Mac Catalyst)" destination in WebKit Xcode projects https://bugs.webkit.org/show_bug.cgi?id=213740 Reviewed by Darin Adler. * Configurations/Base.xcconfig: Set SUPPORTS_MACCATALYST to YES to tell Xcode that this project supports building for Mac Catalyst. 2020-06-23 Devin Rousso Web Inspector: add a tooltip to the icon of overridden resources to clarify meaning https://bugs.webkit.org/show_bug.cgi?id=213531 Reviewed by Brian Burg. * UserInterface/Views/LocalResourceOverrideWarningView.js: (WI.LocalResourceOverrideWarningView.prototype.initialLayout): * UserInterface/Views/ResourceHeadersContentView.js: (WI.ResourceHeadersContentView.prototype._responseSourceDisplayString): Rephrase "local resource override" to just "local override" to match the reference page name. * UserInterface/Views/NetworkTableContentView.js: (WI.NetworkTableContentView.prototype._populateNameCell.createIconElement): (WI.NetworkTableContentView.prototype._populateNameCell): (WI.NetworkTableContentView.prototype._populateTransferSizeCell): Add a `title` for the special transfer size cases, such as for `(local override)`. * UserInterface/Views/ResourceTreeElement.js: (WI.ResourceTreeElement.prototype._updateIcon): * UserInterface/Views/ResourceSizesContentView.js: (WI.ResourceSizesContentView.prototype.initialLayout): * UserInterface/Views/TimelineDataGridNode.js: (WI.TimelineDataGridNode.prototype.createCellContent): (WI.TimelineDataGridNode.prototype.generateIconTitle): Added. * UserInterface/Views/ResourceTimelineDataGridNode.js: (WI.ResourceTimelineDataGridNode.prototype.get data): (WI.ResourceTimelineDataGridNode.prototype.generateIconTitle): Added. Add a `title` to the overridden resource icon that clarifies the fact that the resource was overridden by a local override. * UserInterface/Views/LayoutTimelineDataGridNode.js: (WI.LayoutTimelineDataGridNode.prototype.get data): Cache the `initiatorCallFrame` in the `source` column as well as the `initiator` column, as it is used by the general timeline overview table. * UserInterface/Views/DataGridNode.js: (WI.DataGridNode.prototype.createCell): (WI.DataGridNode.prototype.generateIconTitle): Added. Provide a way to set a `title` on just the icon. * Localizations/en.lproj/localizedStrings.js: 2020-06-23 Devin Rousso Web Inspector: adjust height of undocked title area to match macOS Big Sur https://bugs.webkit.org/show_bug.cgi?id=213490 Reviewed by Brian Burg. * UserInterface/Views/Variables.css: (body.mac-platform.big-sur:not(.docked)): The title bar height is based on the close/minimize/maximize buttons, not the title text. 2020-06-23 Devin Rousso Keyframe animation doesn't 't show up in the Animations timeline https://bugs.webkit.org/show_bug.cgi?id=213441 Reviewed by Brian Burg. * UserInterface/Models/Animation.js: (WI.Animation): (WI.Animation.prototype._updateEffect): An `interationCount` of `Infinity` is not JSON serializable, so represent it as `-1` instead. * UserInterface/Models/MediaTimelineRecord.js: (WI.MediaTimelineRecord): * UserInterface/Views/MediaTimelineDataGridNode.js: (WI.MediaTimelineDataGridNode.prototype.createCellContent): (WI.MediaTimelineDataGridNode.prototype.filterableDataForColumn): The DOM node may not be able to be instrumented if the timeline recording starts before the frontend has had a chance to request the main document, so it's possible for the DOM node to not be set. 2020-06-22 Devin Rousso Web Inspector: adjust height of undocked title area to match macOS Big Sur https://bugs.webkit.org/show_bug.cgi?id=213490 Reviewed by Timothy Hatcher. * UserInterface/Views/Variables.css: (body.mac-platform:not(.big-sur):not(.docked)): Added. (body.mac-platform.big-sur:not(.docked)): Added. (body.mac-platform:not(.docked)): Deleted. * UserInterface/Base/Platform.js: Add logic for detecting macOS Big Sur (and Catalina). 2020-06-22 Devin Rousso Web Inspector: Elements: Node: use a `WI.ContextMenu` instead of a `