2022-02-18 Robert Jenner Unreviewed, reverting r290149. Broke Debug Builds. Reverted changeset: "Generate compile_commands.json on macOS Builds" https://bugs.webkit.org/show_bug.cgi?id=235686 https://commits.webkit.org/r290149 2022-02-18 Brandon Stewart Generate compile_commands.json on macOS Builds https://bugs.webkit.org/show_bug.cgi?id=235686 Reviewed by Saam Barati. Add support for generating compile_commands.json file to WebKit. compile_commands.json can be used by tools like clangd to provide code complete, refactoring, formatting, and cross references. Steps to generate the compile commands file: make r EXPORT_COMPILE_COMMANDS=YES generate-compile-commands WebKitBuild/Release * Configurations/DebugRelease.xcconfig: 2022-02-18 Saam Barati Add LC_SOURCE_VERSION to compile targets https://bugs.webkit.org/show_bug.cgi?id=236720 Reviewed by Michael Saboff. * Configurations/Version.xcconfig: * Configurations/WebKitLegacy.xcconfig: 2022-02-17 Jean-Yves Avenard Unnecessary copy/memory allocation https://bugs.webkit.org/show_bug.cgi?id=236749 rdar://problem/89064893 Reviewed by Dean Jackson. * WebView/WebHTMLView.mm: (createShareMenuItem): Shared NSData constructed from a SharedBuffer instead 2022-02-17 Jean-Yves Avenard CrashTracer: com.apple.WebKit.WebContent at JavaScriptCore: bmalloc_allocate_impl_impl_slow https://bugs.webkit.org/show_bug.cgi?id=236695 rdar://87596724 Reviewed by Jer Noble. * WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): 2022-02-16 Kimmo Kinnunen ANGLE includes interfere with system header includes https://bugs.webkit.org/show_bug.cgi?id=236636 Reviewed by Dean Jackson. Remove the attempt to override system header logic with WebKit ANGLE implementation. They are different implementations and one cannot replace the other. * WebView/WebFrameInternal.h: 2022-02-16 David Kilzer [WebKitLegacy] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings Reviewed by Dean Jackson. * Misc/WebDownload.mm: (callOnDelegateThreadAndWait): - Replace WTFMove() with std::forward<>(). 2022-02-15 Chris Dumez Do preliminary work to pass domain names to CoreLocation https://bugs.webkit.org/show_bug.cgi?id=236566 Reviewed by Darin Adler. * WebCoreSupport/WebGeolocationClient.h: * WebCoreSupport/WebGeolocationClient.mm: (WebGeolocationClient::startUpdating): 2022-02-15 Wenson Hsieh [macOS] Add a context menu item to "Copy Cropped Image" https://bugs.webkit.org/show_bug.cgi?id=236602 rdar://88924479 Reviewed by Megan Gardner. See WebCore and WebKit ChangeLogs for more details. * WebCoreSupport/WebContextMenuClient.h: * WebView/WebHTMLView.mm: (toTag): 2022-02-11 Chris Dumez Unreviewed, fix build with the latest iOS SDK. * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage isNativeLibraryData:]): 2022-02-10 Devin Rousso Permit simultaneous Apple Pay and script injection https://bugs.webkit.org/show_bug.cgi?id=236254 Reviewed by Kate Cheney. * WebCoreSupport/WebPaymentCoordinatorClient.h: * WebCoreSupport/WebPaymentCoordinatorClient.mm: (WebPaymentCoordinatorClient::supportsUnrestrictedApplePay const): Deleted. Remove logic that tracks Apple Pay activity. 2022-02-06 Tyler Wilcock AX: Add internal-only flag to enable WIP display: contents support https://bugs.webkit.org/show_bug.cgi?id=236179 Reviewed by Chris Fleizach. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences cssDisplayContentsAXSupportEnabled]): (-[WebPreferences setCSSDisplayContentsAXSupportEnabled:]): * WebView/WebPreferencesPrivate.h: 2022-02-03 Ryosuke Niwa Delete SelectionAcrossShadowBoundariesEnabled https://bugs.webkit.org/show_bug.cgi?id=235993 Reviewed by Darin Adler. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences keygenElementEnabled]): (-[WebPreferences selectionAcrossShadowBoundariesEnabled]): (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]): (-[WebPreferences isXSSAuditorEnabled]): * WebView/WebPreferencesPrivate.h: 2022-02-03 Michael Saboff WebKit projects have incorrect install name for the frameworks for Catalyst builds with the system content path https://bugs.webkit.org/show_bug.cgi?id=236105 Reviewed by Saam Barati. Refactored build variable computation so that WEBKIT_LEGACY_FRAMEWORKS_DIR doesn't have the system content path prepended. This refactoring includes: - Created INSTALL_PATH_PREFIX to have the system content path when in use. - Changed WEBKIT_LEGACY_FRAMEWORKS_DIR computation to eliminate the inclusion the SYSTEM_CONTENT_PATH. - Reworked INSTALL_PATH to use INSTALL_PATH_PREFIX in the main productions instead of each of variants. - Changed DYLIB_INSTALL_NAME_BASE computation for Catalyst builds to use WEBKIT_LEGACY_FRAMEWORKS_DIR. * Configurations/Base.xcconfig: * Configurations/WebKitLegacy.xcconfig: 2022-02-01 Myles C. Maxfield Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to fontMetricsOfPrimaryFont() https://bugs.webkit.org/show_bug.cgi?id=235938 Unreviewed. * WebView/WebImmediateActionController.mm: (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]): 2022-01-31 Myles C. Maxfield Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to fontMetricsOfPrimaryFont() https://bugs.webkit.org/show_bug.cgi?id=235938 Reviewed by Alan Bujtas. * WebView/WebImmediateActionController.mm: (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]): 2022-01-30 Ryosuke Niwa Delete runtime preference for enabling keygen element https://bugs.webkit.org/show_bug.cgi?id=235867 Reviewed by Antti Koivisto. * WebView/WebPreferences.mm: (-[WebPreferences keygenElementEnabled]): (-[WebPreferences setKeygenElementEnabled:]): * WebView/WebPreferencesPrivate.h: 2022-01-29 Ryosuke Niwa Delete runtime preference for enabling request animation frame https://bugs.webkit.org/show_bug.cgi?id=235866 Reviewed by Darin Adler. * WebView/WebPreferences.mm: (-[WebPreferences requestAnimationFrameEnabled]): (-[WebPreferences setRequestAnimationFrameEnabled:]): * WebView/WebPreferencesPrivate.h: 2022-01-28 Michael Saboff Catalyst builds for WebCore and WebKitLegacy don't create proper symlinks for builds with system content path https://bugs.webkit.org/show_bug.cgi?id=235839 Reviewed by Saam Barati. Fixed ALTERNATE_ROOT_PATH and OUTPUT_ALTERNATE_ROOT_PATH to have proper paths for Catalyst builds, but not for normal macOS builds since they are under WebKit.framework. * Configurations/WebKitLegacy.xcconfig: 2022-01-27 Devin Rousso [Payment Request] allow additional payment method specific data to be passed to `complete()` https://bugs.webkit.org/show_bug.cgi?id=235415 Reviewed by Darin Adler. * WebCoreSupport/WebPaymentCoordinatorClient.h: * WebCoreSupport/WebPaymentCoordinatorClient.mm: (WebPaymentCoordinatorClient::completePaymentSession): 2022-01-27 Elliott Williams Generated xcfilelists contain symlinks when building for macOS https://bugs.webkit.org/show_bug.cgi?id=235663 rdar://88054903 Reviewed by Alexey Proskuryakov. * Configurations/Base.xcconfig: * Configurations/WebKitLegacy.xcconfig: 2022-01-27 Ada Chan Disable WebXR experimental feature by default https://bugs.webkit.org/show_bug.cgi?id=235688 Reviewed by Tim Horton. Remove WebKit::defaultWebXREnabled() since it's no longer used. * WebView/WebPreferencesDefaultValues.h: * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultWebXREnabled): Deleted. 2022-01-19 Alex Christensen Allow experimental feature names to be hidden in WebKitAdditions https://bugs.webkit.org/show_bug.cgi?id=235163 Reviewed by Chris Dumez. * Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb: 2022-01-18 Alex Christensen Use c++2a instead of gnu++2a for Cocoa builds https://bugs.webkit.org/show_bug.cgi?id=234936 Reviewed by Sam Weinig. * Configurations/Base.xcconfig: * Configurations/WebKitLegacy.xcconfig: * MigrateHeaders.make: 2022-01-15 Chris Dumez Introduce dynamicDowncast<>() for convenience https://bugs.webkit.org/show_bug.cgi?id=235259 Reviewed by Darin Adler. Start adopting dynamicDowncast<>(). * DOM/DOMUIKitExtensions.mm: (-[DOMHTMLElement structuralComplexityContribution]): * WebView/WebHTMLRepresentation.mm: (inputElementFromDOMElement): 2022-01-13 Tim Horton Fix a few Objective-C object leaks due to early returns in `init` https://bugs.webkit.org/show_bug.cgi?id=235162 Reviewed by Wenson Hsieh. * Storage/WebDatabaseQuotaManager.mm: (WebCore::if): 2022-01-12 Matt Woodrow _paintBehaviorForDestinationContext should consider kCGContextTypeDisplayList type contexts as potentially being snapshots https://bugs.webkit.org/show_bug.cgi?id=234626 Reviewed by Simon Fraser. _paintBehaviorForDestinationContext currently always returns `Normal` for contexts that aren't a bitmap context. AppKit now provides a context that is of type kCGContextTypeDisplayList, and we want to still potentially consider it a snapshot paint (if the other conditions below are met). This ensure images are sync decoded for consumers that just want a single paint. * WebView/WebFrame.mm: (-[WebFrame _paintBehaviorForDestinationContext:]): 2022-01-11 Michael Saboff Fixed installhdr build failures in WebCore and WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=235059 Reviewed by Filip Pizlo. Refactored how INSTALL_PATH is calculated to simplify the logic for the macOS / iOS location difference for the WebKitLegacy framework. In WebKitLegacy.xcconfig, that required changing NORMAL_PRODUCTION_FRAMEWORKS_DIR. Added the configuration values, ALTERNATE_ROOT_PATH and OUTPUT_ALTERNATE_ROOT_PATH, for iOS builds to drive the newly added create symlinks script. Did the same rework as in WebCore configuration to eliminate using SYSTEM_CONTENT_PATH twice for some paths. * Configurations/WebKitLegacy.xcconfig: 2022-01-10 Alex Christensen Start using C++20 https://bugs.webkit.org/show_bug.cgi?id=233963 Reviewed by Yusuke Suzuki. * Configurations/Base.xcconfig: * Configurations/WebKitLegacy.xcconfig: * MigrateHeaders.make: 2022-01-10 Elliott Williams postprocess-headers.sh: Avoid redundant processing to speed up incremental Xcode builds https://bugs.webkit.org/show_bug.cgi?id=234941 Reviewed by Jonathan Bedard. * postprocess-headers.sh: 2022-01-07 Alex Christensen Unreviewed, reverting r287698. Broke an internal build Reverted changeset: "Start using C++20" https://bugs.webkit.org/show_bug.cgi?id=233963 https://commits.webkit.org/r287698 2022-01-06 Tim Horton Move linkedOnOrAfter() to WTF https://bugs.webkit.org/show_bug.cgi?id=234942 Reviewed by Darin Adler. * DefaultDelegates/WebDefaultUIDelegate.mm: (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]): * Misc/WebDownload.mm: (shouldCallOnNetworkThread): * Misc/WebIconDatabase.mm: (+[WebIconDatabase sharedIconDatabase]): * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultAllowsPictureInPictureMediaPlayback): (WebKit::defaultJavaScriptCanOpenWindowsAutomatically): (WebKit::defaultPassiveTouchListenersAsDefaultOnDocument): (WebKit::defaultRequiresUserGestureToLoadVideo): (WebKit::defaultWebSQLEnabled): (WebKit::defaultShouldRestrictBaseURLSchemes): (WebKit::defaultShouldConvertInvalidURLsToBlank): (WebKit::defaultPassiveWheelListenersAsDefaultOnDocument): (WebKit::defaultWheelEventGesturesBecomeNonBlocking): * WebView/WebView.mm: (needsLaBanquePostaleQuirks): 2022-01-06 Alex Christensen Start using C++20 https://bugs.webkit.org/show_bug.cgi?id=233963 Reviewed by Yusuke Suzuki. * Configurations/Base.xcconfig: * Configurations/WebKitLegacy.xcconfig: * MigrateHeaders.make: 2022-01-06 Jean-Yves Avenard Have CachedRawResourceClient and related networking actors use SharedBuffer. https://bugs.webkit.org/show_bug.cgi?id=232424 rdar://84744687 Reviewed by Youenn Fablet. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::createPreviewLoaderClient): * WebView/WebFrame.mm: (-[WebFrame _commitData:]): 2022-01-05 Tim Horton Move more SDK checks to linkedOnOrAfter() https://bugs.webkit.org/show_bug.cgi?id=234875 Reviewed by Sam Weinig. * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultJavaScriptCanOpenWindowsAutomatically): * WebView/WebView.mm: (needsLaBanquePostaleQuirks): 2022-01-02 Wenson Hsieh [WebKit2] Camera continuity is disabled in richly editable content https://bugs.webkit.org/show_bug.cgi?id=234773 rdar://46323417 Reviewed by Darin Adler. Drive-by fix: add a missing `ALLOW_DEPRECATED_DECLARATIONS_END` for the unbalanced BEGIN declaration. * WebView/WebHTMLView.mm: (+[WebHTMLView _insertablePasteboardTypes]): 2022-01-01 Jeff Miller Update user-visible copyright strings to include 2022 https://bugs.webkit.org/show_bug.cgi?id=234263 Reviewed by Anders Carlsson. * Info.plist: 2021-12-22 Michael Saboff Fix WebKit Build issues when using system content path https://bugs.webkit.org/show_bug.cgi?id=234624 Reviewed by Filip Pizlo. Added SYSTEM_CONTENT_PATH processing to NORMAL_PRODUCTION_FRAMEWORKS_DIR. * Configurations/WebKitLegacy.xcconfig: 2021-12-21 Brady Eidson Make Notification identifiers be a UUID string instead of a uint64_t https://bugs.webkit.org/show_bug.cgi?id=234534 Reviewed by Alex Christensen. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::show): (WebNotificationClient::cancel): (WebNotificationClient::notificationObjectDestroyed): (WebNotificationClient::clearNotifications): Deleted. 2021-12-21 Wenson Hsieh Add support for a UI delegate method to decide how to handle detected modal containers https://bugs.webkit.org/show_bug.cgi?id=234440 rdar://77073735 Reviewed by Darin Adler. See WebKit ChangeLog for more details. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::decidePolicyForModalContainer): 2021-12-19 Wenson Hsieh Add client layer plumbing for classifying modal container controls https://bugs.webkit.org/show_bug.cgi?id=234320 Reviewed by Dean Jackson. See WebCore/ChangeLog for more details. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::classifyModalContainerControls): 2021-12-17 Simon Fraser Read the default value of the ScrollAnimatorEnabled setting from NSUserDefaults https://bugs.webkit.org/show_bug.cgi?id=234456 Reviewed by Tim Horton. It's impossible for a test to run with an animated keyboard scroll because platformAllowsScrollAnimation(), which reads from NSUserDefaults, always trumps the Setting. Fix by initializing the setting from NSUserDefaults and removing the platformAllowsScrollAnimation() check. This allows for a WebKitTestRunner test override the setting. Unfortunately in WebKitLegacy AppKit code consults the @"NSScrollAnimationEnabled" key, so DumpRenderTree has to continue to initialize this NSUserDefault to @NO and tests that try to change the Setting will fail. * WebView/WebPreferencesDefaultValues.h: * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultScrollAnimatorEnabled): 2021-12-18 Chris Dumez Convert ProtectionSpace enums into enum classes https://bugs.webkit.org/show_bug.cgi?id=234455 Reviewed by Alex Christensen. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace): 2021-12-16 Alex Christensen Fix iOS debug build https://bugs.webkit.org/show_bug.cgi?id=234365 * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2021-12-15 Darin Adler Many call sites use makeNeverDestroyed, but could instead take advantage of the NeverDestroyed deduction guide https://bugs.webkit.org/show_bug.cgi?id=234350 Reviewed by Sam Weinig. * Misc/WebNSPasteboardExtras.mm: (writableTypesForImageWithoutArchive): Use deduction. (writableTypesForImageWithArchive): * Misc/WebNSURLExtras.mm: (-[NSString _webkit_rangeOfURLScheme]): Ditto. * WebView/WebDataSource.mm: (+[WebDataSource _repTypesAllowImageTypeOmission:]): Ditto. * WebView/WebFrameView.mm: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Ditto. 2021-12-14 Jean-Yves Avenard Rename SharedBuffer classes. https://bugs.webkit.org/show_bug.cgi?id=233677 rdar://problem/85963900 Reviewed by Youenn Fablet. SharedBuffer are renamed FragmentedSharedBuffer and ContiguousSharedBuffer to SharedBuffer to better reflect their actual types. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: * WebView/WebDataSource.mm: * WebView/WebHTMLView.mm: * WebView/WebResource.mm: 2021-12-13 Jean-Yves Avenard Distinguish contiguous SharedBuffer from non-contiguous one and guarantee immutability https://bugs.webkit.org/show_bug.cgi?id=233030 rdar://85333814 Reviewed by Darin Adler. * DOM/DOMUIKitExtensions.mm: (-[DOMHTMLImageElement dataRepresentation:]): * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::getClientPasteboardData): * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::bufferForType): (WebPlatformStrategies::readBufferFromPasteboard): * WebView/WebDataSource.mm: (-[WebDataSource data]): * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation documentSource]): * WebView/WebHTMLView.mm: (createShareMenuItem): * WebView/WebResource.mm: (-[WebResource encodeWithCoder:]): (-[WebResource data]): (-[WebResource _stringValue]): 2021-12-11 Antti Koivisto Remove redundant StyleRule::Type enum https://bugs.webkit.org/show_bug.cgi?id=234156 Reviewed by Alan Bujtas. * DOM/DOMCSS.mm: (kitClass): * DOM/DOMCSSRule.mm: (-[DOMCSSRule type]): 2021-12-10 Michael Saboff https://bugs.webkit.org/show_bug.cgi?id=234173 Update Install Paths for build system changes Reviewed by Yusuke Suzuki. Updated install paths for changes in the build system that use a system path prefix. * Configurations/WebKitLegacy.xcconfig: 2021-12-10 Devin Rousso Allow `Pasteboard::readBuffer` to read from the pasteboard as a whole instead of a specific item https://bugs.webkit.org/show_bug.cgi?id=233940 Reviewed by Wenson Hsieh. In order to match the WK1 implementation of `-pasteFont:` , we need to read from the font pasteboard as a whole, not a specific item. Make the `index` into an `std::optional` so that we can have this behavior without needing to have a new method. No change in behavior. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::readBufferFromPasteboard): 2021-12-09 Devin Rousso Add a `DOMPasteAccessCategory` to control which pasteboard the WebProcess is granted access to when pasting https://bugs.webkit.org/show_bug.cgi?id=233939 Reviewed by Wenson Hsieh. Implementing `-pasteFont:` requires that we read from the font pasteboard instead of the general pasteboard. In order to allow web content to trigger this (e.g. `document.execCommand("PasteFont"))`) we must have a way for the WebProcess to signal that it wishes to read from the font pasteboard instead of the general pasteboard. As such, create and pass along a `DOMPasteAccessCategory` to `requestDOMPasteAccess`. No change in behavior. * WebCoreSupport/WebEditorClient.h: (WebEditorClient::requestDOMPasteAccess): 2021-12-09 Myles C. Maxfield and Don Olmstead Move TextCodec files from WebCore/platform/text to WebCore/PAL/text https://bugs.webkit.org/show_bug.cgi?id=233683 Reviewed by Yusuke Suzuki. Update to use the new PAL files. * Misc/WebNSURLExtras.mm: (-[NSString _webkit_stringByReplacingValidPercentEscapes]): * WebView/WebFrame.mm: (+[WebFrame stringWithData:textEncodingName:]): * WebView/WebPreferences.mm: (+[WebPreferences _systemCFStringEncoding]): (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): * WebView/WebResource.mm: (-[WebResource _stringValue]): 2021-12-09 Myles C. Maxfield [WebGPU] [MacCatalyst] Fix WebGPU Mac Catalyst build in Apple's internal build system https://bugs.webkit.org/show_bug.cgi?id=234072 Unreviewed. * Configurations/WebKitLegacy.xcconfig: 2021-12-09 Myles C. Maxfield [WebGPU] Fix WebGPU build in Apple's internal build system https://bugs.webkit.org/show_bug.cgi?id=234070 Unreviewed. The PAL headers get put in a different place. * Configurations/WebKitLegacy.xcconfig: 2021-12-08 Truitt Savell Unreviewed, reverting r286632. Broke 3 tests on iOS Reverted changeset: "Add a `DOMPasteAccessCategory` to control which pasteboard the WebProcess is granted access to when pasting" https://bugs.webkit.org/show_bug.cgi?id=233939 https://commits.webkit.org/r286632 2021-12-07 Wenson Hsieh Add support for `navigator.requestCookieConsent()` behind a disabled feature flag https://bugs.webkit.org/show_bug.cgi?id=233890 rdar://86117718 Reviewed by Darin Adler. Add an implementation stub for the new chrome client hook, `requestCookieConsent()`. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestCookieConsent): 2021-12-07 Devin Rousso Add a `DOMPasteAccessCategory` to control which pasteboard the WebProcess is granted access to when pasting https://bugs.webkit.org/show_bug.cgi?id=233939 Reviewed by Wenson Hsieh. Implementing `-pasteFont:` requires that we read from the font pasteboard instead of the general pasteboard. In order to allow web content to trigger this (e.g. `document.execCommand("PasteFont"))`) we must have a way for the WebProcess to signal that it wishes to read from the font pasteboard instead of the general pasteboard. As such, create and pass along a `DOMPasteAccessCategory` to `requestDOMPasteAccess`. No change in behavior. * WebCoreSupport/WebEditorClient.h: (WebEditorClient::requestDOMPasteAccess): 2021-12-07 Cameron McCormack Move FontCache singleton and instance on WorkerGlobalScope to ThreadGlobalData https://bugs.webkit.org/show_bug.cgi?id=233747 Reviewed by Darin Adler. * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics cachedFontDataCount]): (+[WebCoreStatistics cachedFontDataInactiveCount]): (+[WebCoreStatistics purgeInactiveFontData]): Update existing main thread callers of FontCache::singleton() to use FontCache::forCurrentThread(). 2021-12-06 Devin Rousso Change IDL `Date` to be backed by `WallTime` to avoid confusion when converting to native dates https://bugs.webkit.org/show_bug.cgi?id=233781 Reviewed by Darin Adler. JS `Date` is milliseconds-based, but some native dates (e.g. `NSDate`) are seconds-based. `WallTime` will help avoid confusion since not a generic type (e.g. `double`) and instead has explicitly defined conversion methods to seconds, milliseconds, etc.. * DOM/DOMInternal.h: (kit): (core): * DOM/DOMHTMLMediaElement.mm: (-[DOMHTMLMediaElement getStartDate]): 2021-12-02 Myles C. Maxfield [WebGPU] Hook up navigator.gpu.requestAdapter() https://bugs.webkit.org/show_bug.cgi?id=233619 Reviewed by Dean Jackson. * Configurations/WebKitLegacy.xcconfig: We have to be able to #include files from WebGPU. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createGPUForWebGPU const): Hook up GPUImpl to WebCore. 2021-12-02 Chris Dumez [WK2] Make Web Lock API work across multiple WebProcesses https://bugs.webkit.org/show_bug.cgi?id=233719 Reviewed by Alex Christensen. See WebCore changelog. * WebView/WebView.mm: (getOrCreateWebLockRegistry): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): 2021-12-01 Chris Dumez Regression(r283912) Broke backward compatibility for Swift bindings https://bugs.webkit.org/show_bug.cgi?id=233701 Reviewed by Darin Adler. Rename EpochTimeStamp back to DOMTimeStamp in DOMObject.h & DOMEvent.h since those are API headers and we need to maintain backward compatibility. * DOM/DOMEvent.h: * DOM/DOMEvent.mm: (-[DOMEvent timeStamp]): * DOM/DOMObject.h: 2021-11-24 David Kilzer Compiler should be able to check localized format strings for consistency Reviewed by Darin Adler. * Misc/WebLocalizableStringsInternal.mm: (WebLocalizedStringInternal): - Use localizedNSString() instead of localizedString() to eliminate the need to convert from CFString -> String -> NSString. 2021-11-16 Nikolaos Mouchtaris Rename TextDecoration to TextDecorationLine https://bugs.webkit.org/show_bug.cgi?id=232729 Reviewed by Myles C. Maxfield. * WebView/WebView.mm: (-[WebView updateTextTouchBar]): 2021-11-11 Nikolaos Mouchtaris Make scroll granularity an enum class https://bugs.webkit.org/show_bug.cgi?id=232641 Reviewed by Cameron McCormack. * WebView/WebFrameView.mm: (-[WebFrameView _scrollToBeginningOfDocument]): (-[WebFrameView _scrollToEndOfDocument]): (-[WebFrameView _pageVertically:]): (-[WebFrameView _pageHorizontally:]): (-[WebFrameView _scrollLineVertically:]): (-[WebFrameView _scrollLineHorizontally:]): 2021-11-11 Sam Weinig Factor platform specific code out of HTMLModelElement https://bugs.webkit.org/show_bug.cgi?id=232848 Reviewed by Dean Jackson. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Use DummyModelPlayerProvider for the DummyModelPlayerProvider since the feature is not supported for WebKitLegacy at the moment. 2021-11-10 Darin Adler [CF] Reduce duplication and unneeded buffer allocations and copying in URL code, also remove unused methods and functions https://bugs.webkit.org/show_bug.cgi?id=232220 Reviewed by Alex Christensen. * Misc/WebNSURLExtras.h: Tweaked comments a bit. No need to say methods are "new", since that won't be true in the future. Removed unused methods +[NSURL _web_URLWithUserTypedString:relativeToURL:], +[NSURL _webkit_URLWithUserTypedString:relativeToURL:], +[NSURL _web_URLWithData:], +[NSURL _web_URLWithData:relatveToURL:]. Wanted to remove even more nearly unused methods: many were used only inside the WebKit project, in legacy plug-in code, and some seemed unused, but it wasn't easy for me to quickly verify that. * Misc/WebNSURLExtras.mm: Removed "using namespace WebCore" and "using namespace WTF". (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): Deleted. (+[NSURL _web_URLWithUserTypedString:]): Use WTF prefix explicitly. (+[NSURL _webkit_URLWithUserTypedString:relativeToURL:]): Deleted. (+[NSURL _webkit_URLWithUserTypedString:]): Use WTF prefix explicitly. (+[NSURL _web_URLWithDataAsString:]): Removed special case for nil since the code will do the right thing with nil without an explicit check. (+[NSURL _web_URLWithDataAsString:relativeToURL]): Ditto. Also formatted the code as a one-liner. (+[NSURL _web_URLWithData:]): Deleted. (+[NSURL _web_URLWithData:relativeToURL:]): Deleted. (-[NSURL _web_originalData]): Use WTF prefix explicitly. (-[NSURL _web_originalDataAsString]): Ditto. (-[NSURL _web_isEmpty]): Use bridge_cast and make code style checker happy by using "!" instead of "== 0". (-[NSURL _web_URLCString]): Use WTF prefix explicitly. (-[NSURL _webkit_canonicalize]): Use WebCore prefix explicitly. (-[NSURL _webkit_URLByRemovingFragment]): Use WTF prefix explicitly. (-[NSURL _web_schemeSeparatorWithoutColon]): Deleted. (-[NSURL _web_dataForURLComponentType:]): Deleted. (-[NSURL _web_hostData]): Use WTF prefix explicitly. Rearranged for clarity and slightly improved efficiency as well. (-[NSString _web_isUserVisibleURL]): Use WTF prefix explicitly. (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Use WebCore prefix explicitly. (-[NSString _web_decodeHostName]): Use WTF prefix explicitly. (-[NSString _web_encodeHostName]): Ditto. (-[NSString _webkit_decodeHostName]): Ditto. (-[NSString _webkit_encodeHostName]): Ditto. 2021-11-10 Tim Nguyen Migrate DialogElementEnabled from RuntimeFlags to Settings https://bugs.webkit.org/show_bug.cgi?id=232926 Reviewed by Youenn Fablet. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences dialogElementEnabled]): Deleted. (-[WebPreferences setDialogElementEnabled:]): Deleted. * WebView/WebPreferencesPrivate.h: 2021-11-09 Commit Queue Unreviewed, reverting r285536. https://bugs.webkit.org/show_bug.cgi?id=232915 causes API test crashes Reverted changeset: "[CF] Reduce duplication and unneeded buffer allocations and copying in URL code, also remove unused methods and functions" https://bugs.webkit.org/show_bug.cgi?id=232220 https://commits.webkit.org/r285536 2021-10-28 Darin Adler [CF] Reduce duplication and unneeded buffer allocations and copying in URL code, also remove unused methods and functions https://bugs.webkit.org/show_bug.cgi?id=232220 Reviewed by Alex Christensen. * Misc/WebNSURLExtras.h: Tweaked comments a bit. No need to say methods are "new", since that won't be true in the future. Removed unused methods +[NSURL _web_URLWithUserTypedString:relativeToURL:], +[NSURL _webkit_URLWithUserTypedString:relativeToURL:], +[NSURL _web_URLWithData:], +[NSURL _web_URLWithData:relatveToURL:]. Wanted to remove even more nearly unused methods: many were used only inside the WebKit project, in legacy plug-in code, and some seemed unused, but it wasn't easy for me to quickly verify that. * Misc/WebNSURLExtras.mm: Removed "using namespace WebCore" and "using namespace WTF". (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): Deleted. (+[NSURL _web_URLWithUserTypedString:]): Use WTF prefix explicitly. (+[NSURL _webkit_URLWithUserTypedString:relativeToURL:]): Deleted. (+[NSURL _webkit_URLWithUserTypedString:]): Use WTF prefix explicitly. (+[NSURL _web_URLWithDataAsString:]): Removed special case for nil since the code will do the right thing with nil without an explicit check. (+[NSURL _web_URLWithDataAsString:relativeToURL]): Ditto. Also formatted the code as a one-liner. (+[NSURL _web_URLWithData:]): Deleted. (+[NSURL _web_URLWithData:relativeToURL:]): Deleted. (-[NSURL _web_originalData]): Use WTF prefix explicitly. (-[NSURL _web_originalDataAsString]): Ditto. (-[NSURL _web_isEmpty]): Use bridge_cast and make code style checker happy by using "!" instead of "== 0". (-[NSURL _web_URLCString]): Use WTF prefix explicitly. (-[NSURL _webkit_canonicalize]): Use WebCore prefix explicitly. (-[NSURL _webkit_URLByRemovingFragment]): Use WTF prefix explicitly. (-[NSURL _web_schemeSeparatorWithoutColon]): Deleted. (-[NSURL _web_dataForURLComponentType:]): Deleted. (-[NSURL _web_hostData]): Use WTF prefix explicitly. Rearranged for clarity and slightly improved efficiency as well. (-[NSString _web_isUserVisibleURL]): Use WTF prefix explicitly. (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Use WebCore prefix explicitly. (-[NSString _web_decodeHostName]): Use WTF prefix explicitly. (-[NSString _web_encodeHostName]): Ditto. (-[NSString _webkit_decodeHostName]): Ditto. (-[NSString _webkit_encodeHostName]): Ditto. 2021-11-06 David Kilzer Remove empty directories from from svn.webkit.org repository as of r285357 Unreviewed clean up. * Plugins/Hosted: Removed. 2021-11-05 Nikolaos Mouchtaris Make scroll bar mode an enum class https://bugs.webkit.org/show_bug.cgi?id=232651 Reviewed by Simon Fraser. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): (-[WebDynamicScrollBarsView allowsVerticalScrolling]): * WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]): 2021-11-03 Chris Dumez Unreviewed iOS build fix. * WebCoreSupport/WebNotificationClient.mm: (-[WebNotificationPolicyListener NO_RETURN_DUE_TO_ASSERT]): (-[WebNotificationPolicyListener denyOnlyThisRequest]): Deleted. (-[WebNotificationPolicyListener shouldClearCache]): Deleted. 2021-11-01 Brady Eidson Make WebChromeClient's m_webView pointer weak. https://bugs.webkit.org/show_bug.cgi?id=232588 Reviewed by David Kilzer. * WebCoreSupport/WebChromeClient.h: 2021-10-29 Alex Christensen Fix internal macOS build after r285047 https://bugs.webkit.org/show_bug.cgi?id=232462 * MigrateHeaders.make: 2021-10-29 David Kilzer [WebKitLegacy] Enable -Wformat=2 warnings Reviewed by Darin Adler. * Configurations/Base.xcconfig: (WARNING_CFLAGS): - Replace -Wformat-security with -Wformat=2, which enables more warnings like -Wformat-nonliteral. * Misc/WebLocalizableStringsInternal.h: (WebLocalizedStringInternal): - Add NS_FORMAT_ARGUMENT() macro to fix -Wformat-nonliteral warnings. 2021-10-29 Alex Christensen Remove code inside ENABLE(NETSCAPE_PLUGIN_API) https://bugs.webkit.org/show_bug.cgi?id=232462 Reviewed by Anders Carlsson. * Plugins/Hosted/HostedNetscapePluginStream.h: Removed. * Plugins/Hosted/HostedNetscapePluginStream.mm: Removed. * Plugins/Hosted/NetscapePluginHostManager.h: Removed. * Plugins/Hosted/NetscapePluginHostManager.mm: Removed. * Plugins/Hosted/NetscapePluginHostProxy.h: Removed. * Plugins/Hosted/NetscapePluginHostProxy.mm: Removed. * Plugins/Hosted/NetscapePluginInstanceProxy.h: Removed. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed. * Plugins/Hosted/ProxyInstance.h: Removed. * Plugins/Hosted/ProxyInstance.mm: Removed. * Plugins/Hosted/ProxyRuntimeObject.h: Removed. * Plugins/Hosted/ProxyRuntimeObject.mm: Removed. * Plugins/Hosted/WebHostedNetscapePluginView.h: Removed. * Plugins/Hosted/WebHostedNetscapePluginView.mm: Removed. * Plugins/Hosted/WebKitPluginAgent.defs: Removed. * Plugins/Hosted/WebKitPluginAgentReply.defs: Removed. * Plugins/Hosted/WebKitPluginClient.defs: Removed. * Plugins/Hosted/WebKitPluginHost.defs: Removed. * Plugins/Hosted/WebKitPluginHostTypes.defs: Removed. * Plugins/Hosted/WebKitPluginHostTypes.h: Removed. * Plugins/Hosted/WebTextInputWindowController.h: Removed. * Plugins/Hosted/WebTextInputWindowController.m: Removed. * Plugins/WebBaseNetscapePluginView.h: Removed. * Plugins/WebBaseNetscapePluginView.mm: Removed. * Plugins/WebBasePluginPackage.h: * Plugins/WebBasePluginPackage.mm: (+[WebBasePluginPackage pluginWithPath:]): * Plugins/WebNetscapePluginEventHandler.h: Removed. * Plugins/WebNetscapePluginEventHandler.mm: Removed. * Plugins/WebNetscapePluginEventHandlerCocoa.h: Removed. * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Removed. * Plugins/WebNetscapePluginPackage.h: Removed. * Plugins/WebNetscapePluginPackage.mm: Removed. * Plugins/WebNetscapePluginStream.h: Removed. * Plugins/WebNetscapePluginStream.mm: Removed. * Plugins/WebNetscapePluginView.h: Removed. * Plugins/WebNetscapePluginView.mm: Removed. * Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]): * Plugins/WebPluginDatabase.mm: (PluginPackageCandidates::update): (-[WebPluginDatabase removePluginInstanceViewsFor:]): (-[WebPluginDatabase destroyAllPluginInstanceViews]): * Plugins/WebPluginRequest.h: Removed. * Plugins/WebPluginRequest.m: Removed. * Plugins/npapi.mm: Removed. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::createPlugin): (WebFrameLoaderClient::redirectDataToPlugin): (NetscapePluginWidget::NetscapePluginWidget): Deleted. (NetscapePluginWidget::platformLayer const): Deleted. (NetscapePluginWidget::getFormValue): Deleted. (NetscapePluginWidget::handleEvent): Deleted. (NetscapePluginWidget::clipRectChanged): Deleted. (NetscapePluginWidget::notifyWidget): Deleted. * WebView/WebFrame.mm: (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Deleted. (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Deleted. * WebView/WebFramePrivate.h: * WebView/WebHTMLView.mm: (needsCursorRectsSupportAtPoint): (-[WebHTMLView viewWillMoveToHostWindow:]): (-[WebHTMLView viewDidMoveToHostWindow]): (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Deleted. (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Deleted. (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Deleted. * WebView/WebHTMLViewPrivate.h: * WebView/WebView.mm: 2021-10-28 Per Arne Vollan Layout test is crashing inside WebChromeClient::createWindow https://bugs.webkit.org/show_bug.cgi?id=232460 Reviewed by Brent Fulgham. Add null check for local NetscapePluginHostProxy pointer variable. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::didCreateWindow): 2021-10-28 Alex Christensen Disable NETSCAPE_PLUGIN_API at build time on macOS and Windows https://bugs.webkit.org/show_bug.cgi?id=232396 Reviewed by Geoff Garen. * WebView/WebFramePrivate.h: * WebView/WebHTMLViewPrivate.h: 2021-10-28 Youenn Fablet [ Mac wk1 ] 2 media-capabilities/webrtc tests are flaky failures https://bugs.webkit.org/show_bug.cgi?id=232283 Reviewed by Eric Carlson. * WebView/WebView.mm: 2021-10-24 Ian Anderson Enable the modules verifier for WebKitLegacy in Apple internal when using a new enough Xcode https://bugs.webkit.org/show_bug.cgi?id=232190 Reviewed by David Kilzer. Add WK_XCODE_VERSION_BEFORE_13_1 build settings to WebKitLegacy and then use them to enable the modules verifier in Xcode 13.1 and later. * Configurations/Base.xcconfig: * Configurations/WebKitLegacy.xcconfig: 2021-10-22 Ian Anderson Add a module map file for PrivateFrameworks/WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=230735 Reviewed by David Kilzer. Define modules for the Cocoa Touch environment. macOS can't define modules in WebKitLegacy because it's a nested framework on that platform. Set up the modules verifier tool for Apple Internal (it's not supported in the public Xcode). Don't enable it yet because some of the Safari builders use too old of an Xcode. Add the Apple Internal guards for NSURLDownload from WebDownload.h NSURLDownloadSPI.h so it can be included in the module. WebCreateFragmentInternal.h is an Objective-C++ header, but the WebKitLegacy module should be usable by plain Objective-C clients. C++ guards so that it can be included in the module. Switch a few quoted includes to framework style angle includes, which are required for modules. Add some missing includes. * Configurations/WebKitLegacy.xcconfig: * DOM/DOMEventListener.h: * DOM/DOMEventTarget.h: * DOM/DOMNodeFilter.h: * DOM/DOMXPathNSResolver.h: * DOM/WebDOMOperationsPrivate.h: * History/WebHistoryItemPrivate.h: * Misc/NSURLDownloadSPI.h: * Misc/WebCache.h: * Misc/WebDownload.h: * Misc/WebKitErrorsPrivate.h: * Misc/WebLocalizableStrings.h: * Misc/WebUserContentURLPattern.h: * Plugins/Hosted/WebKitPluginHostTypes.h: * Plugins/WebPlugin.h: * Plugins/WebPluginContainer.h: * Storage/WebDatabaseManagerPrivate.h: * Storage/WebDatabaseQuotaManager.h: * Storage/WebStorageManagerPrivate.h: * WebCoreSupport/WebCreateFragmentInternal.h: * WebCoreSupport/WebSecurityOriginPrivate.h: * WebView/WebDeviceOrientation.h: * WebView/WebDeviceOrientationProvider.h: * WebView/WebDeviceOrientationProviderMock.h: * WebView/WebEditingDelegatePrivate.h: * WebView/WebFormDelegatePrivate.h: * WebView/WebGeolocationPosition.h: * WebView/WebResourceLoadDelegatePrivate.h: 2021-10-22 Commit Queue Unreviewed, reverting r284713. https://bugs.webkit.org/show_bug.cgi?id=232187 Broke some Apple internal builds Reverted changeset: "Add a module map file for PrivateFrameworks/WebKitLegacy" https://bugs.webkit.org/show_bug.cgi?id=230735 https://commits.webkit.org/r284713 2021-10-22 Ian Anderson Add a module map file for PrivateFrameworks/WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=230735 Reviewed by David Kilzer. Define modules for the Cocoa Touch environment. macOS can't define modules in WebKitLegacy because it's a nested framework on that platform. Enable the modules verifier tool for Apple Internal (it's not supported in the public Xcode). Add the Apple Internal guards for NSURLDownload from WebDownload.h to NSURLDownloadSPI.h so it can be included in the module. WebCreateFragmentInternal.h is an Objective-C++ header, but the WebKitLegacy module should be usable by plain Objective-C clients. Add C++ guards so that it can be included in the module. Switch a few quoted includes to framework style angle includes, which are required for modules. Add some missing includes. * Configurations/WebKitLegacy.xcconfig: * DOM/DOMEventListener.h: * DOM/DOMEventTarget.h: * DOM/DOMNodeFilter.h: * DOM/DOMXPathNSResolver.h: * DOM/WebDOMOperationsPrivate.h: * History/WebHistoryItemPrivate.h: * Misc/NSURLDownloadSPI.h: * Misc/WebCache.h: * Misc/WebDownload.h: * Misc/WebKitErrorsPrivate.h: * Misc/WebLocalizableStrings.h: * Misc/WebUserContentURLPattern.h: * Plugins/Hosted/WebKitPluginHostTypes.h: * Plugins/WebPlugin.h: * Plugins/WebPluginContainer.h: * Storage/WebDatabaseManagerPrivate.h: * Storage/WebDatabaseQuotaManager.h: * Storage/WebStorageManagerPrivate.h: * WebCoreSupport/WebCreateFragmentInternal.h: * WebCoreSupport/WebSecurityOriginPrivate.h: * WebView/WebDeviceOrientation.h: * WebView/WebDeviceOrientationProvider.h: * WebView/WebDeviceOrientationProviderMock.h: * WebView/WebEditingDelegatePrivate.h: * WebView/WebFormDelegatePrivate.h: * WebView/WebGeolocationPosition.h: * WebView/WebResourceLoadDelegatePrivate.h: 2021-10-19 Darin Adler [Cocoa] Merge and simplify the nsColor family of functions https://bugs.webkit.org/show_bug.cgi?id=231992 Reviewed by Anders Carlsson. * DOM/DOMRGBColor.mm: (-[DOMRGBColor color]): Use cocoaColor instead of nsColor. * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromCocoaColor instead of colorFromNSColor. * WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Use colorFromCocoaColor instead of colorFromNSColor. (-[WebFrame _bodyBackgroundColor]): Use cocoaColor instead of nsColor. * WebView/WebHTMLView.mm: (extractUnderlines): Use colorFromCocoaColor instead of colorFromNSColor. * WebView/WebView.mm: (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]): Use cocoaColor instead of -[UIColor initWithCGColor:] and cachedCGColor. (-[WebTextTouchBarItemController _webChangeColor:]): Use colorFromCocoaColor instead of colorFromNSColor. (-[WebView updateTextTouchBar]): Use cocoaColor instead of nsColor. 2021-10-19 Chris Dumez cachedCGColor() and nsColor() should return smart pointers https://bugs.webkit.org/show_bug.cgi?id=231909 Reviewed by Tim Horton. r276283 attempted to make cachedCGColor() and nsColor() thread-safe but the fix was incomplete since those functions return unretained objects that can be released from the cache on any other thread. This patch updates cachedCGColor() and nsColor() to return a RetainPtr to address the issue. * DOM/DOMRGBColor.mm: (-[DOMRGBColor color]): * WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): * WebView/WebView.mm: (-[WebView updateTextTouchBar]): 2021-10-18 Commit Queue Unreviewed, reverting r284240. https://bugs.webkit.org/show_bug.cgi?id=231931 NeedDifferentArchitectureToWorkWithWebpushd Reverted changeset: "WebKit Managed Notifications: Skeleton NotificationProvider." https://bugs.webkit.org/show_bug.cgi?id=231786 https://commits.webkit.org/r284240 2021-10-15 Brady Eidson WebKit Managed Notifications: Skeleton NotificationProvider. and https://bugs.webkit.org/show_bug.cgi?id=231786 Reviewed by Alex Christensen. * WebCoreSupport/WebNotificationClient.mm: (-[WebNotificationPolicyListener NO_RETURN_DUE_TO_ASSERT]): (-[WebNotificationPolicyListener denyOnlyThisRequest]): Deleted. 2021-10-14 Alex Christensen Remove Variant.h https://bugs.webkit.org/show_bug.cgi?id=231744 Reviewed by Darin Adler. * DOM/DOMHTMLOptionsCollection.mm: 2021-10-14 Myles C. Maxfield All the SDKVariant.xcconfig files should match https://bugs.webkit.org/show_bug.cgi?id=231663 Reviewed by Youenn Fablet. * Configurations/SDKVariant.xcconfig: 2021-10-14 David Kilzer Modernize WebDatabaseManagerClient Reviewed by Sihui Liu. * Storage/WebDatabaseManager.mm: (-[WebDatabaseManager init]): - Add WebKit namespace to WebDatabaseManagerClient::sharedWebDatabaseManagerClient() and convert reference into pointer. * Storage/WebDatabaseManagerClient.h: (WebKit::WebDatabaseManagerClient): - Put WebDatabaseManagerClient in WebKit namespace. * Storage/WebDatabaseManagerClient.mm: - Put WebDatabaseManagerClient in WebKit namespace. (WebKit::WebDatabaseManagerClient::sharedWebDatabaseManagerClient): - Update to use NeverDestroyed<> and to return a reference. 2021-10-13 Chris Dumez Drop makeWeakPtr() and use WeakPtr { } directly https://bugs.webkit.org/show_bug.cgi?id=231679 Reviewed by Darin Adler. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::requestCandidatesForSelection): 2021-10-13 Megan Gardner Remove adjustForIOSCaretWhenScrolling() code https://bugs.webkit.org/show_bug.cgi?id=230454 Reviewed by Simon Fraser. The "adjustForIOSCaretWhenScrolling" code attempted to over-scroll horizontally at the start or end of an overflow scroll in order to make space for the caret to show. However, it was wrong in various ways. It always did this, even for scrollers with no visible caret. It was web-detectable that the scrollX for a scroller could end up as -2. And removing the code doesn't result in obviously incorrect behavior. * DOM/DOMHTML.mm: (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]): * WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]): (-[WebFrame _scrollDOMRangeToVisible:withInset:]): 2021-10-13 Alex Christensen Remove WTF::Variant and WTF::get https://bugs.webkit.org/show_bug.cgi?id=231675 Reviewed by Chris Dumez. * WebView/WebFrame.mm: (-[WebFrame getDictationResultRanges:andMetadatas:]): (-[WebFrame dictationResultMetadataForRange:]): 2021-10-12 Jer Noble [Build-time perf] Forward-declare more things in Document.h https://bugs.webkit.org/show_bug.cgi?id=231489 Reviewed by Myles C. Maxfield. Move the folowing enumerations outside their classes so that they can be forward-declared: - MediaProducer::MediaStateFlags -> MediaProducerMediaStateFlags - MediaProducer::MediaCaptureKind -> MediaProducerMediaCaptureKind - MediaProducer::MutedState -> MediaProducerMutedState * DOM/DOMDocument.mm: * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::playbackTargetPickerClientStateDidChange): * WebView/WebMediaPlaybackTargetPicker.h: * WebView/WebMediaPlaybackTargetPicker.mm: (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange): * WebView/WebView.mm: (-[WebView _playbackTargetPickerClientStateDidChange:state:]): * WebView/WebViewInternal.h: 2021-10-12 Alex Christensen Use std::variant instead of WTF::Variant https://bugs.webkit.org/show_bug.cgi?id=231629 Reviewed by Chris Dumez. * DOM/DOMHTMLSelectElement.mm: (-[DOMHTMLSelectElement add:before:]): 2021-10-12 Chris Dumez Allow direct construction of WeakPtr without makeWeakPtr() https://bugs.webkit.org/show_bug.cgi?id=231580 Reviewed by Darin Adler. Allow direct construction of WeakPtr without makeWeakPtr(), and deprecate makeWeakPtr(). * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::requestCheckingOfString): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::getLoadDecisionForIcons): 2021-10-11 Chris Dumez DOMTimeStamp is now EpochTimeStamp https://bugs.webkit.org/show_bug.cgi?id=231496 Reviewed by Sam Weinig. * DOM/DOMEvent.h: * DOM/DOMEvent.mm: (-[DOMEvent timeStamp]): * DOM/DOMObject.h: 2021-10-08 Jer Noble [Build-time perf] Forward-declare more things in Element.h https://bugs.webkit.org/show_bug.cgi?id=231283 Reviewed by Myles C. Maxfield. Include ElementInlines.h in various necessary places. * WebView/WebHTMLRepresentation.mm: 2021-10-07 Darin Adler Get rid of the deviceClass function, up-leveling to deviceClassIsSmallScreen https://bugs.webkit.org/show_bug.cgi?id=231344 Reviewed by Tim Horton. * WebView/WebPreferences.mm: Removed uneeded Device.h include. * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultAllowsInlineMediaPlayback): Use !deviceClassIsSmallScreen instead of deviceClass == iPad. (WebKit::defaultAllowsInlineMediaPlaybackAfterFullscreen): Use deviceClassIsSmallScreen instead of deviceClass != iPad. (WebKit::defaultInlineMediaPlaybackRequiresPlaysInlineAttribute): Ditto. (WebKit::defaultMediaSourceEnabled): Use !deviceClassIsSmallScreen instead of deviceClass != iPhone and != iPod, and also remove unneeded compile time conditionals. 2021-10-05 Tim Horton should be draggable, similar to https://bugs.webkit.org/show_bug.cgi?id=229246 Reviewed by Wenson Hsieh. * WebView/WebView.mm: (kit): Do nothing for drags in legacy WebKit. 2021-10-03 David Kilzer WTF::RetainPtr<> allows assignment of two pointer types that are not assignable Reviewed by Darin Adler. * Plugins/WebBasePluginPackage.mm: (+[WebBasePluginPackage pluginWithPath:]): - Use explicit type with RetainPtr<> to match return type. 2021-10-01 Chris Dumez Drop support for macOS < 10.15 https://bugs.webkit.org/show_bug.cgi?id=231085 Reviewed by Darin Adler. * WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]): (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Deleted. 2021-10-01 Ian Anderson WebKitLegacy's module map files don't get installed https://bugs.webkit.org/show_bug.cgi?id=230736 Reviewed by David Kilzer. Revert r271607 because it doesn't work and isn't the right approach. * Configurations/WebKitLegacy.xcconfig: * History/WebBackForwardListPrivate.h: * Misc/WebKitLegacy_Private.h: Removed. * Misc/WebKitLegacy_iOS_Private.h: Removed. * Misc/WebKitLegacy_macOS_Private.h: Removed. 2021-09-29 Chris Dumez Make WebLocalizedString() thread-safe https://bugs.webkit.org/show_bug.cgi?id=230954 Reviewed by Alexey Proskuryakov. Make WebLocalizedString() thread-safe. It takes minimal effort to make it thread-safe given that the NSBundle API is thread-safe [1] and clients keep calling it on the background thread. [1] https://developer.apple.com/documentation/foundation/nslocalizedstringwithdefaultvalue "As of OS X 10.11 and iOS 9, NSBundle is thread-safe. As such, you can safely call NSLocalizedStringWithDefaultValue from any execution context." * Misc/WebLocalizableStrings.mm: 2021-09-28 Chris Dumez Move Cross-Origin-Opener-Policy handling to the NetworkProcess https://bugs.webkit.org/show_bug.cgi?id=230812 Reviewed by Youenn Fablet. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForResponse): 2021-09-23 Tim Horton Move more linked-on-or-after checks to WebCore::linkedOnOrAfter() https://bugs.webkit.org/show_bug.cgi?id=230694 Reviewed by Wenson Hsieh. * Misc/WebDownload.mm: (shouldCallOnNetworkThread): * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultRequiresUserGestureToLoadVideo): (WebKit::defaultWebSQLEnabled): (WebKit::defaultShouldConvertInvalidURLsToBlank): 2021-09-23 Tim Horton shouldAllowPictureInPictureMediaPlayback should use WebCore's linkedOnOrAfter() https://bugs.webkit.org/show_bug.cgi?id=230674 Reviewed by Simon Fraser. * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultAllowsPictureInPictureMediaPlayback): Adopt the WebCore API (which supports overrides for Safari and for testing). 2021-09-23 Brent Fulgham Remove XSS Auditor: Part 3 (Deprecate API) https://bugs.webkit.org/show_bug.cgi?id=230661 Reviewed by Mark Lam. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences isXSSAuditorEnabled]): (-[WebPreferences setXSSAuditorEnabled:]): * WebView/WebPreferencesPrivate.h: 2021-09-22 Chris Dumez Drop makeRef() and use Ref { } instead https://bugs.webkit.org/show_bug.cgi?id=230626 Reviewed by Alex Christensen. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::requestCheckingOfString): 2021-09-21 Chris Dumez Drop makeRefPtr() and use RefPtr { } directly instead https://bugs.webkit.org/show_bug.cgi?id=230564 Reviewed by Alex Christensen. * DOM/DOM.mm: (-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]): * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): * WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteDragImage): * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementWithName:inForm:]): (-[WebHTMLRepresentation controlsInForm:]): * WebView/WebView.mm: (-[WebView updateTextTouchBar]): 2021-09-21 David Kilzer Rename {checked,dynamic}_ns_cast<> to {checked,dynamic}_objc_cast<> Reviewed by Brent Fulgham. * WebCoreSupport/WebDragClient.mm: * WebView/WebHTMLView.mm: - Import for future move of WTF::dynamic_objc_cast<> from RetainPtr.h to that header. 2021-09-20 Chris Dumez Stop using makeRef(*this) / makeRefPtr(this) https://bugs.webkit.org/show_bug.cgi?id=230464 Reviewed by Alex Christensen. * Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::start): * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::start): 2021-09-17 Alex Christensen Use ObjectIdentifier for ResourceLoader https://bugs.webkit.org/show_bug.cgi?id=230278 Reviewed by Michael Catanzaro. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::shouldUseCredentialStorage): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace): (WebFrameLoaderClient::connectionProperties): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::willCacheResponse const): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): * WebView/WebDocumentLoaderMac.h: * WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::increaseLoadCount): (WebDocumentLoaderMac::decreaseLoadCount): * WebView/WebViewInternal.h: 2021-09-17 Yusuke Suzuki [JSC] Add fast property enumeration mode for JSON.stringify https://bugs.webkit.org/show_bug.cgi?id=230393 Reviewed by Mark Lam. * Plugins/Hosted/NetscapePluginInstanceProxy.h: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::demarshalValues): 2021-09-14 Chris Dumez [Hardening] Validate IDBValue's blob paths in WebIDBServer::putOrAdd() https://bugs.webkit.org/show_bug.cgi?id=230233 Reviewed by Brady Eidson. * WebCoreSupport/WebPlatformStrategies.mm: 2021-09-13 Youenn Fablet Remove WritableStream runtime flag https://bugs.webkit.org/show_bug.cgi?id=230148 Reviewed by Sihui Liu. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences writableStreamAPIEnabled]): Deleted. (-[WebPreferences setWritableStreamAPIEnabled:]): Deleted. * WebView/WebPreferencesPrivate.h: 2021-09-11 David Kilzer CFNotificationCenterAddObserver() should use weak observers Reviewed by Darin Adler. * WebView/WebHTMLView.mm: (hardwareKeyboardAvailabilityChangedCallback): - Modernize syntax for WeakObjCPtr constructor. (-[WebHTMLView initWithFrame:]): - Use _CFNotificationObserverIsObjC to fix the bug. - Extract local variables and change notificationName cast to be ARC-ready. Remove notificationName from autoreleasePool. (-[WebHTMLView dealloc]): - Extract local variable and change notificationName cast to be ARC-ready. Remove notificationName from autoreleasePool. 2021-09-08 Jean-Yves Avenard Safari TP 131 audio canPlayType() reports false negatives https://bugs.webkit.org/show_bug.cgi?id=229799 rdar://problem/82776747 Reviewed by Youenn Fablet. * WebView/WebPreferencesDefaultValues.h: * WebView/WebPreferencesDefaultValues.mm: Remove no longer used method. 2021-09-07 Sihui Liu Add basic support for Storage API https://bugs.webkit.org/show_bug.cgi?id=229925 Reviewed by Darin Adler. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): 2021-08-31 Chris Dumez Enable SharedArrayBuffer support when COOP/COEP headers are used https://bugs.webkit.org/show_bug.cgi?id=229559 Reviewed by Alex Christensen. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForResponse): 2021-08-31 Sihui Liu REGRESSION (r281771): ASSERTION FAILED: !m_deletionHasBegun under WebCore::Permissions::~Permissions() https://bugs.webkit.org/show_bug.cgi?id=229714 Reviewed by Chris Dumez. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): 2021-08-26 Darin Adler Cut down on use of CFGetTypeID, using dynamic_cf_cast instead; related streamlining https://bugs.webkit.org/show_bug.cgi?id=229414 Reviewed by Tim Horton. * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage bundleVersion]): Use dynamic_cf_cast. 2021-08-30 Sihui Liu Add stubs for Permissions API https://bugs.webkit.org/show_bug.cgi?id=229339 Reviewed by Chris Dumez. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): 2021-08-24 Chris Dumez [WK2] Implement process-swapping based on Cross-Origin-Opener-Policy HTTP header https://bugs.webkit.org/show_bug.cgi?id=229203 Reviewed by Alex Christensen. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForResponse): 2021-08-19 Megan Gardner Remove old unused code and out of date comments. https://bugs.webkit.org/show_bug.cgi?id=229210 Reviewed by Anders Carlsson. * WebView/WebView.mm: * WebView/WebViewPrivate.h: 2021-08-19 Alex Christensen Remove more non-inclusive language from Source https://bugs.webkit.org/show_bug.cgi?id=229230 Reviewed by Myles C. Maxfield. * WebKit.order: * WebView/WebViewPrivate.h: 2021-08-19 Simon Fraser Rename Element::clientRect() which does not return a value in web-exposed "client" coordinates https://bugs.webkit.org/show_bug.cgi?id=229243 Reviewed by Wenson Hsieh. The result of Element::clientRect() is in the coordinate space of the root view, not in the space of the Element's Frame, so does not match the other functions on Element with "client" in the name. Rename to Element::boundingBoxInRootViewCoordinates() for clarity. * WebCoreSupport/WebValidationMessageClient.mm: (WebValidationMessageClient::showValidationMessage): (WebValidationMessageClient::updateValidationBubbleStateIfNeeded): 2021-08-19 Simon Fraser Rename EventHandler::sendScrollEvent() to scheduleScrollEvent() since the event is not sent synchronously https://bugs.webkit.org/show_bug.cgi?id=229256 Reviewed by Geoffrey Garen. Rename EventHandler::sendScrollEvent() and FrameView::sendScrollEvent() to scheduleScrollEvent() since the event dispatch happens via the next rendering update. * WebView/WebFrame.mm: (-[WebFrame sendScrollEvent]): 2021-08-16 David Kilzer "make analyze" should run clang static analyzer in deep mode Reviewed by Alexey Proskuryakov. * migrate-headers.sh: - Treat "analyze" the same as "build" for "ACTION" environment variable. 2021-08-16 David Kilzer -[WebView initWithCoder:] should use -[NSCoder decodeValueOfObjCType:at:size:] Reviewed by Anders Carlsson. * WebView/WebView.mm: (-[WebView initWithCoder:]): - Switch to -[NSCoder decodeValueOfObjCType:at:size:]. 2021-08-13 Chris Dumez Add Cross-Origin-Embedder-Policy support for Blob URLs https://bugs.webkit.org/show_bug.cgi?id=229041 Reviewed by Alex Christensen. * WebCoreSupport/WebPlatformStrategies.mm: 2021-08-12 Chris Dumez Regression(r273194) Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased https://bugs.webkit.org/show_bug.cgi?id=229056 Reviewed by Geoffrey Garen. Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased. I got this wrong in r273194. * Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker forwardInvocation:]): 2021-08-12 Youenn Fablet REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing https://bugs.webkit.org/show_bug.cgi?id=228926 Reviewed by Eric Carlson. isFeatureFlagEnabled is called when creating/initializing WebPreferences. It used to check for WebView, which triggers the execution of WebView initialize method while DumpRenderTree is in the middle of creating its testing setup, including its storage testing sessions. Instead, check for WebResource to remove this side effect and get back to past DumpRenderTree initialization. * WebView/WebPreferencesDefaultValues.mm: (WebKit::isFeatureFlagEnabled): 2021-08-11 Peng Liu Function _os_feature_enabled_impl() expects compile-time static strings as arguments https://bugs.webkit.org/show_bug.cgi?id=229017 Reviewed by Tim Horton. There are multiple issues in the current implementation of `isFeatureFlagEnabled()`. 1. `_os_feature_enabled_impl()` expects compile-time static strings as arguments. So we should not use `String` here. 2. As Simon Fraser pointed out, `String::characters8()` is not null terminated. * WebView/WebPreferencesDefaultValues.h: * WebView/WebPreferencesDefaultValues.mm: (WebKit::isFeatureFlagEnabled): 2021-08-10 Peng Liu REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing https://bugs.webkit.org/show_bug.cgi?id=228926 Reviewed by Jer Noble. Revert a part of r280726 while investigating the test failures. * WebView/WebPreferencesDefaultValues.mm: (WebKit::isFeatureFlagEnabled): 2021-08-10 Chris Dumez Add Cross-Origin-Opener-Policy support for Blob URLs https://bugs.webkit.org/show_bug.cgi?id=228924 Reviewed by Alex Christensen. * WebCoreSupport/WebPlatformStrategies.mm: 2021-08-10 Chris Dumez Document.baseURI is inaccurate for iframe srcdoc documents https://bugs.webkit.org/show_bug.cgi?id=228933 Reviewed by Alex Christensen. * DOM/DOMHTMLBaseElement.mm: (-[DOMHTMLBaseElement href]): 2021-08-09 Chris Dumez Blob URL changes after loading it https://bugs.webkit.org/show_bug.cgi?id=228923 Reviewed by Geoff Garen. * WebCoreSupport/WebPlatformStrategies.mm: 2021-08-09 Myles C. Maxfield Support WTF logging channels https://bugs.webkit.org/show_bug.cgi?id=228768 Reviewed by Fujii Hironori. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2021-08-07 Myles C. Maxfield Deduplicate logging channel algorithms https://bugs.webkit.org/show_bug.cgi?id=228809 Reviewed by Fujii Hironori. * Misc/WebKitLogInitialization.h: Copied from Source/WebKit/Platform/LogInitialization.h. * Misc/WebKitLogInitialization.mm: Copied from Source/WebKitLegacy/mac/Misc/WebKitLogging.m. (WebKit::logChannels): (ReportDiscardedDelegateException): * Misc/WebKitLogging.h: * Misc/WebKitLogging.m: (ReportDiscardedDelegateException): Deleted. * WebCoreSupport/WebDragClient.mm: * WebView/WebDelegateImplementationCaching.mm: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2021-08-07 Commit Queue Unreviewed, reverting r280756. https://bugs.webkit.org/show_bug.cgi?id=228897 Broke gtk build Reverted changeset: "Deduplicate logging channel algorithms" https://bugs.webkit.org/show_bug.cgi?id=228809 https://commits.webkit.org/r280756 2021-08-07 Myles C. Maxfield Deduplicate logging channel algorithms https://bugs.webkit.org/show_bug.cgi?id=228809 Reviewed by Fujii Hironori. * Misc/WebKitLogInitialization.h: Copied from Source/WebKit/Platform/LogInitialization.h. * Misc/WebKitLogInitialization.mm: Copied from Source/WebKitLegacy/mac/Misc/WebKitLogging.m. (WebKit::logChannels): (ReportDiscardedDelegateException): * Misc/WebKitLogging.h: * Misc/WebKitLogging.m: (ReportDiscardedDelegateException): Deleted. * WebCoreSupport/WebDragClient.mm: * WebView/WebDelegateImplementationCaching.mm: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2021-08-06 Peng Liu [macOS] Clean up Feature Flags related code https://bugs.webkit.org/show_bug.cgi?id=228803 Reviewed by Tim Horton. On macOS, Safari Technology Preview or a local build WebKit/Safari will always get the default preference values through the "Feature Flags" SPI. Unfortunately, this approach won't work if the OS does not provide correct default preference values. With this patch, we only get default preference values with the SPI for system WebKit on macOS. For all other cases, we use hardcoded values. So that WebKit will always get the correct default preference values. This patch also fixes a few mistakes in two preferences: "webm_webaudio" and "vp8_decoder". * WebView/WebPreferencesDefaultValues.h: * WebView/WebPreferencesDefaultValues.mm: (WebKit::isFeatureFlagEnabled): (WebKit::defaultIncrementalPDFEnabled): (WebKit::defaultWebXREnabled): (WebKit::defaultWebMParserEnabled): (WebKit::defaultWebMWebAudioEnabled): (WebKit::defaultVP8DecoderEnabled): (WebKit::defaultVP9DecoderEnabled): 2021-08-05 Cameron McCormack Stop tracking form elements with FormController https://bugs.webkit.org/show_bug.cgi?id=228724 Reviewed by Darin Adler. formElementsCharacterCount is unused and can be removed. * WebView/WebFrame.mm: * WebView/WebFramePrivate.h: 2021-07-29 Myles C. Maxfield Stop building WebGPU and the WHLSL compiler to decrease binary size https://bugs.webkit.org/show_bug.cgi?id=228179 Reviewed by Dean Jackson, Robin Morisset, and Devin Rousso. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences webGPUEnabled]): Deleted. (-[WebPreferences setWebGPUEnabled:]): Deleted. * WebView/WebPreferencesDefaultValues.h: * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultWebGPUEnabled): Deleted. * WebView/WebPreferencesPrivate.h: 2021-07-26 Wenson Hsieh [macOS Monterey] Pressing Fn+E should present the emoji picker when editing https://bugs.webkit.org/show_bug.cgi?id=228300 rdar://77558672 Reviewed by Tim Horton. Apply a similar fix, this time for WebKit1 on macOS. * WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]): Only append "insertText:" for a corresponding NSEvent with the Function key held down if it doesn't also map to a item in the main menu. 2021-07-16 Megan Gardner Pipe App Highlight scrolling through UI Process in preparation for Note Overlay avoidance. https://bugs.webkit.org/show_bug.cgi?id=227914 Reviewed by Tim Horton. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scrollMainFrameToRevealRect const): 2021-07-15 Jean-Yves Avenard [Wk1] media/media-source/media-webm-opus-partial.html is a consistent failure (Enable VP8/VP9/Vorbis/Opus in WebKitLegacy) https://bugs.webkit.org/show_bug.cgi?id=228005 rdar://80346720 Reviewed by Jer Noble. * WebView/WebPreferencesDefaultValues.h: Add relevant settings getter methods. * WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultWebMParserEnabled): (WebKit::defaultVP8DecoderEnabled): (WebKit::defaultVP9DecoderEnabled): 2021-07-15 Chris Dumez Add initial support for BroadcastChannel behind a runtime flag https://bugs.webkit.org/show_bug.cgi?id=227924 Reviewed by Sam Weinig. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _preferencesChanged:]): 2021-07-15 Megan Gardner Rename scrollRectIntoView to scrollContainingScrollViewsToRevealRect for clarity. https://bugs.webkit.org/show_bug.cgi?id=227995 Reviewed by Tim Horton. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scrollContainingScrollViewsToRevealRect const): (WebChromeClient::scrollRectIntoView const): Deleted. 2021-07-14 Rob Buis Rename hasOverflowClip() to prepare for the real overflow:clip https://bugs.webkit.org/show_bug.cgi?id=227899 Reviewed by Simon Fraser. Rename hasOverflowClip() to prepare for the real overflow:clip. * DOM/DOMHTML.mm: (-[DOMHTMLElement scrollXOffset]): (-[DOMHTMLElement scrollYOffset]): (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]): 2021-06-25 Commit Queue Unreviewed, reverting r279266. https://bugs.webkit.org/show_bug.cgi?id=227402 Causes crash loop Reverted changeset: "Remove references to order files" https://bugs.webkit.org/show_bug.cgi?id=227377 https://trac.webkit.org/changeset/279266 2021-06-24 Sihui Liu Remove references to order files https://bugs.webkit.org/show_bug.cgi?id=227377 rdar://76070556 Reviewed by Mark Lam. * Configurations/WebKitLegacy.xcconfig: 2021-06-22 Wenson Hsieh [Live Text] [macOS] Add an internal option to disable inline text selection in images https://bugs.webkit.org/show_bug.cgi?id=227265 rdar://79460142 Reviewed by Tim Horton. Rename ContextMenuItemTagLookUpImage to ContextMenuItemTagQuickLookImage. * WebView/WebHTMLView.mm: (toTag): 2021-06-21 Wenson Hsieh [macOS] [WebKitLegacy] Non-actionable "Look Up" action appears when right clicking images https://bugs.webkit.org/show_bug.cgi?id=227240 Reviewed by Devin Rousso. Override the new client hook and return false in legacy WebKit. * WebCoreSupport/WebContextMenuClient.h: 2021-06-17 Alex Christensen Remove empty header WebTypesInternal.h https://bugs.webkit.org/show_bug.cgi?id=227094 Reviewed by Fujii Hironori. * DefaultDelegates/WebDefaultUIDelegate.mm: * History/WebBackForwardList.mm: * History/WebHistory.mm: * History/WebHistoryItem.mm: * Misc/WebDownload.mm: * Misc/WebElementDictionary.mm: * Misc/WebNSDataExtras.h: * Misc/WebTypesInternal.h: Removed. * Plugins/WebBasePluginPackage.mm: * Plugins/WebNetscapePluginPackage.mm: * WebView/WebArchive.mm: * WebView/WebDelegateImplementationCaching.h: * WebView/WebHTMLRepresentation.mm: * WebView/WebHTMLView.mm: * WebView/WebPDFDocumentExtras.mm: * WebView/WebPDFRepresentation.mm: * WebView/WebTextCompletionController.mm: * WebView/WebTextIterator.mm: * WebView/WebViewData.h: * WebView/WebViewInternal.h: 2021-06-16 Chris Dumez Document's execCommand() / queryCommand*() should throw an exception on non-HTML/XHTML documents https://bugs.webkit.org/show_bug.cgi?id=227016 Reviewed by Darin Adler. Update ObjC bindings since the WebCore API now returns ExceptionOr<> types. * DOM/DOMDocument.mm: (-[DOMDocument execCommand:userInterface:value:]): (-[DOMDocument queryCommandEnabled:]): (-[DOMDocument queryCommandIndeterm:]): (-[DOMDocument queryCommandState:]): (-[DOMDocument queryCommandSupported:]): (-[DOMDocument queryCommandValue:]): 2021-06-11 Megan Gardner Rename AppHighlight group to QuickNote to correctly reflect feature. https://bugs.webkit.org/show_bug.cgi?id=226888 Reviewed by Tim Horton. * WebView/WebHTMLView.mm: (toTag): * WebView/WebUIDelegatePrivate.h: 2021-06-10 Alex Christensen Re-enable legacy WebView plug-ins (but not NPAPI) https://bugs.webkit.org/show_bug.cgi?id=226890 Reviewed by Tim Horton. In r276720 I put the check in the wrong place. This should also fix rdar://77179042 again, which I broke, fixed, broke, and am now fixing again. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): 2021-06-08 Devin Rousso [Payment Request] upstream new features https://bugs.webkit.org/show_bug.cgi?id=226740 Reviewed by Andy Estes. - recurring line items (`HAVE_PASSKIT_RECURRING_SUMMARY_ITEM` and `ENABLE_APPLE_PAY_RECURRING_LINE_ITEM`) - deferred line items (`HAVE_PASSKIT_DEFERRED_SUMMARY_ITEM` and `ENABLE_APPLE_PAY_DEFERRED_LINE_ITEM`) - estimated shipping dates (`HAVE_PASSKIT_SHIPPING_METHOD_DATE_COMPONENTS_RANGE` and `ENABLE_APPLE_PAY_SHIPPING_METHOD_DATE_COMPONENTS_RANGE`) - coupon code entry (`HAVE_PASSKIT_COUPON_CODE` and `ENABLE_APPLE_PAY_COUPON_CODE`) - shipped vs in-store pickup (`HAVE_PASSKIT_SHIPPING_CONTACT_EDITING_MODE` and `ENABLE_APPLE_PAY_SHIPPING_CONTACT_EDITING_MODE`) * WebCoreSupport/WebPaymentCoordinatorClient.h: * WebCoreSupport/WebPaymentCoordinatorClient.mm: (WebPaymentCoordinatorClient::completeCouponCodeChange): Renamed from `WebPaymentCoordinatorClient::completePaymentMethodModeChange`. 2021-06-07 Wenson Hsieh Upstream WebKit support for Live Text https://bugs.webkit.org/show_bug.cgi?id=226706 Reviewed by Tim Horton. * WebView/WebHTMLView.mm: Replace IMAGE_EXTRACTION with IMAGE_ANALYSIS. 2021-06-06 Wenson Hsieh Turn TextIteratorBehaviorFlag into an enum class and wrap it in OptionSet https://bugs.webkit.org/show_bug.cgi?id=226691 Reviewed by Darin Adler. See WebCore/ChangeLog for more information. * WebView/WebFrame.mm: (-[WebFrame _stringForRange:]): 2021-06-05 Wenson Hsieh [macOS] Move DataDetectors softlinking in DataDetectorsSPI.h out into a separate PAL header https://bugs.webkit.org/show_bug.cgi?id=226669 Reviewed by Sam Weinig. Adopt the new PAL softlinking header in a few places. See WebCore/ChangeLog for more details. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _clearImmediateActionState]): (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]): (-[WebImmediateActionController _animationControllerForDataDetectedText]): (-[WebImmediateActionController _animationControllerForDataDetectedLink]): 2021-06-04 Chris Dumez Use Vector instead of Vector to store bytes in SharedBuffer https://bugs.webkit.org/show_bug.cgi?id=226623 Reviewed by Darin Adler. Use Vector instead of Vector to store bytes in SharedBuffer. Also have SharedBuffer::data() return a `const uint8_t*` instead of `const char*`. This is our preferred type to store bytes. * Plugins/Hosted/HostedNetscapePluginStream.h: * Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didReceiveData): * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginView:receivedData:]): * Plugins/WebNetscapePluginStream.h: * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::didReceiveData): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginView:receivedData:]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): 2021-06-01 Darin Adler Remove https://bugs.webkit.org/show_bug.cgi?id=226437 Reviewed by Chris Dumez. * DOM/DOMRangeInternal.h: Added import of . * WebView/WebGeolocationPosition.mm: Removed import of . * WebView/WebGeolocationPositionInternal.h: Added import of . 2021-06-01 Antti Koivisto Rename InlineBox to LegacyInlineBox https://bugs.webkit.org/show_bug.cgi?id=226501 Reviewed by Alan Bujtas. * DOM/DOMUIKitExtensions.mm: 2021-05-30 Darin Adler Remove WTF::Optional synonym for std::optional, using that class template directly instead https://bugs.webkit.org/show_bug.cgi?id=226433 Reviewed by Chris Dumez. * : Let the do-webcore-rename script rename Optional<> to std::optional<>. 2021-05-27 Darin Adler Next step toward using std::optional directly instead of through WTF::Optional typedef https://bugs.webkit.org/show_bug.cgi?id=226280 Reviewed by Chris Dumez. * : Accept the renaming done by do-webcore-rename. 2021-05-25 Tim Horton Virtualize GraphicsContext https://bugs.webkit.org/show_bug.cgi?id=226170 Reviewed by Simon Fraser. * Misc/WebCoreStatistics.mm: (-[WebFrame printToCGContext:pageWidth:pageHeight:]): * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:]): * WebInspector/WebNodeHighlightView.mm: (-[WebNodeHighlightView drawRect:]): * WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]): 2021-05-24 Sam Weinig Convert DestinationColorSpace from an enum to class wrapping a platform color space (CGColorSpaceRef for CG ports, etc.) https://bugs.webkit.org/show_bug.cgi?id=226143 Reviewed by Darin Adler. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Update for new DestinationColorSpace class. 2021-05-24 Darin Adler Remove StringBuilder::appendLiteral https://bugs.webkit.org/show_bug.cgi?id=226137 Reviewed by Chris Dumez. * WebView/WebHTMLRepresentation.mm: (regExpForLabels): Use append instead of appendLiteral. Also imrpove local variable names a bit. 2021-05-24 Commit Queue Unreviewed, reverting r277940. https://bugs.webkit.org/show_bug.cgi?id=226182 Caused Safari crash under IPC::typeFromCFTypeRef Reverted changeset: "Convert DestinationColorSpace from an enum to class wrapping a platform color space (CGColorSpaceRef for CG ports, etc.)" https://bugs.webkit.org/show_bug.cgi?id=226143 https://trac.webkit.org/changeset/277940 2021-05-24 Chris Dumez Drop CheckedLock / CheckedCondition aliases https://bugs.webkit.org/show_bug.cgi?id=226176 Reviewed by Kate Cheney. Drop CheckedLock / CheckedCondition aliases now that they are the default. * DOM/DOMInternal.mm: 2021-05-23 Sam Weinig Convert DestinationColorSpace from an enum to class wrapping a platform color space (CGColorSpaceRef for CG ports, etc.) https://bugs.webkit.org/show_bug.cgi?id=226143 Reviewed by Darin Adler. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Update for new DestinationColorSpace class. 2021-05-22 Chris Dumez Replace LockHolder with Locker in local variables https://bugs.webkit.org/show_bug.cgi?id=226133 Reviewed by Darin Adler. Replace LockHolder with Locker in local variables. It is shorter and it allows switching the lock type more easily since the compiler with deduce the lock type T for Locker. * WebView/WebView.mm: (-[WebView _synchronizeCustomFixedPositionLayoutRect]): (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]): (-[WebView _setCustomFixedPositionLayoutRect:]): (-[WebView _fetchCustomFixedPositionLayoutRect:]): 2021-05-22 Commit Queue Unreviewed, reverting r277913. https://bugs.webkit.org/show_bug.cgi?id=226140 Caused multiple layout-test crash on mac debug queues Reverted changeset: "Replace LockHolder with Locker in local variables" https://bugs.webkit.org/show_bug.cgi?id=226133 https://trac.webkit.org/changeset/277913 2021-05-21 Chris Dumez Replace LockHolder with Locker in local variables https://bugs.webkit.org/show_bug.cgi?id=226133 Reviewed by Darin Adler. Replace LockHolder with Locker in local variables. It is shorter and it allows switching the lock type more easily since the compiler with deduce the lock type T for Locker. * WebView/WebView.mm: (-[WebView _synchronizeCustomFixedPositionLayoutRect]): (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]): (-[WebView _setCustomFixedPositionLayoutRect:]): (-[WebView _fetchCustomFixedPositionLayoutRect:]): 2021-05-21 Wenson Hsieh [macOS] Adopt QLItem in WKImageExtractionPreviewController https://bugs.webkit.org/show_bug.cgi?id=226114 rdar://76657718 Reviewed by Tim Horton. Adopt the new QuickLookUI softlinking header in PAL. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController webViewClosed]): 2021-05-21 Chris Dumez Replace more static Locks with CheckedLocks in WebKit / WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=226093 Reviewed by Darin Adler. Replace more static Locks with CheckedLocks so that we can benefit from Clang Thread Safety Analysis. * DOM/DOMInternal.mm: (getDOMWrapper): (addDOMWrapper): (removeDOMWrapper): 2021-05-20 Alexey Shvayka [WebIDL] Remove [ImplicitThis] and [CustomProxyToJSObject] extended attributes https://bugs.webkit.org/show_bug.cgi?id=223758 Reviewed by Sam Weinig. Use inherits instead of toJSDOMWindow() if the value is never a JSProxy. * WebView/WebView.mm: (+[WebView _reportException:inContext:]): 2021-05-19 Sam Weinig Update Base64 encoding/decoding to match more modern WebKit conventions https://bugs.webkit.org/show_bug.cgi?id=225920 Reviewed by Chris Dumez. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::wrapCryptoKey const): (WebChromeClient::unwrapCryptoKey const): Update to use new Optional returning defaultWebCryptoMasterKey(). * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::save): Update to use new Optional returning base64Decode(). 2021-05-17 Peng Liu [GPUP] WebContent process should not pull audio session category from the GPU Process https://bugs.webkit.org/show_bug.cgi?id=225826 Reviewed by Darin Adler. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setAudioSessionCategoryOverride:]): 2021-05-15 Ryosuke Niwa Delete WebSQL code from WebKit2 https://bugs.webkit.org/show_bug.cgi?id=225739 Reviewed by Sihui Liu. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2021-05-13 Megan Gardner Add textIndicator bounce for AppHighlights on scroll. https://bugs.webkit.org/show_bug.cgi?id=225727 Reviewed by Tim Horton. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setTextIndicator const): * WebView/WebHTMLView.mm: (-[WebHTMLView quickLookWithEvent:]): * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController webView:didHandleScrollWheel:]): (-[WebImmediateActionController _cancelImmediateAction]): (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): (-[WebImmediateActionController _defaultAnimationController]): (-[WebImmediateActionController menuItemDidClose:]): (-[WebImmediateActionController _animationControllerForDataDetectedText]): (-[WebImmediateActionController _animationControllerForDataDetectedLink]): * WebView/WebView.mm: (-[WebView _animationControllerForDictionaryLookupPopupInfo:]): (-[WebView _setTextIndicator:]): (-[WebView _setTextIndicator:withLifetime:]): (-[WebView _clearTextIndicatorWithAnimation:]): (-[WebView _showDictionaryLookupPopup:]): (-[WebView _dictionaryLookupPopoverWillClose:]): * WebView/WebViewInternal.h: 2021-05-12 Chris Dumez Notification.requestPermission() should return a Promise https://bugs.webkit.org/show_bug.cgi?id=225712 Reviewed by Darin Adler. Update code now that WebCore passes a CompletionHandler instead of a NotificationPermissionCallback. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::requestPermission): (-[WebNotificationPolicyListener initWithCompletionHandler:]): (-[WebNotificationPolicyListener allow]): (-[WebNotificationPolicyListener deny]): 2021-05-12 Chris Dumez Queue notification permission requests for the same origin on WebKit side https://bugs.webkit.org/show_bug.cgi?id=225701 Reviewed by Geoffrey Garen. Remove some dead code. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: 2021-05-10 Wenson Hsieh Make WebCore::HitTestRequest::RequestType an enum class https://bugs.webkit.org/show_bug.cgi?id=225597 Reviewed by Sam Weinig. See WebCore/ChangeLog for more details. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary const): * WebView/WebFrame.mm: (-[WebFrame elementAtPoint:]): * WebView/WebHTMLView.mm: (-[WebHTMLView elementAtPoint:allowShadowContent:]): * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController performHitTestAtPoint:]): 2021-05-08 Darin Adler [Cocoa] Remove the one use of String::toInt from WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=225568 Reviewed by Sam Weinig. * DOM/DOMHTMLInputElement.mm: (-[DOMHTMLInputElement setSize:]): Use -[NSString intValue] instead of WTF::String::toInt. Both functions ignore leading spaces, and both ignore trailing junk, so there is no significant change in behavior. 2021-05-07 Wenson Hsieh [macOS] Set the -isSourceEditable property when presenting webpage translation popup https://bugs.webkit.org/show_bug.cgi?id=225515 Reviewed by Tim Horton. See WebCore/ChangeLog for more details. * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::handleTranslation): * WebView/WebView.mm: (-[WebView _handleContextMenuTranslation:]): (-[WebView _handleContextMenuTranslation:selectionBounds:menuLocation:]): Deleted. * WebView/WebViewInternal.h: 2021-05-04 Alex Christensen Remove unused references to PageGroup from WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=225359 Reviewed by Sihui Liu. * History/WebHistory.mm: * History/WebHistoryInternal.h: * Storage/WebStorageManager.mm: * WebView/WebView.mm: 2021-05-03 Devin Rousso [macCatalyst] "Enter Full Screen" button in media controls disappears https://bugs.webkit.org/show_bug.cgi?id=225210 Reviewed by Eric Carlson. In order for the "Enter Full Screen" media controls button to stay visible the `