2014-04-22 Brent Fulgham Check (rather than assume) element is a RenderTableSection before using it https://bugs.webkit.org/show_bug.cgi?id=121858 Reviewed by David Kilzer. * fast/table/table-insert-object-before-td-crash-expected.txt: Added. * fast/table/table-insert-object-before-td-crash.html: Added. 2014-04-19 Alexey Proskuryakov Crashes in HTMLFormElement::submit. https://bugs.webkit.org/show_bug.cgi?id=131910 Reviewed by Anders Carlsson. * fast/forms/form-submission-crash-2-expected.txt: Added. * fast/forms/form-submission-crash-2.html: Added. * fast/forms/form-submission-crash-expected.txt: Added. * fast/forms/form-submission-crash.html: Added. 2014-04-17 Darin Adler hostname extraction from a URL should not decode percent-escape sequences https://bugs.webkit.org/show_bug.cgi?id=131837 rdar://problem/15211936 Reviewed by Anders Carlsson and Dave Hyatt. * fast/dom/DOMURL/parsing-expected.txt: Added. * fast/dom/DOMURL/parsing.html: Added. * fast/dom/HTMLAnchorElement/anchor-element-href-parsing-expected.txt: Added. * fast/dom/HTMLAnchorElement/anchor-element-href-parsing.html: Added. 2014-04-03 David Hyatt Continuations casting issue. https://bugs.webkit.org/show_bug.cgi?id=130057 Reviewed by Simon Fraser. * fast/block/continuation-crash-expected.txt: Added. * fast/block/continuation-crash.html: Added. 2014-04-14 Jon Honeycutt Assertion failure under FEImage::determineAbsolutePaintRect() Reviewed by Geoffrey Garen. * svg/filters/feImage-filter-assertion-expected.txt: Added. * svg/filters/feImage-filter-assertion.html: Added. 2014-04-11 Jon Honeycutt Assertion failure changing select element size during focus event dispatch Reviewed by Andy Estes. * fast/forms/select-change-size-during-focus-expected.txt: Added. * fast/forms/select-change-size-during-focus.html: Added. 2014-04-10 Jon Honeycutt Assertion failure in WebCore::FlexBoxIterator::next() Reviewed by Tim Horton. * fast/flexbox/collapse-anonymous-wrappers-assertion-expected.txt: Added. * fast/flexbox/collapse-anonymous-wrappers-assertion.html: Added. 2014-04-07 Jon Honeycutt Assertion failure, !node || node->isElementNode(), in WebCore::RenderBlock::clone() Reviewed by Antti Koivisto. * fast/multicol/fuzzed-test-case-expected.txt: Added. * fast/multicol/fuzzed-test-case.html: Added. 2014-04-02 David Kilzer Use outermost containing isolate when constructing bidi runs Reviewed by Darin Adler. Merged from Blink (patch by jww@chromium.org): https://src.chromium.org/viewvc/blink?revision=157268&view=revision http://crbug.com/279277 Update containingIsolate to go back all the way to top isolate from current root, rather than stopping at the first isolate it finds. This works because the current root is always updated with each isolate run. * fast/text/international/unicode-bidi-isolate-nested-with-removes-expected.txt: Updated. * fast/text/international/unicode-bidi-isolate-nested-with-removes-not-adjacent-expected.txt: Added. * fast/text/international/unicode-bidi-isolate-nested-with-removes-not-adjacent.html: Added. * fast/text/international/unicode-bidi-isolate-nested-with-removes.html: Updated. 2014-04-02 David Kilzer Add LayoutTest for crash with bidi isolates Merged from Blink (patch by jww@chromium.org): https://src.chromium.org/viewvc/blink?revision=156580&view=revision http://crbug.com/265838 See Bug 120504: Fix nested unicode-bidi: isolate * fast/text/international/unicode-bidi-isolate-nested-with-removes-expected.txt: Added. * fast/text/international/unicode-bidi-isolate-nested-with-removes.html: Added. 2014-04-01 Daniel Bates RenderQuote must destroy remaining text renderer before first letter renderer https://bugs.webkit.org/show_bug.cgi?id=78023 Reviewed by Brent Fulgham. Merged from Blink (patch by Abhishek Arya): https://src.chromium.org/viewvc/blink?view=rev&revision=151270 * fast/css-generated-content/quote-first-letter-crash-expected.txt: Added. * fast/css-generated-content/quote-first-letter-crash.html: Added. 2014-04-01 David Kilzer Do not allow HTTP refresh headers to refresh to javascript: URLs Reviewed by Alexey Proskuryakov. Merged from Blink (patch by tsepez@chromium.org): https://src.chromium.org/viewvc/blink?revision=153912&view=revision http://crbug.com/258151 This behaviour has been standard in IE since IE7. This makes us both more compatible and less vulnerable to XSS. * http/tests/security/no-javascript-refresh-expected.txt: Added. * http/tests/security/no-javascript-refresh-static-expected.txt: Added. * http/tests/security/no-javascript-refresh-static.html: Added. * http/tests/security/no-javascript-refresh.php: Added. - Original Blink layout tests with typos fixed and 'PASS:' text added. * http/tests/security/no-javascript-location.html: Added. * http/tests/security/no-javascript-location-expected.txt: Added. * http/tests/security/resources/no-javascript-location.php: Copied from LayoutTests/http/tests/security/no-javascript-refresh.php. * http/tests/security/no-javascript-location-percent-escaped.html: Added. * http/tests/security/no-javascript-location-percent-escaped-expected.txt: Added. * http/tests/security/resources/no-javascript-location-percent-escaped.php: Added. - Add tests using a javascript: URL in a Location: header. * http/tests/security/no-javascript-refresh-percent-escaped.php: Copied from LayoutTests/http/tests/security/no-javascript-refresh.php. * http/tests/security/no-javascript-refresh-percent-escaped-expected.txt: Added. * http/tests/security/no-javascript-refresh-spaces.php: Copied from LayoutTests/http/tests/security/no-javascript-refresh.php. * http/tests/security/no-javascript-refresh-spaces-expected.txt: Added. - Add tests using a percent-escaped javascript: URL and a javascript: URL with leading spaces in a Refresh: header from a web server. * http/tests/security/no-javascript-refresh-static-percent-escaped.html: Added. * http/tests/security/no-javascript-refresh-static-percent-escaped-expected.txt: Added. * http/tests/security/no-javascript-refresh-static-spaces.html: Added. * http/tests/security/no-javascript-refresh-static-spaces-expected.txt: Added. - Add tests using a percent-escaped javascript: URL and a javascript: URL with leading spaces in a meta http-equiv tag. 2014-03-29 David Kilzer Preserve selection end positions in directionOfSelection Reviewed by Brent Fulgham. Merged from Blink (patch by kenrb@chromium.org): https://src.chromium.org/viewvc/blink?revision=150621&view=revision http://crbug.com/164263 VisibleSelection::visibleStart() and VisibleSelection::visibleEnd() can both cause layouts, which has the potential to invalidate any rendertree-based objects. This was causing a problem in FrameSelection::directionOfSelection(), where a reference to a lineBox was being held across a call to visibleEnd(). This patch ensures that the any layout is completed before linebox references are retrieved. * editing/selection/layout-during-move-selection-crash-expected.txt: Added. * editing/selection/layout-during-move-selection-crash.html: Added. 2014-03-28 Radu Stavila In some situations, partial layouts of floating elements produce incorrect results. https://bugs.webkit.org/show_bug.cgi?id=122668 Reviewed by David Hyatt. Added test to ensure an assertion is not reached when performing a partial layout of float elements in certain situations. * fast/block/float/floats-in-clean-line-crash-expected.txt: Added. * fast/block/float/floats-in-clean-line-crash.html: Added. 2014-03-28 Myles C. Maxfield Clear SVGInlineTextBox fragments when the text changes. https://bugs.webkit.org/show_bug.cgi?id=130879 Reviewed by Darin Adler. Ported from Blink: https://src.chromium.org/viewvc/blink?revision=150456&view=revision When failing, this test will render garbage characters or crash. * svg/custom/unicode-in-tspan-multi-svg-crash-expected.txt: Added. * svg/custom/unicode-in-tspan-multi-svg-crash.html: Added. 2014-03-01 David Kilzer Fix lifetime handling of SVGPropertyTearOffs Reviewed by Maciej Stachowiak. Merged from Blink (patch by Ojan Vafai): https://src.chromium.org/viewvc/blink?revision=157801&view=revision http://crbug.com/288771 -Replace SVGStaticPropertyWithParentTearOff with SVGMatrixTearOff since it's only used in that one place. This means we can get rid of the templatizing and the method pointer. -Change SVGPropertyTearOff to keep track of it's child tearoffs and call detachWrapper on its child tearoffs when it's destroyed or when it's wrapper is detached. -Have SVGPropertyTearOff hold WeakPtrs to the child tearoffs to avoid having a cycle. * svg/transforms/svg-matrix-tearoff-crash-expected.txt: Added. * svg/transforms/svg-matrix-tearoff-crash.html: Added. 2014-03-25 David Kilzer Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit Reviewed by Darin Adler. Merged from Blink (patch by Ian Beer): http://crbug.com/303657 https://src.chromium.org/viewvc/blink?view=rev&revision=158938 * fast/forms/form-submission-crash-successful-submit-button-expected.txt: Added. * fast/forms/form-submission-crash-successful-submit-button.html: Added. 2014-03-21 Andreas Kling HTMLFrameOwnerElement should obey the SubframeLoadingDisabler when creating subframes Merge Blink r156744 by Adam Klein. * fast/frames/set-iframe-src-in-pagehide-crash-expected.txt: Added. * fast/frames/set-iframe-src-in-pagehide-crash.html: Added. 2014-04-13 Youenn Fablet [GStreamer] No CORS support for media elements https://bugs.webkit.org/show_bug.cgi?id=99037 Reviewed by Philippe Normand. http/tests/security/video-cross-origin-accessfailure.html verifies that cross-origin streams that fail CORS check are not played when crossorigin attribute is set. http/tests/security/video-cross-origin-accesssameorigin.html verifies that access to same-origin streams are played when crossorigin attribute is set. * http/tests/security/video-cross-origin-accessfailure-expected.txt: Added. * http/tests/security/video-cross-origin-accessfailure.html: Added. * http/tests/security/video-cross-origin-accesssameorigin-expected.txt: Added. * http/tests/security/video-cross-origin-accesssameorigin.html: Added. * platform/efl/TestExpectations: Enabled http/tests/security/video-cross-origin-readback.html. * platform/gtk/TestExpectations: Ditto. * platform/mac/TestExpectations: Disabled http/tests/security/video-cross-origin-accessfailure.html. 2014-03-21 Oliver Hunt Fix semantics of JS execution when assigning an object to document.location https://bugs.webkit.org/show_bug.cgi?id=130213 Reviewed by Geoffrey Garen. * fast/dom/navigation-with-sideeffects-expected.txt: Added. * fast/dom/navigation-with-sideeffects.html: Added. 2014-03-19 Antti Koivisto Crash with long selector list https://bugs.webkit.org/show_bug.cgi?id=123006 Reviewed by Andreas Kling. * fast/css/long-selector-list-crash-expected.txt: Added. * fast/css/long-selector-list-crash.html: Added. 2014-03-18 Antti Koivisto Mutating rules returned by getMatchedCSSRules can result in crash https://bugs.webkit.org/show_bug.cgi?id=130209 Reviewed by Andreas Kling. * fast/css/getMatchedCSSProperties-rule-mutation-expected.txt: Added. * fast/css/getMatchedCSSProperties-rule-mutation.html: Added. * fast/css/getMatchedCSSRules-crash-expected.txt: Added. * fast/css/getMatchedCSSRules-crash.html: Added. 2014-03-08 Oliver Hunt SerializedScriptValue may move Identifiers between worlds https://bugs.webkit.org/show_bug.cgi?id=129979 Reviewed by Andreas Kling. Add test cases * fast/workers/resources/worker-copy-shared-blob-url-worker.js: Added. (count.0.onmessage): * fast/workers/worker-copy-shared-blob-url-expected.txt: Added. * fast/workers/worker-copy-shared-blob-url.html: Added. 2014-03-05 David Kilzer Fix crash in CompositeEditCommand::cloneParagraphUnderNewElement() Reviewed by Jon Honeycutt. Merged from Blink (patch by Yuta Kitamura): https://src.chromium.org/viewvc/blink?revision=168160&view=revision http://crbug.com/345005 The root cause is CompositeEditCommand::moveParagraphWithClones() passing two positions |start| and |end| which do not follow the document order, i.e. in some situations |start| is located after |end| because of the difference in affinity. This patch fixes this crash by normalizing |end| to |start| in such situations. It also adds an ASSERT that checks the relationship between |start| and |end|. * editing/execCommand/format-block-crash-expected.txt: Added. * editing/execCommand/format-block-crash.html: Added. * editing/execCommand/resources/format-block-crash-iframe.html: Added. 2014-03-01 David Kilzer Ensure keySplines is valid in SMIL animations Reviewed by Darin Adler. Merged from Blink (patch by Philip Rogers): https://src.chromium.org/viewvc/blink?revision=156452&view=revision http://crbug.com/276111 This patch fixes a crash in SMIL animations when keySplines are not specified. The SMIL spec is clear on this: http://www.w3.org/TR/2001/REC-smil-animation-20010904/#AnimFuncCalcMode "If there are any errors in the keyTimes specification (bad values, too many or too few values), the animation will have no effect." This patch simply checks that keyTimes is not empty. Previously, splinesCount was set to be m_keySplines.size() + 1 in SVGAnimationElement.cpp; this patch changes splinesCount to be equal to m_keySplines.size() to make the logic easier to follow and to match other checks in SVGAnimationElement::startedActiveInterval. * svg/animations/animate-keysplines-crash-expected.txt: Added. * svg/animations/animate-keysplines-crash.html: Added. 2014-02-19 Daniel Bates Do not dispatch change event twice in single step action https://bugs.webkit.org/show_bug.cgi?id=116936 Reviewed by Ryosuke Niwa. Merged from Blink (patch by Kent Tamura): https://src.chromium.org/viewvc/blink?view=rev&revision=151175 * fast/forms/number/number-type-update-by-change-event-expected.txt: Added. * fast/forms/number/number-type-update-by-change-event.html: Added. 2014-02-17 Chris Fleizach AX: Invalid cast in WebCore::AccessibilityTable::isDataTable (CRBug 280352) Merged from Blink (patch by Dominic Mazzoni): https://src.chromium.org/viewvc/blink?revision=159711&view=revision Reviewed by Oliver Hunt. * accessibility/display-table-cell-causes-crash-expected.txt: Added. * accessibility/display-table-cell-causes-crash.html: Added. 2014-02-16 Andreas Kling Ensure that removing an iframe from the DOM tree disconnects its Frame. Merged from Blink (patch by Adam Klein): https://src.chromium.org/viewvc/blink?revision=156174&view=revision * fast/frames/reattach-in-unload-expected.txt: Added. * fast/frames/reattach-in-unload.html: Added. 2014-02-15 Renata Hodovan ASSERT_WITH_SECURITY_IMPLICATION in WebCore::toElement https://bugs.webkit.org/show_bug.cgi?id=128810 Reviewed by Ryosuke Niwa. * editing/execCommand/indent-with-uneditable-crash-expected.txt: Added. * editing/execCommand/indent-with-uneditable-crash.html: Added. 2014-02-06 Jeffrey Pfau loadSubframe can return null in SubframeLoader::loadOrRedirectSubframe https://bugs.webkit.org/show_bug.cgi?id=128344 Reviewed by Ryosuke Niwa. * TestExpectations: Unskipped tests that were previously crashing 2014-02-04 Jeffrey Pfau Make adoption agency use the task queue https://bugs.webkit.org/show_bug.cgi?id=109445 Reviewed by Ryosuke Niwa. * TestExpectations: * fast/parser/adoption-agency-crash-01-expected.txt: Added. * fast/parser/adoption-agency-crash-01.html: Added. * fast/parser/adoption-agency-crash-02-expected.txt: Added. * fast/parser/adoption-agency-crash-02.html: Added. * fast/parser/adoption-agency-crash-03-expected.txt: Added. * fast/parser/adoption-agency-crash-03.html: Added. 2014-02-04 Myles C. Maxfield Move characterAt index checks from InlineIterator to RenderText https://bugs.webkit.org/show_bug.cgi?id=128224 Move characterAt index checks from InlineIterator to RenderText so that all RenderText calls are covered. Few safe instances are now covered with uncheckedCharacterAt. Merged from Blink: http://src.chromium.org/viewvc/blink?view=revision&revision=150830 Reviewed by Simon Fraser. * fast/text/character-at-crash-expected.txt: Added. * fast/text/character-at-crash.html: Added. 2014-04-12 Youenn Fablet [SOUP] Libsoup internal credential setting should be controlled by loader decision https://bugs.webkit.org/show_bug.cgi?id=130963 Reviewed by Darin Adler. * platform/efl/TestExpectations: Unskipped http/tests/xmlhttprequest/cross-origin-no-authorization.html. * platform/gtk/TestExpectations: Ditto. 2014-04-08 Youenn Fablet [SOUP] Control cookie management according ResourceRequest.allowCookies() https://bugs.webkit.org/show_bug.cgi?id=131026 Reviewed by Sergio Villar Senin. * platform/efl/TestExpectations: Unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html. * platform/gtk/TestExpectations: Ditto. 2014-02-11 Piotr Grad [GStreamer] High playback rate causes crash https://bugs.webkit.org/show_bug.cgi?id=128453 Reviewed by Philippe Normand. Test checks if passing high playback rate causes crash. * media/video-extreme-playbackrate-crash-expected.txt: Added. * media/video-extreme-playbackrate-crash.html: Added. 2014-02-09 Carlos Garnacho [GTK] Enable touch features https://bugs.webkit.org/show_bug.cgi?id=98931 Reviewed by Carlos Garcia Campos. * platform/gtk/TestExpectations: remove fast/events/touch * platform/gtk-wk2/TestExpectations: Add new expectations on fast/events/touch events. 2014-02-03 Radu Stavila REGRESSION (r163018): Can’t scroll in https://bugs.webkit.org/show_bug.cgi?id=127640 Reviewed by Simon Fraser.