2016-03-02 Alejandro G. Castro Unreviewed build fix for media-stream after r197114. * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): 2016-03-01 Csaba Osztrogonác Disable FTL JIT testing on 32-bit JSC tester bots https://bugs.webkit.org/show_bug.cgi?id=154858 Reviewed by Saam Barati. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (Run32bitJSCTests): 2016-03-01 Dean Johnson Fix iOS EWS. https://bugs.webkit.org/show_bug.cgi?id=154880 Reviewed by Alexey Proskuryakov. * Scripts/copy-webkitlibraries-to-product-directory: 2016-02-29 Chris Dumez Have parseHTMLInteger() / parseHTMLNonNegativeInteger() use WTF::Optional https://bugs.webkit.org/show_bug.cgi?id=154845 Reviewed by Ryosuke Niwa. Update API tests accordingly. * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: (TestWebKitAPI::testParseHTMLInteger): (TestWebKitAPI::parseHTMLIntegerFails): (TestWebKitAPI::testParseHTMLNonNegativeInteger): (TestWebKitAPI::parseHTMLNonNegativeIntegerFails): (TestWebKitAPI::TEST): Deleted. 2016-02-29 Simon Fraser Remove the experimental feature of antialiased font dilation https://bugs.webkit.org/show_bug.cgi?id=154843 Reviewed by Zalan Bujtas. Remove the "antialiased font dilation" code path, and related prefs. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Deleted. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): Deleted. 2016-02-29 Brady Eidson Fix timing flakiness in test I added in http://trac.webkit.org/changeset/197372 Unreviewed. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: (TEST): Sometimes a third message from the first html file was leaking through. The message is expected so we should always wait for it and make sure we got it. 2016-02-29 Brady Eidson Modern IDB: WebKit 2 IPC layer easily confused about multiple web processes being connected. https://bugs.webkit.org/show_bug.cgi?id=154837 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Added. 2016-02-29 Joanmarie Diggs [GTK][jhbuild] GLib build fails with GCC 6.0 https://bugs.webkit.org/show_bug.cgi?id=154825 Use the upstream work-around. https://bugzilla.gnome.org/show_bug.cgi?id=761550 Reviewed by Csaba Osztrogonác. * gtk/jhbuild.modules: Apply upstream path. * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Added. 2016-02-29 Filip Pizlo We've been running Octane/regexp all wrong in run-jsc-benchmarks https://bugs.webkit.org/show_bug.cgi?id=154827 Reviewed by Andreas Kling. Octane v.2 and JetStream v.1.1 run this benchmark with warmup. This script was running it without warmup. This patches fixes this by making this script run it with warmup. This fix shows that my last patch, which added FTL support for regexp, was actually a 3% speed-up on Octane/regexp, not a slow-down as the ChangeLog claimed. It discovered this bug because for each Octane test that I want to debug, I usually make a standalone .js file that contains the whole test along with a miniharness - usually a plain loop - that runs it almost like it would for real but with whatever hacks I'm using for debugging. When I wrote such a thing for regexp, I used a ~20 iteration warmup to match the one second of warmup that this benchmark gets in Octane. To my surprise, this quite faithful regexp runner did not see the regression that run-jsc-benchmarks saw. That's when I found out that run-jsc-benchmarks was running it wrong. The reason for the no-warmup slow-down is that the FTL is actually fairly expensive to run on some of these very large functions in the regexp benchmark. I don't think we can do anything about that, and I'd argue that the speed-up we see after the compilation is done suggests that it was worth it. * Scripts/run-jsc-benchmarks: 2016-02-29 Gavin Barraclough RefCounter::Event -> RefCounterEvent https://bugs.webkit.org/show_bug.cgi?id=154767 Reviewed by Darin Adler. RefCounter::Event is kinda verbose to use, and there is no need for this to be specific to a particular typeof RefCounter. Move the enum class up to the top level & rename to RefCounterEvent. * TestWebKitAPI/Tests/WTF/RefCounter.cpp: (TestWebKitAPI::TEST): 2016-02-29 Csaba Osztrogonác Remove more LLVM related cruft https://bugs.webkit.org/show_bug.cgi?id=154821 Reviewed by Darin Adler. * Scripts/build-jsc: * Scripts/build-webkit: * Scripts/copy-webkitlibraries-to-product-directory: * Scripts/export-llvm-build: Removed. * Scripts/run-jsc-stress-tests: 2016-02-28 Sam Weinig Reimplement WKPageGroup in terms of WKUserContentController https://bugs.webkit.org/show_bug.cgi?id=154804 Reviewed by Dan Bernstein. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Added. 2016-02-28 Sam Weinig Bind _WKUserStyleSheets to WKUserContentWorlds to allow for grouping of user content by associating to a world https://bugs.webkit.org/show_bug.cgi?id=154798 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Add tests for removing _WKUserStyleSheets and WKUserScripts 2016-02-27 Alexey Proskuryakov Silence leaks under TextCodecICU::registerCodecs https://bugs.webkit.org/show_bug.cgi?id=154737 Reviewed by Darin Adler. * Scripts/webkitpy/port/leakdetector.py: (LeakDetector._callstacks_to_exclude_from_leaks): 2016-02-26 Michael Catanzaro [GTK] Fix incorrect cast Unreviewed. * MiniBrowser/gtk/main.c: (createBrowserWindow): 2016-02-26 Chris Dumez Fix the behavior of reflecting IDL attributes of type unsigned long https://bugs.webkit.org/show_bug.cgi?id=154771 Reviewed by Ryosuke Niwa. Update API tests to cover the fixes to the parseHTMLNonNegativeInteger() implementation: - "-0" is parsed as 0. - Range boundaries are now [0; 2147483647]. * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: (TestWebKitAPI::TEST): 2016-02-26 Brady Eidson Modern IDB: New database versions are never committed to SQLite. and https://bugs.webkit.org/show_bug.cgi?id=154741 Modern IDB: If a database handle is not open, files are not actually deleted from disk https://bugs.webkit.org/show_bug.cgi?id=154756 Reviewed by Alex Christensen. This also happens to test the previously untested fix for http://trac.webkit.org/changeset/197190 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Added. (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): (-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]): (TEST): 2016-02-26 Commit Queue Unreviewed, rolling out r197216. https://bugs.webkit.org/show_bug.cgi?id=154766 Test simply needs updated result (Requested by litherum on #webkit). Reverted changeset: "Unreviewed, rolling out r197158." https://bugs.webkit.org/show_bug.cgi?id=154758 http://trac.webkit.org/changeset/197216 2016-02-26 Alexey Proskuryakov [iOS Simulator] Reftests don't work https://bugs.webkit.org/show_bug.cgi?id=154764 Reviewed by Daniel Bates. * Scripts/webkitpy/port/image_diff.py: (IOSSimulatorImageDiffer._start): Use simctl instead of sim. 2016-02-26 Chris Dumez Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger https://bugs.webkit.org/show_bug.cgi?id=154714 Reviewed by Darin Adler. Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per: - https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers - https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/PlatformWin.cmake: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: Added. (TestWebKitAPI::testParseHTMLInteger): (TestWebKitAPI::parseHTMLIntegerFails): (TestWebKitAPI::TEST): (TestWebKitAPI::testParseHTMLNonNegativeInteger): (TestWebKitAPI::parseHTMLNonNegativeIntegerFails): 2016-02-26 Commit Queue Unreviewed, rolling out r197158. https://bugs.webkit.org/show_bug.cgi?id=154758 This change did not fix the failing test (Requested by ryanhaddad on #webkit). Reverted changeset: "REGRESSION(r195795): [WK2] fast/text/crash-complex-text- surrogate.html is flakey" https://bugs.webkit.org/show_bug.cgi?id=154709 http://trac.webkit.org/changeset/197158 2016-02-26 Anders Carlsson WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data https://bugs.webkit.org/show_bug.cgi?id=154750 rdar://problem/23861395 Reviewed by Tim Horton. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetchWebsiteData:]): Use the new WKWebsiteDataStore SPI to compute data sizes. 2016-02-25 Gavin Barraclough RefCounter value changed callback should be called on all changes (not just zero edge). https://bugs.webkit.org/show_bug.cgi?id=154699 Reviewed by Geoff Garen. RefCounter currently only triggers a callback when the count goes from zero to non-zero and vice-versa. Change that, to be useful to more clients. * TestWebKitAPI/Tests/WTF/RefCounter.cpp: (TestWebKitAPI::TEST): - Updated for change in RefCounter callback siganture & behaviour. 2016-02-25 Sam Weinig Allow WKUserScripts to be run in isolated worlds https://bugs.webkit.org/show_bug.cgi?id=154701 Reviewed by Anders Carlsson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorld.mm: Added. (-[SimpleDelegate webView:didFinishNavigation:]): (-[UserContentWorldRemoteObject didObserveNormalWorld]): (-[UserContentWorldRemoteObject didObserveWorldWithName:]): * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldPlugIn.mm: Added. (-[_WKUserContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]): (-[_WKUserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]): * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldProtocol.h: Added. 2016-02-26 Youenn Fablet W3C test importer should have an option to clean the destination directory https://bugs.webkit.org/show_bug.cgi?id=152685 Reviewed by Darin Adler. Adding --clean-dest-dir option to W3C test importer. When this option is set, all files in the destination directory will be deleted except for WebKit specific files (test expectations, .gitignore...) before new tests import. Dangling test expectations are removed after tests import.' Adding unit test and minor refactoring for the other tests. * Scripts/webkitpy/w3c/test_importer.py: (parse_args): Add '--clean-dest-dir' option. (TestImporter.do_import): (TestImporter._is_baseline): helper routine to capture -expected.txt files. (TestImporter): (TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing. (TestImporter.clean_destination_directory): (TestImporter.remove_dangling_expectations): * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest._parse_options): (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): (TestImporterTest.test_import_dir_with_no_tests): (TestImporterTest.test_import_dir_with_empty_init_py): (test_clean_directory_option): 2016-02-25 Myles C. Maxfield REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey https://bugs.webkit.org/show_bug.cgi?id=154709 Reviewed by Dan Bernstein. Force auto-activation rules to a consistent state. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): 2016-02-25 Jiewen Tan Unreivewed build fix for r197150. * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: 2016-02-25 Jiewen Tan Restrict information passed with navigation action which is triggered by untrusted event https://bugs.webkit.org/show_bug.cgi?id=154571 Reviewed by Andy Estes. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: Added. (-[WKNavigationActionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): (TestWebKitAPI::TEST): (-[NavigationActionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.html: Added. 2016-02-25 Gavin Barraclough Should template RefCounter instead of RefCounter::Token https://bugs.webkit.org/show_bug.cgi?id=154691 Reviewed by Anders Carlsson. Mechanical update per RefCounter interface change. * TestWebKitAPI/Tests/WTF/RefCounter.cpp: (TestWebKitAPI::TEST): 2016-02-25 Skachkov Aleksandr Unreviewed: Add Aleksandr Skachkov as a commiter * Scripts/webkitpy/common/config/contributors.json: 2016-02-25 Sam Weinig HashMap::ensure() should return an AddResult like all the other add-like functions https://bugs.webkit.org/show_bug.cgi?id=154680 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): Update tests to use/test the new AddResult result. 2016-02-25 Alexey Proskuryakov Enable MallocScribble when detecting leaks https://bugs.webkit.org/show_bug.cgi?id=154679 Reviewed by Geoffrey Garen. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_environ_for_server): * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server): * Scripts/webkitpy/port/mac_unittest.py: (MacTest.test_setup_environ_for_server): 2016-02-25 Eric Carlson Unreviewed, fix iOS builds after r197114. * WebKitTestRunner/TestController.cpp: (WTR::createCanonicalUUIDString): (WTR::TestController::saltForOrigin): 2016-02-25 Eric Carlson [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin https://bugs.webkit.org/show_bug.cgi?id=153163 Reviewed by Tim Horton. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Take top level document origin. * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setUserMediaPermissionForOrigin): Ditto. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::decidePolicyForUserMediaPermissionRequest): Pass through top level document origin. (WTR::checkUserMediaPermissionForOrigin): Ditto. (WTR::TestController::resetStateToConsistentValues): m_userMediaOriginPermissions -> m_cahcedUserMediaPermissions. (WTR::originUserVisibleName): Return a String. (WTR::userMediaOriginHash): Create a hash of the origin plus top level document origin. (WTR::TestController::saltForOrigin): Return salt for an origin. (WTR::TestController::setUserMediaPermissionForOrigin): Return permission for an origin. (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): (WTR::TestController::handleUserMediaPermissionRequest): (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): (WTR::OriginSettings::OriginSettings): New, class to cache settings for an origin. (WTR::OriginSettings::persistentPermission): Persistent permissions for origin. (WTR::OriginSettings::setPersistentPermission): Set permissions for origin. (WTR::OriginSettings::persistentSalt): Return the persistent salt for the origin, if any. (WTR::OriginSettings::setPersistentSalt): Set the persistent salt for the origin (WTR::OriginSettings::ephemeralSalts): Return hashmap used to store per-frame salts. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2016-02-24 Nikos Andronikos [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface https://bugs.webkit.org/show_bug.cgi?id=151688 Reviewed by Dean Jackson. Enables the WEB_ANIMATIONS compiler switch by default. * Scripts/webkitperl/FeatureList.pm: 2016-02-24 Youenn Fablet W3C importer should generate all web-platform-tests submodules descriptions https://bugs.webkit.org/show_bug.cgi?id=154587 Reviewed by Darin Adler. Updated submodules description format (removing submodule name as it is the last string of the path really). Added git subroutines. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.origin_url): (Git): (Git.init_submodules): (Git.submodules_status): (Git.deinit_submodules): * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._install_modules): Updated to submodule name removal. * Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit). * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.test_submodules_generation): Reactivated partially this test. 2016-02-23 Dan Bernstein [Xcode] Linker errors display mangled names, but no longer should https://bugs.webkit.org/show_bug.cgi?id=154632 Reviewed by Sam Weinig. * ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES. * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto. * LayoutTestRelay/Configurations/Base.xcconfig: Ditto. * MiniBrowser/Configurations/Base.xcconfig: Ditto. * TestWebKitAPI/Configurations/Base.xcconfig: Ditto. * WebEditingTester/Configurations/Base.xcconfig: Ditto. * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. 2016-02-23 Anders Carlsson WKWebView should implement NSCoding https://bugs.webkit.org/show_bug.cgi?id=137160 Reviewed by Dan Bernstein. Add tests. * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (TEST): 2016-02-23 Anders Carlsson WKProcessPool should conform to NSCoding https://bugs.webkit.org/show_bug.cgi?id=154608 Reviewed by Sam Weinig. Add tests. * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (TEST): 2016-02-23 Anders Carlsson WKWebsiteDataStore should conform to NSCoding https://bugs.webkit.org/show_bug.cgi?id=154605 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (TEST): 2016-02-23 Anders Carlsson WKWebViewConfiguration should conform to NSCoding https://bugs.webkit.org/show_bug.cgi?id=154602 Reviewed by Beth Dakin. * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (TEST): 2016-02-23 Anders Carlsson WKPreferences should conform to NSCoding https://bugs.webkit.org/show_bug.cgi?id=154597 Reviewed by Sam Weinig. Test encoding and decoding WKPreferences. * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (encodeAndDecode): (TEST): 2016-02-23 Anders Carlsson Fix build. * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): 2016-02-23 Carlos Alberto Lopez Perez [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script. https://bugs.webkit.org/show_bug.cgi?id=153993 Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/main.c: (createBrowserWindow): Support --geometry argument for MiniBrowser. We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized. * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Fix loading of subclasses: The base class has to be loaded first, otherwise any subclase referencing it will give import error. In OSX the ordering of os.listdir() causes the base class (browser_driver.py) to be first on the list, but not on Linux. By specifiying the name of the base class file, we ensure it is always loaded first on any system despite the ordering of listdir. * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: (BrowserDriverFactory.create): * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py: Added. (GTKBrowserDriver): (GTKBrowserDriver.prepare_env): (GTKBrowserDriver.restore_env): (GTKBrowserDriver.close_browsers): (GTKBrowserDriver._launch_process): (GTKBrowserDriver._terminate_processes): (GTKBrowserDriver._screen_size): * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Added. (GTKMiniBrowserDriver): (GTKMiniBrowserDriver.prepare_env): (GTKMiniBrowserDriver.launch_url): (GTKMiniBrowserDriver.close_browsers): * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Fix loading of subclasses. See description above. * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: (SimpleHTTPServerDriver): (SimpleHTTPServerDriver.kill_server): Check if the server is still running before trying to terminate it. Usually the server ends gracefully (no need to terminate it), so this was causing ugly errors on the log. * Scripts/webkitpy/benchmark_runner/utils.py: Fix loading of subclasses. See description above. (load_subclasses): 2016-02-23 Alejandro G. Castro [GTK] Missing configuration patch for openh264 compilation https://bugs.webkit.org/show_bug.cgi?id=154455 This patch is required for the openh264 compilation with the jhbuild-webrtc.modules. The code was implemented by Alessandro Decina. Reviewed by Philippe Normand. * gtk/patches/openh264-configure.patch: Added. 2016-02-20 Olivier Blin [cmake] Use ICU include dirs in WebKit2 and WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=154479 Reviewed by Michael Catanzaro. * WebKitTestRunner/CMakeLists.txt: 2016-02-19 Konstantin Tokarev [GTK] Fixed link error when G_DEFINE_AUTOPTR_CLEANUP_FUNC is not defined. https://bugs.webkit.org/show_bug.cgi?id=154467 Reviewed by Michael Catanzaro. * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: (beforeAll): (afterAll): 2016-02-19 Brady Eidson Add "databaseProcessDidCrash" to the WKContextClient; Adopt it in WKTR. https://bugs.webkit.org/show_bug.cgi?id=154428 Reviewed by Jer Noble. * WebKitTestRunner/TestController.cpp: (WTR::TestController::generatePageConfiguration): (WTR::TestController::databaseProcessName): (WTR::TestController::databaseProcessDidCrash): * WebKitTestRunner/TestController.h: 2016-02-18 Philippe Normand [GStreamer] Bump internal jhbuild versions to 1.6.3 https://bugs.webkit.org/show_bug.cgi?id=149594 Reviewed by Michael Catanzaro. * gtk/jhbuild.modules: Bump to GStreamer 1.6.3. * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed. * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed. * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed. 2016-02-18 Brent Fulgham Extend HashCountedSet with a method to efficiently set the count of an entry https://bugs.webkit.org/show_bug.cgi?id=154352 Reviewed by Geoffrey Garen. * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto. * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added. 2016-02-18 Commit Queue Unreviewed, rolling out r196791. https://bugs.webkit.org/show_bug.cgi?id=154438 broke windows build (Requested by alexchristensen on #webkit). Reverted changeset: "Extend HashCountedSet with a method to efficiently set the count of an entry" https://bugs.webkit.org/show_bug.cgi?id=154352 http://trac.webkit.org/changeset/196791 2016-02-18 Brent Fulgham Extend HashCountedSet with a method to efficiently set the count of an entry https://bugs.webkit.org/show_bug.cgi?id=154352 Reviewed by Geoffrey Garen. * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto. * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added. 2016-02-18 Anders Carlsson Get rid of the --target-web-process and --use-web-process-xpc-service options. Rubber-stamped by Dan Bernstein. We now always use XPC, and --target-web-process is no longer supported. * Scripts/webkitdirs.pm: (execMacWebKitAppForDebugging): (shouldTargetWebProcess): Deleted. (determineShouldTargetWebProcess): Deleted. (shouldUseXPCServiceForWebProcess): Deleted. (determineShouldUseXPCServiceForWebProcess): Deleted. (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Deleted. (argumentsForRunAndDebugMacWebKitApp): Deleted. 2016-02-18 Ryan Haddad Skip API test WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on ios-simulator https://bugs.webkit.org/show_bug.cgi?id=153997 Reviewed by Filip Pizlo. * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: 2016-02-18 Jer Noble run-webkit-httpd should use webkitpy to run httpd. https://bugs.webkit.org/show_bug.cgi?id=154271 Reviewed by Alexey Proskuryakov. Update run-webkit-httpd to use webkitpy.port to launch httpd. Pass on http_port and http_all_interface options to match the current run-webkit-httpd (optional) behavior. * Scripts/run-webkit-httpd: (parse_args): (main): * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): * Scripts/webkitpy/layout_tests/servers/http_server.py: (Lighttpd._prepare_config): * Scripts/webkitpy/port/base.py: (Port.to.start_http_server): 2016-02-18 Filip Pizlo Remove remaining references to LLVM, and make sure comments refer to the backend as "B3" not "LLVM" https://bugs.webkit.org/show_bug.cgi?id=154383 Reviewed by Saam Barati. * Scripts/run-jsc-stress-tests: 2016-02-17 Filip Pizlo Remove LLVM dependencies from WebKit https://bugs.webkit.org/show_bug.cgi?id=154323 Reviewed by Antti Koivisto and Benjamin Poulain. * Scripts/copy-webkitlibraries-to-product-directory: (isContentOfFileEqualToString): (fileContains): Deleted. (buildLLVM): Deleted. (symlinkLLVMLibrariesIfNeeded): Deleted. 2016-02-16 Sam Weinig Add an ensure function on HashMap that takes a key and a function to make the lazy value initialization idiom easier https://bugs.webkit.org/show_bug.cgi?id=134857 Reviewed by Geoffrey Garen. * TestWebKitAPI/Tests/WTF/HashMap.cpp: Add tests for HashMap::ensure. 2016-02-17 Nan Wang AX: Implement sentence related text marker functions using TextIterator https://bugs.webkit.org/show_bug.cgi?id=154312 Reviewed by Chris Fleizach. * DumpRenderTree/AccessibilityUIElement.cpp: (nextParagraphEndTextMarkerForTextMarkerCallback): (sentenceTextMarkerRangeForTextMarkerCallback): (previousSentenceStartTextMarkerForTextMarkerCallback): (nextSentenceEndTextMarkerForTextMarkerCallback): (setSelectedVisibleTextRangeCallback): (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): (AccessibilityUIElement::supportedActions): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::mathPostscriptsDescription): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): (WTR::_convertMathMultiscriptPairsToString): 2016-02-15 Brent Fulgham [Mac] Gather some rudimentary statistics during resource load https://bugs.webkit.org/show_bug.cgi?id=153575 Reviewed by Brady Eidson. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): Add menu item for new debug flag. (-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added. (-[SettingsController resourceLoadStatisticsEnabled]): Added. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController didChangeSettings]): React to changes in users's desire to track resource load statistics. 2016-02-15 Csaba Osztrogonác [EFL] Update Tools/efl/install-dependencies https://bugs.webkit.org/show_bug.cgi?id=154239 Reviewed by Michael Catanzaro. * efl/install-dependencies: 2016-02-15 Alex Christensen Fix internal Windows build of projects built after WebKit https://bugs.webkit.org/show_bug.cgi?id=154249 rdar://problem/24644805 Reviewed by Chris Dumez. * DumpRenderTree/PlatformWin.cmake: * MiniBrowser/win/CMakeLists.txt: Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree more like projects built internally after WebKit. They should only need to use what is in ForwardingHeaders/WebKit. 2016-02-12 Nan Wang AX: Implement paragraph related text marker functions using TextIterator https://bugs.webkit.org/show_bug.cgi?id=154098 Reviewed by Chris Fleizach. * DumpRenderTree/AccessibilityUIElement.cpp: (nextWordEndTextMarkerForTextMarkerCallback): (paragraphTextMarkerRangeForTextMarkerCallback): (previousParagraphStartTextMarkerForTextMarkerCallback): (nextParagraphEndTextMarkerForTextMarkerCallback): (setSelectedVisibleTextRangeCallback): (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (AccessibilityUIElement::supportedActions): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::mathPostscriptsDescription): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): (WTR::_convertMathMultiscriptPairsToString): 2016-02-12 Jason Marcell Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions https://bugs.webkit.org/show_bug.cgi?id=154180 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal repository. 2016-02-12 Jer Noble [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession. https://bugs.webkit.org/show_bug.cgi?id=154136 Reviewed by Alex Christensen. Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession. Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES to GCC_PREPROCESSOR_DEFINES. * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp): (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown): (TestWebKitAPI::TEST_F): 2016-02-11 Dana Burkart Large logs can bring down the webkit master https://bugs.webkit.org/show_bug.cgi?id=122112 Reviewed by Lucas Forschler. Implement the suggested fix of throwing away stdout / stderr. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKit1LeakTests): 2016-02-10 Jason Marcell Remove calls to parseInt in order to work with non-integer revisions https://bugs.webkit.org/show_bug.cgi?id=153820 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer revisions. (BuildbotIteration.prototype._parseData): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue.prototype.update): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto. (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto. 2016-02-10 Jason Marcell Teach dashboard code to compare non-integer revisions https://bugs.webkit.org/show_bug.cgi?id=152345 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method. (BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto. (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer revisions. Also uses new Trac.nextRevision method to calculate a revision range. (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js: (Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new methods. (Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision. (Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range. (Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch. (Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array. (Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests. 2016-02-09 Nan Wang AX: Implement word related text marker functions using TextIterator https://bugs.webkit.org/show_bug.cgi?id=153939 Reviewed by Chris Fleizach. * DumpRenderTree/AccessibilityUIElement.cpp: (endTextMarkerCallback): (leftWordTextMarkerRangeForTextMarkerCallback): (rightWordTextMarkerRangeForTextMarkerCallback): (previousWordStartTextMarkerForTextMarkerCallback): (nextWordEndTextMarkerForTextMarkerCallback): (setSelectedVisibleTextRangeCallback): (AccessibilityUIElement::setSelectedVisibleTextRange): (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::setSelectedVisibleTextRange): (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::setSelectedVisibleTextRange): (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (AccessibilityUIElement::supportedActions): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::setBoolAttributeValue): (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::endTextMarker): (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (WTR::AccessibilityUIElement::mathPostscriptsDescription): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::endTextMarker): (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): (WTR::_convertMathMultiscriptPairsToString): 2016-02-09 Csaba Osztrogonác [EFL] Remove eail related cruft after r195725 https://bugs.webkit.org/show_bug.cgi?id=154030 Reviewed by Alex Christensen. * efl/jhbuildrc: 2016-02-09 Csaba Osztrogonác [EFL] Remove LLVM related cruft after r196077 https://bugs.webkit.org/show_bug.cgi?id=154031 Reviewed by Alex Christensen. * efl/jhbuild.modules: * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed. * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed. * efl/patches/llvm-version-arm64.patch: Removed. 2016-02-05 Aakash Jain tests fail if display sleeps while run-webkit-tests is running https://bugs.webkit.org/show_bug.cgi?id=153919 Reviewed by Alexey Proskuryakov. * DumpRenderTree/mac/LayoutTestHelper.m: (addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off. (releaseDisplaySleepAssertion): Release the DisplaySleep Assertion. (simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt. 2016-02-05 Alex Christensen Fix iOS API tests after r196082 https://bugs.webkit.org/show_bug.cgi?id=153900 Reviewed by Jer Noble. * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp): [WebView initialize] doesn't call JSC::initializeThreading on iOS. 2016-02-04 Jason Marcell The status message for passing combined builder queues should say "all builds succeeded" when expanded. https://bugs.webkit.org/show_bug.cgi?id=153882 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: (BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues when expanded. 2016-02-03 Filip Pizlo run-jsc-stress-tests should be better at telling you details about test failures https://bugs.webkit.org/show_bug.cgi?id=153845 Reviewed by Geoffrey Garen. Here's an example of the contents of results/resultsByFamily, one of the new files that this generates, for some local testing I'm doing. Notice how it groups families of tests together. You won't see this unless you cat results/resultsByFamily. regress.yaml/Regress/radar-24289839.js: regress.yaml/Regress/radar-24289839.js.default: PASS regress.yaml/Regress/radar-24289839.js.ftl: PASS regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL regress.yaml/Regress/radar-24290639.js: regress.yaml/Regress/radar-24290639.js.default: PASS regress.yaml/Regress/radar-24290639.js.ftl: PASS regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL regress.yaml/Regress/radar-24290670.js: FAILED * Scripts/run-jsc-stress-tests: 2016-02-03 Carlos Garcia Campos [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled https://bugs.webkit.org/show_bug.cgi?id=153835 Reviewed by Martin Robinson. WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when the context menu event is not handled, but we are using the returned value without null checking it. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::contextClick): 2016-02-03 Jason Marcell Format revisions for display according to repository type https://bugs.webkit.org/show_bug.cgi?id=153818 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according to repository type. (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto. (BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new _formatRevisionForDisplay function. 2016-02-03 Aakash Jain Logs/CoreSimulator filling up OS disk on WebKit testers https://bugs.webkit.org/show_bug.cgi?id=153853 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup. 2016-02-03 Brian Burg git-add-reviewer should work when run from a subdirectory within the repository https://bugs.webkit.org/show_bug.cgi?id=153842 Reviewed by David Kilzer. There are two problems that needed to be fixed: - We can't assume .git is in $PWD/.git - We can't specify absolute paths to `git commit` Fix these problems using the helpers in VCSUtils that were added to fix this same issue for prepare-changeCogs. * Scripts/VCSUtils.pm: Export gitDirectory() * Scripts/git-add-reviewer: (nonInteractive): Cache gitDirectory() result. (addReviewer): (commit): (changeLogsForCommit): Make paths relative. 2016-02-03 Jer Noble Yet another Yosemite build fix. * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: 2016-02-03 Jer Noble iOS build fix after Yosemite build fix broke iOS build. * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: 2016-02-03 Jer Noble Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior. * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: 2016-02-03 Joonghun Park [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well https://bugs.webkit.org/show_bug.cgi?id=153827 Reviewed by Michael Catanzaro. When an array is passed to subroutines as argument in perl, a list containing its element is returned from the array. Currently @$ arguments are being passed, then it is going to be one list including all the elements not only from @ but also from $. As a result, --cmakeargs option's value is included in @cmakeArgs at generateBuildSystemFromCMakeProject subroutine, so $additionalCMakeArgs doesn't needed anymore. * Scripts/webkitdirs.pm: (generateBuildSystemFromCMakeProject): 2016-02-03 Jer Noble [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks https://bugs.webkit.org/show_bug.cgi?id=153669 Reviewed by Alex Christensen. Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including calling appropriate NSURLSessionDelegate callbacks. Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI. Without this, the ENABLE macros in WebCore header files will not match the one used when compiling WebCore, leading to strange crashes and weird inconsistencies when calling, e.g., inline methods. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added. (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]): (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]): (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]): (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]): (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp): (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown): (TestWebKitAPI::TEST_F): 2016-02-03 Konstantin Tokarev [webkitdirs] Clarify logic behind is{PortName} functions. https://bugs.webkit.org/show_bug.cgi?id=153554 Reviewed by Michael Catanzaro. * Scripts/webkitdirs.pm: (prohibitUnknownPort): This function makes determinePortName() failure fatal. (determinePortName): Added new function which decides which port are we building based on command line switches and platform defaults. (portName): Added getter for determined $portName. (isEfl): Modified to use portName(). (isGtk): Ditto. (isWinCairo): Ditto. (isAppleMacWebKit): Ditto. (isAppleWinWebKit): Ditto. (isIOSWebKit): Ditto. (cmakeBasedPortName): Return portName() with capitalized first letter. (determineIsEfl): Deleted. (determineIsGtk): Deleted. (determineIsWinCairo): Deleted. * Scripts/build-jsc: Call prohibitUnknownPort(). * Scripts/run-minibrowser: Ditto. * Scripts/webkitperl/FeatureList.pm: Ditto. * Scripts/update-webkit: Call determinePortName() instead of determineIsWinCairo(). 2016-02-02 Dan Bernstein Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time) https://bugs.webkit.org/show_bug.cgi?id=153683 Reviewed by Darin Adler. * Scripts/webkitpy/port/driver.py: (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not used by any code in the Web Content process. If that ever changed, we should send it over as a bundle parameter. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013. * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server): Ditto. * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process environment. This is early enough that libxml2 has not been initialized yet. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): Ditto. 2016-02-02 Dan Bernstein Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time) https://bugs.webkit.org/show_bug.cgi?id=153683 Reviewed by Alexey Proskuryakov. Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well. * Scripts/webkitpy/port/driver.py: (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES. * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server): Ditto. 2016-01-29 Grzegorz Czajkowski [EFL] Virtual Keyboard overlaps MiniBrowser's WebView https://bugs.webkit.org/show_bug.cgi?id=153009 Reviewed by Gyuyoung Kim. On mobile, virtual keyboard represented by ecore_imf module appears on the top of application layer usually covering bottom part of the screen. If the web page contains the editable content on the bottom of the page it will be overlapped by keyboard which prevents user from seeing the typed text. Pack MiniBrowser layout into conformant widget to allow EFL to guess the space that will be required by the keyboard, finally resizing it to the desired size. As a result, webview gets resized and scrolled into focused elements which makes the editable elements visible while typing. More details about elm_conformant widger can be found at: https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html * MiniBrowser/efl/main.c: (window_create): pack a box into conformant widget. 2016-02-02 Alejandro G. Castro [GTK][EFL] Upgrade OpenWebRTC dependency https://bugs.webkit.org/show_bug.cgi?id=153489 Reviewed by Philippe Normand. * Scripts/run-gtk-tests: (TestRunner): Avoid running the mediastream API test. * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by default for gtk and efl. * gtk/jhbuild-webrtc.modules: Added modules files with dependencies required to compile and test the mediastream. 2016-02-01 Jason Marcell Add code to parse the git branches out of the Trac RSS feed https://bugs.webkit.org/show_bug.cgi?id=153624 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js: (Trac.prototype.commitsOnBranch): Update filter to check for Git branches. (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to "branches" and updated the code to work with an array instead of a string. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test fixture that contains XML with a Git branch. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant. 2016-02-01 Brady Eidson Add command line flag to DRT to output the number of tests completed in server mode. https://bugs.webkit.org/show_bug.cgi?id=153750 Reviewed by Darin Adler. * DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): (runTestingServerLoop): 2016-02-01 Jason Marcell Improvements to botwatcher's dashboard unit tests. https://bugs.webkit.org/show_bug.cgi?id=153621 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js: (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and _popoverLinesForCommitRange have to traverse commits from different branches. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for _revisionContentWithPopoverForIteration. 2016-02-01 Jason Marcell Refactor to add event listeners and start periodic updates for all trac instances. https://bugs.webkit.org/show_bug.cgi?id=153609 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView): Adding event listeners for all trac instances. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates for all trac instances. 2016-01-31 Darin Adler Replace CaseFoldingHash with ASCIICaseInsensitiveHash https://bugs.webkit.org/show_bug.cgi?id=153639 Reviewed by Filip Pizlo. * Scripts/do-webcore-rename: Use script to do this rename. 2016-01-30 Commit Queue Unreviewed, rolling out r195911. https://bugs.webkit.org/show_bug.cgi?id=153723 Caused frequent assertion failures on bots (Requested by ap on #webkit). Reverted changeset: "Replace CaseFoldingHash with ASCIICaseInsensitiveHash" https://bugs.webkit.org/show_bug.cgi?id=153639 http://trac.webkit.org/changeset/195911 2016-01-30 Darin Adler Replace CaseFoldingHash with ASCIICaseInsensitiveHash https://bugs.webkit.org/show_bug.cgi?id=153639 Reviewed by Filip Pizlo. * Scripts/do-webcore-rename: Use script to do this rename. 2016-01-30 Ryosuke Niwa TouchList should be retargeted https://bugs.webkit.org/show_bug.cgi?id=149592 Reviewed by Antti Koivisto. Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature. * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::touchDownAtPoint): Added. (WTR::UIScriptController::liftUpAtPoint): Added. * WebKitTestRunner/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/HIDEventGenerator.h: * WebKitTestRunner/ios/HIDEventGenerator.mm: (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits. (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up. * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::touchDownAtPoint): Added. (WTR::UIScriptController::liftUpAtPoint): Added. 2016-01-30 Yusuke Suzuki Enable SamplingProfiler on POSIX environment https://bugs.webkit.org/show_bug.cgi?id=153584 Reviewed by Michael Saboff. * Scripts/run-jsc-stress-tests: 2016-01-29 Nikos Andronikos update-webkit-dependency fails to fetch updates through firewall on Windows https://bugs.webkit.org/show_bug.cgi?id=153619 Reviewed by Myles C. Maxfield. On Windows, when a firewall is present we need to read proxy settings from environment variables. This patch relies on the following environment variables being set: HTTP_PROXY HTTPS_PROXY * Scripts/update-webkit-dependency: 2016-01-28 Dan Bernstein [Cocoa] Use the non-Development variants of XPC services for development https://bugs.webkit.org/show_bug.cgi?id=152545 Reviewed by Darin Adler. * Scripts/webkitdirs.pm: (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well. * Scripts/webkitpy/port/driver.py: (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are set in the XPC services as well. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and Guard Malloc are enabled in XPC services as well. * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server): Ditto. 2016-01-28 Csaba Osztrogonác Unreviewed buildfix after r195743. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::isPressActionSupported): 2016-01-12 Jer Noble Custom protocol loading through AVFoundation does not support byte-range requests. https://bugs.webkit.org/show_bug.cgi?id=152919 Reviewed by Alex Christensen. Add tests for new ParsedContntRange class. * TestWebKitAPI/PlatformWin.cmake: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added. (TestWebKitAPI::TEST): 2016-01-28 Konstantin Tokarev Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts. https://bugs.webkit.org/show_bug.cgi?id=153594 Reviewed by Alex Christensen. * Scripts/webkitdirs.pm: (determineNumberOfCPUs): (jscPath): (checkFrameworks): (setupCygwinEnv): (wrapperPrefixIfNeeded): (cmakeGeneratedBuildfile): (generateBuildSystemFromCMakeProject): * Scripts/webkitperl/features.pm: (libraryContainsSymbol): 2016-01-28 Chris Dumez Unreviewed, rolling out r195742. Broke EWS Reverted changeset: "[webkitdirs] Clarify logic behind is{PortName} functions." https://bugs.webkit.org/show_bug.cgi?id=153554 http://trac.webkit.org/changeset/195742 2016-01-28 Darin Adler Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase https://bugs.webkit.org/show_bug.cgi?id=153411 Reviewed by Ryosuke Niwa. * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we have removed the function instead. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we added overloads for const char*. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase. (WTR::AccessibilityUIElement::hasPopup): Ditto. * WebKitTestRunner/cocoa/CrashReporterInfo.mm: (WTR::testPathFromURL): Ditto. 2016-01-28 Konstantin Tokarev [webkitdirs] Clarify logic behind is{PortName} functions. https://bugs.webkit.org/show_bug.cgi?id=153554 Reviewed by Darin Adler. * Scripts/webkitdirs.pm: (determinePortName): Added new function which decides which port are we building based on command line switches and platform defaults. (portName): Added getter for determined $portName. (isEfl): Modified to use portName(). (isGtk): Ditto. (isWinCairo): Ditto. (isAppleMacWebKit): Ditto. (isAppleWinWebKit): Ditto. (isIOSWebKit): Ditto. (cmakeBasedPortName): Code replaced with portName() call. (determineIsEfl): Deleted. (determineIsGtk): Deleted. (determineIsWinCairo): Deleted. 2016-01-28 Konstantin Tokarev [webkitdirs] Don't pass cmakeBasedPortName around. https://bugs.webkit.org/show_bug.cgi?id=153589 Reviewed by Darin Adler. It should be local function of webkitdirs.pm instead. * Scripts/build-jsc: Don't pass cmakeBasedPortName to buildCMakeProjectOrExit(). * Scripts/build-webkit: Don't pass cmakeBasedPortName to buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject(). * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to generateBuildSystemFromCMakeProject(). * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName. (generateBuildSystemFromCMakeProject): Removed $port argument as we can get it from cmakeBasedPortName(). (buildCMakeProjectOrExit): Ditto. 2016-01-28 Gwang Yoon Hwang [GStreamer] Clean up includes and headers related with GStreamerGL https://bugs.webkit.org/show_bug.cgi?id=153590 Reviewed by Philippe Normand. * Scripts/webkitpy/style/checker.py: Skips include_order check for MediaPlayerPrivateGStreamerBase.cpp Removes VideoSinkGStreamer1.cpp which doesn't exist anymore. 2016-01-27 Krzysztof Czech [EFL] Remove unused accessibility related code https://bugs.webkit.org/show_bug.cgi?id=153543 Reviewed by Darin Adler. Removed reference to EAIL library. It not going to be support anymore. There have been changes in EFL/Elementary in terms of the accessibility and we should follow those. * efl/jhbuild-optional.modules: 2016-01-27 Daniel Bates Remove WebKitSystemInterface for iOS SDK < 9 https://bugs.webkit.org/show_bug.cgi?id=153570 Reviewed by Andy Estes. * Scripts/copy-webkitlibraries-to-product-directory: 2016-01-27 Jason Marcell Fix bugs caused by incorrect usage of "branch" vs. "branchName". https://bugs.webkit.org/show_bug.cgi?id=153330 Reviewed by Daniel Bates. In an earlier patch we started using the name "branch" to indicate a branch object, whereas "branchName" implies that the variable or property in question is simply a string. We fixed some inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently spotted in BuildbotQueueView.js. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature. Changed branchName to branch.name in call to commitsOnBranch. (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to _popoverLinesForCommitRange. (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name. (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify fix. 2016-01-27 Ryosuke Niwa Add API to access closed shadowRoot in InjectedBundle https://bugs.webkit.org/show_bug.cgi?id=153533 Reviewed by Antti Koivisto. Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added. (TestWebKitAPI::runJavaScriptAlert): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added. (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest): (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize): 2016-01-27 Jason Marcell Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes. https://bugs.webkit.org/show_bug.cgi?id=153332 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js: (Trac.prototype._xmlTimelineURL): Uses new function. (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added logic for parsing git hashes. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for Trac._parseRevisionFromURL. 2016-01-27 Alexey Proskuryakov Remove Mavericks from the flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=153521 Reviewed by Dan Bernstein. * TestResultServer/static-dashboards/builders.jsonp: * TestResultServer/static-dashboards/flakiness_dashboard.js: 2016-01-27 Alexey Proskuryakov Remove ENABLE_CURRENTSRC https://bugs.webkit.org/show_bug.cgi?id=153545 Reviewed by Simon Fraser. * Scripts/webkitperl/FeatureList.pm: 2016-01-26 Jason Marcell Sort incoming commits via date instead of revision number. https://bugs.webkit.org/show_bug.cgi?id=153467 Reviewed by Alexey Proskuryakov. Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number for sorting revisions. Instead we use the commit date to sort revisions chronologically. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js: (Trac.prototype._loaded): Sort via date instead of revision number. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: (MockTrac): Fix up the mock data to look more like real-world data. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added. Fake RSS feed that adds three more commits. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test Trac._loaded(). 2016-01-26 I-Ting Liu Add a test for WebKit::stringMatchesWildcardString. https://bugs.webkit.org/show_bug.cgi?id=153090 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add the file to the project. * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added. (TestWebKitAPI::TEST): Test that a string matches another string that may contain wildcard characters. 2016-01-26 Konstantin Tokarev [webkitdirs] Removed check for bison, gperf, and flex. https://bugs.webkit.org/show_bug.cgi?id=153496 Reviewed by Alex Christensen. This prerequisites are checked in WebKitCommon.cmake and don't have to be in $PATH. * Scripts/webkitdirs.pm: (checkRequiredSystemConfig): 2016-01-26 Konstantin Tokarev [webkitdirs] isCMakeBuild should be true by default https://bugs.webkit.org/show_bug.cgi?id=153497 Reviewed by Michael Catanzaro. * Scripts/webkitdirs.pm: (isCMakeBuild): 2016-01-26 Daniel Bates Add WebKitSystemInterface for iOS 9.2 https://bugs.webkit.org/show_bug.cgi?id=153355 Rubber-stamped by David Kilzer. * Scripts/copy-webkitlibraries-to-product-directory: 2016-01-26 Daniel Bates WebKitTestRunner: Credential cache is not cleared between tests https://bugs.webkit.org/show_bug.cgi?id=153407 Reviewed by Alexey Proskuryakov. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials() to clear cached credentials. 2016-01-26 Carlos Alberto Lopez Perez kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed. https://bugs.webkit.org/show_bug.cgi?id=153483 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/kill-old-processes: (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL 2016-01-25 Simon Fraser Give the layout test results file a showing the date and time the tests were run https://bugs.webkit.org/show_bug.cgi?id=153187 Reviewed by Darin Adler. Include a 'date' property in the JSON with the date and time the tests completed. * Scripts/webkitpy/layout_tests/models/test_run_results.py: (summarize_results): 2016-01-25 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r195543. https://bugs.webkit.org/show_bug.cgi?id=153451 regressed performance of test bots by ~6% (Requested by dydz on #webkit). Reverted changeset: "WebKitTestRunner: Credential cache is not cleared between tests" https://bugs.webkit.org/show_bug.cgi?id=153407 http://trac.webkit.org/changeset/195543 2016-01-25 Aakash Jain <aakash_jain@apple.com> Failing to upload to flakiness dashboard should not be a hard error https://bugs.webkit.org/show_bug.cgi?id=153444 <rdar://problem/22146294> Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._upload_json_files): If JSON file is not generated, do not try to upload it. 2016-01-25 Daniel Bates <dabates@apple.com> WebKitTestRunner: Credential cache is not cleared between tests https://bugs.webkit.org/show_bug.cgi?id=153407 <rdar://problem/24280834> Reviewed by Brady Eidson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Reset testing network session to clear cached credentials. 2016-01-24 Dan Bernstein <mitz@apple.com> Added project.xcworkspace and xcuserdata to this project’s svn:ignore. * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore. 2016-01-22 Enrica Casucci <enrica@apple.com> Unreviewed build fix after http://trac.webkit.org/changeset/195474. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): 2016-01-22 Tim Horton <timothy_horton@apple.com> Add a test for iOS arrow-key repeat https://bugs.webkit.org/show_bug.cgi?id=152857 <rdar://problem/24017380> Reviewed by Darin Adler. * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::keyUpUsingHardwareKeyboard): (WTR::UIScriptController::keyDownUsingHardwareKeyboard): * WebKitTestRunner/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/HIDEventGenerator.h: * WebKitTestRunner/ios/HIDEventGenerator.mm: (-[HIDEventGenerator keyPress:completionBlock:]): (-[HIDEventGenerator keyDown:completionBlock:]): (-[HIDEventGenerator keyUp:completionBlock:]): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard): (WTR::UIScriptController::keyDownUsingHardwareKeyboard): (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Make it possible to independently send keyUp/keyDown, instead of just paired. 2016-01-22 Tim Horton <timothy_horton@apple.com> Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends https://bugs.webkit.org/show_bug.cgi?id=153193 <rdar://problem/24222034> Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: (webViewForScriptMessageHandlerMultipleHandlerRemovalTest): (TEST): Add a test that exhibits the problems we're fixing here. Before, it would both log and assert in debug, and crash in release. Now it runs happily to completion. 2016-01-22 Enrica Casucci <enrica@apple.com> Add support for testing data detection. https://bugs.webkit.org/show_bug.cgi?id=153360 Reviewed by Tim Horton. Adding a new testing option (useDataDetection) to turn on data detection when running the a test. * WebKitTestRunner/TestController.cpp: (WTR::updateTestOptionsFromTestHeader): * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): 2016-01-21 Simon Fraser <simon.fraser@apple.com> Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator https://bugs.webkit.org/show_bug.cgi?id=153334 Reviewed by Zalan Bujtas. Evaluating expressions in the LayoutUnit summary provider seems to cause re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit denominator to 64. * lldb/lldb_webkit.py: (WebCoreLayoutUnitProvider.to_string): 2016-01-21 Filip Pizlo <fpizlo@apple.com> display-profiler-output should be able to display code blocks sorted by machine counts https://bugs.webkit.org/show_bug.cgi?id=153298 Reviewed by Oliver Hunt. * Scripts/display-profiler-output: 2016-01-21 Julien Isorce <j.isorce@samsung.com> Ensure to use compatible liborc version with wanted gstreamer version https://bugs.webkit.org/show_bug.cgi?id=153276 For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24. The user may have a very recent liborc installed on his system. Reviewed by Philippe Normand. * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency. * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy. 2016-01-21 Nan Wang <n_wang@apple.com> AX: [IOS] Implement next/previous text marker functions using TextIterator https://bugs.webkit.org/show_bug.cgi?id=153292 <rdar://problem/24268243> Reviewed by Chris Fleizach. Made text marker tests available on iOS. * DumpRenderTree/AccessibilityTextMarker.h: * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added. (AccessibilityTextMarker::AccessibilityTextMarker): (AccessibilityTextMarker::~AccessibilityTextMarker): (AccessibilityTextMarker::isEqual): (AccessibilityTextMarker::platformTextMarker): (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange): (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange): (AccessibilityTextMarkerRange::isEqual): (AccessibilityTextMarkerRange::platformTextMarkerRange): * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::pathDescription): (AccessibilityUIElement::lineTextMarkerRangeForTextMarker): (AccessibilityUIElement::textMarkerRangeForElement): (AccessibilityUIElement::selectedTextMarkerRange): (AccessibilityUIElement::resetSelectedTextMarkerRange): (AccessibilityUIElement::textMarkerRangeLength): (AccessibilityUIElement::textMarkerRangeForMarkers): (AccessibilityUIElement::startTextMarkerForTextMarkerRange): (AccessibilityUIElement::endTextMarkerForTextMarkerRange): (AccessibilityUIElement::accessibilityElementForTextMarker): (AccessibilityUIElement::endTextMarkerForBounds): (AccessibilityUIElement::startTextMarkerForBounds): (AccessibilityUIElement::textMarkerForPoint): (AccessibilityUIElement::previousTextMarker): (AccessibilityUIElement::nextTextMarker): (AccessibilityUIElement::stringForTextMarkerRange): (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): (AccessibilityUIElement::indexForTextMarker): (AccessibilityUIElement::isTextMarkerValid): (AccessibilityUIElement::textMarkerForIndex): (AccessibilityUIElement::startTextMarker): (AccessibilityUIElement::endTextMarker): (AccessibilityUIElement::setSelectedVisibleTextRange): (AccessibilityUIElement::getLinkedUIElements): * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: (AccessibilityTextMarkerRange::platformTextMarkerRange): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::removeSelection): (AccessibilityUIElement::lineTextMarkerRangeForTextMarker): (AccessibilityUIElement::setSelectedVisibleTextRange): (AccessibilityUIElement::supportedActions): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::textMarkerRangeForElement): (WTR::AccessibilityUIElement::textMarkerRangeLength): (WTR::AccessibilityUIElement::previousTextMarker): (WTR::AccessibilityUIElement::nextTextMarker): (WTR::AccessibilityUIElement::stringForTextMarkerRange): (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): (WTR::AccessibilityUIElement::endTextMarkerForBounds): (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): 2016-01-20 Filip Pizlo <fpizlo@apple.com> Unreviewed, revert accidental unreviewed commit. * Scripts/display-profiler-output: 2016-01-20 Jason Marcell <jmarcell@apple.com> Refactor compareIterations to remove duplicate code. https://bugs.webkit.org/show_bug.cgi?id=152913 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code. (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure the same behavior before and after refactor. 2016-01-20 Dana Burkart <dburkart@apple.com> Botwatcher's dashboard should show an 'X' when the build is broken https://bugs.webkit.org/show_bug.cgi?id=152507 Reviewed by David Kilzer. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus): (BuildbotStaticAnalyzerQueueView.prototype.update): 2016-01-19 Jason Marcell <jmarcell@apple.com> Remove assertion from revisionContentForIteration that is causing errors on the dashboard. https://bugs.webkit.org/show_bug.cgi?id=153262 Reviewed by Alexey Proskuryakov. Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In such cases this revisionContentForIteration method does not have any content to return, thus the assertion fails. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors. 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Runtime critical warnings when loading a URL after a session restore https://bugs.webkit.org/show_bug.cgi?id=153233 Reviewed by Michael Catanzaro. Add new test case. * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: (viewLoadChanged): (testWebKitWebViewNavigationAfterSessionRestore): (beforeAll): 2016-01-19 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] Remove jhbuild-optional.modules https://bugs.webkit.org/show_bug.cgi?id=152964 Reviewed by Alex Christensen. * gtk/jhbuild-optional.modules: Removed. * gtk/jhbuild.modules: 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add support to load/save session in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=153201 Reviewed by Michael Catanzaro. It makes it easier to test the new WebView session API. * MiniBrowser/gtk/BrowserWindow.c: (browserWindowFinalize): Free the session file path. (browserWindowSaveSession): Save the current WebView session if there's a session file path. (browserWindowDeleteEvent): Call browserWindowSaveSession(). (browser_window_load_session): Try to load the session from the given file path, otherwise fall back to homepage and keep the session file to save the session on window close. * MiniBrowser/gtk/BrowserWindow.h: * MiniBrowser/gtk/main.c: (createBrowserWindow): Pass the given session file path when shouldLoadSession is TRUE. (main): Only allow to restore/save session when MiniBrowser is launched without URL arguments. 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075. Geolocation is no longer allowed for unique origins after r195075. * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewGeolocationPermissionRequests): 2016-01-18 Carlos Alberto Lopez Perez <clopez@igalia.com> [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready. https://bugs.webkit.org/show_bug.cgi?id=153216 Reviewed by Michael Catanzaro. * Scripts/webkitpy/port/pulseaudio_sanitizer.py: (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor. 2016-01-18 Nan Wang <n_wang@apple.com> AX: [Mac] Implement next/previous text marker functions using TextIterator https://bugs.webkit.org/show_bug.cgi?id=152728 Reviewed by Chris Fleizach. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): 2016-01-18 Csaba Osztrogonác <ossy@webkit.org> [cmake] Add testair to the build system https://bugs.webkit.org/show_bug.cgi?id=153126 Reviewed by Michael Catanzaro. * Scripts/build-jsc: 2016-01-16 Myles C. Maxfield <mmaxfield@apple.com> Remove TextRun::allowsRoundingHacks() https://bugs.webkit.org/show_bug.cgi?id=153185 Reviewed by Simon Fraser. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Deleted. 2016-01-15 Konstantin Tokarev <annulen@yandex.ru> [webkitdirs] Avoid list form of open because it broke WinCairo https://bugs.webkit.org/show_bug.cgi?id=153106 Reviewed by Alex Christensen. * Scripts/webkitdirs.pm: (determineArchitecture): 2016-01-15 Simon Fraser <simon.fraser@apple.com> Add kdebug_trace signposts for a few WebCore operations https://bugs.webkit.org/show_bug.cgi?id=153136 rdar://problem/24208487 Reviewed by Sam Weinig. Plist used by kdebug_trace() viewing tools. * Tracing/SystemTracePoints.plist: Added. 2016-01-14 Konstantin Tokarev <annulen@yandex.ru> [webkitdirs] Replaced grep invocation with perl code https://bugs.webkit.org/show_bug.cgi?id=153106 Reviewed by Alex Christensen. * Scripts/webkitdirs.pm: (determineArchitecture): 2016-01-14 Brian Burg <bburg@apple.com> prepare-changelog does not read paths containing spaces properly https://bugs.webkit.org/show_bug.cgi?id=137982 Reviewed by Joseph Pecoraro. Escape whitespace in filenames before passing the file path to other functions. * Scripts/prepare-ChangeLog: (generateFunctionLists): Use the more explicit 3-argument form of 'open'. 2016-01-14 Jason Marcell <jmarcell@apple.com> Standardize the usage of "branch" vs. "branchName". https://bugs.webkit.org/show_bug.cgi?id=152982 Reviewed by Daniel Bates. In an earlier patch we started using the name "branch" to indicate a branch object, whereas "branchName" implies that the variable or property in question is simply a string. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName. (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name. (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js: (Trac.prototype.commitsOnBranch): Change branch to branchName. (Trac.prototype._convertCommitInfoElementToObject): Ditto. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: (MockTrac): Ditto. 2016-01-14 Jason Marcell <jmarcell@apple.com> Add a unit test to test BuildbotQueueView._appendPendingRevisionCount. https://bugs.webkit.org/show_bug.cgi?id=152910 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added. (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added. (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without the need to talk to a real Buildbot server. (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration without the need to talk to a real Buildbot server. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added. (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac server. (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision. (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto. (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time trying to talk to Trac. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for QUnit unit tests. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests. 2016-01-14 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja https://bugs.webkit.org/show_bug.cgi?id=132599 Reviewed by Michael Catanzaro. Check if cmake Ninja generators are installed. * Scripts/webkitdirs.pm: (canUseNinjaGenerator): (canUseEclipseNinjaGenerator): (generateBuildSystemFromCMakeProject): (canUseEclipse): Deleted. 2016-01-13 Myles C. Maxfield <mmaxfield@apple.com> [Cocoa] Testing with font family name "System Font" is unused https://bugs.webkit.org/show_bug.cgi?id=153073 <rdar://problem/24091683> Reviewed by Brent Fulgham. * DumpRenderTree/mac/DumpRenderTree.mm: (allowedFontFamilySet): Deleted. * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: (WTR::allowedFontFamilySet): Deleted. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::allowedFontFamilySet): Deleted. 2016-01-13 Daniel Bates <dabates@apple.com> [XSS Auditor] Add test when XSS payload is in the path portion of the URL https://bugs.webkit.org/show_bug.cgi?id=152871 Reviewed by Brent Fulgham. Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>): <https://src.chromium.org/viewvc/blink?revision=164746&view=revision> * Scripts/webkitpy/layout_tests/servers/lighttpd.conf: 2016-01-08 Andy Estes <aestes@apple.com> [Content Filtering] Lazily load platform frameworks https://bugs.webkit.org/show_bug.cgi?id=152881 rdar://problem/23270886 Reviewed by Brady Eidson. Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string, loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac is loaded after an HTTPS request. To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use. Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were also re-enabled on iOS after mistakenly being disabled by r188892. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: (TEST): (downloadTest): (-[LazilyLoadPlatformFrameworksController init]): (-[LazilyLoadPlatformFrameworksController webView]): (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]): (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]): * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]): (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]): * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: (TestWebKitAPI::TEST): Deleted. * TestWebKitAPI/cocoa/TestProtocol.h: * TestWebKitAPI/cocoa/TestProtocol.mm: (+[TestProtocol registerWithScheme:]): (+[TestProtocol unregister]): 2016-01-12 Dewei Zhu <dewei_zhu@apple.com> Fix the Sunpider converage in slow device. https://bugs.webkit.org/show_bug.cgi?id=152938 <rdar://problem/22511411> Reviewed by Ryosuke Niwa. Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests. * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: 2016-01-12 Ryosuke Niwa <rniwa@webkit.org> Add a build flag for custom element https://bugs.webkit.org/show_bug.cgi?id=153005 Reviewed by Alex Christensen. Added --custom-elements option to enable custom elements support. * Scripts/webkitperl/FeatureList.pm: 2016-01-12 Benjamin Poulain <bpoulain@apple.com> [JSC] Add a help message when run-jsc-stress-tests fails https://bugs.webkit.org/show_bug.cgi?id=153014 Reviewed by Csaba Osztrogonác. * Scripts/run-jsc-stress-tests: 2016-01-11 Saam barati <sbarati@apple.com> run-jsc-stress-tests should try to figure out a JSC path https://bugs.webkit.org/show_bug.cgi?id=152971 Reviewed by Yusuke Suzuki. This patch now allows run-jsc-stress-tests to be run without a "--jsc <jsc-path>" argument. It tries to take its best guess at a <jsc-path> automagically. This makes it much easier to just run run-jsc-stress-tests with a directory or a yaml file as an argument. You now just do this: `run-jsc-stress-tests <path-to-yaml>` or `run-jsc-stress-tests <path-to-directory-of-js-files>` I wrote this patch because I'd often find myself hacking the run-javascriptcore-tests file just to run a particular subset of tests. Because I always forget the arguments to run-jsc-stress-tests (which means I always forgot to provide a --jsc argument), I always found it easier to just hack on that file instead of calling run-jsc-stress-tests directly. No longer is this true! * Scripts/run-jsc-stress-tests: 2016-01-09 Andy Estes <aestes@apple.com> [Cocoa] Add SPI to opt out a URL scheme from the memory cache https://bugs.webkit.org/show_bug.cgi?id=152950 rdar://problem/24066652 Reviewed by Tim Horton. Added an API test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added. (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]): (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]): (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]): (-[AlwaysRevalidatedURLSchemeProtocol startLoading]): (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]): (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): (TEST): 2016-01-11 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r194866. https://bugs.webkit.org/show_bug.cgi?id=152986 This change broke the mac build (Requested by ryanhaddad on #webkit). Reverted changeset: "[Cocoa] Add SPI to opt out a URL scheme from the memory cache" https://bugs.webkit.org/show_bug.cgi?id=152950 http://trac.webkit.org/changeset/194866 2016-01-11 Andy Estes <aestes@apple.com> [Cocoa] Add SPI to opt out a URL scheme from the memory cache https://bugs.webkit.org/show_bug.cgi?id=152950 rdar://problem/24066652 Reviewed by Tim Horton. Added an API test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added. (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]): (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]): (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]): (-[AlwaysRevalidatedURLSchemeProtocol startLoading]): (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]): (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): (TEST): 2016-01-11 Konstantin Tokarev <annulen@yandex.ru> [webkitdirs] Use CMake to determine architecture on isCMakeBuild() https://bugs.webkit.org/show_bug.cgi?id=152959 Reviewed by Brent Fulgham. * Scripts/webkitdirs.pm: (determineArchitecture): 2016-01-11 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] W3C CSS2.1 anonymous table tests are failing https://bugs.webkit.org/show_bug.cgi?id=152455 Reviewed by Mario Sanchez Prada. Add shared-mime-info to the jhbuild environment, since it affects the results of layout tests. Add upstream patches to fix detection of XHTML files. * gtk/jhbuild.modules: * gtk/patches/shared-mime-info-xht-glob.patch: Added. * gtk/patches/shared-mime-info-xhtml-magic.patch: Added. 2016-01-10 Saam barati <sbarati@apple.com> Implement a sampling profiler https://bugs.webkit.org/show_bug.cgi?id=151713 Reviewed by Filip Pizlo. * Scripts/run-jsc-stress-tests: 2016-01-10 Konstantin Tokarev <annulen@yandex.ru> [webkitdirs] Try arch and uname commands on non-windows OS https://bugs.webkit.org/show_bug.cgi?id=152958 Reviewed by Michael Catanzaro. Right now, determineArchitecture() uses `arch` and `uname -m` commands to determine architecture in case of condition (isGtk() || isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows() instead, because this code is applicable to any non-windows OS WebKit supports (even Haiku which once was supported is moderately POSIX-compliant and has uname command). * Scripts/webkitdirs.pm: (determineArchitecture): 2016-01-08 Aakash Jain <aakash_jain@apple.com> run-webkit-tests mis-counts totals when there are other crashes https://bugs.webkit.org/show_bug.cgi?id=152894 <rdar://problem/24098697> Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/layout_tests/models/test_run_results.py: (TestRunResults.add): Do not update result counters for other crashes. 2016-01-08 Youenn Fablet <youenn.fablet@crf.canon.fr> webkit-patch build-and-test should have an option to iterate over new tests https://bugs.webkit.org/show_bug.cgi?id=143093 Reviewed by Michael Catanzaro. This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test. It allows running run-webkit-tests on modified or new paths in LayoutTests. Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests It implements the translation of -expected.* paths to their related tests. It also implements the removal of skipped tests. * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: (LayoutTestFinder.find_touched_tests): * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added. (MockPort): (MockPort.__init__): (MockPort.tests): (LayoutTestFinderTests): (LayoutTestFinderTests.touched_files): (LayoutTestFinderTests.test_touched_test): (LayoutTestFinderTests.test_expected_touched_test): (LayoutTestFinderTests.test_platform_expected_touched_test): (LayoutTestFinderTests.test_platform_duplicate_touched_test): (LayoutTestFinderTests.test_touched_but_skipped_test): * Scripts/webkitpy/port/base.py: (Port.potential_test_names_from_expected_file): * Scripts/webkitpy/tool/commands/download_unittest.py: (DownloadCommandsTest._default_options): * Scripts/webkitpy/tool/steps/options.py: (Options): * Scripts/webkitpy/tool/steps/runtests.py: (RunTests.options): (RunTests.run): (RunTests): (RunTests._new_or_modified_tests): (RunTests._run_webkit_tests): * Scripts/webkitpy/tool/steps/runtests_unittest.py: (RunTestsTest.test_webkit_run_unit_tests): * Scripts/webkitpy/tool/steps/steps_unittest.py: (StepsTest._step_options): 2016-01-07 Joseph Pecoraro <pecoraro@apple.com> prepare-ChangeLog should include radar number https://bugs.webkit.org/show_bug.cgi?id=152839 <rdar://problem/24093563> Reviewed by Daniel Bates. When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that starts with a "<rdar://problem/####>" URL. If found, include that radar URL in the ChangeLog description after the bug URL. * Scripts/prepare-ChangeLog: (main): Update signatures. (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data. (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>. (fetchRadarURLFromBugXMLData): Search comment text for radar URL. (generateNewChangeLogs): Include radar URL if we found one. * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added. Tests for the radar URL extraction. 2016-01-07 Alexey Proskuryakov <ap@apple.com> testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript https://bugs.webkit.org/show_bug.cgi?id=152390 <rdar://problem/23948321> Reviewed by Simon Fraser. Fix two use-after-frees. 1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation, but we may have already progressed to another test by the time the callback fires, having destroyed the TestInvocation. 2. UIScriptController is a RefCounted object, but it has a raw pointer to UIScriptContext which has the same lifetime as a TestInvocation. As a result, completion blocks of UIScriptController actions would use a destroyed TestInvocation. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::~TestInvocation): (WTR::TestInvocation::url): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): (WTR::TestInvocation::runUISideScriptAfterUpdateCallback): (WTR::TestInvocation::runUISideScript): * WebKitTestRunner/TestInvocation.h: * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: (UIScriptContext::UIScriptContext): (UIScriptContext::~UIScriptContext): (UIScriptContext::runUIScript): * WebKitTestRunner/UIScriptContext/UIScriptContext.h: * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::UIScriptController): (WTR::UIScriptController::contextDestroyed): (WTR::UIScriptController::makeWindowObject): (WTR::UIScriptController::setWillBeginZoomingCallback): (WTR::UIScriptController::willBeginZoomingCallback): (WTR::UIScriptController::setDidEndZoomingCallback): (WTR::UIScriptController::didEndZoomingCallback): (WTR::UIScriptController::setDidEndScrollingCallback): (WTR::UIScriptController::didEndScrollingCallback): (WTR::UIScriptController::setDidShowKeyboardCallback): (WTR::UIScriptController::didShowKeyboardCallback): (WTR::UIScriptController::setDidHideKeyboardCallback): (WTR::UIScriptController::didHideKeyboardCallback): (WTR::UIScriptController::uiScriptComplete): * WebKitTestRunner/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::create): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::doAsyncTask): (WTR::UIScriptController::zoomToScale): (WTR::UIScriptController::singleTapAtPoint): (WTR::UIScriptController::doubleTapAtPoint): (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard): (WTR::UIScriptController::contentVisibleRect): (WTR::UIScriptController::platformSetWillBeginZoomingCallback): (WTR::UIScriptController::platformSetDidEndZoomingCallback): (WTR::UIScriptController::platformSetDidShowKeyboardCallback): (WTR::UIScriptController::platformSetDidHideKeyboardCallback): (WTR::UIScriptController::platformSetDidEndScrollingCallback): * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::doAsyncTask): 2016-01-07 Youenn Fablet <youenn.fablet@crf.canon.fr> [buildbot] clean-build script should remove untracked files and revert local changes too https://bugs.webkit.org/show_bug.cgi?id=142400 Reviewed by Ryosuke Niwa. This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files. A helper routine SCM.discard_untracked_files is added for that purpose. * BuildSlaveSupport/clean-build: (main): Making call to Scripts/clean-webkit * Scripts/clean-webkit: Added. (main): Revert changes and delete untracked files. * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SCMTest._shared_test_discard_untracked_files): (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly. 2016-01-06 Simon Fraser <simon.fraser@apple.com> Add a setting and preferences to enable display-list drawing. Does nothing yet. https://bugs.webkit.org/show_bug.cgi?id=152807 Reviewed by Zalan Bujtas. Add an item to the Settings menu to toggle display-list drawing. * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleDisplayListDrawingEnabled:]): (-[SettingsController displayListDrawingEnabled]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): 2016-01-06 Youenn Fablet <youenn.fablet@crf.canon.fr> Python SCM should be able to retrieve untracked files - Add GIT support https://bugs.webkit.org/show_bug.cgi?id=143135 Reviewed by Michael Catanzaro. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.untracked_files): Adding support for git. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (GitTest.setUp): (GitTest.test_untracked_files): Adding test. 2016-01-05 Mark Lam <mark.lam@apple.com> Rename badly named JSC_timeout env var to JSCTEST_timeout. https://bugs.webkit.org/show_bug.cgi?id=152748 Reviewed by Geoffrey Garen. Now that we validate JSC options, the badly named JSC_timeout env var causes the bots to have a bad time. * Scripts/run-javascriptcore-tests: * Scripts/run-jsc-stress-tests: 2016-01-04 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Allow to save and restore session https://bugs.webkit.org/show_bug.cgi?id=115600 Reviewed by Michael Catanzaro. Add test case to check the new session API. * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: (testWebKitWebViewSessionState): (testWebKitWebViewSessionStateWithFormData): (beforeAll): 2016-01-04 Csaba Osztrogonác <ossy@webkit.org> [EFL] Bump EFL version to 1.16.1 https://bugs.webkit.org/show_bug.cgi?id=152688 Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: 2016-01-04 Aakash Jain <aakash_jain@apple.com> error running layout tests on iOS simulator on latest build https://bugs.webkit.org/show_bug.cgi?id=152719 <rdar://problem/24009549> Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/xcode/simulator.py: (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state before running simctl spawn command. 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com> Unreviewed, move Frédéric Wang to committers list He seems to be on the contributors list by accident. He has been landing his own commits for about two years now. * Scripts/webkitpy/common/config/contributors.json: 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com> Unreviewed, move Sebastian Dröge to committers list harder He accidentally added himself to the reviewers list because the file is confusing. Then I accidentially moved him to the contributors list because the file is confusing, even though I knew the contributors list existed in this file and was attempting to add him to the committers list. Really move him to the committers list now. * Scripts/webkitpy/common/config/contributors.json: 2016-01-02 Youenn Fablet <youenn.fablet@crf.canon.fr> Python SCM should be able to retrieve untracked files - Add SVN support https://bugs.webkit.org/show_bug.cgi?id=152546 Reviewed by Michael Catanzaro. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (test_untracked_files): Activating test for SVN. * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.untracked_files): Implementing untracked files retrieval for SVN. 2015-12-31 Andy Estes <aestes@apple.com> Replace WTF::move with WTFMove https://bugs.webkit.org/show_bug.cgi?id=152601 Reviewed by Brady Eidson. * DumpRenderTree/TestRunner.h: (TestRunner::setAllowedHosts): * DumpRenderTree/win/DRTDataObject.cpp: (DRTDataObject::SetData): * TestWebKitAPI/Tests/WTF/Deque.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/HashSet.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/Ref.cpp: (TestWebKitAPI::passWithRef): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/RefPtr.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/Vector.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/WTFString.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: (TestWebKitAPI::createTestValue): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter): (TestWebKitAPI::InMemoryCompiledContentExtension::create): (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension): (TestWebKitAPI::createNFAs): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: (TestWebKitAPI::combine): * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: (TestWebKitAPI::createNFAs): * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: (TEST): * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: (WebProcessTest::add): 2016-01-01 Michael Catanzaro <mcatanzaro@igalia.com> [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension https://bugs.webkit.org/show_bug.cgi?id=152634 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: (testLoadFromGResource): Added test. (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (registerGResource): Added. (webkit_web_extension_initialize_with_user_data): Load the test gresource. * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added. * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file. 2015-12-31 David Kilzer <ddkilzer@apple.com> REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE <https://bugs.webkit.org/show_bug.cgi?id=152601> Ignore unknown pragmas on older clangs. Fixes the following build failure: Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas] #pragma clang diagnostic ignored "-Wself-move" ^ 1 error generated. * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/RefPtr.cpp: (TestWebKitAPI::TEST): 2015-12-31 Andy Estes <aestes@apple.com> Update the style checker to advise using WTFMove() instead of WTF::move() https://bugs.webkit.org/show_bug.cgi?id=152601 Reviewed by Daniel Bates. * Scripts/webkitpy/style/checkers/cpp.py: (check_wtf_move): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (WebKitStyleTest.test_wtf_move): 2015-12-31 Andy Estes <aestes@apple.com> Fix warnings uncovered by migrating to WTF_MOVE https://bugs.webkit.org/show_bug.cgi?id=152601 Reviewed by Daniel Bates. Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle self-move, even if doing so would trigger a warning. * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/RefPtr.cpp: (TestWebKitAPI::TEST): 2015-12-31 Martin Robinson <mrobinson@igalia.com> [GTK] The install-dependencies script has a syntax error https://bugs.webkit.org/show_bug.cgi?id=152613 Reviewed by Michael Catanzaro. * gtk/install-dependencies: Add the missing 'then.' 2015-12-30 Philippe Normand <pnormand@igalia.com> [Mac][GTK] Jhbuild support for OSX https://bugs.webkit.org/show_bug.cgi?id=150799 Reviewed by Michael Catanzaro. * gtk/install-dependencies: Install dependencies on OSX with Homebrew. * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags. * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added. * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed. 2015-12-28 Michael Catanzaro <mcatanzaro@igalia.com> Unreviewed, move Sebastian Dröge to committers list He accidentally added himself to the reviewers list because the file is confusing. * Scripts/webkitpy/common/config/contributors.json: 2015-12-24 Simon Fraser <simon.fraser@apple.com> Remove the unused #define _USE_MATH_DEFINES https://bugs.webkit.org/show_bug.cgi?id=152034 Reviewed by Tim Horton. Update this test to use piDouble from MathExtras.h, and std::numeric_limits<>. * TestWebKitAPI/Tests/WTF/MediaTime.cpp: 2015-12-24 Youenn Fablet <youenn.fablet@crf.canon.fr> Python SCM should be able to retrieve untracked files - Generic changes https://bugs.webkit.org/show_bug.cgi?id=152536 Reviewed by Brent Fulgham. This patch introduces SCM.untracked_files to retrieve a list of untracked files. No support is yet added to GIT and SVN specific implementations. * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.untracked_files): * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SCMTest._shared_test_untracked_files): 2015-12-23 Dewei Zhu <dewei_zhu@apple.com> SVN checkout used by RunBenchmark should be non-interactive https://bugs.webkit.org/show_bug.cgi?id=152542 Reviewed by Ryosuke Niwa. RunBenchmark should not require user interaction while running. * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: (BenchmarkBuilder._checkout_with_subversion): 2015-12-23 Brent Fulgham <bfulgham@apple.com> Web Inspector: add support for running protocol-test.js tests on Windows https://bugs.webkit.org/show_bug.cgi?id=148037 <rdar://problem/22292237> Reviewed by Simon Fraser. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::inspectorTestStubURL): Provide implementation. 2015-12-23 Eric Carlson <eric.carlson@apple.com> [MediaStream] MediaDeviceInfo.label must be empty in some situations https://bugs.webkit.org/show_bug.cgi?id=152000 Reviewed by Brent Fulgham. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::setUserMediaPermission): (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New. * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setUserMediaPermissionForOrigin): New. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::setUserMediaPermissionForOrigin): (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check. (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add persistent permission for origin, that can be done from script now. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for SetUserMediaPermissionForOrigin. 2015-12-23 Brent Fulgham <bfulgham@apple.com> [Win] Unreviewed build fix: Recognize Windows 10 variants. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo._determine_win_version): 2015-12-23 Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org> Content blockers should be able to promote http to https https://bugs.webkit.org/show_bug.cgi?id=148966 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (WebCore::ContentExtensions::operator<<): (TestWebKitAPI::TEST_F): 2015-12-22 Hunseop Jeong <hs85.jeong@samsung.com> [EFL] MiniBrowser should be able to choose the offline-web-application-cache option https://bugs.webkit.org/show_bug.cgi?id=152516 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: 2015-12-22 Brent Fulgham <bfulgham@apple.com> Unreviewed: Add John Wilander as a contributor. * Scripts/webkitpy/common/config/contributors.json: 2015-12-22 Chris Fleizach <cfleizach@apple.com> [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html https://bugs.webkit.org/show_bug.cgi?id=152482 Reviewed by Brent Fulgham. vertical/horizontalScrollbar returns an accessibility element. That element can also be queried for the same property. On WK2, the element returned will not be valid, but is still present and that can lead to looping. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::horizontalScrollbar): (AccessibilityUIElement::verticalScrollbar): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::horizontalScrollbar): (WTR::AccessibilityUIElement::verticalScrollbar): 2015-12-22 Xabier Rodriguez Calvar <calvaris@igalia.com> Unreviewed. * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer. 2015-12-21 Hunseop Jeong <hs85.jeong@samsung.com> [EFL] test_ewk2_context failed after r192808 https://bugs.webkit.org/show_bug.cgi?id=151846 Reviewed by Gyuyoung Kim. Used the added ewk_context_web_process_count_limit_set api instead of the deprecated ewk_context_process_model_set. * MiniBrowser/efl/main.c: (elm_main): 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com> Unreviewed, move myself to reviewer list. * Scripts/webkitpy/common/config/contributors.json: 2015-12-21 Aakash Jain <aakash_jain@apple.com> Unreviewed, add myself to the committers list. * Scripts/webkitpy/common/config/contributors.json: 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] jquery.min.js violates DFSG https://bugs.webkit.org/show_bug.cgi?id=152428 Reviewed by Joseph Pecoraro. Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball. * gtk/manifest.txt.in: 2015-12-19 Dan Bernstein <mitz@apple.com> [Mac] WebKit contains dead source code for OS X Mavericks and earlier https://bugs.webkit.org/show_bug.cgi?id=152462 Reviewed by Alexey Proskuryakov. - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for OS X 10.9: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was never getting compiled: * DumpRenderTree/mac/TextInputController.m: * MiniBrowser/mac/BrowserWindowController.m: * TestWebKitAPI/Tests/mac/AttributedString.mm: * WebKitTestRunner/mac/EventSenderProxy.mm: 2015-12-18 Michael Catanzaro <mcatanzaro@igalia.com> Unreviewed, add WebKitGTK+ Bugzilla email to committers list This is to make it easy to CC it on Bugzilla. * Scripts/webkitpy/common/config/contributors.json: 2015-12-18 Aakash Jain <aakash_jain@apple.com> Pasteboard get messed up after running kill-old-processes https://bugs.webkit.org/show_bug.cgi?id=152426 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/kill-old-processes: (main): Do not kill pasteboard anymore. 2015-12-17 Aakash Jain <aakash_jain@apple.com> run-webkit-tests shouldn't start multiple iOS simulators while only running one test https://bugs.webkit.org/show_bug.cgi?id=152157 <rdar://problem/23851817> Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (LayoutTestRunner.get_worker_count): Calculate required number of workers. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._get_test_inputs): Common method to calculate test_inputs. (Manager._update_worker_count): Calculate and update required number of workers. 2015-12-16 Aakash Jain <aakash_jain@apple.com> run-webkit-tests fails to delete Simulator device during cleanup https://bugs.webkit.org/show_bug.cgi?id=152363 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/xcode/simulator.py: (Simulator.delete_device): Ensure that device is Shutdown before deleting it. 2015-12-16 Tim Horton <timothy_horton@apple.com> [mac-wk2] fast/events force click tests crashing https://bugs.webkit.org/show_bug.cgi?id=152339 Reviewed by Beth Dakin. * WebKitTestRunner/mac/EventSenderProxy.mm: (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]): Set the NSEvent's _type member in addition to overriding -type, because there are assertions in touch event handling code that depend on it. 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr> Enforce temporarily bots to sync WebKit and WPT testharness.js https://bugs.webkit.org/show_bug.cgi?id=152334 Reviewed by Darin Adler. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js. 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr> [Fetch API] Add fetch API compile time flag https://bugs.webkit.org/show_bug.cgi?id=152254 Reviewed by Darin Adler. * Scripts/webkitperl/FeatureList.pm: 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com> Unreviewed. Added files that have impact in building Streams API to the watchlist. * Scripts/webkitpy/common/config/watchlist: 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com> Unreviewed. Added imported tests to Streams API watchlist. * Scripts/webkitpy/common/config/watchlist: 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr> Remove default copy of wpt testharness.js when launching wpt server https://bugs.webkit.org/show_bug.cgi?id=152298 Reviewed by Darin Adler. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT. 2015-12-15 David Kilzer <ddkilzer@apple.com> REGRESSION (r192375): DumpRenderTree.app exits immediately with no error <http://webkit.org/b/152314> Reviewed by Daniel Bates. The change to DumpRenderTreeMain.mm in r192375 caused the iOS code path to exit immediately when calling main(). Unfortunately, DumpRenderTreeMain.mm was used for both DumpRenderTree command-line binary and DumpRenderTree.app, which meant that the app would exit immediately with no error code when run! The workaround is to introduce a separate source file called DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner already does. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add DumpRenderTreeAppMain.mm to the project. Make it the only compiled source for the DumpRenderTree.app target. * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm. (main): Call DumpRenderTreeMain() on iOS. Assert on OS X in case someone tries mistakenly to use the app. * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Link to JavaScriptCore.framework on iOS for the assert. * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Link to JavaScriptCore.framework on OS X for the assert. Remove unneeded EXCLUDED_SOURCE_FILE_NAMES setting. * DumpRenderTree/mac/DumpRenderTreeMain.mm: (main): Add assert for iOS so that a crash occurs if someone tries to run the wrong command. 2015-12-14 Tim Horton <timothy_horton@apple.com> Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke https://bugs.webkit.org/show_bug.cgi?id=152266 <rdar://problem/22092676> Reviewed by Simon Fraser. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added. Add a test that crashed before this change, and doesn't crash after. 2015-12-14 Chris Fleizach <cfleizach@apple.com> AX: iOS: Text field variations do not have the correct traits https://bugs.webkit.org/show_bug.cgi?id=152237 Reviewed by Mario Sanchez Prada. Add iOS calls for determing if an object is a search field or a text area. * DumpRenderTree/AccessibilityUIElement.cpp: (getIsSearchFieldCallback): (getIsTextAreaCallback): (stringForSelectionCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::identifier): (AccessibilityUIElement::isTextArea): (AccessibilityUIElement::isSearchField): (AccessibilityUIElement::traits): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::scrollPageRight): (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait): (WTR::AccessibilityUIElement::fieldsetAncestorElement): (WTR::AccessibilityUIElement::isSearchField): (WTR::AccessibilityUIElement::isTextArea): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::fieldsetAncestorElement): (WTR::AccessibilityUIElement::isTextArea): (WTR::AccessibilityUIElement::isSearchField): (WTR::AccessibilityUIElement::rowCount): 2015-12-14 Carlos Alberto Lopez Perez <clopez@igalia.com> [GTK] [JHBuild] package libtool-bin is now required on Debian systems. https://bugs.webkit.org/show_bug.cgi?id=152252 Reviewed by Sergio Villar Senin. * gtk/install-dependencies: Add libtool-bin to the list of packages required for building the JHBuild on Debian systems. 2015-12-11 Joseph Pecoraro <pecoraro@apple.com> check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones https://bugs.webkit.org/show_bug.cgi?id=152156 Reviewed by Dan Bernstein. Our frameworks should appropriately prefix all ObjC classes, not just external symbols. * Scripts/check-for-inappropriate-objc-class-names: Remove the -g switch to check all ObjC class names. 2015-12-10 Eric Carlson <eric.carlson@apple.com> [MediaStream] Expose media capture devices persistent permissions to WebCore https://bugs.webkit.org/show_bug.cgi?id=152087 Add support for the new user media permission checker page UI client method. Reviewed by Chris Dumez. * WebKitTestRunner/TestController.cpp: (WTR::decidePolicyForUserMediaPermissionRequest): (WTR::checkUserMediaPermissionForOrigin): (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin. (WTR::TestController::createWebViewWithOptions): Ditto. (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions. (WTR::originUserVisibleName): New, create a string for the origin. (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef according to the state of the origin permission map. (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible. (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the origin permission map. * WebKitTestRunner/TestController.h: 2015-12-10 Alex Christensen <achristensen@webkit.org> REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame https://bugs.webkit.org/show_bug.cgi?id=152022 rdar://problem/23763584 Reviewed by Darin Adler. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::setWillSendRequestReturnsNull): (WTR::TestRunner::willSendRequestReturnsNullOnRedirect): (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect): (WTR::TestRunner::setWillSendRequestAddsHTTPBody): (WTR::TestRunner::willSendRequestHTTPBody): Added setWillSendRequestAddsHTTPBody that uses new SPI for testing. 2015-12-10 Aakash Jain <aakash_jain@apple.com> Remove additional simulator checks before running layout-tests https://bugs.webkit.org/show_bug.cgi?id=152146 Reviewed by Darin Adler. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications. * Scripts/webkitpy/xcode/simulator.py: (Simulator._boot_and_shutdown_simulator_device): Deleted. (Simulator.check_simulator_device_and_erase_if_needed): Deleted. 2015-12-09 Aakash Jain <aakash_jain@apple.com> Run atleast one simulator even if max process limit is low https://bugs.webkit.org/show_bug.cgi?id=152081 <rdar://problem/23819694> Reviewed by Alexey Proskuryakov. 2015-12-09 Mario Sanchez Prada <mario@endlessm.com> [GTK] Crash in WebProcess when loading large content with custom URI schemes https://bugs.webkit.org/show_bug.cgi?id=144262 Reviewed by Carlos Garcia Campos. Added new unit test to check the additional scenarios we now handle for custom URI schemes. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (generateHTMLContent): New helper function to generate big enough content. (testWebContextURIScheme): New unit test. 2015-12-09 Ryuan Choi <ryuan.choi@navercorp.com> [EFL] Fix unhandled web process message when launching MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=152048 Reviewed by Gyuyoung Kim. * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: (TestWebKitAPI::TEST): 2015-12-09 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add API to handle beforeunload events https://bugs.webkit.org/show_bug.cgi?id=139090 Reviewed by Gustavo Noronha Silva. * MiniBrowser/gtk/BrowserWindow.c: (browserWindowConstructed): (browserWindowDeleteEvent): (browser_window_class_init): Handle delete-event to prevent the window from being closed when the page has beforeunload handlers. Use webkit_web_view_try_close() when the window is requested to be closed. * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewJavaScriptDialogs): Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM script dialog type. 2015-12-09 Mario Sanchez Prada <mario@endlessm.com> Refactored initialization code in LoadTrackingTest. Rubber-stamped by Carlos Garcia Campos. Small refactoring to make sure that the state of a LoadTrackingTest gets properly reset before loading new web content. * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h: * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp: (LoadTrackingTest::reset): New, refactored code from *load*() and go*() functions and reset the remaining local variables. (LoadTrackingTest::loadURI): Call reset(); (LoadTrackingTest::loadHtml): Ditto. (LoadTrackingTest::loadPlainText): Ditto. (LoadTrackingTest::loadBytes): Ditto. (LoadTrackingTest::loadRequest): Ditto. (LoadTrackingTest::reload): Ditto. (LoadTrackingTest::goBack): Ditto. (LoadTrackingTest::goForward): Ditto. 2015-12-09 Gyuyoung Kim <gyuyoung.kim@webkit.org> [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616 https://bugs.webkit.org/show_bug.cgi?id=151942 Reviewed by Darin Adler. * MiniBrowser/efl/main.c: (window_create): Enable offline web application cache feature on MiniBrowser. (elm_main): 2015-12-08 Aakash Jain <aakash_jain@apple.com> https://bugs.webkit.org/show_bug.cgi?id=151243 <rdar://problem/22955197> Reviewed by Alexey Proskuryakov. * LayoutTestRelay/LayoutTestRelay/main.m: (getTestingSimDevice): Use separate testing device for each worker. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.run): Perform cleanup even if setup fails. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use. (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable. (IOSSimulatorPort.setup_test_run): Handle mulitple simulators. (IOSSimulatorPort._quit_ios_simulator): Same (IOSSimulatorPort.clean_up_test_run): Same (IOSSimulatorPort.check_sys_deps): Same (IOSSimulatorPort.testing_device): Same (IOSSimulatorPort.reset_preferences): Same (IOSSimulatorPort.get_simulator_path): Return simulator path. (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app. * Scripts/webkitpy/xcode/simulator.py: (Device.delete): Delete the simulator device. (Simulator.delete_device): Same (Simulator.wait_until_device_is_booted): Wait for device booting. 2015-12-08 Ryuan Choi <ryuan.choi@navercorp.com> [EFL] Add API to provide preferences before creating ewk_view https://bugs.webkit.org/show_bug.cgi?id=151587 Reviewed by Gyuyoung Kim. * MiniBrowser/efl/main.c: (on_key_down): (quit): (window_create): Moved settings related code to configuration() not to update settings whenever ewk_view is created. (configuration): (elm_main): 2015-12-08 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Fix GTK+ API tests after r193639. The new jhbuild version needs some more variables ot be present in the builtin dict, even if they are set to None. * jhbuild/jhbuildutils.py: (enter_jhbuild_environment_if_available): 2015-12-07 Gustavo Noronha Silva <gns@gnome.org> [GTK] Notify WebCore when notification is clicked https://bugs.webkit.org/show_bug.cgi?id=151951 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewNotification): test the new API. 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com> 'jhbuild build' should fail immediately when building any module fails https://bugs.webkit.org/show_bug.cgi?id=145697 Reviewed by Carlos Garcia Campos. * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option. * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option. Everything is placed under lib instead of lib64 now. * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass --exit-on-error when running 'jhbuild build'. * jhbuild/jhbuildrc_common.py: (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern jhbuild should be able to handle these for us without breaking things.... 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com> Add support to import w3c tests from a repository with a different root that the main repo dir https://bugs.webkit.org/show_bug.cgi?id=151751 Reviewed by Ryosuke Niwa and Youenn Fablet. We should be able to import tests from repositories that are not pure test repositories and where tests are kept in a different directory than the repository root. This patch introduces a new parameter tests_directory that we will use as root directory to search for tests. All paths will be flattened when copying tests to have a less complicated directory structure. This requires having the copy_path lists including tuples of origin and destination directories. * Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory. (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files. * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.test_tests_directory): Test. 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com> Mock TestRepositories in W3C importer tests https://bugs.webkit.org/show_bug.cgi?id=151938 Reviewed by Youenn Fablet. The test importer tests should use a fake repository instead of using the real one. The reason why this happened is because the test repository method reading the file was using the filesystem directly instead of taking the host one. This patch changes that. * Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the default one. (TestDownloader.__init__): When loading the repositories, pass the host filesystem. * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.test_harnesslinks_conversion): (TestImporterTest.test_submodules_generation): Use a fake test repository file. 2015-12-07 David Kilzer <ddkilzer@apple.com> TestNetscapePlugIn: Address review comment on 193607 <http://webkit.org/b/151881> * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (testSetStatus): Initializing std::unique_ptr<char[]> with nullptr is redundant. 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add webkit_uri_request_get_http_method https://bugs.webkit.org/show_bug.cgi?id=151601 Reviewed by Martin Robinson. Add test case to check HTTP method of WebKitURIRequest. * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: (testURIRequestHTTPMethod): (serverCallback): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (sendRequestCallback): 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API https://bugs.webkit.org/show_bug.cgi?id=79918 Reviewed by Gustavo Noronha Silva. Add unit tests to check the different console messages. * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added. (ConsoleMessageTest::ConsoleMessage::operator==): (ConsoleMessageTest::consoleMessageReceivedCallback): (ConsoleMessageTest::ConsoleMessageTest): (ConsoleMessageTest::~ConsoleMessageTest): (ConsoleMessageTest::waitUntilConsoleMessageReceived): (testWebKitConsoleMessageConsoleAPI): (testWebKitConsoleMessageJavaScriptException): (testWebKitConsoleMessageNetworkError): (testWebKitConsoleMessageSecurityError): (beforeAll): (afterAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (consoleMessageSentCallback): (pageCreatedCallback): 2015-12-07 Ryuan Choi <ryuan.choi@navercorp.com> [EFL] MiniBrowser doesn't exit when called ewk_view_try_close() https://bugs.webkit.org/show_bug.cgi?id=151934 Reviewed by Csaba Osztrogonác. * MiniBrowser/efl/main.c: (on_window_deletion): Revert the changes of r192767. 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com> [GTK] update-webkitgtk-libs cannot build mesa https://bugs.webkit.org/show_bug.cgi?id=151535 Reviewed by Martin Robinson. Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM does not have a stable API and we cannot expect mesa to be buildable unless we control the LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7. * gtk/jhbuild.modules: 2015-12-07 Philippe Normand <pnormand@igalia.com> [GTK][Mac] libWebExtensionTest link error https://bugs.webkit.org/show_bug.cgi?id=150802 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library. 2015-12-06 David Kilzer <ddkilzer@apple.com> TestNetscapePlugIn: Fix leaks found by static analyzer <http://webkit.org/b/151881> Reviewed by Darin Adler. Fixes the following leaks found by the static analyzer: DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path' return false; ^~~~~ DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target' return false; ^~~~~ DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url' return false; ^~~~~ * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (toCString): Switch to returning std::unique_ptr<char[]>. Add early return if allocation fails. (testPostURLFile): Switch to using std::unique_ptr<char[]>. Make sure to call fclose() on filehandle, even for an early return. (testSetStatus): Switch to using std::unique_ptr<char[]>. 2015-12-05 David Kilzer <ddkilzer@apple.com> prepare-ChangeLog: Fix some warning messages when using svn <http://webkit.org/b/151914> Reviewed by Daniel Bates. * Scripts/prepare-ChangeLog: (generateFunctionLists): Simplify logic so that we never call normalizePath() with an undefined value. (attributeCommand): Quote $subPath for the shell so that we don't try to run "svn propget" on invalid paths. 2015-12-04 David Kilzer <ddkilzer@apple.com> TestNetscapePlugIn: Fix remaining static analyzer warnings <http://webkit.org/b/151888> Reviewed by Alexey Proskuryakov. Fixes the following static analyzer warnings: Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference) CRASH(); ^~~~~~~ Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH' ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \ ^~~~~~~~~~~~~~~~ Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj') return obj->pluginTest->NPP_SetWindow(window); ^~~~~~~~~~~~~~~ 2 warnings generated. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (CRASH): Use __builtin_trap() for gcc/clang. (NPP_SetWindow): Add early return if obj is nullptr. 2015-12-03 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Test /webkit2/WebKitWebResource/get-data is flaky https://bugs.webkit.org/show_bug.cgi?id=151797 Reviewed by Martin Robinson. Since we switched to use the network process to run the unit tests the test /webkit2/WebKitWebResource/get-data sometimes fails and sometimes passes. We are now also getting the notification for the css image. Since we wait for 3 resources, sometimes the css image is loaded before and then checkResourceData is called for it, but not handled. When the css image is the last one loaded the test passes. So, we just need to wait for the 4 resources. * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (testWebResourceGetData): 2015-12-03 David Kilzer <ddkilzer@apple.com> DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm <http://webkit.org/b/151845> Reviewed by Simon Fraser. Fixes the following static analyzer warning: DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContext): Free 'buffer' after using it in logging to fix the use-after-free. Assign a value of nullptr to buffer so we don't return with it set to a freed address. 2015-12-03 Jer Noble <jer.noble@apple.com> Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2 https://bugs.webkit.org/show_bug.cgi?id=151830 Reviewed by Anders Carlsson. Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): 2015-12-03 Anders Carlsson <andersca@apple.com> Remove Objective-C GC support https://bugs.webkit.org/show_bug.cgi?id=151819 rdar://problem/23746991 Reviewed by Dan Bernstein. * asan/asan.xcconfig: 2015-12-02 Yusuke Suzuki <utatane.tea@gmail.com> Allow nil for unspecified benchmark pathes https://bugs.webkit.org/show_bug.cgi?id=151784 Reviewed by Filip Pizlo. `Pathname.new(nil)` will raise an error. Only generate Pathname if the benchmark path is specified. * Scripts/run-jsc-benchmarks: 2015-12-02 Brent Fulgham <bfulgham@apple.com> [Win] Run non-http tests without Cygwin https://bugs.webkit.org/show_bug.cgi?id=151721 Reviewed by Andy Estes. Support native 32-bit and 64-bit Python (and Perl) builds for running tests: 1. Use "startswith('win')", rather than "== 'win32'" to support various Windows build types. 2. Supply full path for some native Windows utilities, since the path environment does not always have the specified, and they are guaranteed to exist in those specific locations. 3. Make sure native Windows Python test runs pass proper environment variables to run programs. 4. Append 'exe' suffix when running Windows executables. 5. Use the _winreg Python module on Windows, since the Cygwin 'regtool' command doesn't exist. * Scripts/update-webkit: Use Perl $^X command to refer to the path of the current Perl executable, rather than requiring a new path search. * Scripts/webkitpy/common/find_files_unittest.py: (TestWinNormalize.test_win): Use startswith('win'). * Scripts/webkitpy/common/prettypatch_unittest.py: (test_pretty_diff_encodings): Ditto. * Scripts/webkitpy/common/system/executive.py: (Executive._should_close_fds): Ditto. (Executive.shell_command_for_script): Use startswith('win'). (Executive.kill_process): Use full path to killall executable. (Executive.check_running_pid): Use startswith('win'). (Executive.running_pids): Ditto. (Executive.kill_all): Ditto. Also use path to 'killall' executable when running under native Windows Python. (Executive._child_process_encoding): Use startswith('win'). (Executive._should_encode_child_process_arguments): Ditto. (Executive.popen): Recognize proper script engine on Windows, since it does not support the shebang syntax. (Executive.run_in_parallel): Use startswith('win'). * Scripts/webkitpy/common/system/executive_unittest.py: (never_ending_command): Ditto. (ExecutiveTest.test_run_command_with_unicode): Ditto. (ExecutiveTest.serial_test_kill_process): Ditto. (ExecutiveTest.serial_test_kill_all): Ditto. (ExecutiveTest.serial_test_check_running_pid): Ditto. (ExecutiveTest.serial_test_run_in_parallel): Ditto. (main): Ditto. * Scripts/webkitpy/common/system/file_lock.py: (FileLock._create_lock): Ditto. (FileLock._remove_lock): Ditto. * Scripts/webkitpy/common/system/filesystem_unittest.py: (RealFileSystemTest.test_chdir): Ditto. (RealFileSystemTest.test_chdir__notexists): Ditto. (RealFileSystemTest.test_maybe_make_directory__failure): Ditto. * Scripts/webkitpy/common/system/path_unittest.py: (AbspathTest.test_abspath_to_uri_win): Ditto. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo._determine_os_name): Ditto. * Scripts/webkitpy/common/system/user.py: Ditto. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ManagerTest.integration_test_needs_servers): Ditto. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): Handle upper and lower-case driver letters. (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto. * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: (TestLayoutTestApacheHttpd.test_start_cmd): Ditto. * Scripts/webkitpy/layout_tests/servers/http_server_base.py: (HttpServerBase._check_that_all_ports_are_available): Ditto. * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py: (TestHttpServer.test_start_cmd): Ditto. * Scripts/webkitpy/port/base.py: (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE', and 'SYSTEMROOT' in environment passed to test runners. (Port._apache_config_file_name_for_platform): Use startswith('win'). (Port._build_path): Ditto. (Port._path_to_driver): Include 'exe' suffix when running under native Windows. * Scripts/webkitpy/port/driver.py: (Driver._setup_environ_for_driver): Explicitly make some environment variables strings. * Scripts/webkitpy/port/server_process.py: (ServerProcess.__init__): Use startswith('win'). * Scripts/webkitpy/port/win.py: (WinPort): Use the win32 registry utilities on Windows, and appropriate registry key formats. (WinPort._ntsd_location): Revise tool search paths for Windows 10. (WinPort.read_registry_value): Revise to use _winreg library on Windows, and regtool on Cygwin. (WinPort.write_registry_value): Ditto. (WinPort.setup_crash_log_saving): Ditto. (WinPort.restore_crash_log_saving): Ditto. (WinPort.prevent_error_dialogs): Ditto. (WinPort.allow_error_dialogs): Ditto. (WinPort.find_system_pid): Revise to use Windows management infrastructure on native Windows, continue using 'ps' on Cygwin. (WinPort.read_registry_string): Deleted. (WinPort.write_registry_string): Deleted. * Scripts/webkitpy/test/main.py: (main): Use startswith('win'). (Tester._parse_args): Ditto. 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com> [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature https://bugs.webkit.org/show_bug.cgi?id=150792 Reviewed by Saam Barati. * Scripts/webkitperl/FeatureList.pm: 2015-12-01 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r192914. https://bugs.webkit.org/show_bug.cgi?id=151734 JSC tests for this change are failing on 32 and 64-bit bots (Requested by ryanhaddad on #webkit). Reverted changeset: "[ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature" https://bugs.webkit.org/show_bug.cgi?id=150792 http://trac.webkit.org/changeset/192914 2015-12-01 David Kilzer <ddkilzer@apple.com> EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent <http://webkit.org/b/151726> Reviewed by Simon Fraser. * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases): Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak. 2015-12-01 Myles C. Maxfield <mmaxfield@apple.com> Give String and AtomicString an existingHash() function https://bugs.webkit.org/show_bug.cgi?id=151717 Reviewed by Andreas Kling. * TestWebKitAPI/Tests/WTF/AtomicString.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/WTFString.cpp: (TestWebKitAPI::TEST): 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com> [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature https://bugs.webkit.org/show_bug.cgi?id=150792 Reviewed by Saam Barati. * Scripts/webkitperl/FeatureList.pm: 2015-12-01 Sam Weinig <sam@webkit.org> Need completionHandler-based WebKit C SPI for alert, confirm, and prompt <rdar://problem/23320863> https://bugs.webkit.org/show_bug.cgi?id=151708 Reviewed by Anders Carlsson. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): Update for new WKPageUIClient. 2015-12-01 Anders Carlsson <andersca@apple.com> Remove WebKit2.framework https://bugs.webkit.org/show_bug.cgi?id=151715 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h: 2015-12-01 Joseph Pecoraro <pecoraro@apple.com> Unreviewed common typo fix "occurance" => "occurrence". * Scripts/webkitpy/tool/commands/queries.py: (FindFlakyTests._print_statistics): 2015-11-30 Alex Christensen <achristensen@webkit.org> Make ProcessModel always MultipleSecondaryProcesses https://bugs.webkit.org/show_bug.cgi?id=151662 Reviewed by Antti Koivisto. * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: (TestWebKitAPI::TEST): * WebKitTestRunner/TestController.cpp: (WTR::TestController::generatePageConfiguration): 2015-11-30 Alex Christensen <achristensen@webkit.org> Make usesNetworkProcess always true https://bugs.webkit.org/show_bug.cgi?id=151580 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: (TestWebKitAPI::TEST): * WebKitTestRunner/TestController.cpp: (WTR::TestController::generatePageConfiguration): 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug. Add a way to skip unit tests only for Debug or Release builds and skipt the test /webkit2/WebKitWebView/editable/editable only for Debug. * Scripts/run-gtk-tests: (SkippedTest): (SkippedTest.__init__): (SkippedTest.__str__): (SkippedTest.skip_entire_suite): (SkippedTest.skip_for_build_type): (TestRunner): (TestRunner.__init__): 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com> Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset. It's an assert hit because we are reloading a view loaded with HTML data which is not supported. Use loadURI instead. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewCustomCharset): 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com> [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource https://bugs.webkit.org/show_bug.cgi?id=151633 Reviewed by Csaba Osztrogonác. * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed. 2015-11-27 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Remove the remaining uses of GMainLoopSource https://bugs.webkit.org/show_bug.cgi?id=151632 Reviewed by Žan Doberšek. * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (testWebViewSyncRequestOnMaxConns): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::TestRunner): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer): (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded): * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::timeoutSource): (WTR::TestController::notifyDone): (WTR::TestController::platformRunUntil): 2015-11-27 Csaba Osztrogonác <ossy@webkit.org> [cmake] Add testb3 to the build system https://bugs.webkit.org/show_bug.cgi?id=151619 Reviewed by Gyuyoung Kim. * Scripts/build-jsc: 2015-11-27 Csaba Osztrogonác <ossy@webkit.org> [jhbuild] Fix pixman build with clang https://bugs.webkit.org/show_bug.cgi?id=151441 Reviewed by Carlos Garcia Campos. * efl/jhbuild.modules: * gtk/jhbuild.modules: 2015-11-26 David Kilzer <ddkilzer@apple.com> Extract prependToEnvironmentVariableList <http://webkit.org/b/151536> Reviewed by Daniel Bates. Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl webkitdirs_unittest/prependToEnvironmentVariableList.pl * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList and prependToEnvironmentVariableList. (appendToEnvironmentVariableList): Simplify variable name. Switch to use $Config{path_sep}. (prependToEnvironmentVariableList): Add new method. (setupMacWebKitEnvironment): Switch to use prependToEnvironmentVariableList(). (setupIOSWebKitEnvironment): Ditto. * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added. * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added. 2015-11-24 Gyuyoung Kim <gyuyoung.kim@webkit.org> REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button https://bugs.webkit.org/show_bug.cgi?id=151567 Reviewed by Darin Adler. * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close(). (on_window_deletion): 2015-11-23 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Use the network process unconditionally https://bugs.webkit.org/show_bug.cgi?id=151541 Reviewed by Alex Christensen. Fix TestInspectorServer test. Do not assume we already have the title we want when the page has been loaded, since the title is changed afterwards. So, check if the title has already been set, and if not wait for it. * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: (openRemoteDebuggingSession): 2015-11-23 Alex Christensen <achristensen@webkit.org> Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true https://bugs.webkit.org/show_bug.cgi?id=151532 Reviewed by Benjamin Poulain. * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged): (TestWebKitAPI::TEST): (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged): (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted. (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted. Properly load about:blank in all WebViews to clean up. Without this change, we had a Geolocation provider stopping after its state tracker was destroyed with its stack frame, so it was calling a function on a test object that had gone out of scope. Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed, but that will become the default soon and that call will be removed. 2015-11-22 David Kilzer <ddkilzer@apple.com> run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch <http://webkit.org/b/151542> Reviewed by Daniel Bates. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (base_url): Use the Port object (already passed in) to give us the path to the LayoutTests directory, which already checks for a --layout-tests-directory command-line switch. (WebPlatformTestServer.__init__): Remove layout_test_results_dir argument since we can get this from the Port object already passed in via Port.results_directory(). Also switch to use Port.layout_tests_dir() to get the LayoutTests directory. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: (TestWebPlatformTestServer.test_custom_layout_tests_directory): Add test case for custom LayoutTests directory. (TestWebPlatformTestServer.test_previously_spawned_instance): Update Port object to set mock results directory as if it was set on the command-line. Remove unneeded argument from WebPlatformTestServer constructor. (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto. * Scripts/webkitpy/port/base.py: (Port.to.start_web_platform_test_server): Remove unneeded argument from WebPlatformTestServer constuctor. 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] Some unit tests fail when using the network process https://bugs.webkit.org/show_bug.cgi?id=151490 Reviewed by Martin Robinson. Run the soup server in a separate thread in TestResources test to avoid deadlocks. This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and /webkit2/WebKitWebResource/get-data when using the network process. * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: (beforeAll): Create the WebKitTestServer with ServerRunInThread flag. * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp: (WebKitTestServer::WebKitTestServer): When ServerRunInThread is present, create a WorkQueue to run the server. (WebKitTestServer::run): Run the server in the work queue if it has been created. * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server type into server options as flags. 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com> [GTK] ImageDiff should normalize the diff image https://bugs.webkit.org/show_bug.cgi?id=151261 Reviewed by Sergio Villar Senin. * ImageDiff/gtk/ImageDiff.cpp: (readPixbufFromStdin): Fix memory leak. (differenceImageFromDifferenceBuffer): Normalize diff buffer. (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer. == Rolled over to ChangeLog-2015-11-21 ==