2016-09-22 Babak Shafiei Merge r206038. rdar://problem/28086237 2016-09-16 Wenson Hsieh RequiresUserActionForPlayback TestWebKitAPI tests are broken after r206033. https://bugs.webkit.org/show_bug.cgi?id=162080 Reviewed by Jer Noble. I renamed "playingHandler" to the more generalized "testHandler", but did not realize that the RequiresUserActionForPlayback tests also used "playingHandler". Renames the handler to account for this change. * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::SetUp): 2016-09-22 Babak Shafiei Merge r206033. rdar://problem/28086237 2016-09-16 Wenson Hsieh Inserting a space after inserting an accepted candidate scrolls the document and causes a flicker https://bugs.webkit.org/show_bug.cgi?id=162009 Reviewed by Tim Horton. Adds 3 new text editing API tests covering candidate insertion, as well as support for testing candidates in WKWebViews. Refactors common WKWebView helpers across both VideoControlsManager tests and the new WKWebViewCandidateTests into a new utility class, TestWKWebView in TestWKWebView.mm, which is capable of simulating mouse and keyboard events as well as waiting for JavaScript messages sent from the web process and performing actions in response. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit/ios/audio-only.html: * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): (-[MessageHandler initWithMessage:handler:]): Deleted. (-[MessageHandler userContentController:didReceiveScriptMessage:]): Deleted. (-[VideoControlsManagerTestWebView mouseDownAtPoint:]): Deleted. (-[VideoControlsManagerTestWebView performAfterLoading:]): Deleted. (-[VideoControlsManagerTestWebView callJavascriptFunction:]): Deleted. (-[VideoControlsManagerTestWebView loadTestPageNamed:]): Deleted. (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Added. (-[TestCandidate initWithReplacementString:inRange:]): (-[TestCandidate replacementString]): (-[TestCandidate resultType]): (-[TestCandidate range]): (-[CandidateTestWebView insertCandidatesAndWaitForResponse:range:]): (-[CandidateTestWebView _didHandleAcceptedCandidate]): (-[CandidateTestWebView expectCandidateListVisibilityUpdates:whenPerformingActions:]): (-[CandidateTestWebView _didUpdateCandidateListVisibility:]): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: * TestWebKitAPI/mac/TestWKWebViewMac.h: Added. * TestWebKitAPI/mac/TestWKWebViewMac.mm: Added. (-[TestMessageHandler initWithMessage:handler:]): (-[TestMessageHandler userContentController:didReceiveScriptMessage:]): (-[TestWKWebView mouseDownAtPoint:]): (-[TestWKWebView performAfterReceivingMessage:action:]): (-[TestWKWebView loadTestPageNamed:]): (-[TestWKWebView typeCharacter:]): (-[TestWKWebView stringByEvaluatingJavaScript:]): (-[TestWKWebView waitForMessage:]): (-[TestWKWebView performAfterLoading:]): 2016-09-16 Babak Shafiei Merge r204916. rdar://problem/27991573 2016-08-23 Anders Carlsson Add enum traits and use them in the IPC::Decoder https://bugs.webkit.org/show_bug.cgi?id=161103 Reviewed by Sam Weinig. Add API test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added. (TestWebKitAPI::TEST): 2016-09-14 Babak Shafiei Merge r205938. rdar://problem/28227805 2016-09-14 Wenson Hsieh Media controls behave strangely when changing media sources https://bugs.webkit.org/show_bug.cgi?id=161914 Reviewed by Tim Horton. Adds three new unit tests verifying that media controls remain stable during common `src` change scenarios. Also tweaks an existing test to account for new `ended` behavior. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (-[VideoControlsManagerTestWebView waitForMediaControlsToShow]): (-[VideoControlsManagerTestWebView waitForMediaControlsToHide]): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Added. 2016-09-14 Babak Shafiei Merge r205878. rdar://problem/28229827 2016-09-13 Tim Horton Provide a mechanism to specify the maximum width of WKThumbnailView snapshots https://bugs.webkit.org/show_bug.cgi?id=161896 Reviewed by Simon Fraser. * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: (TestWebKitAPI::TEST): Add a test for the new property. Also fix the old new test to run on arbitrary scale displays without failing. 2016-09-12 Babak Shafiei Merge r205784. rdar://problem/28230123 2016-09-10 Wenson Hsieh Apple.com keynote does not display media controls https://bugs.webkit.org/show_bug.cgi?id=161833 Reviewed by Tim Horton. New unit test verifying that wide videos (~2 aspect ratio) still get media controls. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Added. 2016-09-12 Babak Shafiei Merge r205783. rdar://problem/28229756 2016-09-09 Tim Horton WKThumbnailView should expose a mode where it can be reparented without resnapshotting https://bugs.webkit.org/show_bug.cgi?id=161828 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Added. (-[SnapshotSizeObserver observeValueForKeyPath:ofObject:change:context:]): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::setPageLoaderClient): (TestWebKitAPI::TEST): Add a test ensuring that this behaves correctly. 2016-09-09 Babak Shafiei Merge r205417. rdar://problem/28018438 2016-09-03 Wenson Hsieh Media controls behave strangely when videos mute from within a playing handler https://bugs.webkit.org/show_bug.cgi?id=161559 Reviewed by Darin Adler. Accounts for changes when determining whether or not to show media controls for autoplaying videos that have not begun playing yet. Rather than check for a controlled media element upon page load, we force tests to wait until all autoplaying videos have actually begun playing. This extends to tests that involve interaction, such as clicking or scrolling. * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (-[VideoControlsManagerTestWebView callJavascriptFunction:]): (-[VideoControlsManagerTestWebView expectControlsManager:afterReceivingMessage:]): (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): (-[VideoControlsManagerTestWebView waitForPageToLoadWithAutoplayingVideos:]): (TestWebKitAPI::TEST): (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: 2016-09-09 Babak Shafiei Merge r205412. rdar://problem/28014919 2016-09-03 Wenson Hsieh Refactor the heuristic for showing media controls to take all media sessions into account https://bugs.webkit.org/show_bug.cgi?id=161503 Reviewed by Darin Adler. Adds new unit tests verifying the behavior of media playback controls when scrolling another video into view. Please see the WebCore ChangeLog for more details about this change. Also refactors existing VideoControlsManager tests by folding duplicated setup and testing logic into helper methods to make the unit tests more readable. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (-[MessageHandler initWithMessage:handler:]): (-[MessageHandler userContentController:didReceiveScriptMessage:]): (-[VideoControlsManagerTestWebView performAfterLoading:]): (-[VideoControlsManagerTestWebView loadTestPageNamed:]): (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): (-[VideoControlsManagerTestWebView controlledElementID]): (-[VideoControlsManagerTestWebView _handleControlledElementIDResponse:]): (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager): (TestWebKitAPI::TEST): (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): Deleted. (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): Deleted. (-[OnLoadMessageHandler initWithWKWebView:handler:]): Deleted. (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): Deleted. (-[WKWebView performAfterLoading:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Added. 2016-08-31 Babak Shafiei Merge r204989. rdar://problem/28015116 2016-08-25 Wenson Hsieh Dragging against the end of the inline media scrubber causes the media scrubber to hide https://bugs.webkit.org/show_bug.cgi?id=161207 Reviewed by Eric Carlson. Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media controls in this case, we should actually continue showing them. This is because seeking due to user gestures similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end. * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): 2016-08-19 Alexey Proskuryakov Merge r204656 and r204660. 2016-08-19 Alexey Proskuryakov Adopt SimServiceContext in LayoutTestRelay https://bugs.webkit.org/show_bug.cgi?id=161000 Reviewed by Daniel Bates. * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: * LayoutTestRelay/LayoutTestRelay/main.m: 2016-08-11 Keith Miller Merge r203972. 2016-08-01 Keith Miller We should no t keep the JavaScript tests inside the Source/JavaScriptCore/ directory. https://bugs.webkit.org/show_bug.cgi?id=160372 Rubber stamped by Geoffrey Garen. This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to a new top level directory, JSTests. Having the tests in the Source directory was both confusing an inconvenient for people that just want to checkout the source code of WebKit. Since there is no other obvious place to put all the JavaScript tests a new top level directory seemed the most sensible. * Scripts/import-test262-tests: * Scripts/run-javascriptcore-tests: * Scripts/update-javascriptcore-test-res: 2016-08-02 Babak Shafiei Merge r204062. rdar://problem/27592936 2016-08-02 Nan Wang AX: Simulated touch events are not working on iOS https://bugs.webkit.org/show_bug.cgi?id=160395 Reviewed by Chris Fleizach. * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::press): (WTR::AccessibilityUIElement::setSelectedChild): 2016-08-02 Babak Shafiei Merge r203955. rdar://problem/27629346 2016-07-31 Nan Wang AX: Add a check for touch event listener on iOS accessibility object https://bugs.webkit.org/show_bug.cgi?id=160388 Reviewed by Chris Fleizach. * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::boolAttributeValue): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::boolAttributeValue): 2016-07-31 Babak Shafiei Merge r203842. rdar://problem/27553464 2016-07-28 Tim Horton Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.) https://bugs.webkit.org/show_bug.cgi?id=160289 Reviewed by Simon Fraser. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added. (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): (-[AnimatedResizeWebView _endAnimatedResize]): (animatedResizeWebView): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added. Add two tests that ensure that hidden-content and animated resizes don't cause unnecessary synchronous waits. Only the hidden-content one fails before my patch, but it seemed reasonable to add both anyway. 2016-07-31 Babak Shafiei Merge r203928. rdar://problem/27179484 2016-07-29 Wenson Hsieh Media controls are not displayed for some autoplaying videos at certain browser dimensions https://bugs.webkit.org/show_bug.cgi?id=160360 Reviewed by Myles C. Maxfield. Adds two tests verifying that videos may be considered main content as long as they are large enough and cover a majority of the mainframe's viewport. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added. 2016-07-31 Babak Shafiei Merge r203905. rdar://problem/27610246 2016-07-29 Wenson Hsieh Add TestWebKitAPI support for interacting with media controls https://bugs.webkit.org/show_bug.cgi?id=160342 Reviewed by Beth Dakin. Adds support for testing interaction with some media controls, as well as a basic test verifying that media control teardown after interaction does not result in a crash. * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (-[WKWebView mouseDownAtPoint:]): (-[WKWebView performAfterLoading:]): (TestWebKitAPI::TEST): 2016-07-28 Babak Shafiei Merge r203755. rdar://problem/23325160 2016-07-26 Alex Christensen Fix tests after r203743. https://bugs.webkit.org/show_bug.cgi?id=156947 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges. 2016-07-28 Babak Shafiei Merge r203743. rdar://problem/23325160 2016-07-26 David Kilzer Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation https://bugs.webkit.org/show_bug.cgi?id=156947 Reviewed by Alex Christensen. * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner): (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback): * DumpRenderTree/TestRunner.h: (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges): (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges): * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::queueNonLoadingScript): (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveAuthenticationChallenge): * WebKitTestRunner/TestController.h: (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing. 2016-07-28 Babak Shafiei Merge r203855. rdar://problem/27557968 2016-07-28 Myles C. Maxfield Remove deprecated SPI for video inline / fullscreen controls https://bugs.webkit.org/show_bug.cgi?id=160318 Reviewed by Tim Horton. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::SetUp): Deleted. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): Deleted. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): Deleted. 2016-07-28 Babak Shafiei Merge r203752. rdar://problem/27557968 2016-07-26 Myles C. Maxfield [iPhone] Playing a video on tudou.com plays only sound, no video https://bugs.webkit.org/show_bug.cgi?id=160178 Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::SetUp): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): 2016-07-28 Babak Shafiei Merge r203698. rdar://problem/26986673 2016-07-25 Wenson Hsieh Media controls should not be displayed for a video until it starts playing https://bugs.webkit.org/show_bug.cgi?id=160092 Reviewed by Beth Dakin. Verify that multiple videos do or don't show the media controller depending on whether videos are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was passing because we were always showing media controls for large videos with audio, even if they had not played back yet. This change ensures that large videos with audio show media controls only after they begin to play back, and not by virtue of being large enough for main content. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added. 2016-07-28 Babak Shafiei Merge r203700. rdar://problem/27010112 2016-07-25 Brady Eidson Modern IDB: Make sure IndexedDB works from file:// url documents by default https://bugs.webkit.org/show_bug.cgi?id=153783 Reviewed by Alex Christensen. Previously, to grant IndexedDB access to file:// urls for testing purposes, we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:]. As of https://trac.webkit.org/changeset/203695 this is no longer required. Change the relevant API tests to make sure this continues to be no longer required. * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: 2016-07-28 Babak Shafiei Merge r203690. rdar://problem/26668526 2016-07-25 Wenson Hsieh Media controls on apple.com don't disappear when movie finishes playing https://bugs.webkit.org/show_bug.cgi?id=160068 Reviewed by Darin Adler. Adds new API tests. Please see WebCore ChangeLog for more details. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): (TestWebKitAPI::TEST): (-[DidPlayMessageHandler initWithWKWebView:]): Deleted. (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added. 2016-07-28 Babak Shafiei Merge r203629. rdar://problem/27438936 2016-07-22 Wenson Hsieh Media controls should be displayed for media in media documents https://bugs.webkit.org/show_bug.cgi?id=160104 Reviewed by Myles C. Maxfield. Verifies that even a small video with audio in a media document gets media controls. * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): 2016-07-28 Babak Shafiei Merge r203622. rdar://problem/27495748 2016-07-22 Brady Eidson Removing IndexedDatabases that have stored blobs doesn't remove the blob files. https://bugs.webkit.org/show_bug.cgi?id=160089 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added. 2016-07-22 Babak Shafiei Merge r203545. rdar://problem/26964090 2016-07-21 Myles C. Maxfield Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute https://bugs.webkit.org/show_bug.cgi?id=160066 Reviewed by Dean Jackson. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Deleted. * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::SetUp): Deleted. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): Deleted. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): Deleted. 2016-07-22 Babak Shafiei Merge r203540. rdar://problem/26964090 2016-07-21 Myles C. Maxfield Follow-up patch to r203520 https://bugs.webkit.org/show_bug.cgi?id=159967 Unreviewed. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2016-07-22 Babak Shafiei Merge r203520. rdar://problem/26964090 2016-07-21 Myles C. Maxfield [iPhone] Playing a video on tudou.com plays only sound, no video https://bugs.webkit.org/show_bug.cgi?id=159967 Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson. Migrate tests to use new SPI. * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::SetUp): * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): 2016-07-22 Babak Shafiei Merge r203468. rdar://problem/27180657 2016-07-20 Wenson Hsieh Unreviewed iOS build fix. * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac. 2016-07-22 Babak Shafiei Merge r203464. rdar://problem/27180657 2016-07-20 Wenson Hsieh Media controls don't appear when pausing a small autoplaying video https://bugs.webkit.org/show_bug.cgi?id=159972 Reviewed by Beth Dakin. Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms for simulating basic user interaction in VideoControlsManager. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (-[WKWebView mouseDownAtPoint:]): (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): (-[OnLoadMessageHandler initWithWKWebView:handler:]): (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added. 2016-07-22 Babak Shafiei Merge r203447. rdar://problem/27056844 2016-07-20 Csaba Osztrogonác Unreviewed Mac cmake buildfix after r203426. Just for fun. * TestWebKitAPI/PlatformMac.cmake: 2016-07-22 Babak Shafiei Merge r203436. rdar://problem/27056844 2016-07-19 Alex Christensen Fix API test after r203426. https://bugs.webkit.org/show_bug.cgi?id=159949 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: (TEST): If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1. This is no problem. We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data. 2016-07-22 Babak Shafiei Merge r203429. rdar://problem/27056844 2016-07-19 Alex Christensen Add regression test for r203392 https://bugs.webkit.org/show_bug.cgi?id=159949 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: (fileSize): (swizzledBundleIdentifierWebBookmarksD): (defaultApplicationCacheDirectory): (TEST): (swizzledBundleIdentifierMobileSafari): Deleted. This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory. I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused problems with the static bools that are set once in RuntimeApplicationChecks.mm. 2016-07-22 Babak Shafiei Merge r203426. rdar://problem/27056844 2016-07-19 Alex Christensen Add regression test for r203392 https://bugs.webkit.org/show_bug.cgi?id=159949 Reviewed by Brady Eidson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: (TEST): (fileSize): (swizzledBundleIdentifierMobileSafari): (swizzledBundleIdentifierWebBookmarksD): (defaultApplicationCacheDirectory): * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h. * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm. * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed. * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed. 2016-07-22 Babak Shafiei Merge r203541. rdar://problem/27450825 2016-07-21 Chelsea Pugh [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later https://bugs.webkit.org/show_bug.cgi?id=159980 rdar://problem/27450825 Reviewed by Dan Bernstein. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added. (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell when our delegate has hit -dealloc. (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate, and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate will not be messaged. 2016-07-22 Babak Shafiei Merge r203478. rdar://problem/27411085 2016-07-20 Jeremy Jones Add API test for layout constraints after exit fullscreen https://bugs.webkit.org/show_bug.cgi?id=159900 Reviewed by Jon Lee. Added Fullscreen.LaytoutConstraints API test. Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731 This test compares layout constraints on the web view before and after fullscreen to make sure they are preserved. * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added. (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]): (TestWebKitAPI::TEST): 2016-07-22 Babak Shafiei Merge r203435. rdar://problem/27438734 2016-07-19 Andy Estes Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h https://bugs.webkit.org/show_bug.cgi?id=159956 Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h. (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]): Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter. * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h. 2016-07-21 Babak Shafiei Merge r203508. rdar://problem/27392691 2016-07-21 Yongjun Zhang WebBackForwardList's currentIndex could get out of bounds when filtering items. https://bugs.webkit.org/show_bug.cgi?id=159986 Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex to 0. Reviewed by Dan Bernstein. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added. (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): (TEST): 2016-07-20 Babak Shafiei Merge follow-up patch for rdar://problem/27360961. Reviewed by Chris Dumez. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-07-17 Sam Weinig [WebKit API] Add SPI to track multiple navigations caused by a single user gesture https://bugs.webkit.org/show_bug.cgi?id=159856 Reviewed by Dan Bernstein. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Add basic window.open implementation. (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]): Add basic navigation policy implementation which implements a rule where a user gesture is only allowed to open a single non-web URL, all others are dropped. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added. Add API for the new SPI. 2016-07-17 Yusuke Suzuki [JSC] Enable test262 module tests https://bugs.webkit.org/show_bug.cgi?id=159854 Reviewed by Saam Barati. Use --module-file instead. * Scripts/run-jsc-stress-tests: 2016-07-16 Chris Dumez Unreviewed, rolling out r203318. Regressed most JS Benchmarks on MacBook Air by ~2% (7% on SunSpider) Reverted changeset: "[JSC] Change some parameters based on a random search" https://bugs.webkit.org/show_bug.cgi?id=158514 http://trac.webkit.org/changeset/203318 2016-07-16 Chris Dumez Add move constructor / assignment operator to ListHashSet https://bugs.webkit.org/show_bug.cgi?id=159837 Reviewed by Darin Adler. Add API tests. * TestWebKitAPI/Tests/WTF/ListHashSet.cpp: (TestWebKitAPI::TEST): 2016-07-15 Benjamin Poulain [JSC] Change some parameters based on a random search https://bugs.webkit.org/show_bug.cgi?id=158514 Reviewed by Saam Barati. * Scripts/run-jsc-stress-tests: 2016-07-15 Jon Davis Changed the start page URL for WebKit Nightly builds. https://bugs.webkit.org/show_bug.cgi?id=159816 Reviewed by Timothy Hatcher. * WebKitLauncher/start.html: 2016-07-15 Per Arne Vollan Uninitialized variable in DIBPixelData can cause a dangerous memory write https://bugs.webkit.org/show_bug.cgi?id=159414 Reviewed by Brent Fulgham. Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash when the HDC parameter is invalid. * TestWebKitAPI/PlatformWin.cmake: * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added. (TestWebKitAPI::TEST): 2016-07-15 Carlos Garcia Campos [GTK] Add basic tabs support to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=159803 Reviewed by Sergio Villar Senin. It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser. * MiniBrowser/gtk/BrowserTab.c: Added. (titleChanged): (isLoadingChanged): (decidePolicy): (removeChildIfInfoBar): (loadChanged): (createInfoBarQuestionMessage): (tlsErrorsDialogResponse): (loadFailedWithTLSerrors): (permissionRequestDialogResponse): (decidePermissionRequest): (colorChooserRGBAChanged): (popoverColorClosed): (colorChooserRequestFinished): (runColorChooserCallback): (inspectorOpenedInWindow): (inspectorClosed): (browserTabSetProperty): (browserTabFinalize): (browser_tab_init): (browserTabConstructed): (browser_tab_class_init): (getInternalURI): (browser_tab_new): (browser_tab_get_web_view): (browser_tab_load_uri): (browser_tab_get_title_widget): (browser_tab_set_status_text): (browser_tab_toggle_inspector): (browser_tab_start_search): (browser_tab_stop_search): (browser_tab_add_accelerators): (fullScreenMessageTimeoutCallback): (browser_tab_enter_fullscreen): (browser_tab_leave_fullscreen): * MiniBrowser/gtk/BrowserTab.h: Added. * MiniBrowser/gtk/BrowserWindow.c: (getExternalURI): (browserWindowSetStatusText): (reloadOrStopCallback): (goBackCallback): (goForwardCallback): (settingsCallback): (webViewURIChanged): (browserWindowHistoryItemActivated): (browserWindowUpdateNavigationActions): (webViewCreate): (webViewEnterFullScreen): (webViewLeaveFullScreen): (webViewDecidePolicy): (browserWindowCanZoomIn): (browserWindowCanZoomOut): (browserWindowZoomIn): (browserWindowZoomOut): (scrollEventCallback): (faviconChanged): (webViewIsLoadingChanged): (defaultZoomCallback): (searchCallback): (newTabCallback): (toggleWebInspector): (reloadPage): (reloadPageIgnoringCache): (stopPageLoad): (loadHomePage): (editingCommandCallback): (insertImageCommandCallback): (insertLinkCommandCallback): (browserWindowSetupEditorToolbar): (browserWindowSwitchTab): (browserWindowTabAddedOrRemoved): (browser_window_init): (browserWindowConstructed): (browserWindowSaveSession): (browserWindowDeleteEvent): (browser_window_new): (browser_window_append_view): (browser_window_load_uri): (browser_window_load_session): (browser_window_set_background_color): (resetStatusText): Deleted. (activateUriEntryCallback): Deleted. (webViewTitleChanged): Deleted. (resetEntryProgress): Deleted. (browserWindowCreateBackForwardMenu): Deleted. (webViewReadyToShow): Deleted. (webViewLoadFailed): Deleted. (webViewMouseTargetChanged): Deleted. (browserWindowUpdateZoomActions): Deleted. (webViewZoomLevelChanged): Deleted. (updateUriEntryIcon): Deleted. (zoomInCallback): Deleted. (zoomOutCallback): Deleted. (toggleFullScreen): Deleted. (browserWindowEditingCommandToggleButtonSetActive): Deleted. (browserWindowFinalize): Deleted. (browser_window_class_init): Deleted. * MiniBrowser/gtk/BrowserWindow.h: * MiniBrowser/gtk/CMakeLists.txt: * MiniBrowser/gtk/main.c: (createBrowserTab): (aboutURISchemeRequestCallback): (main): (parseBackgroundColor): Deleted. 2016-07-14 Alex Christensen Allow RefPtrs of const RefCounted types https://bugs.webkit.org/show_bug.cgi?id=158269 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WTF/RefPtr.cpp: (TestWebKitAPI::TEST): (TestWebKitAPI::ConstRefCounted::create): (TestWebKitAPI::returnConstRefCountedRef): (TestWebKitAPI::returnRefCountedRef): 2016-07-13 Carlos Garcia Campos Test WTF.StringViewIterators is crashing since r203119 https://bugs.webkit.org/show_bug.cgi?id=159710 Reviewed by Darin Adler. There are two problems in the test case added in r203119. First is that it's testing StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a const reference to the string view member of the deleted CodePoints object. * TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::TEST): 2016-07-13 Daniel Bates [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it https://bugs.webkit.org/show_bug.cgi?id=159738 Reviewed by Dan Bernstein. The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be code signed if applicable. We should also copy this bundle into the PlugIns subdirectory of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the PlugIns subdirectory is the directory where loadable bundles of an app are expected to live. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle. 2016-07-13 Beth Dakin Attempted build fix. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 2016-07-12 Ryosuke Niwa REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker https://bugs.webkit.org/show_bug.cgi?id=159686 Reviewed by Chris Dumez. Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate. * WebKitTestRunner/TestController.cpp: (WTR::runOpenPanel): (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): 2016-07-13 Beth Dakin Add more candidate tests https://bugs.webkit.org/show_bug.cgi?id=159730 Reviewed by Tim Horton. This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds two new tests to that file. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added. * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm. (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed. 2016-07-13 Joanmarie Diggs AX: [ATK] spinbutton-crash.html fails https://bugs.webkit.org/show_bug.cgi?id=159723 Reviewed by Chris Fleizach. Implement support for AXDecrementButton and AXIncrementButton in ATK's AccessibilityUIElement::uiElementAttributeValue(). * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::uiElementAttributeValue): 2016-07-13 Carlos Alberto Lopez Perez [EFL] [GTK] Enable back crypto subtle on development builds. https://bugs.webkit.org/show_bug.cgi?id=159260 Reviewed by Carlos Garcia Campos. * Scripts/webkitperl/FeatureList.pm: 2016-07-12 Mark Lam We should use different stack limits for stack checks from JS and host code. https://bugs.webkit.org/show_bug.cgi?id=159442 Reviewed by Geoffrey Garen. In http://trac.webkit.org/r203067, we limited the amount of stack that tests will run with to keep stack overflow tests sane. Turns out, we also need to teach the LayoutTestRelay to pass env vars over to the iOS simulator. This is needed in order to keep the js/regress-139548.html test happy with this patch. Also fixed up run_webkit_tests.py to explicitly pass an int size value for the JSC_maxPerThreadStackUsage option. Otherwise, it will pass a float value. * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController _environmentVariables]): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (main): 2016-07-12 Filip Pizlo platformUserPreferredLanguages on Mac should not try to put the region into the language https://bugs.webkit.org/show_bug.cgi?id=159693 Rubber stamped by Alexey Proskuryakov. Revert the test change in r200105. * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: (TestWebKitAPI::languageForSystemLanguage): 2016-07-12 Chris Dumez [WK2] Protect against bad database data in LocalStorageDatabase::importItems() https://bugs.webkit.org/show_bug.cgi?id=159663 Reviewed by Benjamin Poulain. Add API test coverage. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added. (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]): (TEST): 2016-07-12 Myles C. Maxfield Relax ordering requirements on StringView::CodePoints iterator https://bugs.webkit.org/show_bug.cgi?id=159609 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::TEST): 2016-07-12 Youenn Fablet Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975 https://bugs.webkit.org/show_bug.cgi?id=159564 Reviewed by Brian Burg. * Scripts/webkitpy/codegen/main.py: (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers. 2016-07-12 Gyuyoung Kim Remove ENABLE_CSS3_TEXT_LINE_BREAK flag https://bugs.webkit.org/show_bug.cgi?id=159671 Reviewed by Csaba Osztrogonác. ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards. https://bugs.webkit.org/show_bug.cgi?id=89235 So this guard can be removed in build scripts. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-07-11 Jason Marcell SVN.create_patch should find svn-create-patch relative to the WebKit root. https://bugs.webkit.org/show_bug.cgi?id=159652 Reviewed by Daniel Bates. * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it. 2016-07-11 Myles C. Maxfield Implement grapheme cluster iterator on StringView https://bugs.webkit.org/show_bug.cgi?id=159598 Reviewed by Anders Carlsson. This is in preparation for honoring the second argument to FontFaceSet.load(). * TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::compareLoopIterations): (TestWebKitAPI::TEST): 2016-07-11 Nan Wang AX: WKWebView should have API to prevent pinch-to-zoom always being allowed https://bugs.webkit.org/show_bug.cgi?id=158364 Reviewed by Anders Carlsson. Added a function in TestRunner so that we can toggle the ignoring viewport scale limits setting. Also added a test option for that in order to change the configuration of the webview in test. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setNavigationGesturesEnabled): (WTR::TestRunner::setIgnoresViewportScaleLimits): (WTR::nextUIScriptCallbackID): * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): (WTR::updateTestOptionsFromTestHeader): (WTR::TestController::setNavigationGesturesEnabled): (WTR::TestController::setIgnoresViewportScaleLimits): (WTR::TestController::platformWillRunTest): * WebKitTestRunner/TestController.h: (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): 2016-07-11 Konstantin Tokarev [GTK] install-dependencies should not install packages built by jhbuild. https://bugs.webkit.org/show_bug.cgi?id=159628 Reviewed by Michael Catanzaro. * gtk/install-dependencies: Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig. 2016-07-11 Olivier Blin System proxy settings not used when building deps with jhbuild https://bugs.webkit.org/show_bug.cgi?id=159567 Reviewed by Michael Catanzaro. This adds the gsettings-desktop-schemas-devel build dep to enable the libgiognomeproxy.so gio module in glib-networking, which uses GSettings on org.gnome.system.proxy. This is needed to query system proxy settings for Gnome desktops. dconf can be manually added to jhbuild to build the libdconfsettings.so gio module for GSettings, so that libgiognomeproxy.so can access system settings. https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy As an alternative to dconf settings, this commit also adds the libproxy-devel build dep to enable the libgiolibproxy.so module in glib-networking (suggested by Fujii Hironori). It is useful to read proxy settings from environment variables. From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID environment variable to force using the envvar module in libproxy. * gtk/install-dependencies: 2016-07-11 Mark Lam Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing. https://bugs.webkit.org/show_bug.cgi?id=159524 Reviewed by Michael Saboff. Forced tests to run with only a 1.5M JS stack size instead of the default 4M. Also fixed up some tests to behave better to work with this new limit. This should make stack overflow tests complete sooner. * Scripts/run-jsc-stress-tests: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (main): 2016-07-11 Michael Catanzaro [GTK] Whitespace fixes in install-dependencies script Unreviewed. * gtk/install-dependencies: 2016-07-11 Michael Catanzaro [GTK] Install missing Fedora dependencies Unreviewed. * gtk/install-dependencies: 2016-07-09 Dan Bernstein Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode https://bugs.webkit.org/show_bug.cgi?id=159600 Reviewed by Daniel Bates. * Scripts/git-add-reviewer: Added the -s|--rubber-stamp option. (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the new option. 2016-07-08 Andy Estes [Content Filtering] Load blocked pages more like other error pages are loaded https://bugs.webkit.org/show_bug.cgi?id=159485 Reviewed by Brady Eidson. Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response to a content filtering provisional navigation failure is ignored in preference of ContentFilter's own error page. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]): (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]): (loadAlternateTest): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: (-[MockContentFilterEnabler initWithCoder:]): * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added. (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]): (TestWebKitAPI::loadAlternateTest): (TestWebKitAPI::TEST): 2016-07-08 Commit Queue Unreviewed, rolling out r202944. https://bugs.webkit.org/show_bug.cgi?id=159570 caused some tests to crash under GuardMalloc (Requested by estes on #webkit). Reverted changeset: "[Content Filtering] Load blocked pages more like other error pages are loaded" https://bugs.webkit.org/show_bug.cgi?id=159485 http://trac.webkit.org/changeset/202944 2016-07-08 Martin Robinson Remove mrobinson from the MathML watchlist https://bugs.webkit.org/show_bug.cgi?id=159559 Reviewed by Philippe Normand. * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist. 2016-07-08 Brady Eidson Clearing LocalStorage doesn't also delete -wal and -shm files. and https://bugs.webkit.org/show_bug.cgi?id=159566 Reviewed by Brent Fulgham. Also helpfully picked over by Andy "Never Forgets" Estes. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added. 2016-07-08 Konstantin Tokarev Removed Qt leftovers from Tools. https://bugs.webkit.org/show_bug.cgi?id=159557 Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Removed 'qt' platform config. * Scripts/webkitpy/common/net/bugzilla/bug.py: Deleted non-functional e-mail address. 2016-07-08 Commit Queue Unreviewed, rolling out r202967. https://bugs.webkit.org/show_bug.cgi?id=159556 This patch caused crashes in https tests on Windows (Requested by perarne on #webkit). Reverted changeset: "[Win] The test http/tests/security/contentSecurityPolicy /upgrade-insecure-requests/basic-upgrade.https.html is failing." https://bugs.webkit.org/show_bug.cgi?id=159510 http://trac.webkit.org/changeset/202967 2016-07-08 Youenn Fablet Generate WebCore builtin wrapper files https://bugs.webkit.org/show_bug.cgi?id=159461 Reviewed by Brian Burg. * Scripts/webkitpy/codegen/main.py: (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option. (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases. 2016-07-08 Hunseop Jeong [EFL] Fix build when media-stream is enabled. https://bugs.webkit.org/show_bug.cgi?id=159206 Bump up the openwebrtc to find the correct package. Reviewed by Gyuyoung Kim. * efl/jhbuild.modules: * efl/patches/openwebrtc-clang-warning-fix.patch: Removed. 2016-07-07 Per Arne Vollan [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing. https://bugs.webkit.org/show_bug.cgi?id=159510 Reviewed by Brent Fulgham. Allow any https certificate when running tests. * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): 2016-07-07 Beth Dakin API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra https://bugs.webkit.org/show_bug.cgi?id=159532 -and corresponding- rdar://problem/27177179 Reviewed by Tim Horton. * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]): 2016-07-07 Andy Estes [Content Filtering] Load blocked pages more like other error pages are loaded https://bugs.webkit.org/show_bug.cgi?id=159485 Reviewed by Brady Eidson. Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response to a content filtering provisional navigation failure is ignored in preference of ContentFilter's own error page. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]): (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]): (loadAlternateTest): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: (-[MockContentFilterEnabler initWithCoder:]): * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added. (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]): (TestWebKitAPI::loadAlternateTest): (TestWebKitAPI::TEST): 2016-07-07 Per Arne Vollan Unreviewed: add myself to the reviewers list. * Scripts/webkitpy/common/config/contributors.json: 2016-07-07 Per Arne Vollan [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing. https://bugs.webkit.org/show_bug.cgi?id=159509 Reviewed by Alex Christensen. We should always insert the url in the url map when identifierForInitialRequest is called. Otherwise we can end up with identifiers not having an entry in the url map when urls are written to the test output file. * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::identifierForInitialRequest): 2016-07-06 Tim Horton Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be https://bugs.webkit.org/show_bug.cgi?id=159498 Reviewed by Sam Weinig. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added. (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]): (expectLinkCount): (TEST): Add a test ensuring that ReferenceDate in the DataDetectors context is respected when deciding what to linkify. 2016-07-06 Alexey Proskuryakov Build fix - work around rdar://problem/27196668. * LayoutTestRelay/Configurations/Base.xcconfig: 2016-07-05 Per Arne Vollan Enhance Windows DRT implementation to support platform scroll wheel events. https://bugs.webkit.org/show_bug.cgi?id=36002 Reviewed by Brent Fulgham. Implement function continuousMouseScrollBy in Windows event sender. * DumpRenderTree/win/EventSender.cpp: (mouseScrollBy): (continuousMouseScrollBy): 2016-07-05 Myles C. Maxfield [Sierra] Rebaseline tests to use un-mocked system font metrics https://bugs.webkit.org/show_bug.cgi?id=159311 Reviewed in person by Alexey Proskuryakov. Stop mocking the system font on Sierra. * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): 2016-07-05 Brady Eidson Database process crashes deleting a corrupt SQLite database file (null deref). https://bugs.webkit.org/show_bug.cgi?id=155506. Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added. 2016-07-05 Alexey Proskuryakov run-webkit-tests should print more complete baseline search paths https://bugs.webkit.org/show_bug.cgi?id=159354 Reviewed by Daniel Bates. run-webkit-tests used to only print directory names in baseline search paths. This was ok in basic usage, but quickly got confusing when using --additional-platform-directory flags. * Scripts/webkitpy/layout_tests/views/printing.py: (Printer.print_config): * Scripts/webkitpy/layout_tests/views/printing_unittest.py: (Testprinter.test_print_config): (Testprinter.test_print_one_line_summary): 2016-07-04 Brady Eidson WebProcesses don't handle DatabaseProcess going away uncleanly.. https://bugs.webkit.org/show_bug.cgi?id=159371 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added. (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]): 2016-07-04 Carlos Alberto Lopez Perez [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04 https://bugs.webkit.org/show_bug.cgi?id=158141 Rubber-stamped by Michael Catanzaro. Instead of checking for an specific Ubuntu version, query the apt database to see which version of PHP is available. * efl/install-dependencies: * gtk/install-dependencies: 2016-07-04 Fujii Hironori webkit-patch failure-reason always raises TypeError https://bugs.webkit.org/show_bug.cgi?id=159394 Reviewed by Benjamin Poulain. In r170637 (Bug 133067), the first and second arguments of pluralize were swapped. * Scripts/webkitpy/tool/commands/queries.py: (FailureReason._builder_to_explain): Swap the first and second arguments of pluralize. 2016-07-02 Youenn Fablet Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd https://bugs.webkit.org/show_bug.cgi?id=152486 Reviewed by Daniel Bates. Add launch of web-platform-tests server by run-webkit-httpd. Add two options to disable starting httpd and web-platform-tests servers. * Scripts/run-webkit-httpd: (parse_args): (main): 2016-07-01 Myles C. Maxfield REGRESSION(r189668): Notification tests are flakey https://bugs.webkit.org/show_bug.cgi?id=159375 Reviewed by Alexey Proskuryakov. Notifications are objects which must exist in both the UI Process and the Web Process. Each process identifies a notification object by a unique ID. When the Web Process sends a message regarding a notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended. Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message to the UI process, to handle the simulated click. However, that RPC didn't perform the same local -> global notification ID mapping, causing the wrong notification to be investigated. The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to manually perform this same mapping. Luckily, this object already receives callbacks every time a notification is created or destroyed. However, because this object is implemented outside WebKit, it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore, this patch adds a private testing function which returns this internal ID. Once given this intenal ID, WebNotificationProvider can properly map between the different IDs. * WebKitTestRunner/TestController.cpp: (WTR::TestController::runTestingServerLoop): (WTR::TestController::simulateWebNotificationClick): * WebKitTestRunner/WebNotificationProvider.cpp: (WTR::WebNotificationProvider::showWebNotification): (WTR::removeGlobalIDFromIDMap): (WTR::WebNotificationProvider::closeWebNotification): (WTR::WebNotificationProvider::removeNotificationManager): (WTR::WebNotificationProvider::simulateWebNotificationClick): (WTR::WebNotificationProvider::reset): * WebKitTestRunner/WebNotificationProvider.h: 2016-07-01 Alexey Proskuryakov Simplify LayoutTestRelay https://bugs.webkit.org/show_bug.cgi?id=159353 Reviewed by Daniel Bates. 1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it by name and runtime makes no sense. 2. Removed code to create devices, webkitpy always does this in advance. 3. Don't create copies of testing apps - we can install the same one into each simulator, now that we don't run multiple tester processes in a single simulator. 4. Pass information on how to find I/O pipes via environment, not via Info.plist. 5. Removed code that kept testing apps alive in the background. 6. Slightly updated coding style in functions that I touched. * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Updated for what we acually use at this point. * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]): (-[LTRelayController ipcIdentifier]): (-[LTRelayController processName]): (-[LTRelayController didReceiveStdoutData:]): (-[LTRelayController didCrashWithMessage:]): (-[LTRelayController installApp]): (-[LTRelayController _environmentVariables]): (-[LTRelayController launchApp]): (-[LTRelayController start]): (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted. (-[LTRelayController uniqueAppPath]): Deleted. (-[LTRelayController uniqueAppURL]): Deleted. (-[LTRelayController uniqueAppIdentifier]): Deleted. (-[LTRelayController createUniqueApp]): Deleted. * LayoutTestRelay/LayoutTestRelay/main.m: (usage): (getRequiredStringArgument): (main): (getTestingSimDevice): Deleted. * Scripts/webkitpy/port/driver.py: (IOSSimulatorDriver.cmd_line): * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformInitialize): * WebKitTestRunner/ios/mainIOS.mm: (-[WebKitTestRunnerApp applicationDidEnterBackground:]): * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): (-[DumpRenderTree applicationDidEnterBackground:]): 2016-07-01 Konstantin Tokarev [cmake] Build TestNetscapePlugin only if NPAPI is enabled. https://bugs.webkit.org/show_bug.cgi?id=159344 Reviewed by Alex Christensen. * DumpRenderTree/CMakeLists.txt: 2016-07-01 Youenn Fablet Add a runtime flag for DOM iterators https://bugs.webkit.org/show_bug.cgi?id=159300 Reviewed by Alex Christensen. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): * Scripts/webkitperl/FeatureList.pm: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setDOMIteratorEnabled): * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-06-30 Tina Liu Add an API test for WKPageRestoreFromSessionStateWithoutNavigation. https://bugs.webkit.org/show_bug.cgi?id=159326 Reviewed by Brady Eidson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added. (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::didChangeBackForwardListForPage): (TestWebKitAPI::setPageLoaderClient): Set the page loader client and register for didFinishLoadForFrame and didChangeBackForwardList callbacks. (TestWebKitAPI::createSessionStateData): Load a webpage ("simple.html") and return the session state for this page. (TestWebKitAPI::TEST): Restore the page session state with that of "simple.html" without navigation. Verify that the committed URL is NULL since there's no navigation involved. Verify that the current item in the back forward list, which should be what we restored from the session state, has the expected URL. 2016-06-29 Filip Pizlo Generators violate bytecode liveness validation https://bugs.webkit.org/show_bug.cgi?id=159279 Reviewed by Yusuke Suzuki. Add Basic to our test harness. * Scripts/run-javascriptcore-tests: (runJSCStressTests): 2016-06-30 Per Arne Vollan [Win][Debug] Assertion fails in TestWTF. https://bugs.webkit.org/show_bug.cgi?id=159299 Reviewed by Alex Christensen. The assert in the & operator in the UniqueRef class fails, because the instance has been moved. The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing the assertion failure. Since the variable is actually used, there is no need to use the UNUSED_PARAM macro. * TestWebKitAPI/Tests/WTF/UniqueRef.cpp: (TestWebKitAPI::TEST): 2016-06-30 Youenn Fablet LayoutTests intermittently failing to run due to issues starting Web Platform Test server https://bugs.webkit.org/show_bug.cgi?id=159166 Reviewed by Alexey Proskuryakov. Setting the certificate directory to the copied config.json. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (WebPlatformTestServer._copy_webkit_test_files): 2016-06-29 Mark Lam Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option. https://bugs.webkit.org/show_bug.cgi?id=159274 Reviewed by Keith Miller. * DumpRenderTree/mac/DumpRenderTree.mm: (DumpRenderTreeMain): 2016-06-29 Alex Christensen WKWebView should ask WKNavigationDelegate about bad ssl certificates https://bugs.webkit.org/show_bug.cgi?id=159176 Reviewed by Sam Weinig. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]): (-[WK2BrowserWindowController webView:didFailNavigation:withError:]): 2016-06-29 Carlos Alberto Lopez Perez [GTK] Add missing install dependency after r202619 https://bugs.webkit.org/show_bug.cgi?id=156716 Unreviewed. * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian. 2016-06-29 Carlos Alberto Lopez Perez [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment. https://bugs.webkit.org/show_bug.cgi?id=156716 Reviewed by Carlos Garcia Campos and Michael Catanzaro. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland (parse_args): * Scripts/webkitpy/port/gtk.py: (GtkPort.__init__): (GtkPort._driver_class): (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests. (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional platform directory for storing the wayland specific layout test results and expectations for ${port}. For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific test expectations file on the GTK port when running the tests with the --wayland command line switch. Baseline search path: gtk-wayland -> gtk -> wk2 -> generic. * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb. (WestonDriver.check_driver): (WestonDriver.__init__): (WestonDriver._start): * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver. (WestonXvfbDriverDisplayTest): (WestonXvfbDriverDisplayTest.__init__): (WestonXvfbDriverDisplayTest._xvfb_run): (WestonDriverTest.make_driver): (WestonDriverTest.test_start): * gtk/install-dependencies: Add the new dependencies that are required for either building weston, or to satisfy the pkg-config check of the new added modules in JHBuild. * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones provided by the system are already new enough. Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one. It was the only way to get the software EGL rasterizer working without depending on user drivers. Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config feature to avoid building libdrm when the one provided by the system is new enough. * gtk/jhbuildrc: * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added. Xorg had no support for searching the DRI drivers on a custom path at runtime. This patch implements support for that reusing the same variable that we use with Mesa to set the custom path for the DRI drivers path. 2016-06-29 Alejandro G. Castro [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes https://bugs.webkit.org/show_bug.cgi?id=159256 Reviewed by Philippe Normand. We need the last fixes in the repository to make the scream queue work with apprtc. * gtk/jhbuild.modules: 2016-06-28 Commit Queue Unreviewed, rolling out r202580. https://bugs.webkit.org/show_bug.cgi?id=159245 Caused all WKTR tests to fail on GuardMalloc and Production only for unknown reasons, investigating offline. (Requested by brrian on #webkit). Reverted changeset: "RunLoop::Timer should use constructor templates instead of class templates" https://bugs.webkit.org/show_bug.cgi?id=159153 http://trac.webkit.org/changeset/202580 2016-06-28 Srinivasan Vijayaraghavan Use a regex to check if a test step is for JavaScriptCore https://bugs.webkit.org/show_bug.cgi?id=159224 Reviewed by Geoffrey Garen. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration.prototype._parseData): Replace array membership test with regex test. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test. 2016-06-28 Michael Saboff btjs no longer accepts optional frame count argument https://bugs.webkit.org/show_bug.cgi?id=159235 Reviewed by Saam Barati. Fix the detection of optional backtrace-depth parameter to use the length of the command. * lldb/lldb_webkit.py: (btjs): 2016-06-28 Jon Lee Update animometer.plan Rubber-stamped by Said Abou-Hallawa. * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601. 2016-06-28 Filip Pizlo Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know. * Scripts/run-javascriptcore-tests: (runJSCStressTests): 2016-06-28 Brian Burg RunLoop::Timer should use constructor templates instead of class templates https://bugs.webkit.org/show_bug.cgi?id=159153 Reviewed by Alex Christensen. Remove the RunLoop::Timer class template argument, and pass its constructor a reference to `this` instead of a pointer to `this`. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::TestRunner): * WebKitTestRunner/InjectedBundle/TestRunner.h: * TestWebKitAPI/Tests/WTF/RunLoop.cpp: (TestWebKitAPI::TEST): 2016-06-28 Ryosuke Niwa REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed https://bugs.webkit.org/show_bug.cgi?id=159199 Reviewed by Alexey Proskuryakov. Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac. * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from an input element getting automatically focused on Mac. 2016-06-28 Per Arne Vollan [Win] Custom elements tests are failing. https://bugs.webkit.org/show_bug.cgi?id=159139 Reviewed by Alex Christensen. Enable custom element API when running tests. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): 2016-06-27 Lucas Forschler Test commit. Please ignore. 2016-06-27 Michael Catanzaro [GTK][EFL] Disable subtle-crypto in FeatureList.pm https://bugs.webkit.org/show_bug.cgi?id=155073 Reviewed by Daniel Bates. * Scripts/webkitperl/FeatureList.pm: 2016-06-27 Simon Fraser [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting https://bugs.webkit.org/show_bug.cgi?id=159077 Reviewed by Tim Horton. Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp. Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process, which is necessary for UI-side compositing. Add some null checks to fix issues when the WKWebView gets resized to be empty, which seems to happen for some tests that call window.resizeTo(). * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Deleted. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dumpResults): * WebKitTestRunner/cg/TestInvocationCG.cpp: (WTR::createCGContextFromImage): (WTR::computeMD5HashStringForContext): (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::windowSnapshotImage): 2016-06-27 Gyuyoung Kim [EFL] Support to build on Debian linux https://bugs.webkit.org/show_bug.cgi?id=159123 Reviewed by Antonio Gomes. * efl/install-dependencies: Install libgnutls28-dev. 2016-06-27 Alex Christensen Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess https://bugs.webkit.org/show_bug.cgi?id=159071 Reviewed by Brady Eidson. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setHandlesAuthenticationChallenges): (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace): (WTR::TestRunner::setAuthenticationUsername): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::didFinishNavigation): (WTR::TestController::canAuthenticateAgainstProtectionSpace): (WTR::TestController::didReceiveAuthenticationChallenge): (WTR::TestController::didCommitNavigation): * WebKitTestRunner/TestController.h: (WTR::TestController::setBlockAllPlugins): (WTR::TestController::setShouldLogHistoryClientCallbacks): (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace): (WTR::TestController::isCurrentInvocation): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations. 2016-06-27 Per Arne Vollan [Win] The test fast/events/wheel-event-outside-body.html is timing out. https://bugs.webkit.org/show_bug.cgi?id=159129 Reviewed by Alex Christensen. Implement the function mouseScrollBy in the Windows event sender. * DumpRenderTree/win/EventSender.cpp: (mouseScrollBy): (mouseScrollByWithWheelAndMomentumPhasesCallback): 2016-06-25 Filip Pizlo REGRESSION: Weak symbol warning when linking TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=159104 Reviewed by Dan Bernstein. This uses a better approach to turn on -fvisility=hidden. All of the other projects set this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;". * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here. * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461. 2016-06-25 Per Arne Vollan [Win] The test fast/events/wheel-event-destroys-frame.html is timing out. https://bugs.webkit.org/show_bug.cgi?id=159086 Reviewed by Alex Christensen. Implement required wheel event function in event sender. * DumpRenderTree/win/EventSender.cpp: (mouseScrollByWithWheelAndMomentumPhasesCallback): 2016-06-24 Filip Pizlo REGRESSION: Weak symbol warning when linking TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=159104 Reviewed by Mark Lam. The problem is that the tests were not compiled with -fvisibility=hidden like the rest of WK. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 2016-06-24 David Kilzer parser_unittests.pl should not hardcode list of tests Reviewed by Daniel Bates. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Update to read the list of tests from the 'resources' directory, and instead map file extensions to subroutine names. Switch to use File::Basename::fileparse() to get basename and file extension for each test. (readTestFiles): Added. Reads files from the directory passed in and ignores: hidden files, anything that isn't a plain file, and expected test results files. 2016-06-23 Simon Fraser Fix Windows build. * DumpRenderTree/cg/PixelDumpSupportCG.cpp: * DumpRenderTree/cg/PixelDumpSupportCG.h: 2016-06-23 Gyuyoung Kim [EFL] Change download path of libxslt Unreviewed EFL build fix. In Korea current download path can't be accessed. Change it. * efl/jhbuild.modules: 2016-06-23 Simon Fraser https://bugs.webkit.org/show_bug.cgi?id=159077 Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably snapshot the final state of the test in release builds. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): 2016-06-23 Simon Fraser Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing. * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (createBitmapContextFromWebView): * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::windowSnapshotImage): 2016-06-23 Simon Fraser [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting https://bugs.webkit.org/show_bug.cgi?id=159077 Reviewed by Tim Horton. Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer. This allows them to capture compositing layers in snapshots, rather than doing a software paint, thus enabling testing of more things. * DumpRenderTree/cg/PixelDumpSupportCG.cpp: (createBitmapContext): Moved to this file to share it. * DumpRenderTree/cg/PixelDumpSupportCG.h: * DumpRenderTree/ios/PixelDumpSupportIOS.mm: (createBitmapContextFromWebView): (BitmapContext::createFromUIImage): Deleted. (BitmapContext::pixelData): Deleted. (BitmapContext::BitmapContext): Deleted. (computeMD5HashStringForBitmapContext): Deleted. (dumpBitmap): Deleted. * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp. * DumpRenderTree/mac/PixelDumpSupportMac.mm: (createPagedBitmapContext): (createBitmapContext): Deleted. * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Deleted. * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::windowSnapshotImage): 2016-06-23 Konstantin Tokarev [jhbuild] Added libxslt module. https://bugs.webkit.org/show_bug.cgi?id=159034 Unreviewed, followup for r202373. * efl/install-dependencies: Removed libxslt * gtk/install-dependencies: Ditto. 2016-06-23 Gyuyoung Kim [EFL] Bump gstreamer version from 1.6.3 to 1.8.0 https://bugs.webkit.org/show_bug.cgi?id=159050 Reviewed by Antonio Gomes. To be sync with GTK port, this patch bumps gstreamer version for EFL port. * efl/jhbuild.modules: * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added. * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added. 2016-06-23 Konstantin Tokarev [jhbuild] Added libxslt module. https://bugs.webkit.org/show_bug.cgi?id=159034 Reviewed by Michael Catanzaro. * efl/jhbuild.modules: * gtk/jhbuild.modules: 2016-06-22 Per Arne Vollan [Win] Use Windows api function to find top level parent. https://bugs.webkit.org/show_bug.cgi?id=159021 Reviewed by Brent Fulgham. Delete findTopLevelParent function, and use Win32 function GetAncestor instead. * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::runModal): (findTopLevelParent): Deleted. * MiniBrowser/win/PrintWebUIDelegate.cpp: (PrintWebUIDelegate::runModal): (findTopLevelParent): Deleted. 2016-06-22 Per Arne Vollan [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out. https://bugs.webkit.org/show_bug.cgi?id=158934 Reviewed by Brent Fulgham. DumpRenderTree should also delete indexed databases when clearAllDatabases() is called. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllDatabases): 2016-06-22 Saam Barati run-javascriptcore-tests should have some environment variables for commonly used settings https://bugs.webkit.org/show_bug.cgi?id=159047 Reviewed by Keith Miller. This patch adds three environment variables that run-javascriptcore-tests consults: - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It determines if we should run the api tests or not. - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It determines if we will perform a build or not before running the tests. to set the default should-build setting. - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to a yaml file. If set, we will run the extra tests it refers to. All the values in these environment variables will be overridden if an option is explicitly passed in. For example, the following will run the api tests: `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi` * Scripts/run-javascriptcore-tests: 2016-06-22 Saam barati TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT https://bugs.webkit.org/show_bug.cgi?id=159037 Reviewed by Benjamin Poulain. Run typeProfiler.yaml tests under an additional CJIT enabled mode. * Scripts/run-jsc-stress-tests: 2016-06-22 Aakash Jain Fix style issues in webkitpy https://bugs.webkit.org/show_bug.cgi?id=159019 Reviewed by Daniel Bates. Fixed the formatting issues as reported by check-webkit-style in webkitpy. There is no functionality change. Only affected file names retained below for brevity. * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: * Scripts/webkitpy/benchmark_runner/utils.py: * Scripts/webkitpy/common/checkout/changelog.py: * Scripts/webkitpy/common/checkout/changelog_unittest.py: * Scripts/webkitpy/common/checkout/checkout.py: * Scripts/webkitpy/common/checkout/checkout_mock.py: * Scripts/webkitpy/common/checkout/checkout_unittest.py: * Scripts/webkitpy/common/checkout/commitinfo.py: * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: * Scripts/webkitpy/common/checkout/scm/scm.py: * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: * Scripts/webkitpy/common/config/committers_unittest.py: * Scripts/webkitpy/common/config/irc.py: * Scripts/webkitpy/common/config/ports.py: * Scripts/webkitpy/common/config/ports_unittest.py: * Scripts/webkitpy/common/config/urls.py: * Scripts/webkitpy/common/host_mock.py: * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: * Scripts/webkitpy/common/net/buildbot/buildbot.py: * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: * Scripts/webkitpy/common/net/credentials_unittest.py: * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: * Scripts/webkitpy/common/net/networktransaction_unittest.py: * Scripts/webkitpy/common/net/statusserver.py: * Scripts/webkitpy/common/system/autoinstall.py: * Scripts/webkitpy/common/system/crashlogs_unittest.py: * Scripts/webkitpy/common/system/executive.py: * Scripts/webkitpy/common/system/executive_mock.py: * Scripts/webkitpy/common/system/executive_unittest.py: * Scripts/webkitpy/common/system/filesystem_mock.py: * Scripts/webkitpy/common/system/filesystem_unittest.py: * Scripts/webkitpy/common/system/logutils_unittest.py: * Scripts/webkitpy/common/system/path.py: * Scripts/webkitpy/common/system/path_unittest.py: * Scripts/webkitpy/common/system/platforminfo.py: * Scripts/webkitpy/common/system/user.py: * Scripts/webkitpy/common/system/user_unittest.py: * Scripts/webkitpy/common/system/workspace_unittest.py: * Scripts/webkitpy/common/thread/threadedmessagequeue.py: * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: * Scripts/webkitpy/layout_tests/controllers/manager.py: * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: * Scripts/webkitpy/layout_tests/models/test_configuration.py: * Scripts/webkitpy/layout_tests/models/test_expectations.py: * Scripts/webkitpy/layout_tests/models/test_failures.py: * Scripts/webkitpy/layout_tests/models/test_run_results.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: * Scripts/webkitpy/layout_tests/views/printing.py: * Scripts/webkitpy/performance_tests/perftestsrunner.py: * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: * Scripts/webkitpy/port/base_unittest.py: * Scripts/webkitpy/port/driver.py: * Scripts/webkitpy/port/driver_unittest.py: * Scripts/webkitpy/port/factory.py: * Scripts/webkitpy/port/gtk.py: * Scripts/webkitpy/port/server_process_unittest.py: * Scripts/webkitpy/port/test.py: * Scripts/webkitpy/port/win.py: * Scripts/webkitpy/style/checker.py: * Scripts/webkitpy/style/checkers/common_unittest.py: * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: * Scripts/webkitpy/style/checkers/js.py: * Scripts/webkitpy/style/checkers/jsonchecker.py: * Scripts/webkitpy/style/checkers/png.py: * Scripts/webkitpy/style/checkers/text.py: * Scripts/webkitpy/style/checkers/text_unittest.py: * Scripts/webkitpy/style/error_handlers.py: * Scripts/webkitpy/style/filter.py: * Scripts/webkitpy/style/filter_unittest.py: * Scripts/webkitpy/style/optparser.py: * Scripts/webkitpy/style/optparser_unittest.py: * Scripts/webkitpy/test/main.py: * Scripts/webkitpy/w3c/test_converter.py: * Scripts/webkitpy/w3c/test_converter_unittest.py: * Scripts/webkitpy/w3c/test_importer_unittest.py: * Scripts/webkitpy/xcode/simulator.py: 2016-06-22 Brady Eidson DatabaseProcess doesn't handle WebProcesses going away uncleanly. https://bugs.webkit.org/show_bug.cgi?id=158894 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: 2016-06-22 Jon Lee Update animometer.plan https://bugs.webkit.org/show_bug.cgi?id=159012 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318. 2016-06-22 Youenn Fablet W3C test importer should generate files to ignore by WebKit SCM https://bugs.webkit.org/show_bug.cgi?id=142743 Reviewed by Darin Adler. TestDownloader generates the .gitignore file according submodules git repository information. TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options. * Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader.generate_gitignore): Generating .gitignore according submodules description. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option. (TestImporter): (TestImporter.write_init_py): Writing not empty __init__.py files. (TestImporter.import_tests): Using of write_init_py. * Scripts/webkitpy/w3c/test_importer_unittest.py: (TestImporterTest.test_git_ignore_generation): Added .gitignore test. (TestImporterTest): (TestImporterTest.test_initpy_generation): Added __init__.py test. 2016-06-21 Sam Weinig WKWebView with no WKNavigationDelegate does not follow universal links https://bugs.webkit.org/show_bug.cgi?id=158997 Reviewed by Dan Bernstein. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added. Add a new test that shows that we have a default navigation delegate by swizzling -[NSWorkspace openURL:]. This will only be called if there is a default client. 2016-06-22 Per Arne Vollan [Win] Implement modal dialog support in MiniBrowser. https://bugs.webkit.org/show_bug.cgi?id=158976 Reviewed by Brent Fulgham. * MiniBrowser/win/PrintWebUIDelegate.cpp: (PrintWebUIDelegate::createWebViewWithRequest): (getHandleFromWebView): (PrintWebUIDelegate::webViewClose): (PrintWebUIDelegate::setFrame): (PrintWebUIDelegate::webViewFrame): (PrintWebUIDelegate::canRunModal): (findTopLevelParent): (PrintWebUIDelegate::runModal): (PrintWebUIDelegate::createModalDialog): * MiniBrowser/win/PrintWebUIDelegate.h: (PrintWebUIDelegate::webViewClose): (PrintWebUIDelegate::setFrame): (PrintWebUIDelegate::webViewFrame): (PrintWebUIDelegate::canRunModal): (PrintWebUIDelegate::runModal): 2016-06-22 Per Arne Vollan window.showModalDialog doesn't work in DumpRenderTree on Windows https://bugs.webkit.org/show_bug.cgi?id=53675 Reviewed by Brent Fulgham. Implement modal dialog support in DumpRenderTree. * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::canRunModal): (getHandleFromWebView): (UIDelegate::createModalDialog): (findTopLevelParent): (UIDelegate::runModal): (UIDelegate::webViewClose): * DumpRenderTree/win/UIDelegate.h: 2016-06-21 Aakash Jain Fix formatting issues reported by check-webkit-style https://bugs.webkit.org/show_bug.cgi?id=159008 Reviewed by Alexey Proskuryakov. Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder. There is no functionality change. * Scripts/webkitpy/tool/bot/irc_command.py: (Restart.execute): (Rollout): * Scripts/webkitpy/tool/bot/ircbot_unittest.py: (IRCBotTest.test_exception_during_command): (IRCBotTest.test_exception_during_command.CommandWithException): (IRCBotTest.test_exception_during_command.CommandWithException.execute): * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: (test_missing_unit_test_results_path): (test_layout_test_results): * Scripts/webkitpy/tool/bot/queueengine.py: * Scripts/webkitpy/tool/bot/queueengine_unittest.py: * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: (AbstractSequencedCommand): (AbstractSequencedCommand.__init__): * Scripts/webkitpy/tool/commands/download.py: (Land): * Scripts/webkitpy/tool/commands/openbugs.py: * Scripts/webkitpy/tool/commands/openbugs_unittest.py: (OpenBugsTest): * Scripts/webkitpy/tool/commands/queries.py: (PatchesToCommitQueue): (PatchesToCommitQueue.__init__): (PatchesToCommitQueue._needs_commit_queue): * Scripts/webkitpy/tool/commands/queries_unittest.py: (PrintExpectationsTest.test_platform): (PrintBaselinesTest): (PrintBaselinesTest.setUp): * Scripts/webkitpy/tool/commands/queues.py: (AbstractQueue): (AbstractQueue.__init__): (AbstractQueue.execute): * Scripts/webkitpy/tool/commands/queues_unittest.py: (test_auto_retry): * Scripts/webkitpy/tool/commands/rebaseline.py: (AbstractParallelRebaselineCommand._files_to_add): (AbstractParallelRebaselineCommand): (AbstractParallelRebaselineCommand._rebaseline): * Scripts/webkitpy/tool/commands/setupgitclone.py: (SetupGitClone): * Scripts/webkitpy/tool/commands/sheriffbot.py: * Scripts/webkitpy/tool/commands/stepsequence.py: * Scripts/webkitpy/tool/commands/upload.py: (PostCommits._comment_text_for_commit): (PostCommits): (PostCommits.execute): (MarkBugFixed): (MarkBugFixed.__init__): * Scripts/webkitpy/tool/commands/upload_unittest.py: (UploadCommandsTest): (UploadCommandsTest.test_commit_message_for_current_diff): * Scripts/webkitpy/tool/grammar_unittest.py: (GrammarTest): (GrammarTest.test_join_with_separators): * Scripts/webkitpy/tool/multicommandtool.py: (HelpCommand.__init__): (HelpCommand): (HelpCommand._help_epilog): (HelpCommand._remove_help_options): (MultiCommandTool): (MultiCommandTool.__init__): (MultiCommandTool.main): * Scripts/webkitpy/tool/multicommandtool_unittest.py: (TrivialCommand): (TrivialCommand.__init__): (MultiCommandToolTest): (MultiCommandToolTest._assert_tool_main_outputs): (MultiCommandToolTest.test_retry): (test_command_help): * Scripts/webkitpy/tool/steps/__init__.py: * Scripts/webkitpy/tool/steps/abstractstep.py: * Scripts/webkitpy/tool/steps/applypatch.py: * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py: (ApplyPatchWithLocalCommit): (ApplyPatchWithLocalCommit.options): * Scripts/webkitpy/tool/steps/build.py: * Scripts/webkitpy/tool/steps/checkstyle.py: (CheckStyle): (CheckStyle.options): * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py: * Scripts/webkitpy/tool/steps/closebug.py: * Scripts/webkitpy/tool/steps/closebugforlanddiff.py: * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: (CloseBugForLandDiffTest): (CloseBugForLandDiffTest.test_empty_state): * Scripts/webkitpy/tool/steps/closepatch.py: * Scripts/webkitpy/tool/steps/commit.py: (Commit.run): * Scripts/webkitpy/tool/steps/confirmdiff.py: * Scripts/webkitpy/tool/steps/editchangelog.py: * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py: * Scripts/webkitpy/tool/steps/metastep.py: (MetaStep): (MetaStep.__init__): (MetaStep.run): * Scripts/webkitpy/tool/steps/obsoletepatches.py: * Scripts/webkitpy/tool/steps/options.py: (Options): * Scripts/webkitpy/tool/steps/postdiff.py: * Scripts/webkitpy/tool/steps/postdiffforcommit.py: * Scripts/webkitpy/tool/steps/postdiffforrevert.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: (PrepareChangeLogTest): (PrepareChangeLogTest.test_resolve_existing_entry): * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: * Scripts/webkitpy/tool/steps/promptforbugortitle.py: * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py: * Scripts/webkitpy/tool/steps/revertrevision.py: * Scripts/webkitpy/tool/steps/runtests.py: * Scripts/webkitpy/tool/steps/runtests_unittest.py: * Scripts/webkitpy/tool/steps/steps_unittest.py: (StepsTest): (StepsTest._step_options): * Scripts/webkitpy/tool/steps/update.py: * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: (UpdateChangeLogsWithReviewerTest): (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug): * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: * Scripts/webkitpy/tool/steps/validatereviewer.py: 2016-06-21 Chris Dumez Unreviewed, rolling out r202296. Broke basic browsing in Safari Reverted changeset: "WKWebView with no WKNavigationDelegate does not follow universal links" https://bugs.webkit.org/show_bug.cgi?id=158997 http://trac.webkit.org/changeset/202296 2016-06-21 Anders Carlsson Fix build. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-06-21 Anders Carlsson Begin moving the Apple Pay code to the open source repository https://bugs.webkit.org/show_bug.cgi?id=158998 Reviewed by Tim Horton. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLE_PAY. 2016-06-21 Said Abou-Hallawa Add system tracing points for requestAnimationFrame() workflow https://bugs.webkit.org/show_bug.cgi?id=158723 Reviewed by Simon Fraser. Add new plist entries to be used by kdebug_trace() viewing tools. * Tracing/SystemTracePoints.plist: 2016-06-21 Sam Weinig WKWebView with no WKNavigationDelegate does not follow universal links https://bugs.webkit.org/show_bug.cgi?id=158997 Reviewed by Dan Bernstein. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added. Add a new test that shows that we have a default navigation delegate by swizzling -[NSWorkspace openURL:]. This will only be called if there is a default client. 2016-06-21 Aakash Jain run-javascriptcore-tests should have flag to skip mozilla tests https://bugs.webkit.org/show_bug.cgi?id=158963 rdar://problem/25838924 Reviewed by Alexey Proskuryakov. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Added flag to skip mozilla tests. 2016-06-20 Commit Queue Unreviewed, rolling out r202136. https://bugs.webkit.org/show_bug.cgi?id=158932 JSBench wasn't regressed by r202002 and r202111 on iOS after all (Requested by rniwa_ on #webkit). Reverted changeset: "Unreviewed, rolling out r202002 and r202111." https://bugs.webkit.org/show_bug.cgi?id=158638 http://trac.webkit.org/changeset/202136 2016-06-20 Keith Rollin Remove RefPtr::release() and change calls sites to use WTFMove() https://bugs.webkit.org/show_bug.cgi?id=158369 Reviewed by Chris Dumez. RefPtr::release() releases its managed pointer awkwardly. It's more direct and clearer to use WTFMove to transfer ownership of the managed pointer. As part of this cleanup, also change a lot of explicit data types to 'auto'. * DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView): (createPagedBitmapContext): * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setMockGeolocationPosition): * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): 2016-06-20 Tim Horton Add a API test for *DeferringViewInWindowChanges as fixed in r202230 https://bugs.webkit.org/show_bug.cgi?id=158947 Reviewed by Simon Fraser. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added. (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::setPageLoaderClient): (TestWebKitAPI::TEST): Add a test ensuring that in-window state changes are deferred when using the SPI for deferring them, as fixed in r202230. 2016-06-20 Fujii Hironori WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE" https://bugs.webkit.org/show_bug.cgi?id=158931 Reviewed by Alexey Proskuryakov. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line. 2016-06-17 Alexey Proskuryakov Add test expectations for macOS Sierra https://bugs.webkit.org/show_bug.cgi?id=158903 Reviewed by Alex Christensen. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added dashboard support. * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Trigger the right build queues on check-in. * Scripts/webkitpy/common/system/platforminfo.py: * Scripts/webkitpy/common/system/platforminfo_unittest.py: * Scripts/webkitpy/layout_tests/models/test_expectations.py: * Scripts/webkitpy/port/mac.py: * Scripts/webkitpy/port/mac_unittest.py: * TestResultServer/static-dashboards/flakiness_dashboard.js: Added cases for Sierra, and updated tests for new baseline search paths. 2016-06-19 Alexey Proskuryakov Another buid fix for master.cfg. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CompileWebKit.start): 2016-06-19 Alexey Proskuryakov Another buid fix for master.cfg. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CompileWebKit.start): 2016-06-19 Lucas Forschler Fix master.cfg Unreviewed build fix. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (CompileWebKit.start): 2016-06-19 Lucas Forschler Test another commit. Unreviewed. 2016-06-19 Lucas Forschler Testing fix for trac-mirror. Unreviewed. 2016-06-19 Lucas Forschler Test a commit against the SVN 1.9 server upgrade. Unreviewed. 2016-06-17 Daniel Bates Unreviewed, rolling out r202186. Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo builds. Reverted changeset: "File scheme should not allow access of a resource on a different volume." https://bugs.webkit.org/show_bug.cgi?id=158552 http://trac.webkit.org/changeset/202186 2016-06-17 Pranjal Jumde File scheme should not allow access of a resource on a different volume. https://bugs.webkit.org/show_bug.cgi?id=158552 Reviewed by Brent Fulgham. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added. * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added. (-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]): When the main page load is complete fetch the contents of the document to check if iframe was loaded (createPartition): Create a disk image and load the contents of the file. (cleanUp): (TestWebKitAPI::TEST): 2016-06-17 Enrique Ocaña González Unreviewed. Added myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: 2016-06-16 Gyuyoung Kim [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04 https://bugs.webkit.org/show_bug.cgi?id=158141 Reviewed by Michael Catanzaro. * Scripts/webkitpy/port/base.py: Detect php version in system, then use it. (Port._is_debian_php_version_7): (Port._debian_php_version): (Port._apache_config_file_name_for_platform): * efl/install-dependencies: * gtk/install-dependencies: 2016-06-16 Filip Pizlo Baseline JIT should be concurrent https://bugs.webkit.org/show_bug.cgi?id=158755 Reviewed by Geoffrey Garen. Need to disable concurrent JIT when running profiler tests. We should have been doing this all along. * Scripts/run-jsc-stress-tests: 2016-06-16 Per Arne Vollan [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements https://bugs.webkit.org/show_bug.cgi?id=140798 Reviewed by Brent Fulgham. Make sure layout is up-to-date before trying to find named elements. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::rootElement): 2016-06-16 Chris Dumez Unreviewed, rolling out r202002 and r202111. Ryosuke says this was a JSBench regression on iOS Reverted changesets: "Make HashMap and HashSet work with Refs" https://bugs.webkit.org/show_bug.cgi?id=158638 http://trac.webkit.org/changeset/202002 "Improve HashMap and HashSet support for Ref" https://bugs.webkit.org/show_bug.cgi?id=158789 http://trac.webkit.org/changeset/202111 2016-06-15 Simon Fraser [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location https://bugs.webkit.org/show_bug.cgi?id=158828 Reviewed by Enrica Casucci. Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style zooming behavior on focus in the iPhone simulator, which is used for testing. * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): * WebKitTestRunner/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformResetStateToConsistentValues): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): 2016-06-15 Sam Weinig Forward/Back keyboard shortcuts need to flip for RTL https://bugs.webkit.org/show_bug.cgi?id=158823 Reviewed by Darin Adler. Add tests for flipping the behavior of command-left and command-right under RTL mode. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added. (-[CommandBackForwardOffscreenWindow isKeyWindow]): (-[CommandBackForwardOffscreenWindow isVisible]): (simulateCommandArrow): (WebKit2_CommandBackForwardTest::SetUp): (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame): (WebKit2_CommandBackForwardTestWKView::SetUp): (WebKit2_CommandBackForwardTestWKView::loadFiles): (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): (WebKit2_CommandBackForwardTestWKWebView::SetUp): (WebKit2_CommandBackForwardTestWKWebView::loadFiles): 2016-06-15 Tim Horton Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView https://bugs.webkit.org/show_bug.cgi?id=158824 Reviewed by Simon Fraser. * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]): (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]): (TEST): Add a test for _shouldExpandContentToViewHeightForAutoLayout. 2016-06-13 Simon Fraser [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar https://bugs.webkit.org/show_bug.cgi?id=158714 Reviewed by Enrica Casucci. Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView method that gets called from UIKit. Add a test that exercises it. * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::keyboardAccessoryBarNext): (WTR::UIScriptController::keyboardAccessoryBarPrevious): * WebKitTestRunner/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::keyboardAccessoryBarNext): (WTR::UIScriptController::keyboardAccessoryBarPrevious): 2016-06-15 Sam Weinig Improve HashMap and HashSet support for Ref https://bugs.webkit.org/show_bug.cgi?id=158789 Reviewed by Chris Dumez. * TestWebKitAPI/Tests/WTF/HashMap.cpp: * TestWebKitAPI/Tests/WTF/HashSet.cpp: Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref 2016-06-15 Aakash Jain Too much log data generated during layout-tests on iOS Simulator https://bugs.webkit.org/show_bug.cgi?id=158751 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.developer_dir): memoized the property so that it is not called repeatedly. 2016-06-15 Per Arne Vollan [Win][CMake] Changes in WebKit options are not reflected in incremental builds. https://bugs.webkit.org/show_bug.cgi?id=158727 Reviewed by Alex Christensen. Delete CMake cache file if WebKit options have been modified. * Scripts/build-webkit: * Scripts/webkitdirs.pm: (shouldRemoveCMakeCache): 2016-06-15 Romain Bellessort Enabling Shadow DOM for all platforms https://bugs.webkit.org/show_bug.cgi?id=158738 Reviewed by Ryosuke Niwa. Removed Shadow DOM from options (enabled by default) * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-06-15 Per Arne Vollan [Win] The test accessibility/selected-text-range-aria-elements.html is failing. https://bugs.webkit.org/show_bug.cgi?id=158732 Reviewed by Brent Fulgham. Implement selectedTextRange() method. * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::selectedTextRange): 2016-06-15 Per Arne Vollan [Win] MiniBrowser is not DPI aware. https://bugs.webkit.org/show_bug.cgi?id=158733 Reviewed by Brent Fulgham. Call Win32 api function to let Windows know that we will scale the contents ourselves. * MiniBrowser/win/WinMain.cpp: (wWinMain): 2016-06-15 Per Arne Vollan Unreviewed: add new email address to contributors.json. * Scripts/webkitpy/common/config/contributors.json: 2016-06-14 Keith Miller JSBench should use geometric mean https://bugs.webkit.org/show_bug.cgi?id=158775 Reviewed by Mark Lam. For some reason JSBench was using algebraic mean. Since each test is pretty substantially different it should use geometric mean instead. * Scripts/run-jsc-benchmarks: 2016-06-14 Alexey Proskuryakov Debug crash logs are not fully symbolicated on Yosemite https://bugs.webkit.org/show_bug.cgi?id=158760 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation for debug builds on Yosemite. 2016-06-14 Alexey Proskuryakov Tests don't work in iOS Simulator when ASan is enabled https://bugs.webkit.org/show_bug.cgi?id=158726 Reviewed by David Kilzer. * Scripts/webkitpy/port/driver.py: (Driver._setup_environ_for_driver): Added a FIXME. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for simulator into LayoutTestRelay, which is a macOS tool. 2016-06-14 Aakash Jain Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly https://bugs.webkit.org/show_bug.cgi?id=158756 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/xcode/simulator.py: (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if the "simulator device" is still in booted state. Since we ensured that simulator device was in booted state earlier in this method, this indicates that simulator device has shut down unexpectedly. 2016-06-14 David Kilzer Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken Unreviewed build fix. * DumpRenderTree/PlatformMac.cmake: Fix silly typo. 2016-06-14 Aakash Jain Too much log data generated during layout-tests on iOS Simulator https://bugs.webkit.org/show_bug.cgi?id=158751 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort._quit_ios_simulator): Do not use -v flag. (IOSSimulatorPort.clean_up_test_run): Ditto. (IOSSimulatorPort._createSimulatorApp): Ditto. 2016-06-14 David Kilzer Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken Unreviewed build fix. The fix in r202056 clobbered DumpRenderTree_SOURCES and TestNetscapePlugin_SOURCES from DumpRenderTree/CMakeLists.txt, so the build failure is now that we're not building the common sources. Fix that by saving the common sources (which are all C++ source files) into *_Cpp_SOURCES lists first, then setting the compiler flags, then creating the final *_SOURCES lists. * DumpRenderTree/PlatformMac.cmake: Add ${TestNetscapePlugin_Cpp_SOURCES} to list that needs "-std=c++14" compiler switch. (TestNetscapePlugin_Cpp_SOURCES): Add new list for C++ source files for TestNetscapePlugin. Seeded with ${TestNetscapePlugin_SOURCES} from CMakeLists.txt. (TestNetscapePlugin_SOURCES): Add ${TestNetscapePlugin_Cpp_SOURCES} to the list of files. (DumpRenderTree_Cpp_SOURCES): Seed list for C++ source files with ${DumpRenderTree_SOURCES} from CMakeLists.txt. (DumpRenderTree_SOURCES): Reformat and sort source lists. 2016-06-14 David Kilzer REGRESSION (r202020): El Capitan CMake Debug build broken Reviewed by Alex Christensen. The bug was that pure C++ source files (and Objective-C source files) were being compiled as Objective-C++ source files. This is obviously incorrect, so the fix was to split out the list of source files by language, then define compiler switches based on each file type. * DumpRenderTree/PlatformMac.cmake: Replace add_definitions() with separate foreach loops that set compiler flags based on each source file's type. (TestNetscapePlugin_ObjCpp_SOURCES): Rename from TestNetscapePlugin_SOURCES. (TestNetscapePlugin_SOURCES): Create based on ${TestNetscapePlugin_ObjCpp_SOURCES}. (DumpRenderTree_ObjC_SOURCES): Split from DumpRenderTree_SOURCES. (DumpRenderTree_Cpp_SOURCES): Ditto. (DumpRenderTree_ObjCpp_SOURCES): Ditto. (DumpRenderTree_SOURCES): Create from above three lists. 2016-06-14 Lucas Forschler Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12 Rubber-stamped by Jessie Berlin. * Scripts/copy-webkitlibraries-to-product-directory: 2016-06-14 Youenn Fablet Activate CMake export compile commands option https://bugs.webkit.org/show_bug.cgi?id=158734 Reviewed by Alex Christensen. * Scripts/webkitdirs.pm: (generateBuildSystemFromCMakeProject): Activating this option for all CMake builds. This allows using ymcd for WebKit hacking. 2016-06-14 David Kilzer Modernize DumpRenderTreeMac.h Reviewed by Andy Estes. * DumpRenderTree/mac/DumpRenderTreeMac.h: - Update copyright. - Update license. - Use #pragma once. - Use OBJC_CLASS macro. 2016-06-13 David Kilzer False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm Reviewed by Andy Estes. * DumpRenderTree/mac/DumpRenderTree.mm: (destroyWebViewAndOffscreenWindow): Change this function to take a WebView, and assert that it's the same as [mainFrame webView]. (dumpRenderTree): Pass 'webView' into destroyWebViewAndOffscreenWindow(). * DumpRenderTree/mac/DumpRenderTreeMac.h: (createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since this function returns a +1 WebView. Declare this method only for Objective-C[++] source. 2016-06-13 Sam Weinig Make HashMap and HashSet work with Refs https://bugs.webkit.org/show_bug.cgi?id=158638 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WTF/HashSet.cpp: (TestWebKitAPI::TEST): Add tests for using Refs in HashMaps (both as key and value) and HashSets. 2016-06-13 Mark Lam Add a mechanism for collecting LLINT stats. https://bugs.webkit.org/show_bug.cgi?id=158668 Reviewed by Filip Pizlo. * DumpRenderTree/mac/DumpRenderTree.mm: (DumpRenderTreeMain): 2016-06-13 Romain Bellessort [GTK] Enabling Shadow DOM by default https://bugs.webkit.org/show_bug.cgi?id=158686 Reviewed by Carlos Garcia Campos. Added support for enabling Shadow DOM by default for GTK. Changed GTK test expectations for fast/shadow-dom tests (most tests pass). * Scripts/webkitperl/FeatureList.pm: 2016-06-12 Aakash Jain run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation https://bugs.webkit.org/show_bug.cgi?id=158651 rdar://problem/26499824 Reviewed by Daniel Bates. This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators, and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened, so that Simulator is implicitly registered with LaunchServices while opening it. * Scripts/webkitdirs.pm: (relaunchIOSSimulator): Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202. (quitIOSSimulator): Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still attempt to launch the simulator. (waitUntilIOSSimulatorDeviceIsInState): Added a FIXME. 2016-06-11 Myles C. Maxfield Addressing post-review comments after r201978. https://bugs.webkit.org/show_bug.cgi?id=158649 Unreviewed. * TestWebKitAPI/Tests/WTF/WTFString.cpp: (TestWebKitAPI::TEST): 2016-06-11 Alexey Proskuryakov Unreviewed leak fix after r201863. * DumpRenderTree/mac/DumpRenderTree.mm: (dumpFramesAsText): 2016-06-11 Myles C. Maxfield [Cocoa] Map commonly used Chinese Windows font names to names present on Cocoa operating systems https://bugs.webkit.org/show_bug.cgi?id=158649 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/WTFString.h: (TestWebKitAPI::TEST): 2016-06-10 Alex Christensen Fix CMake build. * TestWebKitAPI/PlatformMac.cmake: 2016-06-10 Filip Pizlo Rename JSAir to Air.js Rubber stamped by Mark Lam. * Scripts/run-javascriptcore-tests: 2016-06-10 Filip Pizlo JSC Stress Test failing: jsair-tests.yaml/test.js.ftl-eager-no-cjit https://bugs.webkit.org/show_bug.cgi?id=158571 Reviewed by Keith Miller. Unskip the JSAir test. * Scripts/run-javascriptcore-tests: (runJSCStressTests): 2016-06-10 Sam Weinig Re-disable the UserMedia tests which are timing out. They used to be accidentally disabled, due to not including the FeatureDefines correctly, but not we explicitly disable it. * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: (TestWebKitAPI::TEST): 2016-06-10 Alex Christensen Introduce WTF::UniqueRef https://bugs.webkit.org/show_bug.cgi?id=158596 Reviewed by Brady Eidson. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/UniqueRef.cpp: Added. (TestWebKitAPI::B::B): (TestWebKitAPI::C::C): (TestWebKitAPI::function): (TestWebKitAPI::TEST): 2016-06-10 Sam Weinig Refactor TestWebKitAPI to allow just testing WTF https://bugs.webkit.org/show_bug.cgi?id=158625 Reviewed by Tim Horton. Extract all the WTF tests into a new target to allow a faster build / test / fix cycle when working on WTF bugs and features. By calling `run-api-tests --wtf-only`, you don't need to have a build of JavaScriptCore/WebCore/etc to test WTF only changes. * Scripts/build-api-tests: * Scripts/run-api-tests: (buildTestTool): (testToolPaths): Add new options to build-api-tests and run-api-tests to only build/run the WTF test runner. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/Configurations/TestWTF.xcconfig: Added. * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Added. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add two new targets, TestWTFLibrary which contains all the WTF tests, and TestWTF, the test runner that runs the WTF tests. * TestWebKitAPI/Tests/WTF/RunLoop.cpp: Use Utilities.h rather than PlatformUtilities.h. * TestWebKitAPI/Utilities.h: Added. * TestWebKitAPI/PlatformUtilities.h: * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: * TestWebKitAPI/cocoa/UtilitiesCocoa.mm: Added. Move the sleep and run functions into a new Utilities.h/cpp file. This file contains utilities that don't depend on anything in the WebKit project. 2016-06-10 Brady Eidson REGRESSION(r201928?) API test WTF.StringOperators failing https://bugs.webkit.org/show_bug.cgi?id=158623 Unreviewed, but buddy coded with Alex Christensen. * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: (TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed to use string concatenation, otherwise the linker will mess up on the symbol related to this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion. 2016-06-10 Brady Eidson WTF_CrossThreadTask.Basic fails in all non mac ports. https://bugs.webkit.org/show_bug.cgi?id=158612 Reviewed by Alex Christensen. The test is very sensitive to argument evaluation order which is explicitly undefined in C++. Instead, we should just count the appropriate events to forget their order. * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: (TestWebKitAPI::LifetimeLogger::LifetimeLogger): (TestWebKitAPI::LifetimeLogger::~LifetimeLogger): (TestWebKitAPI::LifetimeLogger::isolatedCopy): (TestWebKitAPI::LifetimeLogger::fullName): (TestWebKitAPI::testFunction): (TestWebKitAPI::TEST): (TestWebKitAPI::LifetimeLogger::log): Deleted. (TestWebKitAPI::LifetimeLogger::takeLogStr): Deleted. 2016-06-09 Alex Christensen Clean up Tools *.vcxproj after switching to CMake. * DumpRenderTree/DumpRenderTree.sln: Removed. * DumpRenderTree/DumpRenderTree.vcxproj: Removed. * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Removed. * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed. * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed. * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Removed. * DumpRenderTree/PlatformWin.cmake: * DumpRenderTree/win/TestNetscapePlugin.def: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def. * DumpRenderTree/win/TestNetscapePlugin.rc: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc. * DumpRenderTree/win/resource.h: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h. * MiniBrowser/MiniBrowser.vcxproj: Removed. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Removed. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Removed. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Removed. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Removed. * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Removed. * MiniBrowser/MiniBrowser.vcxproj/small.ico: Removed. * MiniBrowser/win/CMakeLists.txt: * MiniBrowser/win/MiniBrowser.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico. * MiniBrowser/win/MiniBrowser.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc. * MiniBrowser/win/MiniBrowserLib.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc. * MiniBrowser/win/MiniBrowserLibResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h. * MiniBrowser/win/MiniBrowserResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h. * MiniBrowser/win/small.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/small.ico. * WebKitTestRunner/WebKitTestRunner.sln: Removed. * win/DLLLauncher/DLLLauncherWinCairo.props: Removed. 2016-06-09 Zalan Bujtas Add testing support for 3x device scale factor. https://bugs.webkit.org/show_bug.cgi?id=158597 Reviewed by Simon Fraser. Set 3x device scale factor on the test canvas when the test url is prefixed with hidpi-3x-. * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest): * WebKitTestRunner/TestOptions.cpp: (WTR::deviceScaleFactorForTest): (WTR::TestOptions::TestOptions): (WTR::isHiDPITestPath): Deleted. * WebKitTestRunner/TestOptions.h: 2016-06-09 Michael Catanzaro Add comments to clarify feature enablement https://bugs.webkit.org/show_bug.cgi?id=158567 Reviewed by Alex Christensen. * Scripts/webkitperl/FeatureList.pm: 2016-06-09 Filip Pizlo Unreviewed, skip jsair tests while we figure out the debug timeouts. * Scripts/run-javascriptcore-tests: (runJSCStressTests): 2016-06-09 Commit Queue Unreviewed, rolling out r201815. https://bugs.webkit.org/show_bug.cgi?id=158570 This broke the cmake build. (Requested by lforschler on #webkit). Reverted changeset: "Teach cmake about libWebKitSystemInterfaceOSX10.12" http://trac.webkit.org/changeset/201815 2016-06-09 Brady Eidson Greatly simplify CrossThreadTask.h. https://bugs.webkit.org/show_bug.cgi?id=158542 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: (TestWebKitAPI::TEST): 2016-06-09 Chris Dumez Unreviewed, rolling out r201836, r201845, and r201848. Looks like a 1-2% PLT regression on iOS Reverted changesets: "[JSC] Change some parameters based on a random search" https://bugs.webkit.org/show_bug.cgi?id=158514 http://trac.webkit.org/changeset/201836 "Tempory fix for the debug bots" http://trac.webkit.org/changeset/201845 "Change thresholdForOptimizeSoon to match thresholdForOptimizeAfterWarmUp" http://trac.webkit.org/changeset/201848 2016-06-09 Michael Saboff WebKitTestRunner and DumpRenderTree do not handle dangling surrogate characters https://bugs.webkit.org/show_bug.cgi?id=154863 Reviewed by Alexey Proskuryakov. Added a non-strict verions of WKStringGetUTF8CString() that will handle dangling surrogates. Changed the extraction of inner text from frames in DumpRenderTree to use the new WKStringGetUTF8CStringNonStrict() function instead of NSString conversion since NSString doesn't have a way to handle dangling surrogates. The code added in DumpRenderTree matches what was changed in WebKitTestRunner. * DumpRenderTree/mac/DumpRenderTree.mm: (dumpFramesAsText): * WebKitTestRunner/StringFunctions.h: (WTR::toWTFString): 2016-06-08 Hunseop Jeong Try to fix the EFL build. Unreviewed. * TestWebKitAPI/CMakeLists.txt: 2016-06-08 Alex Christensen Fix WinCairo build * DumpRenderTree/cairo/PixelDumpSupportCairo.h: 2016-06-08 Alex Christensen Fix WinCairo build * DumpRenderTree/cairo/PixelDumpSupportCairo.h: (BitmapContext::createByAdoptingBitmapAndContext): (BitmapContext::~BitmapContext): 2016-06-08 Benjamin Poulain [JSC] Change some parameters based on a random search https://bugs.webkit.org/show_bug.cgi?id=158514 Reviewed by Filip Pizlo. * Scripts/run-jsc-stress-tests: 2016-06-08 Aakash Jain tests fail if display sleeps while run-webkit-tests is running https://bugs.webkit.org/show_bug.cgi?id=153919 Reviewed by Alexey Proskuryakov. * DumpRenderTree/mac/LayoutTestHelper.m: (releaseSleepAssertions): Release both Display sleep and System sleep assertions. (addSleepAssertions): Add sleep assertion for both Display sleep and System sleep. 2016-06-08 Lucas Forschler Reverted changeset 201814. * Scripts/copy-webkitlibraries-to-product-directory: 2016-06-08 Per Arne Vollan [Win] Shadow DOM tests are failing. https://bugs.webkit.org/show_bug.cgi?id=158524 Reviewed by Brent Fulgham. Enable Shadow DOM when running tests. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): 2016-06-08 Lucas Forschler Teach cmake about libWebKitSystemInterfaceOSX10.12 This patch also removes duplicated logic inside DumpRenderTree/PlatformMac.cmake Rubber-stamped by Alex Christensen. * DumpRenderTree/PlatformMac.cmake: * WebKitTestRunner/PlatformMac.cmake: 2016-06-07 Lucas Forschler Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12 Rubber-stamped by Jessie Berlin. * Scripts/copy-webkitlibraries-to-product-directory: 2016-06-08 Aakash Jain Don't try to cleanup non-existing ios Simulators https://bugs.webkit.org/show_bug.cgi?id=158510 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.clean_up_test_run): Check if simulator exists before trying to clean it up. 2016-06-08 Brady Eidson Try to fix the Windows build. Unreviewed. * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: (TestWebKitAPI::LifetimeLogger::log): (TestWebKitAPI::LifetimeLogger::takeLogStr): (TestWebKitAPI::testFunction): (TestWebKitAPI::TEST): (TestWebKitAPI::log): Deleted. (VS was seeing it as a dupe symbol) (TestWebKitAPI::takeLogStr): Deleted. (VS was seeing it as a dupe symbol) 2016-06-08 Brady Eidson Make CrossThreadCopier more efficient (fewer copies!). https://bugs.webkit.org/show_bug.cgi?id=158456 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: (TestWebKitAPI::TEST): 2016-06-07 Filip Pizlo Add result validation to JSAir https://bugs.webkit.org/show_bug.cgi?id=158493 Reviewed by Saam Barati. Run JSAir. * Scripts/run-javascriptcore-tests: (runJSCStressTests): 2016-06-08 Brady Eidson Add an API test that confirms object constructor/destructor calls during creation of a CrossThreadTask. https://bugs.webkit.org/show_bug.cgi?id=158528 Reviewed by Alex Christensen. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: Added. (TestWebKitAPI::log): (TestWebKitAPI::takeLogStr): (TestWebKitAPI::LifetimeLogger::LifetimeLogger): (TestWebKitAPI::LifetimeLogger::~LifetimeLogger): (TestWebKitAPI::LifetimeLogger::isolatedCopy): (TestWebKitAPI::testFunction): (TestWebKitAPI::TEST): 2016-06-08 Konstantin Tokarev TestWebKitAPI: Removed redunandant check PLATFORM(GTK) && !defined(BUILDING_WEBKIT2__) https://bugs.webkit.org/show_bug.cgi?id=158521 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/config.h: 2016-06-07 Carlos Garcia Campos [GTK] Use a longer timeout for glib unit tests https://bugs.webkit.org/show_bug.cgi?id=158476 Reviewed by Darin Adler. The timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of the same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out in the bots because the timeout is not enough to run all the tests cases. So, we should use a longer timeout for GLib tests. * Scripts/run-gtk-tests: (TestRunner._run_test_glib): 2016-06-07 Keith Rollin Remove all uses of PassRefPtr in WTF https://bugs.webkit.org/show_bug.cgi?id=157596 Reviewed by Chris Dumez. Update calls to interfaces that no longer take or return PassRefPtrs. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::stringFromUTF8): (TestWebKitAPI::TEST): 2016-06-07 Per Arne Vollan [Win] Imported markup insertion test is failing. https://bugs.webkit.org/show_bug.cgi?id=158477 Reviewed by Darin Adler. Make sure the empty synchronous request is loaded after each test. * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): 2016-06-06 Carlos Alberto Lopez Perez REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step. https://bugs.webkit.org/show_bug.cgi?id=158417 Reviewed by Michael Catanzaro. The toolchain on armhf (ARMv7) seems unable to properly handle a shared library that doesn't link with anything. And libicudata is built by default in this way because it only contains static data. That makes icu unusable on armhf because the linker will be unable to resolve the libicudata dependencies. Most (if not all) distributions workaround this by linking libicudata with libc6, which is already a needed dependency for any of the other icu shared libraries. So import here the Debian patch fixing this issue. For further details check https://bugs.debian.org/653457 * gtk/jhbuild.modules: * gtk/patches/icudata-stdlibs.patch: Added. 2016-06-06 Per Arne Vollan REGRESSION (r104174): 500+ tests failing on Windows https://bugs.webkit.org/show_bug.cgi?id=75965 Reviewed by Michael Catanzaro. Reset WebView scale factors before running next test. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): 2016-06-04 Alexey Proskuryakov REGRESSION (r201263): Some tests have become flaky timeouts. https://bugs.webkit.org/show_bug.cgi?id=157990 Reviewed by Darin Adler. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): It is somewhat legitimate for WebContent to not respond to messages after the test is done; it can be e.g. re-doing a costly repaint. So, we should restart is silently, without making the current test fail. 2016-06-03 Youenn Fablet [GTK] Update YouCompleteMe script to make all include paths absolute https://bugs.webkit.org/show_bug.cgi?id=158301 Reviewed by Michael Catanzaro. Before this patch, some include paths were not made absolute. This could make YouCompleteMe plugin to fail extracting information or validating cpp files. * gtk/ycm_extra_conf.py: 2016-06-03 Nael Ouedraogo Unreviewed: add myself to the committers list. * Scripts/webkitpy/common/config/contributors.json: 2016-06-02 Per Arne Vollan [Win] Fetch API tests are failing. https://bugs.webkit.org/show_bug.cgi?id=158296 Reviewed by Alex Christensen. Enable Fetch API when running tests. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebPreferencesToConsistentValues): 2016-06-02 Srinivasan Vijayaraghavan Really display failing JSC stress tests in buildbot dashboard https://bugs.webkit.org/show_bug.cgi?id=158324 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration.prototype._parseData): Correctly check for string membership in array. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string membership in array. (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is generated after the first time. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array. 2016-06-02 Michael Saboff [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled https://bugs.webkit.org/show_bug.cgi?id=158317 Reviewed by Saam Barati. Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint variant. * Scripts/run-jsc-stress-tests: 2016-06-02 Aakash Jain LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit https://bugs.webkit.org/show_bug.cgi?id=158305 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup. 2016-06-01 Brian Burg REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields https://bugs.webkit.org/show_bug.cgi?id=158227 Reviewed by Alexey Proskuryakov. Add a regression test that runs on Mac only. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added. (-[DummyNavigationDelegate webView:didFinishNavigation:]): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added. 2016-06-01 Chris Fleizach AX: iOS: VoiceOver can't access attachments in mail messages https://bugs.webkit.org/show_bug.cgi?id=158198 Reviewed by Joanmarie Diggs. * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::stringForRange): (AccessibilityUIElement::attributedStringForRange): (AccessibilityUIElement::attributedStringRangeIsMisspelled): * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::attributedStringForRange): (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): 2016-06-01 Carlos Garcia Campos Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow. It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the timeout is applied per tester program not per test case, so we need to mark the whole test WebKit2Gtk/TestInspectorServer as slow. * Scripts/run-gtk-tests: (TestRunner): (TestRunner._run_test_glib): 2016-06-01 Carlos Garcia Campos Unreviewed. Skip media permission request GTK+ unit tests. They are timing out in the bots. * Scripts/run-gtk-tests: (TestRunner): 2016-05-31 Jer Noble Yet another unreviewed build fix; move the closing brace of the namespace declaration inside the #if check. * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: 2016-05-31 Jer Noble Further unreviewed build fix; only run FullscreenTopContentInset test on Mac. * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: 2016-05-31 Jer Noble Unreviewed build fix; only run FullscreetTopContentInset test on platforms where WK_API_ENABLED is set. * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: 2016-05-31 Jer Noble REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen https://bugs.webkit.org/show_bug.cgi?id=158156 Reviewed by Darin Adler. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added. (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]): (TestWebKitAPI::TEST): 2016-05-31 Jon Lee Unreviewed: add myself to the reviewers list. * Scripts/webkitpy/common/config/contributors.json: 2016-05-31 Carlos Alberto Lopez Perez [GTK] Provide alternative mirror for the ICU tarball. https://bugs.webkit.org/show_bug.cgi?id=154530 Unreviewed. * gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having a hard time trying to download the ICU tarball from download.icu-project.org (which redirects to sourceforge and gives problems with something related to SSL). Provide this alternative mirror to make things working back. 2016-05-31 Carlos Garcia Campos [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423 https://bugs.webkit.org/show_bug.cgi?id=158200 Reviewed by Philippe Normand. This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case POSITION_UNAVAILABLE is returned without asking the API layer. * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the document title, and use user script messages that are more reliable instead. 2016-05-28 Aakash Jain tests fail if display sleeps while run-webkit-tests is running https://bugs.webkit.org/show_bug.cgi?id=153919 Reviewed by Darin Adler. * DumpRenderTree/mac/LayoutTestHelper.m: (addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool. 2016-05-27 Srinivasan Vijayaraghavan Display failing JSC stress tests in buildbot dashboard https://bugs.webkit.org/show_bug.cgi?id=156595 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: (BuildbotCombinedQueueView.prototype.update): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration): (BuildbotIteration.prototype._parseData): (BuildbotIteration.prototype.loadLayoutTestResults): (BuildbotIteration.prototype.): (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._createLoadingIndicator): (BuildbotQueueView.prototype.): (BuildbotQueueView.prototype._onPopoverCopy): (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): (BuildbotQueueView.prototype._addIterationHeadingToPopover): (BuildbotQueueView.prototype._testStepFailureDescription): (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): (BuildbotTesterQueueView.prototype.update): (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. (BuildbotTesterQueueView.prototype.): Deleted. (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js. (MockBuildbot): (MockBuildbot.prototype.buildPageURLForIteration): (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: (MockBuildbotQueue): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js. (MockBuildbotTestResults): (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: 2016-05-27 Srinivasan Vijayaraghavan Display failing JSC stress tests in buildbot dashboard https://bugs.webkit.org/show_bug.cgi?id=156595 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Generate the URL for raw JSON output of JSC tests. (Buildbot.prototype.javaScriptCoreTestStdioURLForIteration): Generate the URL for human-readable stdio output of JSC tests. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: (BuildbotCombinedQueueView.prototype.update): Display JSC test results in popover. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (BuildbotIteration): Add javaScriptCoreTestResults variable. (BuildbotIteration.prototype.): Check for javascriptcore tests step. (BuildbotIteration.prototype.loadLayoutTestResults): Add comma at closing brace. (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): Fetch JSON from Buildbot server. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._createLoadingIndicator): Reusable function. (BuildbotQueueView.prototype._onPopoverCopy): Reusable copy event handler to allow accurate copying of text from popovers. (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Generates the popover bubble's inner HTML from the JSC failure data. (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Generate the popover bubble for JSC results and handle request failures. (BuildbotQueueView.prototype._testStepFailureDescription): Moved from subclass. (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): Moved from subclass. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Parse JSON into a list of failing tests. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Instantiate PopoverTrackers for builds whose only failures are JSC tests. (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Use _onPopoverCopy. (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Use _createLoadingIndicator. (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. Moved to superclass. (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. Moved to superclass. (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. Using superclass's reusable function as copy handler instead. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Add new script files. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Added. (MockBuildbot): Mocked version of Buildbot, only containing URL methods. (MockBuildbot.prototype.buildPageURLForIteration): Same as real Buildbot.js (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Points to local file containing JSON for test. (MockBuildbot.prototype.javaScriptCoreTestStdioURLForIteration): Same as real Buildbot.js * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: (MockBuildbotQueue): Use a MockBuildbot() instead of a string. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Added. (MockBuildbotTestResults): Mocked version of BuildbotTestResults. (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Sets the 'regressions' variable. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Add four groups of tests. 2016-05-27 Chris Dumez WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables https://bugs.webkit.org/show_bug.cgi?id=158111 Reviewed by Darin Adler. WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables. These are often used cross-thread and copying the captured lambda variables can be dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon capture). * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForNavigationAction): 2016-05-27 Brady Eidson Modern IDB: After closing a Netflix video, trying to watch it again fails. and https://bugs.webkit.org/show_bug.cgi?id=158160 Reviewed by Alex Christensen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added. 2016-05-27 Joanmarie Diggs AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416 https://bugs.webkit.org/show_bug.cgi?id=158152 Reviewed by Chris Fleizach. The failure is actually a bug fix because only one child is being added, but two notifications were being emitted. Now there is only one notification. To verify this was the case, we really should examine the child reportedly being added. That child is the ATK event's any_data, so pass along that child to the listener. * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: 2016-05-26 Alex Christensen Expose content extension failure error codes in SPI https://bugs.webkit.org/show_bug.cgi?id=158095 rdar://problem/26475651 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: (checkDomain): (TEST_F): Add tests that use the new enum. 2016-05-27 Carlos Garcia Campos New intl-numberformat.js test fails on many Linux platforms https://bugs.webkit.org/show_bug.cgi?id=154530 Reviewed by Darin Adler. The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is. * gtk/jhbuild.modules: 2016-05-26 Yusuke Suzuki [JSC] Allow JSBench to use precise time https://bugs.webkit.org/show_bug.cgi?id=158050 Reviewed by Geoffrey Garen. JSBench use `new Date().getTime()` without options and there is no way to use precise time. This patch modifies the JSBench code to inject the code taking the precise time. `currentTimeInMS` is given by the benchmerk harness and JSBench uses it. run-jsc-benchmark switches this function's implementation between `Date.now()` and testRunner's precise time one. While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and the contents are not changed for a long time. As described in the original paper[1], the tests can be generated by using JSBench's record & replay system, but in that case, we can adopt this modification by changing the tool side. We also add currentTimeInMS implementation in harness.js and u?rem.js directly. u?rem.js implementation is required when it is executed in u?rem.html without harness. And harness.js implementation is required when it is executed in the JSBench's harness. In these implementation, we follow the JetStream's time measuring function: performance.now(), preciseTime(), or Date.now(). [1]: http://dl.acm.org/citation.cfm?id=2048119 * Scripts/run-jsc-benchmarks: 2016-05-26 Brent Fulgham Unreviewed test fix after r201427. https://bugs.webkit.org/show_bug.cgi?id=157423 A debug assertion was firing during some test runs due to the Geolocation permission being turned off during the test. The timer logic was originally written to assert if the timer fired when permissions were disabled. But this is no longer valid, because we expect the Geolocation system to be active and become deactivated if the browsing context violates one of the security criteria. * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate timerFired]): Remove invalid assertion. 2016-05-26 Filip Pizlo ScopedLambda should have a lifetime story that makes sense to the compiler https://bugs.webkit.org/show_bug.cgi?id=158118 Reviewed by Mark Lam. Added a test case. This test crashes before the fix and now it passes. * TestWebKitAPI/CMakeLists.txt: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added. (TestWebKitAPI::TEST): 2016-05-26 Myles C. Maxfield Build fix Rubber stamped by Lucas Forschler. * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 2016-05-25 Anders Carlsson Get rid of WTF/Functional.h https://bugs.webkit.org/show_bug.cgi?id=158081 Reviewed by Chris Dumez. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WTF/Functional.cpp: Removed. (TestWebKitAPI::returnFortyTwo): Deleted. (TestWebKitAPI::TEST): Deleted. (TestWebKitAPI::multiplyByTwo): Deleted. (TestWebKitAPI::multiplyByOneAndAHalf): Deleted. (TestWebKitAPI::multiply): Deleted. (TestWebKitAPI::subtract): Deleted. (TestWebKitAPI::A::A): Deleted. (TestWebKitAPI::A::f): Deleted. (TestWebKitAPI::A::addF): Deleted. (TestWebKitAPI::B::B): Deleted. (TestWebKitAPI::B::~B): Deleted. (TestWebKitAPI::B::ref): Deleted. (TestWebKitAPI::B::deref): Deleted. (TestWebKitAPI::B::f): Deleted. (TestWebKitAPI::B::g): Deleted. (TestWebKitAPI::Number::create): Deleted. (TestWebKitAPI::Number::~Number): Deleted. (TestWebKitAPI::Number::value): Deleted. (TestWebKitAPI::Number::Number): Deleted. (TestWebKitAPI::multiplyNumberByTwo): Deleted. 2016-05-25 Daniel Bates and Brent Fulgham [WebSockets] No infrastructure for testing secure web sockets (wss) https://bugs.webkit.org/show_bug.cgi?id=157884 Reviewed by Andy Estes. Add support to webkitpy to start and stop a secure Web Socket server running on port 9323 using the certificate, private-key from file LayoutTests/http/conf/webkit-httpd.pem. Also teaches run-webkit-httpd to start and stop the Web Socket servers. Modify DumpRenderTree and WebKitTestRunner to understand a new testRunner method, 'setAllowsAnySSLCertificate', which allows us to use the same self-signed test certificate we do for our HTTPS tests. * DumpRenderTree/TestRunner.cpp: (setAllowsAnySSLCertificateCallback): (TestRunner::setAllowsAnySSLCertificate): * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Make sure we turn off the new flag between tests. * Scripts/run-webkit-httpd: (main): Start the websocket server at launch. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.__init__): Remove dead code. * Scripts/webkitpy/layout_tests/servers/websocket_server.py: (PyWebSocket.__init__): Cleanup code. (PyWebSocket): Pass '--tls-client-ca' to start command. (PyWebSocket._prepare_config): Cleanups. * Scripts/webkitpy/port/base.py: (Port.to.start_http_server): (Port.to): (Port.to._extract_certificate_from_pem): Added. (Port.to._extract_private_key_from_pem): Added. (Port.to.start_websocket_server): Start secure socket server. (Port.to.stop_websocket_server): Stop secure socket server. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add new API. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::setAllowsAnySSLCertificate): Added. * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setAllowsAnySSLCertificate): Added. * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-05-25 Keith Miller run-jsc-benchmarks should use the new JSBench rather than look for it in the config file. https://bugs.webkit.org/show_bug.cgi?id=158077 Reviewed by Mark Lam. Since we didn't have JSBench in the tree before we needed to lookup the path to it from benchmark config file. That's no longer the case so we should just fix it in the script. * Scripts/run-jsc-benchmarks: 2016-05-24 Aakash Jain Reorganize dashboard code: move code from _timeIntervalString to base class https://bugs.webkit.org/show_bug.cgi?id=158047 rdar://problem/26457274 Reviewed by Alexey Proskuryakov and Dean Johnson. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: (BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: (QueueView.prototype._readableTimeString): Same. 2016-05-24 Yusuke Suzuki [JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports https://bugs.webkit.org/show_bug.cgi?id=158016 Reviewed by Darin Adler. This patch easily allows run-jsc-benchmark to run WebKitTestRunner-based tests in GTK / EFL ports. This change encourages us to run tests with the browser-heap in nix environments. Two things are modified. 1. Add a fall-back to look up the library path in GTK / EFL / JSCOnly environment. In GTK / EFL / JSCOnly ports, the hierarchy of the build directory is slightly different from Apple port. For example, the jsc bin locate at "WebKitBuild/XXX/Release/bin/jsc" and the lib path is "WebKitBuild/XXX/Release/lib" while the one of Apple port is "WebKitBuild/XXX/Release/jsc" and "WebKitBuild/XXX/Release/lib". And based on this library path, we configure the required environment variables to run WebKitTestRunner in GTK / EFL ports. 2. Add --dependencies option to add dependent library paths. While Apple ports does not require any additional dependent library path, GTK and EFL ports require this path, typically WebKitBuild/DependenciesGTK and WebKitBuild/DependenciesEFL respectively. So we need to add such paths to LD_LIBRARY_PATH. Instead of adding platform options like --gtk / --efl, we add --dependencies option to add the additional dependent library paths. The platform options still require the build path to look up the dependent library directory. So we pass it directly through --dependencies. Multiple additional dependent library paths can be added by using --dependencies multiple times. By using these change, we can run benchmarks that require WebKitTestRunner in GTK / EFL ports (If you would like to run them in a headless manner, you can use xvbuf.). Example: `Tools/Scripts/run-jsc-benchmarks baseline:WebKitBuild/baseline/Release/bin/WebKitTestRunner patched:WebKitBuild/patched/Release/bin/WebKitTestRunner --dependencies WebKitBuild/DependenciesGTK/Root/lib --js-bench` * Scripts/run-jsc-benchmarks: 2016-05-20 Keith Miller We should have JSBench in PerformanceTests https://bugs.webkit.org/show_bug.cgi?id=157952 Rubber-stamped by Saam Barati. This changes the runner to use the layout of the newest version of JSBench. * Scripts/run-jsc-benchmarks: 2016-05-24 Chris Dumez Use auto for some of our lambda function parameters https://bugs.webkit.org/show_bug.cgi?id=158001 Reviewed by Darin Adler. Use auto for some of our lambda function parameters now that we build with c++14. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::willDestroyPage): 2016-05-23 Brady Eidson check-webkit-style gets flags std::literals::chrono_literals as bad naming. https://bugs.webkit.org/show_bug.cgi?id=157969 Reviewed by Alex Christensen. * Scripts/webkitpy/style/checkers/cpp.py: (check_identifier_name_in_declaration): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (WebKitStyleTest.test_names): 2016-05-22 Alexey Proskuryakov RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests https://bugs.webkit.org/show_bug.cgi?id=157977 rdar://problem/20874156 Reviewed by David Kilzer. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): Be more certain to launch a new process when there was a timeout detected. If we don't, there is a chance that the process is not quite frozen, and will still send a response that we no longer expect. (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr too, as stdout is not available, at least not in the case that I was observing. 2016-05-22 Brady Eidson Move to C++14. https://bugs.webkit.org/show_bug.cgi?id=157948 Reviewed by Michael Catanzaro. * DumpRenderTree/mac/Configurations/Base.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: 2016-05-21 Aakash Jain Simulator launch fails intermittently due to failure in checking simulator boot status https://bugs.webkit.org/show_bug.cgi?id=157965 rdar://problem/26402404 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/xcode/simulator.py: (Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking whether simulator has finished booting. 2016-05-21 Dan Bernstein Silence warnings from svn propget when using newer versions of Subversion. https://bugs.webkit.org/show_bug.cgi?id=157879 Reviewed by Daniel Bates. * Scripts/prepare-ChangeLog: (attributeCommand): Redirect svn propget stderr to /dev/null. * Scripts/svn-create-patch: (findMimeType): Ditto. 2016-05-20 Ryosuke Niwa run-benchmark's results should contain Animometer's debug output https://bugs.webkit.org/show_bug.cgi?id=157941 Reviewed by Stephanie Lewis. Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array. The result can be dragged and dropped into Animometer's developer.html page. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites. (BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately. * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Modified the patch to store the debug output. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: (ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined when the request body is larger than a certain size on twisted. 2016-05-20 Srinivasan Vijayaraghavan Use clearer names for JSON output of javascriptcore test results https://bugs.webkit.org/show_bug.cgi?id=157921 Reviewed by Alexey Proskuryakov. "failures" and "apiTestResult" were somewhat ambiguous names. * Scripts/run-javascriptcore-tests: (runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed". 2016-05-20 Chris Dumez Unreviewed, fix API test introduced in r201213. * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (TestWebKitAPI::TEST): 2016-05-20 Rawinder Singh Implement operator== for WeakPtr https://bugs.webkit.org/show_bug.cgi?id=157883 Reviewed by Chris Dumez. Implement operator== and operator!= for WeakPtr and update code to use the operators. * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (TestWebKitAPI::TEST): 2016-05-19 Srinivasan Vijayaraghavan Add JSON results to 32-bit and CLoop JSC tests https://bugs.webkit.org/show_bug.cgi?id=157929 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output. (Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output. 2016-05-19 Csaba Osztrogonác Typo fix in import-test262-tests https://bugs.webkit.org/show_bug.cgi?id=157902 Reviewed by Keith Miller. * Scripts/import-test262-tests: 2016-05-19 Csaba Osztrogonác [EFL] Fix the gst-libav build on ARM Thumb2 after r199649 https://bugs.webkit.org/show_bug.cgi?id=157893 Reviewed by Antonio Gomes. * efl/patches/gst-libav.patch: 2016-05-19 Jer Noble REGRESSION(r200951): VideoControlsManager API tests time out https://bugs.webkit.org/show_bug.cgi?id=157896 Reviewed by Eric Carlson. Explicitly disable user gesture requirements for playback. * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: (TestWebKitAPI::TEST): 2016-05-19 Csaba Osztrogonác Slow JSC stress tests times out in 32 bit debug mode https://bugs.webkit.org/show_bug.cgi?id=154964 Reviewed by Michael Catanzaro. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Pass through the --debug option. * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds. 2016-05-18 Aakash Jain Remove underline from Status Bubbles on dashboard https://bugs.webkit.org/show_bug.cgi?id=157870 rdar://problem/26332321 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style change made in http://trac.webkit.org/r200880 2016-05-18 Michael Saboff r199812 broke test262 https://bugs.webkit.org/show_bug.cgi?id=157595 Reviewed by Filip Pizlo. Added a new run type, runOneLargeHeap, for tests that use a large amount of memory. This run type will not run with the --memory-limited option. Without that option, we'll only the default test variant. * Scripts/run-jsc-stress-tests: 2016-05-18 Simon Fraser REGRESSION (r200534) Command-+ no longer zooms pages https://bugs.webkit.org/show_bug.cgi?id=157826 rdar://problem/26334636 Reviewed by Dean Jackson. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828). 2016-05-18 Joanmarie Diggs [GTK] accessibility/meter-element.html is failing https://bugs.webkit.org/show_bug.cgi?id=115633 Reviewed by Chris Fleizach. Implement AccessibilityUIElement::valueDescription() and add mapping from ATK_ROLE_LEVEL_BAR to AXProgressIndicator. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::valueDescription): 2016-05-18 Brady Eidson Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported). https://bugs.webkit.org/show_bug.cgi?id=157823 Reviewed by Alex Christensen. * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::clearAllDatabases): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::clearAllDatabases): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): 2016-05-18 Joanmarie Diggs AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description https://bugs.webkit.org/show_bug.cgi?id=157822 Reviewed by Chris Fleizach. Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than nullptr upon failure. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::helpText): 2016-05-17 Beth Dakin Make handleAcceptedCandidate a public function https://bugs.webkit.org/show_bug.cgi?id=157763 -and corresponding- rdar://problem/26206397 Reviewed by Tim Horton. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added. * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added. (-[DoNotLeakWebView dealloc]): (-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]): (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]): (TestWebKitAPI::TEST): 2016-05-17 Keith Miller Add test262 harness support code https://bugs.webkit.org/show_bug.cgi?id=157797 Reviewed by Filip Pizlo. The import-test262-tests script is used to generate the yaml file used to run test262. It takes a path to the local copy of the Test262 repository as well as an optional path to file containing a list of failures. This script currently just creates the yaml file used to run the script. It does not relocate the test files into our tests directory. In the future I plan to add that feature but it didn't seem essential for the first iteration. Since many test262 tests need to be run in both strict and non-strict mode, import-test262-tests creates two separate runs for those tests. This enables us to distinguish between failures in only one of the two modes. This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262 takes an actual test file along with the metadata associated with it. prepareTest262Fixture takes a fixture file (used by module tests for importing) and makes sure that file is properly relocated to the test runner directory. The proccess I used to import the tests was to first run import-test262-tests to create a yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the output to a file and collected all the lines with "FAIL" in it. Finally, I reran import-test262-tests with the new failure file to create the final yaml. * Scripts/import-test262-tests: Added. * Scripts/run-jsc-stress-tests: 2016-05-16 Enrica Casucci build fix after r200968 and r200969 Unreviewed. * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): 2016-05-16 Jer Noble API test WebKit2.MSEIsPlayingAudio timing out after r200951 https://bugs.webkit.org/show_bug.cgi?id=157748 Reviewed by Eric Carlson. The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the "user gesture" check fails at that point. Call play() up front; playback will begin as soon as enough data is loaded. * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: 2016-05-16 Enrica Casucci Remove unused initializer for WebEvent on iOS. https://bugs.webkit.org/show_bug.cgi?id=157689 Reviewed by Anders Carlsson. Adopting different initializer for WebEvent to fix the build. * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): 2016-05-16 Srinivasan Vijayaraghavan Add machine-readable results for JSC API tests to the Buildbot json log https://bugs.webkit.org/show_bug.cgi?id=157642 Reviewed by Geoffrey Garen. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests * Scripts/run-javascriptcore-tests: (runJSCStressTests): Abstracted out writing JSON to file (new function below) (writeJsonDataIfApplicable): Added 2016-04-06 Jer Noble [WK2] Add API to WKWebViewConfiguration to control autoplay policy. https://bugs.webkit.org/show_bug.cgi?id=156312 Reviewed by Dan Bernstein. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (TEST_F): 2016-05-16 Brent Fulgham REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays https://bugs.webkit.org/show_bug.cgi?id=157630 Reviewed by Simon Fraser. Update test infrastructure to support checking the number of images in the pasteboard. * DumpRenderTree/TestRunner.cpp: (imageCountInGeneralPasteboardCallback): Added. (TestRunner::staticFunctions): * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::imageCountInGeneralPasteboard): Added. * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::imageCountInGeneralPasteboard): Added stub method. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::imageCountInGeneralPasteboard): Added. * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::imageCountInGeneralPasteboard): Added. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::imageCountInGeneralPasteboard): Added. 2016-05-13 Dewei Zhu Fix JSBench which causes math domain error in run-benchmark script. https://bugs.webkit.org/show_bug.cgi?id=157697 Reviewed by Ryosuke Niwa. Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean. Also fix a round-off error while calculating stdev. * Scripts/webkitpy/benchmark_runner/benchmark_results.py: (BenchmarkResults._format_values): * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: 2016-05-13 Brady Eidson Extend protector naming code style guideline to cover operator= assignment. https://bugs.webkit.org/show_bug.cgi?id=157693 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cpp.py: (check_identifier_name_in_declaration): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (WebKitStyleTest.test_names): 2016-05-13 Aakash Jain Dashboard code restructuring https://bugs.webkit.org/show_bug.cgi?id=157680 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: (BubbleQueueView.prototype.addLinkToRow): Moved to base class. (BubbleQueueView.prototype.addTextToRow): Moved to base class. (BubbleQueueView.prototype._addDividerToPopover): Moved to base class. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: (BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js: (BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: (BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take additional argument. (BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class. (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class. (BuildbotQueueView.prototype._addDividerToPopover): Moved to base class. (BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (documentReady): Display any customView if available. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: (QueueView.prototype.addLinkToRow): Moved from child class, no changes. (QueueView.prototype.addTextToRow): Moved from child class, no changes. (QueueView.prototype._addDividerToPopover): Moved from child class, no changes. (QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic by taking latestIterationGetter method as an argument. (QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes. (QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes. (QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (a:hover:link): Underline only when there is a link. 2016-05-13 Yoav Weiss Turn on WEB_TIMING for all ports https://bugs.webkit.org/show_bug.cgi?id=157673 Reviewed by Alex Christensen. * Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default. 2016-05-13 Brady Eidson Protector Ref/RefPtrs should have a specified naming style. https://bugs.webkit.org/show_bug.cgi?id=157591 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cpp.py: (check_identifier_name_in_declaration): (CppChecker): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (WebKitStyleTest.test_names): 2016-05-12 Csaba Osztrogonác Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards https://bugs.webkit.org/show_bug.cgi?id=157564 Reviewed by Darin Adler. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-05-11 Joanmarie Diggs [GTK] accessibility/aria-readonly.html is failing https://bugs.webkit.org/show_bug.cgi?id=98357 Reviewed by Chris Fleizach. Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly' AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements, ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined with range verification for inputs which implement AtkValue. The latter two additions are admittedly a heuristic workaround for platform accessibility API differences. But they should be sufficient to facilitate cross-platform testing of isAttributeSettable() for form elements which lack ARIA attributes. Bump the minimum version of at-spi2-core and at-spi2-atk to 2.15.4 (earliest version that supports STATE_READ_ONLY). * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::isAttributeSettable): * gtk/jhbuild.modules: 2016-05-10 Ryan Haddad Another attempt to fix the build after r200668. Unreviewed build fix. * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (TEST): 2016-05-10 Dan Bernstein Tried to fix the Mac build after r200668. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): 2016-05-10 Sam Weinig Tweak underline style for data detected links https://bugs.webkit.org/show_bug.cgi?id=157546 Reviewed by Tim Horton. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/Color.cpp: Added. (TestWebKitAPI::TEST): Add tests for the new Color::getHSV() function. 2016-05-10 Filip Pizlo Internal JSC profiler should have a timestamped log of events for each code block https://bugs.webkit.org/show_bug.cgi?id=157538 Reviewed by Benjamin Poulain. * Scripts/display-profiler-output: 2016-05-10 Michael Catanzaro [Linux] Remove seccomp filters support https://bugs.webkit.org/show_bug.cgi?id=157380 Reviewed by Darin Adler. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed. * efl/jhbuild.modules: * gtk/jhbuild.modules: 2016-05-09 Simon Fraser [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling https://bugs.webkit.org/show_bug.cgi?id=157496 rdar://problem/22963278 Reviewed by Tim Horton. Enhance UIScriptController to generate a drag, which is useful for scrolling. * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::dragFromPointToPoint): * WebKitTestRunner/UIScriptContext/UIScriptController.h: * WebKitTestRunner/ios/HIDEventGenerator.h: * WebKitTestRunner/ios/HIDEventGenerator.mm: (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]): * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::dragFromPointToPoint): 2016-05-09 Simon Fraser Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it https://bugs.webkit.org/show_bug.cgi?id=157480 Reviewed by Zalan Bujtas. Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled() and move it next to the other iOS text autosizing tests. Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree. * DumpRenderTree/TestRunner.cpp: (setTextAutosizingEnabledCallback): Deleted. (TestRunner::staticFunctions): Deleted. * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setTextAutosizingEnabled): Deleted. 2016-05-07 Darin Adler Next step on dictionary bindings, along with other bindings refinements https://bugs.webkit.org/show_bug.cgi?id=157451 Reviewed by Chris Dumez. * Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h. Also skip test expectations in a directory that this was modifying unnecessarily. 2016-05-06 Simon Fraser Enable IOS_TEXT_AUTOSIZING on Mac and make it testable https://bugs.webkit.org/show_bug.cgi?id=157432 rdar://problem/16406720 Reviewed by Dean Jackson. Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested. Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2 preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests. These two settings are shared with TEXT_AUTOSIZING. Add a TextAutosizing log channel, which is useful for generated -expected.html results. Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement without changes. An implication of this set of changes is that the way clients enable text autosizing has changed. Previously, they set the "MinimumZoomFontSize" preference to 0. Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing on iPhone only, not iPad. Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled() instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone. UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size, which will now always return 15, but had no other code that toggled this. So it's safe to just rely on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setTextAutosizingEnabled): * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: * WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformResetPreferencesToConsistentValues): 2016-05-06 Dean Jackson Regions, Shapes and Tracks don't need runtime features https://bugs.webkit.org/show_bug.cgi?id=157426 Reviewed by Simon Fraser. The following RuntimeEnabledFeatures can be removed since we have no need to disable them (they are stable and have shipped for a while): - CSS Regions - CSS Shapes - Media tracks * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Deleted. 2016-05-06 Ryan Haddad Increase delay when launching multiple ios-simulators in parallel https://bugs.webkit.org/show_bug.cgi?id=157422 Reviewed by Alexey Proskuryakov. Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_test_run): 2016-05-06 Per Arne Vollan [Win] Remove WinXP support. https://bugs.webkit.org/show_bug.cgi?id=157416 Reviewed by Brent Fulgham. * win/DLLLauncher/DLLLauncherMain.cpp: (enableTerminationOnHeapCorruption): 2016-05-06 Manuel Rego Casasnovas [css-grid] Unprefix CSS Grid Layout properties https://bugs.webkit.org/show_bug.cgi?id=157137 Reviewed by Simon Fraser. Remove "-webkit" prefix from all the grid layout properties, including the display value. Update the source code to remove the prefix where it was used too. * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: (TestWebKitAPI::TEST): 2016-05-05 Alexey Proskuryakov Partially revert http://trac.webkit.org/r200504 Improve HTTP test names in WebKitTestRunner's crash report information https://bugs.webkit.org/show_bug.cgi?id=157389 * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs in crash reporter information. 2016-05-05 Alexey Proskuryakov Improve HTTP test names in WebKitTestRunner's crash report information https://bugs.webkit.org/show_bug.cgi?id=157389 Reviewed by Alex Christensen. * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME. * WebKitTestRunner/cocoa/CrashReporterInfo.mm: (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we use other port numbers too. For http tests, return the complete URL string, not just the path. 2016-05-04 Alex Christensen Blocked redirected main resource requests need descriptive errors https://bugs.webkit.org/show_bug.cgi?id=156828 rdar://problem/25711316 Reviewed by Daniel Bates. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Print out the error type to make sure we have the most descriptive error type. 2016-05-05 Enrique Ocaña González [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE https://bugs.webkit.org/show_bug.cgi?id=157341 Reviewed by Xabier Rodriguez-Calvar. * gtk/jhbuild.modules: * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added. * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added. 2016-05-04 Srinivasan Vijayaraghavan Add JSC test results in JSON format to a Buildbot log https://bugs.webkit.org/show_bug.cgi?id=156920 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests): Move command-line option for output file out of WithProperties. 2016-05-04 Dean Jackson TestRunner should always enable all the experimental features https://bugs.webkit.org/show_bug.cgi?id=157360 Reviewed by Anders Carlsson. Call the new SPI that enables all the experimental features. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): 2016-05-04 Mark Lam ES6 Function.name inferred from property names of literal objects can break some websites. https://bugs.webkit.org/show_bug.cgi?id=157246 Reviewed by Geoffrey Garen. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): (WTR::updateTestOptionsFromTestHeader): * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::viewSupportsOptions): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::viewSupportsOptions): - Add needsSiteSpecificQuirks to WKTR options that can be set. 2016-05-04 Joanmarie Diggs AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named https://bugs.webkit.org/show_bug.cgi?id=157331 Reviewed by Chris Fleizach. Add AXLandmarkRegion to the landmark strings handled by roleToString for objects with ATK_ROLE_LANDMARK. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: 2016-05-03 Beth Dakin Add VideoControlsManager tests https://bugs.webkit.org/show_bug.cgi?id=157332 -and corresponding- rdar://problem/24358431 Reviewed by Sam Weinig. This patch adds three VideoControlsManager tests. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added. (-[DidPlayMessageHandler initWithWKWebView:]): (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added. 2016-05-03 Joanmarie Diggs [ATK] accessibility/document-attributes.html is failing https://bugs.webkit.org/show_bug.cgi?id=125348 Reviewed by Chris Fleizach. The test was failing because the WebArea is now being exposed with the role of ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that change was made, documentEncoding() and documentURI() were not updated accordingly. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::documentEncoding): (WTR::AccessibilityUIElement::documentURI): 2016-05-03 Brent Fulgham [Win] Unreviewed build fix. * EWSTools/start-queue-win.sh: Establish proper VS2015 build environment at start of queue run. 2016-05-03 Joanmarie Diggs [ATK] accessibility/content-editable-as-textarea.html fails https://bugs.webkit.org/show_bug.cgi?id=155353 Reviewed by Darin Adler. The test was timing out because it expected an AXValueChanged notification. In ATK, AXValueChanged notifications are made for widgets which implement the AtkValue interface (sliders, progress bars, etc.). We should be listening for AXTextChanged instead. AtkText's text-insert and text-remove have been added to the AccessibilityNotificationHandler. Also, ATK's AccessibilityUIElement support had a number of unimplemented methods that are being used as part of the previously-failing test. Those methods are now implemented so that the ATK results are much more similar to those on the Mac. * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::stringAttributeValue): (WTR::AccessibilityUIElement::rangeForLine): (WTR::AccessibilityUIElement::boundsForRange): (WTR::AccessibilityUIElement::attributedStringForRange): 2016-05-02 Brady Eidson Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts. https://bugs.webkit.org/show_bug.cgi?id=157274 Reviewed by Alex Christensen. Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout, and reset them in between tests: * DumpRenderTree/TestRunner.cpp: (accummulateLogsForChannel): (TestRunner::staticFunctions): (TestRunner::waitToDumpWatchdogTimerFired): (TestRunner::setAccummulateLogsForChannel): * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Also add the new method to WKTR's TestRunner, but just stubbed for now: * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::accummulateLogsForChannel): * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-05-02 Srinivasan Vijayaraghavan Add fail-fast option to run-javascriptcore-tests https://bugs.webkit.org/show_bug.cgi?id=157270 Reviewed by Geoffrey Garen. * Scripts/run-javascriptcore-tests: Add fail-fast command line option. Defaults to yes, which is the current behavior. 2016-05-02 Carlos Alberto Lopez Perez [CMake] MiniBrowser fails to build because libsoup link flags are not defined. https://bugs.webkit.org/show_bug.cgi?id=157268 Reviewed by Michael Catanzaro. * MiniBrowser/gtk/CMakeLists.txt: 2016-04-30 Darin Adler Streamline and remove unused bindings generation code https://bugs.webkit.org/show_bug.cgi?id=157237 Reviewed by Chris Dumez. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Replace non-standard "int" with standard "long", which means the same thing. 2016-04-30 Darin Adler Next batch of conversions to use C++ enum class instead of strings for enumerations https://bugs.webkit.org/show_bug.cgi?id=157232 Reviewed by Chris Dumez. * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style checking. We don't want to waste time trying to make our generated code match our style. 2016-04-29 Srinivasan Vijayaraghavan Add JSC test results in JSON format to a Buildbot log. https://bugs.webkit.org/show_bug.cgi?id=156920 Reviewed by Daniel Bates. Generate JSON results for JSC tests and upload them to the master using Buildbot's logfiles machinery. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests): Use --json-output option when invoking the run-javascriptcore-tests Perl script, and expose this JSON output as a Buildbot log. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Change key names and remove redundant count key. 2016-04-29 Joanmarie Diggs [ATK] Expose the value of aria-roledescription via an AtkObject attribute https://bugs.webkit.org/show_bug.cgi?id=146719 Reviewed by Chris Fleizach. Implement roleDescription() so that the implementation can be tested. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::roleDescription): 2016-04-27 Alexey Proskuryakov Don't throttle GuardMalloc on 8-core Macs https://bugs.webkit.org/show_bug.cgi?id=157108 Reviewed by Alex Christensen. This was making them slower unnecessarily. * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes): 2016-04-26 Konstantin Tokarev Unreviewed: add myself to the committers list. * Scripts/webkitpy/common/config/contributors.json: 2016-04-26 Ryosuke Niwa Fix text in log files autogenerated by import-w3c-tests https://bugs.webkit.org/show_bug.cgi?id=157021 Unreviewed. Fixing the second typo. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.write_import_log): 2016-04-26 Filip Pizlo WebCore on Mac ignores the user's preferred region (country) while getting the language https://bugs.webkit.org/show_bug.cgi?id=156993 Reviewed by Geoffrey Garen. Change the test expectations for this test. If the variant is not explicitly specified in the AppleLanguage, then we use the locale's country code, which this test assumes is US. * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: (TestWebKitAPI::languageForSystemLanguage): (TestWebKitAPI::TEST): 2016-04-25 Ryosuke Niwa Remove the build flag for template elements https://bugs.webkit.org/show_bug.cgi?id=157022 Reviewed by Daniel Bates. Removed the build option. * Scripts/webkitperl/FeatureList.pm: 2016-04-25 Ryosuke Niwa Fix text in log files autogenerated by import-w3c-tests https://bugs.webkit.org/show_bug.cgi?id=157021 Reviewed by Chris Dumez. s/Webkit/WebKit/ and end each sentence with a period. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.write_import_log): 2016-04-25 Myles C. Maxfield [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr https://bugs.webkit.org/show_bug.cgi?id=156929 Reviewed by Darin Adler. * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST): 2016-04-25 Caitlin Potter [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore https://bugs.webkit.org/show_bug.cgi?id=156976 Reviewed by Darin Adler. Mitigate style-checker spam on bugs which introduce new JavaScript token types. * Scripts/webkitpy/style/checkers/cpp.py: (_EnumState.__init__): (_EnumState.process_clean_line): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (NoNonVirtualDestructorsTest.test_enum_casing): 2016-04-25 Simon Fraser Fix issues with content-animation performance tests https://bugs.webkit.org/show_bug.cgi?id=157001 Reviewed by Sam Weinig. Add patch content for svg-animation.html, and fix the paths in the patch so it applies correctly. Add the patch file to the .plan file. * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: 2016-04-25 Brady Eidson Tweaking IndexedDB watchlist and adding myself to it. * Scripts/webkitpy/common/config/watchlist: 2016-04-25 Commit Queue Unreviewed, rolling out r199916. https://bugs.webkit.org/show_bug.cgi?id=156989 Might break buildbot when master is restarted (Requested by Srinivasan Vijayaraghava, Guest100, on #webkit). Reverted changeset: "Add JSC test results in json format to a buildbot log" https://bugs.webkit.org/show_bug.cgi?id=156920 http://trac.webkit.org/changeset/199916 2016-04-23 Chris Dumez [WebIDL] Drop [Default] WebKit-IDL extended attribute https://bugs.webkit.org/show_bug.cgi?id=156955 Reviewed by Darin Adler. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: 2016-04-23 Csaba Osztrogonác Really enable INDEXED_DATABASE on Apple Mac cmake build https://bugs.webkit.org/show_bug.cgi?id=156902 Reviewed by Michael Catanzaro. * Scripts/webkitperl/FeatureList.pm: 2016-04-23 Andy Estes check-webkit-style: fix false-positive warnings about @synchronized https://bugs.webkit.org/show_bug.cgi?id=156957 Reviewed by Dan Bernstein. * Scripts/webkitpy/style/checkers/cpp.py: (check_spacing_for_function_call): Ignore @synchronized lines. (check_braces): Ditto. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_brace_at_begin_of_line): Added a test case. 2016-04-22 Srinivasan Vijayaraghavan Add JSC test results in json format to a buildbot log https://bugs.webkit.org/show_bug.cgi?id=156920 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests): Add runtime flag to output json into buildbot * Scripts/run-javascriptcore-tests: (runJSCStressTests): Change key names and remove redundant count key 2016-04-22 Ryan Haddad Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854 Unreviewed test gardening. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: (TestWebKitAPI::TEST): 2016-04-22 Carlos Garcia Campos [GTK] Enable the download attribute support https://bugs.webkit.org/show_bug.cgi?id=99025 Reviewed by Žan Doberšek. * Scripts/webkitperl/FeatureList.pm: 2016-04-21 Keith Miller WebScriptObject description swizzler should work in a multi-threaded world https://bugs.webkit.org/show_bug.cgi?id=156808 Add a test for our NSObject swizzling TLS implementation. The test runs on two threads. One in JS and another in Objective-C. We expect the JS thread to use our NSObject description override and the Objective-C thread to act as though it was using the original NSObject description method. Reviewed by Geoffrey Garen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added. * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added. (nsObjectDescriptionTest): (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]): (TestWebKitAPI::TEST): 2016-04-21 Carlos Garcia Campos [GTK] WebKitWebView should claim the contents size as its natural size https://bugs.webkit.org/show_bug.cgi?id=156835 Reviewed by Žan Doberšek. Add test case to check the WebKitWebView preferred size. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewPreferredSize): (beforeAll): 2016-04-20 Simon Fraser Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results https://bugs.webkit.org/show_bug.cgi?id=156827 Update the .plan file now that the files are present in SVN. * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: 2016-04-20 Simon Fraser Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results https://bugs.webkit.org/show_bug.cgi?id=156827 rdar://problem/24358135 Reviewed by Stephanie Lewis. Enhance benchmark_runner so that a benchmark can load a set of tests sequentially, and collate results across them. Also add the ability for the browser_driver to supply additional results, allowing for tests that collect results data in native code, rather than generating it in the web page. Add a set of "content animation" tests that use this new functionality, which test CSS animation and requestAnimationFrame performance. 'plan' files have two new optional keys: 'test_files': a list of files to run as a suite 'options': optional parameters. Currently supports one new option, 'animation_command', which affects the way that iOS tests are run, and is passed to MobileSafari as a parameter on launch. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary. (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results. (BenchmarkRunner): (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for running a single test. It starts and stops the http_server_driver. (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point' key, otherwise look for the new 'test_files' and load each in a loop. (BenchmarkRunner._dump): * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: (BrowserDriver.launch_url): Pass options. (BrowserDriver.add_additional_results): Allow a driver to supply additional results. (BrowserDriver): * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: (GTKMiniBrowserDriver.launch_url): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver.close_browsers): (OSXBrowserDriver._terminate_processes): Fix spelling mistake. (OSXBrowserDriver._terminiate_processes): Deleted. * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: (OSXChromeDriver.launch_url): (OSXChromeCanaryDriver.launch_url): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: (OSXFirefoxDriver.launch_url): (OSXFirefoxNightlyDriver.launch_url): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: (OSXSafariDriver.launch_url): * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added. * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added. 2016-04-20 Dustin Falgout [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18 https://bugs.webkit.org/show_bug.cgi?id=156651 Reviewed by Michael Catanzaro. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: (testWebKitSettings): 2016-04-20 Brady Eidson Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures. https://bugs.webkit.org/show_bug.cgi?id=156782 Reviewed by Alex Christensen. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-04-19 Brent Fulgham Unreviewed build fix after r199752. * DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didChangeIcons): Remove call to removed function. 2016-04-19 Brent Fulgham Remove remaining bits of dynamic rel='icon' loading https://bugs.webkit.org/show_bug.cgi?id=156727 Reviewed by Darin Adler. Remove unused test infrastructure. This code never existed in WebKit2 testing since was only used on Windows. * DumpRenderTree/TestRunner.cpp: (dumpIconChangesCallback): Deleted. * DumpRenderTree/TestRunner.h: (TestRunner::dumpIconChanges): Deleted. (TestRunner::setDumpIconChanges): Deleted. 2016-04-19 Keith Miller ObjcInstance::stringValue should not call NSObject's description method https://bugs.webkit.org/show_bug.cgi?id=156758 Reviewed by Geoffrey Garen. Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't call the NSObjects description method without first swizzling it. * DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController testArrayOfObjects]): (-[ObjCController testObject]): 2016-04-18 Dan Bernstein Fixed building with old Xcode. * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm: (TEST): 2016-04-18 Dean Jackson New SPI to export a dictionary of runtime features https://bugs.webkit.org/show_bug.cgi?id=156645 Reviewed by Darin Adler. Test the experimental features SPI on WKPreferences. * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm: 2016-04-18 Yusuke Suzuki [JSCOnly] Implement RunLoop and remove glib dependency https://bugs.webkit.org/show_bug.cgi?id=155706 Reviewed by Michael Catanzaro. Add TestWTF to JSCOnly port to test WorkQueue and RunLoop. Platform specific ones locate under jsconly directory since it is not `generic` (Since it includes the GLIB event loop case). * CMakeLists.txt: * TestWebKitAPI/PlatformJSCOnly.cmake: Added. * TestWebKitAPI/PlatformUtilities.h: * TestWebKitAPI/Tests/WTF/RunLoop.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/config.h: * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp. (TestWebKitAPI::Util::run): (TestWebKitAPI::Util::sleep): * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp. (main): 2016-04-18 Jon Lee Update Animometer plan. https://bugs.webkit.org/show_bug.cgi?id=156652 Reviewed by Darin Adler. * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616. 2016-04-18 Dana Burkart svn-apply: add option for ignoring changes to ChangeLog files https://bugs.webkit.org/show_bug.cgi?id=156618 Reviewed by Darin Adler. This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of patch() if the file in question is a ChangeLog. * Scripts/svn-apply: (patch): 2016-04-18 Carlos Garcia Campos Pending API Request URL is wrong after reloading https://bugs.webkit.org/show_bug.cgi?id=139342 Reviewed by Darin Adler. Update test case to check that the active URL should remain the same after a reload. * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: (TestWebKitAPI::TEST): 2016-04-18 Carlos Garcia Campos Pending API request URL no set when loading Data, Alternate HTML or plain text https://bugs.webkit.org/show_bug.cgi?id=136916 Reviewed by Darin Adler. Add new test to check that active URL is the requested one right after calling WKPage load methods. * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added. (TestWebKitAPI::TEST): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::loadPlainText): Remove FIXME. (WebViewTest::loadBytes): Ditto. (WebViewTest::loadAlternateHTML): Ditto. 2016-04-18 Commit Queue Unreviewed, rolling out r199660. https://bugs.webkit.org/show_bug.cgi?id=156691 It broke the iOS build (Requested by KaL on #webkit). Reverted changeset: "Pending API request URL no set when loading Data, Alternate HTML or plain text" https://bugs.webkit.org/show_bug.cgi?id=136916 http://trac.webkit.org/changeset/199660 2016-04-18 Carlos Garcia Campos Pending API request URL no set when loading Data, Alternate HTML or plain text https://bugs.webkit.org/show_bug.cgi?id=136916 Reviewed by Darin Adler. Add new test to check that active URL is the requested one right after calling WKPage load methods. * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added. (TestWebKitAPI::TEST): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::loadPlainText): Remove FIXME. (WebViewTest::loadBytes): Ditto. (WebViewTest::loadAlternateHTML): Ditto. 2016-04-18 Jeremy Huddleston Sequoia Fix incorrect assumption that APPLE implies Mac. https://bugs.webkit.org/show_bug.cgi?id=156679 Addresses build failure introduced in r198947 Reviewed by Alex Christensen. * CMakeLists.txt: 2016-04-18 Carlos Garcia Campos [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars https://bugs.webkit.org/show_bug.cgi?id=156621 Reviewed by Martin Robinson. This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not. * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test. 2016-04-17 Gyuyoung Kim [EFL] Bump gstreamer from 1.4.4 to 1.6.3 https://bugs.webkit.org/show_bug.cgi?id=156655 Reviewed by Antonio Gomes. To support html5 video feature, we should bump gstreamer version. * efl/jhbuild.modules: * efl/patches/gst-libav.patch: Update against newer version. * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged. 2016-04-16 Sam Weinig More build fixing. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController share:]): 2016-04-16 Sam Weinig Another build fix. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]): 2016-04-16 Sam Weinig Fix 32-bit build. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController share:]): (-[BrowserWindowController fetch:]): (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]): 2016-04-15 Sam Weinig Add support for NSSharingService to MiniBrowser, for no great reasons https://bugs.webkit.org/show_bug.cgi?id=156658 Reviewed by Darin Adler. * MiniBrowser/mac/BrowserWindow.xib: * MiniBrowser/mac/BrowserWindowController.h: Add the share button. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu. (-[BrowserWindowController share:]): Show the picker when the button is pressed. (-[BrowserWindowController mainContentView]): Add a new override to get the main content view of derived classes (either a WKWebView or the WebView). (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]): (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]): (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]): (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]): (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]): (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]): Add delegate methods. * MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController mainContentView]): * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController mainContentView]): Implement to return the web view. 2016-04-16 Alexey Proskuryakov Build fix. Temporary workaround for rdar://problem/25754945. * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: 2016-04-15 Commit Queue Unreviewed, rolling out r199600. https://bugs.webkit.org/show_bug.cgi?id=156642 It didn't help (Requested by ap_ on #webkit). Reverted changeset: "Build fix." http://trac.webkit.org/changeset/199600 2016-04-15 Alexey Proskuryakov Build fix. * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods. 2016-04-14 Alexey Proskuryakov Some GuardMalloc bots are not happy when running many parallel processes https://bugs.webkit.org/show_bug.cgi?id=156614 rdar://problem/24711525 Reviewed by David Kilzer. * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes): 2016-04-14 Brent Fulgham Make a runtime enabled option https://bugs.webkit.org/show_bug.cgi?id=156583 Reviewed by Alex Christensen. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setDownloadAttributeEnabled): * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-04-14 Anders Carlsson Another build fix attempt. * MiniBrowser/mac/WK2BrowserWindowController.m: 2016-04-14 Anders Carlsson Fix build. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]): 2016-04-14 Anders Carlsson [Mac] Add API for open panel handling to WKWebView https://bugs.webkit.org/show_bug.cgi?id=137759 rdar://problem/23278623 Reviewed by Tim Horton. Have MiniBrowser implement the new delegate method. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]): 2016-04-14 Jiewen Tan Unreviewed, rolling out r199554. The change breaks Yosemite Release/Debug build Reverted changeset: "[Mac] Add API for open panel handling to WKWebView" https://bugs.webkit.org/show_bug.cgi?id=137759 http://trac.webkit.org/changeset/199554 2016-04-14 Anders Carlsson [Mac] Add API for open panel handling to WKWebView https://bugs.webkit.org/show_bug.cgi?id=137759 rdar://problem/23278623 Reviewed by Tim Horton. Have MiniBrowser implement the new delegate method. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]): 2016-04-14 Jon Lee Update Animometer plan https://bugs.webkit.org/show_bug.cgi?id=156569 Reviewed by Alex Christensen. * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests. 2016-04-13 Alex Christensen CMake MiniBrowser should be an app bundle https://bugs.webkit.org/show_bug.cgi?id=156521 Reviewed by Brent Fulgham. * MiniBrowser/mac/CMakeLists.txt: Make an app bundle and compile nibs. * MiniBrowser/mac/Info.plist: CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it. This is just MiniBrowser. 2016-04-13 Chris Dumez We should not speculatively revalidate cached redirects https://bugs.webkit.org/show_bug.cgi?id=156548 Reviewed by Darin Adler. Re-enable speculative loading in the context of layout tests. This was turned off by mistake when speculative loading was turned into a setting recently. * WebKitTestRunner/TestController.cpp: (WTR::TestController::generatePageConfiguration): 2016-04-12 Alexey Proskuryakov Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky https://bugs.webkit.org/show_bug.cgi?id=155367 Reviewed by Darin Adler. * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process): Don't flakily consume the return code with waitpid, callers need to do waitpid on their own. Not sure if this line of code was even intentional. 2016-04-12 Myles C. Maxfield [OS X] Flakey crash after ScrollAnimatorMac destruction https://bugs.webkit.org/show_bug.cgi?id=156372 Reviewed by Darin Adler. Implement the new flag. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions): (WTR::TestController::ensureViewSupportsOptionsForTest): (WTR::TestController::resetPreferencesToConsistentValues): (WTR::TestController::resetStateToConsistentValues): (WTR::updateTestOptionsFromTestHeader): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WKR::PlatformWebView::viewSupportsOptions): 2016-04-12 Tomas Popela Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported https://bugs.webkit.org/show_bug.cgi?id=156338 Reviewed by Michael Catanzaro. Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just for the i686 where it is supported and not for other architectures (such as s390(x) and ppc(64)) where the build will fail with these CXXFLAGS. * Scripts/webkitdirs.pm: (generateBuildSystemFromCMakeProject): 2016-04-11 Alex Christensen Build MiniBrowser with CMake on Mac https://bugs.webkit.org/show_bug.cgi?id=156471 Reviewed by Daniel Bates. * CMakeLists.txt: * DumpRenderTree/CMakeLists.txt: * DumpRenderTree/PlatformWin.cmake: * MiniBrowser/mac/CMakeLists.txt: Added. 2016-04-11 Ryuan Choi [EFL] Do not pass context to EwkViewCreate https://bugs.webkit.org/show_bug.cgi?id=156461 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls. * TestWebKitAPI/efl/PlatformWebView.cpp: (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: (WTR::PlatformWebView::PlatformWebView): Ditto. 2016-04-11 Fujii Hironori [CMake] Make FOLDER property INHERITED https://bugs.webkit.org/show_bug.cgi?id=156460 Reviewed by Brent Fulgham. * CMakeLists.txt: * DumpRenderTree/CMakeLists.txt: * DumpRenderTree/PlatformWin.cmake: * ImageDiff/CMakeLists.txt: * MiniBrowser/efl/CMakeLists.txt: * MiniBrowser/gtk/CMakeLists.txt: * MiniBrowser/win/CMakeLists.txt: Set FOLDER property as a directory property not a target property 2016-04-10 Caitlin Potter [Tools] correctly check for braces in multiline branches in macro definition https://bugs.webkit.org/show_bug.cgi?id=156441 Reviewed by Darin Adler. Prevents emitting whitespace/braces warning for code like the following: ``` #define MACRO(x) \ if (x) { \ doTheThing(); \ continue; \ } ``` * Scripts/webkitpy/style/checkers/cpp.py: (check_braces): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (WebKitStyleTest.test_line_breaking): 2016-04-08 Youenn Fablet Testharness-based tests that time out should be able to produce a detailed output https://bugs.webkit.org/show_bug.cgi?id=145313 Reviewed by Xabier Rodriguez-Calvar. Adding timeout readonly accessor to TestRunner for both WK1 and WK2. * DumpRenderTree/TestRunner.cpp: (getTimeoutCallback): The js "timeout" property getter. (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value. * DumpRenderTree/TestRunner.h: (TestRunner::timeout): Adding access to DRT m_timeout private value. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS. * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition. (WTR::TestRunner::timeout): 2016-04-07 Joseph Pecoraro stylebot should know about TestWebKitAPI FeatureDefines.xcconfig https://bugs.webkit.org/show_bug.cgi?id=156387 Rubber-stamped by Dan Bernstein. * Scripts/webkitpy/style/checkers/featuredefines.py: (FeatureDefinesChecker.check): 2016-04-07 Joseph Pecoraro Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards https://bugs.webkit.org/show_bug.cgi?id=156384 Reviewed by Ryosuke Niwa. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-04-06 Dean Jackson Watchlist modifications: - remove roger_fong - add myself to a few areas - remove graouts from WebInspectorAPI * Scripts/webkitpy/common/config/watchlist: 2016-04-07 Simon Fraser Make it possible to test effect of view exposed rect on tiled backing https://bugs.webkit.org/show_bug.cgi?id=156365 Reviewed by Tim Horton. Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable testing of tile coverage when setViewExposedRect() is passed a non-null rectangle. testRunner.setViewSize() is used instead of using window.resizeTo(), since we can't easily resize a window to larger than the screen being tested on. * DumpRenderTree/TestRunner.cpp: (setViewSizeCallback): (TestRunner::staticFunctions): * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setViewSize): * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::postSetViewSize): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setViewSize): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): 2016-04-07 Jason Marcell Adding layout tests for the bot watcher's dashboard QUnit tests. https://bugs.webkit.org/show_bug.cgi?id=155272 Reviewed by Daniel Bates. Moved supporting resources into a resources folder and updated index.html accordingly to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js. (MockBuildbotQueue): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js. (MockBuildbotQueueView): (MockBuildbotQueueView.prototype._latestProductiveIteration): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js. (MockTrac): (MockTrac.prototype.get oldestRecordedRevisionNumber): (MockTrac.prototype.get latestRecordedRevisionNumber): (MockTrac.prototype.loadMoreHistoricalData): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js. Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory. (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done. * Scripts/run-dashboard-tests: Added. 2016-04-06 ChangSeok Oh Unreviewed, Update my primary email address and expertise. * Scripts/webkitpy/common/config/contributors.json: 2016-04-06 Jon Lee Update the Animometer patch and plan files https://bugs.webkit.org/show_bug.cgi?id=156263 Reviewed by Ryosuke Niwa. Measure the latest set of tests by updating the plan revision to r199134. * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only. * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead of the developer page. 2016-04-06 Saam barati jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989 https://bugs.webkit.org/show_bug.cgi?id=156187 Reviewed by Keith Miller. * Scripts/run-jsc-stress-tests: 2016-04-06 Alex Christensen Compile WebKitTestRunner with CMake on Mac https://bugs.webkit.org/show_bug.cgi?id=156310 Reviewed by Daniel Bates. * CMakeLists.txt: * WebKitTestRunner/CMakeLists.txt: * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: * WebKitTestRunner/PlatformEfl.cmake: * WebKitTestRunner/PlatformGTK.cmake: * WebKitTestRunner/PlatformMac.cmake: Added. 2016-04-05 Simon Fraser Implement operator== and operator!= for Optional<> https://bugs.webkit.org/show_bug.cgi?id=156266 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WTF/Optional.cpp: (TestWebKitAPI::TEST): 2016-04-05 Alex Christensen Make CMake-generated binaries on Mac able to run https://bugs.webkit.org/show_bug.cgi?id=156268 Reviewed by Daniel Bates. * DumpRenderTree/CMakeLists.txt: * DumpRenderTree/PlatformMac.cmake: * DumpRenderTree/PlatformWin.cmake: * TestWebKitAPI/PlatformMac.cmake: 2016-04-05 Youenn Fablet [Fetch API] Add a runtime flag to fetch API and related constructs https://bugs.webkit.org/show_bug.cgi?id=156113 Reviewed by Alex Christensen. * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setWebGL2Enabled): (WTR::TestRunner::setFetchAPIEnabled): (WTR::TestRunner::setAllowUniversalAccessFromFileURLs): * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-04-05 Keith Miller Make Keith a reviewer! https://bugs.webkit.org/show_bug.cgi?id=156246 Reviewed by Mark Lam. * Scripts/webkitpy/common/config/contributors.json: 2016-04-05 Antoine Quint [WebGL2] Allow enabling WebGL2 with a runtime flag https://bugs.webkit.org/show_bug.cgi?id=156166 Always enable WebGL2 during testing. Reviewed by Dean Jackson. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setWebGL2Enabled): * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-04-04 Bill Ming [win] run-webkit-tests failed to launch DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=156150 Reviewed by Alex Christensen. * Tools/Scripts/webkitpy/port/base.py: 2016-04-04 Bill Ming prepare-ChangeLog set endl incorrectly. https://bugs.webkit.org/show_bug.cgi?id=156151 Reviewed by Alex Christensen. * Tools/Scripts/prepare-ChangeLog: 2016-04-03 Sam Weinig Add SPI to allow install script message handlers in isolated worlds https://bugs.webkit.org/show_bug.cgi?id=156153 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld 2016-04-04 Jiewen Tan Build fix for r198956. Unreviewed. * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]): * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): 2016-04-04 Bill Ming [win] prepare-ChangeLog should treat windows path differently. https://bugs.webkit.org/show_bug.cgi?id=156120 Reviewed by Brent Fulgham. * Scripts/prepare-ChangeLog: 2016-04-04 Alejandro G. Castro REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations https://bugs.webkit.org/show_bug.cgi?id=156164 Reviewed by Philippe Normand. Enable the new WEB_RTC option by default for Gtk+. * Scripts/webkitperl/FeatureList.pm: 2016-04-03 Dan Bernstein Use the correct value for the first nightly build with frameworks built for OS X 10.11. * Scripts/bisect-builds: (makeNightlyList): 2016-04-03 Dan Bernstein Made bisect-builds work again. Rubber-stamped by Sam Weinig. * Scripts/bisect-builds: Changed to use HTTPS to access nightly.webkit.org, and added a minimum revision for OS X 10.11. 2016-04-01 Jiewen Tan Build fix for r198956. Unreviewed. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm. (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): (TEST): * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: (-[LoadInvalidSchemeDelegate browsingContextController:didFailProvisionalLoadWithError:]): (TestWebKitAPI::TEST): 2016-04-01 Jiewen Tan WebKit should dispatchDidFailProvisionalLoad while loading invalid URLs https://bugs.webkit.org/show_bug.cgi?id=155995 Reviewed by Andy Estes. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]): (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didStartProvisionalNavigation:]): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Added. (literalURL): (-[LoadInvalidURLNavigationActionDelegate webView:didCommitNavigation:]): (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html: Added. * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: Added. (-[LoadInvalidURLWebFrameLoadDelegate webView:didCommitLoadForFrame:]): (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (TestWebKitAPI::TEST): 2016-04-01 Brent Fulgham Confirm satisfies specification criteria https://bugs.webkit.org/show_bug.cgi?id=156057 Reviewed by Andy Estes. Revise WebKitTestRunner: (1) Provide a download client delegate. (2) Teach WKTR to wait to finish a test until a download finishes. (3) Allow WKTR to notify the current TestRunner that it can finish. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): Update to recognize a new message "NotifyDownloadDone". * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::decidePolicyForNavigationAction): Handle 'download' attribute case. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::waitUntilDownload): Added. * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::shouldFinishAfterDownload): Added. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions): Set up the download client. (WTR::TestController::downloadDidStart): Added. (WTR::TestController::decideDestinationWithSuggestedFilename): Added. (WTR::TestController::downloadDidFinish): Added. (WTR::TestController::downloadDidFail): Added. (WTR::TestController::downloadDidCancel): Added. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::notifyDownloadDone): Added. * WebKitTestRunner/TestInvocation.h: 2016-04-01 Alex Christensen Compile DumpRenderTree with CMake on Mac https://bugs.webkit.org/show_bug.cgi?id=156088 Reviewed by Brent Fulgham. * CMakeLists.txt: * DumpRenderTree/CMakeLists.txt: * DumpRenderTree/DefaultPolicyDelegate.m: (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): * DumpRenderTree/DumpRenderTreeFileDraggingSource.m: * DumpRenderTree/PlatformMac.cmake: Added. * DumpRenderTree/PlatformWin.cmake: * DumpRenderTree/mac/AppleScriptController.m: (convertAEDescToObject): * DumpRenderTree/mac/DumpRenderTreeMain.mm: * DumpRenderTree/mac/LayoutTestHelper.m: 2016-03-31 Bill Ming https://bugs.webkit.org/show_bug.cgi?id=156094 [Win] TestWebCore target build sometimes fail. Reviewed by Alex Christensen. * Tools/TestWebKitAPI/PlatformWin.cmake: 2016-03-31 Gyuyoung Kim [EFL] Bump EFL version to 1.17.0 https://bugs.webkit.org/show_bug.cgi?id=153008 Reviewed by Michael Catanzaro. Original author is Csaba Osztrogonác * efl/jhbuild.modules: 2016-03-31 Daniel Bates run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled https://bugs.webkit.org/show_bug.cgi?id=156071 Reviewed by Brent Fulgham. Fixes an issue where run-webkit-tests will fail to create the suffixed user's cache directory on non-Apple Internal machines with System Integrity Protection enabled because the OS only honors the suffix, specified by the environment variable DIRHELPER_USER_DIR_SUFFIX, in privileged processes. And python(1) does not have sufficient privileges. As a workaround for systems that have System Integrity Protection enabled we compute the path to the suffixed user's cache directory by hand. Additionally, fix an issue where the user's cache directory created by run-webkit-test was never deleted on cessation of the test run. * Scripts/webkitpy/port/driver.py: (Driver._start): Actually store the path to the user's cache directory in self._driver_user_cache_directory so that we can delete this directory on cessation of the test run. * Scripts/webkitpy/port/mac.py: (MacPort): (MacPort._path_to_user_cache_directory): Unset the environment variable DIRHELPER_USER_DIR_SUFFIX (if set), query the OS for the path to the user's cache directory and concatenate this path with the specified suffix. 2016-03-31 Jiewen Tan WebKit should set Original URL of a download request correctly https://bugs.webkit.org/show_bug.cgi?id=155914 Reviewed by Anders Carlsson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[DownloadRequestOriginalURLDelegate initWithExpectOriginalURL:]): (-[DownloadRequestOriginalURLDelegate _downloadDidStart:]): (-[DownloadRequestOriginalURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): (TEST): * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Added. * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Added. 2016-03-30 Dewei Zhu Extend animometer timeout for slow CPUs. https://bugs.webkit.org/show_bug.cgi?id=156047 Reviewed by Ryosuke Niwa. Extend animometer timeout to 30 minutes for slow device. * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: 2016-03-30 Daniel Bates run-webkit-tests must create parent directory of user's cache directory before running tests https://bugs.webkit.org/show_bug.cgi?id=156009 Reviewed by Alexey Proskuryakov. The script run-webkit-tests must create the parent directory of the user's cache directory before running tests because a WebKit2 child process expects that this directory exists when it starts. The script run-webkit-tests influences the path chosen by a WebKit2 child process for the user's temporary directory and user's cache directory via the environment variable DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it as part of setting up the test environment. But run-webkit-tests does not create the user's cache directory. Therefore there is race between the time AppKit creates it and when the launched WebContent and Network processes query for the path to the user's cache directory such that the OS may return the empty string to the WebContent and Network processes if queried for this directory before AppKit creates it. * Scripts/webkitpy/port/base.py: (Port._path_to_user_cache_directory): Added. Base class implementation that returns the empty string. We will override this method for the OS X port to return the path to the user's cache directory with the specified suffix. (Port.remove_cache_directory): Deleted. * Scripts/webkitpy/port/driver.py: (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory to the suffix to use for the user's temporary and cache directories and the path to the user's cache directory, respectively. (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX to self._driver_user_directory_suffix. (Driver._start): Compute the user directory suffix and the path to the user's cache directory. Create the user's cache directory (if applicable). (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable). * Scripts/webkitpy/port/mac.py: (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory(). (MacPort.remove_cache_directory): Deleted. 2016-03-29 Benjamin Poulain [WTF] Removing a smart pointer from HashTable issues two stores to the same location https://bugs.webkit.org/show_bug.cgi?id=155676 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/HashMap.cpp: * TestWebKitAPI/Tests/WTF/HashSet.cpp: 2016-03-29 Srinivasan Vijayaraghavan Add machine-readable results for JSC stress tests https://bugs.webkit.org/show_bug.cgi?id=155771 Reviewed by Darin Adler and Dean Johnson Add an option to output JSC stress test results to a user-specified file in JSON format. * Scripts/run-javascriptcore-tests: (runJSCStressTests): Add JSON output support (readAllLines): Remove trailing newline from the end of each item 2016-03-29 Alex Christensen Fix Windows build. * TestWebKitAPI/PlatformWin.cmake: 2016-03-29 Timothy Hatcher Update WebKit nightly to have a red needle to better match Safari https://bugs.webkit.org/show_bug.cgi?id=155983 Reviewed by Joseph Pecoraro. * WebKitLauncher/webkit.icns: 2016-03-28 Joanmarie Diggs Adding myself as a reviewer. Unreviewed. * Scripts/webkitpy/common/config/contributors.json: 2016-03-25 Dewei Zhu Dromaeo patch used by run-benchmark should not include an invalid address. https://bugs.webkit.org/show_bug.cgi?id=155910 Reviewed by Ryosuke Niwa. Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test. * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: 2016-03-25 Daniel Bates Add WebKitSystemInterface for iOS 9.3 https://bugs.webkit.org/show_bug.cgi?id=155893 Rubber-stamped by Alexey Proskuryakov. * Scripts/copy-webkitlibraries-to-product-directory: 2016-03-25 Daniel Bates Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK() in copy-webkitlibraries-to-product-directory https://bugs.webkit.org/show_bug.cgi?id=155869 Reviewed by Alexey Proskuryakov. It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command line argument. * Scripts/copy-webkitlibraries-to-product-directory: 2016-03-25 Konstantin Tokarev Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port. https://bugs.webkit.org/show_bug.cgi?id=155882 Reviewed by Michael Catanzaro. It was already enabled in all trunk ports, and is required for WebInspectorUI to work. * Scripts/webkitperl/FeatureList.pm: 2016-03-24 Jeremy Zerfas Improve update-webkit-dependency script. https://bugs.webkit.org/show_bug.cgi?id=155576 Reviewed by Brent Fulgham. * Scripts/update-webkit-dependency: -Updated script to also use ETags for helping to determine whether dependency is up to date. -Updated script so it usually won't need to download the entire dependency each time it is ran. -Updated script to ensure zip file contains expected directories before trying to install. -Added some more error checking and improved error messages. (lastModifiedToUnixTime): Deleted. * Scripts/update-webkit-wincairo-libs: -Corrected comment about what script does. 2016-03-24 Bill Ming Fix webkitpy tests after r198617 https://bugs.webkit.org/show_bug.cgi?id=155827 Reviewed by Alex Christensen. * Scripts/webkitpy/tool/steps/confirmdiff.py: (ConfirmDiff._show_pretty_diff): 2016-03-23 Bill Ming webkit-patch failed to open pretty diff on Windows https://bugs.webkit.org/show_bug.cgi?id=155827 Reviewed by Alex Christensen. * Scripts/webkitpy/tool/steps/confirmdiff.py: (ConfirmDiff._show_pretty_diff): 2016-03-23 Jer Noble [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing https://bugs.webkit.org/show_bug.cgi?id=155764 Reviewed by Eric Carlson. Remove the requirement for media elements to have webkit-playsinline attributes on iOS. * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::SetUp): 2016-03-23 Anders Carlsson Crash when using KVO from within -[WebView initWithCoder:] https://bugs.webkit.org/show_bug.cgi?id=155816 rdar://problem/17073265 Reviewed by Dan Bernstein. Add test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added. (-[EarlyKVOCrashResponder initWithWebView:]): (-[EarlyKVOCrashResponder initWithCoder:]): (-[EarlyKVOCrashResponder dealloc]): (-[EarlyKVOCrashResponder encodeWithCoder:]): (TestWebKitAPI::TEST): 2016-03-23 Lucas Forschler Teach kill-old-processes about perl 5.18. Reviewed by Alexey Proskuryakov * BuildSlaveSupport/kill-old-processes: (main): 2016-03-22 Keith Rollin Unreviewed: add Keith Rollin to the committers list. * Scripts/webkitpy/common/config/contributors.json: 2016-03-22 Per Arne Vollan [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround https://bugs.webkit.org/show_bug.cgi?id=141499 Reviewed by Brent Fulgham. As we have moved on to VS2015, this workaround is no longer needed. * DumpRenderTree/cg/ImageDiffCG.cpp: (main): * DumpRenderTree/win/DumpRenderTree.cpp: (main): * DumpRenderTree/win/ImageDiffCairo.cpp: (main): * MiniBrowser/win/Common.cpp: (DllMain): * TestWebKitAPI/win/main.cpp: (main): * win/DLLLauncher/DLLLauncherMain.cpp: (wWinMain): 2016-03-22 Yusuke Suzuki [JSC] ASMBench cannot be run without JSBENCH_PATH https://bugs.webkit.org/show_bug.cgi?id=155751 Reviewed by Saam Barati. Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files. * Scripts/run-jsc-benchmarks: 2016-03-21 Brent Fulgham [Win] SharedBuffer::copy() can cause a segmentation fault. https://bugs.webkit.org/show_bug.cgi?id=155739 Reviewed by Ryosuke Niwa. * TestWebKitAPI/PlatformWin.cmake: Build and run the SharedBuffer tests. 2016-03-22 Csaba Osztrogonác [buildbot] Move ARM Linux bots to JSCOnly port https://bugs.webkit.org/show_bug.cgi?id=155655 Reviewed by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (ConfigureBuild.__init__): (appendCustomBuildFlags): (CompileJSCOnly): (Factory.__init__): (BuildAndRemoteJSCTestsFactory): (BuildAndRemoteJSCTestsFactory.__init__): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: * BuildSlaveSupport/clean-build: (main): 2016-03-21 Brent Fulgham Improve SharedBuffer testing https://bugs.webkit.org/show_bug.cgi?id=93078 Reviewed by Ryosuke Niwa. Based on a Blink patch by Huang Dongsung . Add three test cases from the Blink project that cover various append, copy, and createArrayBuffer calls. * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: (TestWebKitAPI::TEST_F): 2016-03-21 Hyungwook Lee [Win] Connect layoutTestController.findString() to support testing https://bugs.webkit.org/show_bug.cgi?id=50234 Reviewed by Alex Christensen. Implement TestRunner::findString(). * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::findString): 2016-03-20 Dan Bernstein [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR https://bugs.webkit.org/show_bug.cgi?id=155707 Reviewed by Darin Adler. * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET. * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version. Similarly for these projects: * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * LayoutTestRelay/Configurations/Base.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebEditingTester/Configurations/Base.xcconfig: * WebEditingTester/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: 2016-03-20 Dan Bernstein Update build settings Rubber-stamped by Andy Estes. * ContentExtensionTester/Configurations/DebugRelease.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * LayoutTestRelay/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source. * WebEditingTester/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: * asan/asan.xcconfig: 2016-03-18 Sam Weinig Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost https://bugs.webkit.org/show_bug.cgi?id=155621 Reviewed by Alex Christensen. * TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger): (TestWebKitAPI::testMovingUsingEnsure): (TestWebKitAPI::testMovingUsingAdd): Add tests ensuring that objects moved into a map using ensure don't have extra ref-churn. 2016-03-17 Tim Horton Fix some deprecation warnings in WebEditingTester https://bugs.webkit.org/show_bug.cgi?id=155601 Reviewed by Simon Fraser. * WebEditingTester/AppDelegate.m: (-[WebEditingAppDelegate showOperations:]): (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]): 2016-03-17 Tim Horton Find-in-page indicator in Mail viewer is the wrong scale and cut off https://bugs.webkit.org/show_bug.cgi?id=155605 Reviewed by Simon Fraser. * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: (TEST): Add a test that ensures that the find result image is correctly @2x. The NSImage size should be in points. 2016-03-16 Commit Queue Unreviewed, rolling out r198187. https://bugs.webkit.org/show_bug.cgi?id=155564 Potentially break testing on iOS (Requested by Guest23 on #webkit). Reverted changeset: "Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled." https://bugs.webkit.org/show_bug.cgi?id=154667 http://trac.webkit.org/changeset/198187 2016-03-16 David Kilzer check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI Reviewed by Darin Adler. * Scripts/webkitpy/style/checker.py: (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks on TestWebKitAPI since this project uses a config.h header as of r95188. Also remove references to WebKitAPITest, which ceased to exist in r95944. * Scripts/webkitpy/style/checker_unittest.py: (GlobalVariablesTest.test_path_rules_specifier): Add tests. Remove reference to WebKitAPITest project. 2016-03-16 Tim Horton [mac] Printing test snapshots are upside-down after r198242 https://bugs.webkit.org/show_bug.cgi?id=155543 Reviewed by Simon Fraser. * DumpRenderTree/mac/PixelDumpSupportMac.mm: (createPagedBitmapContext): Flip printing snapshots in DRT so that everything is right-side-up. 2016-03-16 Alexey Proskuryakov Update unit test for iOS debug queues. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: 2016-03-16 Jiewen Tan URL Parsing should signal failure for illegal IDN https://bugs.webkit.org/show_bug.cgi?id=154945 Reviewed by Brent Fulgham. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetch:]): * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: (TestWebKitAPI::TEST): 2016-03-15 Tim Horton [iOS Simulator] Test result snapshots are upside down https://bugs.webkit.org/show_bug.cgi?id=154761 Reviewed by Simon Fraser. * WebKitTestRunner/cg/TestInvocationCG.cpp: (WTR::createCGContextFromImage): (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): In r97104, Simon added code to take WindowServer snapshots, which came in flipped, and added code to flip them back. At this point, WindowServer snapshots got flipped, and software snapshots did not. In r140067, Simon noticed that WindowServer ref test images were upside-down on Mac (not sure why this changed), so turned off the flipping code (but didn't delete it!). Now, WindowServer snapshots and software snapshots both are not flipped. In r190304, Carlos added an enum for the source of the snapshot ("WebView" for window server snapshots, and "WebContent" for software snapshots), and - critically - changed the flipping logic to flip software snapshots! We didn't notice this on Mac because at this point we've made it so that we *always* have WindowServer snapshots, but on iOS we still don't have WindowServer snapshots, so now they're flipped. And that's how we got here. To restore the behavior from r140067, and correctly unflip snapshots on iOS, just delete this code. 2016-03-15 Alexey Proskuryakov run-api-tests doesn't print test name when the test crashes https://bugs.webkit.org/show_bug.cgi?id=155476 Reviewed by Daniel Bates. * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output doesn't contain the test name yet. Changed test name output to always be before raw stdout for clarity. 2016-03-15 Chris Dumez Unreviewed, rolling out r198203. Favorites view is no longer loading on iOS Reverted changeset: "URL Parsing should signal failure for illegal IDN" https://bugs.webkit.org/show_bug.cgi?id=154945 http://trac.webkit.org/changeset/198203 2016-03-15 Jiewen Tan URL Parsing should signal failure for illegal IDN https://bugs.webkit.org/show_bug.cgi?id=154945 Reviewed by Brent Fulgham. * MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController fetch:]): * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: (TestWebKitAPI::TEST): 2016-03-14 Chris Dumez Unreviewed, rolling out r197981. Caused a massive PLT regression on Mac. Reverted changeset: "Font antialiasing (smoothing) changes when elements are rendered into compositing layers" https://bugs.webkit.org/show_bug.cgi?id=23364 http://trac.webkit.org/changeset/197981 2016-03-14 Dewei Zhu Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled. https://bugs.webkit.org/show_bug.cgi?id=154667 Reviewed by Ryosuke Niwa and Simon Fraser. Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled. Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'. * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: (ServerControl.render_POST): Deleted. * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook.find_module): (AutoinstallImportHook._install_twisted_15_5_0): * Scripts/webkitpy/thirdparty/__init___unittest.py: (ThirdpartyTest.test_imports): 2016-03-14 Mark Lam Need to distinguish between Symbol() and Symbol(""). https://bugs.webkit.org/show_bug.cgi?id=155438 Reviewed by Saam Barati. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): - Test that the a symbol with an empty string is not equivalent to a null symbol. 2016-03-14 David Kilzer Remove blank lines after #include "config.h" Follow-up fix from review comments on Bug 155394. * TestWebKitAPI/PlatformUtilities.cpp: * TestWebKitAPI/Tests/WTF/RefLogger.cpp: 2016-03-14 Frederic Wang Unreviewed: Add my professional email address. * Scripts/webkitpy/common/config/contributors.json: 2016-03-14 Youenn Fablet Web platform test server should not try to launch servers on already bound sockets https://bugs.webkit.org/show_bug.cgi?id=141157 Reviewed by Darin Adler. * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json. (base_url): Refactored to use wpt_config_json routine. (WebPlatformTestServer.__init__): Fill port mappings according WPT config. 2016-03-13 Joseph Pecoraro Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards https://bugs.webkit.org/show_bug.cgi?id=155417 Reviewed by Yusuke Suzuki. * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 2016-03-13 Dean Jackson DRT should enable WebGL by default on Mac https://bugs.webkit.org/show_bug.cgi?id=155419 Reviewed by Sam Weinig. For some reason, lost in time, WebGL was enabled by default on trunk, but disabled by default in DumpRenderTree when using WebKit 1. This was very annoying, because each test had an explicit command to enable it. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Deleted WebGL line. 2016-03-13 Konstantin Tokarev Added new port JSCOnly. https://bugs.webkit.org/show_bug.cgi?id=154512 Reviewed by Michael Catanzaro. This port allows to build JavaScriptCore engine with minimal dependencies. * Scripts/build-jsc: * Scripts/webkitdirs.pm: (argumentsForConfiguration): (executableProductDir): (determinePortName): (isJSCOnly): (wrapperPrefixIfNeeded): (generateBuildSystemFromCMakeProject): (buildCMakeGeneratedProject): 2016-03-13 David Kilzer TestWebKitAPI: fix linker warnings Reviewed by Darin Adler. * TestWebKitAPI/CMakeLists.txt: - Add RefLogger.cpp source file. - Add other missing cross-platform source files. - Add FIXMEs about RunLoop.cpp and about missing platform-specific source files. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: - Add RefLogger.cpp source file. * TestWebKitAPI/Counters.cpp: (DeleterCounter::deleterCount): Move specific declaration here to fix linker warning. * TestWebKitAPI/Counters.h: (DeleterCounter::deleterCount): Remove declaration of global template variable. * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added. (TestWebKitAPI::log): Added. Move inline definition in RefLogger.h to here to fix linker warning. * TestWebKitAPI/Tests/WTF/RefLogger.h: (TestWebKitAPI::log): Replace inline function with declaration. 2016-03-12 David Kilzer REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to "Test.h" to fix incorrect case. This was discovered when adding WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394. 2016-03-12 David Kilzer run-webkit-tests: handle Darwin framework/library environment variables more consistently Reviewed by Daniel Bates. These changes will make it possible to pass through environment variables from the run-webkit-tests command-line. * Scripts/webkitpy/port/base.py: (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH, __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the list of variables to keep from the run-webkit-test environment. * Scripts/webkitpy/port/driver.py: (Driver._append_environment_variable_path): Add method to append a path to an environment variable, or set the path if the variable doesn't exist. (Driver._setup_environ_for_driver): Extract build_root_path into a local variable. Use Driver._append_environment_variable_path to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH, DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of overwriting them. * Scripts/webkitpy/port/driver_unittest.py: (DriverTest.test__append_environment_variable_path): Add test method to test Driver._append_environment_variable_path. 2016-03-11 Alexey Proskuryakov [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out https://bugs.webkit.org/show_bug.cgi?id=155276 [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out https://bugs.webkit.org/show_bug.cgi?id=155345 [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll https://bugs.webkit.org/show_bug.cgi?id=153997 TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty Rubber-stamped by Filip Pizlo. * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout. * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on iOS again. 2016-03-11 Jer Noble [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting https://bugs.webkit.org/show_bug.cgi?id=155365 Reviewed by Darin Adler. Allow tests running on iOS simulator to play video inline, avoiding this assert. * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: (RequiresUserActionForPlaybackTest::SetUp): 2016-03-11 Frederic Wang [jhbuild] Disable LLVM OCaml bindings. https://bugs.webkit.org/show_bug.cgi?id=153274 Reviewed by Michael Catanzaro. * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM. 2016-03-11 Commit Queue Unreviewed, rolling out r197495. https://bugs.webkit.org/show_bug.cgi?id=155369 LLVM is needed to run update-webkitgtk-libs reliably (Requested by mcatanzaro on #webkit). Reverted changeset: "[jhbuild] Remove LLVM dependency." https://bugs.webkit.org/show_bug.cgi?id=153274 http://trac.webkit.org/changeset/197495 2016-03-11 Youenn Fablet WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings https://bugs.webkit.org/show_bug.cgi?id=153419 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringOperators.cpp: (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase. 2016-03-10 Simon Fraser Font antialiasing (smoothing) changes when elements are rendered into compositing layers https://bugs.webkit.org/show_bug.cgi?id=23364 Reviewed by Tim Horton. Turn off smoothed layer text because it affects many layout test results. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): 2016-03-10 Jer Noble Partial roll-out of r197953; test fails because encode/decode support of those properties were never added. * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (TEST): Deleted. 2016-03-10 Myles C. Maxfield [OS X] Main frame scrollbars should appear on the left on RTL systems https://bugs.webkit.org/show_bug.cgi?id=155149 Reviewed by Simon Fraser. Setting the volatile default needs to be done early, so it is plumbed through the injected bundle's initialization routine. Control of RTL scrollbars is handled by putting the string on the first line of a test. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::shouldUseRTLScrollbars): (WTR::InjectedBundle::platformInitialize): * WebKitTestRunner/TestController.cpp: (WTR::TestController::generatePageConfiguration): (WTR::updateTestOptionsFromTestHeader): (WTR::TestController::getInjectedBundleInitializationUserData): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::viewSupportsOptions): 2016-03-08 Jer Noble Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally https://bugs.webkit.org/show_bug.cgi?id=155141 Reviewed by Beth Dakin. Set the default values for media preferences unconditionally, not just on PLATFORM(IOS). Set "video requires user gesture" to sane defaults in addition to "audio requires user gesture" and (in the case of DumpREnderTree) instead of "media requires user gesture". Add a new test of WK2 user gesture requirement preferences. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Added. (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): (-[RequiresUserActionForPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): (RequiresUserActionForPlaybackTest::SetUp): (RequiresUserActionForPlaybackTest::createWebView): (RequiresUserActionForPlaybackTest::testVideoWithAudio): (RequiresUserActionForPlaybackTest::testVideoWithoutAudio): (RequiresUserActionForPlaybackTest::testAudioOnly): (TEST_F): * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: (TEST): 2016-03-10 Brian Burg Web Inspector: should be able to run protocol and input generator scripts from any directory https://bugs.webkit.org/show_bug.cgi?id=155307 Reviewed by Joseph Pecoraro. * Scripts/webkitpy/inspector/main.py: (InspectorGeneratorTests.main): * Scripts/webkitpy/replay/main.py: (InputGeneratorTests.main): Compute the current SCM based on the location of the script being executed, not the $CWD which could be anything. There's rarely a good reason to use $CWD. 2016-03-10 David Kilzer [iOS] DumpRenderTree crashes when accessing window.testRunner.inspectorTestStubURL Reviewed by Brent Fulgham. * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::inspectorTestStubURL): Always return nullptr for PLATFORM(IOS). This matches what we did in r192604 for WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm. 2016-03-10 Frederic Wang [GTK] Add support for WOFF2 https://bugs.webkit.org/show_bug.cgi?id=152616 Reviewed by Carlos Garcia Campos. * Scripts/webkitpy/style/checker.py: Only verify basic style for third party modules brotli and woff2. 2016-03-09 Ryosuke Niwa Add runtime flags for shadow DOM and custom elements https://bugs.webkit.org/show_bug.cgi?id=155213 Reviewed by Dean Jackson. Always enable shadow DOM and custom elements during testing. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setShadowDOMEnabled): Added. * WebKitTestRunner/InjectedBundle/TestRunner.h: 2016-03-09 Brent Fulgham Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage https://bugs.webkit.org/show_bug.cgi?id=155265 Reviewed by Andy Estes. WK2 localStorage tests need the 'AllowUniversalAccessFromFileURLs' preference set by default. Tests that confirm blocking localStorage manually set the flag to "False" in the test. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::initializeWebViewConfiguration): Set the default state to the correct value. 2016-03-09 David Kilzer check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files Reviewed by Andy Estes. * Scripts/webkitpy/style/checkers/cpp.py: (check_spacing_for_function_call): Ignore @catch lines. (check_braces): Ditto. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_brace_at_begin_of_line): Add test case. 2016-03-09 Jason Marcell Removing reference to Dashboard.Repository.Internal.trac from open source unit tests. https://bugs.webkit.org/show_bug.cgi?id=155274 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: (setup): Deleted. In bug 154180 we removed Dashboard.Repository.Internal which was causing an error in the unit tests. 2016-03-09 Aakash Jain use ulimit command to check process limit in webkitpy https://bugs.webkit.org/show_bug.cgi?id=155260 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_child_processes): Use ulimit command output instead of launchctl limit maxproc command. 2016-03-09 Alexey Proskuryakov Stop building armv7 on iOS device builders https://bugs.webkit.org/show_bug.cgi?id=155246 Reviewed by David Kilzer. * BuildSlaveSupport/build.webkit.org-config/config.json: Building both armv7 and armv7s makes the bots unnecessarily slow. We can catch super rare v7-only regressions elsewhere. * Scripts/webkitpy/common/config/ews.json: Changed EWS to match, as we always want EWS configuration to be verified by buildbot queues. * Scripts/webkitdirs.pm: * Scripts/webkitpy/port/ios.py: Changed default to arm64. I think that the default is probably not used in any practical scenarios, but it's nice to make it more sensible. 2016-03-09 Alexey Proskuryakov Add iOS Simulator EWS to bot watcher's dashboard https://bugs.webkit.org/show_bug.cgi?id=155220 Reviewed by Lucas Forschler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: 2016-03-09 Brent Fulgham Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked https://bugs.webkit.org/show_bug.cgi?id=155185 Reviewed by Anders Carlsson. * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: (TestWebKitAPI::TEST): Allow local file accesss to run test. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: (TEST): Ditto. * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: (TEST): Ditto. 2016-03-09 Tim Horton Removing and re-adding a script message handler with the same name results in an unusable message handler https://bugs.webkit.org/show_bug.cgi?id=155223 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: (TEST): Add a test ensuring that it is possible to remove and re-add a script message handler with the same name and still dispatch messages to it. 2016-03-08 Alexey Proskuryakov Fix iOS Simulator EWS. Unreviewed build fix. * Scripts/webkitpy/common/config/ports.py: 2016-03-08 Aakash Jain Booting multiple iOS simulator parallely fails sometimes https://bugs.webkit.org/show_bug.cgi?id=155208 Reviewed by Darin Adler. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent simulator boot. 2016-03-08 Alexey Proskuryakov Add iOS debug testers to flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=155206 Reviewed by Darin Adler. * TestResultServer/static-dashboards/builders.jsonp: 2016-03-08 Oliver Hunt Start moving to separated writable and executable mappings in the JIT https://bugs.webkit.org/show_bug.cgi?id=155178 Reviewed by Fil Pizlo. Making run-jsc-benchmarks slightly happier on my machine. * Scripts/run-jsc-benchmarks: 2016-03-08 Anders Carlsson Use NSUInteger instead of NSWindowStyleMask. * MiniBrowser/mac/MiniBrowser_Prefix.pch: 2016-03-08 Anders Carlsson Fix build. We intentionally don't use AppKitCompatibilityDeclarations.h here, since we want MiniBrowser to build without WTF. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]): * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): * MiniBrowser/mac/MiniBrowser_Prefix.pch: 2016-03-08 Alexey Proskuryakov Add iOS simulator EWS that runs tests https://bugs.webkit.org/show_bug.cgi?id=155175 Reviewed by Lucas Forschler. * QueueStatusServer/config/queues.py: * Scripts/webkitpy/common/config/ews.json: * Scripts/webkitpy/common/config/ports.py: 2016-03-08 Commit Queue Unreviewed, rolling out r197793 and r197799. https://bugs.webkit.org/show_bug.cgi?id=155195 something weird happened while landing this and everything broke (Requested by olliej on #webkit). Reverted changesets: "Start moving to separated writable and executable mappings in the JIT" https://bugs.webkit.org/show_bug.cgi?id=155178 http://trac.webkit.org/changeset/197793 "arm64 build fix after r197793." http://trac.webkit.org/changeset/197799 2016-03-08 Oliver Hunt Start moving to separated writable and executable mappings in the JIT https://bugs.webkit.org/show_bug.cgi?id=155178 Reviewed by Filip Pizlo. Making run-jsc-benchmarks slightly happier on my machine. * Scripts/run-jsc-benchmarks: 2016-03-08 Daniel Bates Support iterating over an OptionSet and checking if it is empty https://bugs.webkit.org/show_bug.cgi?id=154941 Reviewed by Darin Adler. Add tests to ensure that we do not regression both iteration of an OptionSet and determining whether an OptionSet is empty. * TestWebKitAPI/Test.h: (TestWebKitAPI::Util::assertStrongEnum): Helper function to assert two strong enum type for equality. * TestWebKitAPI/Tests/WTF/OptionSet.cpp: (TestWebKitAPI::TEST): 2016-03-08 Alexey Proskuryakov Add debug iOS Simulator bots to the dashboard https://bugs.webkit.org/show_bug.cgi?id=155157 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: 2016-03-08 Alejandro G. Castro Unreviewed EFL build fix after r197752. * Scripts/webkitperl/FeatureList.pm: Avoid MEDIA_STREAM compilation by default until EFL bumps gstreamer to 1.6. 2016-03-08 Alejandro G. Castro [GTK] [EFL] Avoid running mediastream tests by default until we compile by default https://bugs.webkit.org/show_bug.cgi?id=153540 Reviewed by Philippe Normand. After bumping gstreamer to 1.6.3 in r196804 we can enable again compilation of mediastream and running the tests. * Scripts/run-gtk-tests: (TestRunner): Enable again the UserMedia API test. * Scripts/webkitperl/FeatureList.pm: Enable the compilation of the mediastream by default. * gtk/jhbuild-webrtc.modules: Removed the specific jhbuild modules file. * gtk/jhbuild.modules: Bumped the openwebrtc version to the one we are currently using. 2016-03-07 Jon Lee Update perf bot configuration for Animometer https://bugs.webkit.org/show_bug.cgi?id=155134 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Refactor the patch to work with the latest version of the harness. * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Bump up the timeout, and use the latest version of the harness. 2016-03-07 Joanmarie Diggs [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0 https://bugs.webkit.org/show_bug.cgi?id=154839 Reviewed by Michael Catanzaro. Add '-Wno-error' to jhbuildrc; remove it from the module sets for macos. * gtk/jhbuild-webrtc.modules: * gtk/jhbuild.modules: * gtk/jhbuildrc: 2016-03-07 Aakash Jain webkitpy should verify timestamp from CrashLogs while collecting all crash logs https://bugs.webkit.org/show_bug.cgi?id=155000 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/system/crashlogs.py: (CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected time range, because file modification time is not always accurate. (CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs. * Scripts/webkitpy/common/system/crashlogs_unittest.py: (CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function. 2016-03-06 Alexey Proskuryakov build-webkit prints an error on iOS simulator bots https://bugs.webkit.org/show_bug.cgi?id=155078 Reviewed by Dan Bernstein. This happens when build-layouttestrelay sets $xcodeSDK to undefined, to use host SDK. * Scripts/webkitdirs.pm: (buildXCodeProject): There is no need to pass -sdk, because XcodeOptions() already passes SDKROOT as appropriate. * Scripts/build-layouttestrelay: Added a FIXME. Resetting $xcodeSDK doesn't reset any other configuration variables that were derived from its initial value, like $portName. 2016-03-05 Tim Horton Create a DOMHTMLVideoElement when wrapping