=== WebKit-521.12 === 2006-05-26 David Harrison Reviewed by John Sullivan. Add a list type parameter and a return value to _increaseSelectionListLevel * WebView/WebHTMLView.m: (-[WebHTMLView _increaseSelectionListLevel]): - Now returns DOMNode* (-[WebHTMLView _increaseSelectionListLevelOrdered]): (-[WebHTMLView _increaseSelectionListLevelUnordered]): - Added. These also return DOMNode* * WebView/WebHTMLViewPrivate.h: - Updated as above 2006-05-25 Tim Omernick Reviewed by Anders. REGRESSION: Flash movie audible but not visible until window is resized * Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView dataSourceUpdated:]): Layout if needed here. Maciej recently removed the "LayoutAcceptable" frame state, which used to cause plugin document views to lay out immediately upon receiving data. This call to -layout has the same effect. === WebKit-521.11.1 === 2006-05-25 Timothy Hatcher Reviewed by Tim O. WebKit fails to compile for ppc64 64-bit: WebKit uses FSSpec which is not available in 64-bit Gets WebKit building under 64-bit. Rename WebNSInt and WebNSUInt to WebNSInteger and WebNSUInteger. Start using WebNSInteger where we need to match AppKit API usage of NSInteger. HIWebView and a couple of helper functions are disabled until they can be moved off of QuickDraw. HIWebView needs to be reworked to not use QuickDraw, needed for 64-bit * Carbon/CarbonUtils.m: disabled this file in 64-bit * Carbon/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): * Carbon/CarbonWindowFrame.m: (+[CarbonWindowFrame frameRectForContentRect:styleMask:]): (+[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (+[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): (-[CarbonWindowFrame frameRectForContentRect:styleMask:]): (-[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (-[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): * Carbon/HIViewAdapter.m: disabled this file in 64-bit * Carbon/HIWebView.m: disabled this file in 64-bit (HIWebViewEventHandler): * DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]): * History/WebBackForwardList.m: (-[WebBackForwardList removeItem:]): (-[WebBackForwardList goToItem:]): * Misc/WebDownload.m: (-[WebDownloadInternal download:didReceiveDataOfLength:]): * Misc/WebFileDatabase.m: (UniqueFilePathForKey): * Misc/WebIconDatabase.m: (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _totalRetainCountForIconURLString:]): (-[WebIconDatabase _retainIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]): * Misc/WebSearchableTextView.m: (-[NSString selectionRect]): * Misc/WebTypesInternal.h: Added. * Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream _destroyStream]): (CarbonPathFromPOSIXPath): * Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (TSMEventHandler): (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]): (-[NSData _web_locationAfterFirstBlankLine]): * Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage hash]): * Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (functionPointerForTVector): * WebInspector/WebInspector.m: (-[WebInspector _updateSystemColors]): * WebKit.xcodeproj/project.pbxproj: * WebView/WebDataSource.m: (-[WebDataSource _didReceiveData:contentLength:forResource:]): * WebView/WebFrame.m: (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): * WebView/WebHTMLView.m: (-[NSArray drawRect:]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView conversationIdentifier]): * WebView/WebResourceLoadDelegate.h: * WebView/WebUIDelegate.h: * WebView/WebView.h: * WebView/WebView.m: (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView spellCheckerDocumentTag]): * WebView/WebViewInternal.h: * WebView/WebViewPrivate.h: === WebKit-521.11 === 2006-05-23 Maciej Stachowiak Reviewed by Tim. - more loader refactoring to simplify things and remove knowledge of WebView from WebSubresourceLoader * WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): (-[WebSubresourceLoader didReceiveResponse:]): * WebView/WebDataSource.m: (-[WebDataSource _loadIcon]): (-[WebDataSource _startLoading]): * WebView/WebFrame.m: (-[WebFrame _loadRequest:archive:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): * WebView/WebFrameInternal.h: * WebView/WebFramePrivate.h: * WebView/WebLoader.h: * WebView/WebLoader.m: * WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader initWithDataSource:]): (-[WebMainResourceLoader didReceiveResponse:]): 2006-05-23 Tim Omernick Reviewed by John Sullivan. REGRESSION (420+): After clearing history and closing bookmark view window, attempting to select Safari's menu bar results in a crash * Misc/WebNSWindowExtras.m: (replacementPostWindowNeedsDisplay): My fix yesterday for 4557117 was not quite good enough. Now that we cancel the display timer for a window *before* it deallocates, we need to make sure that while a window deallocates, no new display timers are scheduled for that window. This is actually possible, as 4558301 demonstrates. Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag and bail out of the throttle hack if it is set. This should fix the last of the crashes involving display timers scheduled for deallocated or deallocating windows. 2006-05-23 Maciej Stachowiak Reviewed by Eric. - remove knowledge of WebView from WebLoader in preparation for moving the code down * WebView/WebDataSource.m: (-[WebDataSource _defersCallbacks]): (-[WebDataSource _identifierForInitialRequest:]): (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]): (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource _didReceiveData:contentLength:forResource:]): (-[WebDataSource _didFinishLoadingForResource:]): (-[WebDataSource _didFailLoadingWithError:forResource:]): (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]): (-[WebDataSource _privateBrowsingEnabled]): * WebView/WebDataSourceInternal.h: * WebView/WebLoader.h: * WebView/WebLoader.m: (-[WebLoader releaseResources]): (-[WebLoader setDataSource:]): (-[WebLoader willSendRequest:redirectResponse:]): (-[WebLoader didReceiveAuthenticationChallenge:]): (-[WebLoader didCancelAuthenticationChallenge:]): (-[WebLoader didReceiveResponse:]): (-[WebLoader didReceiveData:lengthReceived:]): (-[WebLoader signalFinish]): (-[WebLoader didFinishLoading]): (-[WebLoader didFailWithError:]): (-[WebLoader willCacheResponse:]): (-[WebLoader cancelWithError:]): * WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]): * WebView/WebView.m: (-[WebView _incrementProgressForIdentifier:response:]): (-[WebView _incrementProgressForIdentifier:data:]): (-[WebView _completeProgressForIdentifier:]): * WebView/WebViewInternal.h: === WebKit-521.10 === 2006-05-22 Tim Omernick Reviewed by Geoff. TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when opening file from file open dialog Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's machine. * Misc/WebNSWindowExtras.m: (replacementDealloc): Cancel display timer before dealloc, not after. Cancelling the timer can cause a message to be sent to the window; best to do that before the window deallocates. (replacementFinalize): ditto 2006-05-20 Maciej Stachowiak Reviewed by Beth. - fix assertion failure on layout tests * WebView/WebDataSource.m: (-[WebDataSource _mainReceivedError:complete:]): Don't do anything if this data source is no longer connected to a frame. Used to be this couldn't happen because the WebView would have been nil, but we no longer go through the WebView. 2006-05-20 Timothy Hatcher Reviewed by Anders. Bug 9018: REGRESSION: resizing the top area of the inspector does not grow as expected http://bugzilla.opendarwin.org/show_bug.cgi?id=9018 Use clientHeight now that offsetHeight includes the border and padding. clientHeight should have been used initially. * WebInspector/WebInspector.m: (-[WebInspector resizeTopArea]): 2006-05-18 Maciej Stachowiak Reviewed by Eric. - remove loading-related code from WebView http://bugzilla.opendarwin.org/show_bug.cgi?id=8981 * Plugins/WebNetscapePluginStream.m: (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): * WebCoreSupport/WebSubresourceLoader.m: (-[WebSubresourceLoader receivedError:]): (-[WebSubresourceLoader signalFinish]): * WebView/WebDataSource.m: (-[WebDataSource _stopLoading]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _finishedLoadingResource]): (-[WebDataSource _mainReceivedBytesSoFar:complete:]): (-[WebDataSource _receivedError:]): (-[WebDataSource _mainReceivedError:complete:]): * WebView/WebDataSourceInternal.h: * WebView/WebFrame.m: (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): * WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader didReceiveData:lengthReceived:]): (-[WebMainResourceLoader didFinishLoading]): * WebView/WebView.m: * WebView/WebViewInternal.h: 2006-05-18 Tim Omernick Reviewed by John Sullivan. More options needed for window display throttle We decided to play it safe and leave our window flushing behavior unchanged from the previous public release. By default, CoreGraphics deferred updates are once again OFF, and the window display throttle is OFF. Individual applications should set the WebKitThrottleWindowDisplayPreferenceKey and WebKitEnableDeferredUpdatesPreferenceKey defaults to suit their needs. Old behavior (like 10.4.6): WebKitThrottleWindowDisplayPreferenceKey=0 (or unset), WebKitEnableDeferredUpdatesPreferenceKey (or unset). Tear-free scrolling/animations: WebKitThrottleWindowDisplayPreferenceKey=0 (or unset), WebKitEnableDeferredUpdatesPreferenceKey=1. While this configuration fixes the tearing issues caused by over-flushing, some applications will experience performance problems as over-flushing with CG deferred updates enabled will cause the app to block. Tear-free scrolling/animations, high performance: WebKitThrottleWindowDisplayPreferenceKey=1, WebKitEnableDeferredUpdatesPreferenceKey=1. This is the riskiest configuration in that it enables the window display throttle "feature", potentially breaking applications' assumptions about when displays occur. However, it provides the "best of both worlds", in that updates are tear-free, and performance impact should me minimal. * WebView/WebPreferenceKeysPrivate.h: Declared WebKitThrottleWindowDisplayPreferenceKey and WebKitEnableDeferredUpdatesPreferenceKey. * WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Turn off CG deferred updates if WebKitEnableDeferredUpdatesPreferenceKey is NO or has no value. Added some comments. 2006-05-18 John Sullivan Reviewed by Darin Adler. - fixed REGRESSION: WebFrameView no longer responds to responder methods sent by Safari code * WebView/WebView.m: (-[WebView _responderForResponderOperations]): Treat sibling views of the main frameView the same as views outside of the webview for the purposes of this mechanism. 2006-05-18 Tim Omernick Reviewed by John Sullivan. Make disabling window throttle safer * Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Don't assume that +_webkit_disableWindowDisplayThrottle restored the NSWindow method implementations; now we'll only swizzle them once, and our replacement IMPs will call the old IMPs when the window throttle is disabled. This is a safer approach when other components/"haxies" override the same methods that we are overriding, as it allows the overrides to "chain" properly. Moved the dictionary initialization code down a bit. The order doesn't matter here. (disableWindowDisplayThrottleApplierFunction): Noticed that this could have been written safer with respect to the timer having the last reference to the window. I never experienced a crash here, but this code is definitely safer. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Don't restore NSWindow method implementations; just clear the flag, flush pending displays, and destroy the dictionary. (replacementPostWindowNeedsDisplay): If throttling is disabled, just call the original IMP. (clearWindowDisplayInfo): Added an assert. (replacementDealloc): Don't call clearWindowDisplayInfo() when throttling is disabled. (replacementFinalize): ditto (cancelPendingWindowDisplay): Removed an unnecessary assertion. 2006-05-17 Tim Omernick Reviewed by Kevin Decker and John Sullivan. REGRESSION: Window throttle code can sometimes leak NSWindows The window display throttle depended on windows being closed before they were deallocated; this is not guaranteed by AppKit. Windows that were being released without being closed were getting stuck in our NSWindow -> WindowDisplayInfo dictionary. * Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Don't retain the NSWindow keys in the window display info dictionary. Instead of overriding -close, override -dealloc and -finalize so that we can remove the NSWindow -> WindowDisplayInfo mapping when a window deallocates. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Restore -dealloc and -finalize. (clearWindowDisplayInfo): Factored the WindowDisplayInfo cleanup code out of the now-defunct replacementClose(). (replacementClose): Removed; no longer needed. (replacementDealloc): Clear the WindowDisplayInfo for the window after deallocation. (replacementFinalize): ditto (-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]): Rewrote this method to be safe in the case where the firing display timer has the last reference to the window. Added comments. 2006-05-17 bradeeoh Reviewed by Tim Hatcher Consolidated WebDatabase base class into WebFileDatabase as the inheritance relationship became obsolete. This improves readability and sets the stage for a further in-depth rewrite of the WebIcon* code. * Misc/WebDatabase.h: Removed. * Misc/WebDatabase.m: Removed. * Misc/WebFileDatabase.h: * Misc/WebFileDatabase.m: (-[WebFileDatabaseOp dealloc]): (-[WebFileDatabase dealloc]): (-[WebFileDatabase path]): (-[WebFileDatabase isOpen]): (-[WebFileDatabase sizeLimit]): * WebKit.xcodeproj/project.pbxproj: 2006-05-17 Adele Peterson Reviewed by Hyatt. WebKit part of initial checkin to prepare for http://bugzilla.opendarwin.org/show_bug.cgi?id=8948 Switch to use new text field implementation for